| === npmccallum [~npmccallu@69-162-252-7.ironoh.adelphia.net] has joined #launchpad | ||
| === ddaa [~david@nemesis.xlii.org] has joined #launchpad | ||
| === npmccallum [~npmccallu@69-162-252-7.ironoh.adelphia.net] has joined #launchpad | ||
| === stub [~zen@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad | ||
| === stub [~zen@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad | ||
| === carlos [~carlos@69.Red-80-33-181.pooles.rima-tde.net] has joined #launchpad | ||
| === stubish [~zen@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad | ||
| === carlos [~carlos@69.Red-80-33-181.pooles.rima-tde.net] has joined #launchpad | ||
| === spiv [~andrew@fuchsia.puzzling.org] has joined #launchpad | ||
| === cprov [~cprov@200.158.100.251] has joined #launchpad | ||
| === elmo_ [~james@host217-37-231-28.in-addr.btopenworld.com] has joined #launchpad | ||
| carlos | daf: ping | 11:25 |
|---|---|---|
| daf | pong! | 11:26 |
| carlos | daf: :-P | 11:26 |
| carlos | I think we are ready to launch the alpha | 11:26 |
| carlos | :-D | 11:26 |
| carlos | do you want to set up it so tomorrow we could launch it? | 11:26 |
| daf | I'm not 100% confident in that patch | 11:26 |
| carlos | daf: I tested it | 11:27 |
| carlos | and works | 11:27 |
| carlos | we could refactor the code later | 11:27 |
| carlos | daf: what problem do you think it has? | 11:27 |
| daf | well, refactoring is about changing the code without changing what it does | 11:27 |
| daf | this is about changing what it does | 11:28 |
| daf | I'm worried about setting inLastRevision to True by default | 11:28 |
| daf | as it affects TTW translations | 11:28 |
| carlos | daf: it is only changed into the msgid | 11:28 |
| carlos | not the msgstr ones | 11:29 |
| daf | I think it would be better to add an extra parameter to the method | 11:29 |
| carlos | a msgid for the first string should always have it | 11:29 |
| carlos | daf: a msgset with a sequence= 0 will say that the msgset is not anymore in the .po/.pot file | 11:30 |
| carlos | daf: don't get confused by the "inLastRevision" vs. "inPoFile" | 11:31 |
| daf | remind me what the difference is | 11:31 |
| === daf is doing some Debian work right now | ||
| carlos | daf: do you want to wait until tomorrow to talk about it? | 11:32 |
| daf | well, I'm happy to talk about it now | 11:32 |
| daf | but I might not do any more work on it tonight | 11:33 |
| daf | I'm feeling quite tired | 11:33 |
| carlos | ok | 11:33 |
| daf | I spent the weekend looking at castles with spiv and Mary :) | 11:33 |
| carlos | daf: good job!!, we need to relax from time to time or we will get mad :-) | 11:34 |
| daf | :) | 11:34 |
| daf | yeah, it was nice to get away from Rosetta for a while | 11:35 |
| carlos | I was watching tv until this afternoon | 11:35 |
| carlos | and doing nothing related to computers :-P | 11:35 |
| carlos | ok, about the inLastRevision vs. inPofile... | 11:36 |
| carlos | we know that a msgid is unique and will be never changed over time for a given msgset | 11:36 |
| daf | agreed | 11:36 |
| carlos | if a msgset is removed from a po file (when I say po it's po/pot) | 11:37 |
| carlos | the sequence is changed to 0 | 11:37 |
| carlos | so we know that pomsgset is not valid anymore | 11:37 |
| carlos | until we see it again | 11:37 |
| daf | yep | 11:37 |
| carlos | so the inLastRevision does not say anything about if that msgid is or not at the po file | 11:38 |
| carlos | but if it was the last one seen for that msgset | 11:38 |
| carlos | so the case for a msgid, it will be always true because it will not be changed ever | 11:38 |
| daf | ok, so the name is misleading? | 11:38 |
| carlos | no, because the msgid_plural could change | 11:39 |
| carlos | but yes, perhaps the name could be improved | 11:39 |
| daf | hmm, ok | 11:41 |
| daf | that makes me happier about the patch | 11:41 |
| daf | did you merge it? | 11:41 |
| carlos | I don't remember it. I think so | 11:42 |
| === daf checks | ||
| carlos | yes it's merged | 11:43 |
| daf | egads pbuilder is slow | 11:43 |
| daf | looks like PQM is still a little wedged | 11:44 |
| carlos | daf: I found a bug because lalo's comment | 11:44 |
| daf | yeah, I just saw it | 11:45 |
| daf | if you agree with him, can you make the change and merge it? | 11:45 |
| daf | I'm still a bit confused | 11:46 |
| carlos | sure | 11:46 |
| carlos | I'm looking at it now | 11:46 |
| carlos | grr, it's not a trivial fix | 12:00 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!