=== BradB [~bradb@george.kkhotels.co.uk] has joined #launchpad [01:25] stub: ping [01:25] stub: how painful are table renamings? [01:25] bugsystem -> bugtracker [01:25] projectbugsystem -> projectbugtracker === kiko [~kiko@200-206-134-238.async.com.br] has joined #launchpad === stub [~stub@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad === kiko cheers sabdfl on [02:09] sabdfl, do you have time for a code-related question? [02:09] kiko: just have to land the patch for the renaming I just accidentally mailed about :-) [02:09] pressed send before i had committed... doh [02:09] heh [02:10] 5 minutes ok?> [02:10] hopefully PQM will be merciful [02:10] sure. [02:23] sabdfl, my question pertains to the intended location of the application component interfaces [02:24] I understand the database class interfaces should live in lauchpad/interfaces/ [02:24] however what about application component classes and views? [02:28] kiko: some views are strongly bound to the domain object and generally useful [02:29] for example, tonight I just reused a method from the BugSystemSetView onto ProjectView to allow for the creation of a BugTracker on a Project as well as from scratch [02:29] the code was common so I took the View method, made it a freestanding function, then got both View's to call that [02:30] and it seems to make sense to have a place to keep view code that can be commonly used with the domain objects in some domain-oriented place rather than in the app itself [02:30] i just don't know exactly where yet [02:30] kiko: your suggestion? [02:31] I'm not sure yet, I wanted to hear your opinion on it now that you have your hands dirty [02:31] that's definitely true [02:32] in a new system we're architecting the domain classes are actually packages that have multiple modules in them -- you have product/ and then klass.py, queries.py, helpers.py, etc. [02:33] you could even have local views though I currently don't like that very much because it makes domain depend on interface classes [02:33] let's get a little dirtier for a while then figure out where to put it [02:33] should be less work that the last one :-) [02:33] yes, that's definitely the right way to do it [02:33] oh, you saw my timezone message then [02:35] having the domain classes be packages allows you to keep a lot of useful code bound together with it [02:35] the actual views and application components can then just pull stuff from them and compose the interface [02:35] sabdfl, this function you created, where did you put it? [02:35] in project.py? [02:36] no, in canonical.malone.browser [02:36] it's really a view function [02:36] and really related to bug trackers [02:37] so canonical.doap.browser.py just imported it from canonical.malone.browser.py [02:37] so it couldn't for instance be reused in a soyuz view of a project? [02:37] yes it could [02:37] somehow I don't like cross-package imports like that -- it seems like it should be moved somewhere "higher" [02:37] OTOH we don't have a place to peg this sort of common code right now [02:38] in our projects I solve that by providing a components/ package that has interface+domain glue that all applications can use [02:38] so there's a components/person/ that actually provides multiple views of person that any app can choose to use at any time [02:38] I figure we should have something like portlets/ at least [02:39] so that soyuz knows exactly where to look for portlets that display bug data, for instance [02:40] I wonder [02:40] does the code in your function actually depend on anything UI-related? [02:40] (if it's not big, perhaps privmsg it to me?) [02:46] kiko: it needs a form and an owner [02:46] so i just pass both as arguments [02:46] the view object calls newBugTracker(form, owner) [02:47] i could have done newBugTracker(request) which I guess would give you enough to work it all out in the function [02:47] I guess it's still pretty tied to UI code, though, if we're dealing with requests and forms [02:50] yes, it is, which is why i put it in browser [02:50] i guess we could have a canonical.launchpad.browser/ [02:50] which has a bunch of View's in it which are generally useful [02:51] and then the REAL app stuff could be in canonical.rosetta etc [02:51] but let's see how it goes [02:51] unless you see a pressing need to reorg that too :-) [02:53] I reckon we can wait till people think it's safe to go back to their little directories [02:53] The cross imports between canonical.doap.browser and canonical.malone.browser is leading towards ugly cross import problems. The component architecture should make this unnecessary. [02:53] and then hit them with a 10am-13pm UTC surprise [02:54] stub, do you have a good solution for storing view-specific code that is common between apps? [02:55] I'd have to see what doap.py is currently importing from malone and why... is that committed? [02:56] stub: should be now [02:56] morning === stub waits for its mirror to finish [03:00] In this case I guess to want to register the common functionality as a Utility [03:01] (assuming it is just a function in malone/browser.py you need to share) [03:03] how do I do a many to many join in sqlobject? [03:03] in other words I want to return Project.bugtrackers [03:03] where bugtrackers is the set of BugSystem obejcts as joined through the ProjectBugSystem table? [03:03] stub: yes it's just a function [03:04] stub: any idea on the ManyToMany join questioN? [03:06] Yer - I'm just looking it up. Haven't used it myself though. [03:06] lucille ? [03:06] lifeless: archive management stuff for james [03:06] http://www.sqlobject.org/docs/SQLObject.html#relatedjoin-many-to-many [03:07] Unfortunately I don't think you can use RelatedJoin until the SQLObject update has been done [03:08] stub: thanks [03:08] hmm... is the sqlobject NOT done? [03:08] lifeless: ?^? [03:08] hmm ? [03:09] https://bugzilla.warthogs.hbd.com/bugzilla/show_bug.cgi?id=2020 [03:10] ah, crossed wires. [03:11] I was waiting for a definative list of which local patches we wanted preserved. [03:11] the code import itself is done and in rocketfuel since the 28th. [03:12] SteveA: does sqlobject 0.6 have your feature to error on duplicate sqlobject class names ? [03:14] lifeless: No - we need to reapply that patch. BradB only put it in upstream a few days ago I think. [03:15] ok sqlobject--test--0.6 now has all our local changes [03:21] AttributeError: 'SORelatedJoin' object has no attribute 'otherClass' [03:21] anybody seen that before? [03:23] do we have the update-database without-losing-contents script yet ? [03:25] Bug 2020 resolved: Update our SQLObject snapshot to 0.6 release [03:25] https://bugzilla.warthogs.hbd.com/bugzilla/show_bug.cgi?id=2020 [03:29] stub: how hard is table renaming? [03:31] alter table foo rename to bar; [03:31] trivial [03:31] Fallout on the Python level is more what you would worry about, and grep will normally see to that. [03:33] stub: ok, please do the following,I'll clean up and commit working code: [03:33] bugsystem -> bugtracker [03:34] should there be a launchpad_unittest target in database/schema ? [03:34] projectbugsystem -> projectbugtracker [03:34] are fieldnames as easy? [03:34] ALTER TABLE SourcepackageBugAssignment ADD FOREIGN KEY (binarypackage) REFENRECES BinarypackageName <-- should this go in now too (patch is in my pending queue) [03:35] ok, trying to do this production update test, but the unit & functional tests are failing. [03:35] stub: i think we want to change the name of the field as well if we change it's target [03:35] binarypackagename [03:35] is that expected ? [03:35] otherwise it would be inconsistent [03:36] sabdfl: I agree - I was just trying to minimize changes since we have a deadline ;) [03:37] let's get them in now [03:37] while you're at it [03:37] eek. [03:37] can we rename projectbugtracker.bugsystem to projectbugtracker.bugtracker [03:38] I can only confirm stuff isn't broken at the revision I'm merged to... [03:38] stub: what's the sql to do the field renames? [03:38] lifeless: none of these tables are stuff you depend on [03:38] even indirectly [03:38] ALTER TABLE foo RENAME COLUMN bar TO baz; [03:38] ok. [03:39] then It'll be your problem :) [03:39] I'd like to have the unit & functional tests passing though.. is there any comment on the fact they are failing at all ? [03:39] alter table projectbugtracker rename column bugsystem to bugtracker; [03:39] this after the previous table renames [03:40] lifeless, brad shot off some emails on the issues this week [03:41] kiko: so make test is expected to fail ? Ok then. [03:41] err, rather, today. [03:41] sabdfl: Just testing the patch now before I commit that with the other pending changes [03:41] yes, it currently fails, though people are expected to fix that ASAP as we want to turn tests back on. [03:41] (in PQM, lifeless) [03:42] justdave: I suspect this will definitely break check-watches.py [03:42] kiko: yes, I was wondering about that :) [03:49] andrew was a bit unhappy about it [03:51] stub: yes it will, but I was expecting that :) [03:55] sabdfl: ok, the first thing that brakes is /soyuz/projects/view-a-project [03:55] * [03:55] AttributeError: 'Product' object has no attribute '_poTemplatesJoin' [03:55] lifeless: there's a much newer and better doap framework [03:55] and equally [03:56] doap/projects/iso-codes [03:56] with the same error [03:56] that works for for the project aaa. [03:56] garh. [03:57] database patches are with pqm [03:57] ok, importantly, the do-not-use-info-imports project fails [03:57] and thats the one I need access to. [03:57] * [03:57] AttributeError: 'Product' object has no attribute '_poTemplatesJoin' [03:58] ditto for the 'Launchpad mirroring project' [03:58] stub: [03:58] alter table bugtracker rename column bugsystemtype to bugtrackertype; [04:02] stub: ok? [04:04] lifeless: it most certainly does... where are you importing Project from? === stub missed the bugsystem -> bugtracker rename. [04:05] IRC is probably not the best medium for this :-) [04:09] stub: also need a unique name on bugtracker [04:09] also, need unique (project, bugtracker) on projectbugtracker [04:09] stub: i have working code for the post-rename platform [04:09] hmm... for a loose definition of woring, given the state of our tests [04:10] unique(project,bugtracker) is already there. [04:10] oops, true [04:10] sabdfl: what do you mean by 'importing Project' ? [04:11] import canonical.launchpad.database is the way to do it [04:11] is that where you are finding your Project object? [04:11] I've just : grabbed the latest code, run the schema makefile to update the database, run make run in the top [04:11] lifeless: or just give me a url that is breaking [04:11] I then browsed to the new doap stuff [04:11] ok [04:12] http://localhost:8085/++skin++Debug/doap/projects/launchpad-mirrors [04:13] 'sworking fine here [04:13] garh. [04:13] ok, I'll nuke my database and retest. The concern though is - we can't do that to emperor. [04:14] (new sample data works fine under the same /doap/projects/ [04:14] (its only existing sample data or production data it has trouble with) [04:14] stub: [04:14] DatabaseException: ERROR: relation "bugtracker_id_seq" does not exist SELECT NEXTVAL('BugTracker_id_seq') [04:15] does the rename automatically rename the seq tables? [04:16] nope. [04:16] it doesn't. [04:16] nice [04:17] No it doesn't, and I don't think we want to (it involves creating a new sequence with the new name, setting its current value correctly, and resetting the default value on the tables primary key). [04:17] oh... [04:19] hmm... what about [04:19] alter table bugsystem_id_seq rename to bugtracker_id_seq [04:19] seems to work here [04:20] kiko? [04:25] sabdfl: its a canonical.launchpad.dmark.Product product instance, but it has not _poTemplatesJoin attribute [04:26] sabdfl, that's peculiar -- you're using alter table on a sequence? [04:27] or do you mean alter sequence bugsystem_id_seq? [04:27] sabdfl: going to the gimp project, doesn't trigger the same code path. [04:28] ack [04:28] bizarre. pgsql has no alter sequence, you're right [04:29] sabdfl, sounds correct then. you alter the table and then the sequences it should use. [04:31] kiko: I think they just overloaded the alter table command to deal with sequences, or it is possibly just a useful side effect === stub has learnt something new [04:31] lifeless: i'll commit to my latest revision, which works on the arch-mirrors project [04:31] sabdfl: thanks [04:31] I'm tracking it down, nearly there :) [04:32] oh, I know why [04:32] the same data has no products. [04:32] so the code int he template that fails is never triggered. you need products to trigger it., [04:33] does your arch-mirrors project have any products ? [04:33] separate question, how do I give myself a usercode ? [04:35] you guys seeing chinstrap.warthogs.hbd.com? [04:35] yes, just fine [04:36] its idling. [04:38] lifeless: i think that's fixed in a recent commit. sec// [04:40] stub, lifeless: pqm mail on the wire [04:41] lifeless: Sample data has no products at the moment, as the inserts are failing because there are no people :-/ [04:41] lifeless: the page template still links to "+add-sourcesource" [04:42] what is the correct url for me to test with locally? [04:42] stub: where are all the people? [04:43] sabdfl: it used to be /soyuz/project/product/+add-sourcesource , then .../sourcesourcename [04:43] sabdfl: Being created *after* the projects are trying to be created :-/ [04:44] Yes - I think somebody has stuck a load of inserts manually at the top of current.sql [04:46] ah [04:47] does pg_dump do things in a fashion that avoids this? [04:47] maybe we should create new-samledata.sql with a big warning at the top of the file: [04:48] Don't worry - I think it was me :-) [04:48] DO NOT EDIT THIS FILE [04:48] ? [04:48] Must have sneezed at the wrong time and made vim do something nasty ;) [04:48] stub: so how do I add a person for me ? === stub pulls the correct version from rocketfuel@ [04:49] lifeless: There is a readme file that Mark wrote in database/sampledata [04:49] lifeless: But don't do it yet, as the new method of making sampledata will not merge well and I'm playing with it atm. [04:50] stub: hmm.. merges could be fun [04:50] stub: the readme doesn't tell me [04:50] that talks about updating the sample data, not about bootstrapping a usercode with password when you don't have one in the first place. [04:51] Oh... ic. The script is in rosetta - look for createuser.py [04:51] You would use that to create your user (crypt your password and insert into the Person table basically), then do the stuff described in sampledata/README to make a snapshot of your database. [04:52] lifeless: foo.bar@canonical.com [04:52] password test [04:52] sabdfl: thanks. [04:52] but.. your scripts want you, i guess [04:52] I'll need to do the createuser thing on emperor though... [04:53] nope, your tweaks don't fix it. [04:53] its the lack of products that stop you seeing it I think. [04:54] oh bah, and now a problem with _bugtrackers. [04:55] lifeless: i think i've found the problem code [04:55] cool [04:56] I'll go grab a late breakfast. [04:56] as I'm starving === justdave_ [~justdave@24.247.63.44.gha.mi.chartermi.net] has joined #launchpad === justdave [~dave@24.247.63.44.gha.mi.chartermi.net] has left #launchpad ["Poof"] === justdave_ is now known as justdave [05:06] patch going to pqm now [05:07] lifeless: were you tracking the renaming at all? [05:13] sabdfl: yes, but at the email level, not hte code level - no time to do more [05:13] ok, theres a lot to clean up [05:13] i'm on it now, may as well pull an all nighter [05:13] get some sleep... sleep is important. [05:14] no, i think i want to commit this so I can as you to replace the "duh" lines with something more... explanatory [05:14] sure thing. [05:15] that was all the last day @ london :[ [05:15] sure, time to clean it up though [05:15] ill get everything renamed and in the right places [05:15] and running [05:16] thank you [05:16] I'll go back to default-branch handling for now then [05:17] lifeless: please don't use arch-tag in new files [05:17] let's stick to tla add [05:17] sabdfl: why not ? [05:18] (arch tag is faster, able to carry data via patch | inclusion in svn etc, able to just be 'mv'ed) [05:19] lifeless: when you copy the file, arch bitches [05:20] sabdfl: right, because you have the same id present, so you just update the tag, same as if you copy a file then run tla add. [05:21] right now, half the files have them, half don't and i don't like it [05:21] nor does the rest of the launchpad team [05:21] oh. === lifeless shrugs [05:22] ok, for launchpad, I won't arch-tag files. [05:32] lifeless: how do you specify an Interface for a method that takes **kwargs [05:32] ? [05:33] erm, the usual I'd have said: [05:33] method(known, arguments, *args, **kwards) [05:34] thankjs [05:36] did you know i'm up to 320 tests in cscvs ? === stub [~stub@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad [06:10] lifeless: you're making baby jesus cry over here [06:11] sorry baby jesus [06:11] baby sqlite is making me cry now [06:14] what do you use sqlite for ? cscvs? [06:14] yes [06:14] the temporary cache of CVS changesets [06:14] i have had to really brutalise the classes you created for sync db insertion [06:15] where are you using those classes, and are there tests? [06:15] what file where they int ? [06:15] if it's enough just to get the data in the db, that's up and running now [06:15] when? [06:15] if they came from canonical.arch.*, then I was using them in buildbot and in launchpad and there is good test coverage. [06:16] if they came from canonical.soyuz.*, then just stashing the data in the database is enough. [06:16] but there isn't great test coverage for the soyuz ones ( the functional test framework wasn't present when I was writing the bulk of that code) [06:16] the latter, phew [06:17] sabdfl: When Malone sends an email to a Person, which email address does it use? I think we need a 'preferredemail' column in the People table [06:17] agreed, but what if there isn't a preferred email, o any email? [06:17] preferred contactdetails ? [06:18] It should be set automatically to the first confirmed address. If there is no preferred email or no email we don't send them anything [06:19] (or better yet, refuse to let them be subscribed as a CC in the first place in that situation, although we still need to cope if they remove their email addresses later or they become invalid) [06:21] lifeless: I was thinking of just a foreign key referencing the emailaddress table [06:22] Or perhaps a preferred boolean column on the emailaddress table would be better... [06:22] I was thinking just tack an object against the Person... represent that in the db the easiest way. [06:25] It is tied to the emailaddress table though, where we store the status (new, confirmed, old). [06:29] Hmm... actually we *could* just use the existing status column. [06:54] i like the idea of doing nothing till we have a confirmed email for them [06:54] at that point, they are a user [06:54] till then, they are data [06:55] what's the magic to get Table.select(name='foo')? [06:56] stub? [06:57] magic? [06:57] Table just needs to inherit from SQLOS or whatever our base clase is :) [07:10] kiko: can you give me an example using Product? [07:10] I want the product with name='foo' [07:11] sure [07:11] >>> p.select(name='gnome') [07:11] Traceback (most recent call last): [07:11] File "", line 1, in ? [07:11] TypeError: select() got an unexpected keyword argument 'name' [07:11] >>> [07:11] p = Project [07:12] Project.select(Project.q.id == 23) [07:12] for instance [07:13] there are examples in soyuz/sql.py I suspect [07:14] ah [07:14] thanks [07:14] I don't have a tree to peek at right now [07:14] sabdfl: usually though I think its best to abstract that. [07:14] it makes the code very dependent on the exact db structure. [07:15] lifeless, abstracting by providing class methods like getProjectByID? [07:15] kiko: for example, yes. [07:15] actually, the DataMapper pattern from POEAA is a much better way, which I started implementing for Product Project and Sync in soyuz [07:16] well, okay, but I tend to think that the domain code is helplessly intertwined with SQL and therefore tightly coupled to the db schema [07:16] but, any abstraction that decouples data representation and semantics is the key, [07:16] in practice at least [07:16] kiko: thats the whole point of the abstractions, they prevent that. [07:16] Have you got a copy of POEAA ? [07:16] Patterns of ... ? [07:17] maybe I do [07:17] patterns of enterprise application architecture [07:17] fowler [07:17] martin [07:17] I see. [07:18] the problem I see is that IRL unless the abstraction is really flexible you end up cheating here and there to get things to just go as you need them to. [07:18] I'm okay with cheating though [07:18] and if you accept that I'll agree that providing abstractions that are cheatable are much better than sprinkling column and table names around application code if possible. [07:19] if your abstraction is just a dictionary mapping X to Y however.. ;-) [07:19] kiko: how do i use tal to specify a url that's like /xxx/name/ [07:19] where xxx is fixed [07:19] and name comes from tal [07:19] like: [07:19] hummm [07:19] like: /srcpkg/5/ [07:20] if i use tal:attributes it replaces the whole href [07:20] kiko: sabdfl string('xxx') + context/name [07:20] hmmmm, can I see the whole statment [07:20] I think you need python: or something in there too. [07:21] kiko: right, so what you do is you encapsulate the semantics of the domain<->persistence in the data mapper. [07:21] then when you need to cheat, you just extend the datamapper appropriately. [07:22] you can tie data mappers into your transaction framework, and that then takes care of lazy commits and so on. [07:22] it all hangs together /very/ nicely. I understand that APE is based on much of POEAA [07:23] sabdfl, does that actually work? [07:24] lifeless: the Mapper code is horrible to follow [07:24] the quick stuff I'd put together ? [07:24] kiko: python: string('sdfsdf')+source.name [07:24] works [07:24] lifeless: yes [07:25] I think data mappers tend to be kind of complex, given my experience with APE [07:25] maybe a nice fancy framework but the codepaths are too horrendous for words [07:25] cause if thats what you mean, I won't disagree, I was simply aiming to keep the two things separate and build it out as appropriate. [07:25] thanks for the fun evening ;-) [07:25] heh [07:25] sabdfl: nyah, that wasn't a nice fancy framework :) [07:26] what's wrong with this: [07:26] return SourceSource.select(SourceSource.q.name=="%s" % \ quote(sourcesourcename))[0] [07:26] kiko: yes, data mappers are complex for trivial projects - but for something the size of launchpad... I think they are a simplification. [07:26] sabdfl: are you asking me whats wrong with it stylisically, or functionally ? [07:27] it looks okay [07:27] functionally, it's 6:30 am [07:27] could be there are no SourceSource objects in the database and [0] is breaking things [07:27] kiko: yeah, deliberate exception in that case. [07:28] yes, but I need to see a traceback [07:28] sabdfl: is there a traceback from that ? [07:28] list index out of range [07:29] but the same code works in a console [07:29] it just means that the [0] is breaking things [07:29] are you looking at the same database? [07:29] sabdfl: it means that there is not a matching source source for that sourcesourcename [07:29] are you running into an sqlobject-caching-my-data thing? [07:30] I'd add a import pdb;pdb.set_trace() before the return, and poke a little after you trigger it [07:30] I suspect it's just a consistency of db view issue, but ... [07:32] ok i'm in pdb [07:32] how do i print out variables etc? [07:32] u [07:32] will take you up the stack [07:32] d [07:32] will take you down the stack [07:32] kiko: there are sourcesrouce rows [07:32] list will show you the code [07:33] will be evaluated in that context. [07:33] ie. [07:33] print quote(sourcesourcename) [07:33] or print self.foo.bar [07:33] ok, sourcesourcename is coorect [07:33] is quote(sourcesourcename) correct ? [07:34] you can assign variables too: [07:34] temp=SourceSource.select(SourceSource.q.name=="%s" % quote(sourcesourcename)) [07:34]

Eric Deleforterie2004-10-01 20:46 [03:41]

p="nowrap">etienne zannelli2004-10-01 23:25 [03:41]

Eric Deleforterie2004- [03:41] oops [03:41] http://paste.plone.org, please ;) [03:41] sorry [03:41] wrong paste buffer [03:41] a img.selected { background-color:#77F } [03:41] a:visited img { background-color:#BBB } [03:41] a:visited img.selected { background-color:#77F } [03:42] a img:hover { background-color:#55F } [03:42] [03:42] sabdfl: just run 'make' as normal - the errors are it trying to drop or alter tables that don't exist. [03:42] /* The following are used to induce highlighting effects on thread message icons */ [03:42] that's it [03:42] 5 lines [03:42] starting with that comment [03:42] #55F is the blue that is an envelope background [03:42] I should include them? [03:42] aha [03:42] couldn't find it the last time I looked [03:42] thanks [03:42] ok [03:42] also: [03:43] http://lists.ubuntu.com/lists/thread/20041002.075655.e3b28dc7.en.html [03:43] I have changed the roll-over of the list of threads to an orangey colour === limi looks at the shiny new Planet tab on ubuntulinux.org :) [03:43] there's an odd effect on the last row of the table [03:43] you mean the border? [03:45] yes [03:45] I guess so [03:45] random orange lines [03:46] SteveA: btw, if you could add in the Planet tab in Lurker, that would save me a round-trip :) [03:46] just add: [03:46]

[03:46] accesskey="t">Planet [03:46]

[03:47] after the existing tabs (Ubuntu, Community, Support) [03:48] stub: even after a complete database drop and recreate, i still see this: [03:48] DatabaseException: ERROR: relation "bugtracker_id_seq" does not exist SELECT NEXTVAL('BugTracker_id_seq') [03:49] Where do you see the error? When the sample data is loading or from launchpad? [03:50] no, when queries start to hit the db [03:51] When I do '\d BugTracker' inside psql, I can see the primary key is referencing bugsystem_id_seq and nothing else should even know that sequence exists. [03:52] alter table projectbugsystem_id_seq rename to projectbugtracker_id_seq; [03:52] alter table bugsystem_id_seq rename to bugtracker_id_seq; [03:52] these fix the problem [03:53] stub: These were the autocomplete renames I suggested. :) (At least some of them) [03:53] It doesn't fix my database, as the DEFAULT value of the tables still point to the old sequence (which no longer exists!) [03:54] Is there python code that is referencing the _seq sequence directly, rather than telling the database to use DEFAULT? [03:54] limi: I added the tab [03:54] not afaik [03:54] great, thanks [03:55] SteveA: fixing the border now [03:55] ok [03:55]