[12:07] (spiv/#launchpad) SteveA, lulu: registering through the plone site with a + in the email address seems to work fine, apart from an odd error immediately after signing up (and I had to explicitly ask for a password reset after signing up, too) [12:10] spiv: did you see the subsequent email from lu? the people mailing in were having trouble with mako's shipit, not with the main website [12:10] but, thanks for checking into it. we should fix the odd error you uncovered [12:10] (daf/#launchpad) spiv: lulu is not here [12:10] (spiv/#launchpad) SteveA: Yeah, I did, but I thought it would be working checking just in case :) [12:10] (elmo/#launchpad) steve: it's 11pm... [12:10] (spiv/#launchpad) daf: Damn people with nicks that are too short to bother tab-completing ;) [12:11] elmo: it is 1am [12:11] (daf/#launchpad) spiv: damn them :) [12:11] (spiv/#launchpad) SteveA: Also, this means the nick-generation stuff is live. [12:11] cool [12:11] (elmo/#launchpad) SteveA: blahblah, you know what I mean. where Lu is, it's 11pm [12:11] can you note the odd error in the bug report? [12:12] (spiv/#launchpad) (I also changed the authserver to accept nicks as login IDs, alongside Person.id values and emailaddresses) [12:12] elmo: ok, but it was spiv who addressed lulu [12:12] great [12:12] (daf/#launchpad) aye, Lu clocks of pretty regularly between 5 and 6 [12:12] (spiv/#launchpad) Hmm, it's midnight here, come to think of it... [12:12] (daf/#launchpad) s/of/off/ [12:12] that will allow us to switch between email address for login and nick, if we want to at some point === spiv still isn't quite used to being on roughly the same timezone as other people ;) [12:13] (daf/#launchpad) :) [12:14] (daf/#launchpad) being over here is weird [12:14] you mean you're not dead yet? [12:14] (daf/#launchpad) stub tends to be saying "good morning" when I'm going to bed [12:14] (daf/#launchpad) SteveA: not yet [12:14] does it feel safe at night? [12:15] (daf/#launchpad) Mark's estimation of my life expetancy notwithstanding [12:15] (daf/#launchpad) it does, actually [12:15] wow [12:15] (daf/#launchpad) not that I've been out at night much [12:15] (daf/#launchpad) safe, but cold [12:15] I must try to sleep [12:16] (daf/#launchpad) yes [12:16] (daf/#launchpad) you must === BradB just realized daf and co. are a few hours from Montreal [12:18] NYC Mao Championship! [12:18] (daf/#launchpad) :) [12:18] last time i was in NYC was for the '96 NY Open Chess Championship...memories... [12:18] pictures of the twin towers, etc. [12:19] (daf/#launchpad) gosh, 8 years [12:19] yep === carlos hates too much the functional tests... [12:21] carlos: why? [12:21] BradB: because I'm trying to fix one, that's all :-) [12:21] ah...yeah, that's the fun part [12:21] fsdo "fun" [12:26] (dilys/#launchpad) Merge to rocketfuel@canonical.com/launchpad--devel--0: implemented bug subscription listing (patch-632) [12:35] daf: I detected a bug in pofile_adapters that I don't think it's a direct problem of my changes, should I fix it? (the functional tests are failing because it) [12:36] I mean, should I fix it or wait after the merge? [12:38] (daf/#launchpad) if it's not related to your branch, you'll ideally fix it in the trunk and merge the fix onto your branch [12:38] (daf/#launchpad) I don't know if that's feasible or not [12:39] daf: it should be doable, I will take that approach tomorrow, I'm tired today and it's too late... [12:39] daf: we need to do a review of all code, I was adding XXX in many places [12:40] (daf/#launchpad) "all" code? [12:42] well, all code related to pofile.py [12:43] perhaps it's me, but there are some places where I have some doubts if it's correct... [12:44] daf: I'm tired tonight, let me rephrase it tomorrow :-) [12:44] (daf/#launchpad) sure :) [12:47] ok, good night!! [01:04] (dilys/#launchpad) Merge to rocketfuel@canonical.com/launchpad--devel--0: fixed adding of bug subscriptions (patch-633) [01:13] spiv: around ? [01:14] lifeless: duh... just realised that the sql recipe you gave me to enable sync was wrong... [01:15] had to dig into sourcesource.py, a job is a sync if sourcesource.syncingapproved is non-NULL instead of just processingapproved... [01:15] oh? [01:15] you said: update sourcesource set processingapproved=NOW(), syncinterval='1 day' where name like 'foo%'; [01:15] the recipe I gave you was syncingapproved=NOW() ... [01:15] oh, oops. [01:16] the force of copy-pasting :-P [01:17] limi has real issues with his tla revision library [01:17] btw, I noticed that the taxi.py brokeness will prevent the mirror from ever being populated, since the mirroring is done there. You're sure that's not going to be a problem for testing? [01:17] inode signature validation problems, etc [01:17] can i just blow away the revision library contents? [01:17] sabdfl: yes [01:18] rm -r the directory/* [01:18] ? [01:18] rm -rf revlib/*@* [01:18] so you do not blow the =* files which store the options [01:18] ddaa: thats what I'm trying to track dow with spoiv [01:19] ddaa: and yes, the stuff that you are testing doesn't need the mirroring. [01:19] lifeless: ha... I thought that spiv was tasked to "make taxi.py sort of work again" [01:20] apparently the sqlobject stuff had thread safety issues. [01:21] ho btw, I noticed that the slave bot tend to hang with a two zombie subprocs, on sh and one cvs... i would not be very surprised that the cscvs process handling stuff is making twisted unhappy... [01:22] ddaa: you tracked down a hang on that? [01:22] nope [01:22] just a guess [01:22] I've had a suspicion about it, but haven't verified it. Can't fix a guess. [01:23] :) [01:23] lifeless: that's exactly what I did with pyarch/twisted... [01:23] "I guess that using twisted own process handling will make thing run more smoothly" [01:23] and, surprise, it worked the first time [01:23] ddaa: with pyarch I had verified it as being a problem - I threw logging statements before and after pyarch calls. [01:24] and it consistent broke there. [01:24] lifeless: oh ok === ddaa goes back at putting zenity to sync [01:24] so far, its not been breaking *for me* around similar popen calls in cvs. [01:25] btw, I made a hack here so buildbot binds to localhost only [01:25] if you can track down a hang there, that would be great - I'll port over your process handling asap. [01:26] so it does not listen to the wild internet on my non-firewalled ubuntu system. [01:26] aw man, kdelibs has a file kdecore/libintl.cpp.orig [01:26] anyone spot the problem there ?! [01:26] I do [01:26] it will be moved to +conflicting-files or something, won't it? [01:27] yeah, but the id remains. [01:27] so you get a tree-lint error. [01:27] that orig/rej handling behaviour in tla is soooo stupid... [01:28] I don't agree. [01:28] it's moving stuff around even when the inventory tells it's source. [01:28] "if it source it belongs there, user said" [01:28] the problem is that foo.c is patched by 'patch'. and patch created foo.c.orig and foo.c.rej. [01:29] lifeless: that does not happen in your case [01:29] having those files present in a 'names' or 'tagline' with 'untagged source source' would result in them being commited. [01:29] so it's creating a problem in your case. [01:29] ddaa: my case is irrelevant. its like commiting a dir called CVS to CVS. [01:29] it can't do it. [01:30] You can't commit .orig and .rej file to arch? Weird, i already commited {arch}/=tagging-methog.orig, of course the result was a corrupt archive since the revlib would not build. [01:31] I just cachedrev to work around it. [01:31] And the revlib would not build because tla moved the file around. [01:31] even though it was source [01:31] well, more accurately, if you manage to do it, you get trouble. [01:32] I *can* go to a cvs repository and create a dir inthe repo called CVS === mdz [~mdz@69-167-148-207.vnnyca.adelphia.net] has joined #launchpad [01:32] and that similarly gives the system kiniptions. [01:32] What causes trouble is that tla move source files when their name end in .orig or .rej. If the user says it's source, trust the user. [01:32] ddaa: heres where I disagree. [01:33] *shrug* [01:33] tla should lift the semantic problems first. once that is done, your suggestion is viable. until then its just a can of corner cases. [01:33] for instance, we could reserver ,,filename.orig and ,,filename.rej for tla. [01:34] as we already have reserved ,,* for tla. [01:34] Yup. Would be better. [01:35] There's probably no one around except tom perverse enough to use such names. [01:36] Yet I reckon the moving .orig files around causing breakage was hard to forsee for the arch designer. [01:37] that's the kind of thing you think is perfectly reasonable until [01:37] a use case comes where it's not... [01:37] moving around was not the original behaviour [01:37] it was a reaction to other negative behaivour... [01:38] I was probably not there at the time... [01:38] what was the issue? [01:39] IIRC the original one was them being committed to tla. [01:39] so then they got moved out of the way. [01:40] rather than out of the namespace at creation. :{ [01:40] That was before the inventory classification? [01:41] Was not, because that still need "precious" logic to work... [01:43] inventory is way back [01:43] so... wrong solution... the right solution was to classify as non-source. [01:43] but the defaults were older still [01:44] and no, classifiying as non-source doesn't fix anything. [01:44] it prevents the file from being commited [01:45] but not from overwriting a possible users file, and not from the user changing the naming methods, and not the naming methods for existing archives. [01:46] overwriting a possible user file: that's were the +conflict-file should trigger, not before [01:46] changing the naming method: that's exactly my point, if I say those are source, they should be archived and handled correctly. [01:47] ddaa: we're back full circle. [01:47] lifeless: yes... I was expecting it... [01:49] so, you just need to special-case your code to say that .orig and .rej file cannot possibly be source, and if someone is perverse enough to actually use a .orig suffix for a real source file, then you're screwed. [01:49] well, I'm checking if thats what kdelibs do. [01:50] or if its a glitch they would rather forget. === ddaa lights a notional candle and notionally prays [01:52] Tools that cause screwage are bad. Pyarch is bad for having a synchronous api, twisted is bad for causing other process handling schemes to break, sqlos is bad for having difficult thread safety problems, and tla is bad for messing around with .orig and .rej files. [01:53] congratulations, you have just channeled asuffield. [01:53] how do you feel? [01:53] bad [01:53] like the world is a big pile of steaming shit [01:53] if asuffield feels like that all the time, I understand he's generally unfriendly. [01:54] but I find the irony of it all funny :-D === ddaa had blushed... [01:55] omg. [01:55] revision 1.1 [01:55] date: 1998-06-03 21:04:23 +0000; author: kulow; state: Exp; [01:55] true LPGL version of libintl. I'm almost sure, that this will cause major [01:55] problems, but has one big advantage: we have no longer mixed licenses. [01:55] Anyway, I've added the .orig file, so in trouble, the user can copy the [01:55] .orig file back [01:56] ==== [01:56] the kde folk overloaded .orig in their tree. === ddaa cackles [01:56] the first patch failure they get, they'd be hosed. [01:56] then 25 days later, they nuke it. [01:57] ---------------------------- [01:57] revision 1.2 [01:57] date: 1998-06-28 22:18:05 +0000; author: garbanzo; state: dead; lines: +0 -0 [01:57] *.orig and *.new don't really belong in here, and they're not being used [01:57] anyways, so I'd just as soon sweep em into the Attic. [01:57] ---------------------------- [01:57] ok, time to teach cscvs that .orig and .rej should be ignored. === ddaa still thinks that's not the Right solution [01:58] [01:59] lifeless: Exceptions.RuntimeError, No CVS Commits have occured, cannot perform incremntal totla [01:59] ddaa: you know the right soluiton: alter tla to use ,,filename.{orig,rej}. update the move-conflictpatch files logic, update the default naming conventions. [01:59] do we want to do this for 1 repository ? [02:00] which 6 years ago for one month had a brain fart ? [02:01] lifeless: that's not the right solution, i expect that will hose emacs diff-mode which handles .rej files by (i suppose) guessing the patch target from the name of the rej. [02:01] and any other tool which does essentially the same thing. [02:02] Except, if the ,,filename.rej file is altered to be a proper patch. [02:02] ddaa: its the only solution that both prevents the user hosing their working tree and simultaneously allows them to put .orig and .rej files in the archive. [02:02] in short, this isn't a trivial problem, and asserting that tla should 'just leave the files alone' isn't sufficient to fix it. [02:03] your exception - the lastFoo method has failed to retrieve the incremental starting point. [02:03] I'm all in favor of letting the user hose the tree if the inventory is altered so .orig/.rej files are source. You know, the sharp knives / dangerous tools stance. [02:04] ddaa: we currently give people a bandsaw. And you want to make it worse ? [02:04] I'm fully in favour of powerful tools, and *should they need to be* dangerous ones. [02:04] Same thing as I said before. There should be something that is really a toolbox, and something that is really a user tool. The same tool cannot do both properly. [02:05] ah yes - cscvs.arch.findLastCSCVSCommit [02:05] that returned None, not the revision that was last commited to arch. [02:05] Yet, you are correct that this discussion is not very relevant, since existing tools and practices effectively route most people around the problematic use cases. [02:05] you should be able to just import it and execute it to see what the results are. === jblack_ [~jblack@static-209-158-45-74.scr.east.verizon.net] has joined #launchpad [02:15] ah... my fault... last time I tried to sync I had not set the syncingapproved and it nukedtargets then crashed because of the locked sqlite db. [02:15] (which was locked because the previous run crashed on taxi.py) [02:17] It's tricky to get that thing to run. [02:31] sabdfl: wasn't the adding of comments to a bug already working? i thought it may have been but it isn't anymore. [02:32] BradB: might have been broken with the skinning [02:32] underlying code might still work [02:32] check for a BugMessage addform [02:32] BradB: could you focus on email for this week? [02:32] i'll keep cleaning up the basics [02:33] sorry, got a bit lost on the artwork today [02:33] but i spent a lot of time on it over the weekend [02:33] sabdfl: that was my intent, so the first thing that seemed needing email notification was adding of comments. [02:33] but adding of comments doesn't work. [02:35] ah :-) [02:35] i also fixed subscriptions earlier, because notifications are pretty useless if people aren't able to subscribe. :) [02:35] BradB: i think they *do* work but the form is messed up [02:36] yeah, that's why i asked here next [02:36] hm [02:40] fixed. === daf [daf@muse.19inch.net] has joined #launchpad === justdave [~dave@24.247.63.44.gha.mi.chartermi.net] has joined #launchpad [02:53] lifeless: portd/JobStrategy.py, line 180 in getCVSTempRepoDirPath [02:54] return os.path.join(self.getWorkingDir(self.aJob,self.dir), "cvs_temp [02:54] exceptions.AttributeError: 'CVSStrategy' object has no attribute 'dir' [02:54] I'm going to bed now. [02:55] Just pointing out the problem. If you do not have the time to fix it, I'll do it tomorrow. === ddaa [~ddaa@nemesis.xlii.org] has left #launchpad [] [03:12] cheers guys, launch day tomorrow, need some sleep === sabdfl [~mark@host217-37-231-28.in-addr.btopenworld.com] has left #launchpad [] [03:28] (dilys/#launchpad) Merge to rocketfuel@canonical.com/launchpad--devel--0: fixed adding comments to bugs (patch-634) === BradB is now known as BradB|away === jblack_ is now known as jblack [04:59] (dilys/#launchpad) Merge to rocketfuel@canonical.com/cscvs--devel--1.0: skip over .rej and .orig files in CVS repositories (patch-33) [05:21] (dilys/#launchpad) Merge to rocketfuel@canonical.com/buildbot--devel--0: api update to latest cscvs (patch-60) [05:38] (dilys/#launchpad) Merge to rocketfuel@canonical.com/buildbot--devel--0: restore setting the cscvs tree's logger (patch-61) [06:47] stub@belch ~ $ tla -V [06:47] tla tla-1.2-4 from regexps.com [06:47] Copyright 2003 Tom Lord [06:47] This is free software; see the source for copying conditions. [06:47] There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A [06:47] PARTICULAR PURPOSE. [06:47] Report bugs to lord@emf.net. [06:47] # automatically generated release id (by arch-buildpackage) [06:47] tla-1.2-4 [06:48] lifeless: Before I go chasing why things are screwed at my end, is that correct? [06:48] thats the standard ubuntu or debian build [06:48] we are generally using integration, but - whats the problem ? [06:48] (Is it the one I mailed you back about already?) [06:51] The one I mailed you about (I think you were confused by by mail client helpfully word wrapping). But I'm getting the same error in launchpad, so something has changed between the last patch I committed yesterday and this morning. I was checking if a package upgrade had bit me without me realizing. [06:52] the (null)/ bit in your log was definately wrong [06:52] what tla are you using? [06:52] that (null) will cause the lookup for the signing rule to fail. [06:52] do you see the same (null)/category--branch--version--patch-level in the launchpad corrupt checksum ? [06:52] jblack: 1.2-4 - ubunut standard [06:54] (where that (null) is, should have been the archive name - 'stuard.bishop@canonical.com') [06:54] Yeah. === jblack looks up bofh... [06:55] Cosmic rays, stub. [06:55] More seriously, very weird. Can I see the log? [06:55] lifeless: No - there is no null in the launchpad one. [06:56] stub: eek. [06:56] but its also not got the gpg lines around it ? === lifeless hands over to jblack, as he's flat out [06:57] First time I've heard of anything like this. Nothing even close. [06:57] tla bombs if it can't figure out the version involved. [06:58] jblack: try 'tla init-tree', 'tla import -S $fqversion' [06:58] then check checksum in the base-0 [06:58] -----BEGIN PGP SIGNED MESSAGE----- [06:58] Hash: SHA1 [06:58] Signature-for: stuart.bishop@canonical.com/cookiecrumbler--canonical--1.2--patch-3 [06:58] md5 log b42f0da30042d2c99a3492293a5a7fb7 [06:58] md5 cookiecrumbler--canonical--1.2--patch-3.patches.tar.gz aedf797c0b7536fd7043076990b4acd2 [06:58] -----BEGIN PGP SIGNATURE----- [06:58] Version: GnuPG v1.2.4 (GNU/Linux) [06:58] iD8DBQFBZqpZAfqZj7rGN0oRAtcHAJ9nvP5ql3gzm9lwsMuc9n9TQZk7fACfSBDT [06:58] vfPyu0fhr2x2+FVK3IGUeDU= [06:58] =Kcvn [06:58] -----END PGP SIGNATURE----- [06:58] I advised stuart to use the normal way which is 'tla init-tree $fqversion' ; 'tla import -S' [06:59] That is the checksum from a project I am sure hasn't been touched since it was working. Same error, so either my tla is screwed or I've screwed my config and don't remember doing it. [06:59] stub: that looks fine syntax wise. [06:59] cat $thatfile | gpg --verify-files - [07:00] my patch-log looks right for init-tree $fqv ; tla import -S [07:00] it's signature-for line does not have (null)/.. ? [07:00] Though I'm using a newer gpg of course. [07:00] pardon, newer tla. [07:01] I didn't make a signed (duh) making [07:01] jblack: hang on. [07:01] 'init-tree $fqv ; tla import -S ' is known good [07:02] its 'init tree'; 'tla import -S $fqversion' that is suspect [07:02] stub: did that cat work ? [07:03] since when does import -S take an option ? [07:03] year 0 [07:03] Doesn't improt here. [07:03] Doesn't improt here. "tla init-tree; tla import -S this--that--0" [07:03] reports no patchlog. [07:04] but its not the recommended way because things between init-tree and import need the patch-log dir etc [07:04] and import -S doesn't take a fqvn argument. [07:04] heh, well stub got a bad checksum in the archive. [07:04] Just checked the code. [07:04] tla import [options] [[archive] /version] [07:04] is the help. [07:06] stub: ping [07:06] lifeless: The cat worked [07:06] I can't reproduce his behavior here. [07:06] ok, stub, now cat your ~/.arch-params/stuart@canonical.com.check file [07:06] not with my tla-dev, anyways [07:07] I'm doing a tla get from rocketfuel@canonical.com-SOURCE - this should confirm if I have a corrupted archive or not. [07:07] stub: hang on [07:07] please [07:07] lets work through this methodically. [07:07] doing a get from -SOURCE *will not work*. [07:07] you are thrashing, which helps noone. [07:07] stub: so, please cat that file. [07:07] I don't have a stuart@canonicalcom.check - just an =default.check. It contails just 'gnome-gpg --clearsign' [07:08] stub: ok, thats not what we recommend. [07:08] but, we can test if its working [07:08] in fact. [07:08] thats your problem. [07:09] your default *check file* is *signing*. [07:09] which will never work. [07:09] the check file should be something like [07:09] tla-gpg-check gpg_command="gpg --verify-files -q --no-show-notation --batch --no-tty " 2>&1 | grep "^gpg: Good signature from" 1>&2 [07:10] with extra params if you are checking a specific archive to restrict the keys that can be used. [07:10] Sorry - wrong file [07:10] stub@belch ~/tmp $ cat ~/.arch-params/signing/=default.check [07:10] #!/bin/sh [07:10] tmp=$(mktemp tla-gpgout.XXXXXX) [07:10] if ! gpg --batch --verify 1>"$tmp" 2>&1; then [07:10] cat "$tmp" [07:10] exit 1 [07:10] fi [07:10] rm -f "$tmp" [07:10] omg [07:10] where did you get that from ? [07:10] probably me [07:10] Yu [07:10] p [07:11] which goes all the way back to the orignal recommendations of keychecking. [07:11] sh ~/.arch-params/signing/\=default.check [07:12] Anyway - I just checked our a revision from chinstrap and things look to be working fine. I think my archive is screwed. [07:12] bah [07:12] thats [07:12] sh ~/.arch-params/signing/\=default.check < 'good checksum file' [07:12] that will succeed or fail [07:13] (good checksum file in your archive, obviously) [07:14] sh ~/.arch-params/signing/\=default.check < /home/stub/.arch-archives/stuart.bishop\@canonical.com/launchpad/launchpad--devel/launchpad--devel--0/patch-271/checksum [07:14] Works fine [07:15] try this [07:15] tla cat-archive-log stuart.bishop\@canonical.com/launchpad--devel--0--patch-271 [07:16] $ tla cat-archive-log stuart.bishop\@canonical.com/launchpad--devel--0--patch-271 [07:16] ******************************** [07:16] INVALID CHECKSUM FILE SYNTAX FOR REVISION! [07:16] archive: stuart.bishop@canonical.com [07:16] revision launchpad--devel--0--patch-271 [07:16] checksum file: checksum [07:16] ******************************** [07:16] trouble reading checksum file for stuart.bishop@canonical.com/launchpad--devel--0--patch-271 [07:16] ok, can you paste the checksum file please [07:17] stub@belch ~/launchpad/launchpad $ cat /home/stub/.arch-archives/stuart.bishop\@canonical.com/launchpad/launchpad--devel/launchpad--devel--0/patch-271/checksum-----BEGIN PGP SIGNED MESSAGE----- [07:17] Hash: SHA1 [07:17] Signature-for: stuart.bishop@canonical.com/launchpad--devel--0--patch-271 [07:17] md5 log bf098182919c00fb76eabd690f0ea426 [07:17] md5 launchpad--devel--0--patch-271.patches.tar.gz 0550eecf8e2860babf1d61e55a80f649 [07:17] -----BEGIN PGP SIGNATURE----- [07:17] Version: GnuPG v1.2.4 (GNU/Linux) [07:17] iD8DBQFBc4BCAfqZj7rGN0oRAk3xAKCDHHaHsMG5bl9Ke34kRO+/GBvX9wCeIXRE [07:17] 0gqPzMMbxHymwpMYmu5tMKo= [07:17] =yr2h [07:17] -----END PGP SIGNATURE----- [07:18] stub@belch ~/launchpad/launchpad $ cat /home/stub/.arch-archives/stuart.bishop\@canonical.com/launchpad/launchpad--devel/launchpad--devel--0/patch-271/checksum | gpg --verify-files - [07:18] gpg: Signature made Mon 18 Oct 2004 18:35:14 EST using DSA key ID BAC6374A [07:18] gpg: Good signature from "Stuart Bishop " [07:18] gpg: aka "Stuart Bishop " [07:18] gpg: aka "Stuart Bishop (dropbear.id.au Domain Admin) " [07:18] gpg: aka "Stuart Bishop (Work) " [07:18] gpg: aka "Stuart Bishop (Work) " [07:19] ah [07:20] nm [07:20] that looks fine to me [07:20] jblack: can you see anything? [07:21] lets md5 the files, and see which one mismatches. [07:21] maybe its a doublecacherev or something. [07:22] nah [07:22] that would spit out a different error [07:22] stub: can you try patch-270 [07:22] please ? [07:22] stub@belch ~/tmp $ md5sum /home/stub/.arch-archives/stuart.bishop\@canonical.com/launchpad/launchpad--devel/launchpad--devel--0/patch-271/checksum 3fef8a3397c50797399d9a7956df99a9 /home/stub/.arch-archives/stuart.bishop@canonical.com/launchpad/launchpad--devel/launchpad--devel--0/patch-271/checksum [07:23] just cat-archive-log ... patch-270 [07:23] invalid syntax... [07:23] yup [07:24] stub: works ? [07:24] No - invaid revision name error [07:24] tla cat-archive-log stuart.bishop\@canonical.com/launchpad--devel--0--patch-270 [07:24] stub@belch ~/launchpad/launchpad $ tla cat-archive-log launchpad--devel--0--patch-270 [07:24] ******************************** [07:24] INVALID CHECKSUM FILE SYNTAX FOR REVISION! [07:24] archive: stuart.bishop@canonical.com [07:24] revision launchpad--devel--0--patch-270 [07:24] checksum file: checksum [07:24] ******************************** [07:24] trouble reading checksum file for stuart.bishop@canonical.com/launchpad--devel--0--patch-270 [07:24] ok that works for me on chinstrap. [07:24] so its /not/ a f*cked archive. [07:25] its almost certainly a f*cked gpg check rule [07:25] I havn't mirrored it since it was working [07:25] patch-270 is on chinstrap. [07:25] else if (file_contents && arch_pfs_memoize_checksum_file (arch->arch.name, [07:25] arch->arch.official_name, revision, file_contents)) [07:25] else if (file_contents && arch_pfs_memoize_checksum_file (arch->arch.name, [07:25] arch->arch.official_name, revision, file_contents)) [07:25] which is why I asked you to check it. :) [07:25] And the gpg check rule works file if I checkout someone elses stuff from chinstrap [07:25] ls ~/.arch-params/signing [07:26] so arch_pfs_memoize_checksum_file is returning 1. [07:26] stub@belch ~/launchpad/launchpad $ ls -al ~/.arch-params/signing/ [07:26] total 28 [07:26] drwxr-xr-x 2 stub stub 4096 2004-10-19 14:54 . [07:26] drwx------ 4 stub stub 4096 2004-09-23 05:02 .. [07:26] -rwxr-xr-x 1 stub stub 22 2004-10-19 15:03 =default [07:26] -rwxr-xr-x 1 stub stub 131 2004-10-19 15:03 =default.check [07:26] -rw-r--r-- 1 stub stub 28 2004-09-23 05:04 stuart.bishop@canonical.com-MIRROR [07:26] -rw------- 1 stub stub 183 2004-10-19 14:54 tla-gpgout.IYPB0S [07:26] -rw------- 1 stub stub 183 2004-10-19 14:53 tla-gpgout.OxzwWn [07:27] stub: try this. [07:27] tla cat-archive-log stuart.bishop\@canonical.com-MIRROR/launchpad--devel--0--patch-270 [07:27] if that works, your local disk has gone wonky in some respect. [07:28] if that doesn't work, its almost certainly gpg related, and we can check by making your check script a no-op. [07:28] stub@belch ~/tmp/foo $ tla cat-archive-log stuart.bishop\@canonical.com-MIRROR/launchpad--devel--0--patch-270 [07:28] Revision: launchpad--devel--0--patch-270 [07:28] Archive: stuart.bishop@canonical.com [07:28] Creator: Stuart Bishop [07:28] Date: Mon Oct 18 16:49:54 EST 2004 [07:28] Standard-date: 2004-10-18 06:49:54 GMT [07:28] Modified-files: lib/canonical/launchpad/database/person.py [07:28] lib/canonical/launchpad/scripts/nicole/database.py [07:28] lib/canonical/librarian/storage.py [07:29] lib/canonical/lucille/TagFiles.py test_on_merge.py [07:29] New-patches: stuart.bishop@canonical.com/launchpad--devel--0--patch-270 [07:29] ok, this is kinda weird. [07:29] Summary: Tabnanny putting on her jackboots for the whitespace impared [07:29] Keywords: [07:29] I also just created a fresh archive locally and it is working fine for some simple tests. [07:29] lifeless: arch_pfs_memoize_checksum_file is failing one of two regexes. [07:29] You want I tar up my archive and email it to you? [07:29] stub: I'd like you do copy down the checksum file from patch-270 on chinstrap, and compare it locally. [07:30] I have to leave shortly for the stug group I'm talking at tonight. [07:30] so mailing to me won't do you much good. [07:30] jblack: yeah [07:33] stub@belch ~/tmp/foo $ scp chinstrap.warthogs.hbd.com:/home/warthogs/archives/stuart.bishop@canonical.com/launchpad/launchpad--devel/launchpad--devel--0/patch-270/checksum checksum270.chinstrap [07:33] checksum 100% 434 0.4KB/s 00:00 [07:33] stub@belch ~/tmp/foo $ diff checksum270.chinstrap /home/stub/.arch-archives/stuart.bishop\@canonical.com/launchpad/launchpad--devel/launchpad--devel--0/patch-270/checksum [07:33] stub@belch ~/tmp/foo $ [07:33] They are identical [07:33] ok, now that is plain old bizarre [07:34] Brought to you by the user who first broke star-merge :-) [07:34] jblack: can you please follow this through ? [07:34] I can try, but I'm rather lost. [07:34] ok, summary: [07:35] he can't access the revision ...-patch-270 [07:35] locallay [07:35] but he can remotely. [07:35] but he can when he does it via -MIRROR [07:35] and the checksum is identical [07:35] we haven't had stub cross-check the md5s in the checksum against the files on disc. [07:35] (stub can you do that now) [07:36] I would qualify that to 'I can't access any of the revisions or branches I have tried in that archive' [07:36] launchpad--devel--0, cookiecrumbler--canonical--, etc. [07:36] stub: can we disclude obvious stuff, like you haven't played with permissions? [07:37] Permissions on the archive look fine and I havn't messed with them [07:37] in fact there is an interesting idea, stub if you have sshd running, you could register the local archive via sftp and see if that fixes it. [07:37] And I have disk space [07:39] Nope - I get the same checksum error if I access it via sftp [07:39] Its failing on either the revision, or on the official_archive search. [07:39] could it be that the checksum is saying its for a different archive than the name the archive is registered as? [07:39] stub@belch ~ $ tla register-archive stuart.bishop@canonical.com-SFTP sftp://localhost/home/stub/.arch-archives/stuart.bishop@canonical.com [07:39] stub@belch ~ $ cd tmp [07:39] stub@belch ~/tmp $ tla get stuart.bishop@canonical.com-SFTP/launchpad--devel--0 [07:39] Password: [07:39] * ensuring library has stuart.bishop@canonical.com-SFTP/launchpad--devel--0--patch-271 [07:39] ******************************** [07:40] INVALID CHECKSUM FILE SYNTAX FOR REVISION! [07:40] archive: stuart.bishop@canonical.com-SFTP [07:40] revision launchpad--devel--0--patch-271 [07:40] checksum file: checksum [07:40] ******************************** [07:40] trouble reading checksum file for stuart.bishop@canonical.com-SFTP/launchpad--devel--0--patch-271 [07:40] stub@belch ~/tmp $ [07:40] stub, please stay with the cat-archive-log ....-patch-270 as the test [07:40] as 270 is known good, 271 isn't. [07:40] you may have several things wrong. [07:40] For your mirror, what is =meta-info/name ? [07:41] stub@belch ~/tmp $ tla cat-archive-log stuart.bishop\@canonical.com-SFTP/launchpad--devel--0--patch-270 [07:41] Password: [07:41] ******************************** [07:41] INVALID CHECKSUM FILE SYNTAX FOR REVISION! [07:41] archive: stuart.bishop@canonical.com-SFTP [07:41] revision launchpad--devel--0--patch-270 [07:41] checksum file: checksum [07:41] ******************************** [07:41] trouble reading checksum file for stuart.bishop@canonical.com-SFTP/launchpad--devel--0--patch-270 [07:41] jblack: My mirror on chinstrap you mean? [07:42] jblack: very interesting that sftp access to the local one also fails. [07:42] lifeless: Yeah. [07:42] so the same code path, with the two archives, fails. [07:42] and the checksum files are the same. [07:43] I'll butt out now. [07:43] To restate, he can get from his mirror, but not from his original archive. [07:43] following the tla code is probably the right thing. :0 [07:43] stub: =meta-info/name for both, please [07:43] jblack is there a tla command to show that? [07:44] tla meta-info-file or something right ? [07:44] not listed in the help. [07:44] Am I supposed to have ~/.arch-archives/stuart.bishop@canonical.com/=meta-info ? If so, that might be the problem. [07:44] I seem to remember that ddaa uses something with pyarch though... [07:45] there's a cmd-archive-meta-info.c [07:45] stub: erm YES YOU ARE [07:45] lifeless: Ok. Then we have found the cause. It aint there. [07:45] stub: copy the \=meta-info dir from chinstrap to yours [07:46] lifeless: And that's why the regex fails. :) [07:46] then remove the single file called 'master' [07:46] sorry, 'mirror' [07:46] jblack: yup. [07:46] what a mindblowing bad error-report from tla. [07:46] Oh, I don't think so. [07:46] Well, yeah. [07:46] yeah, that should be 'corrupt arhcive' right from the get go. [07:47] But a reasonable screw up. The only way for =meta-info not to be there is for someone or something to rm it. [07:47] Should I nuke the mirror file in there on my local copy? [07:47] ack on the screwup bit. [07:47] stub: yes, only in the local copy [07:47] don't alter anything on chinstrap [07:48] stub@belch ~ $ tla cat-archive-log stuart.bishop\@canonical.com/launchpad--devel--0--patch-270 [07:48] Revision: launchpad--devel--0--patch-270 [07:48] Archive: stuart.bishop@canonical.com [07:48] Creator: Stuart Bishop [07:48] Date: Mon Oct 18 16:49:54 EST 2004 [07:48] Standard-date: 2004-10-18 06:49:54 GMT [07:48] Modified-files: lib/canonical/launchpad/database/person.py [07:48] lib/canonical/launchpad/scripts/nicole/database.py [07:48] lib/canonical/librarian/storage.py [07:48] lib/canonical/lucille/TagFiles.py test_on_merge.py [07:48] New-patches: stuart.bishop@canonical.com/launchpad--devel--0--patch-270 [07:48] Summary: Tabnanny putting on her jackboots for the whitespace impared [07:48] Keywords: [07:49] yay [07:49] I suspect I should rsync from chinstrap to ensure nothing else is missing? [07:49] stub: check the new imports and so on. === jblack grumbles something about "Don't go into archive dirs and changing/removing files" [07:49] no, don't [07:49] that will bring across archive lock dirs [07:50] any imports/commits during this period, you should check the checksums for (null) [07:50] if they have (null) replace it with the archive name, and regenerate the gpg signature around it [07:50] just make sure you have name and signed-archive in =meta-info on both. [07:50] jblack can help if you need ot do that [07:50] lifless: Oh, and that explains the (null) too. [07:50] exactly [07:51] permitting that in the first place is a major bug IMO [07:51] I've already got up a postit to do more =meta-info checks [07:51] I'm not worried about recent commits or anything, since none of them worked :-) More that whatever nuked =meta-info might have nuked bits and pieces elsewhere (although I supposed the checksums should see to that now they are working) [07:52] stub: Ok. Cheat. [07:52] steal tla's archive check script. [07:52] That will sanity check the archive. [07:52] =gpgcheck.awk or somesuch. [07:52] that doesn't check the archive tough IIRC - it only checks for gpg issues [07:53] wouldn't have helped here. [07:53] it doesn't check md5s? [07:53] sure doesn't. [07:53] no, its a wrapper script. [07:53] Oh. I know. :) [07:53] really lazy way. [07:53] Hmm... the most reasonable explanation for it missing is my fingers slipping when I was removing branches trying to get my import working nicely (although I can't think how I managed to only remove a single file rather than the entire damn archive) [07:53] try a get on every branch in your archive. [07:55] omg StringIO is slow [07:55] mkdir test; cd test; tla abrowse stuart.bishop@canonical.com | grep -- --.*-- | xargs -n1 tla get [07:56] lifeless: You know about cStringIO ? [07:56] jblack: ta. I didn't want to have to figure that out myself :-) [07:56] stub: nope faster I presume ? [07:56] if any of the gets fail, then we'll fix it. If not, you're gtg [07:56] lifeless: Yes - part of the standard library. Doesn't handle unicode strings though. [07:57] how much faster? [07:57] While you're getting, I'm going to hit the local denny's for coffee and a burger, ok? [07:57] Lots and lots faster [07:57] (thats a technical term) [07:57] like x86 over os x faster ? [07:57] lots n lots daddy [07:58] Just use 'from cStringIO import StringIO' instead of 'from StringIO import StringIO' [08:01] stub: if you have a problem doing those gets, send email to jblackphone@linuxguru.net with a short ( <100 character) message ? [08:05] Gets all ran fine except for one dummy branch I created to to help diagnose the problem, now nuked. [08:06] ok. then you're cleared for flight === justdave [~dave@24.247.63.44.gha.mi.chartermi.net] has joined #launchpad === ddaa [~ddaa@nemesis.xlii.org] has joined #launchpad [09:52] Hello launchers. === lulu [~lu@host217-37-231-28.in-addr.btopenworld.com] has joined #launchpad === limi [~limi@host217-37-231-28.in-addr.btopenworld.com] has joined #launchpad === Kinnison [~dsilvers@haddenham.pepperfish.net] has joined #launchpad [10:40] Morning === carlos [~carlos@69.Red-80-33-181.pooles.rima-tde.net] has joined #launchpad [10:57] morning === sabdfl [~mark@host217-37-231-28.in-addr.btopenworld.com] has joined #launchpad [10:58] Morning sabdfl [10:58] morning all [10:58] lifeless: around? === ..[topic/#launchpad:sabdfl] : lunchpad: home of the sandwich artists | fogo na bomba | "qorking along happily, egged on by SteveA" [11:02] mmmm eggs [11:03] arch help, anyone? [11:03] ddaa? [11:04] is it scary stuff, or might I be able to help? [11:04] scary stuff [11:04] signature and checksum failures [11:05] merfle === ..[topic/#launchpad:sabdfl] : lunchpad: home of the sandwich artists | fogo na bomba | "qorking along happily, with SteveA egging us on" [11:07] Kinnison: is your "drop my changes rather than everyone elses changes" star-merge script on the wiki? [11:07] has it been blessed by an arch god? [11:07] no and no [11:07] 'k [11:07] a version which doesn't automatically check for conflicts is in launchpad/utilities/arch/dsilvers [11:07] but it is not blessed [11:08] isn't the default in launhcpad now to refuse commit if you have .orig or .rej lying around? [11:08] one of stub or spiv was playing with that. I don't know if they committed it [11:09] unrecognized ^.*(\.orig|\.rej)$ [11:09] Looks like it is in [11:09] Not me - I don't know arch that well [11:09] Today, I will be mostly generating override files [11:10] morning stub [11:10] sabdfl: I, jblack and bob2 are just out of team meeting. [11:10] ok [11:10] we have.... limi arch problems! [11:11] yay! [11:11] he was using tla 1.2.0 on ppc, now upgraded to 1.2.1 [11:11] limi! There you are. I have more questions for you on that subject. [11:11] just tagging off lp--devel--0 is failing [11:11] with checksum errors, inode errors, signature verification errors, it's a mess [11:11] have blown away the revision library [11:11] Really. === ddaa suggests using 1.2.2rc2 that's definitely what works best [11:12] and tagged off launchpad--devel--0 into an entirely new branch, and even that did not work [11:12] it's not official by any mean, but it's the best release around. [11:12] it's not available for ppc afaik [11:12] sabdfl: It builds on ppc. [11:12] but that probably won't fix these problems. [11:13] Lets hit it a step at a time. [11:13] limi, are you here? [11:13] yup [11:13] Which archive is this you're having problems with? Yours, or rocketfuel's ? [11:13] how can I find out? :) [11:14] by telling me which one you're trying to get from. === ddaa leaves the matter in jblack's competent hands, but will be monitoring. [11:14] i did tla tag -S rocketfuel@canonical.com/launchpad--devel--0 a.l@canonical.com--2004/launchpad--devel2--0 [11:14] to get a brand new branch that limi could work on without disturbing previous branches [11:15] and error msg is: [11:15] it failed [11:15] INVALID SIGNATURE ON REVISION! [11:15] archive: rocketfuel@canonical.com [11:15] revision launchpad--devel--0--patch-248 [11:15] checksum file: checksum [11:15] last night, we were getting similar messages on the old branch too, during star-merge [11:15] sabdfl: You were tagging in limi's archive? Are you guys in the same place or something, or did you mirror him and then drop the mirror file? [11:16] jblack: i'm sitting next to him, typing on his computer [11:16] Ok. Maybe his signature checker is wrong. [11:16] first, can he get from rocketfuel, such as "tla get rocketfuel@canonical.com/launchpad--devel--0" ? [11:16] works for about 280 patches, then fails? [11:17] would you remember the patchnumber? [11:17] trying to do it again with 1.2.1 now, seems to get further [11:18] Ok. To what revision in 1.2.1 ? [11:19] still working [11:19] ok, seems to have got as far as starting to do the patches this time [11:19] 1.2.1 seems better than 1.2.0 === jblack smiles happily hearing that. [11:22] jblack: what's the latest public release of tla? [11:22] There's two, the one I did, and then the one Tom did. [11:23] The lastest one I made was 1.2.2rc2 === lifeless_ [~robertc@dsl-69.8.240.220.rns01-kent-syd.dsl.comindico.com.au] has joined #launchpad [11:23] and toms? [11:23] his hosed 1.2.1 [11:24] there are two 1.2.1, jblack's, on tom's. jblack's is the good one. [11:24] There's a big problem in his 1.2.1. He took some patches that weren't ready yet that is a bit too severe with truncated checksums. === jblack waves to lifeless. [11:24] limi: still getting? [11:25] so, current sane tla = 1.2.2rc2 [11:25] jblack: so if limi is using 1.2.1 which version of 1.2.1 is he using? [11:25] and why do we only have 1.2 in warty? [11:25] jblack: still getting [11:25] Yeah. There's a small bug in 1.2.2rc2, but it only affects 10% of the people in 10% of the time, and in a safe way. [11:25] sabdfl: I'll defer to lifeless on that. [11:26] Actually, I won't. [11:26] sabdfl: probably because asuffield, who is the debian maintainer, tracks tom. [11:26] Lifeless and I are avoiding a power struggle with Tom. [11:26] The arch release process is just starting to get going again. [11:26] If we start pushing a fork, we throw everything back into chaos. [11:26] ok, we're still going to do a public integration / community build right? [11:27] as discussed? [11:27] I've still got plans for that, yes. [11:27] spiv: around? [11:27] (spiv/#launchpad) sabdfl: Just waking up, yeah. [11:27] And I'll act on that if you wish, but my recommendation is to wait about 3 weeks, and give the new merge process a fair shot. [11:28] this came in last night, was it from you? [11:28] @@ -132,7 +135,8 @@ [11:28] return { [11:28] 'id': personID, [11:28] 'displayname': displaynameOrig, [11:28] - 'emailaddresses': list(emailAddresses) [11:28] + 'emailaddresses': list(emailAddresses), [11:28] + 'salt': saltFromDigest(sshaDigestedPassword), [11:28] } [11:28] def changePassword(self, loginID, sshaDigestedPassword, [11:28] jblack: if there's a new merge process let's pursue that [11:28] (spiv/#launchpad) sabdfl: Yep. [11:28] Yes sir. I'll make sure you're up to date as to how its working out. [11:29] but i'm losing patience with tom w.r.t. arch, and am starting to think it's inevitable that we put out a regular release [11:29] a little competition is healthy, as you've seen [11:29] it's not making any public progress yet, but it's not right time to step out with a new integration branch. That could be perceived as sabotage. [11:29] (still patching) [11:29] sabdfl++ [11:29] Is the existing arch community large enough that its perceptions actually matter? [11:30] ddaa: yes, and has to be handled carefully, but tla has stagnated and unless this new process gets it going i'll risk that perception in favour of actually getting the tool usable [11:30] sabdfl: I'm agree with you. But the timing isn't quite right. If we push at this exact moment, we may not carry the community with us, and then you're paying for a lot of development you could otherwise get for free. [11:30] spiv: where is the salt getting used? [11:30] (spiv/#launchpad) sabdfl: It's handed back to the XML-RPC caller. [11:30] jblack: understood, keep me posted [11:30] spiv: why? [11:31] (spiv/#launchpad) I added it there to be consistent the return value from everywhere else. [11:31] we should never expose salt [11:31] stub: i'm not sure what you mean. Tla is defined by what tom puts on gnu.org. And gets some non-trivial public coverage. [11:31] (spiv/#launchpad) sabdfl: The salt is the only way the caller can generate a matching digest. [11:31] SteveA and i discussed this at length and agreed to change the protocol [11:31] the caller should not be generating the digest [11:31] the caller gives credentials (username, password) and you then calculate the match yourself [11:31] (spiv/#launchpad) Then the caller needs to send the password cleartext. [11:32] (spiv/#launchpad) I'm happy for that to change, but it's the first I've heard of it :) [11:32] (spiv/#launchpad) It'll also need changes on Roche's end. [11:32] spiv: either use tls, or public key encrypt the credentials in transit, at your option, but don't expose the salt [11:32] i nearly fell off my chair when i realised we were passing the salt around [11:33] (spiv/#launchpad) sabdfl: I'm not sure why exposing the salt is such a big problem? [11:33] spiv: salt is there as a last-minute defense [11:33] no sense in giving it away [11:33] limi: still going ? [11:34] just finished [11:34] so you're good? [11:34] * Made cached revision of alexander.limi@canonical.com--2004/launchpad--devel2--0--base-0 [11:35] Ok. Are you using libraries? [11:35] spiv: your other option is to store the username and password in the clear [11:35] "How can I find out?" [11:35] If not, we should set you up with sparse greedy libraries. That'll speed you up dramatically. [11:35] :] [11:35] then to generate a random salt for every connection [11:35] pass that salt to them [11:35] have them also generate a salt [11:35] I think I am running greedy sparse [11:35] ddaa: Let me put it this way - if arch split into gnu-arch and sane-arch, and worst case every arch user outside of cononical stuck with gnu-arch, would sane-arch still attract more users over the long term? If sane-arch actually has a measurable uptake (unlike gnu-arch), it will smother it. I suspect a split might encourage new people to come over to arch (or refugees from arch comming back). [11:35] (dilys/#launchpad) Bug 1918 resolved: implement XML-RPC authentication server [11:35] (dilys/#launchpad) https://bugzilla.warthogs.hbd.com/bugzilla/show_bug.cgi?id=1918 [11:35] then they send you their salt plus the digest of credentials and both salts [11:35] type tla my-revision-library. Do you get a directory? [11:36] jblack: sabdfl rm'ed the lib because they had a inode corruption errors. [11:36] (spiv/#launchpad) sabdfl: I'm not sure that a salt from both ends makes sense there -- surely in that case the salt is only good to protect against replay attacks? [11:36] $ tla my-revision-library [11:36] $ tla my-revision-library [11:36] /opt/local/bin/revision-library [11:36] /Users/limi/Work/Canonical/revision-library [11:36] spiv: user generates own salt to reduce dictionary attacks by man in the middle [11:36] Ok. for both of those, type "tla library-config " [11:37] And just to make sure, neither of those are on nfs, right? [11:37] stub: you only want to make a split if the company is willing to invest a substantial amount of the arch team time into developing it. [11:37] say a mitm send you a carefully crafted salt, which when used as a salt will in fact expose the credentials [11:37] st [11:37] you generate your own random salt [11:37] (spiv/#launchpad) sabdfl: That's sounding excessively complex for note enough gain to me... we should just go for ssl/tls in that case. [11:37] that way you *know* your credentials are never exposed [11:37] stub: besides it's probably better to avoid such a solution as long as possible. [11:37] * library /Users/limi/Work/Canonical/revision-library [11:37] greedy? yes [11:37] sparse? yes [11:37] spiv: i'm not telling you what to do, just telling you what your options are [11:38] $ tla library-config /opt/local/bin/revision-library [11:38] tla: indicated library is not on library path [11:38] dir /opt/local/bin/revision-library [11:38] (spiv/#launchpad) sabdfl: Sure. Just giving my opinion on the options :) [11:38] thawte.com school of cryptography [11:38] LOL! I suppose you would an authority. :) [11:39] (spiv/#launchpad) SSL would be easy to do on the server end. I'm not sure how easy it is to do on the client end with out-of-the-box xmlrpclib, but I'm sure it can be done. [11:39] jblack: a signing authority in that case :-P [11:40] limi: Sorry. Missed your answer. [11:41] Ok. I suggest going to sparse greedy libraries. [11:41] and I'd remove the library that doesn't exist as well. [11:42] tla library-config --sparse /Users/limi/Work/Canonical/revision-library [11:42] tla my-revision-library -d /opt/local/bin/revision-library [11:44] jblack: the lib was already greedy sparse :-) [11:44] and now it'll be extra sparse! [11:44] (sorry limi. Getting tired on this side) [11:45] thanks, seems things are under control again [11:45] Ok. [11:45] You know how to reach me for emergencies? === ddaa missed what was done to fix the checksum errors [11:48] he went from 1.2.0 to 1.2.1, and the problem magically disapeared. [11:50] just as a reminder, if you need to reach me during an emergency, send a short ( < 100 character) email to jblackphone@linuxguru.net [11:51] chances are good (but not 1.0) that I'll respond. [11:54] duh! [11:55] That code cannot possibly work for syncs!!! [12:06] lifeless_: CSCVSStrategy.sync is emphy [12:06] is that normal, or is that result of some error? [12:07] jblack: thanks [12:07] How can syncs possibly work if the .dir, .aJob and .logger instance variables are not set? [12:07] ddaa: we also blew away my entire local setup before upgrading to 1.2.1 [12:07] lifeless_: I'm going to examine the history, but you might save me some time. [12:08] limi: next time you have some time, upgrade to 1.2.2rc2, it's significantly better in the error reporting dept. [12:09] well, I tend to stick to what's available in my ports tree [12:09] compiling arch was non-trivial the last time I tried it [12:10] ha... OS X.. last time I looked (back in the texmacs days) compiling random unix stuff just did not work. The build system apparently required some black magic... [12:11] Since that, I no longer buy it when someon says "osx is just a bsd variant" [12:11] in my experience it's a horribly mutilated bsd variant if anything [12:11] (but maybe the situation have improved) [12:12] *has improved [12:12] what's the shell magic to say "if there's a .rej or .orig file"? [12:12] it has [12:12] only arch that doesn't build ;) [12:13] FOO=`find . -name "*.rej" -o -name "*.orig"` [12:13] sabdfl: you prolly want something along "tla inventory -b | egrep -e '\.(rej|orig)$'' [12:13] if [ "x$FOO" = "x" ] ; then [12:13] # no .rej or .orig [12:13] else [12:13] Kinnison: no find, tla inventory [12:14] # some .rej or .orig [12:14] fi [12:14] ddaa: feh; no context == generic answer :-) [12:15] sabdfl: unless that's one of those trees where rejects are classified as unrecognized, spiv did that to launchpad at a point. [12:15] Kinnison: thanks [12:15] I dunno if it was reverted. [12:15] so find doesn't give a useful exit code? [12:15] In that case it would be "tla inventory -u" instead of -b [12:16] sabdfl: egrep does, and tla inventory saves you the traversal of {arch} [12:17] just "tla inventory" w/o option would do it as well in your case. [12:19] if tla inventory -b | egrep -e '\.(rej|orig)$ ; then ; else ; fi [12:19] ooops [12:19] if tla inventory | egrep -e '\.(rej|orig)$' ; then ; else ; fi === ddaa realizes he was probably inaccurate with this statement about not traversing {arch} [12:26] does make check give a useful result code? [12:26] Yes, pqm relies on it. [12:30] stub: how do I set up the plpython stuff? [12:32] stub, BradB|away: we've got limi up again but can't test anything till we get plpython running [12:32] on macosx [12:32] any tips? [12:39] i guess we need to rebuild postgres [12:40] with python support [12:40] comment it out of the makefile [12:40] they're not *needed* for now IIRC [12:46] what was the resolution for finding a python apt_pkg on macosx? [12:59] sabdfl: fink.sf.net [01:03] carlos: thanks [01:03] limi: can you look for python-apt on fink? [01:03] Running the makefile with the plpython commented out should work - it just means some database constraints won't exist atm. [01:04] I need to install fink then - but, sure [01:04] I'd suggest seeing if DarwinPorts (which I think limi is already running) has the python stuff though - I never had much success with fink's postgresql stuff (it never got out of unstable for a start) [01:06] I tried, only found the ruby bindings in DP [01:07] stub: we found an apt in darwin ports, not sure if that has hte python-apt module === limi is not a big fan of fink either [01:07] It would also be trivial to remove the dependancy on it at this stage - it just restricts us a bit in the future and means we will start having pl/sql code in the codebase [01:07] plpython wasn't too hard [01:07] (if it works :) [01:07] but it's python-apt which the soyuz guys use which we now need to solve [01:08] limi: What is the error message you get when it tries to run createlang? There is a chance it is installed and something else is going wrong [01:08] could be permissions again, though limi is running pg_ctl start as his local user, so he should be postgres superuser too right? [01:09] createlang? haven't seen that error msg [01:09] darwinports seems setup to let you do everything as the localuser. === limi is downloading Fink to look for py-apt [01:10] Please someone who has access to the production database tell me the output of: [01:10] createlang is the command the makefile runs to make plpythonu available in the launchpad_test database. If the error message is from something else, it isn't a plpythonu problem [01:10] select name, cvsroot from sourcesource where name like 'zenity%' ; [01:11] and then "select * from sourcesource where name like 'zenity%'" [01:11] (spiv/#launchpad) ddaa: zenity-HEAD-import.job | http://chinstrap.warthogs.hbd.com/~jdub/cvsballs/zenity.tar.bz2 [01:12] zenity-HEAD-import.job | http://chinstrap.warthogs.hbd.com/~jdub/cvsballs/zenity.tar.bz2 [01:12] spiv: and what are all the fields? [01:12] (spiv/#launchpad) ddaa: More than I'd like to paste on IRC ;) [01:13] (spiv/#launchpad) privmsg? [01:13] spiv: then paste on jabber please [01:13] (spiv/#launchpad) Jabber, ok. [01:13] q [01:18] ddaa: any idea how the backbuilder stuff is going? [01:24] abentley is using it for himself, but it's not being merged because it was not regression-tested. [01:24] And if/when it breaks, it would break silently and severely (data loss) [01:24] merp === ddaa is out for lunch [01:25] what's the backbuilder? [01:25] It an extension to allow tla to build patch-X from patch-(X+1) by reverse-application of patches [01:26] AIUI [01:26] actually, from patch-(X+N) and even across version boundaries. [01:27] hairy, and in a critical part, so to be handled with extreme caution. [01:27] Kinnison: btw, what's "merp"? [01:29] ddaa: it's a noise word [01:29] ddaa: say it out loud with a high-pitched voice [01:29] ddaa: Like 'meep' or 'erk' only different :-) === debonzi [~debonzi@200.158.100.251] has joined #launchpad [01:33] carlos: any idea what to look for in fink for python-apt? is it in unstable only? [01:33] sabdfl: no idea, I'm not using fink, I just know about it, sorry === Kinnison loves approaching code the day after === Kinnison deletes two pointless classes; alters the SQL views and merges all the publishing logic into one place [01:35] the joy of sleep [01:35] Indeed. This way there isn't pointlessly duplicated code [01:35] and SourcePackagePublisher/BinaryPackagePublisher get collapsed into what was originally just a base class... Publisher [01:35] (all in canonical.lucille of course) === cprov [~cprov@200.158.100.251] has joined #launchpad [01:41] stub: do we want someone to be able to have multiple subscriptions to the same bug? [01:41] watch / cc / ignore? [01:41] i think we should make (bug, person) UNIQUE [01:41] That depends on the behaviour of 'cc'. If you have 'cc' and you automatically get the same behaviour as 'watch' as well, then yes. [01:42] what is the difference between watch and cc? [01:42] (erm... yes... make it unique) [01:42] My interpretation is that watch makes the bugs appear on your reports (when they exist. The dashboard, 'my bugs' etc.). CC means you get emailed about all changes to that bug. [01:43] Can someone else add you to CC without necessarily knowing you're watching the bug? [01:43] we could define the apropraite behaviour === Kinnison is concerned that while they have equivalent results; the two concepts are sufficiently different that you should allow both at once [01:44] E.g. you might be watching all bugs in a given package yes? But that means something different to explicitly being in the CC list on a bug doesn't it? [01:46] CC would be Watch with extra behaviour. Watching all bugs on a given package would be stored in a seperate table if implement that behaviour. [01:46] what stub said [01:47] relationship between person and package is different to that between person and bug [01:48] I'll go make it unique. We can replace it with a more lax constraint in the future if we implement more complex subscription types. [01:48] okay === Kinnison just thought he should pipe up in case :-) [01:49] cc is watch + email, i figure [01:49] stub was that you that fixed the subscriptions portlet? [01:49] No - that was Brad I think [01:50] We're using SQLObject 0.6 these days; aren't we? [01:50] It was working just fine last time I played with that one ;) [01:50] Kinnison: yes [01:50] coolie [01:50] stub: 0.6 does non-integer IDs as follows [01:50] in your class, put _idType = str [01:51] wallow in the joy === Kinnison now has almost certainly unique and non-specious id columns in his package publishing views [01:55] Can someone run 'make test' and let me know if there are a heap of failures bitching about not being able to find the Utilities component? === stub runs it himself from a rocketfuel checkout [02:01] Hmm.. those tests already broken. Cool... I guess... ;) [02:06] stub: what is the result of the following command on the production database? [02:06] select count(*) from sourcesource where cvsroot like '%.tar.%' or cvsroot like '%.tgz'; [02:08] ddaa: You want a snapshot of the production database btw? There are hourly backups being made and I'm happy to push them somewhere as long as Mark, Elmo & Thom have no objections to where the data is escaping too. === stub runs the query [02:08] ddaa: 332 [02:09] Bad news. 332 rows of the sourcesource table have broken data. [02:09] Good news. We are going to fix it. [02:10] What is the procedure to fix production data? [02:10] generate a sql script to be eyeballed and manually applied? [02:11] Pretty much, yeah. I'm happy to do it or help out, but you probably know the data better. === debonzi_ [~debonzi@200.158.100.251] has joined #launchpad [02:13] elmo: ping? [02:13] ddaa: It doesn't have to be an sql script btw. A Python script would work just as well. [02:13] elmo: can you install man-db on zhongshan please? === Kinnison goes shopping, bbl [02:15] (elmo/#launchpad) Kinnison: what on earth for? [02:15] elmo: for reading of apt-ftparchive manpages [02:15] stub: I would have expected more anal retention... [02:15] elmo: It's irritating to have to have another terminal up :-( [02:15] (elmo/#launchpad) Kinnison: sorry, but you'll need to deal with that - the DC stays minimal [02:15] ddaa: It is easier to get Python code correct that SQL code :-) [02:15] elmo: okay [02:16] stub: sorta makes sense... [02:41] (dilys/#launchpad) Merge to rocketfuel@canonical.com/launchpad--devel--0: Vocabularies should be looked up by name (avoids circular import issues and they get a context too). Rationalize vocabulary/vocabularies package (patch-635) [02:45] stub: i'm going to blast malone/browser.py into ordered parts this afternoon, ok? [02:46] Sure. Subsumed in the launchpad area or separate? [02:50] stub: yes into launchpad browser/ database/ interfaces/ [02:51] there will still be the core MaloneAppView etc in the old location i think [02:53] Hmm... I don't know if there is much point leaving it around. All the database code and the Z3 code is in the one spot, a few minor bits of bootstrap code around elsewhere seems to be a bit of a decoy. [02:54] I guess see how it looks after === debonzi [~debonzi@200.158.100.251] has joined #launchpad [03:01] i tihnk we'll end up with launchpad/browser/malone [03:01] which has just the bootstrap code for malone [03:01] and launchpad/browser/rosetta [03:01] etc [03:02] at some "long distant future" time we may also want to distribute the lp components separately, and that will require a whole new component glue [03:02] elmo: ping [03:02] I wonder if launchpad/launchad/lib/launchpad needs some thought... the swedish chef school of project layout ;) [03:03] dists/launchpad/lib/canonical/launchpad ? [03:03] i'll be someone has canonical/launchpad/launchpad/lib/canonical/launchpad :-) [03:03] bet [03:05] blech. circular imports [03:05] elmo: I request new password on mawson, but I still can't create a DB, either as "sudo -u launchpad .." (inserting crazy rand. gen. pass everytime is an issue, anyway) [03:05] what's the lazy import thing? [03:05] cprov: change your password perhaps? [03:06] SteveA: do you mean via passwd ? (doesn't work ...) [03:07] Stick the import statements in the function that needs it is the work around. [03:07] sabdfl: the lazy import thing is a bit of non-standard magic I cooked up during the soyuz sprint. I don't think it is checked in right now, but the code is around somewhere. [03:07] ok [03:07] hm [03:07] bugs depend on assignments depend on bugs [03:07] cprov: there's a "userdir-ldap" thing you can use to change your password. I don't know how to access it though. [03:08] stub: this BugContainerBase class, is that something you know all about? [03:08] SteveA: https://... stuff ? I saw, but like you, I don't know how to access [03:08] the zope3 way to avoid circular imports is to use adapters and utilities to indirectly refer to objects via the interfaces you need. [03:09] So, everything depends on interfaces, but doesn't have many interdependencies [03:09] Mmm... [03:09] I think I wrote BugContainerBase - yeah. === BradB|away is now known as BradB [03:11] BradB! [03:11] yo! [03:11] BradJIT [03:11] I need your helpful Mac assistance ;) [03:12] apt_pkg and plpython [03:12] how? :) [03:12] aka. python-apt [03:12] limi: apt_pkg: forget it. Just create a stub for the module that has the two names that actually get imported set to None. [03:12] kiko filed a bug for what's wrong with it, but it won't get fixed anytime soon. [03:12] ok [03:12] BradB: can't wait for the soyuz boys to check in their page tests :-) [03:13] limi: plpython: forget it too. :) I always just comment out that part of the Makefile when I work, then uncomment it before I check in again. [03:13] BradB: if you think necessary we can eliminate the apt_pkg dependency [03:13] limi: And, I'm hoping that extra complexity will be dropped, because it's overkill. [03:13] cprov: You'd have to ask sabdfl if it's worth it. [03:14] I see === limi is at one point going to forget that Makefile [03:14] sabdfl: there are some already [03:14] I know, because there's one that always fails for me because of not having apt_pkg. [03:14] is there any way to tell arch to ignore any changes to that file? [03:14] i tihnk the package dependency links are awesome [03:14] sabdfl: what do you think, apt_pkg helps, but it is causing many problems to Mac people, [03:15] limi: You wouldn't want to, because it gets updated somewhat frequently by other people. [03:15] so yes, we can create smarter stubs for MacOSX that return lists etc instead of None [03:15] that should work [03:20] sabdfl: I suggest to write a simple DEB deps parser (that's why we need apt_pkg) and eliminate the dependency intead of write an imporved stub for Mac ..it will be easier and cleaner for everybody [03:20] s\intead\instead [03:22] 'try: import apt_pkg; except ImportError: import stub as apt_pkg' would work for now (and possibly good enough permanenty?) [03:22] (spiv/#launchpad) stub: So long as we can make tests that depend on the real apt_pkg get skipped when it's not available, yeah. [03:22] cprov: [03:22] just use: [03:23] SteveA: Any word on when the page test generator will work again? Malone is costing a fair bit of coin for me to do the same things over and over again, because people are being allowed to checkin code that breaks things that already work, because I can't do page tests for that code due to the bugs filed in Bugzilla. [03:23] So, today again, I have to go through and unbreak vocabularies that are looked up by name that can't be looked up by name, because they're vocabularies, not vocabulary factories. [03:24] defParseDepends(test): [03:24] return [[('macosx', '', '')] ] [03:24] bradb: ^^ [03:24] stub: Your vocab changes to Malone broke every screen that's accessed off a bug, btw. [03:25] Urgh... [03:25] same for ParseSrcDepends [03:25] I think we fix that properly this time then === debonzi [~debonzi@200.158.100.251] has joined #launchpad [03:27] sabdfl: ok, but as spiv said, we'll lack on ftests, btw is there a way to don't consider an
    ...
, or it should be done just by line ? [03:27] sabdfl: Is that basically saying that the given package has no dependencies on a package in os x? [03:31] BradB: it means that the pages will still run [03:31] and we can bypass the ftests for that in macosx [03:31] this is just a stub that will pretend that EVERY package depends on a package called macosx [03:31] for fun [03:32] BradB: what was the magic incantation to build postgres with plpython? [03:32] sabdfl: ./configure --help. it's either to add --with-python, or --enable-python; the former, I think. [03:33] there's no ./configure in the darwin ports dir that i can see? [03:33] Oh, I just d/l'd the source of 7.4.5 [03:34] I think you have to invoke a specific target to get the ports tree to unpack and prepare the source tree [03:34] Kinnison: que? [03:35] lulu: ping [03:35] BradB:pong! [03:36] BradB: How's our cookie issue? [03:36] Kinnison: how do i invoke a specific target? [03:37] lulu: I was just going to ask you if I can go ahead and do it again now. (I have to go grab the patch, but it should be easy this time) [03:37] sabdfl: Not a clue; It's been years since I've used a ports tree [03:37] BradB: Go for it. Thanks Brad. [03:38] lulu: thanks, i'll let you know in the next little bit when everything should be okay. [03:38] BradB: Great! Do we need to log out? [03:40] It'd be better if noone were logged in. It'll probably take me about 10-20 mins to get the patch and check it out before applying it to canonical.com. [03:41] BradB: Ok - I'll log off. Tx! === lifeless_ is now known as lifeless === jblack_ [~jblack@static-209-158-45-74.scr.east.verizon.net] has joined #launchpad === Kinnison pouts at this query doing seqscans which are probably sucky [03:51] oh well; it only takes 600msecs for now [03:51] BradB: did you build with readline support? [03:55] sabdfl: Should be unnecessary unless limi wants to use psql to talk to the database. Readline will be in /opt/local [03:56] how do i tell ,.configure where to look? [03:56] So I take it that it is createlang that is failing when limi tries to build the launchpad database? [03:56] doens't like --with-readline=/path [03:56] stub: yes [03:56] env LIBS=-L/opt/local/lib ./configure blah blah blah [03:57] 'k thanks [03:58] i'm installing postgres *cough* 8.0.0b3 *cough* [03:58] don@t tell limi :-) [03:58] Troublemaker :-) [03:58] will give it a quick shot and see if it works [03:59] we may as well start to cut our teeth on personal machines [04:00] Need to get martin to package it up for hoary packages so it is easy for us to test [04:02] sabdfl: Yeah, I built with readline, I think [04:04] stub: Your Plone changes were only in CMFCore/ presumably? [04:05] Yup - tla changes --diffs stuart.bishop@canonical.com/plone--release--2.0.4 should tell you exactly what (about 3 lines in CookieCrumbler.py and the new cipher.py module) === BradB finds out how long that takes to run [04:07] oh... I can send you the diff [04:08] (dilys/#launchpad) Merge to rocketfuel@canonical.com/launchpad--devel--0: Make vocabulary method produce factories, and move to vocabulary module (patch-636) [04:09] stub: I was just in the midst of undoing your vocab patch on my tree (not being entirely sure if arch will do what I think it should, but...) [04:09] Yes - just CookieCrumbler.py and the cipher.py module === kiko [~kiko@200-206-134-238.async.com.br] has joined #launchpad [04:11] The amount of output coming from a "tla undo foo@bar/baz--patch-123" is definitely a bug. === stub has never tried it === BradB looks through the diffs [04:14] BradB: if you have a revlib/pristine for the specified revision, the output is clean. [04:14] Maybe the revision generation should only produce summary output if that's what you mean. [04:15] Mhh... even then... yes, the changeset should appear twice... once for generation anh once for application. [04:16] Maybe the generation output should be cut off. [04:21] stub: So i guess this patch depends on PyCrypto? :) [04:22] Yes. I thought that would be a better approach than attempting to implement AES myself ;) === SteveA wonders what's wrong with xor and a large one-time pad [04:23] It needs someone who knows this stuff better than me to vet the cipher.py module to ensure I'm not on crack, but is better than what we have atm at least ;-) [04:23] (and a large salt) [04:24] SteveA: Because you know the plaintext (the passphrase) and can reverse the secret from the cipher text. [04:24] hmm -- right, the point is to set a cookie with information that the person knows already. === limi [~limi@host217-37-231-28.in-addr.btopenworld.com] has joined #launchpad [04:26] elmo: Presumably you're the guy to ask to get a python package installed on gentoo? [04:41] SteveA: Should I just install pycrypto somewhere under ~zope, or should I wait until someone can install it system-wide? [04:47] ConfigurationError: ('Invalid value for', 'factory', 'Module canonical.launchpad.vocabulary has no global BugTrackerVocabulary') [04:47] will that go away if I star-merge? === ddaa notes that undo does not display the changeset generation output, only application. [04:48] ddaa: I think that all the output I was seeing was due to having a greedy revlib. [04:50] probably... then I agree this output should be sumarized (only display "* building revision xxxx") [04:51] BradB: python-crypto is in ubuntu, so we should just get that installed on gentoo [04:52] SteveA: okay, i'll email elmo then [04:52] ok. I just asked elmo and thom on #canonical [04:53] but, mail to admins is the "canonical" way to do it [04:53] ok === limi [~limi@host217-37-231-28.in-addr.btopenworld.com] has joined #launchpad [04:55] Okay, make check currently fails === limi fills daf and mako with volcanicity [04:55] Mostly with: ConfigurationError: ('Invalid value for', 'factory', 'Module canonical.launchpad.vocabulary has no global BugTrackerVocabulary') [04:56] anyone know what I can do to fix that? [04:56] (parsing ftesting.zcml -> configure.zcml -> vocabulary/configure.zcml [04:59] macosx has a funnny [04:59] wc [04:59] wc -l [04:59] gives an indented result [04:59] which breaks some of stub's new magic [05:00] how do i get rid of the whitespace before the number? [05:00] sabdfl: yes! [05:00] BradB: any suggestions? [05:00] is this in shell? [05:00] yes === BradB was thinking of sed or awk [05:00] dsilvers@petitemort:~$ echo $(( 500)) [05:00] 500 [05:00] that might help [05:00] i guess i need wc -l | ??? [05:00] to get rid of leading and trailing ws [05:01] what's the ??? foo? [05:01] instead of foo=`wc -l bar` do foo=$((`wc -l bar`)) [05:01] BradB: thom has installed python-crypto on gentoo [05:01] is that /bin/sh? [05:01] SteveA: cool, thanks [05:01] Hmm... is there a way of saying do a numeric comparison so whitespace doesn't matter? [05:01] ah yes, echo `wc -l ...` seems to do the right thing. [05:01] BradB: there's that too actually; good call [05:02] dsilvers@petitemort:~$ dash [05:02] \u@\h:\w$ echo $(( 4500)) [05:02] 4500 [05:02] I guess $(()) is posix shell [05:02] Kinnison: make check is working here.... and I checked in the last changes to vocabulary as far as I know [05:03] BradB: we'll commit from limi's box to verify that he can actually do that [05:04] stub: will you see if there's a better way to check if a db exists? [05:04] also, pg 8.0 bitches if you try to install a language twice [05:05] please could you find a way first to test if the language is installed, and then only try and install if it isn't? [05:05] psql -l is the most trustworthy way I think - the other way is to attempt to connect and catch the error. [05:06] I didn't think the install language would run twice, since the database is being dropped and recreated by default (hmm... unless it has been added to template1...). [05:07] I'll need to drop the makefile and replace with a python script I think, or at least some python helper scripts to use in the makefile. [05:08] stub: Okay; so it's some of my changes magically causing the issue [05:08] stub: Sorry for the noise on-channel === BradB mutters something about converting to a Python-based build process [05:11] (dilys/#launchpad) Merge to rocketfuel@canonical.com/launchpad--devel--0: canonical.arch.infoUpdater, fix sourcesource.cvsroot from info files (patch-637) [05:11] Kinnison: if launchpad out of rocketfuel doesn't start at all, that means the "make check" before merging isn't working. [05:11] this is weird [05:11] stub: you are no longer running Mac OS X? [05:11] SteveA: noted [05:11] the $(()) trick works find at the command prompt [05:11] for both bash [05:12] and bin/sh [05:12] SteveA: unless he doesn't have something that the pqm box does. [05:12] Good or bad mutters? I know they work for me but don't know what other people think. [05:12] It seems that the real error message was "class Interface not defined" [05:12] unless his environent is "broken", yes [05:12] limi: Nope. Had to give my mac back to old work [05:12] Kinnison: didn't compile zope libraries [05:12] but it fails inside the makefile [05:12] sabdfl: what is $(SHELL) ? [05:12] SteveA: Naah; it was that I have 'Interface' somewhere where i meant 'SQLBase' [05:12] stub: Lucky you. :P [05:13] SteveA: 'make check' works now :-) [05:13] cool [05:14] Kinnison: at the command prompt it's bash === stub misses his 17" G4 TiBook [05:14] sabdfl: and in the script? [05:14] appropriately enough, from make it is "HELL" [05:14] sabdfl: $$(SHELL) [05:14] I also miss iPhoto and iCal :-( [05:14] (from make) [05:14] stub: is there any hope for HFS+ though? sometimes i wonder... [05:14] maybe I'm meant to have Panther and UFS [05:15] sabdfl: don't forget to double-up all dollar signs for shell-under-make [05:15] hey, i know so little about make AND shell i'm not worthy of debugging stub's code [05:16] BradB: ufs didn't seem nice when I tried it under 10.0, although I vaguely remember the problems from OS9 apps. I would want to see benchmarks on same hardware/different os before condemning HFS+ though. [05:16] stub: My "muttering" was my hinting that we need a Python-based build process to sanely and easily do the more complex dependency checks we're currently trying to shoehorn (in a cross-platform way) into a Makefile. [05:16] hmm... if i put @ echo $$(SHELL) in the makefile it says: [05:16] And with a Python-based build, we then have a Makefile 10-12 people can maintain, instead of 1-2. [05:17] sabdfl: You think I know what I'm doing??? I learnt when I started sysadmining so I never would have to learn sh, awk etc. and have spend the last 10 years with tcsh as my shell :-) [05:17] /bin/sh: line 1: SHELL: command not found [05:17] BradB: Cool. +1 then :-) [05:17] (ermm... learnt Perl that should be) [05:18] Yeah, Perl precludes me from knowing all the different little shell programs that people actually still, well, use. [05:25] stub: ok, the magic incantation appears to be: [05:26] @if [ "$$((`psql.... [05:26] @if [ "$$((`psql -l | grep ${TEST_DBNAME} | wc -l`))" = '1' ] ; \ [05:26] then dropdb ${TEST_DBNAME} ; \ [05:26] fi [05:26] heh heh [05:27] I suggest keeping the makefile strictly to handle dependencies, and using python scripts for the rest. That is, the makefile targets are just python scripts. That's what I did for test_on_merge.py and make check. [05:27] it may be more verbose, but it is easier to understand, and less prone to sh-jockies writing incomprehensible stuff in the makefile. [05:30] why would a fresh pull of rocketfuel have test errors? [05:30] it won't [05:30] it does [05:30] not page test errors, anyway [05:30] yes [05:30] have you installed all the things required? [05:30] is it on a machine that has run launchpad before? [05:32] sabdfl: What are the errors? :) [05:32] it's db integrity error's during the page tests [05:32] it seems as though it's running the page tests against a db that already has the page test data in it [05:32] que? [05:33] IntegrityError: ERROR: duplicate key violates unique constraint "productrelease_pkey" [05:39] sabdfl: what if you manually reset the DB and run make check? [05:40] (e.g. i don't rely on the make check rule properly resetting the DB here, because it doesn't seem to reset it properly on OS X, due to the indent issues with wc and such.) [05:41] is this the optimisation recently introduced by stub not working on OS X? [05:45] SteveA: there are rules that are broken in the top-level and schema Makefile, and dependencies that have been introduced that break things on OS X (e.g. plpython), which would indicate that they were probably made by someone who wasn't working on OS X, if that's what you're asking. :) [05:45] would A-A-P be an alternative to make? http://www.linuxjournal.com/article.php?sid=7215 [05:46] Python-based and all [05:46] BradB: I noticed that stub had recently checked in some optimisations of the setup for functional tests and page tests [05:47] ah, that, not sure yet [05:48] That won't affect this - it is creating the launchpad_unittest_template database, not the one used by the page tests [05:50] grep provides decent exit codes, so why use wc -l ? [05:50] stub: problems was that ALL the places you have the new voodoo needed $$(()) love [05:50] we have it fixed now [05:50] just have to see if limi can actually commit and pqm [05:53] committed [05:56] does make check give a useful exit code? [05:57] pqm relies on it [05:57] shell would be...? [05:59] echo $? [06:00] if [ $? -GT 0 ] ; then [06:00] sans caps on the gt, right? [06:00] looks good [06:01] yes, sabdfl [06:01] kiki! [06:15] (dilys/#launchpad) Merge to rocketfuel@canonical.com/launchpad--devel--0: More lucille-related db stuff and an example of how non-integer primary keys work (patch-638) [06:19] heh [06:21] kiko: ? [06:26] hey Kinnison [06:27] I was wondering what you were laughing at [06:28] sabdfl's kiki smirk. [06:32] aha === BradB is now known as BradB|lunch [06:45] they think it's funny to corrupt a person's name that way. [06:45] (elmo/#launchpad) err, pot, kettle, black, mister Trout [06:46] I see [06:46] sabdfl, can I request elmo allow the creation of an account for salgado@async.com.br? === Kinnison decides to call kiko 'koko' instead then [06:46] that wasn't english. hopefully it's half-afrikaans. [06:47] kiko: who's that? [06:48] sabdfl, Guilherme Salgado, who will be starting after next month as per our phone discussion [06:48] sabdfl, we'd rather he tagged off debonzi or cprov but we're not sure arch makes that safe enough. === cprov thinks "koko" might sound funny/strange in a portuguese talk [06:49] sabdfl, if you would rather we pursued the arch route for this period, I'm okay with it. [07:13] (dilys/#launchpad) New bug 2121 for Launchpad/Launchpad: product interface verification fails [07:13] (dilys/#launchpad) https://bugzilla.warthogs.hbd.com/bugzilla/show_bug.cgi?id=2121 [07:14] kiko: it does [07:15] (dilys/#launchpad) New bug 2122 for Launchpad/Launchpad: branch interface verification fails [07:15] (dilys/#launchpad) https://bugzilla.warthogs.hbd.com/bugzilla/show_bug.cgi?id=2122 [07:16] sabdfl, hmmm. [07:16] sabdfl, "it does"? [07:16] i'm starting to like arch [07:16] i think he could tag off cprov, then cprov merges from him and pushes up to rocketfuel [07:16] at least for a week or two [07:17] so I should try and get salgado to tag off cprov. [07:17] okay -- the only issue I see is gpg-signing the merged patches, but I think jblack_ can help us there. [07:17] (dilys/#launchpad) New bug 2123 for Launchpad/Launchpad: dbschema unit tests fail [07:17] (dilys/#launchpad) https://bugzilla.warthogs.hbd.com/bugzilla/show_bug.cgi?id=2123 [07:17] jblack_, if you are around, we'd appreciate some help. [07:18] sabdfl, I know jblack_ takes patches from elsewhere and merges them into RF, so I assume it is possible, we just never have. [07:21] (dilys/#launchpad) New bug 2124 for Launchpad/Launchpad: "check" rule for top-level makefile should run unit tests [07:21] (dilys/#launchpad) https://bugzilla.warthogs.hbd.com/bugzilla/show_bug.cgi?id=2124 === lulu [~lu@host217-37-231-28.in-addr.btopenworld.com] has left #launchpad [] [07:36] kiko: "elsewhere" could be tricky [07:36] but if he tags of cprov then there is no loop [07:36] he can only update when cprov updates [07:36] essentially, cprov is his upstream, not rocketfuel [07:36] he doesn't mirror to chinstrap or merge to rocketfuel [07:36] yes, I understand. [07:36] cprov merges from him and pushes to rocketfuel [07:37] we just were thinking if the fact that chinstrap won't recognize his gpg signature be a problem for cprov's RF request. [07:37] (spiv/#launchpad) kiko: I'm not sure, but I think that may be ok, because cprov will have signed it. [07:38] (spiv/#launchpad) kiko: But it's worth checking with our arch guys :) [07:42] spiv: ok, I'm not sure if the patches will be resigned, but anyway salgado should have access to my archive (in my laptop), it might be complex (WEBDAV maybe) [07:44] (spiv/#launchpad) cprov: He only needs read access, so plain http would work (although you'd have to mirror it and make sure the mirror had .listing files) === debonzi [~debonzi@200.158.100.251] has joined #launchpad === spiv boggles as archzoom takes over a minute of cpu time to process one page request === BradB|lunch is now known as BradB === carlos hates current.sql, he had a hard to detect bug because the sample data :-( [08:12] "corrupt library (failed inode signature validation)" [08:12] is there any way for me to find out which files were corrupted? [08:13] ddaa, lifeless, jblack_: ^^^ [08:14] None that I am aware of. [08:14] But because of hardlinking, you should probably remove at least the whole version from the revision library. [08:14] I'd really like to know what got corrupted so I can work out whether it was my fault and whether it's likely to happen again [08:15] (spiv/#launchpad) ddaa: I've been in daf's position too. It'd be a really useful diagnostic. [08:15] If you are interesting in diagnosis, you can just move the revision out of the revlib, remove the whole version, then run "tla changes" in the tree. [08:15] "remove the whole version"? [08:16] (spiv/#launchpad) (for instance, there seems to be something that reguarly corrupts my zope checkout if I hardlink it, but I've no idea what, so I just don't hardlink that anymore) [08:16] rm -rf path-to-revlib/arch@host/category/category--branch/category--branch--0 [08:17] (spiv/#launchpad) ddaa: It was the conflicting "move the revision out of the revlib" and "remove the whole version" that confused me :) [08:17] also, a way of automatically removing corrupt revisiosn would be nice [08:17] removing each one by hand is a pain [08:18] If you love shell one liners you could do something along "tla library-revisions $version | xargs -n 1 tla library-remove" or something like that [08:18] daf: good point, I do not know how to do that. [08:19] well, wishlist bug [08:19] do we have a place in Bugzilla for bugs on Arch? [08:19] we should [08:20] There should probably be a tool which traverse the whole revlib, check the inode sigs, and remove and list corrupt revisions. [08:20] agreed [08:21] daf: you can post a message to gau with a subject starting with "[BUG] ", that will put in in tla own bts, which is being written by asuffield. [08:21] Well, it was beinf [08:22] being written by asuffield until not long ago. He does not seem very active on that atm. I've heard that tom pissed him off by changing his mind multiple times on some feature. [08:22] arch is BIG on NIH [08:22] the model we've been using so far is this: [08:22] if we have people at Canonical who are involved in some project we use [08:23] like Steve for Zope, Andrew for SQLObject, etc. [08:23] (spiv/#launchpad) (BradB for SQLObject, me for sqlos...) [08:23] then we file bugs in bugzilla and the appropriate people interface with upstream [08:23] spiv: ah, ok [08:23] daf: okay [08:23] I think this could work for Arch also [08:23] (spiv/#launchpad) daf: BradB has commit privs on SQLObject :) [08:24] spiv: I bet you were happy to get rid of that one :) [08:24] No problem with that. I guess "the appropriate person" will end up being jblack. [08:24] (spiv/#launchpad) daf: Hah. I'm still happy to look into SQLObject issues, but it's good having more help, not to mention someone that's a little more responsive than ianb... [08:25] justdave: how about a category in Bugzilla for Arch bugs? [08:25] (spiv/#launchpad) An "Arch" category in bugzilla could potentially be a good place for PQM bugs/feature requests as well. [08:26] yes [08:26] they're currently filed agains "Project Admin" or somesuch === sabdfl [~mark@host217-37-231-28.in-addr.btopenworld.com] has joined #launchpad [08:29] is that usual to use something of the form " " as the summary of cvs commit messages? === daf shrugs [08:29] I tend to do a one-line summary of the commit [08:30] which is usually "Updated Welsh translation." :) [08:30] (spiv/#launchpad) ddaa: Not in my limited experience. [08:30] I see many of those in zenity and yelp, so I'm not sure that's normal. === BradB starts the scary canonical.launchpad.event namespace [08:30] I also see many summaries starting with a "* " which looks suspect... [08:31] but... well, I'm not even sure that cvs has the notion of a summary line... [08:32] BradB: events? [08:32] ddaa: *-lines are probably copied out of the changelog [08:32] yeah... I guess I should ask lifeless... [08:33] ddaa: hah, true -- I've clearly been using Arch too much :) [08:33] Coming from cvs, I do not know what is expected crack and what is unusual crack. [08:33] SteveA: for things that are added or edited related to a bug [08:34] then again, that would imply that I haven't been using CVS enough, which is oxymoronic [08:34] "my users hate arch, but they hate cvs even more" [08:34] hmm: deleting the last 50 revisions fixed the corruption [08:34] BradB: good idea. Don't bother using an interface for the events. Use classes and keep them simple (no, or next to no logic in the event itself). [08:34] If you must use logic in the event, do it in the __init__ [08:35] ddaa: precisely! [08:35] sabdfl was unkeen on using events at this point when I brought up the idea in London. [08:35] (spiv/#launchpad) ddaa: I'm pretty sure that cvs doesn't have a summary line concept. Many projects have software that mails commit messages with the first line as the subject, so the first line tends to be a de facto summary line. [08:35] (spiv/#launchpad) ddaa: (But I am not a CVS expert :) [08:36] SteveA: it seems the most natural way... [08:37] there are a total of about 13-14 things that we need to monitor [08:38] about 7ish, but there's add/edit events for each (the only exception is perhaps comments, which aren't currently editable [08:38] I agree. If you add events.py... it should be events not event, because like interfaces there are many kinds of event in the file. It isn't like we have a domain object type called an "Event". [08:38] oh, ok [08:39] Write in the module's docstring about using just classes, not interfaces, and keeping them as free of logic as possible (as in, just carriers of information) [08:39] and if there must be any logic in them, to do all the processing in __init__, just like with an exception. [08:39] events are a lot like exceptions, actually [08:39] personally, I'd put them in with interfaces [08:39] Is the only reason to avoid interface to reduce the amount of typing? [08:40] along with exceptions. because they are a lot like exceptions, and form part of the interface to something. [08:40] there should never be more than one implementation of a particular event. [08:40] the event itself carries sufficient type information for routing the event to subscribers. [08:41] yeah. i'll have one handler class that delegates to the appropriate method based on what happened. [08:41] so, I'd say, put the events in with the interfaces [08:41] you can just have handler functions, when that makes more sense [08:41] and, it often does [08:42] SteveA: why not keep them in canonical.launchpad.events? seems simpler than to group them in interfaces, which they aren't. [08:42] exceptions aren't interfaces too [08:42] s/too/either/ [08:42] i'd put exceptions in an exceptions namespace :) [08:42] but, they are part of the public interface of a thing. [08:43] and vocabularies in a vocabularies namespace? [08:43] yeah :) [08:43] like they are currently [08:43] the interfaces modules define the boundaries of a subsystem. [08:44] that boundary is not just the IWhatever interface, it is also the exceptions that can be raised when interacting with an IWhatever [08:44] and the events that get produced when interacting with an IWhatever [08:44] but, really, I don't mind a lot either way. [08:44] i'll leave it in events for now, and if people find it that strange, i'll let someone else tla mv it. [08:45] (or do the conceptual equivalent :) [08:45] the point is, if you're looking for stuff to do with a Bug... [08:45] hm, true === BradB hmms [08:46] the other thing is one of dependency [08:46] so, a subscriber to such an event needs to know about the event [08:46] and about the interface of whatever the event is carrying [08:46] a BugAddedEvent would probably carry the bug [08:47] maybe the IPerson that added the bug... maybe not [08:47] anyway, some things for you to think about :-) [08:47] yeah [08:47] i'll check in some kind of code that works today [08:47] cool [08:51] Kinnison: lib/canonical/lucille/tests is not a package [08:51] it must be a package [08:52] add an __init__.py to it to make it into a package [08:52] what's the cvs magic to know whether a file has the binary bit on? [08:54] (dilys/#launchpad) Bug 2123 resolved: dbschema unit tests fail [08:54] (dilys/#launchpad) https://bugzilla.warthogs.hbd.com/bugzilla/show_bug.cgi?id=2123 [08:58] (dilys/#launchpad) Merge to rocketfuel@canonical.com/launchpad--devel--0: Fix bug 2123, failing dbschema tests. (patch-639) [09:05] Okay... knew that... [09:05] someone tell the zenity folks about -kb... === ddaa is out [09:09] SteveA: we discussed this yesterday [09:10] SteveA: Lucille's tests don't pass when run outside a specific directory [09:10] SteveA: so Kinnison is deliberately not making it a package until he's fixed them [09:13] I'd be inclined to make it a package, but not call it "tests" [09:13] so, the test runner won't complain [09:13] and I won't be mislead into thinking that they're standard launchpad tests ;-) [09:13] I don't think it's worth worrying about it if it's a short-term problem :) [09:14] (spiv/#launchpad) daf: Is it because it needs to access the tests/data directory? [09:14] (spiv/#launchpad) Or is it more than just that? [09:14] spiv: yes [09:14] (AFAIK) [09:14] (spiv/#launchpad) Ok, that's fairly easy to fix, I would think. [09:14] a volunteer! :) [09:14] (spiv/#launchpad) Heh. [09:15] are you still in Ma{j,ll,y}orca, spiv? [09:15] (spiv/#launchpad) It'd be easier to fix with Twisted's test runner ;) [09:15] (spiv/#launchpad) Yeah, for a couple more days. [09:15] and then on to Prague? [09:15] (spiv/#launchpad) Yep. [09:15] it's cold here, how's Spain? [09:15] (spiv/#launchpad) Good :) [09:16] (spiv/#launchpad) It's not really swimming weather anymore, but it's not far off... [09:16] (spiv/#launchpad) There was plenty of people sun bathing on the weekend :) [09:17] spiv: you're in spain? [09:17] kiko: I'm here [09:18] (spiv/#launchpad) For a couple more days, yeah. [09:18] mainland or island? [09:18] (spiv/#launchpad) SteveA: See my travel itinerary on the wiki ;) [09:18] (spiv/#launchpad) Island. [09:18] \\\\\\ [09:18] cprov, like I told kiko, I'm here === SteveA fixes one of the lucille tests [09:36] (dilys/#launchpad) Merge to rocketfuel@canonical.com/launchpad--devel--0: imrpoved project search; various tidyings-up (patch-640) [09:42] carlos: around? [09:42] daf: yes [09:43] how's your branch looking? [09:46] daf: better, but not as good as it should :-(, I had a bug on the sample data and I expend too many hours with it [09:47] ok [09:47] it's fixed now? [09:47] I'm with the export and import functional tests, seems like the functionality is now in place, but with some minor errors [09:47] daf: yes, the sample data bug is fixed [09:48] I also detected that the functional tests need some love [09:48] because I imported a pofile and it was empty in the database and the functional test said it was right [09:48] carlos: you haven't merged your branch yet? [09:49] SteveA: no :-( [09:49] any idea when it will be merged? [09:50] Kinnison: please please no UTF8 source files! [09:50] SteveA: do events that get trigged by a foo getting added to a bug belong in lib/canonical/launchpad/zcml/foo.zcml? [09:50] Events are one of the things not mentioned in the example.zcml. [09:51] canonical/launchpad/zcml/bug-events.zcml? [09:51] that's because we don't have any events, and mark was unkeen to start using them [09:51] I don't know what a foo is [09:51] but, decide on the best place to put them that answers the question: [09:51] I cannot give a concrete estimation, I think I have studied all code now so it should be easy because I understand all, my plan is don't go to sleep until it's fixed, I'm starting to be bored of this patch [09:52] "If I'm a person who has spent only 1 week on the project as a whole, where would I go looking to find it?" [09:52] carlos: can you break the job down into smaller parts that you can merge? === daf wonders what the aversion to find/grep is [09:53] daf: I thought that I prefer if you merge your changes to pofile.py because It will be easier If I merge it with my branch than if you should do it... [09:53] carlos: is there something I could help with that you make your job easier? === BradB goes for bugevents.zcml [09:53] BradB: no '-'? [09:53] SteveA: no, the problem is the database change if we change the schema, all the changes are needed [09:53] how can I open a .txt file encoded in UTF-8 and save it without screwing it up? [09:53] SteveA: use a decent editor [09:54] hmph [09:54] :se encoding=utf-8 [09:54] I'm using gvim. I think a bit of :set encoding=utf8 will do it [09:54] daf: perhaps you could start validating my code, I'm working on it too much time and perhaps you could catch the errors I don't see... [09:54] but, I'll repeat... All source code files should be in ascii [09:54] carlos: ok [09:54] SteveA: use recode [09:55] carlos: how should I go about validating it? [09:55] carlos: what does recode do? [09:55] daf: I will do a star-merge now to get latest unittest fixed [09:55] daf: change the encoding of a text file [09:55] carlos: that doesn't help for editing it [09:55] recode latin1..utf8 file.txt [09:55] it converts it into non utf-8 [09:56] and you can edit it later [09:56] what if there are non-latin-1 glyphs in the file? [09:56] I thought that was what SteveA wants to do [09:56] Steve doesn't want Latin 1 either [09:56] daf: change latin1 with the encoding :-P [09:56] he wants ASCII [09:57] but that will break the file removing chars, right? [09:57] if you have (say) "" in the source code, you can't convert it to Latin 1 [09:57] Instead of "Perell Marn" he will get "Perell Marn" [09:57] because Latin 1 doesn't have such a character [09:58] and are in Latin 1, and so they can be converted [09:58] daf: dude, the latin1 string was just an example it should be changed to the needed encoding, of course if you want to strip out the non ascii chars... I don't have any idea about how to do it :-) [09:59] oh, an example :) [09:59] I think Stee was saying that he wants to edit the file [09:59] Steve [09:59] without changing the encoding for now [09:59] In fact the command I pasted is to convert a latin1 file into utf-8 :-) [10:00] carlos: heh, I thought it might be :) [10:00] anyhow, this is getting off topic [10:00] any suggestions for reviewing the changes you have made? [10:01] also, you said I should merge my changes to pofile.py? [10:02] yes, please merge it and I will review the merge into my branch [10:02] I think it will be easier [10:02] well, it's not a critical change [10:02] so I can merge it after you have merged your branch [10:02] as you want [10:02] I think it will let us merge your branch quicker if we delay that change [10:03] about the suggestions to review the changes... not sure, let me merge the rocketfuel changes into my branch and looking the functional tests for one more hour, perhaps It's finished already, because seems like it's beeing imported the file already [10:03] please get merged as quickly as you can [10:04] carlos: you'll report back to me in 1 hour? [10:04] daf: yes [10:04] at 21:00 UTC, is it ok? [10:04] yes [10:04] later, then [10:05] I'll be finishing work today at 21:25 or so [10:05] ok [10:07] daf: arch product created. [10:08] I need to get some food, I'm back in 10 minutes [10:11] (dilys/#launchpad) Merge to rocketfuel@canonical.com/launchpad--devel--0: Some soyuz fix and sql.py cleanup started. (patch-641) [10:12] justdave: great, thanks! [10:15] (dilys/#launchpad) Merge to rocketfuel@canonical.com/launchpad--devel--0: Make lucille tests run as part of the main launchpad unit tests. Reformat lucille test code to pep8. Change utf8 encoded file into ascii encoding. (patch-642) [10:21] (dilys/#launchpad) New bug 2125 for Arch/general: Arch leaves a revision lock when signature fails [10:21] (dilys/#launchpad) https://bugzilla.warthogs.hbd.com/bugzilla/show_bug.cgi?id=2125 [10:21] (dilys/#launchpad) Merge to rocketfuel@canonical.com/launchpad--devel--0: fix makefile for Mac OS X (patch-643) [10:27] (dilys/#launchpad) New bug 2126 for Arch/general: cleaning broken revisions from one's revision library is painful [10:27] (dilys/#launchpad) https://bugzilla.warthogs.hbd.com/bugzilla/show_bug.cgi?id=2126 [10:49] spiv: someday you should explain me why we should use SQLObject.selectBy(fooID=foo.id) instead of just SQLObject.selectBy(foo=foo) or am I doing anything wrong? [10:50] carlos: BradB knows SQLObject well also [10:51] BradB: someday you should explain me why we should use SQLObject.selectBy(fooID=foo.id) instead of just SQLObject.selectBy(foo=foo) or am I doing anything wrong? [10:51] :-D [10:52] (spiv/#launchpad) carlos: Because SQLObject is pants. [10:52] carlos: Because of a bug in sqlobject. ;) [10:52] funny, SQLObject is a really good idea but it sucks... [10:52] :-) [10:56] SteveA: Looks like I'm creating a package called canonical.launchpad.events anyway, to hold the classes that implement event interfaces (since interfaces are required for events.) [10:58] carlos: nice idea, shame about the implementation? [10:59] daf: well, I think it needs some bug fixing :-) but I can live with it if I know how to workarround the bugs [11:01] carlos: It's a hell of a lot better than not-sqlobject, at least. [11:01] perhaps we should have a bug open in our Bugzilla about this SQLObject issue [11:01] BradB: true [11:01] carlos: BONG! 21:00 :) [11:02] daf: let the test I'm running finish and I will give you an answer :-) === carlos is not sure but thinks it's all fixed but two easy to fix bugs in the exporter === BradB looks forward to moving LP to python 2.4 and multi-line imports [11:03] daf: the main problems I had was the fooID=foo.id thing [11:04] BradB: multi-line imports? [11:04] BradB: they sound good [11:05] surrounding imports with brackets Does The Right Thing [11:05] no more: [11:05] import foo, \ [11:05] bar, \ [11:05] baz, \ [11:05] etc. [11:06] (with step indentation for added effect :P) [11:06] wow!! it worked (more or less....) [11:07] daf: I have now minor bugs to fix, so what do you prefer?, check the code now or as soon as those minor bugs are fixed do the merge into rocketfuel? (tonight for sure) [11:07] BradB: why not just one import per line??? [11:08] and I believe that's what pep8 recommends. [11:08] er, more specifically i meant the from imports. [11:10] ddaa: because this is annoying [11:10] from canonical.launchpad.foo.bar.baz import corge, grault [11:10] from canonical.launchpad.foo.bar.baz import flarp, bling [11:12] daf: should i be able to see the current code running on mawson? [11:12] sabdfl: yes [11:13] mawso's code is currently 27 minutes old [11:13] i get "forbidden" [11:13] on / [11:14] did you install the SSL certificate? [11:14] i have the launchpad client cert [11:14] not the second one [11:14] that should be enough [11:14] it works for me [11:15] I have no idea how to go about debugging this sort of thing [11:15] heisenbug, works now :-) [11:15] heh :) [11:15] tls i can debug :-) [11:16] :D [11:16] that code appears to be massively out of date [11:19] why so? [11:19] oh, hmm [11:19] changes i made over the weekend and though had been merged [11:19] maybe the update is broken [11:19] :-) [11:20] yeah, there was a Makefile.orig lying around [11:20] bah [11:22] ok, try again now === daf goes out [11:26] BradB: I don't think interfaces are required for events [11:26] daf: should I merge the branch when it's ready or should I wait for your review? [11:27] SteveA: They are. Jim said so. :) [11:28] SteveA: The idea is that classes should be usable, but they aren't yet. [11:28] ah -- that's just in the directive [11:28] not in the underlying system [11:29] right [11:37] I'm doing something a bit different with email, Brad [11:38] because I want to integrate testing sending email with pagetests [11:38] so, I suggest you make a function in canonical/launchpad/mail.py for sending mail [11:38] use the standard python libs for it [11:38] I had it in mailnotification (where all the subscriber functions are) [11:39] ok [11:39] the stuff that subscriber functions do should be pretty minimal glue stuff, imo [11:39] yep, they're simple [11:39] various other things will need to send email, for example, the forgotten password pages [11:39] I'm writing more page tests for the forgotten password stuff [11:39] canonical.launchpad.sendmail, perhaps? [11:40] but I want to get it so that I can test sending email from there too [11:40] sure === BradB shifts some code around [11:40] but, I'd be inclined towards canonical.launchpad.mail.send for the function [11:40] or canonical.launchpad.mail.sendmail for ease of importing [11:40] i'll do the latter [11:40] k [11:40] thanks [11:41] I'll sort out getting the zope transactional stuff hooked up, but we can manage without that at present [11:41] ok [11:42] not sure if python's stdlib blocks or not [11:42] that was another feature of the z3 way [11:42] it blocks [11:43] but we want that right now [11:43] keep it really simple right now [11:43] i see what you mean [11:54] probably when we're developing stuff, we'll want to keep it blocking [11:54] the events work now; now i've just got to go and implement 15 different handlers :P [11:54] cool [11:55] The handlers are admittedly really simple; making sure an event is published on, e.g., an edit, may be slightly less simple. [11:57] Kinnison: need to split up publishing.py, it's getting a little overloaded [12:00] sabdfl: which one?