| === kiko-afk is now known as kiko | ||
| === stub [~stub@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad | ||
| stub | BradB: The existing vocabulary tests should show you what is needed. | 12:47 |
|---|---|---|
| stub | Urgh - which I can't find any more. I could have sworn there were some there :-( | 12:49 |
| stub | And the work I did splitting up the Launchpad harness into standalone setUp and tearDown methods never landed. | 12:52 |
| BradB | It'll be worth deploying a new dogfood once I land this bug-id-in-subject-line-on-add patch | 12:52 |
| stub | BradB: Yup | 12:52 |
| === BradB waits while make check runs | ||
| stub | harness.LaunchpadFunctionalTestCase is supposed to setup the database and all the Z3 infrastructure for functional tests (although Carlos was going to land a patch last night I think because I forgot to actually call the superclasses setup/teardown). | 12:54 |
| BradB | stub: I know. The problem is, this isn't a functional test. | 12:55 |
| BradB | A functional test is like "add a bug". | 12:55 |
| BradB | I wanna test one teeny little thing, that just happens to grab some data from the outside world. | 12:56 |
| stub | Yup. I moved the pgsql.py harness into ftests because SteveA seemed to be saying it was a functional test because it hit the database, but I think you are right and it should stay in the Unit test area. | 12:57 |
| BradB | stub: SteveA, daf and I had this argume^Wdiscussion in London. :P | 12:58 |
| stub | I think pureist thinging says you need a stub implementation of the database, but in our environment SQLObject are just another provided datatype that we should be treating like dictionaries. | 12:58 |
| BradB | stub: My major concern there is that stub implementations are a Real World Nightmare to work with. | 12:59 |
| BradB | The rely on knowing the *implementation* of the code your testing, which is masochistic. | 12:59 |
| stub | Hey - I think I personally caused the stub implemenations in soyuz and rosetta to be dropped because I never bothered with it in Malone and it worked dammit ;) | 01:00 |
| BradB | heh | 01:00 |
| BradB | I built the world's most solid credit card payment processing on the same philosophy (i.e. test stubs usually suck) | 01:01 |
| BradB | s/processing/processing system/ # okay, there might be one or two better | 01:01 |
| BradB | daf: I'm now just waiting on tla as I land the bug id fix. Can we expect dilys's malone notifications to be working tomorrow? | 01:03 |
| === BradB tells tla to fogo na bomba | ||
| === stub wonders if he should attempt upgrading to Hoary | ||
| BradB | stub: what's the status of airport cards being supported in linux? | 01:16 |
| BradB | i want to install ubuntu on my other powerbook (the 15" 867 MHz), and see if it'll run faster than this 1.5 GHz one. | 01:16 |
| stub | I have no idea. I'm not on a mac any more so haven't been following. | 01:16 |
| dilys | Merge to rocketfuel@canonical.com/launchpad--devel--0: add bug id to subject line in bug add emails. cleanup bug add machinery and remove some dead chickens. (patch-764) | 01:28 |
| BradB | stub: anytime you want to rollout a new dogfood, go ahead. | 01:31 |
| stub | Oohh..... from z3-users | 01:35 |
| stub | No, but in order for them to work well, the have to be ILocations; you can put a proxy around the values before returning them using zope.app.location.locate(object, parent, name). | 01:35 |
| stub | Might be possible to hack that into our publisher method and make everything that is traversable to locatable | 01:36 |
| BradB | that's what i was saying though :) | 01:43 |
| BradB | we need locations | 01:43 |
| BradB | the way it is now is screwed up. bugcontainers contain bugs, but bugs don't know that they're in bugcontainers. | 01:44 |
| stub | Mmm.... it might be trivial to switch it on though - I suspect it involves changing a single method. I might give it a try ;) | 01:49 |
| stub | BradB: I spoke too soon last night about the bug watches. Our internal bugzilla is setup so you need to be logged in before you can see a bug. I suspect we need to extend the BugTracker table to contain a username and password, and refactor the checkwatches.py script to goto that tracker types login form, login, and maintain the auth information when it then checks the bugs on that external tracker. Which is annoying because we proba | 01:59 |
| stub | Hmm... maybe I could just hardcode auth information in there for our internal one... | 02:00 |
| BradB | watches in general will need to support the possibility that logging in to the remote system could be required | 02:01 |
| BradB | is the intent for dogfooding that we'll be watching dogfood bugs that were already reported in bugzilla? (i.e. before i got jdub to make that impossible) | 02:03 |
| BradB | ...until they're migrated in a week or two. | 02:03 |
| === BradB is now known as BradB|afk | ||
| dilys | Merge to thelove@canonical.com/bazaar--devo--1.0: Making test-dir-regexps.sh posixly correct (patch-64) | 02:20 |
| BradB|afk | stub: so will there be a new dogfood by the time Canada wakes up tomorrow? | 02:58 |
| stub | BradB|afk: yup | 03:01 |
| BradB|afk | sweet | 03:01 |
| stub | It is pretty trivial for me to rollout now and difficult to screw up. | 03:02 |
| BradB|afk | cool | 03:02 |
| === BradB|afk is now known as BradB|away | ||
| stub | SteveA: ping | 04:44 |
| daf | BradB|away: sure, as long as I have some sample emails to work with | 06:18 |
| stub | daf: At this stage, I think we just want to report the subject line of emails that have an errors-to: set to bounces@canonical.com - that should be future proof while we tweak the templates. | 09:26 |
| === ddaa [~ddaa@deep-thought.xlii.org] has joined #launchpad | ||
| === stub [~stub@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad | ||
| === Kinnison [~dsilvers@host81-153-126-219.range81-153.btcentralplus.com] has joined #launchpad | ||
| Kinnison | Morning | 10:12 |
| === lulu [~lu@host217-37-231-28.in-addr.btopenworld.com] has joined #launchpad | ||
| Kinnison | lulu! | 10:18 |
| === Kinnison dances | ||
| lulu | morning :o) | 10:18 |
| === doko [doko@dsl-082-082-210-084.arcor-ip.net] has joined #launchpad | ||
| === salgado [~salgado@200-206-134-238.async.com.br] has joined #launchpad | ||
| === sabdfl [~mark@host217-37-231-28.in-addr.btopenworld.com] has joined #launchpad | ||
| Kinnison | Morning sabdfl | 01:00 |
| sabdfl | hiya | 01:01 |
| === cprov [~cprov@200.158.100.251] has joined #launchpad | ||
| sabdfl | stub: how did that popup page selector work out? | 01:11 |
| sabdfl | hiya BradB|away | 01:11 |
| stub | sabdfl: Partially done. I think it will be running by the end of tomorrow. | 01:12 |
| stub | Itegrates happily as a standard widget, and the popup is working. I just have to have the popup contain content and the javascript to push the value back to the form. | 01:13 |
| === debonzi [~debonzi@200.158.100.251] has joined #launchpad | ||
| === debonzi [~debonzi@200.158.100.251] has joined #launchpad | ||
| sabdfl | Kinnison: what's been the focus since you got archives published? | 03:28 |
| Kinnison | sabdfl: "The focus" ? | 03:29 |
| Kinnison | sabdfl: gina-wise, the dogfood server and hoary | 03:29 |
| Kinnison | sabdfl: lucille-wise, getting a pile of unit-tests done for all the publishing stuff and then the domination and unpublishing stuff | 03:29 |
| sabdfl | ok | 03:30 |
| Kinnison | sabdfl: I have been prioritising dogfood over lucille recently; although that has receeded into nearly no time now | 03:30 |
| Kinnison | So apart from periodic dogfood related sidelines; I'm back to lucille full-time | 03:31 |
| sabdfl | do you think the spanish inquistion will need to roast your tosies to get derivative distros working before christmas? | 03:31 |
| sabdfl | ok | 03:31 |
| Kinnison | my toesies?! eep! | 03:31 |
| === Kinnison doesn't want his toes roasted; that's fer sure | ||
| Kinnison | Hopefully wednesday next week will leave me pretty much clear to get single-distro working nicely | 03:32 |
| Kinnison | Derivative distros needs all the policy stuff assuming we're not faking it | 03:32 |
| sabdfl | right | 03:32 |
| Kinnison | Hopefully we'll get a chance to discuss some of that next week | 03:32 |
| sabdfl | yes | 03:32 |
| Kinnison | Cool | 03:32 |
| sabdfl | we'll start as simple as possible | 03:32 |
| sabdfl | germinate-style | 03:32 |
| Kinnison | Do you want me to try and come up with an agenda for wednesday? | 03:32 |
| sabdfl | just a list of packages to be included | 03:33 |
| sabdfl | good idea to have an agenda | 03:33 |
| === BradB|away is now known as BradB | ||
| BradB | morning | 03:36 |
| Kinnison | brad. | 03:37 |
| sabdfl | mornin' bradb | 03:37 |
| sabdfl | nice cleanup work in malone btw on the bug add forms etc | 03:37 |
| BradB | thanks | 03:38 |
| BradB | dilys integration should be a real possibility today. i'm sure we'll end up reformatting the notification emails at some point, but they provide everything dilys needs now. | 03:39 |
| sabdfl | awesome | 03:41 |
| sabdfl | i think we should make the product / package selection compulsory for new bugs | 03:44 |
| BradB | ok | 03:44 |
| sabdfl | given the Packaging table which links product and package, we should be able to make it quick | 03:44 |
| BradB | what do you mean "make it quick"? make it quick to figure out if the selected a package or product? | 03:46 |
| BradB | s,the,they, | 03:47 |
| ddaa | spiv: can I disable globally the stderr proxy twistd puts in place? | 03:49 |
| spiv | ddaa: hmm | 03:49 |
| ddaa | I suspect it's what causes the gdb stuff to segfaults | 03:50 |
| ddaa | I successfully got the gdb macros to run on a dummy python script. | 03:51 |
| sabdfl | BradB: selecting a package should immediately preselect the relevant product | 03:51 |
| spiv | ddaa: there's no option in twistd to do it... | 03:52 |
| spiv | ddaa: it's a hack, but the simplest way would be to edit the startLoggingWithObserver function in twisted/python/log.py | 03:52 |
| spiv | Changing the default value of setStdout should be sufficient. | 03:53 |
| BradB | sabdfl: ah. IOW, /both/ are required. | 03:53 |
| ddaa | spiv: well, then when is it done? I am happy if I can just add a bit of client code to restore sys.stderr out of sys.__stderr__ at some point. | 03:53 |
| spiv | (that flag affects sterr too) | 03:53 |
| spiv | ddaa: Well, it's done before running the tap/tac. | 03:53 |
| spiv | So I suspect you could sort it out in buildbot's master.cfg thing. | 03:54 |
| sabdfl | i'm not sure we can require both, since we can't be certain that the product entry has been created | 03:54 |
| sabdfl | also, the bug might not exist upstream | 03:54 |
| ddaa | spiv: I'm interested in doing that in the slave. | 03:54 |
| sabdfl | for example, if it's purely a packaging bug | 03:54 |
| sabdfl | then it only exists in the package, not upstream | 03:54 |
| BradB | sabdfl: is it worth auto-selecting the product then? i would have thought it'd be common that the bug reporter would have no idea if the bug exists upstream. | 03:56 |
| spiv | ddaa: I suppose you could do it with something that does "reactor.addSystemEventTrigger('before', 'startup', setattr, sys, 'stderr', sys.__stderr__)" | 03:57 |
| BradB | sabdfl: stub was saying that maybe there was a specific reason that we don't want the product selection widget on the bug add form too. i think he was saying that it would confuse users (i.e. it's probably enough for us to leave it to the package maintainer to decide if a product assignment is warranted.) | 03:57 |
| spiv | ddaa: Personally, I'd just edit log.py ;) | 03:58 |
| === ddaa looks at spiv with blank stare | ||
| sabdfl | hmm... good idea | 03:58 |
| spiv | ddaa: I don't know the slave code well enough to know where a good spot to put that call would be, hence my slightly vague advice. | 03:58 |
| === ddaa follows spiv advice | ||
| BradB | sabdfl: ok, i'll remove it today. | 03:59 |
| sabdfl | i think it would also be possible to add a bug directly to a product, which creates the bug, and a bug-product-assignment | 03:59 |
| sabdfl | remember, we want to be able to use malone for pure-upstream projects too | 03:59 |
| BradB | sabdfl: that's technically how we should be assigning bugs to malone. | 03:59 |
| sabdfl | yes | 04:00 |
| BradB | maybe two add forms? i'm not sure... | 04:00 |
| sabdfl | go to the product, then "file bug" | 04:00 |
| sabdfl | i'll have a stab at that | 04:00 |
| sabdfl | now | 04:00 |
| BradB | ok | 04:00 |
| Kinnison | owwwie! unittests hurt my fingers | 04:01 |
| sabdfl | what are the semantics of page test creation now? | 04:01 |
| ddaa | spiv: your suggestion does not seem to work terribly well... | 04:04 |
| BradB | sabdfl: each dir in pagetests is a "story" | 04:05 |
| BradB | sabdfl: for each "story", a fresh db is created. | 04:05 |
| BradB | ./makepagetest {xx,nn} some cool test | 04:05 |
| BradB | xx if it's stand-alone, nn if it depends on the previous test. | 04:05 |
| dilys | Merge to rocketfuel@canonical.com/launchpad--devel--0: Fix zopeless bug for Carlos (patch-765) | 04:06 |
| BradB | that puts the test in pagetests/, then you move it to the appropriate story and elide all the crap not related to what you're testing. | 04:06 |
| sabdfl | right | 04:06 |
| spiv | ddaa: Hmm :/ | 04:07 |
| BradB | sabdfl: i /think/ that it's appropriate for each app to be a story. i started that malone dir, because standalone was starting to get a bit overwhelming. we might want to gradually make standalone/ go away (and the tests therein be moved to malone/ soyuz/ rosetta/ and launchpad/) | 04:08 |
| === debonzi [~debonzi@200.158.100.251] has joined #launchpad | ||
| sabdfl | so creation is unchanged, just move them to a story afterwards? | 04:19 |
| === debonzi [~debonzi@200.158.100.251] has joined #launchpad | ||
| ddaa | progress... I added the sys.stdout/stderr restauration hack at some essentially random place, and now it segfauts just a bit later | 04:25 |
| ddaa | mh... well, no... actually, just at the same place :-( | 04:27 |
| ddaa | hehe... that was the "print local variables" that screwed at some point :-) | 04:33 |
| === debonzi is now known as debonzi|lunxh | ||
| === debonzi|lunxh is now known as debonzi|lunch | ||
| ddaa | Here it goes. | 04:42 |
| BradB | sabdfl: correct (sorry, wasn't paying attention to this window for a while) | 04:42 |
| ddaa | Hehe! Not even needing gdb actually... | 04:43 |
| ddaa | I got a familiar "interrupted system call" from within cscvs | 04:44 |
| ddaa | at a point where I used to have an occasional hanf | 04:44 |
| sabdfl | BradB: any reason why the page test creation is not recording a POST? | 04:49 |
| BradB | sabdfl: that should work fine...you're posting on port 9000? | 04:50 |
| sabdfl | thought i did | 04:51 |
| sabdfl | just tried again and it seems to have got it | 04:51 |
| BradB | ok | 04:51 |
| === debonzi|lunch is now known as debonzi | ||
| sabdfl | BradB: i think we need a datecreated on the bugassignment tables | 05:20 |
| sabdfl | so we can see a list of the bugs assigned to a product, in order of assignment | 05:20 |
| sabdfl | or a list of the x latest bugs assigned | 05:20 |
| sabdfl | mind if i go ahead and create that? | 05:20 |
| BradB | we don't yet have that? yes, please feel free to create them. :) | 05:21 |
| BradB | sabdfl: while you're at it...do we want to add a "note" to assignments and infestations? mdz mentioned something about wanting this. | 05:22 |
| sabdfl | ok | 05:22 |
| sabdfl | could be tricky to display though | 05:22 |
| BradB | we could elide it as necessary "blah blah blah..." | 05:23 |
| sabdfl | can I sort() a list descending? | 05:54 |
| BradB | foo.sort(lambda a, b: cmp(b, a)) | 05:55 |
| sabdfl | wow, that's immediately obvious, innit | 05:56 |
| sabdfl | thanks :-) | 05:56 |
| BradB | no prob :) | 05:56 |
| spiv | "foo.sort(); foo.reverse()" works well as well :) | 05:59 |
| BradB | slower though | 06:00 |
| spiv | BradB: Actually, no. | 06:01 |
| BradB | oh, because it's all done in C? | 06:02 |
| spiv | BradB: The cost of doing n log n python function calls tends to strongly outweigh the cost of reversing the list in C :) | 06:02 |
| BradB | indeed, indeed. | 06:02 |
| BradB | looks like 2.4 will make this operation even faster with reverse iteration | 06:06 |
| spiv | Yeah. And also with supporting a keyfunc to sort. | 06:10 |
| spiv | So you could do "foo.sort(keyfunc=operator.neg)" | 06:11 |
| spiv | Too many ways to do it ;) | 06:12 |
| BradB | heh | 06:12 |
| === BradB is now known as BradB|lunch | ||
| lulu | night all :o) | 07:43 |
| === lulu [~lu@host217-37-231-28.in-addr.btopenworld.com] has left #launchpad [] | ||
| === BradB|lunch is now known as BradB | ||
| BradB | daf: ping | 08:18 |
| daf | BradB: pong | 08:42 |
| BradB | daf: do you have enough info now to get dilys going with malone? | 08:49 |
| daf | I'm working on it as we speak | 08:50 |
| BradB | awesome | 08:50 |
| BradB | daf: will we be able to also see who submitted a bug? (i just realized that there's no way to see who made a *change* currently, be at least we know who submitted a bug.) | 08:52 |
| BradB | s/be at/but at/ | 08:52 |
| daf | if you want to :) | 08:53 |
| daf | actually, I don't see that information in the report | 08:53 |
| BradB | Submitted By: | 08:54 |
| BradB | daf: yes, it's useful to know who submitted that. then we can jump into conversation with that person on IRC, knowing who just submitted it. | 08:54 |
| daf | ah, in the headers | 08:55 |
| BradB | actually, it's currently Owner:, but I made a little fix so that when the next version is rolled out it'll be Submitted By: | 08:55 |
| BradB | no, in the add mail itself | 08:55 |
| daf | oh, *right* | 08:55 |
| BradB | :) | 08:55 |
| daf | cool | 08:55 |
| daf | where's Malone, by the way? | 09:02 |
| BradB | https://launchpad.ubuntu.com/malone | 09:02 |
| BradB | a bug is at https://launchpad.ubuntu.com/malone/bugs/$bugnumber | 09:02 |
| daf | ta | 09:03 |
| daf | and what's my password? :) | 09:05 |
| BradB | i dunno, you tell me :) | 09:07 |
| BradB | it's whatever it is in ubuntulinux.org | 09:07 |
| BradB | it's just a dump from production. | 09:07 |
| daf | ah | 09:08 |
| === daf tries to remember if he has an accoutn | ||
| BradB | yep, you do | 09:09 |
| === daf wonders what the password is | ||
| BradB | there's a forgotten password link, that hopefully works correctly on dogfood. you could give it a shot and see what happens. | 09:14 |
| daf | where is it? | 09:14 |
| BradB | https://launchpad.ubuntu.com/ubuntulinux/forgottenpassword | 09:15 |
| BradB | you see it from going here: https://launchpad.ubuntu.com/ | 09:15 |
| daf | ahh | 09:16 |
| daf | "Your account details have not been found." :-/ | 09:16 |
| BradB | daf: you were using the wrong email address. it's dafydd.harries@canonical.com. you've got mail. | 09:18 |
| daf | heh | 09:20 |
| daf | I also have an account at daf@muse.19inch.net, apparently | 09:20 |
| BradB | yes | 09:20 |
| daf | the forgotten password thing works | 09:20 |
| BradB | woo | 09:20 |
| daf | but it has an incorrect link in the email | 09:20 |
| BradB | can you file a bug for that and assign it to debonzi? | 09:21 |
| daf | well, the link is http://www.ubuntulinux.org/forgottenpassword/... | 09:21 |
| daf | and it should be https://launchpad.ubuntu.com/... | 09:21 |
| daf | does the code have some way of knowing the correct prefix? | 09:22 |
| BradB | it should have a way. perhaps it wasn't implemented. | 09:22 |
| BradB | did you confirm that it's actually correctly resetting the p/w and allowing you to login to dogfood/ | 09:23 |
| daf | yes | 09:25 |
| daf | also, it redirected me to http://canonical.com after I'd reset my password :) | 09:25 |
| BradB | heh | 09:26 |
| BradB | that's something debonzi and steve worked on, so the bug should probably be assigned to debonzi | 09:26 |
| === debonzi [~debonzi@200-158-107-151.dsl.telesp.net.br] has joined #launchpad | ||
| BradB | debonzi! | 09:27 |
| BradB | daf has a bug for you | 09:27 |
| BradB | in forgottenpassword | 09:27 |
| daf | I'll file it in a second | 09:27 |
| BradB | thanks | 09:27 |
| debonzi | BradB, daf.. right.. just do it :) | 09:28 |
| BradB | heh | 09:28 |
| daf | grrrr | 09:32 |
| daf | summaries | 09:32 |
| debonzi | daf, Im going for dinner and Ill take I look on it latter.. see you all | 09:32 |
| daf | debonzi: sure | 09:32 |
| debonzi | :) | 09:32 |
| dilys | New Malone bug #39: forgottenpassword email has incorrect link | 09:35 |
| dilys | https://launchpad.ubuntu.com/malone/bugs/39 | 09:35 |
| BradB | (submitted by Dafydd Harries) | 09:35 |
| BradB | ;P | 09:35 |
| daf | :) | 09:36 |
| daf | well, I guess I could parse "Owner: ..." for now | 09:36 |
| daf | how's this: | 09:42 |
| dilys | New Malone bug #39: "forgottenpassword email has incorrect link", submitted by Dafydd Harries | 09:42 |
| dilys | https://launchpad.ubuntu.com/malone/bugs/39 | 09:42 |
| daf | ? | 09:43 |
| BradB | sure. if other #launchpad'ers don't like it, they'll let us know :) | 09:44 |
| daf | true :) | 09:45 |
| sabdfl | hi all | 10:11 |
| sabdfl | dilys! | 10:11 |
| sabdfl | nie | 10:11 |
| sabdfl | c | 10:12 |
| === SteveA [~steve@adsl-213-190-44-43.takas.lt] has joined #launchpad | ||
| sabdfl | good work daf | 10:12 |
| sabdfl | & bradb | 10:12 |
| BradB | thanks | 10:14 |
| daf | sabdfl: thanks | 10:14 |
| SteveA | I have cookie login working nicely in my tree. I need to do something about pagetests before I merge though, otherwise we'll end up with a bit of a mess. | 10:15 |
| BradB | what kind of mess? | 10:15 |
| sabdfl | hopefully you can't merge a mess ;-) | 10:15 |
| BradB | exactly :) | 10:16 |
| daf | BradB: I think you can close #33 now | 10:16 |
| SteveA | I could make it merge, by cleaning up the current mess with a hack. but there would be difficulties when creating new pagetests. | 10:17 |
| BradB | SteveA: because of expirations? | 10:17 |
| daf | SteveA: doesn't the basicauth still work? | 10:18 |
| sabdfl | SteveA: the layers work a *treat* | 10:18 |
| SteveA | BradB: no, because of authentication. although basic auth still works, when you create new pagetests, there will be cookie headers that need eliding. | 10:18 |
| SteveA | sabdfl: cool | 10:18 |
| BradB | SteveA: we elide a lot of stuff anyway. i don't see the problem. | 10:19 |
| SteveA | there's a limitation in the session/cookie api | 10:19 |
| SteveA | you can't see if there is a current session without making a current session | 10:19 |
| SteveA | BradB: I really like that you can create a pagetest, and immediately run it again. it would be a shame to lose that. Then again, it might encourage more elision ;-) | 10:20 |
| BradB | SteveA: we've already agreed (sabdfl and I, and I think others) that we elide a ton of stuff. we've never been able to record-and-run anyway. | 10:20 |
| BradB | e.g. you have to elide AuthorizationError's, dates, Content-Length, etc. anyway | 10:21 |
| === sabdfl wonders if it's worth climbing on the "elide everything but one specific page feature" soapbox again | ||
| === sabdfl decides everyone's heard that message already :-) | ||
| sabdfl | what's the tal foo to give you assignee/browsername OR "No assignee" ? | 10:22 |
| SteveA | in implementing this stuff, I've found a number of bugs I need to file on zope3 | 10:22 |
| SteveA | | | 10:22 |
| BradB | SteveA: cool | 10:23 |
| SteveA | tal:content="context/whatever | default" | 10:23 |
| sabdfl | default being? | 10:23 |
| SteveA | <p tal:content="context/whatever|default">The default</p> | 10:23 |
| SteveA | or, | 10:23 |
| sabdfl | ah | 10:23 |
| SteveA | <p tal:content="context/whatever|string:The default">This is always removed</p> | 10:23 |
| sabdfl | nice | 10:24 |
| BradB | SteveA: I'm looking forward to the bug of not ignoring elisions in diffs output to be fixed, because it's a major pain to do a lot of eliding until that's fixed. Also the broken <BLANKLINE> elisions needs to be fixed. | 10:24 |
| SteveA | you can actually string a load of "|"s together | 10:24 |
| sabdfl | first one that works matches? | 10:24 |
| SteveA | yes | 10:24 |
| SteveA | BradB: noted :-) | 10:24 |
| SteveA | Zope3 keeps its own copy of the relevant libs, so we can change them there | 10:24 |
| SteveA | easier than changing them in the python libs | 10:24 |
| SteveA | although, we might be able to get such bugs fixed in python before 2.4 final | 10:25 |
| sabdfl | is it possible to use the same addform with different contexts, and do some different post-processing? | 10:26 |
| sabdfl | for example | 10:26 |
| sabdfl | i want to "add a bug to a product" | 10:26 |
| sabdfl | actually, all I want to do is add the bug | 10:26 |
| BradB | sabdfl: make a new schema for that. | 10:27 |
| BradB | i think you can: | 10:27 |
| sabdfl | then after adding it, i want to add the productassignment | 10:27 |
| BradB | 1. create a base schema common to both add forms (bug + package and bug + product) | 10:27 |
| BradB | 2. inherit and create a schema for bug + package. | 10:28 |
| sabdfl | base schema should just be IBug | 10:28 |
| BradB | 3. do the same for bug + product. | 10:28 |
| sabdfl | factory should just be Bug | 10:28 |
| BradB | sabdfl: no, it's a schema for rendering a form to add a package. | 10:28 |
| sabdfl | you can use the full IBug schema, then restrict the elements using... | 10:28 |
| sabdfl | fields | 10:29 |
| BradB | sabdfl: schemas are, among other things, there to help zope render forms for you. IBug doesn't include product or package. | 10:29 |
| sabdfl | i don't want product or package | 10:29 |
| BradB | oh, ok | 10:29 |
| sabdfl | the use case is: | 10:29 |
| sabdfl | navigate to the product or package in doap or soyuz | 10:29 |
| sabdfl | then click on "file a new bug for this product/package" | 10:29 |
| sabdfl | now all i need is fields from the bug | 10:29 |
| sabdfl | create the bug | 10:29 |
| sabdfl | *then* create the product/package bugassignment | 10:30 |
| BradB | you just need to configure two addforms then, i think. one hanging off product, one off package. | 10:30 |
| BradB | what we've got now is hanging off BugContainer. | 10:30 |
| BradB | er, but hrm, that might not work. | 10:30 |
| sabdfl | btw, i've created a Title field | 10:31 |
| sabdfl | and it automatically gets a nice widget | 10:31 |
| sabdfl | no need for the displayWidth stuff | 10:31 |
| BradB | i thought the displayWidth stuff was a feature :) | 10:32 |
| sabdfl | Title and Summary | 10:32 |
| BradB | not all titles will want to be the same width. | 10:32 |
| sabdfl | it's a feature i didn't know about so I subclassed TextLine :-) | 10:32 |
| sabdfl | it was fun | 10:32 |
| BradB | we just needed a top-level browser:widget, rather than only a subdirective. | 10:32 |
| BradB | but anyway, hm | 10:32 |
| sabdfl | the idea is that we can have consistent validation rules for a Name, a Title, a Summary (ShortDesc) etc | 10:32 |
| sabdfl | right | 10:33 |
| sabdfl | i'm just learning here | 10:33 |
| BradB | i too would have to play around a bit to figure out the best way to do what you're wanting to do with products/packages + filing bugs. maybe SteveA has a more immediate solution. | 10:35 |
| sabdfl | i think it's under control | 10:39 |
| sabdfl | well... there are two ways I can think | 10:39 |
| sabdfl | will let you know what i come up with | 10:39 |
| BradB | cool | 10:39 |
| BradB | sabdfl: got a moment to discuss how to provide a useful bug listing, that more clearly shows the user what stuff they need to fix? (or to get someone else to fix :) i think i have an idea. | 10:45 |
| sabdfl | ok fire away | 10:45 |
| BradB | sabdfl: ok, so here's the thing: | 10:45 |
| BradB | we need one screen in malone where i can go to find out what bugs i need to fix. | 10:46 |
| BradB | in malone, bugs are assigned to packages or products and infest specific versions of products and packages (to which they may or may not be assigned) | 10:46 |
| BradB | assignments talk about work needing to be done. infestations just describe the way in which a bug affects a particular version of a thing. | 10:47 |
| sabdfl | yes | 10:47 |
| BradB | so, for our main bug listing ("Outstanding Bugs" or something) we can totally ignore infestations. | 10:47 |
| sabdfl | yes | 10:47 |
| BradB | we need to show that somewhere, but on a different screen | 10:47 |
| sabdfl | though we do need to think a little about the connection between infestation and assignment | 10:47 |
| BradB | sabdfl: there isn't always one. | 10:48 |
| sabdfl | yes | 10:48 |
| BradB | sabdfl: for products and packages that have infestations, we can provide some kind of link or whatever, but that's the easy part. | 10:48 |
| sabdfl | right | 10:48 |
| BradB | so, we show the Outstanding Bugs table with all the columns, including a "package" column, and a "product" column, one of which will be populated in each row. | 10:49 |
| BradB | and by "all the columns" i mean things like severity, priority, assignee, etc, of course. | 10:49 |
| sabdfl | so it's really "outstanding bug assignments" | 10:49 |
| BradB | mm...kind of. i thought "outstanding bugs" made it more clear, but... | 10:49 |
| BradB | assignments is a bit of jargon we may not want to include in the title of that page. | 10:50 |
| sabdfl | this is one area where i've been tempted by postgres inheritance | 10:50 |
| sabdfl | yes | 10:50 |
| BradB | sabdfl: a guy i used to work with in quebec city is the guy who implemented inheritance in sqlobject. :) | 10:50 |
| BradB | but anyway, does that seem about right? | 10:51 |
| BradB | (there's still some issues though, but i think they come down to validation really, rather than altering the fundamental view i have in mind of how this interface should present info) | 10:52 |
| sabdfl | yes it does | 10:52 |
| sabdfl | hold on a sec | 10:52 |
| BradB | ... | 10:52 |
| sabdfl | ok | 10:52 |
| sabdfl | just checked my implementation of the assignment report | 10:52 |
| sabdfl | i was trying to focus on the bug itself | 10:53 |
| sabdfl | but i can see the point of including the assignment info | 10:53 |
| BradB | the issues i'm referring to are, e.g. what if there's an infestation saying "affected", but the bug isn't assigned to the corresponding package? things like that. i think we can work that out though, because an infestation is, afterall, not a statement of work. | 10:53 |
| sabdfl | that's what i was saying above | 10:54 |
| sabdfl | we are going to have to polish off quite a lot of that stuff | 10:54 |
| sabdfl | figuring out usability | 10:54 |
| BradB | yes | 10:54 |
| sabdfl | people will take time to understand the model | 10:54 |
| BradB | yes | 10:54 |
| sabdfl | they will assume that saying "this version has the bug" is the same as saying "please fix it!" | 10:55 |
| BradB | yes, they may indeed | 10:55 |
| sabdfl | so the "add an infestation" should default to adding an assignment too, say, with a checkbox, that can be removed | 10:55 |
| sabdfl | perhaps if you set "victimised" as the infestation then the assignment is by default not created | 10:56 |
| sabdfl | these are polish items | 10:56 |
| BradB | yes, i was just about to mention that... | 10:56 |
| BradB | i'll focus on coming up with a better listing first off, in any case. | 10:56 |
| sabdfl | do you want me to revamp the bugs assigned report? | 10:56 |
| BradB | sabdfl: i think it'll be folded into the Outstanding Bugs page. | 10:56 |
| BradB | e.g. one field on which you can search will be assignee | 10:57 |
| BradB | and, by default, it may show all the bugs you've been assigned. or not, but either way, another screen won't be needed, i don't think, once this works right. | 10:57 |
| BradB | nor will the screen i created, for the bugs submitted by | 10:58 |
| BradB | i would expect that too to be a field i can search on | 10:58 |
| sabdfl | where is the outstanding bugs page? | 10:58 |
| BradB | It's what the "Bugs" page is now becoming. | 10:59 |
| BradB | er, hm, it shouldn't be called "Outstanding Bugs", I guess | 10:59 |
| BradB | that's just what the default params will retrieve | 10:59 |
| === debonzi [~debonzi@200-158-107-151.dsl.telesp.net.br] has joined #launchpad | ||
| BradB | sabdfl: random though: yeah, a checkbox on an infestation like "[] notify the maintainer of this package" should make the user's life much easier. it would then create the assignment, if needed. | 11:03 |
| BradB | s/though/thought/ | 11:03 |
| sabdfl | yes | 11:03 |
| debonzi | daf, did you file the bug for me? | 11:03 |
| BradB | sabdfl: i'll proceed with modifying the listing then first, to bring it inline with what we've just discussed. | 11:04 |
| daf | debonzi: yeah | 11:04 |
| sabdfl | ok | 11:04 |
| BradB | thanks for the feedback | 11:04 |
| daf | debonzi: https://launchpad.ubuntu.com/malone/bugs/39 | 11:04 |
| debonzi | daf, ohh right.. I was looking for it in the launchpad package :) | 11:05 |
| daf | debonzi: doh, mea culpa | 11:05 |
| debonzi | daf, one question about that bug.. | 11:08 |
| daf | yes? | 11:09 |
| debonzi | the url is www.ubuntu.org because AFAIK it is been used in the ubuntulinux site. | 11:09 |
| daf | the same one? | 11:10 |
| debonzi | I beliave soo.. | 11:10 |
| daf | I mean, the same one for launchpad and for ubuntu | 11:10 |
| daf | ah, hmm | 11:10 |
| debonzi | SteveA did it.. He nows better than me how it is been used.. | 11:10 |
| debonzi | you can even see that I changed the styleshee for forgottenpassword to be the same as www.ubuntulinux.org | 11:11 |
| daf | yeah | 11:11 |
| daf | well, perhaps we should get SteveA to look at it tomorrow | 11:11 |
| debonzi | daf, I belive so | 11:12 |
| debonzi | If he says it is ok too change, its just one line :) | 11:12 |
| debonzi | s/too/to | 11:12 |
| daf | perhaps we can use the magic context things he was talking about to fix it | 11:12 |
| debonzi | daf, yes.. sounds good | 11:13 |
| debonzi | daf, do you know about this magic context ? | 11:13 |
| daf | debonzi: nope :) | 11:13 |
| debonzi | daf, ok.. I ll take a look :) | 11:13 |
| debonzi | daf, request.get("HTTP_REFERER", "") gives me http://localhost:8086/ ... What do you think? | 11:18 |
| daf | debonzi: that's because of the Apache proxy | 11:18 |
| debonzi | daf, I mean... do you think I can use it to compose the email ? | 11:19 |
| daf | debonzi: hmm, I don't think that's reliable | 11:19 |
| daf | debonzi: it's not important -- I suggest we just ask SteveA when we see him | 11:20 |
| debonzi | daf, fine.. lets do that way | 11:20 |
| daf | thanks for taking a look | 11:21 |
| debonzi | daf, welcome | 11:21 |
| === BradB is now known as BradB|afk | ||
| sabdfl | BradB|afk: close to keyboard? | 11:46 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!