=== kiko [~kiko@200-206-134-238.async.com.br] has joined #launchpad [01:29] night === stub [~stub@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad [05:27] Merge to rocketfuel@canonical.com/launchpad--devel--0: ++resource++ URLs should be absolute and favicon (patch-825) === stub [~stub@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad === stub [~stub@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad [10:30] Morning === stub [~stub@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad [10:49] Morning stub [10:49] Yo [10:50] You going to be around long enough to review and merge an sql patch if I commit it soon? [10:50] yup [10:51] cool; I'm just doing my normal paranoid checks before submitting to pqm [10:52] pqm request sent ;-) [10:52] Got comments? :-) [10:53] It's four views [10:53] I wasn't aware comments were needed for views [10:53] If you want them I'll have to do some more [10:56] At the very least it needs 'This is a view used by blah listing all the whatsits with green watchamacallits' [10:56] Oh okay [10:56] give me a sec to hack [10:57] Just stick 'em straight in comments.sql [10:57] before you merge the patch? [10:58] Sure. A few spurious non fatal errors never hurt anyone ;) [10:59] COMMENT ON VIEW blah IS ''; ? [10:59] like that? [10:59] Yup. [10:59] cool [10:59] I caught my pqm request before it hit servers so I'll put them at the bottom of the patch [10:59] I'll sort out any quoting errors or whatever when I do the merge so don't be too paranoid [11:01] *nod* [11:04] pqm merge sent [11:18] Merge to rocketfuel@canonical.com/launchpad--devel--0: Rename some views, merge some, tidy the sqlobject interactions with them. (patch-826) [11:19] that'd be the one === stub gives Kinnison a gold star for his comments [11:39] So - should I make a decision about view naming conventions now, or just be inconsistent ;) [11:39] I recommend being inconsistent [11:40] I offered two conventions in that file [11:40] since I can't choose [11:44] Neither of which match the V* ones I committed for Kiko ;) I guess there are important things to worry about though... [11:46] I guess we will want some indexes in there at some point to speed up those joins.. [11:49] most of the joins are on primary keys but in time we may want indexes too [11:49] I've only tested performance on a single distrorelease (warty) and that seems fine === cprov [~cprov@200.158.100.251] has joined #launchpad [11:53] Morning cprov [11:58] Kinnison: morning === salgado [~salgado@200-206-134-238.async.com.br] has joined #launchpad [12:11] Merge to rocketfuel@canonical.com/launchpad--devel--0: Views for Lucille (patch-827) [12:11] thanks stub === debonzi [~debonzi@200.158.100.251] has joined #launchpad === salgado [~salgado@200-206-134-238.async.com.br] has joined #launchpad === carlos [~carlos@69.Red-80-33-181.pooles.rima-tde.net] has joined #launchpad === lulu [~lu@host217-37-231-28.in-addr.btopenworld.com] has joined #launchpad === salgado [~salgado@200-206-134-238.async.com.br] has joined #launchpad === stub [~stub@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad === kiko [~kiko@200-206-134-238.async.com.br] has joined #launchpad === Kinnison does more db patches for stub [01:07] ALTER TABLE BinaryPackage [01:07] ALTER COLUMN archspecific SET NOT NULL; [01:07] is that right to mark the column as not-null ? === stub [~stub@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad [01:11] Kinnison: I think so [01:11] carlos: ta [01:11] yeah; patch 7 does it that way [01:18] stub: I've sent another pqm merge with another db patch [01:19] stub: if you happen to still be around [01:38] Erm, is pqm b0rken? [01:42] pqm 2349 0.0 0.0 3756 2272 pts/2 S+ Nov18 0:00 -su [01:42] not sure what that means [01:42] that's the only pqm process on chinstrap [01:42] indeed [01:42] (elmo/#launchpad) that's just lifeless with a pqm hell open [01:43] (elmo/#launchpad) err, shell [01:43] I think you were right the first time :-) === Kinnison sighs. 45 gigs to fetch === Kinnison knew he should have kicked off an archive mirror sooner than this [01:55] (elmo/#launchpad) dude, you should have come to the data centre [01:55] lunch time [01:56] (elmo/#launchpad) (when you were in London I mean - it's by far the faster way I know of to get a local mirror :) [01:59] elmo: laptop doesn't have enough room for a full mirror [01:59] my desktop only has 5 gigs more than this mirror will need spare right now [01:59] I'm tempted to say "sod this" and just hammer mawson instead [01:59] (elmo/#launchpad) use zhongshan? === Kinnison looks to see if that mirror is enough [02:01] yeah; sod it; that'll be enough === Kinnison ruffles elmo for being the voice of reason [02:04] elmo: any idea why pqm hasn't done my merge-request yet? [02:05] (elmo/#launchpad) it thinks it has [02:05] (elmo/#launchpad) tabnanny failed [02:05] (elmo/#launchpad) ---- tabnanny bitching ---- [02:05] (elmo/#launchpad) /home/pqm/arch/queue/workdir/rocketfuel@canonical.com/rocketfuel@canonical.com---launchpad--devel--0/launchpad/lib/canonical/launchpad/scripts/gina/clas [02:05] (elmo/#launchpad) ses.py 299 '\tif len(data) == 0:\n' [02:05] (elmo/#launchpad) /home/pqm/arch/queue/workdir/rocketfuel@canonical.com/rocketfuel@canonical.com---launchpad--devel--0/launchpad/lib/canonical/launchpad/scripts/gina/grab [02:05] (elmo/#launchpad) ber.py 136 '\t try:\n' [02:05] aah [02:06] Kinnison, WHAT ARE THOSE TABS DOING THERE? [02:06] why didn't 'make check' catch those? [02:06] elmo: was pqm meant to forward that info back to me? [02:07] (elmo/#launchpad) Nov 22 12:21:28 chinstrap postfix/smtp[26745] : 1C8AFEE806F: to=, relay=adelie.warthogs.hbd.com[82.211.81.139] , delay=0, stat [02:07] (elmo/#launchpad) us=sent (250 Ok: queued as 33288192C01C) [02:07] boggle [02:08] (elmo/#launchpad) you're bouncing it [02:08] (elmo/#launchpad) Nov 22 12:21:28 adelie postfix/smtp[16595] : 33288192C01C: to=, relay=mx.pepperfish.net[195.149.39.198] , delay=0, status=boun [02:08] (elmo/#launchpad) ced (host mx.pepperfish.net[195.149.39.198] said: 550 rejected: cannot route to sender: response from fiordland.warthogs.hbd.com [82.211.81.145] was 550 [02:08] (elmo/#launchpad) : Recipient address rejected: User unknown in virtual alias table (in reply to MAIL FROM command)) [02:08] (elmo/#launchpad) meh [02:08] aah because the sender is unroutable [02:12] Kinnison: I want you to get a screwdriver and lever your "tab" key from your keyboard. [02:12] it's what I do ;-) [02:12] SteveA: emacs does the right thing for me [02:12] SteveA: I blame vim on mawson === SteveA wonders about tests for the test_on_merge.py script. [02:13] I'd very much like it if 'make check' would rant about tabs [02:13] It does! [02:13] why didn't it rant at me I wonder [02:18] Merge to rocketfuel@canonical.com/launchpad--devel--0: Gina bits and a db patch for binarypackage, fixed tabs in gina too (patch-828) [02:18] woo [02:18] elmo: it's working now [02:19] stub: fancy reviewing that patch? [02:19] sure [02:19] ta === Kinnison sets about doing scary things to gina so she supports multi-arch [02:26] Kinnison: Can we make the new column processorspecific instead of archspecific? We are already using arch for arch, and using arch as an abbreviation for architecture will be confusing. [02:27] stub: either that or architecturespecific [02:27] Hmm... although we already have distroarchrelease [02:27] in fact, I would prefer architecturespecific [02:28] ok. I'll put it through as architecturespecific [02:30] elmo, did you not get my request to admins@? [02:33] (elmo/#launchpad) the one you sent on Friday? [02:38] elmo, yes, for salgado. [02:38] he starts this week [02:40] (elmo/#launchpad) I've started what I have to do on my end [02:44] thanks. [03:02] Merge to rocketfuel@canonical.com/launchpad--devel--0: BinaryPackage.architecturespecific for Gina (patch-829) [03:03] elmo: any chance you can either make me a postgres superuser on zhongshan or do some stuff for me on template1 ? [03:05] (elmo/#launchpad) done the former [03:05] (elmo/#launchpad) do you want a less 1980's copy of the archive too? [03:05] That'd be ace if you could; I think the copy is okay but an update would be nice [03:09] (elmo/#launchpad) hmm, I'm going to have to move it, fyi [03:10] that's fine [03:10] (elmo/#launchpad) /srv/archive.ubuntu.com/ -> /srv/archive.ubuntu.com/ubuntu/ to match mawson and generally be sane [03:10] yeah === stub [~stub@dsl-246.248.240.220.dsl.comindico.com.au] has left #launchpad [] === Kinnison starts doing deep and scary changes to gina === Kinnison realises why he hasn't been workraved yet === Kinnison reenables workrave [03:34] hmmmm [03:35] morning [03:35] the new rosetta's favicon is really funny, but I'm not sure it should be used in our public release :-P [03:35] BradB: morning [03:35] ohh, it's not rosetta's favicon but launchpad one [03:37] SteveA: around? [03:38] hi carlos [03:38] SteveA: hi [03:38] I'm about to have a phonecall with daf. can it wait a little while? [03:38] yes [03:50] elmo:zhongshan is full dude :-( [03:50] elmo: It's possible that rsync failed :-( [03:51] elmo; I'm emptying my test pool; can you repeat the archive sync to be sure it's complete? [03:51] (elmo/#launchpad) boggle [03:52] elmo: zhongshan only has a 67 gig drive [03:52] well a 67 gig / partition [03:52] (elmo/#launchpad) *BOGGLE* [03:53] (elmo/#launchpad) we're at 45Gb for archive.u.c/ubuntu already [03:53] yeah [03:53] scary eh? [03:53] (elmo/#launchpad) RUN AFUCKINGWAY [03:53] I've freed 17 gigs on zhongshan [03:55] (elmo/#launchpad) is zhongshan any use to use, with what little space will be left ? [03:56] yep [03:56] (elmo/#launchpad) ok [03:56] (elmo/#launchpad) well, mirror's rerunning now [03:56] I'm prototyping the multi-arch gina [03:56] I can just turn off the librarian integration for the duration [04:04] elmo: any hint to enter on mawson using my local ssh certificate as I do to enter chinstrap? [04:04] (elmo/#launchpad) carlos: cat .ssh/id_rsa.pub | gpg --clearsign | mail change@db.warthogs.hbd.com [04:05] elmo: I did it already, but I need to use chinstrap to reach mawson [04:05] and my local certificate is not used, but the one at chinstrap [04:05] (elmo/#launchpad) uh? [04:06] Host mawson [04:06] ProxyCommand ssh chinstrap nc -q0 %h %p [04:06] Hostname mawson.ubuntu.com [04:06] BradB: I know it's late... but happy birthday :-) [04:06] is what I have in my .ssh/config [04:06] (elmo/#launchpad) you are using the proxying instructiosn on wiki.canonical.com/MachineOverview right? [04:06] elmo: didn't know about that [04:06] O:-) [04:06] Kinnison, elmo thanks, I'm going to read it now [04:12] carlos: thanks :P === kiko is now known as kiko-fud === Kinnison runs the first multiarch test [04:22] this one doesn't cope with arch-indep debs but it's a good start === bob2 [rob@bob2.user] has joined #launchpad [05:20] aloha [05:20] I broke launchpad again [05:23] after "make" in the db schema dir, then "make build run" in the root, I get an exception when doing anything on the DOAP page [05:26] Is spiv on holiday? [05:27] BradB: yes [05:27] bob2: That explains why it's broken then. :) [05:28] bob2: The deal is, if $app is broken, it's because $developer didn't provide a complete enough test suite for his $app, and thus we were able to checkin a change that made $developer's $app break. [05:29] :-P === carlos leaves for a while [05:29] later [05:30] BradB: hah [05:31] BradB: should I send $developer a backtrace? [05:31] bob2: no. https://launchpad.ubuntu.com/malone/bugs. [05:32] BradB: ah === bob2 rummages around for the cert === BradB reads up on XML-RPC in Z3 [05:43] BradB: hrm, is my login the same as the website's? === sabdfl [~mark@host217-37-231-28.in-addr.btopenworld.com] has joined #launchpad [05:44] BradB: i have a present for you [05:45] really! :) [05:46] (elmo/#launchpad) doh. poor Brad. if it's anything like the "gift" Colin got.. ;-) [05:46] heh heh [05:49] can non-LP people login to the malone dogfood server? [05:49] (elmo/#launchpad) no [05:49] (elmo/#launchpad) why? [05:49] erm, to the LP web thing, not ssh [05:49] bob2: do you have an account on ubuntulinux.org? it's the same one. [05:50] ah [05:50] (elmo/#launchpad) yes - it's just protected by a clientside cert, which is in the mailing list archives [05:50] yeah, I have thgat [05:50] but I need to login to report the bug, but I guess I've just misremembered my password [05:51] ah, perfect [05:52] bob2: you can report the bug on the launchpad product perhaps. we don't have products for DOAP or FOAF, i don't think. [05:53] elmo: that's the gift that keeps getting given ;-) [05:53] BradB: its a dump of a malone db with a couple thousand bugs sync'd from debbugs [05:53] BradB: yeah, that's what I was doing [05:54] 24,000 messages [05:54] LP seems really slow [05:54] 7,000 bugs [05:54] New Malone bug #59: "DOAP pages cause an exception.", submitted by Rob Weir [05:54] https://launchpad.ubuntu.com/malone/bugs/59 [05:54] woo [05:55] its a nice taste of malone-for-distro-team [05:55] sabdfl: and it won't wipe my hard drive, right? :) [05:55] BradB: *shouldn't* [05:55] i need lots of people, since that's what i'm testing currently. === BradB writes up the doc on how to search for people with XML-RPC [05:57] wtf is up with the bugs on 44bsd-rdist? [05:57] BradB: i will extend my debbugs sync script to add all the relevant people, then you'll have *plenty* [05:57] but for the moment, let's work with this snapshot [05:58] ok. where do i get it when i need it? [06:00] carlos: please ping me when you're back === kiko-fud is now known as kiko [06:06] bugs 56 and 59 seem to have been attached to 44bsd-rdist somehow [06:08] People who know something about FOAF: the thing that contains people in Launchpad, what's it called? [06:08] I see IPersonSet, but it isn't clear that there's any implementation for any of that yet, and thus I'm not sure if it's really been blessed as the thing on which to search for people. [06:08] implementation on a search page somewhere, that is. [06:11] sabdfl: dude, are you /sure/ you don't want to remove summary from the bug reporting page? :) for every person that's reported a bug thus far in malone (including me) they've either 1. begged for summary to be optionally, if even on the bug add form at all and/or 2. written a summary that precludes the need for having to explicity say #1. :) [06:11] s,optionally,optional, [06:12] BradB: ask me this again after we have outside users for a month, ok? [06:12] ok [06:12] also, make sure you are using the summary wherever it is possible [06:12] in other words, presenting it in the UI in sane and sensible places [06:12] i think it adds a level of quality that other bug trackers don't have [06:12] yeah. i haven't yet found those places, but i'll keep it in mind. [06:13] if you are not presenting the info anywhere, then it's useless to ask people to capture it [06:13] i think there's a lot of value in having a one-paragraph summary of a bug [06:13] but that value is only shown when that one paragraph appears in all the right places [06:13] if anything, i could perhaps see stealing the first paragraph of the report itself as the summary. [06:14] but good bug reporters know very well that the title of the bug has to tell me what this bug is about. [06:14] as the initial summary perhaps, and then allow people ample opportunities to improve it later. [06:14] in my reports, i print the title, and use a tooltip for the summary [06:14] I know I've used bugtrackers of upstreams that I use, but don't contribute to, and I've wanted to improve the summaries on their bug reports when I've found the wrong or the right bug I'm looking for [06:15] here's my proposal, sabdfl, SteveA, BradB [06:15] but if it is too much hassle to do so, then I won't [06:15] use by default the initial comment as the bug summary [06:15] and allow it to be edited later separately [06:15] I always dreamed of doing this for bugzilla [06:15] the initial comment is the bug summary and it's immutable [06:15] at this stage we don't have any clear guidelines on the form as to WHAT info to put in summary vs description [06:16] well, the user won't read any guidelines anyway.. [06:16] Users Don't Read, remember. :) [06:17] heck, i wouldn't even bother reading that. i don't care much about being nice to a bug tracker. i just want it to get out of my way, like just about everything i do that involves a computer. [06:17] they will, if it's in the text box already [06:17] it has to be something obvious. description is obvious; title and description is sufficiently obvious, title, summary and description are less so. [06:17] sabdfl, Jacob Nielsen would slap you on the wrist if he heard that :) [06:18] he would find my wrist is a little less limp than his own [06:18] he's not limp-wristed personally, in fact [06:19] ok, if nobody says otherwise, i'm writing a PersonContainer for FOAF, because i see nothing else that contains people. [06:19] er, no, i'm not. i'm going to test something that already has a container that i know of instead. :) [06:21] BradB, salgado is starting on FOAF tomorrow, if you'd like to assign to him. === SteveA wonders if updating summaries to existing bugs to be better on-target is like slashdot moderation. something someone can do a little of from time to time, and receive karma. [06:21] sure. i don't really know how to report this as a bug though, as i don't know enough about FOAF to say how it should work. [06:25] kiko: Where's IProduct{Set,Container}? i.e. What did you guys /really/ call it? [06:26] BradB, just report it saying what you need, we'll sort out the rest. [06:26] daf, carlos: let's talk about rosetta on #canonical-meeting in 30 minutes' time. (1600 UTC) [06:26] kiko: ok [06:26] BradB, soyuz doesn't actually deal with products except when linking to rosetta and malone, you know. :) [06:26] let's use IxxxSet rather than IxxxContainer as our convention. [06:27] ok, I'll go with ISourcePackageSet then [06:28] There are a few interfaces / implementations with "Container" in them. debonzi, can you take on renaming these to "Set" instead? === Kinnison tries multiarch-gina again [06:28] SteveA, sure [06:29] debonzi: so we have IBugExternalRefContainer in malone, and that should be changed to IBugExternalRefSet whereever it occurs. [06:29] for example. [06:30] BradB: scp chinstrap:~mark/launchpad_dev.20041122.sql.bz2 . [06:30] SteveA, Right.. Ill d that [06:30] this only applies to code that is to do with soyuz, malone and rosetta. not to other launchpad application system code, such as in lib/canonical/launchpad/webapp/session.py we have LaunchpadSessionDataContainer [06:31] SteveA: yes, bug editing would definitely give you karma [06:31] because a LaunchpadSessionDataContainer is a different kind of thing, and should stay as it is. Basically, stuff in canonical/launchpad/webapp should stay as it is [06:31] thanks debonzi [06:31] that's what salgado should be working on [06:31] so would linking malone bugs to upstream, etc [06:32] New Malone bug #60: "FOAF needs a search interface exposed via XML-RPC", submitted by Brad Bollenbach [06:32] https://launchpad.ubuntu.com/malone/bugs/60 [06:33] why xmlrpc? [06:33] for the super widget [06:33] why not just an http GET ? that should be compatible with more browsers, and be simpler to implement. [06:34] there have been a bunch of discussions about this already [06:34] SteveA: manually parsing the response in JS? [06:35] when kiko and mark and I last discussed this, we talked about returning the response in a way that is easy to parse with javascript [06:35] we were just talking about this last week. nobody mentioned anything about not using XML-RPC. [06:35] I think kiko suggested passing back a javascript array [06:35] I sure did. [06:36] but, the transport really should make no difference. far fewer browsers support xmlrpc for javascript than support doing HTTP, and there is much less complexity on the server, and in the handling of things like authentication. [06:37] SteveA: ping [06:37] hello carlos [06:37] hi [06:37] I'd like to have a meeting with you and daf about rosetta on #canonical-meeting, in 20 minutes time [06:37] ok [06:38] kiko: you mean the reponse is a data structure that would be eval'd (or whatever the JS equivalent is) into a JS array? [06:39] s/is a/is text that looks like a/ [06:39] yes, that would be it. a bit nasty using eval, but it's not too slow. [06:40] this, using an HTTP GET, ought to be a simple thing [06:40] kiko: nasty indeed. seems pretty insecure. [06:40] insecure how? [06:41] the javascript is being served from our server. it is data coming from our server that gets evaled by the javascript interpreter in a browser. then later, it is getting more data from our server, and evaling it. [06:41] SteveA: for all the different things that will need to be searchable and their corresponding data returned in this eval'd data structure, it seems to be asking for a quoting attack. [06:42] I really can't see how. You have a function in JS that gets data from a particular URL and evals it. [06:42] I don't see what there is to attack. [06:42] SteveA: javascript insertion? [06:43] I don't see what you mean. [06:44] SteveA: like an sql insertion attack, but with javascript instead. is that easy to avoid here/ [06:44] the javascript is not executed on our server. [06:44] so? :) [06:45] I do not see a possibility for anything that resembles an sql insertion attack [06:46] SteveA: as long as people exposing the GET interfaces are cautious to quote the return values correctly, it should be okayish. there's an elevated risk here though, no doubt. [06:47] SteveA: e.g. if I entered my name as 'Brad "); ...some nasty js here...' or some such. [06:48] I was under the impression that sqlobject should pretty much prevent an SQL injection attack [06:48] Kinnison: there's no sql injection attack going on here. [06:49] Oh you're talking HTML injections? [06:49] i said a javascript injection attack. :) the same /idea/ as an sql insertion attack, but on javascript, not sql. [06:49] one would hope all values heading back out got HTML encoded yes === BradB is now known as BradB|lunch [06:53] BradB|lunch: ping when you're back [06:54] sabdfl: didn't quite head out the door yet. [06:54] what's up? [06:54] a bunch of things that used the ownerID trick have busticated recently [06:54] busticated how? [06:54] in which app? [06:54] hmm... [06:54] go into doap [06:55] search for a project [06:55] click on a product [06:55] look on the left, see the "File A Bug.." link [06:55] click on it and file a bug [06:55] boom [06:55] who didn't test that? === Kinnison sprinkles another commit or two into gina [06:57] BradB|lunch: the page tests still work [06:57] ouch :/ [06:57] because if you POST the correct things to the form, it still works [06:57] i think it has to do with the rendering [06:57] this is where we want to use the normal addform, but we want to add the owner to the object, owner being the request principal [06:58] i copied what i thought was your example on how to do that [06:58] BugFactory does that already. I've already filed a bug saying that things that add bugs need to use BugFactory. [06:59] [06:59] so should I rework that form to use BugFactory? [06:59] that would close a bug, so yeah, i think it'd be a good idea [06:59] hmm... it seems to do so already [07:00] sabdfl: the first thing to do is make sure the relevant test fails though. [07:01] there is no test for this part of the machinery [07:01] ...or create one, as necessary :) [07:01] eh, which i guess means fixing it first then [07:02] hmm... old on, further debugging suggests the problem lies elsewhere [07:03] ok [07:03] this is interesting [07:04] in the zcml for the addform, i gave both a class= and a content_factory= [07:04] the view class has a createAndAdd method, which is what is being called [07:04] it does not seem to be calling the content_factory (which was BugFactory) at all [07:06] SteveA: what are the rules for an addform with both a class= and a content_factory=? [07:06] Merge to rocketfuel@canonical.com/launchpad--devel--0: Librarian wrapper for Lucille (patch-830) [07:06] sabdfl: createAndAdd is what properly calls the content_factory :) [07:07] you don't want to override both [07:07] ok, i'll try leaving out the class [07:07] the template calls view/update, which will call createAndAdd, inside which a call to self.create calls the actual factory. if you provide createAndAdd on your view /and/ a content_factory, it will not do what you expect. [07:08] sabdfl: wow, what hugely complex code the zcml addform directive has behind it [07:09] BradB|lunch: well here's the challenge [07:09] i'm doing the "file a bug ON A KNOWN PRODUCT" age [07:10] url would be something like /doap/projects/foo/bar/+filebug [07:10] "file a bug on product bar of project foo" [07:11] you're doing exactly the same as what a normal bug add is, but you're just molding the UI around a bit to make a shortcut off a bug. if anything, perhaps you can simple store the product id in a hidden field in the form. [07:11] s,simple,simply, [07:11] s/off a bug/off a product/ # heh [07:12] point being though, the code should be structured in such a way that 1. we don't duplicate any templates, hopefully, and 2. by the time BugFactory is called, it all just Does The Right Thing (i.e. the params have been provided to BugFactory correctly by the caller) [07:13] in an add form, the default implementation of self.create(*args, **kw) is to call the content_factory [07:13] BradB|lunch: i don't think auto-generated forms, on their own, are going to be good enough for us [07:14] the reality is that i spend large amounts of time trying to bend the form machinery to do what i want [07:14] SteveA: we've got that part figured out already. sabdfl overrode createAndAdd on his view class, which precludes calling the factory, hence the problem. [07:14] in this case, storing a "hidden id" seems so ugly [07:14] sabdfl: why!? [07:15] well, for a start, it's likely to expose the db id of the product, which i'd rather not do [07:15] so, you need to call self.create from your new createAndAdd [07:15] SteveA: is that all? [07:15] sabdfl: they're exposed everywhere already. if we need to fix that, we can, which would include fixing how it would be presented when a hidden id. [07:15] sabdfl: the point is that you probably didn't mean to override createAndAdd :) [07:15] the default case just says: content = self.create(*args, **kw) [07:16] i did intent to override createAndAdd [07:16] sabdfl: why? [07:16] because in this case I not only want to create a bug, i want to create the ProductBugAssignment too [07:16] sabdfl: i already solved that problem though. [07:17] SteveA: i think i looked into the default implementation [07:17] sabdfl: trust me. we have rules about how a bug is add. those rules are explained in BugFactory. whereever you create bugs from the UI, you should be using BugFactory, so that when those rules change, they change consistently everywhere. [07:18] sabdfl: if his means that in your shortcut-UI you store a hidden id, then it's worth our time to do that, and it's perfectly sane to do so. [07:18] ok, i think i can just add product to the **kw and call BugFactory [07:19] sabdfl: if you don't like the fact that we expose ID's in our HTML, then we'll fix the tokens that vocabs use. this will automatically fix the hidden field value (because that's just a token from a vocab) [07:19] s/ID's/IDs/ [07:20] sabdfl: why not just store it as a hidden field? i don't understand why we want to write duplicate code in there for nothing. surely the Z3 machinery has an easy way to say "save these request params as hidden fields in the form". [07:21] then your link to add a bug simply passes the relevant token. === BradB|lunch really goes for lunch now [07:25] BradB|lunch: when you're back, take a look at that db dump and let's walk through malone using that many bugs [07:25] sabdfl: did you call the default implementation from your own code, or did you entirely override it? === sabdfl will have to ask kiko for help on indexes etc [07:26] SteveA: entirely overrode it [07:26] ceck in browser/product.py [07:26] sure. [07:26] ProductFileBugView [07:27] nice security code ;-) [07:27] def notify_bug_added(bug_add_form, event): [07:28] sabdfl, I can take a look at some queries when you need me to. [07:28] SteveA: give me something better to work with ;-) [07:28] will do RSN [07:28] kiko: we're just getting to the OOOOFFF point you guys hit when you first rn gina [07:30] sabdfl: maybe you could have done it by adding your own code, but calling the original to do its work in between [07:34] stevea: i'm trying to fix this function: [07:34] def notify_bug_added(bug_add_form, event): [07:34] is bug_add_form a dict? [07:35] if bug_add_form.owner: [07:35] owner = bug_add_form.owner.displayname [07:35] if bug_add_form.sourcepackage: [07:35] spname = bug_add_form.sourcepackage.sourcepackagename.name [07:35] if bug_add_form.product: [07:35] pname = bug_add_form.product.displayname [07:35] these lines will fail if the form *didn't* get a source package or product [07:35] it cannot be a dict [07:36] can i change these to bug_add_form.get('fieldname', None)? [07:36] if it were a dict, it would read bug_add_form['owner'] : etc. [07:36] ah, right [07:36] wtf is it then? [07:36] I don't know. try asking the debugger? [07:36] an instance? === Kinnison cries and beats up on gina with a stick [07:36] :) [07:36] right [07:36] kiko: you'll be the FIRST person i ask next ;-) [07:36] Kinnison, behave or I'll let you have no more fun with her today. [07:37] (Pdb) print bug_add_form [07:37] [07:37] there you have it. [07:37] whouldya look at that? [07:37] you want hasattr() I suspect. [07:37] kiko: but but but she is completely and utter fucked from a multi-arch PoV [07:37] tnx :-) [07:38] hasattr is evil. it eats exceptions [07:38] hasattr(bug_add_form, "sourcepackage") ? === Kinnison keeps finding places where he has to add in scary joins so she believes she has a binarypackage worth adding === Kinnison runs her again [07:38] maybe you want getattr(fieldname, None) [07:38] SteveA, well, what do you suggest -- this is going to raise AttributeError, isn't it? [07:38] slightly less evil than hasattr [07:38] then it's: [07:38] if getattr(bug_add_form, "sourcepackage", None) is not None: [07:38] ... [07:38] (but I hate that) [07:38] yeah, of course [07:39]