/srv/irclogs.ubuntu.com/2004/12/14/#launchpad.txt

BradBok12:01
carlosbut I don't know the city so don't know a good place to buy it outside big stores that are also in Valencia12:01
BradBat worst, lamont's bringing me one, but i was hoping to have my own12:01
BradBcarlos: how commonly spoken is french in spain?12:02
carlosBradB: zero12:02
carlosBradB: but Catalan is close to French (some words) so perhaps you could understand somethings12:03
BradBdamn! i would have thought sort of popularish, given that the francophones i know learning spanish say it's really easy to learn spanish once you know french, thought it might be reciprocal12:03
carlosBradB: the problem is that Catalua has its own language, thus they usualy learn Spanish, Catalan and English 12:04
carlosBradB: in other Spanish regions where don't have a local language, they learn Spanish, English and French12:05
BradBah12:06
BradBsabdfl: I can't figure out if logging everything (in BugActivity) that gets added to a bug (an assignment, an infestation, a web link, etc.) makes sense or not. What do you think?12:27
Kinnisonsabdfl: I'll try and make the time up on saturday instead then.12:38
=== kiko_bz is now known as kiko
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: Small improvements to the potemplate add/edit forms (patch-934)01:33
=== stub [~stub@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad
stubBradB: ping02:11
=== kiko [~kiko@200-206-134-238.async.com.br] has joined #launchpad
=== Signon time : Thu Dec 2 08:38:37 2004
=== Signoff time : Fri Dec 3 06:27:18 2004
=== Total uptime : 0d 21h 48m 41s
=== warthylog [~warthylog@port49.ds1-van.adsl.cybercity.dk] has joined #launchpad
=== Topic for #launchpad: lunchpad: home of the sandwich artists | fogo na bomba | "qorking along happily, with SteveA egging us on"
=== Topic (#launchpad): set by sabdfl at Tue Oct 19 11:05:38 2004
=== warthylog [~warthylog@port49.ds1-van.adsl.cybercity.dk] has joined #launchpad
=== Topic for #launchpad: lunchpad: home of the sandwich artists | fogo na bomba | "qorking along happily, with SteveA egging us on"
=== Topic (#launchpad): set by sabdfl at Tue Oct 19 11:05:38 2004
sabdflmorning all09:44
sabdflBradB: log only what you think makes sense, we'll get user bug requests if they think they want to see something in there that we are not logging and can deal with those on a case by case basis.09:46
sabdflstub: around?10:01
stubsabdfl: Yup10:01
sabdfldid you get a chance to look at mark-project-refactor.sql?10:01
stubYes - emailed you about it10:02
stubIts already to put it in if we want.10:03
stubMy main concern is when I checked the documentation on the project table, it looked like we could no longer reasonably support some of the original use cases (gnome project's website product, kde project's website product) without people having to use the project name as a prefix for some or all of their products.10:05
=== silbs [~sbsm0084@host217-37-231-28.in-addr.btopenworld.com] has joined #launchpad
=== ddaa [~ddaa@host217-37-231-28.in-addr.btopenworld.com] has joined #launchpad
stubsabdfl: Is that manifest patch waiting on me btw? I don't remember getting an 'its ready' but may have missed it.10:09
lifelesssabdfl: those areones brought in previously as we'd agreed. bob2 will be working on them today.10:11
bob2yup10:12
sabdflstub: no, i am going to work on code with keybuk today, then we'll know it's ready10:29
sabdfl(the manifest patch)10:30
sabdflstub: new version of the projectless patch will be in as soon as pqm is ready10:30
sabdfli've dropped the old UNIQUE (project, product.name);10:31
sabdfland added comments10:31
stubDid you get my modifications? Or are we going to get a clash10:31
sabdflstub: need some manual tinkering with the production db at some stage10:31
sabdfli refueled just before modifying it, had you comitted?10:32
stubYes - but I don't know if it got through in time (I hadn't noticed my first commit bounced due to forgetting to update launchpaddatabaserevision earlier today)10:33
stubSee what happens10:34
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: bugassignment table and bugactivity tweak (patch-935)10:35
stubI win. 10:36
stubsabdfl: I think your patch will conflict. Email me the file and I'll sort it at my end.10:37
sabdflbugger10:55
sabdfl:-)10:55
sabdfli'll have to resolve the conflict anyhow10:55
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: update project refactoring patch for stub (patch-936)11:04
SteveAsabdfl: do you think we'll have malone working as the ubuntu bug tracker later this month?11:14
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: Soyuz classmethod clean up done. All classmethods used before for Soyuz app componentes has been removed. Other solutions has been used like utilits as sugested by SteveA. Thanks SteveA. (patch-937)11:55
=== carlos [~carlos@69.Red-80-33-181.pooles.rima-tde.net] has joined #launchpad
carlosmorning11:57
dilysMerge to rocketfuel@canonical.com/cscvs--devel--1.0: production fixes to the gnarly port (patch-42)11:58
SteveAhi carlos11:58
SteveAyou pingged me, but I was asleep11:58
carlosSteveA: yes, it was about the mail I sent you later11:58
carlosthe file upload problem11:58
SteveAokay, I'll take a look at it.  It does seem very strange that adding another field to the form stops it working properly.12:03
SteveAwhat browser are you using?12:03
carlosSteveA: no, it does not stops working , the forms works, but the upload field does not work like it should12:03
carlosSteveA: epiphany12:04
carlosthe old upload form works always12:04
SteveAthat's what I mean by "stops working properly"12:04
SteveAcan you try it with firefox?12:04
carlosbut my template creation form with that upload field does not handles the upload12:04
carlosok12:04
carlossure12:04
SteveAdaf had a similar problem earlier with epiphany, and it seems to be a problem with epiphany12:04
=== debonzi [~debonzi@103.21.77.83.cust.bluewin.ch] has joined #launchpad
carlosSteveA: it works now so I could assume that it's epiphany's fault12:09
SteveAdo we have any epiphany hackers on the warty/hoary team?12:09
carlosI thought it was not the problem because daf had a check to prevent it, but it does not work. I will fix it now12:09
SteveAmaybe they've come across this problem before.  perhaps it is a reported bug12:10
carlosSteveA: don't know12:10
SteveAif we knew more about it, perhaps there's a way of working around it12:10
carlosI could check that with seb12812:10
carlosSteveA: I will do a check to see if it's a file like object or a unicode instance12:11
carlosif it's a unicode instance will show a warning saying that the upload failed12:12
carlosthat should stop breaking launchpad12:12
SteveAthat's a good idea12:12
carlosas soon as we know if there is a way to fix work around it we could change it later12:12
carlos /s/fix/ /12:13
SteveAactually, here's what I want you to do.12:13
SteveA1. file a bug in malone on this.  this is okay, even if it isn't our bug, as we need to resolve it one way or another.12:13
SteveA2. put your workaround in the code, and write a comment in there saying why this is there, and making reference to the bug in malone12:14
SteveA3. write a message to the launchpad mailing list describing the problem and the workaround and the bug, so that everyone else on the team knows about it12:15
SteveAwe can get seb128 to look at it in mataro12:15
carlosok12:15
=== salgado [~salgado@200-206-134-238.async.com.br] has joined #launchpad
carlosSteveA: I have other problem that prevents me to reduce code duplication12:16
carlosI'm not able to do a "from canonical.rosetta.pofile_adapter import foo"12:17
carlosfrom canonical/launchpad/database/pofile.py12:17
carlosbecause canonical/rosetta/__init__.py imports the class Project12:18
carlos"from canonical.launchpad.database import Product"12:18
carlosand seems like it's not ready at that point12:18
carlossorry, Product, not Project12:18
SteveAwell12:19
SteveAI see the problem12:19
carlosI know I could fix it with: "from canonical.launchpad.database.product import Product"12:19
SteveARosettaApplication has changed from being a "placeholder application object" that doesn't do anything but have some views12:19
SteveAinto a database object that directly uses SQL12:19
carlosbut I know that we are trying to prevent those imports12:19
SteveASo, RosettaApplication needs to move in to the launchpad/database area12:20
SteveAor, that code (the translatables method) needs to be separated from it somehow12:20
SteveAthe way I'd do this is as follows12:20
SteveA* keep RosettaApplication where it is12:20
SteveA* make translatables() part of the IProductSet interface and the ProductSet class.12:21
SteveA* make RosettaApplication use this by looking up getUtility(IProductSet)12:21
SteveAso, we get to keep RosettaApplication where we expect to find it12:21
carlosand it does not depends on the sql code directly12:22
SteveAand the translatables() method is also in a reasonable place, seeing as it is to do with products12:22
SteveAyes12:22
carlosI get the idea, ok.12:22
carlosthanks12:22
carlosSteveA: seb says that it's the first time he knows about that epiphany bug and he says he don't have a problem with bugzilla uploading files from it12:30
=== stub [~stub@dsl-246.248.240.220.dsl.comindico.com.au] has joined #launchpad
=== SteveA [~steve@adsl-213-190-44-43.takas.lt] has joined #launchpad
=== SteveA [~steve@adsl-213-190-44-43.takas.lt] has joined #launchpad
dilysMerge to thelove@canonical.com/bazaar--devo--1.1: Now baz changes does a tree-lint (patch-23)12:57
=== cprov [~cprov@200.158.100.251] has joined #launchpad
salgadoif I do a "baz delta --diffs patch-998 patch-999" where neither of these patchlevel exists, I got a "corrupt archive" error.01:16
salgadobut if I specify launchpad--devel--0--patch-99{8,9} it tells me that these patchlevels doesn't exist(exactly what I expected).01:17
salgadois this intensional behaviour?01:17
=== kiko [~kiko@200-206-134-238.async.com.br] has joined #launchpad
=== debonzi [~debonzi@103.21.77.83.cust.bluewin.ch] has joined #launchpad
SteveAcarlos: heard of "trados" ?02:44
carlosSteveA: context?02:46
SteveAtranslation tool02:46
SteveA<srichter> my wife is a linguist  and she works with Trados02:46
SteveA<srichter> the defacto standard for translators and linguists02:46
SteveA<SteveA> standard of what?02:46
SteveA<srichter> of a translations tool02:46
SteveA<srichter> one of its main functionalities is the translation memory02:46
SteveA<SteveA> okay.  I'll ask the rosetta team about it.02:46
SteveA<srichter> you put a document in and Trados records Translations of sentences of this document02:46
carlosyes02:46
carlosI think some people was talking about it at gnome mailing list02:47
carloslet me check02:47
carlosyeah. I know that the name was familiar for me02:49
carlosI think it's the most used application to do translations02:49
carlosit's a commercial tool02:49
SteveAwe should try to look at it sometime02:49
carloshttp://www.trados.com/02:50
BradBstub: pong03:00
BradBsabdfl: yes, i've been following some ideas to keep the bug changelog fairly simple03:00
stubeh? Oh - I emailed you about that (and then Mark said on the mailing to do it the way I did anyway)03:01
BradBcatching up on email now03:02
stubPatch is in, but the bug migration isn't03:02
=== salgado is now known as salgado-afk
=== kiko is now known as kiko-afk
dilysNew Malone bug #116: "Upload fails sometimes from epiphany", submitted by Carlos Perell Marn03:44
dilyshttps://dogfood.ubuntu.com/malone/bugs/11603:44
KinnisonIs there a standard login on the dogfood server?03:46
stubUrgh... I thought my merge went through hours ago - bounced :-(03:49
stubKinnison: Real accounts please03:50
Kinnisonstub: real accounts?03:50
BradBstub: UNIQUE(project, name) will allow dup names for products that don't have projects. Is that something we want to allow?03:50
BradBI'm guessing not.03:50
stubNot a shared one - yours.03:50
=== Kinnison looks
stubBradB: No. My bad.03:52
Kinnisonstub: the forgotten password thing mails me an ubuntulinux.org change url03:52
stubYer - you need to create your account in launchpad_dogfood or con someone else into doing it for you.03:53
KinnisonBut apparently the password I last thought of was correct03:53
BradBKinnison: dude, you already bypassed the forgotten p/w and manually reset your p/w in the dogfood db, IIRC :)03:54
stubBradB: product.name is about to become UNIQUE anyway - patch should have gone through a few hours ago but I didn't check that mailbox ;)03:54
KinnisonBradB: it seems so03:54
BradBstub: So product names will be *globally* unique?03:54
stubBradB: Yup03:54
KinnisonBradB: I forget these things when using a different browser :-)03:54
=== Kinnison has taught his desktop the login data now ;-)
BradBKinnison: heh heh03:55
BradBstub: hm, interesting :)03:55
BradB     * jblack@gnuarch.org--2004/baz--lintchanges--1.1--patch-103:58
BradB       Now baz changes does a tree-lint03:58
BradBfinally! :)03:58
stubBradB: We arrive at Barcelona at the same time. Look out for the unshaven dude with stupidly long hair and a Zope T-Shirt.04:01
BradBwicked!04:02
BradBI just shaved yesterday, but I might be too lazy to shave again once the con gets under way.04:02
kiko-afkI mean04:04
kiko-afkSERIOUSLY long hair04:04
carlosX-)04:05
dilysMerge to thelove@canonical.com/bazaar--devo--1.1: By default show qualified revisions (patch-24)04:08
stubActually - I'll wear my Async SHOW ME THE CODE T-Shirt04:13
stub'Cause it is cool04:13
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: Product.name is now globally unique, and Product.project optional (patch-938)04:14
carlosBradB: do we have a way to do form validation easily in launchpad?04:38
carlosI'm more interested on the visual feedback of errors (missing mandatory fields and things like that)04:38
dilysMerge to thelove@canonical.com/bazaar--devo--1.1: merge in tla inode sig integrity improvements from rbtcollins@hotmail.com--barch/tla--inode-sigs--1.2 - helps bug #3869 (patch-25)04:41
BradBcarlos: for forms that aren't add or edit forms, you mean?04:41
carlosBradB: well, at this moment it's for add/edit forms04:41
carlosI know you are using autogenerated forms with malone, that's why I'm asking04:42
BradBcarlos: Yes.04:46
BradBPass a callable to the constraint paramater.04:47
BradB(of a field in your schema)04:47
BradBcarlos: src/zope/schema/README.txt04:47
carlosBradB: thanks04:47
BradBno prob04:48
=== carlos leaves for a while, will be back in one hour or so
Kinnisonelmo: roughly what time would be a good time for gina to run? I.E. when will the daily archive sync complete?05:08
stubFarewell until Spain! I'm off in 12 hours.05:19
BradBsee you there dude05:20
=== debonzi [~debonzi@38.90.203.62.cust.bluewin.ch] has joined #launchpad
SteveAKinnison, BradB: I plan to fix up forgottenpassword tonight05:58
KinnisonSteveA: cool05:58
BradBawesome05:58
KinnisonSteveA: hang on... tonight? Aren't you at the lunchpad?05:58
SteveAno05:58
SteveAI'm in lithuania05:58
Kinnisonoh I thought you flew to .uk on wednesday05:58
SteveAI'd just popped in to see what condition my condition was in.05:58
SteveAwell, that and a schooltool meeting.05:58
Kinnisonoh heh05:59
SteveAafaik, the schooltool meeting had been planned before the arch sprint05:59
SteveAso I did 1/3 day on schooltool and 2/3 on canonical05:59
SteveAeach day05:59
=== debonzi [~debonzi@61.208.76.83.cust.bluewin.ch] has joined #launchpad
SteveA nice article on wrapping GTK+ things for python: http://www-106.ibm.com/developerworks/linux/library/l-wrap/06:03
SteveAI was in this cafe, and the "ubuntu" song came on the sound system.  So,  I bought the CD from them.06:07
SteveAit's one of the songs on the "Africa" compilation published by Putomayo06:09
KinnisonSteveA: bring the CD with you to mataro?06:10
SteveAyep, willdo06:11
SteveAI'm listening to it now, as I'm not sure which track is the one with the ubuntu chorus.06:11
SteveAdefinitely "move your ass around" music though06:12
SteveAideal for those long coding sessions06:12
KinnisonMmm donkey!06:14
SteveAaha, got it: "Thandaza" by "Soul Brothers"06:14
BradBSteveA: email sent06:25
SteveAthanks06:26
=== Kinnison -> london.
SteveABradB: do you need this fixed up urgently?06:44
SteveAI mean, is it stopping you doing something you really want to get done right now?06:44
SteveA(just trying to plan my evening's work)06:44
BradBSteveA: It's not stopping me, per se, but it's still leaving a major gap in the fact that the whole point of keeping history (or well, an important part of it) is to be able to make a note about why one changed something (e.g. why a bug was rejected.)06:45
BradBI'm just putting a dummy message in the BugActivity.message field in the meantime.06:45
BradBI think it's more of a showstopper than the forgotten p/w though, if that's what you're asking :)06:46
SteveAokay.  I'll take a brief look now, and if I don't get the "eureka", I'll try and get to it more thoroughly this evening.06:46
SteveABradB: probably unrelated...         fields="title shortdesc description name"06:48
SteveAI see no changelog_comment in there06:48
BradBSteveA: Unrelated. Error is precisely the same with or without.06:49
SteveAtry adding a "for" attribute perhaps06:50
BradBI'll have to try it a bit later, as I've commented out the code and reverted the ZCML, and am in the midst of merging some of the activity stuff.06:55
dilysMerge to thelove@canonical.com/bazaar--devo--1.1: merge in aaron.bentley@utoronto.ca--baz/bazaar--three-way--0 (patch-26)06:56
SteveAokay.  let me know how it goes, and whether I need to look into it further.06:56
SteveAif it *does* work, that makes it easier to find out exactly what is going on.06:56
BradBok, I'll let you know when I get around to it.06:57
=== kiko-afk is now known as kiko
=== salgado-afk is now known as salgado
salgadoSteveA, I want to get rid of person-{join,unjoin}.pt, wich only serves to display "User foo joined team bar". for this I was thinking in self-posting to the team page and then look in the request for +join/+unjoin. 07:24
salgadowhat do you think of this?07:24
kikosalgado, except it's not self-posting!07:26
salgadoyeah, it's not. but how do I'll call it?07:27
SteveAsounds like something that could use a status message and a redirect07:28
=== mdz_ [~mdz@69-167-148-207.vnnyca.adelphia.net] has joined #launchpad
kikoSteveA, can you elaborate or point out a simile?07:32
SteveA  -----> d:-)07:33
SteveAoh, you didn't mean "a smiley"07:33
kiko  simile07:33
kiko       n : a figure of speech that expresses a resemblance between07:33
kiko           things of different kinds (usually formed with `like' or07:33
kiko           `as')07:33
SteveAI meant that, rather than fill in a form and go to a do-nothing page that just says "you did something", go to a normal "+index" page, but with a status message saying "you did something".07:34
SteveAFor a self-posting form, this is usually done with a redirect on successful form submission07:34
kikoSteveA, using person-join.pt and a redirect, or using index itself and sniffing +join from the request location?07:35
SteveAkiko: yep -- had metaphor and simile drilled into me for years in school :-)07:35
kikothank god someone here went to school! barbarians! ;)07:35
=== kiko is completely crushed-tired today
SteveAthe message would be done in the same way brad has been doing messages.07:36
kikoah?07:36
BradBkiko: I wrote a mail to the list about it already.07:36
BradBkiko: It should contain everything you need to know.07:36
SteveAa bit subject to "we can make your page say something lame" injection attacks07:37
SteveAbut we'll worry about that later07:37
BradBSteveA: Mine isn't. :)07:37
SteveAok -- must read it more carefully ;-)07:37
kikoBradB, did the message have a subject? :)07:37
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: record some of the more important bug activity, namely bug add/edit, package assignment add/edit and product assignment add/edit (still a work in progress\!) (patch-939)07:37
BradBkiko: Yeah, it mentioned "status messages" in the subject :)07:37
BradBAnd "add forms" too, I think.07:38
kikookay07:38
kikosalgado, see if you can find it, otherwise I can explore my launchpad mailbox07:38
kikobut if it is not sufficient 07:38
kikoI WILL BE BACK07:38
=== kiko whimpers about this is documentation, wiki material, not friggin mail content!
kikoand that wasn't english either07:39
salgadokiko, I'm reading it right now07:39
BradBkiko, salgado: http://rince.africaninspace.com/mailman/private/launchpad/2004-December/000845.html07:39
BradBthat shows how sadly difficult it currently is to display status messages that 1. survive redirects and 2. avoid content injection attacks.07:40
=== BradB is now known as BradB|lunch
SteveABradB|lunch: okay -- so it works only for ints07:42
salgadoyou can pass in any bug number07:43
BradB|lunchsalgado: yes, but you won't get a defacement07:43
SteveAthe general form of that is a regex or other callable that verifies the form of the passed-in replacement07:43
SteveAbasically a schema field ;-)07:43
BradB|lunchsalgado: I could have also verified that the bug exists, but that's just the details07:43
SteveAso, perhaps we have a "redirect message schema"07:43
SteveAclass IBugAddedRedirect(Interface):07:44
SteveA    bugnumber = Int(u"The bug number")07:44
SteveAsomething like that07:44
BradB|lunchSteveA: i dunno about regexes there though, it depends on what you want to show.07:44
BradB|lunchnormally the general form is intended to be: 1. you pass back something that uniquely identifies something you want to show, 2. you leave it to the view to write the actually message, and lookup whatever it's supposed to lookup from the identifier it was given.07:45
SteveAthen, in the redirect, it says  ..../+index?schema=IBugAddedRedirect&bug=12307:45
SteveAcould also use the docstring of the IBugAddedRedirect schema as the message07:45
SteveAclass IBugAddedRedirect(Interface):07:45
SteveA    """Bug number ${bug} has been added."""07:45
SteveA    bugnumber = Int(u"The bug number")07:45
SteveA    bug = Int(u"The bug number")07:46
SteveA(oops -- ignore 'bugnumber')07:46
BradB|lunchseeing schema=IBugAddedRedirect makes me worry a bit :)07:46
SteveAis this total CA crack ? ;-)07:46
BradB|lunchheh07:46
BradB|lunchokay, really |lunch now07:47
SteveAof course, we could use a code instead of IBugAddedRedirect07:47
SteveAlike, an int07:47
SteveAbut, that would be handled by the framework -- no need to see that in the code07:48
=== cprov [~cprov@200.158.100.251] has joined #launchpad
=== silbs [~sbsm0084@host217-37-231-28.in-addr.btopenworld.com] has left #launchpad []
=== BradB|lunch is now known as BradB
sabdflSteveA, BradB: the View class should as a general pattern have a "messages" attribute, which is a list of messages08:54
sabdflperhaps those could be smart enough to know what sort of message they are (info, alert, error sort of thing)08:55
sabdflthen a form can trivially iterate over those and display them08:55
sabdflwithout content-injection problems08:55
BradBsabdfl: hm? I don't see how that survives redirects.08:58
BradBsabdfl: Realistically, what happens is that .nextURL gets called on the add form's view, which redirects to another URL (e.g. redirect back to the bug listing from a bug add form)08:59
BradBWe need some kind of smart "IPC", I think. e.g. perhaps a status could be associated with a unique token, registered in a global utility. The global utility could store the status object + receipt in the ZODB, and pass the receipt to the nextURL. A view could then try to "pick up" a status message (like picking up something waiting for you at the post office), using the receipt. That's one idea anyway.09:02
BradBe.g.:09:04
BradB(in some method where something happens)09:04
BradBstatus.setInfo("congrats, something happened successfully")09:05
BradBbrowser_status = getUtility(IBrowserStatus)09:05
SteveAsabdfl: what I proposed is similar to what you describe above.09:05
BradBbrowser_status.set(status, 'some unique receipt')09:05
SteveAwith the formalism of using schemas to describe messages and the allowed form of replacement text09:05
BradBthen in nextURL:09:06
SteveABradB: sounds a bit complex and heavy; could do that, though 09:06
BradBreturn "foo?status_receipt=some+unique+receipt"09:06
SteveAanother scheme entirely is to use crypto, and pass a digest along with the query string stuff09:07
SteveAfoo?message=You+have+added+bug+123&digest=0x123abcde09:07
SteveAstill, not a big problem at the moment.  let's chat about it next week09:07
BradBSteveA: If I check that IBugEditForm thing now (with for=), will you have any time to look into tonight/09:08
SteveAyes09:08
BradBok, then I'll check it now09:08
BradBI expect that it's going to tell me that my view doesn't implement IBugEditForm. Let's see...09:14
BradBSteveA: Adding for="canonical.launchpad.interfaces.IBugEditForm", produced the exact same KeyError09:16
=== BradB tries one last thing
BradBSteveA: i tried implement()'ing that iface in the view class too. no dice.09:18
BradBi.e. same error09:19
SteveAokay.  is this going to be straightforward for me to reproduce on my machine?09:19
SteveAis all the necessary code checked in?09:19
BradBSteveA: no, but all the necessary code is in the email that I sent you. :)09:20
BradBI don't really want to check this in09:20
BradBlib/canonical/launchpad/zcml/bug.zcml and lib/canonical/launchpad/interfaces/bug.py are where the bits go09:20
SteveAcan you mail me those files?09:21
SteveAthat way I'll be sure I've got it right09:21
BradBok09:21
SteveAI'll have a crack at this now09:21
SteveAI need to fix up that keyerror problem, anyway09:23
BradBsent09:23
BradBSee, we're already doing something very similar with the bug add form (it uses IBugAddForm to create a form that includes fields that you won't find on the bug itself.) It seems though that editforms behave differently in that respect.09:24
SteveAyeah, weird09:29
SteveAit could well be a bug09:29
SteveAthis part of the forms stuff is more complex than it should be09:29
BradBSteveA: I hope life gets made easier with a browser:form directive in Mataro!09:30
=== salgado is now known as salgado-afk
=== salgado-afk is now known as salgado
=== mdz [~mdz@69-167-148-207.vnnyca.adelphia.net] has joined #launchpad
=== mdz [~mdz@69-167-148-207.vnnyca.adelphia.net] has joined #launchpad
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: add infestation activity tracking (patch-940)10:27
BradBsabdfl: I just realized package maintainers are going to get spammed on bug notifications, crap.10:54
BradBe.g. I'm the debian maintainer. I don't want to get emails about to whom the bug was assigned among the redhat maintainers.10:55
BradBsabdfl: It's not a big deal I guess. The notifiers could be made more intelligent for some of the notifications (e.g. a maintainer probably wants to see CVE refs and web links and perhaps even infestations no matter the distro, whereas the *assignment stuff could be filtered to notify per-distro)10:59
BradBSteveA: any luck on the editform-fu?11:17
SteveABradB: not yet.  popped off to eat.  I'll stare at it some more now :) 11:18
sabdflSteveA, bradb, it seems that the web page alert or message is really a message *to a person*11:36
sabdflso this might be a useful place to use the zodb decorations11:37
sabdfldecorate the principal11:37
sabdfl"add this alert to the list of alerts for user X"11:37
sabdflthen the view can have a .messages list which give you any messages11:37
sabdflhmm... how would messages be cleared, I wonder?11:37
sabdflback in a few minutes11:38
BradBsabdfl: Annotations are meant to describe things, without having to alter the original content to do so. I think an average Zope 3 developer would be quite surprised to figure out that annotations were used for that.11:39
BradBsabdfl: And also, well, it's not thread safe.11:39
SteveAI think zodb annotations, and maybe the zodb in general, is a bit dodgy for status messages.11:40
SteveAbut...11:40
=== sabdfl [~mark@host217-37-231-28.in-addr.btopenworld.com] has left #launchpad []
SteveAI think the idea of a personal activity log is useful11:40
SteveAlike, imagine if there's a list of stuff you've done, and when11:40
SteveAthat is kept in the zodb11:41
SteveAthat you can look at11:41
SteveAand a portlet that tells you the most recent 5 things11:41
SteveAand has a link to the "noun" that the thing was about11:41
BradBSteveA: Or better, yet, a not-personal activity log, perhaps.11:41
SteveAfor example, if a thing is "changed status on bug 123", it is a link to bug 12311:41
BradBPeople seem to always want to be able to audit users.11:41
SteveAnon-personal?11:41
BradBi.e. just an audit log of what people do in the site.11:42
SteveAwell, sure, *we* could look at what someone has done.  could be useful for handling bug reports11:42
SteveAit would be an audit log only of completed transactions11:42
SteveAwhich is useful in itself11:42
SteveAbut not so useful of a full audit log11:42
SteveAhey, another thing to jam on in mataro11:42
SteveAwhen do you leave, brad?11:42
BradBtomorrow night at 18:4011:43
BradBgoing for tapas with girlfriend soon :P11:43
SteveAcool11:43
SteveAwhere does bug.py go?11:43
SteveAit seems to have a large delta from the one in database/11:43
BradBSteveA: that files contains interfaces11:43
SteveAoh11:43
SteveAduh ;-)11:43
BradB:)11:44
SteveAshould have actually read the file11:44
SteveAso, if I go to +edit on a bug I'll see the problem11:44
BradByes11:44
SteveAone thing with malone11:45
BradBSteveA: the goal is that all edit screens on things related to a bug (including, of course, the bug itself) will have one extra little widget added to them, to capture a changelog message, and store that somewhere that isn't a bug11:45
SteveAI find the lots of "document" icons in different places very confusing11:45
SteveAlike my UI renderer has left noise when I've been trying to drag and drop11:46
=== carlos [~carlos@69.Red-80-33-181.pooles.rima-tde.net] has joined #launchpad
BradBSteveA: mark's idea :)11:46
SteveAthe icons should be in front of the text11:46
SteveAnot after it11:46
SteveAso they line up nicely11:46
BradBthat'd help, yeah11:46
SteveAand like they are in the column header11:46
SteveAI think we need something better for "upstream"11:47
BradBSteveA: the word you mean?11:47
SteveAno, the icon11:47
BradBah11:47
SteveAyay11:48
SteveAI have reproduced your bug11:48
SteveAokay11:49
BradBwoo11:49
SteveAtraverse functions need to return None, not raise KeyError11:49
SteveAso the traverse function is in error there11:49
SteveAthat's the "traverse function" contract11:49
SteveAlet's see what happens when I fix that11:49
SteveAokay, I now get a proper NotFound error11:50
SteveAnow I need to find out why it doesn't find +edit11:50
BradBindeed, indeed11:51
SteveAcan you fix the traverse function in your copy?11:51
BradBsure11:51
BradBit might break things though. i guess we'll see11:51
SteveAshouldn't do11:52
SteveAaw crap11:55
SteveAI think I've got it11:56
SteveAokay, here's what you need to do11:57
BradB!11:57
SteveA1. register the +edit form for IBug11:57
SteveA2. register an adapter from IBug to IBugEditForm.11:57
SteveAI suggest you use the "decorates" thing for this11:57
SteveAyou know about "decorates" don't you?11:58
SteveAbasically, the forms machinery doesn't really fit with what you're trying to do11:58
SteveAI think what you're trying to do is pretty reasonable, given the forms machinery11:59
SteveAwe need to make this better when we work on browser:form11:59
BradBSteveA: if i were missing an adapter, i would have expected it to tell me that it couldn't find an adapter11:59
SteveAit does do11:59
SteveAwhen you do step 1 above11:59

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!