| stub | carlos: updated, and data migration script running | 12:17 |
|---|---|---|
| kiko-fud | ITS WORKING! | 12:27 |
| kiko-fud | yarrr stub | 12:28 |
| Nafallo | why can't I add my GPG key to launchpad? | 12:40 |
| kiko-fud | Nafallo, what's the issue? | 12:41 |
| kiko-fud | you /can/ | 12:41 |
| Nafallo | " Sorry, a system error occurred" <-- :-P | 12:41 |
| Nafallo | https://launchpad.ubuntu.com/people/nafallo/+editgpgkey | 12:41 |
| kiko-fud | Nafallo, file a bug, nag cprov and nag me if that doesn't work | 12:41 |
| Nafallo | trying to add: CC52241EFEA132F4B34AD7CC2DDA825B509CBA71 | 12:41 |
| Nafallo | oki | 12:41 |
| kiko-fud | cprov, ping? | 12:42 |
| cprov | kiko-fud: pong, I'm aware | 12:43 |
| Nafallo | cprov: known problem? seems to be #1163 | 12:43 |
| cprov | Nafallo: probably not, I'm investigating, did you do it recently ? | 12:44 |
| Nafallo | cprov: yepp. 00:40 or something :-) | 12:44 |
| Nafallo | ehm... 22:40 UTC ;-) | 12:44 |
| cprov | Nafallo: much better in UTC ;) | 12:46 |
| Nafallo | hmm | 12:46 |
| === cprov [~cprov@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| Nafallo | cprov: wb :-) | 12:47 |
| Nafallo | I'm happy to do almost any bugtests you ask me to do :-) | 12:48 |
| Nafallo | I can't reopen the bug either ;-) | 12:51 |
| kiko-fud | we can | 12:51 |
| cprov | kiko-fud: Nafallo: calm down, It could no be the same bug, so wait ! | 12:52 |
| kiko-fud | heh | 12:53 |
| kiko-fud | okay | 12:53 |
| Nafallo | cprov: oki. but then again, that bug just says we get the "sorry" message ;-). | 12:53 |
| cprov | Nafallo: did you get "System Error" ? | 12:54 |
| Nafallo | cprov: yes | 12:55 |
| === cprov looking | ||
| Nafallo | the page that asks you to add a bug etcetera. | 12:56 |
| cprov | Nafallo: dude, this is a name Christian Bjlevik | 01:01 |
| Nafallo | cprov: yea. I know my name :-) | 01:02 |
| Nafallo | don't tell me that's the error? ;-) | 01:03 |
| cprov | Nafallo: yes it is ... how is your name in LP ? | 01:03 |
| Nafallo | cprov: works good everywhere :-) | 01:03 |
| cprov | Nafallo: GPGME doesn't accept UNICODE, so we need it in ASCII, not a big issue, but an anoying one | 01:05 |
| Nafallo | cprov: something you can convert server-side? :-) | 01:06 |
| cprov | Nafallo: we will fix it in LP, it's a known bug | 01:07 |
| Nafallo | cprov: oki :-) | 01:08 |
| Nafallo | that package shall be fixed to. atleast for breezy. | 01:08 |
| cprov | Nafallo: thank you for your valuable feedback ... keep trying | 01:08 |
| cprov | Nafallo: Pyme needs some love ;) | 01:09 |
| Nafallo | cprov: oki. thanks to you and kiko-fud to :-) | 01:09 |
| Nafallo | cprov: is that from a package currently in breezy? | 01:12 |
| cprov | Nafallo: yes, python2.4-pyme | 01:13 |
| Nafallo | hmm, can't find it on my amd64 or on packages.ubuntu.com :-/ | 01:16 |
| cprov | Nafallo: just to confirm the bug, try to import you key again in launchpad, I'm following the errors | 01:17 |
| Nafallo | bang :-) | 01:18 |
| Nafallo | got it? | 01:20 |
| cprov | Nafallo: no, it's masked by another unicode error in zope, don't worry it needs some investigation to resolve it properly | 01:22 |
| Nafallo | :-) | 01:22 |
| cprov | Nafallo: if it won't ask too much, could you try the process again ? :-P | 01:28 |
| Nafallo | yepp :-) | 01:29 |
| Nafallo | got it? :-) | 01:29 |
| cprov | Nafallo: yes, now i got | 01:29 |
| cprov | Nafallo: so, you won a bug watch, 1496 ... kick me if I don't give it correct priority, ok ? | 01:38 |
| Nafallo | cprov: sure :-) | 01:38 |
| Nafallo | cprov: what's CPG? ;-) | 01:39 |
| cprov | Nafallo: dude .. typing & walking sucks .. GPG | 01:39 |
| Nafallo | :-) | 01:40 |
| Nafallo | https://launchpad.ubuntu.com/distros/ubuntu/breezy/+lang/sv | 01:49 |
| Nafallo | I don't have permission to access that page :-/ | 01:49 |
| cprov | Nafallo: you are not part of the translation team, I guess ... ask the specialists daf or carlos | 01:58 |
| Nafallo | cprov: I am :-). | 01:58 |
| Nafallo | cprov: that's why it is very odd ;-) | 01:58 |
| Burgundavia | is there any reason why read-only access to that page is being blocked, aside from the preformance issues? | 01:59 |
| cprov | Nafallo: uhmm .. bad bad ... speaking about me then, poor cprov isn't | 01:59 |
| Nafallo | I will probably bug carlos until the CC-meeting beguns ;-) | 02:00 |
| === asgeirf [~asgeirf@nat-pool-brisbane.redhat.com] has joined #launchpad | ||
| === cprov goes home | ||
| === morgs|away [~morgan@wblv-146-245-52.telkomadsl.co.za] has joined #launchpad | ||
| === bob2 [~rob@crumbs.ertius.org] has joined #launchpad | ||
| === warthylog [~warthylog@port49.ds1-van.adsl.cybercity.dk] has joined #launchpad | ||
| === Topic for #launchpad: Rosetta is unwell, login before using! || Discussion with launchpad users and developers. || Includes Rosetta and Malone. || Register for your account on https://launchpad.ubuntu.com/+login | ||
| === Topic (#launchpad): set by lifeless at Fri Jul 15 13:40:55 2005 | ||
| === warthylog [~warthylog@port49.ds1-van.adsl.cybercity.dk] has joined #launchpad | ||
| === Topic for #launchpad: Rosetta is unwell, login before using! || Discussion with launchpad users and developers. || Includes Rosetta and Malone. || Register for your account on https://launchpad.ubuntu.com/+login | ||
| === Topic (#launchpad): set by lifeless at Fri Jul 15 13:40:55 2005 | ||
| BjornT | hi spiv | 08:36 |
| spiv | Hello! | 08:39 |
| spiv | I'm about to disappear to do a little bit of shopping. | 08:39 |
| BjornT | ok, i was just wondering how's it going with the distinct/order by fix? | 08:40 |
| === morgs|away [~morgan@wblv-146-245-52.telkomadsl.co.za] has left #launchpad [] | ||
| === morgs|away [~morgan@wblv-146-245-52.telkomadsl.co.za] has joined #launchpad | ||
| spiv | BjornT: Back. | 10:05 |
| spiv | BjornT: Hmm, I can't seem to reproduce "queries like 'SELECT DISTINCT ... FROM POTemplate, ProductSeries ... ORDER BY datecreated' fail, since datecreated exists in both tables" | 10:05 |
| spiv | BjornT: afaict the order by produced by my branch always generates "ORDER BY Tablename.columnname" rather than "ORDER BY columnname". | 10:07 |
| BjornT | spiv: hmm, i'll try again. maybe i did something wrong | 10:08 |
| BjornT | spiv: btw, i found another problem with sqlobject. BugMessage.selectOneBy doesn't work. BugMessage.selectOne does work, though, so it's not a big problem | 10:09 |
| spiv | BjornT: Interesting. In what way doesn't it work? | 10:10 |
| BjornT | spiv: well look at _SO_columnClause (dbconnection.py, line 496). soClass._SO_columnDict[key] .dbName fails with a KeyError: 'message' | 10:15 |
| spiv | How odd. | 10:18 |
| carlos | spiv did you see my email about the librarian problems I'm having that prevents me to merge into rocketfuel? | 10:20 |
| spiv | carlos: I did... is this related to the fixes pending in my librarian-cleanups branch? | 10:20 |
| carlos | spiv, I get the same problem with your fixes | 10:21 |
| carlos | I merged your branch into that one | 10:21 |
| carlos | and then I twisted2.0 start working | 10:21 |
| carlos | but getting the same problem pqm has | 10:22 |
| spiv | Hmm. | 10:22 |
| === morgs gets a failure from pqm in test_zopeless_reconnect.txt... Huh? | ||
| spiv | BjornT: Does selectBy fail too? | 10:26 |
| spiv | BjornT: What are you passing to selectOne/selectOneBy? | 10:26 |
| spiv | BjornT: it works for me here: | 10:29 |
| spiv | >>> BugMessage.selectOneBy(bugID=1, messageID=3) | 10:29 |
| spiv | <BugMessage at 0x-4934e6b4> | 10:29 |
| spiv | Hmm, it seems SQLObject still needs ID on foreign keys, despite, what the changelog said on the version I merged from :( | 10:30 |
| BjornT | spiv: ok. i passed bug=bug_one, message=message_three | 10:30 |
| BjornT | i guess it's not worth trying to get that to work | 10:32 |
| spiv | It ought to :/ | 10:32 |
| spiv | I guess it's time to merge the latest from upstream again... | 10:32 |
| BjornT | yeah it would be nice | 10:35 |
| spiv | carlos: Hmm, poimport.txt is using the database with using e.g. LaunchpadTestSetup... | 10:38 |
| spiv | morgs: Try again? There's a race in that test that needs fixing. | 10:44 |
| carlos | spiv, is it a problem or a question? :-) | 10:44 |
| morgs | spiv: thx | 10:45 |
| spiv | carlos: Speculation about the problem :) | 10:46 |
| spiv | I think without LaunchpadFunctionalTestSetup or similar, the transaction bits for SQLObject aren't fully hooked up. | 10:46 |
| carlos | spiv, https://chinstrap.ubuntu.com/~dsilvers/paste/fileKZpLKP.html | 10:47 |
| carlos | that's what the test is using | 10:47 |
| daf | I bet that's it | 10:49 |
| daf | try changing it to use FunctionalTestSetup | 10:49 |
| spiv | carlos: It does? I don't see where it uses those in poimport.txt in your LaunchpadPoImportFeedback branch? | 10:49 |
| daf | spiv: the test runner calls those implicitly for that test | 10:49 |
| daf | there's a mapping lower down in the file | 10:50 |
| daf | (morning) | 10:50 |
| === spiv discovers a weird instrumental (synth-organ!) cover of Paranoid Android in his music collection... | ||
| daf | oooh | 10:50 |
| daf | who by? | 10:51 |
| spiv | I've absolutely no idea. | 10:51 |
| daf | heh | 10:51 |
| spiv | "Artist: Unknown" | 10:51 |
| spiv | "Title: seminar5" "Album: seminar". Other tracks have illuminating names like "seminar2". | 10:52 |
| spiv | I think I got this from my sister. I'll have to ask here about it when she gets back from Belfast... | 10:52 |
| spiv | "her" | 10:52 |
| spiv | Oh, it's using Zopeless setup? Then using import transaction; transaction.commit() won't work. | 10:54 |
| spiv | Use LaunchpadZopelessTestSetup.txn.commit() instead. | 10:54 |
| spiv | That's one of the significant differences with "zopeless", it doesn't (yet) integrate with that. | 10:55 |
| daf | well | 10:56 |
| daf | using LaunchpadFunctionalTestSetup would also work, yes? | 10:56 |
| spiv | I think so, yeah. | 10:56 |
| daf | any reason for using one over the other? | 10:58 |
| carlos | spiv, yes, that's new from my branch | 10:58 |
| carlos | spiv, it's inside the .py script that launches that test | 10:58 |
| carlos | test_system_documentation.py | 10:58 |
| daf | carlos: try changing it! | 10:58 |
| carlos | oh | 10:59 |
| === carlos just read the possible solution ;-) | ||
| === carlos tries it | ||
| === SnakeBite [~SnakeBite@84.242.143.64] has joined #launchpad | ||
| daf | carlos: try it with --test=poimport first | 11:04 |
| daf | (rather than running the whole suite) | 11:04 |
| carlos | daf, doing that already, don't worry :-) | 11:04 |
| === otep [~otep@AP-203.167.31.177.sysads.com] has joined #launchpad | ||
| === daf wonders why he can't edit https://launchpad.ubuntu.com/products/rosetta/+bugs/214 | ||
| daf | huh, I can now | 11:06 |
| daf | weird | 11:06 |
| carlos | daf, https://launchpad.ubuntu.com/malone/bugs/214 | 11:07 |
| carlos | try from there :-) | 11:07 |
| === aatim [~aatim@203.131.175.93] has joined #launchpad | ||
| daf | carlos: what's the status of #1036? | 11:09 |
| Nafallo | https://launchpad.ubuntu.com/distros/ubuntu/breezy/+lang/sv | 11:09 |
| Nafallo | carlos: why don't I have permission to see that page? | 11:10 |
| carlos | daf, the migration script should be changed to reduce its memory usage, but the bug is already fixed | 11:11 |
| daf | carlos: cool, I'll close it | 11:11 |
| carlos | Nafallo, because we had to disable Rosetta because performance issues, it should be fixed as soon as our db master appears | 11:12 |
| daf | carlos: does poimport.txt pass now? | 11:12 |
| carlos | daf, no, but it's not related anymore to librarian, at least not with that error... | 11:12 |
| daf | heh | 11:12 |
| Nafallo | carlos: oki :-) | 11:12 |
| daf | ok | 11:12 |
| daf | that's good | 11:12 |
| daf | carlos: we're waiting for stub to do a production update? | 11:12 |
| carlos | daf, well, it should pass the tests ;-) | 11:12 |
| carlos | daf, no, he did it already | 11:13 |
| Nafallo | carlos: you haven't reached him yet? I know you tried all yesterday ;-) | 11:13 |
| carlos | but seems like he forgot to remove the restrictions lifeless added on Friday | 11:13 |
| Nafallo | s/all/all\ of/ | 11:13 |
| carlos | Nafallo, I did but went to sleep before he finished the update so I was not able to check that all worked | 11:13 |
| daf | ah | 11:13 |
| Nafallo | carlos: aha. he should have used me as guineapig then ;-) | 11:14 |
| Nafallo | hmm, guineapig is probably not the word I was after. | 11:14 |
| daf | carlos: can you do those pending plural forms tasks today? | 11:15 |
| Nafallo | tester more likely ;-) | 11:15 |
| daf | carlos: also, maybe you can do https://launchpad.ubuntu.com/malone/bugs/680? | 11:15 |
| carlos | daf, I will look into them, yes | 11:16 |
| carlos | Nafallo, ;-) | 11:16 |
| daf | carlos: thanks | 11:16 |
| carlos | np | 11:17 |
| BjornT | spiv: please run this test with your distinct/orderby branch: | 11:19 |
| BjornT | >>> from canonical.launchpad.interfaces import IProductSet | 11:19 |
| BjornT | >>> list(getUtility(IProductSet).get(1).translatable_series) | 11:19 |
| BjornT | [] | 11:19 |
| dilys | Merge to rocketfuel@canonical.com/launchpad--devel--0: [r=BjornT] Fix Bug 1394: +source form to add RCS information is broken without sourcepackages (patch-2116: morgan.collett@canonical.com) | 11:23 |
| carlos | spiv, I committed by mistake your branch inside mine.... | 11:26 |
| carlos | spiv, I'm going to revert it, but I'm not sure if that would cause a problem with patchlogs.... | 11:26 |
| === aatim_ [~aatim@203.131.175.93] has joined #launchpad | ||
| carlos | daf, https://launchpad.ubuntu.com/malone/bugs/214 is not yet fixed, it's pending on data migration.... | 11:29 |
| === carlos needs a bazaar guru :-( | ||
| daf | the bug is that you get a system error | 11:31 |
| daf | you won't get a system error any more | 11:31 |
| daf | so the bug is fixed | 11:32 |
| Kinnison | carlos: what are you trying to achieve with baz? | 11:34 |
| carlos | Kinnison, I committed a branch merge by error | 11:35 |
| carlos | I need to remove it without preventing that the other branch is merged into rocketfuel in the future | 11:35 |
| daf | baz replay --reverse | 11:36 |
| daf | I think this may be in the HackingFAQ | 11:36 |
| Kinnison | carlos: which rocketfuel patch is it in? | 11:36 |
| carlos | not yet in rocketfuel | 11:36 |
| carlos | but it's in a branch I'm going to merge into rocketfuel | 11:36 |
| carlos | daf, really? | 11:36 |
| === carlos checks | ||
| daf | carlos: any idea if https://launchpad.ubuntu.com/malone/bugs/908 is fixed? | 11:36 |
| daf | https://wiki.launchpad.canonical.com/LaunchpadHackingFAQ#head-79296582f0e565dfd505904a1bf99e60133e765d | 11:37 |
| daf | you don't want to do the sync-tree thing though | 11:37 |
| carlos | daf, not sure about that bug | 11:37 |
| daf | otherwise it will prevent spiv from merging his branch | 11:38 |
| carlos | daf, that's exactly what I want to avoid | 11:39 |
| carlos | thanks | 11:39 |
| carlos | hmm | 11:40 |
| carlos | daf, that does not work | 11:40 |
| carlos | it's the same i got with patch -p1 -R | 11:40 |
| daf | ? | 11:40 |
| carlos | daf, tree-id says its reverted to previous patchset | 11:41 |
| daf | ? | 11:41 |
| carlos | so, baz update will reapply the patchset | 11:41 |
| daf | don't revert your branch | 11:41 |
| daf | revert spiv's | 11:41 |
| carlos | oh! | 11:41 |
| carlos | :-P | 11:41 |
| daf | :) | 11:41 |
| carlos | my god this is hell.... | 11:58 |
| === carlos looks for the panic button | ||
| Nafallo | carlos: say hello to satan from me. I know him :-). | 11:58 |
| carlos | Nafallo, :-) | 11:59 |
| === carlos decides to wait for lifeless | ||
| daf | what were you trying? | 11:59 |
| carlos | daf, the problem is that spiv's branch has rocketfuel merges | 12:03 |
| carlos | and I'm getting a big mix of things | 12:03 |
| carlos | with replay --reverse | 12:04 |
| Kinnison | You need to just reverse spiv's non-merge patches I guess | 12:04 |
| daf | mm, that might help | 12:06 |
| daf | baz logs -res andrew.bennetts@c.c/launchpad--librarian-cleanups--0 | 12:07 |
| daf | er | 12:07 |
| carlos | as I said, I think I will wait for lifeless so I'm 100% sure I'm not breaking my tree and I don't ban spiv's branch in the future | 12:07 |
| daf | baz logs -rs andrew.bennetts@c.c/launchpad--librarian-cleanups--0 | 12:07 |
| daf | where's your sense of adventure? | 12:08 |
| daf | lifeless might have already gone to bed | 12:08 |
| morgs | daf, carlos - he's in brazil | 12:09 |
| daf | oh, right | 12:09 |
| daf | so he should be around in an hour or two | 12:09 |
| === Kinnison has lost track of the number of times he has (extremely carefully) had to undo history in his baz archive | ||
| carlos | daf, I know, that's why I'm deciding to wait for him ;-) | 12:10 |
| === Kinnison is glad he doesn't have an auto-mirror hook | ||
| carlos | Kinnison, the mirror is lacking this revision | 12:10 |
| carlos | Kinnison, but I doubt is safe that I just rm the patchlog.. | 12:11 |
| Kinnison | no | 12:11 |
| Kinnison | never just rm patchlogs | 12:11 |
| Kinnison | what is your branch? | 12:11 |
| carlos | carlos.perello@canonical.com--2004/launchpad--LaunchpadPoImportFeedback--0 | 12:12 |
| === Kinnison gets that | ||
| Kinnison | and the branch you're trying to undo is andrew.bennetts@c.c/launchpad--librarian-cleanups--0 ? | 12:13 |
| carlos | right | 12:14 |
| carlos | Kinnison, but as it's not mirrored, you should not have that branch | 12:14 |
| carlos | patch-25 is the "broken" one | 12:14 |
| carlos | patch-24 should be the one you have | 12:15 |
| daf | you could try reverting patch-25 in your branch | 12:15 |
| daf | and then doing sync-tree | 12:15 |
| carlos | daf, are you 100% sure? | 12:18 |
| Kinnison | carlos: why is patch-25 not mirrored? | 12:19 |
| carlos | because I was able to stop it before the mirror were done | 12:20 |
| Kinnison | Okay, hang on | 12:20 |
| Kinnison | You want to: 1. revert patch-25 | 12:20 |
| Kinnison | 2. noone but youhas it | 12:20 |
| Kinnison | 3. it has not been merged into anything else | 12:20 |
| Kinnison | is that true? | 12:20 |
| daf | it will be in his revision library | 12:20 |
| Kinnison | daf: revlib and arch-cache can be cleaned | 12:21 |
| daf | that's icky | 12:21 |
| daf | you want a patch-26 that has patch-25 reverted | 12:21 |
| === Kinnison hides his "remove head revision" script | ||
| daf | eww | 12:21 |
| daf | carlos: is patch-25 *only* the merge from spiv? | 12:21 |
| carlos | daf, and a local change I did by mistake but that is ok to lose it | 12:22 |
| carlos | kiko-fud, yes, that's true | 12:23 |
| daf | ok, so, I suggest you do | 12:23 |
| Kinnison | carlos: in that case, baz replay --reverse patch-25 | 12:23 |
| Kinnison | carlos: baz sync-tree | 12:23 |
| daf | yes | 12:23 |
| daf | what Kinnison said | 12:23 |
| daf | then baz commit | 12:23 |
| carlos | daf, but if I just revert patch-25 in patch-26, spiv's changes will be undo when he merge from rocketfuel. That's why I have a problem | 12:24 |
| carlos | ok | 12:24 |
| === carlos tries | ||
| daf | no, I think there will be no problem with Rocketfuel | 12:24 |
| daf | Kinnison: what do you reckon? | 12:24 |
| carlos | daf, with Kinnison solution I suppose it's ok, but if I reverte patch-25 with a normal commit, there will be problems when spiv wants to merge his changes | 12:25 |
| daf | you're only undoing changes on your branch | 12:25 |
| daf | not undoing changes anywhere else | 12:25 |
| morgs | I think it will be OK... if you baz diff against rocketfuel after you've done it, spiv's stuff won't appear at all, which means when you merge to RF, spiv's stuff won't be part of the patch | 12:25 |
| === Kinnison 's solution will mean that merging into RF won't introduce spiv's patches at all | ||
| Kinnison | thusly it'll all be safe | 12:27 |
| carlos | morgs, but my tree would have spiv's patchlogs so those changes will not be applied, not sure if I'm explaining myself..... | 12:27 |
| Kinnison | carlos: Your tree doesn't have them at the head | 12:27 |
| carlos | anyway, Kinnison solution sounds safe | 12:27 |
| Kinnison | carlos: so it's quite safe | 12:27 |
| carlos | so I'm doing that | 12:27 |
| daf | Kinnison: baz revert will revert spiv's patch logs also | 12:27 |
| Kinnison | daf: exactly | 12:27 |
| daf | er | 12:27 |
| daf | that was meant to be directed at carlos | 12:27 |
| Kinnison | carlos: If you want to test it, do what I said, commit, then get a RF checkout, merge in your branch and then merge in spiv's branch to satisfy yourself that the latter will work | 12:28 |
| === Kinnison often simulates a PQM merge to check for himself what'll happen | ||
| daf | or check out spiv's branch and merge your branch into it | 12:28 |
| daf | if you're worried about that | 12:28 |
| carlos | as I said, the --replay and sync-tree should be enough | 12:29 |
| Kinnison | replay --reverse | 12:29 |
| carlos | Kinnison, yeah, it's done. Thank you | 12:31 |
| Kinnison | daf: Why is it that dilys doesn't report bugs here any more | 12:33 |
| daf | I reckon baz logs -fr andrew.bennetts@c.c/launchpad--librarian-cleanups--0 | xargs -i baz replay --reverse '{}' would have worked also | 12:33 |
| daf | Kinnison: because the bug mail format has changed and I haven't fixed dilys yet | 12:33 |
| === Kinnison spanks daf into fixing dilys | ||
| Kinnison | can't have her making puppies | 12:33 |
| daf | puppies? | 12:33 |
| Kinnison | To "fix" a dog is to get it neutered | 12:34 |
| daf | oh | 12:34 |
| Kinnison | Sorry, I'm clearly on surreal non-humour mode today | 12:34 |
| daf | don't call dilys a dog | 12:34 |
| daf | she might stop reporting your merges | 12:34 |
| === Kinnison sniggers | ||
| === Kinnison thought dilys was named after your dog | ||
| daf | ha | 12:35 |
| Kinnison | See, clearly I'm broken today | 12:35 |
| === Kinnison recommends the application of beer in 1h time | ||
| daf | no more broken than I | 12:35 |
| daf | your prescription sounds promising | 12:37 |
| Kinnison | excellent | 12:39 |
| daf | hmm, I shall have to render myself suitable for appearance in public | 12:39 |
| === Kinnison hands daf a few strategically shaped nurbs for rendering | ||
| === carlos tries again to merge poimport changes... | ||
| === carlos -> out, see you later. | ||
| === daf fumbles for his control mesh | ||
| Kinnison | eww, not in public | 12:42 |
| === Mez [~Mez@cpc2-lich4-3-0-cust115.brhm.cable.ntl.com] has joined #launchpad | ||
| Kinnison | ciao | 01:00 |
| === Kinnison will be back after lunch | ||
| kiko-fud | ahoy | 01:04 |
| Nafallo | hi kiko! :-) | 01:04 |
| kiko | hey there | 01:04 |
| morgs | aloha | 01:05 |
| kiko | the only way of getting any work done is to arrive an hour early! | 01:05 |
| kiko | no sigh of the sab | 01:05 |
| morgs | :) | 01:05 |
| dilys | Merge to rocketfuel@canonical.com/launchpad--devel--0: [trivial] Fix Bug 1309: +source does not show svn details on load, mouse action required (patch-2117: morgan.collett@canonical.com) | 01:05 |
| morgs | daf, remember the changes you made for the DatabaseImportFascist, and the pagetests (or lack thereof)? Turns out there's no pagetest for project/+new, and that got broken :( | 01:07 |
| daf | oops! | 01:08 |
| daf | what was it you added a page test for? projects/+new-product? | 01:08 |
| dilys | New Malone bug 1499 filed on Bazaar by Daniel Silverstone: baz log panics outside of a working tree | 01:09 |
| dilys | https://launchpad.ubuntu.com/malone/bugs/1499 | 01:09 |
| === kiko [~kiko@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| morgs | daf: yes, somehow I missed the project/+new... | 01:12 |
| daf | hmm, I wonder why I thought that had tests | 01:13 |
| morgs | so projects/+new gives: ComponentLookupError: (<InterfaceClass canonical.launchpad.interfaces.project.IProject>, '') | 01:14 |
| daf | interesting | 01:14 |
| daf | perhaps IProject is not registered as a utility | 01:14 |
| morgs | Oh | 01:14 |
| daf | yep, you need to add a <securedutility> to lib/canonical/launchpad/zcml/project.zcml | 01:15 |
| daf | er, no | 01:15 |
| daf | ignore that | 01:15 |
| daf | (you have a securedutility for IProjectSet already) | 01:16 |
| daf | I imagine the code is calling getUtility(IProject) where it should be calling getUtility(IProjectSet) | 01:17 |
| morgs | Aah, I'll check that quickly | 01:17 |
| daf | hmm, I can't find the code | 01:17 |
| morgs | Yup | 01:17 |
| morgs | browser/project.py | 01:17 |
| daf | ah, this branch is stale | 01:18 |
| daf | that's why | 01:18 |
| morgs | It does call IProject, I'll fix it | 01:18 |
| daf | groovy | 01:18 |
| daf | I'm sure you'll be adding a test also ;) | 01:18 |
| morgs | tests-r-us | 01:19 |
| === daf -> lunch | ||
| BjornT | kiko! | 01:27 |
| kiko | hey ho | 01:27 |
| BjornT | kiko: so, you don't seem to have anything to complain about BBA. does that mean i can consider it approved? ;) | 01:28 |
| kiko | heh | 01:30 |
| kiko | sorry man, it was kind of crazy these last weeks, getting all the sprint sorted out | 01:30 |
| kiko | yours wasn t the only review I dropped | 01:30 |
| dilys | Merge to rocketfuel@canonical.com/launchpad--devel--0: [r=SteveA] menus for Rosetta (patch-2118: daf@canonical.com) | 01:32 |
| kiko | woooo | 01:32 |
| BjornT | kiko: so, what's the (*real*) ETA for getting it reviewed? | 01:33 |
| === mpool [~mbp@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| === debonzi [~debonzi@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| === jamesh [~james@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| === mpt [~mpt@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| === cprov [~cprov@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| === salgado [~salgado@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| dilys | Merge to thelove@canonical.com/dists--bazaar--1.5: new build (patch-49) | 02:14 |
| dilys | Merge to thelove@canonical.com/bazaar--devo--1.5: don't "panic" when doing "baz log" outside a tree, added -d option to log (patch-38: Matthieu.Moy@imag.fr) | 02:15 |
| lifeless | hi | 02:18 |
| dilys | Merge to rocketfuel@canonical.com/launchpad--devel--0: [trivial] Fix Bug 1482: System error while creating a new project (patch-2119: morgan.collett@canonical.com) | 02:44 |
| Nafallo | carlos: ping | 02:45 |
| carlos | Nafallo, pong | 02:47 |
| carlos | lifeless, something is missing from the cherrypick that stub did yesterday. Is stub around? or could you take a look? | 02:47 |
| Nafallo | carlos: would "I took the silence for a yes" as me as coordinator suffice for ubuntu swedish translators? I don't get response from more than one guy, and he seems to like the idea with me as coordinator :-). | 02:48 |
| carlos | Nafallo, sure, as long as you have clear that that position will not be for ever, it will depend on the quality of your work. If you "break" Swedish translations someone else could take from you the coordinator role | 02:51 |
| Nafallo | carlos: ofcourse. it's not like this action can't be undone. I mostly want to relieve you from being admin when I aswell could handle it :-) | 02:53 |
| carlos | Nafallo, I will give you admin rights now. | 02:53 |
| spiv | BjornT: andrew.bennetts@canonical.com/sqlobject--distinct-orderby-other-fix--0--patch-4 should fix your latest distinct problem. | 02:54 |
| Nafallo | carlos: nice. thank you :-). | 02:55 |
| Nafallo | carlos: people are probably away from their broadband connections at universitys or something now that it's summer :-). | 02:55 |
| carlos | Nafallo, could you tell me your launchpad login? | 02:55 |
| Nafallo | carlos: nafallo@magicalforest.se | 02:55 |
| carlos | hmmm | 02:56 |
| carlos | Nafallo, and your name? | 02:56 |
| carlos | I don't see your account | 02:56 |
| BjornT | spiv: thanks. i'll try it out. | 02:56 |
| Nafallo | carlos: Christian Bjlevik | 02:56 |
| carlos | ok, found ;-) | 02:56 |
| Nafallo | hehe | 02:56 |
| carlos | Nafallo, you are an admin now for that team | 02:57 |
| carlos | feel free to approve / reject people that is pending to approval | 02:57 |
| Nafallo | carlos: thanx :-) | 02:57 |
| === BjornT -> lunch | ||
| carlos | Nafallo, np | 02:58 |
| bradb | morning | 03:01 |
| carlos | bradb, morning | 03:10 |
| === SteveA [~steve@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| bradb | hey carlos | 03:19 |
| BjornT | spiv: so, now it fails when orderby is used together with union (since you have to use 'foo' rather than 'Table.foo'). i might be able to work around it, though, if it's too much trouble to fix it. | 03:26 |
| kiko | bradb, yo? | 03:53 |
| kiko | bradb, when you fixed the focus issue on +filebug, how did you do it? | 03:54 |
| kiko | you hacked it in, I see | 03:54 |
| bradb | kiko: in ZCML, extra="tabindex=1" (our CSS uses "tabindex=1" to do some magic) | 03:54 |
| bradb | no hack, just mysterious z3 junk | 03:55 |
| bradb | it might have to be rolled back for 1.0 AFAICS, because getting it working with the tab ordering of the other fields appears to be a monumental effort | 03:55 |
| kiko | what about the javascript | 03:56 |
| daf | urgh, headache | 03:56 |
| bradb | kiko: can't use the .js hack because bug-add.pt is used for various bug-filing forms, not all of which have title as their first field | 03:57 |
| kiko | and tabindex=1 gives it focus or? | 03:57 |
| bradb | yes, we have .js in one of our CSS files that uses tabindex to autofocus, also taking into consideration (by the looks of it, anyway), doing proper focussing on error fields if forms are filled out incorrectly (that doesn't seem to work though, but i haven't look a lot into it.) | 03:58 |
| bradb | it's possible that tabindex=1 Just Works when .js is disabled as well, but i haven't tested it, so i don't know for sure | 03:59 |
| kiko | wow, js in a css file? :) | 04:04 |
| bradb | er, sorry, it's in launchpad.js | 04:06 |
| bradb | SteveA: any news on the page title situation? | 04:13 |
| === terrex [~terrex@84-122-73-155.onocable.ono.com] has joined #launchpad | ||
| carlos | kiko, please, could you tell stub that Rosetta is still disabled? | 04:22 |
| kiko | yeah | 04:24 |
| === sabdfl [~mark@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| carlos | kiko, thanks | 04:25 |
| === Keybuk [~scott@syndicate.netsplit.com] has joined #launchpad | ||
| === stub [~stub@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| kiko | <carlos> kiko, please, could you tell stub that Rosetta is still disabled? | 04:25 |
| carlos | stub, hi | 04:26 |
| carlos | stub, production has disabled pomsgset usage and the problematic url is still under launchpad.Admin permission. | 04:27 |
| bradb | SteveA: around for a menu question? | 04:27 |
| carlos | stub, did you have any problem yesterday? | 04:27 |
| SteveA | no | 04:27 |
| SteveA | speccin | 04:27 |
| SteveA | g | 04:27 |
| bradb | daf: got a sec for a menu question? | 04:27 |
| Kinnison | Keybuk: What do you think about that version numbering stuff I mailed you yesterday? | 04:28 |
| === terrex_ [~terrex@84-122-73-155.onocable.ono.com] has joined #launchpad | ||
| Keybuk | Kinnison: those version numbers are invalid | 04:31 |
| dilys | Merge to rocketfuel@canonical.com/launchpad--devel--0: [trivial] fix some small CSS validity problems (patch-2120: james.henstridge@canonical.com) | 04:31 |
| daf | bradb: shoot | 04:32 |
| bradb | daf: ok, so I have an interface IFoo | 04:32 |
| bradb | three pages hanging off it: A, B, and C | 04:32 |
| bradb | easy enough | 04:32 |
| bradb | but | 04:32 |
| bradb | there's one more page, D. | 04:32 |
| daf | ok | 04:32 |
| bradb | it isn't actually directly linked to from any of the menu items (only A, B, and C are), *but*, I want tab C to be selected when you're looking at page D. | 04:33 |
| daf | hmm | 04:33 |
| bradb | ISTM that the menu system just does some magic and knows when you're looking at page A, and selects the tab for A, etc. any idea how to select a certain tab when you're looking at a page that isn't linked to from any of the menu options? | 04:34 |
| daf | what are the relative URLs of C and D? | 04:34 |
| bradb | +advanced and +results | 04:35 |
| Kinnison | Keybuk: but they're in the archive :-( | 04:35 |
| daf | hmmmm | 04:35 |
| daf | I don't think the current API provides for that | 04:35 |
| daf | presumably +results is the page you get when you submit a query to +advanced | 04:35 |
| Keybuk | Kinnison: that's nice | 04:35 |
| Keybuk | they shouldn't be <g> | 04:35 |
| daf | any reason they can't have the same URL? | 04:35 |
| bradb | daf: yes, because query results are not the advanced search form | 04:36 |
| Keybuk | catch a version error, and just treat it as a string | 04:36 |
| bradb | A and C lead to D | 04:36 |
| Keybuk | because it's an illegal version, there's no way to compare it | 04:36 |
| bradb | A being the simple search form | 04:36 |
| Keybuk | so you can't do sorting, but that shouldn't matter | 04:36 |
| bradb | daf: don't get me wrong, i could do some fancy ZPT to wedge this into the lp menu system but i was hoping that the menu system might help me out in this regard. | 04:37 |
| === Mez [~Mez@cpc2-lich4-3-0-cust115.brhm.cable.ntl.com] has left #launchpad ["Leaving"] | ||
| Kinnison | Keybuk: fair enough | 04:37 |
| === bradb files a bug | ||
| Keybuk | _or_ stick a 0 on the front of it, and compare it that way | 04:38 |
| Kinnison | So an upstream version of 0F4.2.1 is allowed where F4.2.1 isn't? | 04:43 |
| daf | bradb: so yes, the menu system decides which tab is selected by looking at the request URL and comparing it to the URLs of each of the links in the facet menu | 04:43 |
| bradb | daf: right | 04:44 |
| === jordi [~jordi@115.Red-213-96-69.pooles.rima-tde.net] has joined #launchpad | ||
| === terrex_ is now known as terrex | ||
| jordi | for some reason I dropped off the channel | 04:47 |
| bradb | daf: i noticed yesterday that there appears to be a way to override link.selected, but that doesn't appear to apply to the problem i'm having | 04:47 |
| carlos | jordi, looser! | 04:47 |
| carlos | ;-) | 04:47 |
| carlos | jordi, so, are you starting today? | 04:47 |
| daf | carlos: "loser"! | 04:47 |
| jordi | daf: thanks daf. | 04:48 |
| daf | ("looser" == "more loose") | 04:48 |
| carlos | daf, it's jordi, he needs to 'o' | 04:48 |
| jordi | I would have been a bit more harsh to correct that :) | 04:48 |
| carlos | in fact 'it' is Jordi :-P | 04:48 |
| jordi | carlos: apparently not. | 04:48 |
| jordi | Next week, according to claire. | 04:48 |
| daf | jordi will be joining us on Monday | 04:48 |
| === jordi dances. | ||
| carlos | daf, oh, I thought you said today ... | 04:48 |
| daf | I did | 04:49 |
| daf | I was wrong | 04:49 |
| carlos | ok ;-) | 04:49 |
| daf | I'm going to go and lie down for a bit to see if that improves matters | 04:49 |
| jordi | daf: it was going to be today :) | 04:49 |
| kiko | jordi, are you coming? | 04:53 |
| jordi | no :( | 04:54 |
| jordi | No pop the trunk for me | 04:54 |
| jordi | kiko: I am working hard in bringing the kiko-speech to Debian | 04:54 |
| jordi | pop-the-trunk is quite extended now. | 04:55 |
| jordi | DO IT needs more work | 04:55 |
| jordi | google pop the trunk :P | 04:55 |
| kiko | wow | 04:59 |
| stub | carlos: Try now | 05:03 |
| === carlos tries | ||
| bradb | mpt: ping | 05:06 |
| carlos | hmm it's still a bit slow, but it's better than what we had | 05:07 |
| carlos | stub, thank you | 05:08 |
| carlos | Nafallo, Rosetta should be ok now | 05:08 |
| Nafallo | carlos: kewl! I check it after CC-meeting :-) | 05:08 |
| stub | carlos: Only 6700 of the 28000 pofiles have been updated yet. It will take another day or two to complete the migration (the migation script could be more efficient, but I think I should just continue the existing run and not worry about fixing it) | 05:13 |
| dilys | Merge to rocketfuel@canonical.com/launchpad--devel--0: [trivial] fix validity errors in launchpad.css (patch-2121: mpt@canonical.com) | 05:16 |
| carlos | stub, is the same problem we have with the other script? | 05:23 |
| lifeless | ~[6~[6~~. | 05:47 |
| carlos | lifeless, I agree ;-) | 05:50 |
| carlos | spiv, still around? | 05:55 |
| === kolcvk [~assew@server.off.lv] has joined #launchpad | ||
| === Virtuall [~virtuall@81.198.61.143] has joined #launchpad | ||
| kolcvk | hello , i've started to translate gstreamer but it says that i'm not an official translator ... | 06:07 |
| Virtuall | how didn't I imagine that... | 06:07 |
| Virtuall | how can we with kolcvk become official latvian translators? | 06:07 |
| Virtuall | ok :) | 06:11 |
| carlos | Virtuall, kolcvk is it for Ubuntu ? | 06:14 |
| carlos | Virtuall, kolcvk from which URL are you translating? | 06:14 |
| kolcvk | yes | 06:14 |
| kolcvk | https://launchpad.ubuntu.com/distros/ubuntu/hoary/+sources/gstreamer0.8/+pots/gstreamer-0-8/lv/+translate | 06:14 |
| carlos | kolcvk, I think we don't have yet a latvian translation team... | 06:14 |
| === carlos checks | ||
| kolcvk | can we be the LV translation team ? | 06:15 |
| carlos | sure | 06:15 |
| carlos | we create it per translators request | 06:15 |
| kolcvk | so can you make us OFFICIAL lv translation team ? | 06:16 |
| Virtuall | you have the request | 06:16 |
| Virtuall | kolcvk, relax about that word | 06:16 |
| carlos | Virtuall, did you sent the request already? | 06:16 |
| kolcvk | we are easier to translate (faster) if we are .. | 06:17 |
| carlos | I have some requests in my queue, but I don't remember if latvian is one of them | 06:17 |
| kolcvk | no we did'nt sent | 06:17 |
| Virtuall | where should we send it?! | 06:17 |
| kolcvk | are request accepted on irc? | 06:17 |
| kolcvk | requests * | 06:17 |
| carlos | please send a request to rosetta@ubuntu.com | 06:18 |
| carlos | kolcvk, yes, but I could forget it ;-) | 06:18 |
| carlos | as I'm a bit busy atm and will do it later today | 06:18 |
| carlos | is better if you send it by email so I don't forget it | 06:18 |
| kolcvk | do you have some form or something ? | 06:18 |
| kolcvk | or it is freeform | 06:18 |
| kolcvk | ? | 06:18 |
| carlos | kolcvk, just send me an email with this conversation and that's enough | 06:19 |
| kolcvk | ok | 06:19 |
| carlos | thanks | 06:20 |
| kolcvk | Message was sent | 06:22 |
| carlos | kolcvk, cool | 06:23 |
| kolcvk | :) | 06:23 |
| kolcvk | will i get some answer(email) when you will add me ? | 06:24 |
| === Mez [~Mez@cpc2-lich4-3-0-cust115.brhm.cable.ntl.com] has joined #launchpad | ||
| carlos | I send a confirmation email, yes | 06:25 |
| kolcvk | 10x | 06:25 |
| mpt | bradb-lunch: PONG | 06:50 |
| mpt | er, pong | 06:50 |
| bradb | mpt: it's in your Inbox | 07:13 |
| bradb | salgado: Any love on the one-bugmail-per-recipient review? | 07:13 |
| mpt | bradb: Ok, you are 94th in the queue. Your call is important to us. | 07:14 |
| === bradb dares mpt to read mail non-sequentially! | ||
| bradb | filter on subjects that include "mpt" | 07:14 |
| SteveA | bradb: help me out. i'm really busy with specs and discussions. i'll only be able to look at your menus issue if you make it really easy for me. | 07:17 |
| SteveA | bradb: add to the bug exactly how i can see the issue. make it clear. | 07:17 |
| salgado | bradb, not yet. I'll try to look at it today | 07:21 |
| bradb | salgado: cool, thanks | 07:21 |
| dilys | Merge to rocketfuel@canonical.com/launchpad--production--1.25: Cherry pick patch-2082 (patch-5: morgan.collett@canonical.com, rocketfuel@canonical.com) | 07:22 |
| SteveA | daf: ping | 07:29 |
| bradb | SteveA: https://launchpad.ubuntu.com/products/launchpad/+bugs/1507/+edit -- does this clarify the problem? | 07:31 |
| SteveA | why +edit? | 07:31 |
| daf | SteveA: pong | 07:31 |
| bradb | SteveA: remove +edit, if you want | 07:31 |
| SteveA | daf: you filed a menus bug before debconf | 07:32 |
| SteveA | i looked into it, and i cannot see what the problem you are reporting is | 07:32 |
| bradb | mpt: the questions i had were more on the subject of where things link to. where do the following link to: | 07:32 |
| SteveA | you did not state 1. what happens 2. what should happen but does not 3. why | 07:32 |
| bradb | 1. "Bugs", "Report a Bug" and "Show Reports" when viewing the bug | 07:32 |
| bradb | page (i.e. context-insensitive.)? | 07:32 |
| bradb | 2. "Bugs", "Report a Bug" and "Show Reports" when viewing the | 07:32 |
| bradb | /malone page? | 07:32 |
| SteveA | daf: please look into this, and get back to me about it | 07:32 |
| daf | SteveA: reply sent to the bug -- please let me know if this clarifies matters | 07:37 |
| SteveA | ok | 07:39 |
| SteveA | bradb: okay, i understand what you want for bug 1507 | 07:40 |
| === daf assigns 1303 to Steve | ||
| bradb | SteveA: ok, great | 07:41 |
| SteveA | daf: https://launchpad.ubuntu.com/malone/bugs/1303 | 07:42 |
| SteveA | examples | 07:42 |
| bradb | SteveA: not sure if you saw it, but: https://launchpad.ubuntu.com/products/launchpad/+bugs/1509 was another fairly important menu bug, IMHO | 07:42 |
| SteveA | give examples of the urls | 07:42 |
| daf | ok | 07:42 |
| SteveA | daf: please tell brad about the debug menus view | 07:44 |
| daf | bradb: there's a magic URL you can append to any context object | 07:44 |
| daf | bradb: it displays information about the state of the menus system which is often very useful in debugging problems with the menu system | 07:45 |
| daf | just tack +debug-menus onto the end and paste the results into bug reports | 07:45 |
| bradb | cool, SteveA is that documented anywhere in the tree? | 07:46 |
| daf | SteveA: I've added some more information to 1303 | 07:47 |
| bradb | SteveA: would it help if i posted the debug output into 1509? | 07:49 |
| SteveA | so, i have to look at 1507, 1303, 1509, 1240 | 07:50 |
| SteveA | bradb: yes | 07:50 |
| bradb | SteveA: I've added the debug output to 1509. | 07:52 |
| mpt | bradb: Did you paste that stuff above before or after you saw my reply? | 07:53 |
| mpt | I'm not sure whether it's a reiteration or a response | 07:53 |
| bradb | haven't checked my mail since | 07:54 |
| === bradb checks | ||
| bradb | mpt: hm dude | 07:58 |
| bradb | mpt: /malone/+advanced eh? :P | 07:58 |
| bradb | mpt: we don't have a page called /malone/+advanced and, AFAIK, sabdfl doesn't want a /malone/+advanced for 1.0. so what do we do? | 08:00 |
| === debian_ [logichackd@hlfxns0146w-142167165044.ns.aliant.net] has joined #launchpad | ||
| mpt | bradb: Make it unavailable, then | 08:02 |
| bradb | ok | 08:03 |
| bradb | another thing i was wondering: why does "Report a Bug" go to the package filebug page? isn't that going to repeatedly trip-up our users who are gracious enough to file Launchpad/Malone/Rosetta bugs? | 08:04 |
| carlos | daf, https://launchpad.ubuntu.com/errors/showEntry.html?id=1121796244.240.641369537676 | 08:05 |
| carlos | SteveA, daf, is it related to the menu changes? | 08:05 |
| === debian_ [logichackd@hlfxns0146w-142167165044.ns.aliant.net] has left #launchpad [] | ||
| daf | interesting | 08:06 |
| daf | it can't be related related to my menu changes because they're not in production yet | 08:06 |
| dilys | Merge to rocketfuel@canonical.com/launchpad--production--1.25: Cherry pick patch-2116 (patch-6: morgan.collett@canonical.com, rocketfuel@canonical.com) | 08:06 |
| SteveA | carlos: yes. it uses @@absolute_url | 08:07 |
| carlos | daf, not your latest changes but the ones you did a while ago | 08:07 |
| SteveA | carlos: it should not use that. it should use /fmt:url instead | 08:07 |
| SteveA | carlos: it also means that page is not tested | 08:07 |
| mpt | bradb: Yes, there should be a global "Report a Bug" page which lets you specify a distribution or leave it blank | 08:07 |
| carlos | SteveA, yeah, I suppose it | 08:08 |
| mpt | depending on whether you're reporting a bug that's in a distribution or not | 08:08 |
| carlos | SteveA, so the fix is just a template change? | 08:08 |
| daf | and a test | 08:08 |
| carlos | I think I can do fix it as trivial and add a test | 08:08 |
| SteveA | no | 08:08 |
| SteveA | add a test | 08:08 |
| SteveA | and then do it | 08:08 |
| carlos | daf, I know ;-) | 08:09 |
| carlos | SteveA, I cannot add a pagetest | 08:09 |
| carlos | if the page does not work.... | 08:09 |
| bradb | mpt: what fields would be required on that form? | 08:09 |
| SteveA | carlos: you can write one by hand. it isn't hard | 08:11 |
| SteveA | i am just ranting about the TDD mantra | 08:12 |
| SteveA | of test before code | 08:12 |
| mpt | bradb: Product/Package, Distro (optional), Title, Description | 08:12 |
| carlos | ok | 08:13 |
| bradb | mpt: why is a form like that necessary? | 08:17 |
| carlos | daf, I think I get out of ideas to fix poimport.txt tests | 08:18 |
| carlos | daf, could you try it tomorrow? (or today if you have time) | 08:18 |
| carlos | it's a transaction problem | 08:18 |
| carlos | daf, the librarian problem disappears if I apply spiv's suggestions, but then, the mail test fails because that kind of commit seems to be invalid in that case | 08:19 |
| daf | carlos: can you paste a failure message? | 08:19 |
| carlos | daf, it's either librarian failing to find an alias or the email queue being empty | 08:20 |
| carlos | daf, more or less is the same error I sent to launchpad yesterday | 08:21 |
| daf | ok | 08:22 |
| jamesh | salgado: ? | 08:23 |
| carlos | daf, my branch: carlos.perello@canonical.com--2004/launchpad--LaunchpadPoImportFeedback--0 | 08:23 |
| carlos | daf, it's approved to be merged into rocketfuel since last week | 08:24 |
| carlos | by salgado | 08:24 |
| salgado | jamesh, me | 08:26 |
| jamesh | salgado: I made those last few changes to my CalendarSubscriptionSubset branch that you suggested. Do you want to look over it again, or is it okay to merge | 08:28 |
| jamesh | ? | 08:28 |
| dilys | Merge to rocketfuel@canonical.com/launchpad--production--1.25: Cherry pick patch-2119 (patch-7: morgan.collett@canonical.com, rocketfuel@canonical.com) | 08:28 |
| daf | carlos: I have a checkout of it | 08:28 |
| salgado | jamesh, it should be okay to merge. :) | 08:29 |
| jamesh | thanks. | 08:29 |
| dilys | Merge to rocketfuel@canonical.com/zope--test--3.0: This is a quick fix to let exceptions be logged for users with non-ascii names be logged. It is not of sufficient quality to push upstream if it is not already fixed there. (patch-16: stuart.bishop@canonical.com) | 08:29 |
| salgado | jamesh, btw, any news on your launchpad--facets--0 branch? did you get Steve to review it? | 08:29 |
| carlos | daf, I'm reverting the test/librarian setup and teardown changes I did. Moving them from the .py script into the .txt file again just in case that's the problem. IF that still fails it's all yours. | 08:30 |
| salgado | jamesh, I'm asking because I did some foaf-menu related work and that's depending on your branch getting merged | 08:30 |
| jamesh | salgado: I put it on SteveA's queue | 08:30 |
| jamesh | salgado: I should ask him about it (it is a prereq for some of my calendar UI cleanups too) | 08:31 |
| salgado | jamesh, that'd be great. thanks | 08:31 |
| bradb | stub's merge made it in without a reviewer stamp? | 08:32 |
| === mdke [~matt@mdke.user] has joined #launchpad | ||
| mdke | carlos, switching channel in here as this conversation has got longer than I expected | 08:32 |
| kiko | it's not to rocketfuel, bradb | 08:32 |
| kiko | err to launchpad, sorry :-( | 08:32 |
| carlos | mdke, ok | 08:33 |
| mdke | carlos, is it the same bug as #1511 | 08:33 |
| bradb | kiko: so the rule is that if you're not committing to launchpad, you don't need a reviewer stamp? | 08:33 |
| bradb | or is it a bug in the reviewer stamp checker? | 08:34 |
| kiko | I think the stamp checker only applies to launchpad | 08:34 |
| carlos | mdke, what? the search form returning zero entries? | 08:35 |
| carlos | mdke, no, it's different | 08:35 |
| mdke | ok | 08:35 |
| === mdke files more bugs | ||
| carlos | cprov, debonzi The sourcepackage search form is not able to find the ubuntu-docs packages | 08:35 |
| bradb | daf: when can we expect dilys to make her triumphant return to bugmail spam? | 08:36 |
| carlos | mdke, that's for soyuz | 08:36 |
| carlos | mdke, it's not a Rosetta bug | 08:36 |
| daf | bradb: I thought I'd fixed her this morning | 08:36 |
| cprov | carlos: is it related to the fti stuff ? | 08:36 |
| bradb | hm, it seemed broken to me. i'm filing another bug now, so i guess we'll find out for sure | 08:36 |
| daf | yeah | 08:37 |
| mdke | carlos, i file the bug under launchpad right? | 08:37 |
| kiko | it's broken, because I filed tens of bugs today and nothing. | 08:37 |
| carlos | mdke, that's ok too | 08:38 |
| bradb | (er yeah, i'm not going to file this bug that i was about to file, because maybe it's not a bug, but dilys is broken, like kiko said) | 08:39 |
| daf | oh | 08:39 |
| daf | it's probably a procmail thing | 08:39 |
| mdke | carlos, good, i filed it at #1513 | 08:39 |
| daf | rather than a Python thing | 08:39 |
| dilys | New Malone bug 1513 filed on The Launchpad by Matthew East: Search form on distros/ubuntu/hoary/+sources returns no result for ubuntu-docs | 08:39 |
| dilys | https://launchpad.ubuntu.com/malone/bugs/1513 | 08:39 |
| bradb | ! | 08:39 |
| daf | there we go | 08:39 |
| daf | fixed | 08:39 |
| mdke | wow | 08:40 |
| mdke | dilys is cool | 08:40 |
| carlos | mdke, ok, thank you | 08:40 |
| mdke | hmm | 08:40 |
| mdke | i have 0 karma | 08:40 |
| mdke | i guess I must have done something wrong :( | 08:40 |
| daf | I think everybody starts off with 0 | 08:40 |
| daf | we're still working on the means by which you accumulate it | 08:41 |
| mdke | ah | 08:41 |
| mdke | a while ago i had some more | 08:41 |
| mdke | ;) | 08:41 |
| mdke | also an interesting problem: in my personal settings, I can click in and edit all the boxes except for Wiki Page. In that box the cursor doesn't change and I can't click in it. | 08:42 |
| bradb | mdke: you used to have more than 0 karma? | 08:42 |
| mdke | bradb, like 60 or so | 08:43 |
| mdke | bradb, now today I filed some bugs and its 0 ;) | 08:43 |
| bradb | er, i seem to have lost a lot of karma too | 08:43 |
| mdke | bradb, we suck | 08:43 |
| dilys | New Malone bug 1514 filed on The Launchpad by Christian "kiko" Reis: Error messages in autogen'd forms are in the wrong place | 08:44 |
| dilys | https://launchpad.ubuntu.com/malone/bugs/1514 | 08:44 |
| bradb | i'm not 100% sure though. | 08:44 |
| kiko | finally dilys | 08:44 |
| bradb | mpt: i guess the malone front page should have an "About Malone" tab like Rosetta? | 08:46 |
| bradb | hm, about tabs seem to suck though | 08:46 |
| bradb | once i know what Malone or Rosetta is, i'm never going to go back to the tab again | 08:46 |
| bradb | s/the tab/that tab/ | 08:47 |
| bradb | mdke: did you merge accounts or anything? data loss is always worrying. | 08:48 |
| daf | bradb: does that matter? it's not as though the tab is particularly obtrusive | 08:48 |
| bradb | daf: depends: is tab menu space valuable or disposable to you? | 08:49 |
| daf | it's limited, which is not the same as valuable | 08:49 |
| bradb | right now, it's probably not noticeable one way or the other | 08:49 |
| mdke | bradb, no I've had the same account since I started (gulliver666) | 08:50 |
| mdke | bradb, i've added and removed email I guess, but otherwise I have no idea | 08:50 |
| daf | salgado might know what's going on | 08:50 |
| daf | I wouldn't be surprised if karma got reset during the overhaul he did | 08:51 |
| daf | since it wasn't being used for much before that | 08:51 |
| bradb | mdke: when did you last notice that you had a karma higher than 0? | 08:51 |
| mdke | bradb, fraid I can't pinpoint that. I don't check a lot. | 08:51 |
| bradb | ok | 08:52 |
| salgado | daf, yes, that's right. the karma was started from zero again last week | 08:52 |
| salgado | mdke, don't worry, soon you'll see your karma points going up. :) | 08:52 |
| === mdke wipes brow in relief | ||
| mdke | so no bug? | 08:53 |
| carlos | bradb, I used to have around 300 points of Karma | 08:54 |
| salgado | mdke, no, take a look at your "Recent Activities" page | 08:54 |
| carlos | I think latest karma changes reset the old values | 08:54 |
| jblack | stub: ping | 08:54 |
| mdke | the wiki box thing seems to have been reported already at #1462 | 08:54 |
| bradb | karma restarted last week and i still have ~550 points? hm. | 08:54 |
| stub | jblack: pong | 08:55 |
| mdke | salgado, yes the recent activities seem to have been resetted too | 08:55 |
| salgado | mdke, yes, it was resetted, but you can see the bug you just reported there. | 08:55 |
| salgado | I hope so | 08:55 |
| salgado | if you can't, then it's a bug | 08:55 |
| mdke | i can | 08:56 |
| mdke | :) | 08:56 |
| jblack | do you have the time to squeeze in an asci-output sql query? | 08:56 |
| mdke | bradb, that is some serious karma | 08:56 |
| === bradb can walk on water too | ||
| stub | yup | 08:57 |
| mdke | hehe | 08:57 |
| jblack | Also, did I ever tell you that you're a super cool dude? | 08:57 |
| jblack | I'd like product name, length(shortdesc), number of product series and if a product series, and the cvsroot if it has a : in it. | 08:58 |
| dilys | Merge to rocketfuel@canonical.com/launchpad--devel--0: [r=salgado] rename CalendarSubscriptionSet to CalendarSubscriptionSubset, and make it an adapter for IPerson (patch-2122: james.henstridge@canonical.com) | 08:58 |
| jblack | oh, and whether or not its enabled, and synced. | 08:59 |
| jblack | (I know that's a tall order, and you won't hurt me feelings if you say "are you kidding?" | 08:59 |
| SteveA | jamesh: we should do an in-person review of the code soon | 08:59 |
| mdke | thanks all | 08:59 |
| === mdke [~matt@mdke.user] has left #launchpad [] | ||
| === Virtuall [~virtuall@81.198.61.143] has joined #launchpad | ||
| === daf goes to lie down again | ||
| stub | jblack: You want length(productseries.summary) or length(product.summary) ? | 09:04 |
| jblack | product summary. | 09:04 |
| jblack | I'm trying to catch products lacking a description (typically some equivilant of "BLAH") | 09:05 |
| stub | jblack: I can't display what you asked for in a table. Do you mean you want product.name, length(summary), count(productseries), count(productseries with ':' in the cvsroot) ? Or do want product.name, length(summary), count(productseries), cvsroot (which means you get multiple rows per product, and the count(productseries) column irrelevant) | 09:12 |
| jblack | Either way works. The thing I'm after is whether or not there's an attached series that has cvs details. (btw, did you catch the part about enabled and sync as well?) | 09:13 |
| jblack | Later on I need to categorize a list of ubuntu package names by determining their state in launchpad. | 09:14 |
| jblack | Would it be easier if I broke the request up into simpler ones? | 09:15 |
| jblack | (all products that are enabled, all products that are synced, all products with a a product series that has something 'like' a cvs root, etc) ? | 09:15 |
| jblack | beg pardon. s/all products/all products with a product series/g | 09:16 |
| === SnakeBite [~SnakeBite@84.242.143.64] has joined #launchpad | ||
| dilys | Merge to rocketfuel@canonical.com/launchpad--devel--0: [trivial] Focus name field when creating a new product (patch-2123: christian.reis@canonical.com) | 09:47 |
| dilys | New Malone bug 1515 filed on The Launchpad by Brad Bollenbach: I want to be able to attach a menu to a specific page...right? | 10:03 |
| dilys | https://launchpad.ubuntu.com/malone/bugs/1515 | 10:03 |
| bradb | SteveA: ^^ another blocker bug on menus, I think | 10:04 |
| SteveA | bradb: looks rather out of scope for the menus | 10:11 |
| SteveA | bradb: i'll think it over, but really, it is out of scope for what menus are about at the moment | 10:11 |
| SteveA | see, menus are attached to the currently viewed content object | 10:11 |
| SteveA | not to arbitrary pages | 10:11 |
| SteveA | if you are trying to stretch the menus beyond what they were designed for, we have a choice | 10:11 |
| SteveA | 1. extend the design to accommodate | 10:12 |
| SteveA | 2. use or build something more appropriate | 10:12 |
| SteveA | i certainly would not call it a "blocker bug on menus" | 10:12 |
| bradb | SteveA: what do you see as being the solution to the problem? | 10:12 |
| SteveA | cos, if that is the case, i'll have to close it with a "won't fix, out of scope" message | 10:12 |
| SteveA | bradb: i'm not going to be able to look at it for a while. | 10:14 |
| bradb | i can think of ways to solve the problem, but it's all a bit too contortionist for my (and, i think, sabdfl's) taste | 10:14 |
| === Burgundavia [~corey@S0106000000cc07fc.gv.shawcable.net] has joined #launchpad | ||
| bradb | SteveA: sure, i understand that you're busy in .br | 10:15 |
| SteveA | bradb: note also... | 10:15 |
| SteveA | that menus are selected according to two things | 10:15 |
| SteveA | 1. the facet that is selected | 10:15 |
| SteveA | 2. the type of object that is the immediate content object | 10:15 |
| bradb | *oh* | 10:15 |
| SteveA | i don't see (from a brief read of your bug report) what isn't working | 10:15 |
| bradb | #1 might save me | 10:16 |
| === bradb tries | ||
| SteveA | that's the whole idea, dude | 10:16 |
| bradb | yeah, brainfart | 10:16 |
| SteveA | if you haven't already, read daf's docs | 10:16 |
| bradb | i'm still not certain that this will fix the problem, but i'm going to make another attempt | 10:17 |
| SteveA | okay, cool | 10:17 |
| SteveA | i have all of these bugs bookmarked for later | 10:17 |
| bradb | yeah, i've skimmed some of menus.txt, if that's what you're referring to. seems pretty, ahem, comprehensive. ;) | 10:17 |
| SteveA | so add any new info to the bug | 10:17 |
| SteveA | bradb: read daf's wiki page | 10:17 |
| SteveA | it explains everything very clearly | 10:17 |
| bradb | ok, i'll take a look | 10:18 |
| SteveA | menus.txt goes into too much implementation detail for what you need | 10:18 |
| bradb | indeed | 10:18 |
| SteveA | it is more for maintainers of the menus system | 10:18 |
| dilys | Merge to thelove@canonical.com/dists--bazaar--1.5: new build (patch-50) | 10:27 |
| dilys | Merge to thelove@canonical.com/bazaar--devo--1.5: baz diff --quiet shows the diff (patch-39: Matthieu.Moy@imag.fr) | 10:28 |
| bradb | daf: which wiki page did you write on menus, btw? i could find nothing written by you on the lp wiki that matched "Menu" or "Menus". | 10:30 |
| SteveA | https://wiki.launchpad.canonical.com/LaunchpadMenus | 10:49 |
| SteveA | it doesn't say the author is daf, because he was a contributor, not the original author | 10:49 |
| SteveA | however, daf has been writing and maintaining that page | 10:49 |
| SteveA | bradb: please add a link to that page in menus.txt | 10:50 |
| bradb | ah, ok | 10:51 |
| dilys | Merge to rocketfuel@canonical.com/launchpad--devel--0: [trivial] Focus name field when creating a new product (patch-2124: christian.reis@canonical.com) | 10:57 |
| === terrex [~terrex@84-122-73-155.onocable.ono.com] has joined #launchpad | ||
| dilys | New Malone bug 1516 filed on The Launchpad by Brad Bollenbach: Menu API makes it seem difficult to create a custom menu for each of distro and distrorelease bug listings | 11:16 |
| dilys | https://launchpad.ubuntu.com/malone/bugs/1516 | 11:16 |
| SteveA | bradb-afk: rejected 1516. see comments for what you need to do. | 11:22 |
| dilys | Merge to rocketfuel@canonical.com/launchpad--devel--0: Many fixes and tests for the poimport script r=salgado (patch-2125: carlos.perello@canonical.com, andrew.bennetts@canonical.com) | 11:23 |
| bradb-afk | SteveA: Right, good point, I'll make .links a property. | 11:24 |
| SteveA | well | 11:24 |
| SteveA | i think that using a marker interface is much cleaner | 11:24 |
| SteveA | because if you make 'links' a property, then | 11:24 |
| SteveA | you are spreading 'if' statements throughout the code | 11:25 |
| SteveA | rather than making the if statement in one place | 11:25 |
| SteveA | but, that's just, like, my opinion | 11:25 |
| SteveA | do you think we'll be able to get rid of the BugTaskSubset ? | 11:25 |
| SteveA | and replace it with smarter traversal? | 11:25 |
| bradb-afk | depends; how did you want to make the traversal "smarter"? | 11:26 |
| SteveA | mark has already done this for some things, in a slightly verbose way | 11:26 |
| SteveA | my Navigation stuff will make this very easy | 11:26 |
| SteveA | the idea is, when you have a distro | 11:26 |
| SteveA | and you have a url like .../ubuntu/+bugs/1234 | 11:26 |
| SteveA | then you don't actually have a content object for +bugs | 11:27 |
| SteveA | instead, in the traversal function for a distro | 11:27 |
| SteveA | you say "if you have +bugs, then 'consume' that part of the URL, and use the next part to traverse to a bug" | 11:27 |
| SteveA | so, no need for the Subset | 11:27 |
| bradb-afk | SteveA: what if it's just /ubunutu/+bugs ? | 11:28 |
| SteveA | depends | 11:28 |
| bradb-afk | (ubuntu, even) | 11:28 |
| SteveA | 404 is one option | 11:28 |
| SteveA | another option is you use a particular page template for that | 11:28 |
| SteveA | (to implement that is a tad more complex, but doable) | 11:28 |
| SteveA | (and is supported by the Navigation code) | 11:28 |
| SteveA | so, +bugs would just be a view on IDistribution | 11:29 |
| bradb-afk | SteveA: what if it's /distros/ubuntu/+bugs/+new ? +bugs/+advanced ? +bugs/+index ? this is currently the foundation of our navigation structure. | 11:29 |
| SteveA | a page, with the name '+bugs' | 11:29 |
| SteveA | so, +bugs/+new is just some other template. maybe it is a "DummyBug". I'm not sure. mark has a clear idea where he wants to go with this. | 11:30 |
| SteveA | +bugs/+advanced would be just some page template | 11:30 |
| SteveA | essentially, a view on a distro | 11:30 |
| bradb-afk | didn't you say that +bugs was itself going to be a page template? | 11:30 |
| SteveA | well... | 11:31 |
| SteveA | what you get when you go to +bugs is a page template | 11:31 |
| SteveA | the traversal function knows what to do | 11:31 |
| SteveA | to return the correct object | 11:31 |
| SteveA | whether the +bugs page, the +bugs/+advanced page, or the +bugs/123 object | 11:31 |
| SteveA | oh, brad, there are about 6000000 new business cards here for you | 11:32 |
| bradb-afk | and the context in whatever page template gets returned would always be something like an IDistribution or IProduct? | 11:32 |
| SteveA | exactly | 11:32 |
| bradb-afk | SteveA: +1.514.963.2567? i beg they put the 1 in front this time (it was my fault that it was missing last time.) | 11:33 |
| bradb-afk | (but not my fault that i got so many! :P) | 11:33 |
| kiko | still wrong | 11:33 |
| kiko | enjoy | 11:33 |
| SteveA | you have 6000000 still wrong cards | 11:33 |
| bradb-afk | shit, and i *changed* the wiki page | 11:33 |
| SteveA | yeah | 11:33 |
| bradb-afk | like, long long ago | 11:33 |
| SteveA | but this was a reprint | 11:33 |
| bradb-afk | in a galaxy far far away | 11:34 |
| bradb-afk | hmph | 11:34 |
| SteveA | because many of the cards were messed up | 11:34 |
| SteveA | so, we get a reprint of the same as the first time. no changes. | 11:34 |
| bradb-afk | oh well | 11:34 |
| bradb-afk | SteveA: this "smarter" traversal thing sounds interesting. i think it'd be interesting to see someone code it up and see if it'll actually work (with menus, etc.) | 11:35 |
| SteveA | mark has already used it | 11:36 |
| carlos | daf, so, finally, I was able to merge the poimport branch | 11:36 |
| bradb-afk | SteveA: I was thinking more specifically of Malone's existing pages, but seeing an example would be insightful. | 11:36 |
| carlos | daf, but I had to disable the connection as a the poimport user as stub asked | 11:36 |
| SteveA | it works well | 11:36 |
| carlos | stub, around? | 11:36 |
| SteveA | bradb-afk: i'll land my navigation stuff soon, and you can use that | 11:37 |
| bradb-afk | ok | 11:37 |
| SteveA | the sab will love you for getting rid of BugTaskSubset | 11:37 |
| SteveA | and i could show you how to do the required code right now | 11:38 |
| bradb-afk | with your nav stuff? | 11:38 |
| SteveA | no | 11:39 |
| SteveA | just with a normal traversal function | 11:39 |
| bradb-afk | are you talking about returning ViewPageTemplateFiles, essentially? | 11:39 |
| SteveA | the nav code makes it a breeze | 11:39 |
| SteveA | but you can do it now | 11:39 |
| SteveA | no, i'm not | 11:39 |
| bradb-afk | ok, where's an example? | 11:40 |
| SteveA | i don't know right now | 11:40 |
| bradb-afk | ok, GIVE me one then! please. | 11:40 |
| SteveA | ./canonical/launchpad/browser/traversers.py | 11:41 |
| bradb-afk | yep, i'm there | 11:41 |
| SteveA | so, you see what he's done for +lang | 11:41 |
| bradb-afk | yeah, was just looking at that | 11:42 |
| SteveA | the issue is that it is quite messy to do this right now | 11:42 |
| dilys | Merge to rocketfuel@canonical.com/sqlobject--test--0.6: Fix SelectResults.__contains__() to work with set operations (UNION, EXCEPT, INTERSECT). r=spiv (patch-31: guilherme.salgado@canonical.com) | 11:42 |
| SteveA | the one thing you can't see there | 11:42 |
| bradb-afk | SteveA: indeed it is :) | 11:42 |
| SteveA | is how to return a page for +bugs | 11:42 |
| SteveA | you should be able to do this with | 11:43 |
| SteveA | from zope.component import queryView | 11:43 |
| SteveA | page = queryView(obj, name, request) | 11:43 |
| SteveA | if page is not None: | 11:43 |
| SteveA | return page | 11:43 |
| SteveA | and where 'name' is going to be something you calculate from '+bug' and the actualy name (like '+advanced'), so like '+bug/+advanced' or '+bug+advanced' or '+bug(+advanced)' | 11:45 |
| SteveA | the latter two cases are if for some reasong '+bug/+advanced' doesn't work | 11:45 |
| SteveA | when you register the page in zcml | 11:45 |
| SteveA | do you get what i mean? | 11:45 |
| SteveA | you're looking up a page actually called '+bug/+advanced' as its nmae | 11:45 |
| SteveA | name | 11:45 |
| bradb-afk | i kind of see what you mean. i haven't yet grasped how this simplifies things vs. IBugTaskSubset though. | 11:46 |
| SteveA | well, mark dislikes xxxxSubset code | 11:46 |
| SteveA | and, with the nav code, it gets *really* simple | 11:46 |
| SteveA | if you can refactor it to this now | 11:47 |
| SteveA | then it can be easily refactored to nav code later | 11:47 |
| SteveA | and you'll save the sab doing it for you | 11:47 |
| === SteveA --> spec writing | ||
| bradb-afk | right, i have to leave right now, but i'll look at this tomorrow again. it's possible that it might help make my +filebug problem go away (if it makes it a lot easier to do +bugs/+new then the menu work is a lot easier to hook up.) | 11:49 |
| === bradb-afk & # afk, really | ||
| === mdke [~matt@mdke.user] has joined #launchpad | ||
| mdke | carlos, still awake? | 11:57 |
| mdke | or anyone else with rosetta. I need to approve some translations made by people who are not in a translation team. Do I have to copy and paste from the "suggestions" box, or is there a proper way to approve the translations? | 11:58 |
| jblack | anybody have the time to provide a pre-review review? | 11:58 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!