=== koke [n=koke@adsl229-164.unizar.es] has joined #launchpad [12:16] night all [12:17] kiko_diskless: Would you mind reviewing this privacy patch so that the Malone front page doesn't prompt for login anymore? (It doesn't do so at this moment either, but it did earlier, and it will again when another private bug gets filed) [12:18] sure [12:19] thanks, just make linting... [12:20] wow /me <3 bradb [12:20] bradb, in exchange two questions: any eta on a mountain bike for me, and how much does it cost to buy a crap car in montreal? [12:22] kiko_diskless: I haven't looked into mountain bikes yet. I'll make a note to look in the next few days. [12:22] okidok [12:22] crap car? hm, not sure. [12:23] maybe $1000-$1500 CAD [12:23] any reason why you want to buy rather than rent? [12:27] well, I was thinking of driving to NYC, but the return fee is $1000CAD [12:27] so buying might be a better option than renting [12:29] kiko_diskless: you wanna be stuck with a *car* in NYC? :) it should be pretty cheap by bus or train. [12:29] like, a few hundred bucks [12:29] yeah, that's an option. I was thinking of taking my time though [12:37] kiko_diskless: you might find something if you keep your eye on http://voir.ca/petitesannonces/annonces.aspx?iIDRubrique=801&iIDZone=1&iNumeroParution=1937 [12:38] thanks [12:42] kiko_diskless: patch sent === camilotelles [n=Camilo@20132139198.user.veloxzone.com.br] has joined #launchpad [12:58] okidok [01:09] downstairs === koke [n=koke@adsl229-164.unizar.es] has left #launchpad ["Konversation] [01:23] SteveA: hows the new lappy ? [01:31] kiko-fud: i'm not here right now, but can I merge that patch? === koke [n=koke@adsl229-164.unizar.es] has joined #launchpad === stub [n=stub@203-214-4-72.dyn.iinet.net.au] has joined #launchpad [01:37] are there any web services planned for launchpad?? === bradb [n=bradb@modemcable033.209-70-69.mc.videotron.ca] has left #launchpad [] === jamesh [n=james@203-59-207-160.dyn.iinet.net.au] has joined #launchpad === rbelem [n=rodrigo@200.246.97.164] has joined #launchpad === Seveas [n=seveas@seveas.demon.nl] has joined #launchpad [02:21] kiko-fud: Carlos seemed happy with the whitespace migration. Should I be running this on production, or do we still have more verification to do? === rbelem [n=rodrigo@200.246.97.164] has joined #launchpad [02:46] stub: There's a heinous bug in gina :-) [02:46] stub: I'm working on a fix now [02:46] itym Gina is a heinous bug [02:47] Well, there is that, but this is related to binary package priorities [02:47] we have an inverted priority map [02:47] bloody thing === Kinnison is preparing a fix now [02:50] ideally I'll need a reviewer to go over it [02:50] basically it's removing a buggered duplication and fixing up references to it [02:50] spiv: fancy an easy-peasy review? [02:53] Kinnison: sure. === Kinnison is just committing now [02:54] It'll be daniel.silverstone@canonical.com--desktop/launchpad--gina-fix--20050920--patch-2 [02:54] I'll say once it's mirrored [02:56] ** adding revision daniel.silverstone@canonical.com--desktop/launchpad--gina-fix--20050920--patch-2 [02:56] 2005-09-21 00:54:14 GMT Daniel Silverstone [02:56] Remove BinaryPackagePriority (a pointless duplication of PackagePublishingPriority) which wasn't even the same values, thusly causing endless issues with published archives. [02:56] done === spiv waits for baz [02:59] You're aware of baz's show changeset stuff yes? [02:59] I am. [02:59] Normally chinstrap is speedier than this... [02:59] Well that change is standalone so you should be able to use it === stub [n=stub@203-214-4-72.dyn.iinet.net.au] has joined #launchpad [03:10] stubby. [03:11] spiv: does that patch look okay to you? [03:17] Kinnison: Yep, looks fine. [03:17] Almost [trivial] :) [03:18] Yeah, I was gonna [trivial] it but figured it deserved a look over [03:18] it's a lot of lines for a trivial y'see [03:18] Right. [03:18] I wish more people would do what you just did :) === Kinnison grins [03:18] nearly-trivial reviews tend to be fast reviews, modulo baz. === Kinnison is gonna sit through at least the start of a gina run on dogfood, then if it looks fine, I'll send pqm a request and retire for the night === th1a [n=hoffman@pool-64-223-62-134.prov.east.verizon.net] has left #launchpad [] [03:19] *cough* because you don't have enough tests *cough* [03:19] ;) [03:20] Heh [03:21] Well, this run appears more sane [03:21] 01:21:12 WARNING Countdown 16857 binary packages [03:21] not convinced I cba. to wait through an entire binary package run [03:25] priorities look good === Kinnison bounces [03:25] merge is in pqm's queue [03:25] see you tomorrow [03:25] ciao === Kinnison -> bed. [03:27] night === Burgundavia [n=corey@S0106000000cc07fc.gv.shawcable.net] has joined #launchpad [04:08] Merge to rocketfuel@canonical.com/launchpad--devel--0: Remove BinaryPackagePriority which caused publisher vs. gina issues. r=spiv (patch-2451: daniel.silverstone@canonical.com) [04:44] Merge to rocketfuel@canonical.com/launchpad--production--1.33: Cherry pick patch-2444 into production 1.33 (patch-5: rocketfuel@canonical.com, christian.reis@canonical.com) [05:10] Merge to rocketfuel@canonical.com/launchpad--production--1.33: Cherry pick patch-2446 into production 1.33 (patch-6: guilherme.salgado@canonical.com, rocketfuel@canonical.com) === robitaille [n=robitail@d154-5-117-228.bchsia.telus.net] has joined #launchpad === hub__ [n=hub@toronto-hs-216-138-231-194.s-ip.magma.ca] has joined #launchpad [06:54] hi [06:56] hi hub__ [06:56] looks like launchpad does not like my GPG key [06:56] or that I don't like his GPG encrypt [06:57] is this a problem registering a GPG key, or signing a code of conduct? [06:57] registering [06:57] GPG reject the encrypted confirmation message [06:58] so you received the encrypted confirmation, but couldn't decrypt it? [06:59] yep [06:59] what error do you get? [06:59] adding a subkey elgmal [06:59] I think that's it [06:59] will know in a bit [07:00] note that Launchpad pulls the keys from the keyserver network, so if it is a new key (or you are making changes to it) it may take time to propagate [07:00] yep [07:00] will upload it again [07:01] so "gpg --decrypt" on the PGP blob you received doesn't give you any error messages? [07:03] bingo [07:03] that's it [07:03] sorry for the noise [07:03] enigmail decrypt without problem now [07:04] okay. Follow the URL, enter your launchpad password and it should all be set up [07:04] it will add any additional uids from the key as unvalidated emails for your account too [07:04] yep [07:04] duplicate account detected [07:04] fun [07:04] :-) [07:04] I love that [07:05] w00t [07:05] kudos to launchpad people [07:07] the merge accounts page is at https://launchpad.net/people/+requestmerge, if it didn't already point you there [07:07] it is all good [07:07] it told me, I followed it worked [07:08] now I should read the documentation [07:08] the last uid on your key looks weird: "Pedro R. Fernandez" [07:08] it is a GPG bug [07:09] I have the same key ID as someone else [07:09] I should have played lottery [07:09] http://bugzilla.mozdev.org/show_bug.cgi?id=11204 [07:10] so you do. [07:10] good thing we get you to enter in the full fingerprint :) [07:10] yep [07:10] keyid is not to be "trusted" [07:10] as there are more individuals on earth than combination [07:11] but 1 / 2^32 is still more luck that the Lotto here [07:11] hub__: Congratulations ;) [07:12] thx === _Rappy_ [n=hunt-pre@dsl-253-122.monet.no] has joined #launchpad [09:42] morning all! [09:43] I wanted to ask something, if I had a launchpad name registered, and I changed it yesterday, what isn't it reflected in my ubuntu.com email alias? [09:43] (a possible bug?) [09:50] sivang: I'm not sure if anyone except elmo can help you. [09:52] stub: ah, but as there are probably two parts to this, how do we know which of them failed? (e.g., launchpad part vs. the host system) [09:55] stub: btw, I'd like to note that the gpg importing system rocks , well, as well as every other part of launchpad [10:10] hi === Treenaks [n=martijn@messy.foodfight.org] has joined #launchpad === carlos [n=carlos@243.Red-83-47-24.pooles.rima-tde.net] has joined #launchpad [10:13] morning [10:13] hi [10:18] I'm getting timeouts and proxy errors using rosetta.. known issue? [10:19] carlos: I'm translating the Ubuntu FAQ Guide [10:19] carlos: my view is set to "untranslated only", and when I click "save and continue" it just stops.. [10:19] and after a few minutes I get: [10:19] The proxy server received an invalid response from an upstream server. [10:19] The proxy server could not handle the request POST /distros/ubuntu/breezy/+sources/ubuntu-docs/+pots/faqguide/nl/+translate. [10:19] Treenaks, could you check if it happens too with other modules? [10:20] main page works [10:20] changing profile too [10:20] Treenaks, I mean, translate another package [10:20] I can browse around [10:20] carlos: oh [10:20] carlos: let me see [10:21] thank you [10:23] same with gstreamer/show all [10:23] (waiting for the timeout/error message now) [10:24] Treenaks, URL? [10:24] https://launchpad.net/distros/ubuntu/hoary/+sources/gstreamer0.8/+pots/gstreamer-0-8/nl/+translate [10:24] (hoary!?) [10:25] hmmm [10:25] Treenaks, what do you do there? [10:25] to get the timeout [10:25] carlos: just change anything and press "Save & Continue" at the bottom [10:26] carlos: remove the "needs review" flag for example (there is only 1 on the initial page) [10:26] aw crap, my merge of last night failed with a merge conflict. [10:26] no need to change anything [10:26] carlos: oh, ok.. then just submitting creates the timeout? [10:27] yeah [10:27] Treenaks, please, could you file a bug report? [10:28] carlos: ok [10:28] I need to profile that code a bit to know what's going on... [10:28] Treenaks, thank you [10:28] carlos: what package/distribution names? === WaterSevenUb [n=WaterSev@azevedo.astro.up.pt] has joined #launchpad [10:29] Treenaks, https://launchpad.net/products/rosetta/+filebug [10:33] carlos: guess what.. [10:33] Treenaks, timeout? [10:33] carlos: I think I'm getting a timeout on bug submit [10:34] then it's not a rosetta specific problem.... [10:34] stub, ? [10:34] is there any problem? [10:34] oh it worked now [10:34] it was just very very slow [10:51] carlos: yo [10:52] stub, is the load of the server too high? [10:53] stub, Treenaks is getting many timeouts [10:56] Nothing unusual - pretty much unloaded. There is a poimport process running chewing up 20% of a CPU, but emperor still has three cpus idle. [10:56] Treenaks: Are they 'launchpad is down for maintenance' pages? [10:57] stub: no [10:57] stub: they are "Proxy error" pages [10:57] If it says 'launchpad is down for maintenance', then it is our load balancer that is giving trouble. [10:57] stub: or "System Error, please retry or file a bug" pages [10:57] ok. So I suspect that the error pages are from another proxy server between you and our data centre. [10:57] But I can't prove that ;) [10:58] stub: I'm not using a proxy on my side [10:58] once we get the request timeout stuff working, hopefully other proxies won't time out requests on us :) [10:59] Treenaks: Your ISP might have a proxy, but it would be odd for them to bother with SSL connections. [10:59] Hmm.. [10:59] stub: "my ISP" is a 100mbit ethernet cable plugged into the BGP router :) [11:00] elmo: ping [11:00] It seems to get slower on higher page numbers [11:01] stub, an HTTPS proxy?? [11:03] carlos: can be done, but doesn't make sense usually. Useful in some network topologies where clients don't have direct internet access or if you have particularly paranoid firewalling. [11:03] I don't think it can be done transparently either... === stub is pleased to discover TCP/IP is all becoming a blur from a past life [11:06] carlos: HTTPS proxies work differently to HTTP ones: you send them a "CONNECT hostname:port" command, and then you do the SSL handshake and request [11:06] still, I don't use a https-proxy.. [11:07] ok - I've found some error messages. The issue is definitely at our end. [11:07] great way to punch any protocol through a firewall if they're not configured properly :) [11:07] Treenaks: Thanks for the heads up [11:08] I'll need elmo or possibly Znarl to check out the Pound logs to determine if the issue is in Launchpad, Apache or Pound. [11:09] who can edit a teams calendar? [11:09] Burgundavia: team admins? [11:09] can it be more granular than that? [11:12] Morning === stub suspects Launchpad is taking too long to render some of the pages, and Apache is giving up waiting for the load balancer. [11:13] morning === mdke [n=matt@unaffiliated/mdke] has joined #launchpad [11:36] stub: yeah, well... [11:36] jamesh's database "takes too darn long" patch landed [11:36] so i can hook it up to the publisher [11:37] and also get that "shut down the socket if there are too many tasks queued" stuff done [11:41] dudes, we need gina run on production.... [11:47] Merge to rocketfuel@canonical.com/launchpad--devel--0: r=kiko + some [trivial] various menus landings. (patch-2452: steve.alexander@canonical.com, mpt@canonical.com) [11:47] hurrah === koke [n=koke@169.Red-217-127-113.staticIP.rima-tde.net] has joined #launchpad === koke [n=koke@169.Red-217-127-113.staticIP.rima-tde.net] has left #launchpad ["Konversation] === jinty [n=jinty@205.134.224.215] has joined #launchpad === Keybuk [n=scott@syndicate.netsplit.com] has joined #launchpad === Kinnison lunches === camilotelles [n=Camilo@20132139198.user.veloxzone.com.br] has joined #launchpad === Keybuk [n=scott@syndicate.netsplit.com] has joined #launchpad [01:52] spiv kiko-fud lifeless salgado BjornT jamesh stub -- reviewers meeting in 8 [01:53] SteveA: I won't be able to be around for this meeting, I'm in the "fix final fuckups" moment of our release [01:53] jordi: that's okay, it's a reviewers meeting === cprov [n=cprov@200-171-140-32.dsl.telesp.net.br] has joined #launchpad [01:54] SteveA: isn't the meeting at 13 UTC usually? [01:55] i thought it was 1200UTC [01:55] like the launchpad meeting [01:56] hmm, was 1600 last week [01:56] according to the logs [01:56] spiv kiko-fud lifeless salgado BjornT jamesh stub -- reviewers meeting in 65 minutes [01:57] SteveA: I mean the meeting in 3 mins? [01:57] jordi: there is no meeting in 3 mins [01:57] jordi: i was mistaken about the time [01:57] great, this is wednesday. [01:57] jordi: but, the meeting is just for the review team [01:57] there's a launchpad developers' meeting tomorrow at 1200 UTC [01:57] and you're invited to that one [01:59] Boo hiss [02:00] sounds like a singer from a redneck punk band === niemeyer [n=niemeyer@200.138.134.63] has joined #launchpad [02:02] Hiho! [02:03] hi gustavo === mpt [n=mpt@200-171-140-32.dsl.telesp.net.br] has joined #launchpad [02:05] Hello Steve [02:06] goooooooooooooooooooooooooooooood morning [02:06] hey mpt [02:07] mpt: What about "launchpadders"? [02:07] mpt: Ok.. nevermind :) [02:07] "Launchpadders" is so last month [02:08] Hehehe [02:08] mpt: what's it now then? [02:08] mpt: Launchpaddites? [02:08] mpt: Launchpaddistas? [02:08] For some reason kiko-fud addresses all his messages to the Launchpad list as "The Soyuz team at Launchpad" [02:08] though most of us aren't working on Soyuz [02:08] it's been lunchpadder for years [02:08] mpt: it's a mind-control ploy [02:09] So I always took care to rewrite that as "The Launchpadding Launchpadders at Launchpad" [02:09] mpt: once you belive you work for kiko, he can launch his evil legions of the undead^w^wlaunchpad hackers === WaterSevenUb [n=WaterSev@azevedo.astro.up.pt] has joined #launchpad === ddaa [n=ddaa@ordo.xlii.org] has joined #launchpad === salgado [n=salgado@200-171-140-32.dsl.telesp.net.br] has joined #launchpad === matsubara [n=matsubar@200-171-140-32.dsl.telesp.net.br] has joined #launchpad [02:18] BjornT, around? [02:22] hi salgado [02:23] yo BjornT. might you have some time today for us to sort out the remaining bits of that basic-voting review? [02:24] salgado: ah, sorry, forgot about that. i'll take a look at it now [02:27] cool. thank you === BjornT -> phone === segfault [i=carlos@prognus.com.br] has joined #launchpad [02:44] lifeless: what do you think of a FewerBazConflicts BOF to diagnose (and hopefully) fix the workflow of our fellow launchpadders? [02:44] could be interesting [02:44] I just have a persistent feeling that a lot of the frustration around is caused by workflow that expect that baz merge does magic. [02:45] Maybe also DemystifyingMeshMerge :) [02:45] Merge to rocketfuel@canonical.com/launchpad--devel--0: [r=spiv] Launchpad Auto Build System Scoring prototype, ordering jobs by sourcepackagerelease urgency/component and time pending in queue. (patch-2453: celso.providelo@canonical.com) [02:46] lifeless: okay, I'll sumbit to JaneW, who do you think should be lead? I think the deliverable should be documentation. [02:47] mh... that calls for jblack... [02:47] jblack: ping [02:51] Anyone fancy a quick review of two trivial, but not quite trivial patches? [02:51] (I.E. functionally they're trivial but they're more than one or two lines) [02:51] less than 400 lines? [02:52] spiv kiko-fud lifeless salgado BjornT jamesh stub -- reviewers meeting in 9 minutes [02:53] k === Treenaks [n=martijn@messy.foodfight.org] has left #launchpad [] [02:55] uhm yes [02:56] Kinnison: send them to me [02:56] Do you want patch numbers, or a diff or what? [02:56] diff + tree-id is most convenient [02:57] okies [02:57] in email? [02:57] sure [02:57] stub, ping [02:58] salgado: pong [02:59] stub, another cherrypick. would be great if you could do it before going to bed. :) [02:59] patch-2446 [02:59] want me to mail you? [02:59] SteveA: sent [02:59] salgado: Done [03:00] great! thanks stub [03:00] salgado: I asumed you forgot to email me since it seemed like a patch that needed rolling out [03:00] stub: what channel ? [03:00] Dunno [03:00] stub, indeed, I forgot. but thankfully you watch the commits list closely. :) [03:00] bah [03:01] SteveA: what channel? [03:01] canonical-meeting [03:01] kiko-fud: ping [03:01] salgado: you've got mail. it mostly the testing to make sure that assert statements are triggered that bothers me. [03:01] that is weird [03:01] the point of assert statements is that they shouldn't get triggered [03:02] exactly my point [03:02] if you're going to test for it, i think it is worth upgrading to a proper exception [03:02] you can't argue "i'm lazy, so i want a single statement" then [03:02] as you're writing a test for it [03:02] well, I'm writing tests to prove that that is not allowed [03:03] and client code should verify the pre-conditions before trying to do that [03:03] spiv: btw, are you aware of that 'python -O test.py -f --test=librarian.txt hangs? not sure if it's important or not [03:03] morning reviewers [03:04] kiko: ECHANNEL [03:04] BjornT: No, I wasn't! [03:04] BjornT: Ouch. [03:04] kiko, #canonical-meeting [03:05] old news === zyga [n=zyga@chello084010027057.chello.pl] has joined #launchpad === Kinnison prepares to upgrade his laptop to breezy using the archive re-published on mawson === Kinnison eeps [03:16] wow [03:18] wow? [03:19] yeah, sounds cool [03:20] Kinnison: be carefull... [03:20] Kinnison: I just did and it hurts :/ [03:20] zyga: what was the state of breezy @ 4am ? [03:20] Kinnison: ?/ [03:21] so, I've been using assertions a lot in database code, to catch client code not checking for pre-conditions [03:22] I also write doctests to prove you are not allowed to do some things you don't met the pre-conditions [03:23] zyga: mawson gets its archive pulse around 4am [03:23] BjornT is concerned about the tests depending on these assertions being raised [03:23] aah, zyga wouldn't know === Kinnison grins [03:23] never mind [03:24] what should I do? kiko, SteveA, BjornT? [03:24] Kinnison: I did the upgrade a minute ago and udev gave me a hard time :/ [03:24] kiko: I don't think the new exception display is as useful as I hoped. I think I need to waste more space and output the str(the_exception) + url instead of just the url [03:24] stub: which new exception display? [03:25] SteveA: Script output. [03:26] salgado: if you're writing a test to test your asserts, i think maybe these asserts are more than just that. you'll want to either put the tests in a special "here are some tests to show that we do something decent when a programmer misbehaves when using our APIs", or make them a part of the contract for those methods, documented in the docstring, and proper exceptions. [03:27] so, you have the choice of either way, but don't let it be ambiguous whether these are part of the API interface, or just you being nice to other programmers who make mistakes. [03:28] ok, so that means we should be using specific exceptions when checking for pre-conditions? [03:28] I'm sitting on the fence. More tests are good, and testing your assertions work as you hope is good. [03:28] But nobody asked me ;) === matsubara [n=matsubar@200-171-140-32.dsl.telesp.net.br] has joined #launchpad [03:29] i still think that assert statements should never be triggered, not even by tests [03:29] salgado: So one clear practical problem is that the correctness of our code, as measured by the test suite, will be wrong if your tests are depending on assert statements and we run with python -O. [03:30] I think it won't make any difference using specific exceptions in these cases, as the pre-conditions are pretty clear in the docstrings. if you don't check for them, it's your fault and you should get an exception that's not meant to be caught (AssertionError) === lamont [n=lamont@dhcp-sn38-07.hrz.uni-oldenburg.de] has joined #launchpad [03:30] I think I'm with Steve: if they're worth testing, explicitly raise rather than assert. [03:30] well, I guess everything in database code is worth testing, no? [03:31] I don't believe in arguments mentioning -O. The only people who use it don't know what it does. [03:31] stub, +1 [03:31] stub: It's a bit of a weak argument I admit. Perhaps "practical" was too strong a word to use :) === Hieronymus [n=jeroen@cp413115-a.tilbu1.nb.home.nl] has joined #launchpad [03:31] SteveA: yeah, sorry. I thought today was Thursday. [03:31] Indeed, having tests fail if you run them could be a good thing since the code isn't designed to work with it ;) [03:32] I'd almost be happier if we had "try: assert False:\nexcept AssertionError: pass\nelse: print 'LP is not python -O safe.'; sys.exit()" ;) [03:32] okay, we're never going to use -O on launchpad, without some serious cleanup work anyway. [03:32] spiv: sure, add that. [03:32] We should have a test for that ;) [03:33] salgado: keep the asserts, keep the tests, but make sure these tests are not in the general flow of documentation, but are classified as "testing asserts to catch faulty preconditions" or suchlike. [03:34] everyone vaguely satisfied with that? [03:34] i'd be happier if the tests were in a special file, to make it even clearer [03:34] It'll do for me. It feels odd, but I don't think it really matters hugely :) [03:34] Kinnison: you have review mail. [03:34] okay, I would do that. but my point here was not that I wanted only to keep the asserts. I wanted to make sure that we can use asserts to check for pre-conditions. [03:35] s/I would/I will/ [03:35] SteveA: ta [03:35] salgado: if you'd write in the docstring "if you do such-and-such it raises an AssertionError" then make sure you're not using an assert. [03:36] if you'd write in the docstring "don't do such-and-such" then use an assert [03:36] SteveA, no, I usually write "you can't use this method if you don't have this and that" [03:36] then that's fine. [03:36] use an assert [03:37] and make sure the tests of these cases are clearly separated. perhaps as doctestname-cornercase.txt or something like that [03:38] we can make the documentation work better as documentation, and put the more involved testing, and the testing of corner cases and misbehaving clients, in another file === SteveA asks for a better name [03:38] that seems pretty fine [03:40] salgado: please improve the AssertionsInLaunchpad docs, and get bjorn to review your improvements [03:40] to reflect what we've decided [03:40] sure. that's why I wanted this discussion [03:40] stub, that would be wonderful! makes me smile! === stub names Steve 'Kenneth' [03:44] i can pretend my name is "Keith" === Kinnison hands SteveA a snot-proof deckchair [03:45] i must now dig my clothes up, and go to get some belated lunch [03:46] Kinnison: are you showing sufficient gravitas? [03:47] I believe so [03:52] SteveA: was my reply convincing? === bradb [n=bradb@modemcable033.209-70-69.mc.videotron.ca] has joined #launchpad [03:54] Kinnison: yes, but it seems slightly tasteless to alter sys.argv [03:54] oh? [03:54] I guess I'm used to C where you futz with argv if you want [03:55] I'll probably end up with optparse or something eventually but since for now there's only one argument I couldn't be bothered with it [03:56] please add a comment saying "lookee here, altering sys.argv" [03:56] erm okay [03:58] Kinnison: You probably should be using canonical.launchpad.scripts.log_options [03:58] stub: whassat then? [04:00] erm... logger options. Gives you --quiet and --verbose, tied up to Pythons logging system so you use log.debug(foo) and log.error(foo) instead of print statements. [04:01] (and if you were using it, it wouldn't have been a bother to add more command line options) [04:03] stub, did you see the odd error checkwatches returns now? [04:03] BugTrackerConnectError: https://bugzilla.ubuntu.com: HTTP Error 501: Not [04:03] +Implemented [04:03] stub, I think our proxy doesn't support https, perhaps? [04:03] kiko: Don't know. [04:04] note that this is returning for bugzilla.ubuntu.com [04:04] stub: okay, so instead of thinking about optparser I'm thinking about the canonical variant. where can I find a spec about it? [04:04] which we used to be able to monitor correctly [04:04] stub, should we ping elmo and find out? [04:05] Yer.... 501 not implemented when I test manually. I guess it isn't implemented ;) [04:05] heh [04:05] bandido [04:07] stub, just turn off the proxy and at least ubuntu.com will work [04:07] o [04:07] k [04:07] kiko: Can I merge that auth problem patch? [04:07] and I'll pester james into opening outgoing https for us (think he will?) [04:07] bradb, did I read it? [04:08] kiko: I dunno. I sent it to you yesterday though. [04:08] You said you were going to review it. [04:09] ah, but saying and doing! [04:10] what's the name of our other sysadmin? [04:10] BjornT, AssertionsInLaunchpad updated. :) [04:11] stub, can I have access to the full access and error logs of the production servers? [04:12] kiko: are you going to be able to review it now, or am I going to [trivial] this merge? :) I've got four patches desparately wanting to be merged atm. [04:13] bradb, I need to eat something first, if you can wait [04:13] I'm dying [04:14] i can't wait! [04:14] salgado: If you don't mind a time delay, yes. I can copy them across to a machine you have access to. Giving out more accounts on the production servers though could be problematic as they are supposed to be secure (and more accounts == more attack vectors) [04:16] kiko: anyway, i guess i'll wait. please review this as soon as possible if you can though. the sooner this patches get merged, the sooner i can get to writing your admin fix patch. [04:16] kiko: (and the email header fix you requested, also ready to be merged but in the queue) [04:16] stub, if you did that systematically I'd really appreciate it [04:17] stub, no, the time delay won't be a problem. I just want them to try to find what users are doing that is causing them to go back to a logintoken page after they already "consumed" the token [04:17] and also find how some users are reaching the +login page on shipit [04:17] 14:13:01 ERROR Blah! [04:17] Cool. I can set up a regular rsync somewhere. Erm... chinstrap ok I wonder? [04:17] salgado, maybe just reloading the URL? [04:18] stub, that would rock! [04:18] stub, that would be great [04:18] kiko, that gives me only the error logs. I want the access logs to see what's the workflow === kiko is more excitable [04:20] and also, the error logs are starting to expire too quickly, now that we're having a lot more of these logintoken errors, because of shipit [04:21] lifeless: what do you do to prevent pysvn from raising UnicodeDecodeError from a request for a diff (e.g. when it barfs trying to decode its own data while I'd be perfectly happy with a byte stream)? [04:21] salgado: looks good. although i'd be inclined to say that the tests generally should go in a separate file, to really separate them from the documentation of the API. [04:22] BjornT, that's fine. do you want me to change that? [04:22] salgado: yeah, why not :) [04:23] well, I was expecting that you would volunteer for that. ;) [04:23] I'll change in a couple of minutes. :) [04:26] salgado: They are in ~stub/production_logs on chinstrap. I'll cron it tomorrow unless elmo has some way already setup for doing this sort of thing. [04:26] stub, cool. ta [04:28] stub, rock! [04:28] salgado, I was suggesting that that was the way people were running into errors [04:30] kiko, could be. but they'd have to do that before the form is processed, because they get redirected after that [04:32] Weird - one of the launchpad servers isn't getting any hits, but it seems to be responding just fine. [04:34] stub, pound perhaps? [04:34] maybe [04:35] https://chinstrap.ubuntu.com/~dsilvers/paste/file7ZsueE.html [04:36] seems like the password widget used the wrong context? [04:40] weird [04:42] kiko, they're not reloading the page. all the requests returning 404 are GET requests [04:43] Merge to rocketfuel@canonical.com/launchpad--devel--0: Minor dominator fix and add --careful to publish-distro.py. r=stevea (patch-2454: daniel.silverstone@canonical.com) [04:43] oh no, there's some POSTs too. I guess that ones I can assume are all reloads? [04:44] If you call .selectOneBy() does that error if there are more than one? [04:44] or does it do a LIMIT 1 [04:44] ? [04:44] Kinnison, it raises [04:44] Kinnison, at least selectOne raises [04:44] okay thanks [05:04] is there any problem with LP? it's damn slow here. [05:04] here too === Kinnison blows dogfood away and starts it again, sorry guys === lamont [n=lamont@dhcp-sn38-07.hrz.uni-oldenburg.de] has joined #launchpad [05:13] upstairs for some salgado/matsubara action [05:19] salgado: about your request for oppinion about LoginToken, to keep them seems to be a good idea since they do not represent a big storage volume and I think we will have plenty space for new token ids ( [a-zA-Z0-9] [20] ~7E36 possibilities) . Based on this we can have an additional feature in foaf that shows all requests done by you, if it's interesting at all ? what do you think ? [05:23] yeah, I think it's okay to keep tokens around (in particular to avoid 404s) [05:23] jordi: Around? [05:23] but should we keep them forever? [05:25] why not? [05:25] salgado: why not ? 2 reasons are valid: we can't generate new token ids ( false 7E36 available, more than 1E6 worlds pop.) AND we can't store (false they are tiny) [05:28] BjornT: stick around dude, I'll be following up to your URL changes email soon... :) [05:28] cprov, seems fine. can you reply to my email, so we keep the discussion in a single place? [05:29] salgado: ok, to store every token available the number is HUGE even in TB ;) [05:29] salgado: ok, will reply [05:29] bradb: ok, i will :) [05:31] bradb: btw, would you object if i would remove the wrapping that is done for comments in mail notifications? [05:31] BjornT: yeah, i think i would, actually :P [05:32] why do you want to remove wrapping of comments in email notifications? [05:32] bradb, because it doesn't work very well [05:32] bradb: it's buggy as it is, and i'd say it's almost impossible to get it right. [05:32] well, BjornT, to be fair, I think it's fixable [05:33] I store all the bugmail launchpad emits on our product [05:33] bradb: what we could do is to wrap the comments that are made via the web ui, before we store them in the database [05:33] about 5% is broken [05:33] it may not be simple to fix, but I don't think any user will appreciate a developer shortcut of simply removing wrapping from emails altogether :) [05:33] BjornT, that's not trivially done -- you should see the bugzilla bug about removing wrap-hard [05:33] let me get you a reference [05:34] BjornT: my opinion is: yes, it's probably not easy, but if you can try and make it Just Work, users will be happy. they will demonstrate their satisfaction in the form of not saying "gah! what's with this ugly, unwrapped email!" [05:35] bradb, BjornT, before continuing down this path, I suggest you look at https://bugzilla.mozilla.org/show_bug.cgi?id=11901 === BjornT reads === bradb works on landing the URL changes firstr [05:35] bradb: ping [05:36] it was fixed the right way, too [05:36] SteveA: can it wait? I'm in the middle of something for the next couple of hours. [05:36] SteveA: I was going to get back to you later on that transaction.commit breakage [05:36] bradb, BjornT: one major improvement would be not wrapping lines that start with >. [05:37] kiko: yes, i think we can do useful, smart things like that that will help solve the problem [05:37] bradb: this is about actions portlets and your work [05:37] SteveA: right, what's up? [05:37] see, unless we coordinate, it's likely you'll get conflicts and so need to do more work [05:38] so, enough menus stuff has landed so that you can go directly to using menus on your branch, i think [05:38] this would be better for you, and it doesn't take very long to do it. [05:38] what do you think? [05:39] SteveA: I need to land this code. [05:40] so, we're agreed then? ;-) [05:40] SteveA: I've already lost one full day to conflict resolution. [05:40] SteveA, I'd suggesting letting bradb land, tbh [05:40] great. this will save you from further conflicts in the area of actions portlets. [05:40] really, it's a very quick thing for you to do. [05:40] SteveA: After it's landed, I'll make more menu changes. [05:41] BjornT: I'm still confused: what different does importing from the specific module make when in the interfaces package? [05:41] carlos, can you ping me when you're back? [05:41] __init__.py gets run either way, no? [05:41] bradb: it's possible you'll conflict. [05:42] SteveA: I've already merged up to about an hour ago. [05:42] when can you land what you have? [05:42] SteveA: within the next couple of hours, hopefully [05:42] kiko, I'm back already [05:42] super-carl [05:42] os [05:42] if it's within the next couple of hours, that's great [05:42] bradb: try not to import sourcepackage from its specific module, and you'll see === bradb tries [05:43] hm [05:45] I don't understand why that happens. [05:45] __init__.py still gets run, no? [05:46] jordi, hi [05:46] jordi, around? [05:47] jordi, ping us when back === hub__ [n=hub@toronto-hs-216-138-231-194.s-ip.magma.ca] has joined #launchpad [05:49] bradb: i'm not sure exactly how it works, but i do know that it can cause problems sometimes === bradb feels the sting of a language with (virtually) no compile time [05:53] BjornT: reply sent === niemeyer [n=niemeyer@200.138.134.63] has joined #launchpad [06:09] kiko, carlos: here, sortof (I'm back at office finishing the release) [06:10] I'll privmsg jordi, carlos [06:10] jordi, wasn't gajim's 0.8 branch obsolete? [06:10] kiko, ok [06:10] thanks [06:13] umm [06:13] bradb: you haven't mirrored the changes yet? [06:14] BjornT: nope [06:14] waiting for make check first [06:14] do we know about broken apps 2 on production? [06:14] bradb: ok, ping me when you've done that. it looks fine, just want to take a quick look at it. [06:15] BjornT: ok, will do [06:15] carlos: heh, this is a bit silly. [06:15] elmo, stub was talking about this -- but he said the server was answering requests fine? [06:16] ddaa, around? [06:16] well, I just logged on and saw a "timed out" on nagios [06:16] it's actually disappeared now [06:16] which doesn't make me feel much better [06:16] salgado: I am. [06:16] jordi, so as I think, they changed their mind, right? [06:16] carlos, jordi: I think nikos is confused, just let him be [06:17] wait for him to show up if he must [06:17] he's usually on #pygtk, I can knock on him there [06:17] ddaa, will "baz make-archive --mirror" overwrite an existing archive? I want to re-register my mirror [06:17] I'd consider it a bug if it did. [06:18] you probably want "baz register-archive -d" with the old location and "baz register-archive" with the new one. [06:18] I do not know how the -f flag behave with the new archive registration model, it had a clear use case with registered names, though. [06:19] salgado: but I think the proper place to ask is #bazaar :) [06:19] or #arch [06:19] ddaa, I already delete the existing registration and registered my own archive again [06:19] so, what's the problem? [06:19] but then after that I don't have the mirror registered. (e.g. archive-mirror fails) [06:20] archive-mirror: Warning: no mirror registered for guilherme.salgado@canonical.com === matsubara is now known as matsubara-lunch [06:20] salgado: -> #bazaar === Seveas [n=seveas@seveas.demon.nl] has joined #launchpad [06:23] ddaa: is malone bug 1205 still important to you? [06:35] SteveA: I might be able to answer when launchpad.net starts responding again... === zyga [n=zyga@chello084010027057.chello.pl] has joined #launchpad [06:41] kiko: do you know anything about the crap the test suite is spewing? [06:41] on stderr [06:42] SteveA: this is not important anymore [06:43] now that the import death sprint is over [06:43] ddaa: okay. thanks. [06:43] Would still be sexy to have though :) [06:43] it's on a very old branch from morgs [06:43] probably best to reimplement it if we need it in the future [06:44] SteveA, no clue :-/ [06:44] it's gross, man [06:44] I do not think we are ever going to _need_ it again [06:44] I need to run for fud to get back in time for the meeting [06:44] ok [06:55] Merge to rocketfuel@canonical.com/launchpad--devel--0: rs=kiko hook jamesh's request timeout code up to the web publisher. (patch-2455: steve.alexander@canonical.com) [06:56] mpt: ping === camilotelles [n=Camilo@200.128.80.250] has joined #launchpad [06:58] SteveA: pong [06:59] kiko: The salient differences between bug 11901 and now are that (1) NS4 is no longer a target browser, and (2) browsers except MSIE support max-width [07:00] BjornT: changes committed and mirrored === bradb holds his finger over the Big Red Button === mdz [n=mdz@ca-studio-bsr1o-251.vnnyca.adelphia.net] has joined #launchpad [07:04] gogogo brad. doit === gneuman [n=guest@200-171-140-32.dsl.telesp.net.br] has joined #launchpad [07:07] BjornT: how's it look? [07:07] bradb: push it! [07:07] ! === matsubara-lunch is now known as matsubara [07:27] SteveA: What's your preferred way of documenting a "missing" parameter in an Interface? i.e. How do you write the interface code/method signature to show that? [07:27] what is a "missing" parameter? [07:27] e.g. [07:27] missing = object() [07:27] class IFoo(Interface): [07:27] def bar(this, that, somethingelse=missing): [07:28] is this a marker? [07:28] can you not use None ? [07:28] """Do stuff...raise an error if something else is missing.""" [07:28] SteveA: no, can't use None. None is a valid arg value. [07:28] okay [07:28] I suggested [07:28] class NoUserSpecified: pass [07:28] placing that in the interface [07:28] then you need to have a singleton value that is available from the interfaces file [07:28] um, module [07:28] and using in the interface and in the database class [07:29] right [07:29] it needs to be called something unique [07:29] that's what I suggested [07:29] so, not just missing [07:29] it's a constant, basically [07:29] but [07:29] consider having two different methods [07:29] don't use a class? :) [07:29] no_user_specified = object() would be good [07:30] but, consider having two different methods [07:30] it is often bogus to have a method change what it does based on the presence or absence of a keyword arg. [07:30] SteveA: it's a database search method, whose user parameter is required. [07:30] this is a guardian, SteveA === SnakeBite [n=SnakeBit@84.242.143.64] has joined #launchpad [07:31] SteveA: i.e. we want to specifically say that it's required, and give you a useful error message if you didn't pass a user arg. [07:31] if the 'user' parameter is required, make it a positional arg [07:31] that is how in python you say "this arg is required" [07:31] SteveA: that breaks pretty easily. [07:32] all the user of the API has to do is pass a parameter in the first position, in this case, and it would work [07:32] so, you want to ensure that someone sets it explicitly [07:32] well, "work", i.e. break [07:32] and it can be set to a Person or to None ? [07:32] SteveA: right [07:33] okay. then in the interface, you can just say user=None, and in the docstring, say "The 'user' argument must be explicitly supplied" [07:33] and in the implementation, use a private marker for its default value [07:33] ok, that was another approach i had considered [07:34] will do that, thanks [07:34] why not use the same value for interface and database, SteveA? [07:34] because it is a private marker [07:34] it doesn't need to be in the interface [07:34] Merge to rocketfuel@canonical.com/launchpad--devel--0: [trivial] Following the specification, fixing builddUI pages for homogeneous facet url +builds. (patch-2456: celso.providelo@canonical.com) [07:34] two different implementations could use different markers, for example [07:35] it would do no particular harm to put the marker in the interface, and import it into the database code, but it seems to be a lot of work for something that will never be used. [07:35] actually, something that is _meant_ to be never used [07:36] kiko: are you happy with that then? =None and a private marker? [07:36] If None is not a a valid value, it's simpler to just use that. [07:36] sure [07:36] Trying to enforce contract in python tends to lead to much ugliness IME. [07:37] ddaa: i agree. [07:37] however, brad is adamant that he wants clients to provide the 'user' arg explicitly [07:38] I think None would make a pretty good value then. [07:38] so i think 1. that's just an implementation issue and 2. a note in the docs serves to note the requirement [07:38] so, it is None in the interface [07:38] and a marker, to detect whether it is explicitly provided, in the implementation [07:38] using **kw is another way to check it is explicitly provided, btw [07:39] And it's TypeError if the argument is not set to something of the right type or interface (or just not None). [07:39] yuck! [07:39] it is an error of some kind if the argument is not provided [07:39] the arg can be provided as None === bradb commits the changes [07:40] bradb: what is the error you're trying to avoid people making? [07:40] SteveA: not passing the user arg [07:40] which causes us grief [07:40] SteveA: if they don't pass the user arg, they almost surely will not get the correct, privacy-aware, search results back. [07:41] what will they get back if user is None? [07:41] would a warning suffice? [07:41] SteveA: the correct, privacy-aware search results. in this case, as an anon user. [07:41] correct [07:41] SteveA: warnings aren't strong enough for this, IMHO. [07:41] well... [07:41] let me think aloud for a moment [07:42] what if you made the default value None [07:42] and had a warning that is issued only if the value is None while the logged-in user is not anonymous [07:42] anyway -- another question [07:43] why can't you make 'user' positional ? === ddaa think Python people do not use NullObject often enough [07:44] SteveA: because it's too easy to get that wrong. for example, if it were positional, the existing bug that caused me to fix this bug in the first place would have remained uncovered by the tests. [07:44] bradb: sounds good, but i'm none the wiser [07:44] example? [07:44] bugset.search(duplicateof=bug) [07:44] er. [07:44] btw "uncovered by the tests" can mean two very different things [07:44] icks that [07:45] call the API searchAsUser(user, other args) [07:46] SteveA: there's a better reason why i rejecting making user positional [07:46] not the thing about uncovering bugs in tests, etc. [07:46] rather, the error message [07:46] TypeError: foo() takes at least 1 non-keyword argument (0 given) communicates very little to the user of the API, in this case [07:47] please write the method's "def" here [07:47] >>> def foo(bar, baz=None): [07:47] ... pass [07:47] ... [07:47] >>> foo(baz=1) [07:47] Traceback (most recent call last): [07:47] ... [07:47] um [07:47] the actual method we're talking about [07:48] oh [07:48] def search(self, duplicateof=None, orderBy=None, limit=None, user=_missing): [07:48] okay. def searchAsUser(self, user, duplicateof=None, orderBy=None, limit=None) [07:49] that is much more pythonic than what you're trying to do [07:49] the name tells clients of the API that 'user' is important and required [07:50] phew, that's going to break a lot of code :) [07:50] BRM [07:51] brm? [07:51] bicycle repair man [07:51] lifeless and spiv swear by it [07:51] ah, interesting [07:52] if it works with emacs, i might be interested [07:55] SteveA, I had a change in person-porlet-actions.pt. all I need to do now is add it to the relevant contextmenu (TeamContextMenu in this case)? [07:56] that depends what the change is [07:56] if the change is to do with context menu items, then you need to update that context menu [07:56] if, however, the change was to do with an app menu (bounties, specs, support, etc) then that app menu needs updating [07:57] it has to do with the context menu (a 'Show Polls' link) [07:57] ok === mdke_ [n=matt@81-178-156-35.dsl.pipex.com] has joined #launchpad [08:03] SteveA, there's a 'common_reassign' in PersonContextMenu(). I guess I can remove that, right? [08:03] depends [08:04] depends on? [08:04] well, common_reassign comes from the CommonLinks mixin class [08:04] so, if you want to use the menu link at that point in the menu, then you need to leave it in. [08:04] if you do not want to use it, then take it out [08:05] kiko: replied to your review of the front page patch [08:05] this CommonMenuLinks is used only in browser/person.py? [08:05] SteveA, ^ [08:05] (I mean, it's not meant to be used by other modules, I guess) [08:06] Who else has upgraded to Breezy for LP development? [08:06] i have, on my laptop === camilotelles_ [n=Camilo@200.128.80.250] has joined #launchpad [08:07] not on my desktop yet [08:07] SteveA: Did dist-upgrade work ok? [08:07] bradb: fresh install [08:07] ah [08:07] bradb: Mine was a touch difficult [08:07] bradb: but I'm doing it from the dogfood archive [08:07] bradb, I'm not using for LP development, but the dist-upgrade went fine === Kinnison is having to upgrade gina to cope with broken stuff [08:08] the only problem was caused by filesystem corruption, that I guess was there before the upgrade [08:08] When I dist-upgraded to warty, I couldn't boot anymore :/ turned out to be a yaboot conf problem (initrd line somehow got commented, IIRC) [08:08] salgado: yes, the CommonLinks is used only there at present, because that's the place where the links were in common. [08:08] this will need refactoring if we get links in common across modules [08:08] then, they'll move into webapp/__init__.py [08:09] SteveA, then, right now, the common_reassign shouldn't be "common", as it should exist only in teams pages [08:09] okay, then you can move it into just the team's class, and change its name [08:19] Merge to rocketfuel@canonical.com/launchpad--devel--0: [r=BjornT] Malone URL changes. Yep. Also: contextualize the bug page, allowing for viewing a bug in a context where it's not yet filed (and One-Click (TM) reporting of the bug in that context), add a simple distro sourcepackage object and a bunch of other bugfixes. (patch-2457: brad.bollenbach@canonical.com) [08:20] woo bradb woo [08:20] "Yep." [08:21] well done bradb [08:21] thanks :) === camilotelles__ [n=Camilo@200.128.80.250] has joined #launchpad [08:22] I've got a bunch more to land today, if the toolchain stays out of my way. [08:22] you mean that was your last landing of today? [08:23] kiko: I've got three other patches on the way to merge today. The toolchain will probably limit me to getting about two of them merged. === kiko chuckles [08:25] kudos to BjornT for taking on the task of reviewing that patch. :) [08:28] SteveA: btw, that means all systems go for whatever menu stuff you're working on. making sure Malone menus work superbly is my next major goal (while doing various other things, like making sure our error messages, success messages, and other feedback messages 1. exist and 2. don't suck.) [08:29] cool [08:29] nice one brad [08:29] i'm merging the latest now, so i can land some of mpt's menus work [08:29] 1 conflict [08:29] but need to see whether tests pass [08:30] how bogus is that? [08:30] <<<<<<< TREE [08:30] def traverseSourcePackage(sourcepackage, request, name): [08:30] if name == '+pots': [08:30] potemplateset = getUtility(IPOTemplateSet) [08:30] return potemplateset.getSubset( [08:30] distrorelease=sourcepackage.distrorelease, [08:30] sourcepackagename=sourcepackage.sourcepackagename) [08:30] return None [08:30] ======= [08:30] >>>>>>> MERGE-SOURCE [08:30] why is that a conflict? [08:30] it's clearly an addition [08:31] lifeless once explained this to me, but I forgot [08:31] ddaa might know [08:32] because diff3 sucks? [08:32] SteveA: lemme guess, it's an addition at the end of a file? [08:32] no [08:32] SteveA: it's called traverse_sourcepackage, IIRC [08:32] in traversers.py [08:32] lib/canonical/launchpad/browser/sourcepackage.py [08:32] SteveA: my guess would be that there is a deletion at this point between BASE and OTHER. [08:33] since base is not shown, you get this puzzling message [08:33] bradb: what did you do with the searchAsUser stuff? [08:33] i don't see that name in the source [08:33] SteveA: just merged from rf into that branch. will resolve conflict and merge now. [08:33] cool [08:33] thought it was the one that just landed [08:33] you are truely a man of many branches [08:34] SteveA: the point about the traversal function is that i moved it into the right place [08:34] which appears to be what's causing the conflict [08:34] i see, so that's just dead code now? [08:35] SteveA: did you change anything at all in that code? the function you show doesn't exixst here. [08:35] nor does it *exist* here [08:35] the first part is identical with what you moved [08:36] so, i'll just delete it [08:36] sounds good === gneuman [n=gneuman@200-171-140-32.dsl.telesp.net.br] has joined #launchpad [08:42] mpt: what did you do to #2112 an hour ago. An email came through but it's impossible to tell from that what you did [08:42] mpt: I'm suspecting that you unduplicated it [08:44] That is correct, and it was only a few minutes ago [08:45] gneuman, matsubara: Those bugs were about the same code, but they weren't duplicates [08:45] sladen, it's a bug in malone -- I know about it but am unsure it's reported [08:46] kiko: Then report it and get your interns to mark it as a duplicate if necessary ;-) [08:46] mpt, they are next to you -- please ask them yourself. [08:47] kiko, they subscribed to launchpad-bugs five minutes too late, so they don't have a copy of the notification [08:47] hum, I suppose that doesn't matter though [08:50] of course it doesn't [08:50] there is this great feature called "forward" [09:17] launchpad seems to be 'hung' for about the last 3 minutes. The actualy server responds but no page comes back [09:18] probably some freak query on some page taking up all the resources [09:19] we have code waiting to be deployed that stops such things from happening [09:22] *still hung*. Do both the frontends live behind the same IP or can I force it onto the other one? Hmm, now there's a 503 unavailable [09:24] and back to being hung [09:25] Keybuk: I'm wondering: should the Sender: header be malone@... (which, AFAIK, doesn't exist), or the bug's address? [09:25] malone [09:25] :D [09:27] bradb: probably somewhere like 'malone' or 'malone-bounces' which goes to an intelligent piece of code that picks up bouncing email address and stops spamming them after a couple of fails === Hieronymus [n=jeroen@cp413115-a.tilbu1.nb.home.nl] has joined #launchpad [09:28] exactly [09:28] and set the envelope sender/return path (MAIL FROM:) to the same thing [09:28] When will Launchpad be back? Is there an ETA? [09:30] kiko: for this Reply-To/From patch (which was meant to make the From: header ML friendly but replying to the message still Do The Right Thing), do you mind if we save the Sender: setting/bounce handling for another day? [09:31] (well, From: header ML friendly, easy to reply directly to person who made the change, etc. but anyway, same question... :) [09:32] bradb, is it difficult to add a sender line? [09:34] Hieronymus, it's back, already [09:35] kiko: No, but I don't know how that behaves with bounces. === bradb muddles around the RFCs [09:36] bradb, any worse than we currently do? [09:36] kiko: if it bounces to an address that itself would bounce then that would seem worse to me [09:36] ddaa: ping [09:37] Merge to rocketfuel@canonical.com/launchpad--devel--0: r=SteveA, mpt's mpt@canonical.com/launchpad--menus--0509 adding menus to source packages (patch-2458: mpt@canonical.com, steve.alexander@canonical.com) [09:37] yay === SteveA goes home [09:37] yay yay yay [09:38] and distro releases! [09:38] mpt: mail me about any menus stuff for me to review tomorrow morning. [09:39] bradb: surely you want email replies about the bug to go back to the bug! [09:40] bradb: otherwise you have the same hassle with Bugzilla where you actually have to log into it [09:40] sladen: Yeah, of course we want replies to go back to the bug, hence Reply-To: [09:41] SteveA: I won't have time for any more before tomorrow, probably === rbelem [n=rodrigo@200.246.97.164] has joined #launchpad === Burgundavia [n=corey@S0106000000cc07fc.gv.shawcable.net] has joined #launchpad === rbelem is now known as rbelem-afk === fr500 [n=admin@201.219.12.6] has joined #launchpad [09:49] hey all [09:50] elmo: do you know if I can change my email alias, I changed it in launchapd but it doesn't reflect on the mail alias. (actually, it would be nice to know if this feature even exists) === Hieronymus [n=jeroen@cp413115-a.tilbu1.nb.home.nl] has left #launchpad [] [09:52] jblack: I might be sort on time [09:52] Keybuk: would you consider it acceptable to set Sender: to malone-bounces@ for now and set the Envelope From to malone-bounces@ when we've already written a bounce handler for that? [09:52] jblack: but here's the idea [09:52] jblack: our boys are complaining a lot about baz, I think the problem boils do to two things: [09:53] bradb: sure [09:53] ok [09:53] 1. not using available optimisations in particular hardlinked trees and fl_cow [09:53] 2. bad workflows that cause a lot of conflicts [09:54] Yes [09:54] sivang: yes you can, and it should work now [09:54] jblack: I was thinking of making a FewerBazConflicts BOF, were we could talk with the most serious cases (bradb? mpt?), figure out their requirements and come with alternative workflows to satify them. [09:55] jblack: the deliverable of the BOF wolud be documentation, so I though of you as the BOF main. [09:55] elmo: ok, I'll test that again [09:55] jblack: I wanted to know how you felt about it before actually submitting the BOF to JaneW. [09:55] elmo: every how often is the cronjob for this changes is run? [09:56] sivang: I wonder if you feel like translating one of the xml gnme manuals using xml2po to see if it works. :) [09:56] sivang: it's not fixed ATM, I'm still working on it [09:56] there are some that are really short. [09:56] sivang: no need to finish it even [09:56] I think thats a good idea. put me as first, and lifeless as second. [09:56] elmo: oh ok, let me know when you want me to test it [09:56] sivang: now === mdke_ is now known as mdke [09:56] elmo: ok, sec. [09:56] jblack: okay, please remind me about it (I'm going to leave any minute now) [09:57] ddaa: I'll try [09:57] so I might forget about it [09:57] ddaa: planning a launchpad documetnation bof? [09:57] sivang: a very specific kind of documentation, but yes [09:57] general documentations things are jblack's === dand [n=dand@gw.datagroup.ro] has joined #launchpad === ddaa leaves [09:58] elmo: you rock :) [09:59] jblack: I'm interested in both, where do I sign ? :) [09:59] ddaa: The things about baz that slow me down the most are: 1. its speed, 2. its robotic feedback. Not sure that that fits with what you had in mind for discussion in a FewerBazConflicts BOF [09:59] sivang: sivang: It'll be on the bof page [09:59] s/feedback/feedback and failure modes/ === terrex [n=terrex@84-122-83-29.onocable.ono.com] has joined #launchpad [10:01] jblack: k [10:01] jblack: on the same as the distro team's you mean? [10:01] There will be some master list at the bof, and once we get it on it'll be listed there and in the schedule. [10:02] ddaa: on the other hand, relying on the user chosing a different filesystem or using obscure LD_PRELOAD hacks to allow editing of hardlinked trees, etc. isn't exactly the right way to solve speed issues [10:03] . o O (you said it dude) [10:05] jordi: what do we need to test? [10:05] jordi: habe you done changed to xml2po ? [10:06] sivang: if it works at all for rtl langs [10:06] jordi: IIRC you thought it was Yelp's fault, did you sort that out? [10:07] I have no idea. That's what I'd like to find out. :) [10:07] jordi: ok, let me know if there is a very small snippet I can test with, but I need to finish a patch before, will ping you when I'm ready [10:10] sivang: geyes-applet is trivial [10:10] should be done in 15 minutes. [10:10] http://kvota.net/doc-l10n/by-modules.html [10:11] jordi: through rosetta ? [10:12] sivang: nope [10:12] jordi: how ddo I fetch the xml for translation ? [10:12] sivang: actually, have a look at desktop-feedback :) [10:12] even more tiny [10:12] but geyes is very easy [10:13] you do the po file, and then convert to xml [10:13] I can tell you how [10:13] I need to get the source pkg right? [10:14] jordi: can you email me instructions instead? If I don't manage to finish it tonight I will do it tommorow while at work [10:14] sivang@ubuntu.com? [10:16] jordi: you know it already :) [10:16] jordi: ah sorry, sivan@ubuntu.com [10:16] jordi: without the g [10:19] k [10:22] sivang: mailed === GoRoDeK [n=gorodek@p5083D797.dip.t-dialin.net] has joined #launchpad [10:26] there goes launchpad [10:27] Keybuk: one more nitpick: would it be ok to set Sender: to our standard, LP-wide bounce address? (currently this is bounces@canonical.com in the config file i'm looking at, but presumably when we get serious about bounce handling, it'll be something more launchpadesque) [10:27] yes [10:28] ok === rbelem-afk is now known as rbelem [10:28] sender can be anything launchpaddy, it basically says "this is what made this e-mail" [10:28] bradb, does this affect bjorn't bounce-into-librarian code? [10:28] kiko: no idea [10:30] we're already setting Errors-To to that the same address in production, so it seems unlikely that this would cause any harm === mpt wonders why we're talking about baz BoFs when we'll have switched to bzr by then ;-) [10:32] okay === WaterSevenUb [n=WaterSev@azevedo.astro.up.pt] has joined #launchpad [10:40] Keybuk: right, so, I've added this: [10:40] >>> msg["Sender"] [10:40] 'bounces@canonical.com' [10:40] kind of test all throughout bugnotifications.txt [10:40] and a 2-liner in mailnotification to add the header [10:40] Keybuk: tests pass, can i merge it now? [10:40] cool [10:41] go for it [10:41] go for it bradb [10:41] make us proud [10:41] heh === bradb goes for it [10:41] sometime soon we'll want to change the id to bugXXX@bugs instead of XXX@bugs [10:41] stop getting caught in spamtraps [10:41] though perhaps this From: is less hated [10:42] maybe bug.42@...? [10:42] jordi: ok, I got the mail. thanks [10:42] jordi: can I use ubuntu source pkg instead of fetching from CVS? === terrex [n=terrex@84-122-83-29.onocable.ono.com] has joined #launchpad [10:45] sivang: most probably, but you'll have to run automake, not autogen [10:45] jordi: ok, then I'll try that , I will do it now for you :) === dand_ [n=dand@gw.datagroup.ro] has joined #launchpad [10:48] jordi: hmm, ironically enough, geysy doesn't have it's own pkg, it's part of gnome-panel's src pkg [10:48] jordi: is that ok ? [10:49] gnome-panel? it's not gnome-applets? [10:50] jordi: no, geys is in gnome-applets IIRC (minus late hour and full day of work) [10:50] jordi: hrm. you were right [10:54] bradb: speed: see hardlinked trees, fl_cow and my following reply to Keybuk's comment. robotic feedback: What do you mean? I see you often here complaining about having a ridiculous number of conflicts. [10:55] jordi: I can't find the POT in the CVS website [10:55] the ridiculous number of conflicts is when baz decides to use an ancient branch of Celso's as the common ancestor, rather than the revision just two back [10:55] it does it from time to time [10:55] it's a known bug [10:55] ddaa: the conflict insanity was mostly specific to the URL changes branch, not a regular thing [10:55] Keybuk: we know how to solve the speed issues. lifeless has been working a lot towards fixing them in baz, cleaning the code to allow making the changes. But they will never be implemented there because the focus is now on bzr, which has the improvements built-in already. [10:56] sivang: I gave you a link for the pot file before [10:56] jordi: it opened whole lots of modules, not specific to geyes [10:56] ddaa: indeed [10:56] Keybuk: so I'm focusing here on: 1. alleviating the pain in the meantime 2. diagnosing the workflow issues that will cause pain in the future as well [10:56] sivang: you can pic the pot file for geyes there [10:56] pick === Keybuk recommends morphine [10:57] jordi: found it. I need some caffeine. Too bad I don't drink coffe anymore [10:58] I have never drank coffe :) [10:58] ddaa: the robotic feedback is things that matter only a fraction as much to me as the speed issues. you get used to "botched invariant", "Comparing FROM and TO ...", "Applying 150 revisions .............................", the enormous amount of output from baz switch, etc. after a while. :) [11:00] bradb: speed issues: here, baz status on a launchpad tree takes 10s. Most merge and switch ops take less than a minute, it takes more time only when months old trees are involved. [11:00] bradb: how does that compare to you? [11:01] i don't have exact numbers, except to say that it's a heck of a lot slower for me [11:01] i don't use fl-cow though [11:01] using hardlinked trees gives you order of magnitude more speed on status/diff/commit. fl_cow makes that safe. Having a well hardlinked revlib makes merges much faster (brings the benefits of hardlinked trees into the revlib). [11:01] i was kind of hoping to not have to [11:02] and, well, it's not packaged for warty [11:02] er, hoary even [11:02] maybe it's in breezy though? i haven't upgraded yet. [11:02] ddaa, about the months old trees; that matters only if not using --link? or it always matters? [11:03] bradb: I'm not using it personally, because i'm confortable enough to do it the unsafe way. But I have seen it deployed and it's quite simple not all that scary: the cow effect is restricted to specific directories. [11:03] bradb: ask lifeless for details, he's the debian maintainer for the thing. [11:04] I'm using hardlinked trees without fl-cow and I'm not having any problems. fl-cow is only for safety? [11:04] salgado: it always matter, just because the delta grow so insanely huge. And not just patchlog, genuine source changes as well. But I think nobody should be using branch as out of date as what is used in importd production systems. [11:04] salgado: yes [11:05] fl-cow is just there to avoid corrupting your revlib when using a hardlinked tree and being careless. [11:06] oh, wait a second. you were refering to months old trees or months old branches? my trees are ages old and I switch them everyday, but all my branches are fresh [11:07] I mean things like switching between launchpad head and the 1.22 production branch. [11:09] Merge to rocketfuel@canonical.com/launchpad--devel--0: [r=kiko] Fix a bug on the Malone front page where 'latest bugs' wasn't privacy aware, and thus causing inappropriate auth challenges when recent bugs included private bugs. (patch-2459: brad.bollenbach@canonical.com) [11:09] so, if all my branches are fairly recent, this shouldn't be a problem for me? [11:09] salgado: the date at which your branch was created is hu... [11:09] irrelevent you will be assim.... gag === bradb writes cherrypick mail [11:10] what matters is how far in time it is wrt to the other branches you merge/switch your tree with. [11:11] ahhh, now I see [11:12] good ole bradb [11:13] later all === mpt [n=mpt@200-171-140-32.dsl.telesp.net.br] has left #launchpad [] [11:14] SteveA: I'd like to get some team feedback about this FewerBazConflicts things. Maybe the issue is not where I think it is. I'd like to know who feel the have more conflicts than they should have. And those will be the raw matter for this BOF. [11:15] SteveA: so, I'd like if you could add something about that on tomorrow's meeting agenda. Should not take more than a couple of minutes. [11:15] * the raw material for [11:22] jordi: I do make inside the geyes/docs dir, but it doesn't run [11:22] make: *** No targets specified and no makefile found. Stop. [11:23] I ran automake instead of autogen as you said [11:23] sivang: need to run automake and configure [11:24] jordi: DOh, silly nme [11:25] configure running [11:26] jordi: done === sivang trying to open the xml file in yelp [11:27] weird. Something went wrong. I can't see my translations [11:28] you see english? [11:28] from the xml in the he/ dir? [11:37] jordi: yes, although I can swear I transalted about 3 strings [11:38] jordi: I think it ignored the he thingy altogether [11:41] sivang: does the dxml have any hebrew at all? [11:41] or is it just yelp? [11:42] ddaa, why does baz consume so much memory? [11:42] users are baz branching launchpad and blowing up at 500MB [11:42] launchpad dead again [11:42] because it's buggy? [11:43] and there's no way of working around this right? [11:43] maybe adding a cachedrev? === matsubara [n=matsubar@200-171-140-32.dsl.telesp.net.br] has joined #launchpad === kiko looks at ddaa for hope [11:43] kiko: can someone already branch launchapd ? :) === rbelem is now known as rbelem-afk [11:44] kiko: apparently this problem only occurs with branch and merge, so my guess would bet it has something to do with building full lists of ancestors in memory. === ddaa punts to lifeless [11:45] ddaa, how do I add a cachedrev manually? [11:45] kiko: I do not think that would help [11:45] but it would not hurt to try... [11:45] I think it might [11:45] lifeless added one for me once [11:45] it helped [11:45] jordi: the xml doesn't seem to have hebrew at all [11:45] kiko: baz cacherev REVISION === Kinnison manages to branch launchpad quite easily [11:46] rock [11:46] if you want to add a cacherev in anything but the default location, you need to specify an url in place of the archive name. === Kinnison prods his local mirror [11:49] okay [11:49] jordi: I found the "problem" I was translating inside the POT file (need some sleep), putting it in the PO itself, displays hebrew nicely on yelp [11:49] jordi: however, not alinged right. text is displayed correctly though [11:50] jordi: does this help? [11:50] ddaa, how long should this take? [11:51] it's stuck running gpg === Kinnison finds that caching a rev of launchpad takes a while [11:51] something roughly proportional to (size of the checkout)*(baz network suckiness) [11:52] IOW a loooong time === Kinnison finds that the cacherev mostly takes the time of tar [11:53] assuming it's already in the revlib [11:53] I wonder why the last cacherev is 2322 [11:53] if we are in 2459 [11:53] mh [11:53] that's a bug [11:53] I see [11:53] sounds like the autocacherev isn't working [11:53] sounds like it [11:53] it's strongly advised to make lifeless miserable about it until the baz used by pqm is fixed. [11:54] that's why baz is eating up so much memory [11:54] lifeless is all systems go on avoiding taking a pie in the face I think [11:54] kiko: just add intermediate revs to your revlib [11:54] I am happy [11:54] kiko: you are a manager, you are more qualified than I for harassing people [11:54] if I take a pie in the face to make everybody more productive great [11:54] what isn't great is that johan tested bzr yesterday and said that branching was slow [11:55] I wonder what he means by slow === matsubara [n=matsubar@200-171-140-32.dsl.telesp.net.br] has joined #launchpad [11:55] kiko: was that on a system with local disc? [11:55] kiko: IAUI the bzr guys are cooking up a Twisted-based networking support that does not suck. [11:55] Kinnison, indeed it was [11:56] weird [11:56] kiko: coo [11:56] he hasn't used baz yet though [11:56] I cannot see what could possibly take a long time in a bzr branch... [11:56] everything's relative if you haven't used baz [11:56] ha... I guess it was doing ~ "cp -R"... [11:57] kiko: I heard there are things much worse [11:57] CVS for example [11:57] it can't be slower though [11:58] and launchpad dies === ddaa gives kiko a larch [11:58] was larch fast? [11:59] okay, see baz is faster than tla [11:59] now, consider something about 50x slower than tla [12:00] my imagination isn't so good [12:00] how much is baz faster than tla? [12:01] hard to measure, the speed up come for a good part from things like automatic cacherevs [12:01] ah [12:01] but I'd say about 2x faster [12:02] I'm a die-hard tla addict and never bothered to look seriously at baz [12:02] sometimes more, when e.g. the backbuilder kicks in. [12:02] this gives me another reason to change habbits [12:02] the backbuilder was cool [12:02] does baz suck less than tla over nfs? [12:02] I think it sucks about the same. [12:02] anything FS-heavy will suck over NFS [12:03] it still abuses the FS just as badly