/srv/irclogs.ubuntu.com/2005/09/28/#launchpad.txt

=== Seveas [n=seveas@seveas.demon.nl] has joined #launchpad
=== Seveas [n=seveas@seveas.demon.nl] has joined #launchpad
=== Seveas [n=seveas@seveas.demon.nl] has joined #launchpad
=== Seveas [n=seveas@seveas.demon.nl] has joined #launchpad
mptgoodnight people01:01
=== mpt [n=mpt@200-171-140-32.dsl.telesp.net.br] has left #launchpad []
=== Seveas [n=dennis@seveas.demon.nl] has joined #launchpad
=== Seveas [n=dennis@seveas.demon.nl] has joined #launchpad
=== camilotelles [n=Camilo@20132139198.user.veloxzone.com.br] has joined #launchpad
=== Seveas [n=seveas@seveas.demon.nl] has joined #launchpad
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: [r=kiko]  make malone admin aware, fix a privacy-related bug for upstream task editing and a nasty bug in login() that was not raising an error when an invalid email was passed (patch-2469: brad.bollenbach@canonical.com)02:24
=== hubZzz is now known as hub
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: [trivial]  Minor variable name fixing for buildd infrastructure after test in DF, foodix/breezyfood is running. (patch-2470: celso.providelo@canonical.com)02:44
=== bradb [n=bradb@modemcable033.209-70-69.mc.videotron.ca] has left #launchpad []
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: Bring failed binary imports down from 472 to 6 by finding sources more aggressively. r=spiv (patch-2471: daniel.silverstone@canonical.com)02:49
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: Facilitate navigation when changing orders. Fix https://launchpad.net/malone/bugs/2449. r=kiko (patch-2472: guilherme.salgado@canonical.com)03:27
=== stub [n=stub@203-214-4-72.dyn.iinet.net.au] has joined #launchpad
=== robitaille [n=robitail@d154-5-117-228.bchsia.telus.net] has joined #launchpad
=== GoRoDeK [n=gorodek@p5083D517.dip.t-dialin.net] has joined #launchpad
=== Burgundavia [n=corey@S0106000000cc07fc.gv.shawcable.net] has joined #launchpad
sivangMorning all!08:55
Treenakshey sivan08:56
=== BjornT [i=10183@82-135-221-189.ip.takas.lt] has joined #launchpad
sivanghey Treenaks  ;)09:18
=== carlos [n=carlos@243.Red-83-47-24.staticIP.rima-tde.net] has joined #launchpad
carlosmorning09:29
carlosstub, hi, around?09:29
stubyes09:30
carlosstub, I was not able to reach staging's librarian from mawson09:30
carlosI'm not sure If I'm doing anything wrong09:30
carlosstub, I took the configuration from the staging configuration and put it inside the default one09:31
carlosbut I still get "connection refused" errors09:31
stubcarlos: the staging environment is rebuilding at the moment, including a fresh db sync from production09:31
stubcarlos: Because the whitespace migration script completed09:31
carloscool09:31
carlosstub, well, I had that problem yesterday09:32
stubShould be about another 1 hour 15 mins or so09:32
stubcarlos: I'll test from mawson once it is back up09:32
carlosstub, ok, if you could tell me the config I should use, please...09:33
stubdownload_url http://librarian.staging.launchpad.net/09:35
stubdownload_host librarian.staging.launchpad.net09:35
stubdownload_port 8009:35
stubupload_host asuka.ubuntu.com09:35
stubupload_port 5809009:35
stubThat should be enough09:36
carlosok, that's the problem, wrong port...09:36
stubcarlos: staging update had a problem - it will be dead for another 2.5 hours09:46
carlosstub, ok09:47
carlosthanks for the info09:47
=== interalia [n=interali@adsl-60-232.swiftdsl.com.au] has joined #launchpad
stubcarlos: I think you missed a 'where' clause in that SQL you sent me10:29
carlosright, sorry10:30
carlosI copied& pasted the wrong line10:30
carlos:-(10:30
carlosWHERE code = 'fy'10:31
stubcarlos: done10:32
carlosthank you10:32
=== ghostdog [n=ghostdog@203.177.246.234] has joined #launchpad
=== ddaa [n=ddaa@ordo.xlii.org] has joined #launchpad
=== _Rappy_ [n=hunt-pre@dsl-253-122.monet.no] has joined #launchpad
=== lamont [n=lamont@dhcp-sn38-07.hrz.uni-oldenburg.de] has joined #launchpad
ddaalifeless: if the needs ever become serious, I think I have come up with a good idea to considerably speed up cscvs svn support while keeping decent layering.11:15
lifelessddaa: cool11:15
ddaaThe basic idea is to have a cache that is loaded at the start of the import for each revision. The cache manages a full svn checkout, and sequencially updates the tree. The update can be optimised by finding the the longest common prefix of modified relpath() in the log. Then all propget, cat, listing, etc. operations can be done on the local checkout instead of asking the repository.11:17
=== nkour [n=nkour@ppp50-adsl-3.ath.forthnet.gr] has joined #launchpad
KinnisonMorning11:20
nkourcarlos, hello11:20
lifelessddaa: k11:22
nkourcarlos, I'm upstream can I update a po in rosetta? Can I remove a branch in rosetta? (after moving the po back to 'the package' branch)?11:24
carlosnkour, gajim?11:25
nkourcarlos, yes I hate to be bugging but the problems are still there11:25
carlosnkour, you need to talk with Jordi11:26
nkourcarlos, about what?11:26
nkourdammit I do not understand how I do not have full control to even delete it from rosetta and readd it11:26
carlosnkour, we are being confused with gajim. First the 0.8 branch was requested to be removed, now we should use it....11:26
carlosnkour, so it's better if you talk directly with jordi, who started to handle your request11:27
carlosso we don't confuse the request11:27
nkourcarlos, okay. the problem was that I was not aware svn was added, nor the guy that asked understands the innerings11:27
nkourjordi, hello11:27
carlosnkour, could you send an email explanining all the issues to rosetta@ubuntu.com?11:28
nkourcarlos, but tell me this. why can't I do whatever I want without bugging you?11:28
carlosjordi will get it and me too 11:28
nkourokay11:28
carlosnkour, it depends on what do you want to do11:28
nkourEVERYTHING :)11:28
nkourthat is related to my project11:28
carlosnkour, please, describe current situation and how do you want it11:28
nkourremove po, add po, add/delete branch etc etc11:29
nkourI want to have 0.8 and JUST THAT, and upload whichever po I get outside of rosetta so I do not see people dup effort11:29
nkoureg. I have italian po 100% now, outside of rosetta. I cannot do anything to avoid dup of effort11:29
carlosnkour, you should be able to upload any .po file as the owner of the product/potemplate after the initial upload done by jordi11:30
carlosnkour, if you are not able, it's a bug11:30
nkourcarlos, I do not see how to do that in https://launchpad.net/products/gajim/+translations11:31
carlosplease, send the email so we don't miss anything and we will tell you what is doable, what is not doable and if it's planned in the future11:31
carlosnkour, https://launchpad.net/products/gajim/it/+upload11:31
nkourcarlos, hidden link? 40411:31
=== rbelem [n=rodrigo@200.246.97.164] has joined #launchpad
carlosnkour, sorry https://launchpad.net/distros/ubuntu/breezy/+sources/gajim/+pots/gajim/it/+upload/+login11:33
carlosnkour, sorry https://launchpad.net/distros/ubuntu/breezy/+sources/gajim/+pots/gajim/it/+upload11:33
carlosnkour, it's not a hidden link11:33
carlosyou select the language and choose to upload a po file11:34
carlosit's the procedure11:34
carlosother option is to upload a tarball with the .pot file + .po files from: https://launchpad.net/distros/ubuntu/breezy/+sources/gajim/+pots/gajim/+upload11:34
nkourcarlos, ok I keep those links but via UI I do not see how to do it sorry11:35
nkourI mean how to go to those links. how to select langauage11:35
nkourall I get is that my preferred lang is Greek and that is all11:36
carlosnkour, because as upstream, you are supposed to use the one I told you for the tarball with the .pot and .po files11:36
carlosnkour, the other is for translators11:36
carlosso you only see the language you translate into11:37
carlosanyway11:37
nkourcarlos, ok11:37
nkourcarlos, should I still write a mail just to say that I want HEAD to be removed or you can just rm it ?11:37
carlosyou can reach it from https://launchpad.net/distros/ubuntu/breezy/+sources/gajim/+pots/gajim11:37
carlosnkour, send the email, please11:37
nkourcarlos, https://launchpad.net/distros/ubuntu/breezy/+sources/gajim/+pots/gajim/+upload says:  Sorry, you don't have permission to access this page.11:38
nkourYou are logged in as Nikos Kouremenos11:38
nkourdon't you love that?11:38
carloslifeless, 11951 carlos    15   0 2125m 994m  968 D  0.3 65.8  17:43.15 baz11:39
carlosnkour, that's a bug11:39
carlosno, wait11:39
carlosit's not a bug11:39
carloswrong owner...11:39
carlosjust a second...11:39
=== rbelem_ [n=rodrigo@200.246.97.164] has joined #launchpad
ddaait's a bug jim, but not as we know it11:39
nkourok fix me!!11:39
carlosfuck11:39
nkourat least the hidden way works11:39
carlosnkour, I gave you the wrong link11:39
nkourone by one the po11:39
carloswait11:39
carloslet's start again...11:39
nkourno wait11:39
nkourI do not like 0.8 being controls by Rosetta Admins11:40
carloshttps://launchpad.net/products/gajim/+series/main/+pots/gajim/+upload11:40
carlosnkour, the other is Ubuntu specific so it's normal you are not allowed to do anything there11:40
nkourcarlos, ok I wanna discuss that a bit11:40
carlosphone11:40
carlosjust a second, please...11:40
nkourk11:40
carlosI'm back11:45
nkourwow I found another bug?11:45
nkourI uploaded italian to the hidden link (0.8 it/) but I get italian fully untraslated but it is not hte case11:46
nkourbut first things first:11:46
carlosnkour, dude, the upload messages tells you that it takes some time to have the import done....11:46
nkourok it was listed though :^11:47
nkourI'm upstream and you say that the correct way is to upload a tarball11:47
nkourbut I cannot11:47
carloswhy?11:47
nkourso I have to have access to secret links to upload each po11:47
nkourbecause in 0.8 I do not have access11:47
nkournow, I do not undersatnd this philosophy:11:47
nkourusers use 0.8, not svn. we have new strings (but not frozen strings) in svn, so user if submits a new transl (outside of rosetta) it sends us directly to us11:48
nkournow, without the hidden link, it's impossible for me to avoid: another italian starting from 0% in 0.811:48
nkourbut that po is for 0.8 100%11:49
carlosnkour, why do you say that you cannot upload a tarball?11:49
nkourand I cannot say to tranls: "hey do svn, but you will have your strings removed (not frozen)" so all NEW translations are for 0.8 but rosetta is bossy11:49
nkourcarlos, because owen ir Rosetta Admins and not me11:49
nkourso it's insane11:49
nkourexcept if you guys want to be bugged everyday11:49
carlosnkour, ok, one thing is Ubuntu, another thing is upstream11:50
nkourI do not care about that11:50
nkourlisten:11:50
nkourif I get Chinese outside of Rosetta, I will get it for 0.811:50
nkourfor 0.8 strings11:50
nkourso I consider it done. but rosetta does not know, so Liu Xian guy will start Chinese from scratch and will waste time11:50
carlosnot really11:51
nkourhe could have used to chinese another app11:51
nkourhow is that/11:51
nkour?11:51
carlosif you upload that translations into upstream's link https://launchpad.net/products/gajim/+series/main/+pots/gajim11:51
carlosnkour, he will see those translations as suggestions11:51
carlosin the near future, we will implement a way to apply automatically those translations from upstream directly into Ubuntu's ones11:52
carlosbut atm, the translations will appear11:52
carlosneed to be manually selected, but will see them11:52
nkourlost you11:52
nkourif I update to devel (where I'm owner) what happens?11:52
nkourdo they also get magically to 0.8?11:53
carlosnot directly (yet)11:53
nkoura so you like bugging :)11:53
carlosbut will appear in any other branch we have11:53
carlosas suggestions11:53
nkourok wait11:53
nkourI do not like bugging you again so let's solve this11:53
nkourvia the hidden link: https://launchpad.net/distros/ubuntu/breezy/+sources/gajim/+pots/gajim/it/+upload I can upload po to 0.8 right?11:54
carlosno, because you are not member of the Ubuntu's Italian translation Team11:54
nkouru said so, I did but 10 mins have passed and italina is still 0% https://launchpad.net/distros/ubuntu/breezy/+sources/gajim/+pots/gajim11:54
carlosyou can only do that into: https://launchpad.net/products/gajim/+series/main/+pots/gajim/it/+upload11:55
nkourcarlos, well it did not fail !11:55
carlosnkour, are you sure it was inside distros URL or products URL?11:55
nkourdistros11:55
nkourmoreover11:55
carloshmmm 11:55
nkourso it got added 0%11:56
nkouryab :)11:56
nkourif I make translation open to anyone, can I update the PO in 0.8?11:56
nkourif not, there you go. I have to bug you everyday11:56
=== mdke [n=matt@unaffiliated/mdke] has joined #launchpad
carlosnkour, ok, you found a bug....11:57
nkouryes that is yab11:57
carlosyou should not be able to do the upload...11:57
nkourI do not mind finding bugs, but I also want to do the job11:57
nkourI want to upload po to 0.8 po11:57
nkourpos*11:57
carlosnkour, you can have CLOSED translations for 0.811:57
nkourok I open them and I can11:58
carlosand still have rights to do the uploads11:58
carlosas maintainer11:58
nkourwell it did not work11:58
nkourit's 0%11:58
nkourplease tell me what to do to have italian in 0.8 and then remove devel11:58
carlosnkour, dude... again, the upload is not done so fast11:58
carlosit's added to a queue of imports11:58
carlosand is handled later11:58
nkourcarlos, ok the upload wants 20 minutes?11:59
nkourok11:59
carlosnkour, we are uploading all OpenOffice translations so the queu is a bit busy11:59
carlosusually it does not take more than 5 minutes11:59
nkourthat queue I hope says about moving basque back to 0.811:59
carloswith the current queue it will take some extra time11:59
nkourok11:59
nkouris that import queue somewhere upblic?12:00
nkourcarlos, I wanna make sure it is the ast time I bug you12:00
carlosdid you release any gajim version from the 0.8 branch?12:00
nkouryea12:01
carlosnkour, no, we still need to implement the web view of that queue12:01
carlosnkour, could you tell me the exact version and codename?12:01
carlosplease12:01
nkourcarlos, 0.8, 0.8.1, 0.8.2 (last is in ubu)12:02
nkourcarlos, I have to go soon12:03
SteveAhi12:03
nkourcarlos, the problem to be solved:12:03
carlosnkour, I'm near there12:03
carlosnkour, the series is now 0.812:03
nkourremove devel12:03
carlosso devel has been removed already12:04
carloslook into it12:04
nkourwas the basque po moved to 0.8 from devel?12:04
carlosNafallo, https://launchpad.net/products/gajim/+series/0.8/+translations12:05
carloss/Nafallo/nkour/12:05
carlosnkour, there are only one set of translations12:05
carlosnkour, the ones in devel are now the 0.8 translations12:05
nkourthanks12:06
nkourI hope Italian gets filled12:06
carlosnkour, you need to upload it yourself12:06
nkourreupload?12:06
nkourok12:06
carloseither uploading a tarball with hte .pot and .po files at https://launchpad.net/products/gajim/+series/0.8/+pots/gajim/+upload or using the URL it/+upload12:06
nkourok12:07
carlosbut use the /products/ url instead of the distros one12:07
carlosnkour, anything else?12:07
nkourcarlos, the problem: LP points to distros url12:07
carlosthat's something you will need to talk with sabdfl (mark), by default we point to the latest Ubuntu release12:08
carlosnkour, are you going to use Rosetta as upstream way to translate gajim?12:08
nkourcarlos, I cannot force everyone to use Rosetta12:09
=== jinty [n=jinty@205.134.224.215] has joined #launchpad
nkourhttps://launchpad.net/distros/ubuntu/breezy/+sources/gajim/+pots/gajim/+edit fix so HEAD --> the latest from the box below left in this page12:09
nkourI cannot do that so I bug you12:10
carlosnkour, I mean... are you going to get/upload translations for all languages?12:10
carlosnkour, that's a /distros URL so it's normal you don't have rights there12:10
nkourcarlos, yes i know so just please update that12:11
nkourcarlos, I just upload to /releases/ the italian po12:11
nkourwhich was outside rosetta12:11
nkouras rosetta hugs POT without aksing (via ubu package) I'm forced (because I'm a good guy) to update pos there so I do not get dup of effort12:12
nkourdamn12:12
=== SteveA wonders if stub is still around
=== zorglub [n=zorglub@194.146.226.84] has joined #launchpad
Kinnisonanyone know what this is, and how to fix it? : https://dogfood.ubuntu.com/distros/foodix/breezyfood/i386/readahead12:13
TreenaksI can't translate in rosetta anything atm, is t his known?12:13
SteveAKinnison: i can help12:14
SteveAKinnison: so, you have an expression in a template that goes  file/url/fileurl, line 19, col22 of binarypackage-portlet-details.pt12:14
zorglubhow often does the bazaar repository sync with upstream ?12:15
SteveAand it is saying that 'file', a BinaryPackageFile object, cannot be traversed to the name "url"12:15
SteveAthat would ususally mean that there is no 'url' attribute or method, or that the attribute or method is a forbidden attribute.12:16
SteveATreenaks: what's up?12:16
KinnisonSteveA: right, ta12:16
TreenaksSteveA: When I click "save & continue" in rosetta, I get a System Error page12:17
TreenaksSteveA: after a few seconds of waiting12:17
SteveAokay.  what is the exact URL you see before you click "save and continue" ?12:17
TreenaksSteveA: works on almost all rosetta URLs with translatable strings for me12:18
SteveAplease give me a specific url12:19
TreenaksSteveA: I can't even get there now: https://launchpad.net/distros/ubuntu/breezy/+sources/ubuntu-docs/+pots/faqguide/nl/+translate12:19
Treenaks(second time it works)12:19
SteveAwhat's your usename on launchpad?12:20
TreenaksSteveA: martijn@foodfight.org (/people/martijn)12:20
TreenaksSave & Continue on https://launchpad.net/distros/ubuntu/breezy/+sources/ubuntu-docs/+pots/faqguide/nl/+translate gives an error12:20
SteveAokay12:21
SteveAi can see what is happening12:21
SteveAthe problem is that the query is taking too long for the back-end database to process, so it is being aborted12:21
Treenaksreasonable12:21
SteveAit's an issue that some rosetta pages with certain translations are taking too long to be processed12:22
SteveAand this can have a bad effect on the whole application12:22
TreenaksI can't translate anything atm12:22
SteveAi'll look into it and get back to you in 10 mins, okay?12:23
Treenaksok12:23
zorglubok, I registered VLC on launchpad and I have a few questions12:24
SteveAvlc rocks12:24
zorglub- I registered a product, and then, saw the concept of projects. I don't understand how I can attach the product to the project now12:25
zorglub:)12:25
zorglub- I added the SVN repository, and bazaar sync now says "testing", it has been like that for some time, is it normal / how long does it normally take ?12:27
SteveAddaa / jblack: a question for you here12:27
zorglub- vlc has a translation in rosetta, from breezy, but it's not up-to-date. To add the upstream .po, I need to wait for bazaar mirror and then ask the rosetta list, right ?12:27
zorgluband that's all :)12:27
SteveAyou can get jordi to help you upload the .po right away, i think12:28
ddaaSteveA: ACK12:28
zorglubSteveA: will it automatically sync with upstream .po when they are modified in SVN ?12:28
ddaazorglub: what the name of the thing?12:29
zorglubproduct is vlc, project is videolan12:29
ddaagoing to production requires auditing and some manual operation12:29
ddaamh12:29
=== carlos [n=carlos@243.Red-83-47-24.staticIP.rima-tde.net] has joined #launchpad
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: [trivial]  Make poimport and poattach connect as correct database users (patch-2473: stuart.bishop@canonical.com)12:30
ddaazorglub: the product does not appear to belong to any project, do you want me to fix that?12:31
zorglubyes, please12:32
ddaazorglub: done12:32
zorglubthx12:32
ddaaalso, reviewed the project description12:32
ddaazorglub: I'm going to enter the release tarball details12:35
ddaa(it's not _yet_ used, but will eventually provide much packaging goodness through HCT)12:35
zorglubfor 0.8.2 ?12:35
ddaamh...12:35
ddaanevermind...12:36
ddaaI'm still finding that bit somewhat confusing, so just ignore what I said. You do not need it yet.12:36
zorglubok12:37
zorglubI actually didn't really understand why releases are attached to a developent branch12:37
ddaaReleases are attached to series.12:38
zorglubhum, no, that's actually logical12:38
ddaaWhich are actually much more than branches.12:38
ddaaI have a patch in the works here that actually exposes branches, and they may not be attached to any series.12:38
ddaaalso, a series may have no branch...12:38
ddaaThe UI is currently very confused about that though.12:39
ddaaThe fact that you can actually associate releases to series in a somewhat, but not quite, freeform manner does not help IMO.12:39
ddaazorglub: the test import is running, i'll keep you posted12:40
zorglubok thansk12:41
SteveATreenaks: can you try translating again now please?  see if the page works.12:42
ddaaMh, I reproduced a hang situation in the cscvs test suite here12:44
ddaadarn CVS... apparently, sometimes it won't quit after a SIGTERM... will add a SIGKILL after 10 seconds12:44
TreenaksSteveA: ok12:57
TreenaksSteveA: "Sorry, a system error occurred"12:59
TreenaksSteveA: https://launchpad.net/distros/ubuntu/breezy/+sources/ubuntu-docs/+pots/faqguide/nl/+translate12:59
stubcarlos: staging is all updated now01:02
carlosstub, cool, thanks01:02
=== SteveA pings stub
=== zyga [n=zyga@2-mi2-1.acn.waw.pl] has joined #launchpad
stubyo01:04
SteveAdo you see the priv message?01:04
SteveATreenaks: can you try once more please?01:10
TreenaksSteveA: trying01:11
ddaaHey, I need a trivial review01:12
TreenaksSteveA: Still a system error, took longer this time though01:13
ddaawho has a couple of minutes to help me fight pqm hangs?01:13
TreenaksSteveA: before the kill-long-queries-hack I sometimes had to reload 2 or 3 times (max timeout: Proxy 502 error) to get it right01:14
ddaadavid.allouche@canonical.com--2004/cscvs--quickfixes--0--patch-601:14
TreenaksSteveA: consistently01:14
dilysMerge to rocketfuel@canonical.com/pybaz--devel--0: [trivial]  fix "from pybaz import *" (patch-41: ddaa@ddaa.net)01:19
SteveATreenaks: thanks for helping out.  can you try once again?01:21
TreenaksSteveA: *click*01:22
TreenaksSteveA: wow, instantly!01:22
SteveAokay, we've worked out what the problem is.01:22
SteveAit isn't fixed properly right now01:23
SteveAbut we can now work on a proper fix01:23
TreenaksSteveA: I also reported this as #2465 btw01:23
SteveAthanks01:23
SteveAcarlos: ping01:30
carlosSteveA, pong01:30
carloskiko-zzz, new language pack with workarounds and .pot files being built...01:50
=== zorglub_ [n=53915de2@wahe.diwi.org] has joined #launchpad
zorglub_ddaa: it apparently failed :)01:58
=== niemeyer [n=niemeyer@200.103.247.46] has joined #launchpad
niemeyerGreetings!02:01
carlosSteveA, stub I have a small problem02:11
carlosSteveA, stub I'm not able to merge latest rocketfuel into hte branch where I have the karma fixes02:11
SteveAwhy is that?02:11
carlosbazaar takes all my laptop memory (1.5GB RAM + 1.5GB SWAP) and dies02:11
SteveAwell, we want to cherrypick it anyway02:12
SteveAso what is your branch?02:12
SteveAso, we want to get the diff against production, ideally02:12
SteveAnot against rocketfuel02:12
carlosSteveA, the problem is that the diff shows changes unrelated that I think are already merged, but I'm not sure...02:12
carlosok02:12
SteveAare the changes isolated?02:12
SteveAcan you list the files that need to be changed?02:13
=== carlos looks to the whole diff and checks...
=== cprov [n=cprov@200-171-140-32.dsl.telesp.net.br] has joined #launchpad
carlosSteveA,  carlos.perello@canonical.com--2004/launchpad--devel--0 is the branch02:14
=== matsubara [n=matsubar@200-171-140-32.dsl.telesp.net.br] has joined #launchpad
=== spacey [n=spacey@flits101-191.flits.rug.nl] has joined #launchpad
=== spacey wants to set his hackergotchi icon in launchpad ^_^
=== SteveA switches to carlos' branch
carlosSteveA,  https://chinstrap.ubuntu.com/~dsilvers/paste/fileKkDk6S.html02:20
carlosSteveA, those are all changes 02:20
SteveAso, if i apply that to production, that's all that's needed?02:20
carlosI think so, yes02:21
SteveAokay.  i'll switch to the production branch, and make a cherrypick branch for this change02:22
SteveAis the code involved in this tested?02:22
carlosI need to add some tests to be sure that if works always but with that change the amount of imports will be reduced for sure02:22
carloss/imports/inserts/02:22
carlosNot fully tested02:22
carlosthat's why it's not yet merged02:22
carlosI wrote it before leaving for holidays02:22
carlosI tested it02:23
carlosand the code works, but I'm not 100% sure if it fix all cases02:23
SteveAwhat kind of object is selection.activesubmission ?02:23
SteveAa dbschema item?02:23
carlosno02:24
=== mpt [n=mpt@200-171-140-32.dsl.telesp.net.br] has joined #launchpad
carlosa POSubmission object02:24
SteveAso, i think it is safer to compare with .id == .id02:24
carlosok02:25
mptGoooooooooooooood morning02:25
SteveAcan selection.activesubmission or selection.publishedsubmission be None ?02:25
carlosmpt, morning!02:25
carlosSteveA, yes02:25
SteveAone or both?02:25
carlosboth02:25
SteveA+    if active == published:02:25
SteveA+        # The translation came from a published file so we don't add karma.02:25
SteveA+        return02:25
SteveA02:25
SteveAso, they can both be None here02:25
carlosoh, both at the same time?02:26
carlosno02:26
SteveAok02:26
carloswell, technically is possible, but I don't think our code should allow that02:26
carloslifeless, ddaa around?02:28
SteveAstub: i'm preparing a cherrypick branch.  running the tests now.02:30
stubSteveA: Tests get run when it is cherry picked so you can skip that if you want02:30
SteveAi'd rather make sure i did it right02:31
ddaacarlos: here02:37
carlosddaa, I'm not able to merge latest rocketfuel into my carlos.perello@canonical.com--2004/launchpad--devel--0 branch02:38
ddaa...02:38
carlosbaz merge dies after my memory is completely used02:38
=== ddaa rolls a cigarette
carlosand baz merge --star-merge gives me 28 conflicts with files I didn't touch02:39
carlosI don't know if it's related with the fact that I remove my revision library yesterday02:39
carlosbecause I ran out of disk space02:40
ddaaI believe the OOM condition might be related to the lack of revlib02:40
ddaayou can library-add rocketfuel, that should help02:41
carloslibrary-add ?02:41
carloshow?02:41
carlosI have never done that before02:41
ddaabaz library-add rocketfuel@canonical.com/launchpad--devel--002:41
ddaaadds a revision to the revision library02:41
ddaawhen given a branch, adds the latest revision02:41
carlosok02:42
carlosdoing it atm...02:42
carlosdone02:42
ddaaif you run out of disk space, it's better to use library-relink02:42
ddaaand remove some old revisions you do not need02:42
carlosI want to do that after moving to breezy02:42
ddaajust keeping the latest revisions of each branch should give you good results now that baz has the backbuilder02:43
sivangrehi all02:43
ddaacarlos: -> #bazaar02:43
SteveAddaa: Hacking faq please!02:43
carlosddaa, ok02:43
=== ddaa obliges
=== goro-afk [n=gorodek@p5083D517.dip.t-dialin.net] has joined #launchpad
KinnisonSteveA: You remember the 'url' thing we discussed earlier?02:47
SteveAyes02:47
KinnisonSteveA: well, BinaryPackageFile has a url property02:47
KinnisonSteveA: and it's listed in IBinaryPackageFile02:47
=== Kinnison is confusticated
=== gneuman [n=gneuman@200-171-140-32.dsl.telesp.net.br] has joined #launchpad
SteveAKinnison: okay, you're right.02:49
SteveAstub: cherrypick mirroring02:49
SteveAKinnison: bogus code in the database class02:52
cprovSteveA: what's exactly wrong ?02:53
SteveAstub: mirrored03:00
SteveAemailed to you the branch id03:00
stubDone03:05
carlosstub, so are you going to reenable the poimport script?03:06
ddaahttps://wiki.launchpad.canonical.com/LaunchpadHackingFAQ#head-7ede78aa7deeb4b4c9e649ad7bf58422279436f603:07
stubcarlos: already done03:08
carlosstub, ok, so 30 minutes to be sure if the performance problem is still there or not....03:09
carlosstub, can I do anything to help you?03:09
stubme? I'm paying GTA3. I don't think you can help from there ;)03:09
carlos;-)03:10
=== Seveas [n=seveas@ksl403-uva-132.wireless.uva.nl] has joined #launchpad
=== carlos -> lunch
=== zyga [n=zyga@2-mi2-1.acn.waw.pl] has joined #launchpad
=== salgado [n=salgado@200-171-140-32.dsl.telesp.net.br] has joined #launchpad
=== terrex [n=terrex@84-122-83-29.onocable.ono.com] has joined #launchpad
dilysMerge to rocketfuel@canonical.com/launchpad--production--1.33: Cherry pick rosetta script karma fix (patch-10: steve.alexander@canonical.com)03:33
ddaa???03:34
ddaaprint >> open(difffile,'w'), diff.encode('utf8')03:34
ddaaUnicodeDecodeError: 'ascii' codec can't decode byte 0xe7 in position 362: ordinal not in range(128)03:34
ddaaanybody got a clue about what I'm doing wrong here???03:35
SteveAwell03:35
SteveAdo you expect to encode arbitrary 8 bit data as utf-8 ? 03:35
SteveAmaybe you want to decode it?03:35
ddaait's UnicodeDecodeError03:35
ddaapysvn gives me utf8 at some places03:35
ddaaI just coded workaround for the problems that cause yesterday, including a test for exactly the condition that the encode('utf8') is meant to catch03:36
SteveAokay03:36
ddaaexcept I get this stupid error that makes no sense from roomba03:36
ddaaI'm giving print a str (it's the output of encode, right?) and it still tells me UnicodeDecodeError...03:37
SteveAaha03:37
SteveAso, the problem is that 'diff' is a str not a unicode03:37
ddaait's a unicode03:37
ddaathat's why I'm encoding it03:37
ddaato make it a str03:38
SteveAare you sure it is a unicode?03:38
ddaaand anyway the error would be UnicodeEncodeError if I was wronge03:38
SteveA>>> 'foo\xe7'.encode('utf-8')03:38
SteveATraceback (most recent call last):03:38
SteveA  File "<stdin>", line 1, in ?03:38
SteveAUnicodeDecodeError: 'ascii' codec can't decode byte 0xe7 in position 3: ordinal not in range(128)03:38
SteveA>>> u'foo\xe7'.encode('utf-8')03:38
SteveA'foo\xc3\xa7'03:38
SteveA>>>03:38
ddaaholy... shit03:38
ddaaPYSVN IS SO BROKEN IT'S NOT EVEN FUNNY03:39
ddaawhy... why???03:39
SteveAhow about a generous sprinkling of assert isinstance(diff, unicode) ?03:40
ddaayes, but why??? What the hell was the rapidsvn guy who wrote that shit was thinking???03:41
SteveAbtw03:41
SteveApython is evil03:41
=== dand [n=dand@gw.datagroup.ro] has joined #launchpad
SteveAin that it allows you to treat an 8 bit string as "yeah, probably ascii"03:41
ddaaSteveA: elaborate?03:41
SteveAthis has caused SO many problems03:41
ddaaYeah, i guess it's a painted-in-a-corner compatibility issue now.03:42
SteveAscrew compatibility.  this issue has cost more03:42
ddaaBut I agree that allowing to treat unicode strings as "yeah maybe a byte stream" is WRONG, WRONG!!!03:42
=== SteveA notes that this is why he isn't BDFL of python
ddaathis whole notion of "ascii string" in python is wrong03:43
=== bradb [n=bradb@modemcable033.209-70-69.mc.videotron.ca] has joined #launchpad
ddaaa string is either a byte stream (str) or a character string (unicode). This ascii shit only serves to confuse matters.03:44
ddaaSteveA: you got to understand that03:44
ddaain some case the diff command will fail _internally_ with UnicodeDecodeError trying to decode non-utf8 data into a unicode object.03:45
ddaaso, assumed it just being stupid, and always returned a unicode...03:45
SteveAit probably doesn't do an explicit conversion03:46
ddaabut now I see it's not being merely stupid, it's being actively antagonising bordering on unusable03:46
SteveAand so, if a string gets through "untouched" it will remain a string03:46
ddaaI imagine... yes03:46
ddaait's concatenating some gettext data there, sometimes03:47
ddaaor something like that03:47
ddaaokay, that's the straw that breaks the camel back.03:47
mptHow do I get the URL of the person logged in?03:47
=== ddaa goes out and nukes the use of svn diff.
=== mpt guesses it involves canonical_url
KinnisonSteveA: formatters for zope03:48
KinnisonSteveA: can you point me at a simple example of a text formatter03:48
=== Kinnison needs to write one
salgadompt, canonical_url(getUtility(ILaunchBag.user))03:48
SteveAKinnison:  i do not know what "formatters for zope" means03:48
SteveAsalgado: brackets wrong03:48
KinnisonSteveA: Well, I think we have something which linkifys bug messages for example03:49
=== Kinnison wants to write something for rendering a string as an 80 column fixed-pitch terminal
SteveAah03:49
mpt... in TAL? :-)03:49
SteveAso a fmt:xxx thing in a page tempalte?03:49
Kinnisonthat's the monkey03:49
=== Keybuk [n=scott@syndicate.netsplit.com] has joined #launchpad
mptNameError: name 'canonical_url' is not defined03:50
SteveAimport it03:50
SteveAfrom canonical.launchpad.webapp03:50
mptThis is TAL03:50
kikothen /fmt:url, mpt?03:51
SteveAof what though?03:51
SteveAwe don't expose the user through tal, do we?03:51
mptlp:person/fmt:url?03:51
mptlet's see03:51
salgadois request/lp:person ?03:51
SteveAah, okay03:51
kikorequest/lp:person03:51
ddaaGuys.03:51
SteveAi need to tidy that up03:51
SteveAwant to get rid of 'lp:...'03:51
kikoyes ddaa 03:51
ddaaThe next person I catch treating a patch or a source file as anything but a byte stream will suffer incredble pain.03:52
ddaakiko: nothing personal, I'm just being angry03:52
Keybukddaa: how else could you treat them?03:53
ddaaKeybuk: e.g. doing operations with it involving a unicode string03:53
ddaawill cause python to turn it into a unicode, sometimes03:53
kikostub, we're getting a bunch of permission denied error in cronscripts03:54
kikocve03:55
kikodistribution03:55
kikoanything you might know about?03:55
asmodaikiko: oi!03:55
carlosstub, how's going?03:55
kikohey asmodai 03:55
asmodaikiko: got an email that he will email you ;)03:55
carloskiko, hi03:55
asmodaikiko: he seems impressed/enthousiastic03:55
SteveAKinnison: i think we already have something like that03:55
stubNo idea. Has anyone been bitching in here?03:56
kikoasmodai, that's so great!03:56
kikostub, I get error mail :)03:56
KinnisonSteveA: where would it be if we did?03:56
SteveAKinnison: fmt:nice_pre03:56
KinnisonSteveA: where can I see the source for that?03:56
SteveA lib/canonical/launchpad/webapp/tales.py03:57
SteveAline 83703:57
asmodaikiko: he cc:'d me I see03:57
KinnisonSteveA: aha, ta03:58
Keybukddaa: the problem I tend to have is unicode strings leaking out of the database03:58
kikostub, any clue what changed permissions there?03:58
kikostub, I could email the errors if you like03:58
ddaaKeybuk: I had this problem at a point with cscvs, I just agressively casted them all to str() early and was done with it.03:58
KinnisonSteveA: so if I have: tal:content="job/logtail"03:59
ddaa(actually, with importd)03:59
KinnisonSteveA: do I want tal:content="fmt:nice_pre/job/logtail" ?03:59
SteveAtal:content="structure job/logtail/fmt:nice_pre"03:59
kikothe opposite, Kinnison 03:59
Keybukddaa: yeah, I do that and I *still* get leaks :-/03:59
stubkiko: Is it recent, or you talking about errors generated during staging rollouts or something?03:59
kikostub, hmmmm. it was tonight (for me) -- maybe..04:00
ddaaKeybuk: debuggers really lack the ability to answer "where does that object come from" sort of questions.04:00
kikostub, I'll forward them04:00
ddaaCould be an interesting thing to hack with PyPy04:01
Keybukyeah, it's one thing that the MS debugging has always done that I miss04:01
Keybuktracks the creation and use of variables04:01
stubI get them. I havn't got any outstanding, so would have deleted them04:01
Keybukso you can inspect a variable and see all the lines of code where it was changed and to what04:01
SteveAyou could hook into variable binding in python04:02
ddaamh... I would not go that far. I would be happy enough with "where was this immutable created" and "where was this attribute last assigned".04:02
SteveAand record rebindings quite easily04:02
SteveAbut that's not the same as tracking an object and what names it has had in what namespaces04:03
kikostub, forwarded, but they were staging-mail04:06
stubkiko: Then ignore them - they were from staging upgrades. Stuff doesn't run well when the db is half setup.04:07
carlosstub, please, could you confirm me that the karma issue is gone?04:07
stubcarlos: I can't confirm it. However, nobody is in here complaining about launchpad timeouts so it might be sorted.04:08
carlosstub, cannot you see the amount of imports?04:08
carloss/importS/inserts/04:08
kikostub, how could we solve this in a better way?04:08
stubNot really.04:09
stubkiko: Solve what?04:09
kikospurious errors being send while upgrades run.04:09
kiko(obviously)04:09
kikos/send/sent04:09
stubkiko: there are several discussions going on here ;)04:09
carlosok04:09
stubkiko: It just involves disabling all the cron jobs before upgrades, but I havn't been game to automate that.04:10
kikoit's late!04:10
kikostub, do all cronjobs import or use some sort of central infrastructure?04:10
kikowe could add a quit-if-locked thing04:10
stubkiko: No. I really want to have a single cron job that runs every 60 seconds that spaws everything else as required - it will make setup much easier.04:11
carlosok, so. Do you need anything from me before I leave for the weekend?04:11
kikoyeah, great idea that would be04:11
carloskiko, stub, SteveA ?04:11
stubWe could hook into steve's 'down for maintenance' file as a quick solution though. Just a matter of engineering.04:11
kikostub, can you mail me a dump of the crontab so I can see how many scripts they are?04:11
kikomusic has a right to children04:16
=== kiko elbows stub
=== stub punches kiko in the face
kikoget some sleep cranky melbourner04:29
kikoand answer my questions04:29
kikostub, also, I want a suggestion on where I should start investigating centralizing database names.04:29
SteveAwhat does "centralizingn database names" mean?04:30
SteveAi can send you a crontab output04:31
kikoyou know about our quagmire -- wanting to use the same database instance for various users.04:31
kikoI set up individual databases but on diskless it's so slow make check takes an hour and often just hangs04:31
SteveAthis is at async?04:31
kikoyes04:31
kikoso I did some investigation of where we hardcoded database names04:32
kikoit's some 40-odd files04:32
SteveAhow about they get them from launchpad.conf?04:32
kikothere are (AFAIK) some 5 database tables04:32
SteveAso, launchpaddev=launchpad-dev etc.04:32
SteveAin launchpad.conf04:32
kikoSteveA, I'm fine with any solution that can forseeably work, yeah04:32
stubFor normal code, they should all pull the database name from the config file. I'd start with that. Tests will be more complex (since they need at least a template and a scratch db name). The database build scripts should pull the names from the same location 04:33
kikoI meant database names.04:33
stubI thought I sent you the crontab?04:33
kikono04:33
kikostub, okay, I'll start work on that -- any suggestions on how the Makefile should obtain the names, or should I factor that out?04:34
stubpython -c 'import config; print config.dbname' might be the quickest (and ugliest) approach. Extra points for rewriting the makefile into a Python script that doesn't suck.04:36
kikookay04:36
SteveAis there an "ant" for python04:37
SteveAmaybe part of phillip eby's stuff04:38
stubthere is, but I don't see why we would bother.04:38
stub(pyant I believe).04:38
kikoSteveA, just fixed the fucking floating tabs04:38
kikoI had it fixed yesterday but was conflicted to death04:38
SteveAyay04:39
SteveAwhat's the fix?04:39
SteveAcss magic04:39
kikounfucking plone.css stupidity04:39
kikoby adding hacks to our css04:39
kikoit does ul { line-height: 1.5em }04:39
kikoso I had to do04:39
kikoline-height: inherit; max-height: 1.4em; because of IE04:40
mptkiko: IE doesn't do max-height either, you'll need line-height: 1.4em instead04:41
asmodaiMakes you wonder if some people test on non-mozilla browsers in the first place04:42
Kinnisonis pqm wedged? PID 31103 seems the obvious candidate04:42
=== camilotelles [n=Camilo@200.128.80.250] has joined #launchpad
mptasmodai: There's no Windows here. Normally I'd test on Konqueror, but it's not installed here either04:43
=== mpt bugs kiko to install it
salgadompt, you can just type 'scooby' in a terminal and you'll get windows. but please don't tell anybody we have windows here. :P04:44
bradbmpt: Just so you know: I'm doing a Malone feedback-a-thon patch right now. The goal is pretty much to not be able to do something in Malone without Malone telling you what you did (and who got an email about it.)04:44
=== mvo [n=egon@ip181.135.1511I-CUD12K-01.ish.de] has joined #launchpad
asmodaimpt: You do test with Opera though? :)04:45
bradbmpt: Or, of course, what you did /wrong/, if applicable04:45
mptasmodai: Opera's not even on the radar at the moment, but that might need to change if their new-found ad-free-ness makes them more popular on Free OSes04:46
=== asmodai goes to add more todo list items in trac as tickets
=== mpt tried Opera for Mac on Wednesday, and it was horribly awful as usual
asmodaimmm04:46
bradblimi loves Opera, last I checked04:46
asmodaiguess it is more of a blessing on Windows then ;)04:46
bradbwhich means our CSS should work pretty well in Opera04:47
mptbradb: To see how untrue that is, try removing the plone.css line from main-template.pt, and Shift+reloading04:47
mptplone.css is currently (1) providing the portlet borders, and (2) ****ing up the tabs04:48
mptand that's about all.04:48
bradbright, i see04:49
bradbthe tabs line up nicely too :)04:49
=== bradb wonders why we even have a plone.css then
mpt:-)04:50
asmodaito point fingers? :)04:50
bradbto piss users off slightly more, it would seem04:51
bradbmpt: how much effort is it to get rid of plone.css?04:52
kikompt, I'll try doing it today04:54
kikobradb, it's two lines of main-template, I almost did it yesterday04:54
kikobecause we haven't formed enough of a mutiny yet!04:55
mptThat's right04:55
mptA spec with an array of ImportantPersonApproved in its Status: header04:55
bradbkiko: two lines of main-template? I meant how much effort also so that it doesn't break the current look-and-feel.04:55
bradbsounds like it's just a few classes to bring over, in any case04:56
kikobradb, about 10 minutes of my time04:56
bradbawesome04:56
mptI'd like to do it more carefully than that, though04:56
mptbecause a lot of launchpad.css is overriding bits of plone.css04:56
kikoKinnison, you really need should start using variables to shorten and simplify your code04:56
kikoit's very difficult to read04:56
mptso I'd like concatenate the files, then nuke the sections that cancel each other out04:57
kiko            overrides.setdefault(distrorelease, {})04:57
kiko            overrides[distrorelease] .setdefault(component, {})04:57
kiko            overrides[distrorelease] [component] .setdefault('src', [] )04:57
kiko            overrides[distrorelease] [component] ['src'] .append( (sourcepackagename,section) )04:57
kiko            overrides.setdefault(distrorelease, {})04:57
kiko            overrides[distrorelease] .setdefault(component, {})04:57
kiko            overrides[distrorelease] [component] .setdefault('bin', [] )04:57
kiko            overrides[distrorelease] [component] ['bin'] .append( (binarypackagename,priority,section) )04:57
kikoand using setdefault() is just.. ugh04:57
kikosomebody remind me why python even has setdefault?04:57
Kinnisonbecause it's useful04:57
Kinnisonand neat04:57
Kinnisonand tidy04:57
kiko            filelist.setdefault(distrorelease, {})04:57
kiko            filelist[distrorelease] .setdefault(component,{})04:57
kiko            filelist[distrorelease] [component] .setdefault(architecturetag,[] )04:57
kiko            filelist[distrorelease] [component] [architecturetag] .append(ondiskname)                   04:57
kikodude, this is anything but neat and tidy04:58
=== terrex [n=terrex@84-122-83-29.onocable.ono.com] has joined #launchpad
stubIts neater than the alternative using if: then: or exception handling, and is quite a bit faster (despite all the spurious empty list and dictionary creations)04:59
SteveAsetdefault is good04:59
bradbdumb question: where do I find the error log for staging, and for which I have the perms to view it?04:59
SteveAand everyone should learn what it means04:59
SteveAKinnison: you should look at using a descriptive variable name for filelist[distrorelease]  and filelist[distrorelease] [component] 05:00
KinnisonOkay, I'll put that on my gardening page05:00
Kinnisondone05:01
KinnisonSteveA: I'm trying to learn how tal/tales/metal work05:03
bradbguys, I've found what may be a critical bug (500 on the +assignedbugs screen). where do I find the error log (in a place that I have perms to view it) for staging so that I can fix this problem before it hits prod?05:03
KinnisonSteveA: We seem to use @@blahfoo in our tales expressions05:03
KinnisonSteveA: what does the @@ mean?05:03
SteveAit means "force the lookup to be in the 'views' namespace, and not any other kind of traversal"05:04
SteveAthink of it as two eyes, if you like05:04
Kinnisonis that a launchpad specific thing, a zope thing, or a generic tales thing?05:04
bradbstub: Where do I find the error log for staging (in a place that I have perms to view it?)05:05
stubOn /errors ?05:05
bradbAlready tried that. 403.05:05
stubThats odd05:05
=== stub wonders if SteveA got around to playing with the errors screen
SteveAi wrote up a spec05:06
SteveAgot other things to do first05:06
bradbstub: In the meantime, how do I get access to the error log for staging?05:07
stubbradb: chinstrap:~stub/staging_logs05:08
bradbthanks, /me looks05:08
bradbstub: what's the query timeout on staging? it seems like launchpad is commiting suicide on staging because of it.05:10
bradbsee also, committing05:11
stubbradb: That it to stop pages locking up launchpad and making nothing work. If you hit the timeout, the page needs fixing.05:13
bradbstub: These pages worked just fine in the past. They take a bit longer, but nothing that kills the entire system.05:13
bradbstub: Can the timeout be set to something more practical, while still making sure Rosetta doesn't kill LP?05:14
stubbradb: they arn't working any more then. If a page takes a couple of seconds to render, it is dangerous to the system.05:14
stubbradb: On production it is set to 12 seconds, which is waaay too much.05:14
BjornTbradb: i'd suggest to remove "Bugs reported on software you maintain", it's kind of useless anyway.05:15
kikostub, I think a better strategy may be to set to 30s and drop 5s a week05:15
bradbstub: This doesn't make sense to me. The timeout is set so low that it's killing pages that worked perfectly fine in the past. At the very least, shouldn't we optimize these pages *before* slitting their throat?05:15
bradbBjornT: so would i05:15
kikostub, and keep staging 5s under production05:15
kikothat way people have time to fix pages05:16
bradbBjornT: i would also suggest removing that "bugs with common interest" uselessness, but kiko wants to keep it05:16
kikothe current situation is going to kill my QA effort05:16
kikowe're getting bugs filed left and right on killed queries :-(05:16
mptbradb: that should be cached05:16
SteveAkiko: do you think the error page should say "this was a query that ran too slow" ?05:16
kikobradb, hey, do what you have to do -- I don't think it's useless *at all*, but if it kills the page, disable it05:16
stubkiko: 12 seconds is already rediculous.05:17
kikoSteveA, anything that stops people filing bugs, we have some 15 already05:17
bradbkiko: more accurately, i just don't think that it belongs under +assignedbugs05:17
SteveAkiko: do you think it will help?05:17
SteveAwe could have one bug05:17
SteveAand link the page to that bug05:17
kikostub, I don't disagree, but it's no use throwing out baby and bathwater05:17
stubkiko: If people are still reporting bugs, I doubt the pages will render in 30 seconds either.05:17
SteveAso people can add comments to it if they want05:17
SteveAbut keep it all in the one place05:17
kikoSteveA, the issue is that the bugs on individual queries/locations are actually useful05:18
kikoI think the error page should say "Query took too long"05:18
SteveAok05:18
SteveAi'll make it so05:18
kikothanks a million05:18
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: Fix a missed table rename from long ago which was breaking binarypackagefile.url. Celso is putting a test into his soyuzfiles test suite for this. in the meantime, r=stevea (patch-2474: daniel.silverstone@canonical.com)05:18
SteveAi'm also going to make tracebacks appear in production for the admin team05:18
kikostub, I don't know, translations used to work, now..05:18
kikoSteveA, rock!05:18
stubkiko: They used to have fewer entries in the tables too. Now there are tables with over 15,000,000 rows in them and there is just stuff we cannot do interactively no matter how many indexes, how much hardware we throw at it and how much people jump up and down.05:20
bradbSo, what are we going to raise the timeouts too? I think it would be useful to do what kiko was saying. Set a pretty high limit at first, gradually dropping it every week, giving us time to examine linkchecker reports and time to do something about it.05:20
bradbs/too/to/05:20
=== hub is now known as hubW
kiko+1 to bradb's request05:21
kikoSteveA, stub: can you consider what we're asking for? I can't have launchpad dying under me as I'm triaging or..05:21
stub12 seconds is already rediculously high, so I'm quite happy to reduce that to pretty high05:21
kikoincrease you mean? :)05:22
stubpretty high < rediculously high.05:22
bradbstub: "ridiculously high" would be high enough to let Rosetta keep killing LP05:22
stubbradb: It might well be05:23
stubbradb: The real nasty pages took over 6 minutes to render05:23
bradbYes, and we've never had that kind of problem in Malone. I'm just suggesting that we set it high enough to let Malone keep working (even if, in some cases, that seems retardedly slow from a DBA perspective) and let us improve it before we tighten the noose too much.05:24
stubbradb: What pages does malone have that are hitting the 12 second limiton production?05:24
bradbi dunno. i was talking about staging.05:25
bradbpeople were reporting problems with bug searching suddenly erroring out on prod though, which, seen from the user perspective, is *really* bad when it can so easily be avoided.05:25
stubbradb: not from a dba perspective, from a web developer and user perspecive. More than a few seconds, and people hit reload. All four threads lock up, queues start happening and launchpad is locked solid.05:25
stubbradb: Was that before or after steve increased the timeout to 12 seconds?05:26
bradbafter05:26
bradber, sorry05:26
bradbafter the timeout was set, but i don't know when it was increased to 12s05:26
bradbi believe it was yesterday that users were complaining about this05:26
stubIt was originally set to 4 seconds (about 24 hours ago), and steve increased it to 12 seconds over the next 12 hours or so05:27
bradbstub: just to compare, what is it on staging?05:28
stubI can set staging to whatever will help people debug their code the best. I'd assumed a lower limit would be good for that.05:28
bradbdamn, i just got an error on searching05:28
stub4 seconds, or possibly 2.05:28
bradbon prod, searching ubuntu bugs05:28
stub2 seconds05:29
bradbhttps://launchpad.net/distros/ubuntu/+bugs, I searched for "firefox". i got an error.05:29
stubjust returned in < 2 seconds for me. So that page is going slow because other processes or threads are taking too long. Increasing the timeout could make it worse.05:30
bradbWhy not try it and see what happens?05:31
bradbwe can't get /much/ worse that sporadic errors that make this much --> <-- sense to a user :)05:32
stubbecause it is already 1:30 am saturday morning and steve won't be around much longer either to reset it if it screws up05:32
stubbefore, launchpad was totally unusable so it *can* get much, much worse. We cherry picked the updates and spent the time switching this on for a reason.05:32
bradbstub: you say "launchpad", but we know what you really mean :)05:33
bradbhint, it wasn't Malone05:33
stubno, launchpad. The entire thing locks up. everything is affected.05:33
bradbsure, but I'm pretty sure that's not due to Malone queries, even the slowest ones :)05:34
kikothere's no such thing as "rosetta and not malone"05:34
kikoyou're all in the same boat together05:34
kikoanyway05:35
kikostub, could it be that the vacuum analyzes running do some slowing down of production as well?05:35
bradbkiko: the distinction is important in diagnosing the speed bottlenecks, i think05:35
kikoI'm seeing them a lot in the cron output05:35
stubkiko: that is another database being vacuumed.05:35
kikostub, and the instance copes fine with multiple vacuums in terms of performance?05:36
stubit is fine.05:37
stubqueries are quick - there isn't a performance issue with the db.05:37
stubjust some pages are issuing hundreds to render a single page (such as some of the malone bug pages IIRC!), and some queries are blocking due to other processes locking resources for too long.05:40
bradbSteveA: I've got two pages: A and B. A presents information about an object. From A, you click on the link to page B to change something about that object. When you submit, the change is made, and you're taken back to page A with a message like "The following fields were updated successfully: foo, bar, baz." Do we have a standard way of displaying feedback messages in this pattern, or should B post to A, and let A do the processing05:46
=== cprov lunch
=== dikrib [n=dikrib@port5.ds1-esp.adsl.cybercity.dk] has joined #launchpad
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: remove time dependence from some database tests [r=spiv]  (patch-2475: james.henstridge@canonical.com)05:51
=== bradb & # lunch
=== matsubara is now known as matsubara-lunch
kiko        for translator in self.context.translators:06:16
kiko            return True06:16
kikosomebody06:16
kikoplease06:16
kikoTELL ME WHY?06:16
ddaa*giggle*06:16
ddaathe answer has to be:06:17
ddaaBECAUSE!06:17
kikogod06:17
ddaaquick, annotate!06:17
=== kiko scratches head
kikoquick? :)06:17
ddaawell, you know what I meant...06:18
kiko        """We need to have this to tell us if there are any translators."""06:18
kikothat's the docstring06:18
kikoI love docstrings06:18
SteveAobviously it should be 'yield True' ;-)06:18
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: remove time dependence from some database tests [r=spiv]  (patch-2476)06:19
ddaabtw06:19
ddaathat sholud be followed by06:19
ddaaelse:06:19
ddaa    return False06:19
jordikiko: hey man06:19
jordiI'll need your help in a min.06:19
ddaaseen that way, it almost makes sense in some perverse way06:19
sivanghey jordi , what's up? 06:21
SteveAddaa: else: doesn't make sense for an break doesn't make sense06:21
SteveAddaa: else: doesn't make sense for an 'if' without a 'break'06:21
ddaaI have to agree.06:21
ddaaBut I think it makes sense for a 'repeate' with a 'return'.06:22
kikoSteveA, but nothing in that code made sense anyway :)06:22
ddaa(hint: reread yourself)06:22
ddaaSteveA: can I quote you on that?06:22
kikono06:24
kikohe meant06:24
kikoelse: doesn't make sense for a 'for' without a 'break'06:24
kikoyou can quote me on that06:24
SteveAindeed i did06:24
kikoof course I'm eminently less quotable than anybody here06:24
kikobut I mean well06:24
jordisivang: hey06:25
jordikiko: team ubuntu-l10n-tl to ubuntu-translators06:25
kikopyflakes doesn't understand decorators06:25
kikowelcome to hell06:25
kiko(PWEI)06:25
kikome looks06:26
SteveAhttp://localhost:8086/products/firefox/+bug/606:28
SteveAtell me06:28
SteveAwhere should menu items for that page go?06:28
SteveAthis is replacing bug-portlet-actions06:29
SteveAso i guess in browser/bug.py06:29
SteveABjornT: opinion?06:29
jordikiko?06:31
jordiSteveA: are you guys able to add plural forms?06:31
SteveAi cannot06:31
SteveAmail the launchpad list06:31
SteveAi think stu can06:31
SteveAhe'll read it there, probably tomorrow06:31
jordik06:32
kikojordi, what do you mean by "add plural forms"06:33
jordihttps://launchpad.net/products/gnomebaker/+series/main/+pots/gnomebaker/tl/+translate06:33
kikowhat is tl, jordi?06:33
kikotagalog06:33
kikojordi, done06:34
jordioops, just sent an email, I'll reply so stu doeesn't do anything06:35
jordikiko: team stuff done too?06:35
jordiok06:35
jordidoes the plural forms thing take  effect immediatly?06:36
kikojordi, team stuff done06:36
kikojordi, how many plural forms?06:37
kikowhat expression?06:37
jordiPlural-Forms is nplurals=2; plural=n>1;06:37
kikookay06:38
kikojordi, can you verify both requests are ok?06:38
=== terrex [n=terrex@84-122-83-29.onocable.ono.com] has joined #launchpad
jordiok for the teams, and rosetta doesn't barf anymore about pluiral forms06:39
jordiso I guess it's ok06:39
SteveApleurisy ?06:39
kikobradb, ping?06:39
jordilp is slow lately06:40
kikoyeah. no clue why06:40
jordidamn :/06:40
niemeyerIsn't it because there are lots of new users?06:40
kikoah, shipit?06:41
SteveAyeah\06:41
SteveAwe could put shipit on its own app server, but i think most of the contention is with the database 06:41
SteveAand its locking06:41
kikobut shipit is only simple requests06:42
kikoassignedbugs doesn't run /at all/ on staging06:42
kikoSteveA: please up the time to at least 20s06:42
kikowe need some time to fix these issues06:43
=== kiko cries
jordiour release ended today, more or less.06:44
jordiwe had a few very last minute hickups.06:44
jordilike our drupal eating our "download" node.06:44
jordikiko: uh, to the gnomebaker template? I am interested in the global one. gnomebaker was just an example.06:45
jordianywy. They can translate gnomebaker until tomorrow.06:45
kikojordi, there is no global template -- I think stub needs to twiddle the language06:45
jordiyes, it's something in the database06:45
jordiis he the only one with db access for this kind of stuff?06:46
jordithere shouldbe ui for you guys to do it.06:46
kikoindeed06:47
=== matsubara-lunch is now known as matsubara
jordihmm06:49
jordiI can't find that simple menu editor for gnome in launchpad.06:49
jordiisn't it part of ubuntu?06:49
jordiif something is part of breezy, it should ahve a product already in rosetta, right?06:52
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: [trivial]  Fix the damned floating tabs, and display status for bugwatches in the bugwatch-index (patch-2477: christian.reis@canonical.com)06:53
=== Seveas [n=seveas@seveas.demon.nl] has joined #launchpad
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: [trivial]  small shuffle on arch-indep packages for gina (patch-2478: daniel.silverstone@canonical.com)07:24
=== Treenaks [n=martijn@messy.foodfight.org] has left #launchpad []
=== terrex [n=terrex@84-122-83-29.onocable.ono.com] has joined #launchpad
=== bloodthirsty [i=bloodthi@218.208.247.243] has joined #launchpad
bloodthirstyhello07:49
bloodthirstyis anybody here?07:49
kikoNO07:52
=== jmarki [n=jmarki@nusnet-201-39.dynip.nus.edu.sg] has joined #launchpad
kikoKinnison, could you make lint before committing code? it will help catch lots of little style issues before review, I think you'll appreciate it07:54
kikoI'm fixing it up to warn less of non-issues07:54
=== camilotelles [n=Camilo@200.128.80.250] has joined #launchpad
Kinnisonkiko: okay, I'll try to remember that08:00
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: [trivial]  delintify and add XXXs galore to archivepublishing bits (patch-2479: christian.reis@canonical.com)08:00
kikothanks08:01
kikoI added some XXXs there for you08:01
KinnisonRight08:01
kikoKinnison, and btw:08:03
kikobuilddmaster.py08:03
kikostartBuild()08:03
kikonot tested08:03
kikonot used08:03
kiko    def startBuild(self, builders, builder, queueItem, pocket):08:03
kiko        """Find the list of files and give them to the builder."""08:03
kiko        archrelease = queueitem.build.distroarchrelease08:03
kikotypo in first line08:03
kikocprov, make note, I'll fix but XXX08:03
SteveAhey gneuman 08:05
SteveAarond?08:05
SteveAum, around?08:05
gneumanSteveA, 08:06
SteveAhi08:06
gneumanme08:06
SteveAyou08:06
gneuman=] 08:06
SteveAso, i think i found a bug on a page, but i'm in the middle of menus work08:06
SteveAso, i don't want to track it down right now08:06
SteveAcan you look into it?08:06
gneumantell me about it08:06
gneumansure08:06
SteveAokay, here's what i did08:06
SteveArun launchpad with sample data, as normal08:06
SteveAhttp://localhost:8086/distros/ubuntu/warty/+sources/mozilla-firefox/+bug/508:07
SteveAgo there08:07
gneumanam i suppsoe to be doing it while u talk?08:07
SteveAthere's a box on the bottom right08:07
SteveAabout "links to remote bug trackers"08:07
SteveAclick the +add link08:07
SteveAget a 40408:07
gneumanok08:08
gneumanhold on08:08
Kinnisonkiko: If you're going to touch the buildmaster I'd really rather you didn't08:08
Kinnisonkiko: I'm making notes about the buildmaster ready for a cleanup08:08
kikoKinnison, too late now :)08:08
Kinnisonokay, I'll try and not use line numbers :-)08:08
kikowriting clean code the first time is a better approach to quality, anyway :)08:08
kikonice! much better08:09
gneumanSteveA, 08:10
gneumani didnt get the 40408:10
gneumanlet me try a lilttel more08:11
gneumanits actually adding bug watchers08:12
SteveAokay08:12
SteveAthat's good, then08:12
gneuman=] 08:12
SteveAmaybe it is just something on my branch08:12
kikoSteveA, what's the URI that is a 404?08:12
=== Kinnison heads out for the night
gneumankiko, http://localhost:8086/distros/ubuntu/warty/+sources/mozilla-firefox/+bug/508:13
SteveAhttp://localhost:8086/distros/ubuntu/warty/+sources/mozilla-firefox/+bug/5/watches/+new08:13
Kinnisonciao all08:13
SteveAbye08:13
kikogneuman, is that URI a 404?08:13
kikosee ya kinni08:13
gneumanhttp://localhost:8086/distros/ubuntu/warty/+sources/mozilla-firefox/+bug/5/+addwatch08:14
gneumanworks08:14
gneumanmaybe SteveA is using a diferene link08:14
gneumanthis is a addwatch08:14
gneumannot watches new08:14
SteveAstrange08:15
SteveAokay, i'll find out when i come to merge this into PQM08:15
SteveAsee the diff08:15
gneumanok08:15
SteveAthanks gneuman 08:15
gneumanno prob08:15
kikoSteveA, have you merged in bradb's latest changes already?08:15
SteveAthink so08:15
SteveAi did a merge just 1 hour ago08:15
kikoweird as weird can be then08:15
kikomaybe you baz smashed that change?08:16
SteveAdunno08:16
SteveAi'll see what the diff against RF gives when it is time to get a review08:16
kikoSteveA, it's broken, gneuman has an old tree08:17
kikogneuman, you need to baz merge rocketfuel@canonical.com/launchpad--devel--008:17
kikothen try again08:17
kikomatsubara, same with you08:17
SteveAokay08:17
gneumanok08:18
SteveAso, this could be a regression08:18
BjornTSteveA: did you click on the link in the action menu, or the bug watch portlet. the add link in the bug watch portlet seems to be broken in my tree, but not in the actions portlet08:19
mdkeerm08:19
mdkesilly question08:19
mdkehow do I mark a bug as fixed in malone?08:20
kikomdke, you mark the task as fixed08:20
kikoso click on the link in the task table08:20
mdkei see it08:20
mdkethanks08:20
SteveABjornT: that's what i'm seeing08:20
kikome too08:20
mdkekiko, what about if I am not the assignee? it can't be marked as fixed/notabug etc?08:21
mdkekiko, e.g. #2270, i marked the task which was assigned to me as fixed, but the original task (wrongly assigned to rosetta) is not a bug and I can't mark it as such08:22
=== SteveA goes for a short workrave
kikomdke, you can't fix that, but any launchpad developer can08:24
kikoone moment08:24
=== BjornT checks the other portlets for incorrect links and creates branch to fix it
mdkekiko, can the bug reported fix that?08:24
kikomdke, what bug?08:25
mdkesorry08:27
mdkekiko, s/reported/reporter08:27
kikoI'm not sure. BjornT or bradb?08:28
kikomdke, at any rate, I've fixed that bug, thanks for letting me know :)08:29
mdkekiko, no problem, thanks. But I am genuinely interested in whether a bug reporter can reject their own bug, do you know the answer?08:30
mdkeoh sorry08:30
mdkei missed your response08:30
kikoI'm not entirely sure.08:31
kikompt, why are you worried about performance of string replacement?08:31
gneumanmpt isnt here08:33
kikohmmm, right. I just got mail from him though08:33
mdkehis away message is "classes"08:35
kikomdke, apparently you can, right?08:46
mdkekiko, i haven't tried yet08:47
mdkei wasn't the reporter of that bug08:47
kikoah08:47
=== bradb returns
SteveAgneuman: http://localhost:8086/malone/cve/  <-- needs a spelling check08:54
bradbmdke: The bug reporter can't edit the bug status (at least, not solely by virtue of being the reporter of the bug.) This sucks.08:55
bradbkiko: re: assignedbugs, yeah, i know :/08:57
mdkebradb, yeah that sucks a bit08:57
mdkeis there a bug open on that?08:58
bradbkiko: that's why i'm pleaded earlier for a semblance of a plan before lp commits suicide08:58
kikoI know08:59
bradbmdke: https://launchpad.net/malone/bugs/1156 seems similar08:59
bradbSteveA: did you see my question earlier re: passing feedback messages between views/urls/pages?09:01
bradbSteveA: btw, yes, in case somebody didn't already note it, the add watch link is incorrect in the watches portlet09:05
bradbkiko: is that what you fixed? (the add watch link in the watches portlet?)09:06
kikobradb, nope, bjorn was looking at it, but..09:08
bradbi'll fix it here09:08
kikobradb, you can leave the easier things for gneuman and matsubara you know :)09:09
kikosalgado-lunch?09:09
bradbit was a one second fix to commit as part of the feedback-a-thon branch :P09:09
bradball i need to figure out now is a way to pass messages between views that doesn't suck09:10
SteveAbradb: look at the spec.  if the spec doesn't meet your needs, add a question at the end.09:10
bradbwhich spec?09:10
bradbright, i see it09:11
=== bradb reads
mptkiko: Only worried about the effect of doing fancy processing for ~10 menu items and ~1 page title per page09:19
kikompt, does it involve linear regression or calculation of pi to the Nth root?09:19
SteveAmpt: i've done almost all the menus up to and including m..09:20
mptSteveA, you speed demon09:20
SteveAi have some questions though09:20
=== mpt is still mired in support tracker
=== GnuKemist [n=GKemist@cpe-69-206-241-40.nj.res.rr.com] has joined #launchpad
bradbSteveA: Any idea what the status of the BNM implementation is?09:32
SteveAis it tracked in launchpad?09:33
SteveAif not, it should be09:33
=== terrex [n=terrex@84-122-83-29.onocable.ono.com] has joined #launchpad
bradbSteveA: ah yes, it is. https://launchpad.net/products/launchpad/+spec/browser-notification-messages makes me want to die.09:37
bradbbut, good on stub for putting it in there. using the spec tracker will help us improve its UI.09:37
=== bradb files some spec UI bugs
=== nkour [n=nkour@ppp42-adsl-103.ath.forthnet.gr] has joined #launchpad
nkourjordi, ping09:44
gneumanSteveA, going to see that09:49
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: [trivial]  increase staging page timeout to 8 seconds (patch-2480: stuart.bishop@canonical.com)09:49
kikowooo stub09:49
nkourjordi,  I updated italina and it is 100% the file, but rosetta now 10 hours still says 0% https://launchpad.net/products/gajim/+series/0.8/+pots/gajim09:49
SteveAgneuman, matsubara: hiya!  i have found some code that needs fixing.  up for it?09:51
nkourkiko, ?09:51
nkourkiko, can u fix it09:51
gneumansure we are09:51
SteveAokay, great09:51
SteveAso, the first thing is, on a person's own page, there are facilities to add an 'emblem' and a 'hackergotchi'09:52
SteveAthese facilities aren't tested or documented, but i was looking at the pages as part of the menus work i'm doing, and it seems pretty clear that a person is meant to be able to add their own hackergotchi.09:52
SteveAunfortunately, the permissions prevent this at present09:52
bradbkiko: assignedbugs works now! :)09:52
gneumanso we have to change permitions?09:53
SteveAplease look into this, make it so that people can add their own hackergotchi, and prove it with a pagetest09:53
GnuKemistexcuse me...  I can validate that too...  tried it and was stuck with permission msg09:53
gneumanok, kiko will guide us09:53
SteveAmpt: do you think the root +login page should, on successful login, go to that person's own page?09:54
SteveAGnuKemist: thanks09:54
=== mdke_ [n=matt@81-178-228-227.dsl.pipex.com] has joined #launchpad
bradbSteveA: is there not meant to be a workflow to adding a hackergotchi, to prevent pr0n spamming and such?09:54
GnuKemistSteveA, np =)09:54
bradbSteveA: i.e. a workflow that requires some review team to approve hackergotchis (sp?)09:55
=== pablof [n=ubuntu@200.128.80.250] has joined #launchpad
=== claude [n=claude@139.116.203.62.cust.bluewin.ch] has joined #launchpad
pablofhow create new project in launcpad ? i'm not find out a link09:55
=== JanC [n=janc@lugwv/member/JanC] has joined #launchpad
SteveAbradb: dunno09:55
SteveAbradb: the entire feature isn't documented09:55
SteveAbradb: https://launchpad.net/malone/bugs/2501/  <-- add your concern here09:56
mptSteveA: No, but I do think the front page should be a bit more current-person-specific09:57
SteveAwell, it doesn't even go back to the front page at present09:57
SteveAthat can be fixed09:57
mptI think that bug was reported09:58
SteveAgneuman, matsubara: also, check carefully the spelling on those pages.  i noticed at least one typo.09:59
GnuKemistSteveA, one thing I noticed... after you log in, should you have a Profile link somewhere?10:00
SteveAyou can click on your own name at the top right.10:02
SteveAis that what you mean?10:02
GnuKemistyup... but I thought that "profile" would be more clear10:02
=== pablof [n=ubuntu@200.128.80.250] has left #launchpad []
GnuKemistand a link to browse the people list10:03
SteveAmpt: can we have a title on that link?10:03
GnuKemistI could only do it by clicking on the people link above... but don't think it to be intuitive for the regular user10:03
GnuKemistjust my oppinion off course10:03
SteveAhttps://launchpad.net/  <--- there's a link to "people and teams", second box down, LHS10:04
GnuKemistsaw it10:04
GnuKemistsorry10:04
SteveAis that what you had in mind ?10:05
GnuKemistyes...  it wasn't on my field of vision10:05
GnuKemist;)10:05
GnuKemistI was looking for it up abopve10:05
GnuKemistabove10:05
bradbSteveA, mpt: Is there anything I can be doing right now to help the Malone menus implementation along? I'm not really clear what state menus are in, and how much work I'll have to do for Malone menus to be considered implemented.10:06
GnuKemistupper right hand corner10:06
SteveAbradb: i've converted all malone actions portlets to menus on a branch10:06
bradbSteveA: cool. when do you expect to land that?10:07
SteveAvery soon10:07
bradbgreat, thanks10:07
=== goro-afk is now known as GoRoDeK
mptSteveA: As a way of saying "hey, this is your profile page", I think adding the person icon to the left of the existing name link would work10:09
SteveAcool10:10
=== mpt sighs at the ninja-star person icon
SteveAthe ninja-star person sighs back, and looks doe-eyed at mpt10:11
mptooh, requited!10:11
SteveAbradb: ping10:22
bradbSteveA: pong10:22
SteveAi just mailed you a diff10:22
SteveAthere's some stuff in there that is marked XXX10:23
SteveAabout a method of a view class that should be made into a method on IBug10:23
SteveAto avoid duplicated or poorly factored code10:23
SteveAit is about getting the subscription for a person10:23
SteveAso, it should be something like IBug.subscriptionForPerson(person)10:23
SteveAif you would make such a method, and refactor existing RF code to use it, that would speed up the landing of the rest of it10:24
bradbthat sounds like an unneeded method10:27
bradbIBug already has isSubscribed. i can't see what the use case is for getting the actual subscription row.10:28
SteveAvarious views need it10:29
SteveAso, there's code in a couple of places that loops over subscriptions looking for one that matches10:29
SteveAread the diff10:29
SteveAin my branch, i factored the code out into a function at the module level of a view module10:30
SteveAbut it needs to become a method on IBug 10:30
bradbyup, I read the diff. looking only at the code, it's still not clear to me why that method is needed for anything.10:31
SteveAit is needed in both a menu, and a view10:31
=== bradb looks to see how it's used, once he unbreaks his branch, destroyed whilst an undo ran out of disk space
bradbSteveA: what magic can you do with that method that you don't do with IBug.isSubscribed?10:32
bradbs/don't/can't/10:32
SteveA    @property10:35
SteveA    def subscription(self):10:35
SteveA        """Return the current user's IBugSubscription.10:35
SteveA        If the user is not subscribed to this bug, return None.10:35
SteveA        XXX: refactor into method on IBug.10:35
SteveA        """10:35
SteveA        user = getUtility(ILaunchBag).user10:35
SteveA        if user is None:10:35
SteveA            return None10:35
SteveA        for subscription in self.context.subscriptions:10:35
SteveA            if subscription.person.id == user.id:10:35
SteveA                return subscription10:35
SteveA        return None10:35
SteveA10:35
SteveAfirst of all, that should be a method on IBug10:35
SteveAit is not good having that code in the view.10:35
bradbi think that method can probably be completely removed10:36
bradbunless we have a use case for why you need to get the IBugSubscription of a person10:36
SteveA?10:36
SteveAit is used by a template10:36
bradbit's crystal clear to me that there is view code using that, but not why that view code is needed at all, given that there's IBug.isSubscribed.10:37
SteveAand in a menu, i need to know whether someone is subscribed or not10:37
bradbIBug.isSubscribed.10:37
SteveAokay10:38
SteveAso it is only ever used in tal:condition10:38
SteveAso, i'll refactor these to use IBug.isSubscribed onthe branch.10:39
SteveAta10:39
bradbnp10:39
=== GnuKemist [n=GKemist@cpe-69-206-241-40.nj.res.rr.com] has left #launchpad ["Leaving"]
=== SteveA goes home
sivangbye SteveA 10:59
=== jinty [n=jinty@205.134.224.215] has left #launchpad ["Leaving"]
=== terrex [n=terrex@84-122-83-29.onocable.ono.com] has joined #launchpad
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: [trivial]  Lint fixes all over the tree. Improve lint script to reduce clutter, and paved the way for a lintmerge. (patch-2481: christian.reis@canonical.com)11:56
kikoYES!11:58
=== bradb & # out

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!