/srv/irclogs.ubuntu.com/2005/10/22/#launchpad.txt

=== Nafallo_away is now known as Nafallo
=== mattl_ [n=mattl@84-51-154-191.mattle084.adsl.metronet.co.uk] has joined #launchpad
sabdflsivang: register the spec against the product or distro that is relevant, then assign them all to the ubz agenda01:34
sivangsabdfl: ok, thx.01:35
sabdflnp. i will write up the full process and post to the lists this week so that we get as many people drafting specs before UBZ as possible01:39
sivangcool01:40
sivangsabdfl: I've filed a wishlist bug for the spec tracker,01:40
sivangsabdfl: that it should also allow grouping acording to tracks from the main sprint overview 01:40
=== interalia [n=interali@adsl-60-232.swiftdsl.com.au] has joined #launchpad
sivangsabdfl: I already have a handful of specs to register in it.01:41
sabdflsivang: there aren't tracks01:41
sabdflthe specs should be grouped by distro or product01:41
sivangeh, right01:41
sabdflthe conf is just an aggregation of them01:41
sivangyes that's what I meant :)01:42
sabdflwe'll use some sort of autoscheduler to figure out who can meet at any time01:42
sabdflbased on priority and status of the specs01:42
sivangyeah, so I've heared here and there :)01:42
sivangwould be cool putting it to the test01:42
sabdflwill be, yes01:43
sivangsabdfl: is there some sort of linear programming algo there? (like ones used for solving transportation and logistic problems)01:43
sivang?01:43
sabdflsivang: nothing too fancy just yet01:44
sivangsabdfl: k, I should get near a fax machine acutally and stop asking, just "Use the source, Luke" ;-)01:44
sabdflfax machine?01:45
sivangsabdfl: yeah, to sort out the NDA thingy 01:46
sabdflok01:47
=== ajmitch would love to see the source, if he could pass the NDA by his boss :)
sabdflKeybuk: i have a bunch of test failures in HCT with my new branch, will need your help02:01
sabdflcould you baz switch to mark.shuttleworth@canonical.com/launchpad--newpackageclasses--0 and run the HCT tests please?02:01
sabdflin summary, the branch creates a ton of new classes, that are basically a "source package within a distro" or "source package release within a distro", same for binary packages, with distro and distrorelease and distroarchrelease02:02
sabdfllots of permutations and combinations02:02
sabdflanyhoo... HCT doesn't like it, i'll focus on the test failures in LP itself (13 left) if you could have a look at the HCT ones02:02
sabdfli think you made up a "distro source package" object yourself, for HCT, right?02:03
sabdfli think you'll find the new one quite nice02:03
sabdflthese are the bits that need to go live tuesday :-)02:04
ajmitchheh, no pressure there :)02:06
sivangajmitch: how come not? this is soyuz that's approaching landing :)02:06
ajmitcha smooth touchdown is always impressive :)02:07
Keybuksabdfl: yup, no problem02:07
sivangyes, even for trained pilots02:07
Keybukyou're up to date with the hct branch?02:07
Keybuk(rocketfuel)02:07
=== lifeless starts taking wagers on sabdfls sleep between now and tuesday pm
ajmitchlifeless: AUD?02:10
lifelessajmitch: reais!02:11
ajmitchah right02:12
=== ajmitch doesn't have any of those on him
sivanglifeless: some sort of .au currency ?02:12
lifelesssivang: brazillion02:12
sabdflKeybuk: i'm up to the point where i think stub branched for production02:27
sabdflit was rocketfuel launchpad patch 265402:27
sabdflnot sure what the equivalent hct patch level is02:27
Keybukbaz tree-id lib/hct02:28
Keybuk(is just there's a test fix for "on pure breezy" in there, want to make sure you've got that one)02:30
Keybuk(though I see failures in hctapi I think too ... so there's at least some other problems here)02:30
sabdflKeybuk: rocketfuel@canonical.com/hct--devel--1--patch-2002:37
sabdflthat's out of date02:37
sabdflbut i didn't want to update to a point that you were depending on launchpad past the branch date (friday)02:37
Keybukright02:37
sabdflif youre expecting stub to roll the latest stuff out tuesday then am happy to update now02:38
sabdflsourcerer too02:38
Keybuksome schema changes went in recently, let me check you haven't got mismatched versions02:38
Keybuksabdfl: yeah02:43
Keybukpatch-266202:43
Keybuk    2005-10-15 05:39:24 GMT02:43
Keybuk    [r=stub]  replace ManifestEntry patch_on with parent that can apply to all types of entry02:43
Keybukyou have the Launchpad side of my changes02:43
Keybukjust update lib/hct and lib/sourcerer02:43
sabdflno i don't02:43
sabdfli have patch-2654 only02:43
Keybukhmm02:44
sabdflat least, i darned well hope so02:44
Keybukeither you've accidentally pulled them in02:44
Keybukor baz just lied to me02:44
Keybukhang on02:44
sabdflbugger damn shoot02:44
Keybukoh, wait, maybe I ran the wrong command02:44
Keybukno, worry02:44
Keybukignore me02:44
lifelesssabdfl: baz cat-log rocketfuel@canonical.com/launchpad--devel--0--patch-265502:44
KeybukI ran the wrong baz command :p02:44
sabdflcat-log: no log for revision (rocketfuel@canonical.com/launchpad--devel--0--patch-2655)02:44
sabdfl  tree: /home/mark/projects/ubuntu/launchpad02:44
sabdflphew :-)02:45
lifelesssabdfl: good.02:45
KeybukI ran baz missing and somehow managed to think you *had* that revision02:45
Keybuk<g>02:45
Keybuksabdfl: what's your tree-id of sourcerer?02:45
sabdflKeybuk: patch-3002:45
Keybukok, I'll back mine down to the same ids02:46
=== Keybuk runs make check
sabdfloh, this is joy02:47
Keybukhmm? :p02:48
sabdflthere's a simple bug in some code that causes the test suite to spit out PO Template Header parsing error messages02:48
sabdflso instead of the bug getting fixed02:48
sabdflthe error messages are happily embedded in about 90 tests02:48
sabdfland i fixed the bug02:48
sabdflso all the tests fail :-)02:48
lifelessgahr02:49
=== eirikn [n=eirikn@hagbart.nvg.ntnu.no] has joined #launchpad
Keybuksabdfl: ok, no errors in hct or sourcerer -- checking hctapi03:06
sabdflyou can run tests with no errors?03:06
Keybukdepends where the errors are03:07
KeybukI am getting errors in hctapi03:07
Keybuksabdfl: ahhh, I understand03:21
Keybuksome of the database functions return new classes, and the url resolver needs to know about them03:22
sabdflKeybuk: that makes sense, yes03:24
Keybukdoes anything return SourcePackage anymore?03:29
=== netjoined: irc.freenode.net -> brown.freenode.net
=== eirikn [n=eirikn@hagbart.nvg.ntnu.no] has joined #launchpad
=== eirikn [n=eirikn@hagbart.nvg.ntnu.no] has joined #launchpad
sabdflKeybuk: yes03:41
sabdflSourcePackage is a "DistroReleaseSourcePackage" in the new scheme of things03:42
sabdflyou get:03:42
sabdfl DistributionSourcePackage03:42
sabdfl DistributionSourcePackageRelease03:42
sabdfl SourcePackage03:42
sabdfl  DistroReleaseSourcePackageRelease03:42
sabdfl DistroReleaseBinaryPackage03:42
sabdfl DistroArchReleaseBinaryPackage03:43
sabdfl DistroArchReleaseBinaryPackageRelease03:43
sabdfli think thats it03:43
=== netjoined: irc.freenode.net -> brown.freenode.net
=== eirikn [n=eirikn@hagbart.nvg.ntnu.no] has joined #launchpad
=== eirikn_ [n=eirikn@hagbart.nvg.ntnu.no] has joined #launchpad
Keybukwhich one has the magic mapping back to ProductSeries ?03:47
Keybukis that still only on SourcePackage ?03:48
Keybuk(which you could rename to DistroReleaseSourcePackage to match your new names <g>)03:49
sabdflKeybuk: yes on both counts03:58
=== netjoined: irc.freenode.net -> brown.freenode.net
=== eirikn_ [n=eirikn@hagbart.nvg.ntnu.no] has joined #launchpad
=== tambaqui [n=patricia@200-213-121-118-mns.cpe.vivax.com.br] has joined #launchpad
=== LotusPetal [n=Lotus@cpe-66-65-244-241.nycap.res.rr.com] has joined #launchpad
=== BlackLotus [n=Lotus@cpe-66-65-244-241.nycap.res.rr.com] has joined #launchpad
Keybukuh, this is weird04:18
Keybukbaz branch is just hanging04:18
Keybukmeh, it started as soon as I traced it ... weeeird04:21
Lathiatdont you love those 04:26
Lathiatheisenbugs or whatever04:26
Keybukit's consistently doing it too04:28
=== TinMan [n=Lotus@cpe-66-65-244-241.nycap.res.rr.com] has joined #launchpad
sabdflKeybuk: ok, no more test failures in LP itself04:46
sabdfldo you want help on the hct front?04:46
Keybukalready done04:48
Keybukjust waiting for bzr to get its act in gear and actually make the commit04:48
sabdflKeybuk: nice.thanks!04:51
sabdflwe'll have to get lifeless to do a coordinated commit04:51
sabdflmy stuff is not against current RF, but rather designed to land cleanly on the branch destined shortly for production04:51
KeybukI branched from you04:53
Keybukyou'll just need to pull the one changeset04:53
Keybukit was the bits of hct in launchpad that broke, not outside04:53
Keybuksabdfl: pull from scott@canonical.com--2005/launchpad--newpackageclasses--004:56
Keybukit just mirrored04:56
Keybukis one patch that applies to hctapi and test_hctapi and makes it use your new classes04:56
Keybuk(just gonna reboot to try and rid myself of baz's strange behaviour)05:11
=== Keybuk [n=scott@syndicate.netsplit.com] has joined #launchpad
=== Koven [n=jcalopez@201.245.233.5] has joined #launchpad
Kovennight05:59
KovenI've one question about launchpad05:59
=== Nafallo is now known as Nafallo_away
=== Koven [n=jcalopez@201.245.233.5] has left #launchpad []
=== robitaille [n=robitail@d154-5-117-228.bchsia.telus.net] has joined #launchpad
=== Burgundavia [n=corey@S0106000000cc07fc.gv.shawcable.net] has joined #launchpad
=== _Rappy_ [n=hunt-pre@dsl-253-122.monet.no] has joined #launchpad
SteveAgood morning launchpadders08:02
GoRoDeKhi SteveA08:07
SteveAhi GoRoDeK.  how's is going?08:08
GoRoDeKSteveA: to sum it up: very good. thx for answering :) but have to go to some math lectures now ... cu08:10
SteveAcool08:11
\shis soyuz landed already? :)08:48
SteveAthe new ui and such from mark? not yet.  hopefully it'll be polished up today, and landed tomorrow.08:56
\shsounds good :)08:57
fabbione\sh: look at the positive side of all this09:03
fabbionewe can blame launchpad if dapper is broken :)09:03
fabbioneany time :)09:03
fabbione"hey the kernel OOPS..." "must be soyuz bug"09:04
SteveAwe're gonna be rewriting the kernel in python09:05
SteveAeasier to maintain09:05
fabbioneehhehe09:05
fabbionehave fun :)09:05
fabbioneyou will also need a new python interpreter in the MBR09:06
fabbioneotherwise you can't boot09:06
fabbioneoh did i mention that you have approx 512 bytes for that?09:06
\shfabbione: this will never happen...but if it's happening, then we have to rename soyuz to apollo 13 ,-)09:06
fabbione\sh: ehhehe09:06
\shfabbione: good morning btw :) 09:07
fabbioneit can't be a good morning09:07
fabbioneit's monday dude..09:07
fabbionemorning sucks on monday09:07
fabbione;)09:07
ajmitchheh09:07
ajmitchmorning, then :)09:07
\shfabbione: well, u r right...i have 3 digital tv issues to track down...and it looks like the problem was in front of the tv or settop box09:08
ajmitch\sh: isn't that usually the case?09:08
\shajmitch: only in 99% of the cases09:08
\sh1% is my fault ,-)09:08
fabbione\sh: wrong :)09:10
fabbionethat 1% must be somebody else fault09:10
fabbioneyou just need to figure of who :)09:10
ajmitchthat's why you need a system like soyuz?09:11
fabbioneajmitch: exactly :)09:12
\shfabbione: oh yes...but u know who managing works...100% sure, that the management is at fault, but this is wrong, so team lead is wrong and team lead is always right, so at this point the guy from ops is the fault ,-)09:12
\shs/who/how/09:12
=== carlos [n=carlos@243.Red-83-47-24.staticIP.rima-tde.net] has joined #launchpad
carlosmorning10:02
SteveAhello carlos10:04
carloshi10:04
SteveAi'm going to do a bit of work on potemplate UI today10:05
SteveAto make its facet menus better, and to make it produce a proper NotFound 404 error10:05
SteveAwhen going to a not found language10:05
carlosok10:10
carlosSteveA, cool, thanks10:10
jordiIf I need to report some issue with my connectivity/ability to read email, is it sounder@ or allhands@?10:18
jordiMy main mailserver has bad hardware trouble, it seems10:19
SteveAnot sounder@10:22
SteveAmostly people use warthogs@10:22
=== ddaa [n=ddaa@marvin.xlii.org] has joined #launchpad
SteveAmorning david10:22
=== ddaa looks left
=== ddaa looks right
jordierr, I meant warthogs, not sounder of course10:34
jordithanks steve10:34
SteveAjordi: do you need an email account to keep up with the rosetta list etc?10:35
jordiSteveA: I probably should, yes. I don't know how much time my normal emial account will be down10:38
SteveAhow about a gmail account?10:40
SteveAgive me an email address for you, and i'll send you an invitation10:40
carlosSteveA, I think elmo said that we can get a pop3/imap account if needed10:41
SteveAyeah10:42
SteveAbut10:42
carlosinstead of an email alias10:42
SteveAwhy bother?10:42
carlos:-)10:42
carlosjust noting it10:42
SteveAi can give jordi a gmail account right now10:42
SteveAwe can ask the admins for an imap account too10:42
SteveAbut, that will certainly take a bit longer10:42
carlosright10:43
SteveAi guess the canonical imap account would show mail as coming from jordi's canonical email address10:43
jordioh, I have a gmail account.10:43
SteveAcool10:43
jordiI could temporarily use that10:44
jordiI'll subscribe10:44
SteveAso, i guess you just need your canonical email address pointed at it ?10:44
jordiif it can be snet to both, that'd be best10:44
SteveAjordi: fabbione had a suggestion on #canonical10:51
jordiSteveA: inside the DC10:52
jordidb.ubuntu.com does not exist here10:53
SteveAyeah, so ssh to chinstrap10:53
SteveAand use it from there10:53
jordioh. AFAIK, I have no account.10:53
SteveAokay, then an RT request is what it'll have to be.10:53
=== thisfred [n=thisfred@a80-127-80-154.adsl.xs4all.nl] has joined #launchpad
KinnisonHmm, no stub10:54
SteveAhe should be around shortly10:55
SteveAhe's having some 'ISP blocks irc' issues10:55
SteveAi've given him an account somewhere to use to do ssh tunneling10:55
=== Kinnison nods
jordihow can isps be so fascist10:58
jordiprobably some enlightened mind thought IRC is only used by worm bots or whatever10:59
Lathiatquite easily apparently10:59
SteveAmy home ISP has blocked one irc port11:00
SteveAbut only at the adsl router11:00
SteveAso, i'll reconfigure it when i get around to it11:01
SteveAthey don't mind my doing so11:01
SteveAit's just the default configuration11:01
Lathiatthats less bad11:02
Lathiati like the ISPs that block incoming ports but let you turn it off11:02
Lathiatsmtp, etc11:02
jameshisn't stub on iinet?11:03
jameshI haven't had any troubles11:03
Lathiatyeh he is11:04
Lathiatdoesn't sound like something iinet would do11:04
Lathiatmight just be a b0rked route or something11:04
SteveAjamesh: he's relocated to thailand.11:06
jameshah11:06
SteveAjamesh: good morning.11:07
SteveAhow's the bugzilla conversion doing?11:07
SteveAlifeless: does anyone use a 307 response ?11:10
lifelessECONTEXT11:11
lifelessits pretty much guaranteed that someone does, as the ietf likes reference uses before making a standard11:12
jameshSteveA: I've got the basics in place for going through the list of bugs, creating users as needed11:12
jameshSteveA: I'm just working out the details of converting the comments11:12
SteveAlifeless: does anyone *really* use it?11:13
SteveAjamesh: cool.  any issues so far?  anything you need to tell brad or bjorn about?11:13
jameshSteveA: nothing in particular.  The existing malone interfaces seem sufficient to implement the whole lot11:14
jameshwhich is good11:14
SteveAthat's good11:14
SteveAand, any news on the autoscheduler magic?11:14
jameshSteveA: some web browsers handle 307 responses (temporary redirects) different to permanent redirects11:14
jameshSteveA: they update bookmarks if they see a permanent redirect but not otherwise11:15
SteveAokay11:15
SteveAi'm adding some stuff to Navigation to allow permanent redirects as an option11:15
SteveAi need it for making the shipit user.cgi permanently redirect to the shipit homepage11:16
lifelessSteveA: I dont know. if you want to make a permanent redirect, use a permanent redirect11:16
SteveAyeah.  was just curious about 307.  haven't seen any software that specifically supports it.11:17
SteveAand i figured you'd know11:17
=== elmo [n=james@83-216-156-21.jamest747.adsl.metronet.co.uk] has joined #launchpad
jameshwe should support "402 Payment Required"11:17
lifelessSteveA: I haven't seen any bug reports about it :)11:17
SteveAfor bounties?11:18
jameshdunno :)11:18
SteveAfor +addkarma ;-)11:18
ajmitchheh11:18
=== WaterSevenUb [n=WaterSev@azevedo.astro.up.pt] has joined #launchpad
sabdflmoin moin sports fans11:54
Kinnisonsports?11:54
KinnisonIs this lesser-spotted-lunchpad-developer hunting?11:54
Kinnisoncarlos: gah, your patch pipped mine into pqm's queue by nine seconds11:59
carlosKinnison, well, It's fourth time I try to merge that patchset and was rejected always because baz conflicts....11:59
carlosI think it's time to get it merged ;-)12:00
Kinnison:-)12:00
SteveAKinnison: should i put aside time to do reviews for you today?12:00
KinnisonSteveA: if stub can turn up and check a db patch and give me a blessing then yes12:02
KinnisonSteveA: otherwise I'm not sure how we're gonna open 'cos I have a patch which *has* to hit production and I've failed to get stub every time I've tried12:02
SteveAcarlos: do you know why LanguageNotFound is a ValueError, and is not a NotFoundError ?12:03
carlosphone....12:03
SteveAKinnison: have you mailed stub about it?12:04
KinnisonSteveA: No because I'm useless12:04
KinnisonSteveA: I was just moving my stuff to my desktop12:04
SteveADOIT12:04
KinnisonSteveA: I'll mail him in about 5 minutes12:04
SteveAta12:04
Kinnisonstub@canonical.com ?12:06
SteveAstuart.bishop@12:08
SteveAstub might work12:08
Kinnisonta12:08
carlosSteveA, because I think it was a ValueError and I think you asked me to create its own exception and seems like I choose the wrong parent....12:11
SteveAokay12:11
SteveAi'm changing it to derive from NotFoundError12:11
carlosok, thank you12:12
SteveAsabdfl: bug 215112:17
UbugtuMalone bug #2151: No page to edit architecture details (404 error) Fix req. for: launchpad (upstream), Severity: Normal, Assigned to: Nobody, Status: New http://launchpad.net/malone/bugs/215112:17
SteveAsabdfl: does your branch fix this?12:17
SteveAKinnison: stu will be around very shortly12:29
KinnisonSteveA: yeah, I'm chatting to him on jabber since I found him there12:29
SteveAk12:29
sabdflSteveA: no12:30
SteveAsabdfl: ta.  i'm doing a bunch of bugfixing, but i don't want to conflict with your landing.12:30
=== stub [n=stub@213.133.64.221] has joined #launchpad
stubWeee12:40
Kinnisonstubby!12:41
=== SteveA looks for his US$50
sabdflhey stubarooney12:41
stubMorning12:42
SteveAstub: i'm preparing a branch with a bunch of fixes of the most common errors in launchpad12:42
SteveAit's for merging into RF, but would be neat to cherrypick it if there's no conflicts12:42
stubThis is all sounding like we are rolling out HEAD tomorrow12:42
SteveAooh, fun12:42
SteveAthat would be simpler12:42
SteveAalthough i'd like to see a day on staging first12:42
stubPretty much everything that has landed recently is a bug fix for cherry picking, or critical.12:43
SteveAit's the "critical" i worry about12:43
SteveAthese things sometimes introduce bad regressions12:43
stubWe can roll out staging at the press of a button (well I can since I have the keys all setup). Will Kiko's minions have time to abuse it?12:43
SteveAhmm... i need to get some lunch.  i have a few hours more of fixes to make.12:44
SteveAmatsubara and gneuman will be able to give it some stick12:44
SteveAi think it is worth doing.12:44
stubok. I'm going to try roll out Keybuk's and/or sabdfl's Gina spanking onto staging12:44
SteveAkiko can help them be systematic about it12:44
SteveAokay, so we plan staging today, hammer staging tonight, roll out tomorrow.12:45
sabdflstub: i'm just merging keybuk's changes now12:45
SteveAsabdfl: what do you think of above plan?12:45
sabdflwith a bit of luck that will result in tests passing across the board12:45
stubsabdfl: Good. Saves me trying to land it ;)12:45
sabdflSteveA: why roll out head tomorrow?12:45
SteveAcompared to what?12:46
stubsabdfl: Ping me when you have it merged and I can roll it out to staging while PQM is chewing on it12:46
sabdflSteveA: patch -2654 + fixes12:46
SteveA<stub> Pretty much everything that has landed recently is a bug fix for cherry picking, or critical.12:46
sabdflstub: ok. i also have some decruftifying work to do12:46
stubYer - if it isn't HEAD, it sure will smell like it12:46
sabdflhmm..12:47
sabdflone thing i am concerned about with my changes is cron scripts12:47
sabdfli don't thnk those have good tests, in general12:47
sabdflso if my changes break those...12:47
SteveAit's been a weak point in the past.12:48
SteveAbut, staging isn't good at picking up such problems12:48
SteveAi think we can just monitor them closely12:48
SteveAand fix as needed over the next couple of days12:48
stubI can cherry pick what I can and just delay any other 'critical' stuff until we have had a chance to kick the tyres on staging then12:48
SteveAstub: has staging picked up cronscript issues before?12:49
sabdflstub: has most of the "critical" stuff other than mine actually landed on HEAD now?12:49
sabdfli could update to head12:49
SteveAKinnison: i'm going to get some lunch shortly.  i'll be available for reviews when i get back.12:49
sabdflonly 6 conflicts :-)12:49
KinnisonSteveA: cool12:50
stubSteveA: No. The cronscripts that have been tested there worked fine on staging. They have had database locking issues, which we didn't pick up, but I think we are learning to deal with that in our code now (?)12:50
SteveAstub: what about a cronscript with broken code12:50
SteveArather than just contention-prone code?12:51
SteveAgo dilys !12:51
=== SteveA expects some kind of pqm announcement any second
=== stub goes and checks the arch-commits archive
=== Kinnison wonders what stevea is getting excited about
SteveAKinnison: the pqm queue going down, so i can get my fixes in ;-)12:52
SteveAah, sod it... i'll get them in after lunch.12:52
=== SteveA --> lunch
=== Kinnison 's branch has only been building for 20 minutes or so
stubok. production--1.37 (scheduled for tomorrow rollout) is currently at patch -2659. There are only three other commits in rocketfuel after that, of which only one (patch-2663, a small fix from salgado) should probably be cherry picked. 12:55
stubsabdfl: ^^^12:55
sabdflmy changes are huge (patch is up to 11000 lines, filtered, now, with more to come) and will have bugs. but not bugs that cause data loss12:55
sabdflnothing in there writes12:55
sabdflits all just better ways to visualise and present the existing data12:55
sabdfli'm hoping finally to remove the SourcePackageInDistro and VsourcePackageReleasePublishing view cruft12:55
stubso I think we are good to go for a production rollout tomorrow. My comment was partially based on the assumption that sabdfl's branch would need to be landed as soon as we could confirm it worked on staging in order to get Dapper open12:56
=== Kinnison 's bits will be needed to land, but we've discussed that on jabber
stubSo.... gina has already been run on production. Has anyone given any though to it we can leave cleanup until later or should we do that now? Or is is a simple matter of just deleting the contents of a few tables and letting Gina-NG rebuild them?12:58
sabdflerk12:59
sabdflwe agreed NOT to run gina on production12:59
sabdflit has known12:59
sabdflissues12:59
stubsabdfl: That was agreed *after* it had been run12:59
Kinnisonsabdfl: gina ran on production (to an extent) before you raised the issues12:59
sabdfland we were going to look at the results of a run on staging AFTER my branch had landed12:59
sabdflfuck12:59
sabdflthat's not good12:59
Kinnisonit's very easy to clean out what we're worried about01:00
stubKinnison: Cool.01:00
Kinnisonwe empty the following tables (in the following order): binarypackagefile securebinarypackagepublishinghistory binarypackagerelease build01:00
sabdflok01:00
sabdflthen fix gina01:00
stubok. I'll do that on staging before testing Gina.01:00
sabdflthen run again?01:01
Kinnisonyeah, gina is additive. take away what she's done and she'll do it again01:01
sabdflgreat. thanks Kinnison, made my day there01:03
sabdfldid kiko make the gina fix?01:03
sabdflstub: keybuk's hctapi fixes merged and mirrored. running tests now01:03
sabdflstub: when you make a production config, does it include specific patch levels of all the other branches? like hct and sourcerer?01:04
sabdflwhat happens if they move on post-thursday, compatible with launchpad--devel--0 but not the thrusday branch for production?01:05
stubsabdfl: Generally no, but I have had to do it on occasions01:05
sabdflok01:05
sabdfli just want to know what versions to be testing with01:05
stubI'll freeze it now01:05
stubsabdfl: so - I thought your branch you are landing now had the Gina fixes. I think your changes and Steve's are the only ones that have been made, and I don't know if your branch includes SteveA's.01:10
sabdflstub: no. kiko was going to make the gina fixes01:10
stubok.01:10
=== cprov [n=cprov@200-171-140-32.dsl.telesp.net.br] has joined #launchpad
=== GURT [n=pastafzu@cpe-24-195-211-214.nycap.res.rr.com] has joined #launchpad
=== matsubara [n=matsubar@200-171-140-32.dsl.telesp.net.br] has joined #launchpad
matsubaragood morning!01:17
ajmitchmorning01:18
stubsabdfl: https://chinstrap.ubuntu.com/~dsilvers/paste/fileV27R74.html01:22
=== niemeyer [n=niemeyer@200.138.35.146] has joined #launchpad
sabdflah. the gina error in my tests was the absence of dpkg-source on the test machine :-)01:30
sabdfl(not the db gina error, the weird gina test failure)01:31
sabdflstub: gracias, will test against that01:31
sabdflstub: can i add this to 25-41-0.sql?01:40
sabdfl-- rid ourselves of unused views01:40
sabdflDROP VIEW vsourcepackageindistro ;01:40
sabdflDROP VIEW vsourcepackagereleasepublishing ;01:40
sabdfli'm just running tests now01:40
sabdflwant to get rid of that old cruft. Kinnison will be happy.01:41
stubsabdfl: Sure01:43
sabdflthanks01:43
stubDinner time.01:44
=== TinMan [n=Lotus@cpe-66-65-244-241.nycap.res.rr.com] has joined #launchpad
=== sabdfl [n=mark@pdpc/supporter/silver/sabdfl] has left #launchpad []
=== TinMan [n=Lotus@cpe-66-65-244-241.nycap.res.rr.com] has joined #launchpad
=== TinMan is now known as lotuspetal
=== lotuspetal is now known as LotusPetal
=== zyga [n=zyga@2-mi2-1.acn.waw.pl] has joined #launchpad
=== mpt [n=mpt@200-171-140-32.dsl.telesp.net.br] has joined #launchpad
mptGoooooood morning02:06
sivanghey mpt  :)02:09
=== Nafallo_away is now known as Nafallo
=== WaterSevenUb [n=WaterSev@azevedo.astro.up.pt] has joined #launchpad
=== carlos -> lunch
carlossee you02:16
=== sabdfl [n=mark@pdpc/supporter/silver/sabdfl] has joined #launchpad
sabdflhey kiko02:18
sabdflstub: looking good here, tests all passing with the extra views removed02:18
sabdflvsourcepackagereleasepublishgin and sourcepackageindistro are *toast*02:19
sabdfllifeless, ddaa: question. if I'm at --patch-20 and swtich to --patch-22 why does it not show modified files?02:19
sabdfltalks about patch logs etc, but not modified files02:19
sabdflbaz status then shows the correct patch level02:20
dilysMerge to rocketfuel@canonical.com/dists--devel--0: [trivial]  production-1.37 freeze (patch-121: stuart.bishop@canonical.com)02:20
kikomorning vietnam02:21
sabdflit may be napalm city today, indeed02:22
sabdflkiko: did gina get that dup-entry-fixin' love?02:22
sabdflwe've nuked the production run results in order to run it again with the fix02:23
kikolet me see02:25
kikonope, not that I'm aware of02:25
kikothe last commit that touched it was stub's 02:26
sabdflgina?02:28
sabdflkiko: ok, you said that was a faily straightforward fix, will you do it? i thought that's what we planned02:28
kikoyes, that touched gina02:28
kikoverifying that the binarypackagerelease had already been built and early-returning, right?02:29
kikowhat's kind of bad is that I don't have any test rig for gina set up02:29
kikocprov, do you have one?02:29
kikosabdfl, do you have a test rig set up?02:29
kikoI can try mailing you a patch instead of you like02:29
cprovkiko: no 02:30
SteveAre02:31
kikosuck02:31
sabdflkiko: no, i don't have one handy02:32
kikosabdfl, I need a full archive and a katie dump, right? I wonder if it's easy to run it on staging02:34
kikocprov, Kinnison: is it?02:34
cprovkiko: at least one full component, katie isn't mandatory anylonger02:35
=== cprov tries to remember debonzi's last changes
SteveAsabdfl: nice post to the faq about __getitem__ style.  i'll correct the bug in the sample code.  i agree with it.  one thing i want to avoid though is having 'heavy' or ambiguous __getitem__ methods.02:35
SteveAthat is, they should give access to just one or at most two types of things.02:35
cprovkiko: try to run on gwyddion or use my external HD in your lappy02:35
SteveAotherwise foo[bar]  is hard to understand02:36
=== uws [n=mathilda@scrat.hensema.net] has joined #launchpad
kikocprov, the issue is that I don't think you can reproduce the error with a single run with no katie dump02:36
uwsHmmm. Is the oops-i'm-suffering-from-brain-damage-so-please-mail-me-my-password functionality broken or what?02:37
kikois it broken?02:37
cprovkiko: I see, you're right, anyway we have complete warty/hoary here if you think it'd be udeful for you.02:37
uwskiko: I don't get any mail from it, it seems02:38
uwskiko: Are you a project admin?02:38
uwskiko: if so, you can grep logs for   "uws+launchpad@xs4all.nl"02:38
ddaasabdfl: probably because there were no modified files, I guess02:38
uwskiko: nevermind, it was just terribly slow :P02:42
SteveAkiko: hi!02:43
kikohow are you SteveA 02:43
SteveAi'm good.  how are you in brazil?  still hot like the she-devil?02:43
kikoyeah, pretty hot.02:44
SteveAso, i've fixed a bunch of the "top error" bugs02:44
SteveAon my tree02:44
SteveAi've got a few more to do02:44
kikocool02:44
SteveAgoing to try to get it into the rollout that is happening over tonight --> tomorrow, along with mark's soyuz stuff02:44
SteveAhas anyone talked with you about organising QA work tonight?02:45
kikonot yet02:45
SteveAokay02:45
kikoI'm at the moment concerned with fixing gina02:45
SteveAso, stub checked, and there isn't much added to HEAD other than what would need to be cherrypicked anyway02:45
SteveAso, we're going to do a full rollout02:45
kikocool02:45
SteveAcan you organise a few people in brazil to do QA on staging later today?02:45
kikoland your top-fixes02:46
kikosure, what time do we roll out?02:46
SteveAbasically, to make a list of typical pages, and go through them02:46
SteveAtrying stuff out02:46
kikoor are we blocked on me fixing gina? :-)02:46
SteveAwe need to clear out the old gina data, and then to do a gina run with a fixedup gina02:46
elmodapper is blocked on gina02:46
SteveAand that's a precondition for getting Kinnison02:46
SteveA 's latest stuff02:46
SteveAwhich is needed, as elmo says, for opening dapper02:47
kikookay02:47
kikowell02:47
SteveAhow's the gina looking?02:47
kikotbh I can can try fixing gina but it will be a blind-fix unless I set up a local run02:47
SteveAwe can do runs on staging02:47
SteveAstu will be back from lunch soon02:47
kikoSteveA, lunch?02:47
SteveAlunch02:47
kikowtf02:47
kikoanyway02:48
SteveAor dinner02:48
Lathiatits 9-11pm in australia :)02:48
SteveAwhat does 'dinner' mean anyway02:48
SteveAstub is in thailand02:48
SteveA<stub> Dinner time.02:48
SteveAthat's what he said02:48
kikoSteveA, can we do runs on staging?!02:48
Lathiatdinner is ambiguous02:48
SteveAwhen i debugged some gina stuff last week02:49
Lathiatsome people say it means lunch, some say it means tea time (night meal)02:49
SteveAit was on staging02:49
SteveAstaging can't take a complete gina run02:49
SteveAbut we can do main, for example02:49
SteveAwe can do various sections02:49
SteveAhmm... are my gina changes in RF?02:50
=== SteveA looks
Nafallodinner doesn't mean "put foodish stuff into <body>"?02:50
SteveAkiko: apparently not02:50
SteveAkiko: i'll mail you a patch02:51
kikoSteveA, thanks 02:51
SteveAthis gets gina running to completion in production / staging02:51
SteveAthere was one issue with gina not handling unsigned .dsc files02:52
SteveAand another issue about a simple bug in some SQL02:52
SteveAthere's also a bit of extra debugging output02:52
kikowhy can't we do a complete gina run on staging?02:52
SteveAdisk space02:53
kikois there a way of triggering the gina error quickly?02:53
SteveAwhat error?02:53
SteveAwith that patch, gina runs to completion on main, security, for breezy, hoary and warty, on staging02:53
kikoit raises errors though02:54
SteveAthe remaining issue is what mark was talking about friday night02:54
SteveAwhat kind of errors?02:54
SteveAwith the patch i sent you, it raises no errors02:54
kikopsycopg.IntegrityError: ERROR:  duplicate key violates unique constraint02:55
kiko+"binarypackagerelease_binarypackagename_key"02:55
kikowhat is the remaining issue then?02:55
SteveAyes.  i fixed it02:55
SteveAwith Kinnison's help02:55
SteveAon friday02:55
SteveAand ran it on staging02:55
SteveAto check02:55
kikoand?02:55
SteveAthe remaining issue is that gina is putting duplicate data into the database02:55
kikooh02:56
kikointo what table?02:56
SteveAsee the launchpad list02:56
SteveA"Gina run in production on tuesday, staging with mark's patch monday"02:56
SteveAi sent it02:56
SteveAwith a transcript from this channel02:56
SteveAyou were there02:56
SteveAyou're in the goddamn transcript ;-)02:57
kikoI believe I actually said something02:57
Kinnisonsorry guys, I was at lunch02:57
SteveA<sabdfl> kiko: i don't know how gina collects info before it decides to02:57
SteveAput it in the db02:57
SteveA<sabdfl> but i'm guessing..02:57
SteveA<sabdfl> it finds all the bin packages for the arch, from the source package02:57
SteveA<sabdfl> then creates a build for those02:57
Kinnisonanything needing my input?02:57
SteveA<sabdfl> it should first look to see if the bin package is there already02:57
SteveA<sabdfl> if it finds one, it should find them all02:57
SteveA02:57
SteveAKinnison: yes02:57
SteveAplease read the above02:57
SteveAand think about it02:57
SteveAand talk with kiko about it02:57
Kinnisonhow much of "the above" ?02:57
kikoyeah yeah02:57
SteveAthe <sabdfl> part02:58
KinnisonRight, okay02:58
Kinnisonso I know what sabdfl's on about02:58
Kinnisonkiko: what do you want to know?02:58
kikolet me clean out my tree, 1m02:58
kikoSteveA, sabdfl: what area of launchpad should we emphasize the test on?03:00
SteveAsouyz pages primarily03:00
SteveAbut make sure that the rest still works03:00
SteveAwe really don't want a failure in shipit03:00
SteveAso that should be tested to make an order or two03:00
SteveAand to sign up03:00
SteveAwith a new account03:00
kikosure03:01
SteveAis salgado going to be around today?03:03
kikoyes, he has a class on monday morning or something, that's all03:03
SteveAbug 2714 probably needs some love03:03
UbugtuMalone bug #2714: sort doesn't sort entire data set Fix req. for: shipit (upstream), Severity: Normal, Assigned to: Guilherme Salgado, Status: Accepted http://launchpad.net/malone/bugs/271403:03
kikoSteveA, salgado has some poll fixes that I would rather we did first -- shipit is coming along acceptably for now03:04
kikothe sorting is nice-to-have but not critical IMO03:04
SteveAk03:04
SteveAi'm going to get on with fixing the remaining top bugs.  we'll sort out the staging situation when stub returns.03:05
kikoKinnison, my tree is clean, let me start looking at the code03:05
SteveAdid you get that patch i mailed?03:06
SteveAjordi: is your mail sorted out yet?03:07
kikoSteveA, yes, I did03:07
SteveAcool03:08
=== jordi just got back from the hospital
jordiSteveA: let me check03:09
kikojordi, hospital?03:09
jordikiko: I had my back checked after 6 months03:10
jbaileyLP seems to not want me to log in.03:10
jordi6 months ago I had big pain03:10
jordijbailey!03:10
jbaileyIs it known to be broken, or is it somehow just me?03:10
SteveAjbailey: could be the 'lack of Vary' header problem03:10
jbaileyjordi!03:10
SteveAjbailey: if you're going via an aggressive proxy03:10
SteveAit's high on my list of things to fix, after the top 10 not working pages03:10
jbaileySteveA: I have no idea what my ISP has.03:10
SteveAlet me try logging out and then in...03:11
jbaileyIs there a suggested workaround?  And/or does just replying to bug mail get it into malone? =)03:11
=== stub [n=stub@costello.z3u.com] has joined #launchpad
SteveAjbailey: try going to https://launchpad.net/+login03:11
SteveAtry shift+reload of the page you want to see03:11
SteveAhi stub 03:11
SteveAso, kiko will need to try new-gina out on staging03:12
mdkejordi, got some more fixed po files for you if you are up for it03:12
SteveAcan we get staging ready, with gina data nuked ?03:12
SteveAand maybe the librarian GC-ed ?03:12
elmoumm03:12
elmostaging doesn't have enough data to test the bug that needs fixed03:12
BjornTjbailey: replying to bug mail works as well03:13
kikothat was my concern03:13
kikoelmo, what do you suggest?03:13
SteveAelmo: don't we have main from both breezy and hoary on there?03:13
jbaileySteveA: Lovely.  Logging in on that other page and then shift-reload worked.03:14
elmooh, err, don't mind me - I seem to have gotten confused03:14
jbaileyShift-reload hadn't worked before that.03:14
jbaileyBjornT: Nice, thanks. =)03:14
elmoasuka apparently has a full mirror archive.u.c mirror03:14
stubSteveA: Librarian garbage collected means deleting all the files btw ;)03:14
KinnisonSteveA: Most python equiv of "touch $foo" => open(foo,"w").close() yes?03:14
SteveAjbailey: okay.  i wonder... can you try logging out, and seeing if you can reproduce the issue?03:14
SteveAstub: is the LGC running in production?03:15
jordiSteveA: fixed, thanks03:15
stubSteveA: LibrarianGarbageCollection is still a work in progress (nearly ready to land the first half IIRC)03:16
SteveAKinnison: perhaps... maybe open it append.03:16
KinnisonSteveA: is that w+ ?03:17
SteveAstub: i'm concerned we'll need it run in production before a gina run in production.03:17
SteveAelmo: what's the current free space on the librarian please?03:17
elmo/dev/sda3             537G  361G  149G  71% /03:18
SteveAKinnison: os.utime03:18
SteveAKinnison: do we have enough space in the librarian to do a full gina run03:18
jbaileySteveA: Sure, gimme a sec.03:18
KinnisonSteveA: that doesn't work if the path doesn't exist03:18
KinnisonSteveA: What I'm actually trying to do is; "test -e $foo || touch $foo"03:19
jbaileySteveA: No, I cannot reproduce it right now.03:19
=== zyga_ [n=zyga@2-mi2-1.acn.waw.pl] has joined #launchpad
elmoSteveA: FWIW, archive.u.c all 6 arches is 99Gb03:19
SteveAjbailey: thanks.  please let me know if it happens again.03:19
elmoI don't know how that translates in gina tho - hopefully it shouldn't grow any03:19
jbaileySteveA: Will do!03:19
=== bradb [n=bradb@modemcable033.209-70-69.mc.videotron.ca] has joined #launchpad
SteveAhey brad03:20
kikoahoy bradb 03:20
bradbhey dudes03:20
kikoduderino03:20
SteveAKinnison:  you know os.path.exists ?03:20
KinnisonSteveA: yes, currently I have:03:21
Kinnison                    if not os.path.exists(comp_path):03:21
Kinnison                        # When I think about you, I touch myself...03:21
Kinnison                        open(comp_path, "w").close()03:21
SteveAlooks good to me03:21
kikoin the future grep -v "\s+#\s$" please03:21
kiko+$ even03:22
Kinnisonkiko: Pardon?03:22
=== Lathiat smirks
mptsivang: Tell me about the "sivang" person in Launchpad03:24
kiko@#@!*!9881@&(!03:25
kikodeleted my old inbox03:25
kikothat's a sad way of clearing out email :-(03:25
sivangmpt: what do you mean? :)03:25
mptsivang: We're getting many errors from URLs like https://launchpad.net/people/sivang03:25
SteveAthat's interesting03:25
sivangmpt: errors?03:25
SteveAwhen i go there now03:25
SteveAi get an error03:25
Lathiati get a page not found03:26
mptsivang: Is that your account?03:26
mptIs that an account you merged into another one?03:26
sivangI didn't merge it :)03:26
sivangJust changed it03:26
sivangto https://launchpad.net/people/sivan03:26
kikobradb, are you going to fix 933 or can I give it to matsubara?03:26
mdkemine is giving an error too03:26
sivangI figured is nicer to have my first name registered, that way have the same for the u.c email alias03:27
mdkepeople/mdke03:27
mptsivang: Had you posted the old URL anywhere else?03:27
mdkeoops, it is there now03:27
mptLike a mailing list?03:27
mptor a wiki page?03:27
SteveAhmm... something interesting is happening when traversing 'people'03:27
SteveAlooks like it somehow returns 'None'03:27
bradbkiko: You could give it to matsubara if you want. That would *rock* *rock* *rock* to have that fixed.03:27
sivangmpt: not that I know of, that's quite interesting, I must say03:27
mptkiko, can you get the Referer headers included in those logs? SteveA was asking for those last week too, iirc03:28
=== sivang checks on the wiki
SteveAmpt: i think i need to hack stuff to get referer headers easily03:28
kikoSteveA, yeah, I was amused by your comments about asking me to add referrer information -- there is none :)03:28
SteveAmpt: but i can get them with a bit of research, matching up error logs with traffic logs03:28
SteveAkiko: you can match up the two logs03:28
sivangmpt: no, I didn't mention those anyware. But I saw google has already cached almost all of my page's properties.03:29
sivang(When I look for myself on google, that is)03:29
mptYes, perhaps it's googlebot03:29
mpthttp://www.google.co.nz/search?hl=en&lr=&q=link:ifqC7ngMP6UJ:https://launchpad.net/people/sivang03:29
kikoSteveA, that's a bit of work and I'm loathe to do it unless, well, you say it's not includable in the regular log03:29
mptso we need the User-Agent header as well :-)03:30
SteveAmpt: okay, i'll look these up later03:30
SteveAi need to fix some bugs and get a branch landed now03:30
SteveAmpt: how's the menus work coming on?03:30
stubSo kiko - you got a branch for me?03:31
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: Bits and bobs on distro{arch,}release. r=stevea (patch-2664: daniel.silverstone@canonical.com)03:31
SteveAmpt: maybe we should spec out leaving a 'redirect' record when a name is changed in launchpad03:31
SteveAso that, until another name occupies it, the page can say 'you're probably looking for this'03:31
kikostub, no, I don't03:31
stubkiko: ok. Bath time then.03:32
kikoat the moment I don't even know how to run a test for the fix I have03:32
SteveAstub: 03:32
bradbkiko: Do you have a few minutes to wrap up this sort order patch?03:32
SteveAif you make staging ready for testing gina on03:32
SteveAi can log in and do the stuff03:32
stubok03:32
=== Nafallo is now known as Nafallo_away
mptSteveA: Like I said, I want to land the design fascism branch first so that I'm not redoing work -- I thought I'd get to land that last week, but the capitalization blocked it03:32
mptso I need to put up the branch for sabdfl to look at03:33
SteveAmpt: okay.  how much left on that?03:33
mptand then it should be landable03:33
kiko    "low": SourcePackageUrgency.LOW,03:33
kiko    "medium": SourcePackageUrgency.LOW,03:33
kiko    "high": SourcePackageUrgency.LOW,03:33
kiko    "emergency": SourcePackageUrgency.LOW,03:33
kikoKinnison, why is everything ow?03:33
kikolow?03:33
SteveAwe're do damn mellow...03:33
SteveAthis is medeterranean urgency levels03:34
SteveAkiko: how long until you want to try a gina run?03:34
sabdflurgency? "maybe"03:34
KeybukSteveA: would a patch that changes just two import lines be considered [trivial]  ?03:34
=== salgado [n=salgado@200-171-140-32.dsl.telesp.net.br] has joined #launchpad
Keybuk(it also deletes about 15,000 lines03:35
SteveAKeybuk: perhaps... you can always paste the change into https://chinstrap.ubuntu.com/~dsilvers/paste/, with a summary of the deletion to get an instant review from any reviewer listening.03:36
mattl_hi, i've been looking at launchpad over the last few days.. it's based on Plone, right? is the source code to Launchpad available anywhere yet?03:36
kikobased on Plone. hmmm.03:36
kikoI don't know how to answer that :)03:37
SteveAmattl_: we use parts of the plone style sheet.03:37
Kinnisonkiko: urgh, what file?03:37
kikothere's this plone.css file I want to to delete though :)03:37
mptI've already deleted it03:37
mattl_okay, does it run on Zope?03:37
SteveAmattl_: but it isn't based on plone at all.  the source code isn't available right now.03:37
kikoKinnison, handlers.py, right before fuck in ear03:37
SteveAmattl_: it uses Zope 3, sqlobject, twisted and a bunch of other stuff.03:37
kikoKinnison, and /don't/ touch that file, just send me diffs if you like03:38
kikoSteveA, not to mention string and wire03:38
mattl_SteveA: okay, thanks. is there any plan for making it available at some point?03:38
SteveAkiko: i wasn't going to mention the string and wire.03:38
mattl_what colour is the string?03:38
sabdflchewing gum & duct tape03:38
KeybukSteveA: meh, that involves "baz diff" taking less than a metric week03:38
Kinnisonkiko: urgh that's so totally shit03:38
Kinnisonkiko: yeah, just fix them to be LOW/MEDIUM/HIGH/EMERGENCY03:39
kikoKinnison, you should focus more on code and less on cursing PEP-8 perhaps?03:39
SteveAmattl_: management have said that it will be made open eventually.  but there is no definite plan.  we're making some parts of it open as we go.03:39
kikosure03:39
=== sabdfl waits for mpt to ask what flavour the chewing gum is
SteveAKeybuk: don't see why.  paste the two changed lines into the paste thing, along with a paragraph about the deletions.03:39
Kinnisonkiko: I'm certain I wouldn't have done that03:39
kikosabdfl, it's vegemite flavor 03:39
Kinnisonkiko: but if I did then yeah, perhaps I should03:39
kiko:)03:39
mattl_SteveA: Thanks.03:39
SteveAthere will come a time when waiting for bzr for launchpad will be quicker than waiting for baz diff.03:39
=== Kinnison vomits at the mere thought of vegemite
=== SteveA hands Kinnison a man frmo brussels
Kinnisonmmmm mussels03:40
=== mpt is glad he doesn't use chewing gum
mptthough, mussel-flavored gum would be interesting03:40
bradbkiko: do you have a moment to wrap up this sortorder patch?03:40
SteveAkiko: so... when shall i plan to do some gina wrangling on staging with you?03:40
kikobradb, sure03:40
kikoSteveA, in about 30 minutes03:40
SteveAstub: can you let me know when staging will be ready?03:40
bradbkiko: so, from reading your email...03:41
kikohey Kinnison 03:41
SteveAkiko: fine.  just enough time for me to fix another bug or two.03:41
bradbkiko: to be sure, what do you mean exactly by wanting the backend "unified"? there's exactly one function you call to get the sort params.03:41
Keybukhttps://chinstrap.ubuntu.com/~dsilvers/paste/filea6ekEM.html03:41
kikobradb, you said "old-style" versus "new-style" sorting initially, and I wanted there to be only one backend, not two. is that fixed? I can look at the code anyway though.03:42
bradbkiko: Should I just resend the latest version of the patch? I guess it's more or less different enough to have another look, if you're interested. Maybe that'll clear things up.03:42
SteveAKeybuk: is this just a straight relocation to put sourcerer at the top level?03:43
kikobradb, yeah03:44
kikoKinnison:    "source": PackagePublishingPriority.EXTRA #Some binarypackages ended up03:44
kiko                                              #with priority source.03:44
KeybukSteveA: Sourcerer's been in both places for the most part of the last year03:44
bradbkiko: ok, bazzing my way there now03:44
kikoany clue why they ended up with priority source?03:44
Keybukthe lib/canonical/sourcerer one is when lifeless randomly checked an ancient copy in03:44
Keybukdespite there being lib/sourcerer pulled in by the config03:44
elmokiko: it's a dak thing03:44
Kinnisonkiko: bug in dak03:44
Keybukthe change kills the ancient one, and just adjusts the code to use the new Version parser (which has bug fixes too)03:45
SteveAKeybuk: i see.  the 'canonical.sourcerer' makes it clearer that it is canonical code.  but anyway...  so the code was actually using both versions, as is apparent from the imports you changed.03:45
KeybukSteveA: yup, it was confused code03:45
stubBah. fti.py is starting to take silly amounts of time to run.03:45
SteveAKeybuk: okay, r=me03:45
Keybukif we like canonical.sourcerer -- we should make a change to the sourcerer branch in rocketfuel and stuff03:45
=== stub adds optimizing fti.py to his todo
SteveAKeybuk: i think we have better things to do that relocate sourcerer right now.03:46
Keybukindeed03:46
sabdflmpt: spiv made a good review comment03:48
sabdflin all the listings i tend to use a smaller font for the summary-below-the-main-bit03:49
sabdflcan we have a class "lesser"?03:49
sabdflalso, i often have indents03:49
sabdflstyle="font-size: 80%; margin-left: 30px;" is common in these03:49
sabdflclass="lesser indented" would be nicer, or something similar03:50
sabdflthoughts?03:50
ddaa30px?03:50
ddaa3em, good, 30px bad03:50
=== ddaa like to view his web pages with ridiculously large fonts sometimes
mptsabdfl: class="lesser" already exists and already does what you want :-)03:52
Keybukyes, sabdfl: don't ever use "px" in stylesheets, m'kay03:52
sabdflmpt: ok. and the indent?03:52
Keybukuse "em" or "%" so those of us which bad eye sight can scale the pages up03:52
ddaakeybuk: border-width=1px is fine, because explorer has stupid values for logical line widths.03:53
mptsabdfl: Wanting an indent is a side-effect of not using the listing tables consistently with the rest of LP03:53
Keybukyeah, that kind of thing, and for absolute graphics alignment and stuff03:53
mptsabdfl: which I'll show you once I've got this branch landed03:53
sabdflok. i'm sceptical of the tables based approach though03:53
=== ddaa boggles
ddaacall the doctors, Keybuk and I agree on something!03:54
stubSteveA: staging is awaiting your pleasure03:56
SteveAthanks stub.  i've still got that US$50...03:56
SteveAcarlos: ping03:59
bradbkiko: Got distracted in #canonical there for a second, but I just sent the current version of the patch your way.04:07
kikook04:08
=== heyko [n=heyko@p54843B1C.dip.t-dialin.net] has joined #launchpad
SteveAkiko: it's 30 mins... how's gina looking?04:14
kikoSteveA, I'm still following the code. Kinnison, sabdfl, elmo: can you tell me which table we're duplicating data in? build or binarypackagerelease?04:16
sabdflkiko: could be both04:17
kikosabdfl, "could"? I need to know04:17
sabdflsorry, i had an imported database with examples on my laptop, but i dumped it to do normal testing04:17
sabdfldoes Kinnison's dogfood have the results of a gina run?04:18
sabdflKinnison: ping04:19
stubIIRC it was build04:19
kikookay04:19
kikosabdfl, could it be a matter of altering handlers.py:*._getBinary() to stop checking for the distrorelease?04:20
stubBinaryPackageRelease was the insert that was failing due to violated constraints04:20
kikothat's fixed04:21
sabdflkiko: i dont know gina at all04:21
kikook04:21
sabdflthat ho never felt my lovin touch04:21
stubNight ppls04:21
Kinnisonsabdfl: yes?04:22
stubSteveA will be taking Gina for a spin04:22
kikoKinnison, gimme a hand04:22
Kinnisonhmm?04:22
sabdflKinnison: kiko needs your help to debug gina04:22
sabdflspecifically, kniwing whats being duplicated04:22
sabdflnight stub04:23
bradbkiko: How does the patch look?04:23
bradbkiko: re: the priority icon, note: 1. it was mpt's idea, 2. whether it's a good thing or a bad thing, I don't know. Personally, I hate icons, unless they're extremely obvious and standard (like pencil == edit, red X == delete, etc.), but I did add title attribs to them in this patch, and also linkified them, which makes them slightly more usable.04:24
kikobradb, you need to wait for gina, but I'll give you a hint: get_sortorder_from_request() needs to loose all reference to "new-style" and "old-style" -- IOW, you should share the form variables in the request.04:25
kiko+    if request.get("orderby"):04:25
kiko+        # The old-style sorting, which is based on clickable column headers.04:25
kiko+        return request.get("orderby").split(",")04:25
kiko+    elif request.get("sort") and request.get("sortorder"):04:25
kiko+        # The new-style sorting, with a list format and dropdown sorting04:25
kiko+        # widget.04:25
kiko+        return request.get("sortorder").split(",")04:25
kikojust call everything orderby or sortorder04:25
kikoit doesn't need to be special-cased to new versus old04:25
bradbkiko: ok, question for you (i don't know the "right" answer):04:26
bradblet's say you've got the search form and you type in the search "crashes"04:26
bradbyou see a header "1 -> 15 of 15 results"04:27
bradbunderneath that, the sort widget04:27
bradbyou change the sort order, to be ordered by priority (let's say that wasn't the default) and click "Sort Again"04:27
bradbrerenders04:28
bradbthen you change it *again*, but don't click "Sort Again"04:28
kikook04:28
bradbthen you do a search04:28
bradbdo you expect the current sort order to persist, or the new one that you chose but, for whatever reason, didn't submit?04:28
kikothe new one04:28
kikowhat sort of question is that?04:28
SteveAbradb, kiko: we need to focus on gina04:28
kikowhy is there a separate "sort again" button?04:28
bradbkiko: what sort of question is that?04:29
SteveAi have 1.5 hours or so to go until i'll very much want to go home for the day04:29
bradbkiko: what did you have in mind? evil jumping screen js submits? :P04:29
kikobradb, can you put it up for me to look at in like 1h?04:30
bradbok04:30
kikoSteveA, I'm already going over it with Kinnison, ok?04:30
SteveAokay, great04:30
SteveAjamesh: are you available for a quick review?04:33
SteveAKinnison: do you have stuff for me to review?04:35
KinnisonSteveA: not yet, will have in about 20 minutes04:37
SteveAokay cool04:37
SteveAi just finished my bugfixing work04:37
KinnisonSteveA: I'm just doing some work tidying my security.cfg04:37
KinnisonIIRC someone made it possible to alter what db user was used for a doctest04:40
Kinnisonwhat does one have to do to do that?04:40
SteveAsee poimport.txt04:40
SteveAsee also launchpad/ftests/test_system_documentation.py04:41
Kinnisonta04:41
SteveAin fact04:41
SteveAthe latter is better04:41
SteveAthe former looks wrong04:41
KinnisonErm, so that has poExportSetUp04:42
Kinnisonbut what do I do?04:42
SteveAcopy what it does04:44
SteveAbut for what you need04:44
Kinnisonright, so I just create uploaderSetUp and uploaderTearDown ?04:44
SteveAso, add a set up and tear down function 04:44
SteveAyes04:44
Kinnisonokies04:44
SteveAand register it in special = {...}04:44
kikoKeybuk?04:45
Keybukkiko: ?04:45
kikoU-TURNin?04:45
Keybuk#canonical04:46
=== lamont__ [n=lamont@15.238.7.17] has joined #launchpad
jameshSteveA: sure.04:52
SteveAjamesh: actually, i reviewed the diff, and decided it was [trivial] .  but there is one part i'd like you to review even so04:52
SteveAthat is a change to the query timeout stuff04:52
jameshokay04:53
SteveAhttps://chinstrap.ubuntu.com/~dsilvers/paste/fileaFiLk0.html04:53
SteveAit concerns me because it is fragile to changes in the db connection code / database stuff04:53
SteveAi was thinking of lower()ing and normalizing whitespace before comparing the string, to make it more robust.04:54
SteveAmaybe you can think of how to write a test for it?  maybe making a direct DB connection, using the adapter, and issuing a query that makes that ProgrammingError occur, and then issuing another bogus query to check that only that error is handled with a RequestQueryTimedOut exception.04:55
jameshSteveA: I had some ideas about how to test for it04:56
jameshSteveA: we already load some custom Python functions into postgres via plpython04:56
SteveAjamesh: okay, well this code is on its way to pqm.  but i'd appreciate if you can write a decent test for it :-)04:56
SteveAi'm afraid i need to go test gina with kiko shortly04:56
jameshSteveA: so I wonder if we could add a custom function that just does a time.sleep() of a given length04:56
SteveAi see04:57
SteveAalso, i guess my error class should be RequestStatementTimedOut...04:57
SteveAyes, i think that may be the only way to make it deterministic04:58
SteveAi think a good test is a much better idea than trying to make the string-matching robust05:00
SteveAtthe consequences of not matching properly aren't too bad though -- just a SystemError rather than a nice "request timeout" error05:01
=== terrex [n=terrex@84-122-90-162.onocable.ono.com] has joined #launchpad
kikoSteveA, sabdfl: ping05:09
SteveAyep05:09
sabdflkiko: pong05:09
kikoso the issue seems to be that we are looking for binarypackagereleases that were built in the current distribution release05:10
sabdflSteveA: ok, mirrored, so mark.shuttleworth@canonical.com/launchpad--newpackageclasses--0--patch-36 passes all tests with the rest of what's in the production branches, should merge cleanly, and has all reviewer feedback05:10
sabdflkiko: don't do that05:10
carlosSteveA, pong05:10
kikoI've fixed this by changing the query to look for releases with that version and architecture in the current /distribution/05:11
SteveAhi carlos.  i had a question about some potemplate stuff, but then found out what i needed for now.05:11
carlosok05:11
carlosSteveA, feel free to ask anything you need05:11
kikosabdfl, that would avoid creating the release and the build for every distribution release after the one its source was uploaded to05:12
kikosabdfl, don't do.. what?05:12
kikobradb, https://launchpad.net/malone/bugs/328005:13
UbugtuMalone bug #3280: bug listing uses images to show priority, they lack titles Fix req. for: malone (upstream), Severity: Normal, Assigned to: Nobody, Status: New http://launchpad.net/malone/bugs/328005:13
bradboh, cool, thanks05:13
SteveAsabdfl: i'll try merging mark.shuttleworth@canonical.com/launchpad--newpackageclasses--0--patch-36 into staging05:15
kikoSteveA, sabdfl doesn't want to talk to me 05:15
SteveAsabdfl: are there any important database changes in there (other than removing some unused tables) ?05:16
SteveAsabdfl: i'm not sure how to apply such changes to staging05:17
elmohe's on the phone05:17
SteveAelmo: what's the best way to get baz to get archives from chinstrap to asuka?05:20
SteveAuse sftp as my user and use my password?05:20
=== terrex [n=terrex@84-122-90-162.onocable.ono.com] has joined #launchpad
elmoSteveA: in the short term, I guess yes05:22
SteveAok05:22
kikoSteveA, I believe I have a patch for you05:23
SteveAkiko: cool.  but we still don't know what mark's objection was05:24
kikoSteveA, note that he didn't even hear my solution before saying it05:24
kikoelmo, if he ever gets off the phone, we're waiting05:24
salgadoSteveA, do you have anything against the fix stub suggested in https://launchpad.net/products/launchpad/+bug/1612? (if not I'm going to merge it)05:28
UbugtuMalone bug #1612: Logging in from front page doesn't return to front page Fix req. for: launchpad (upstream), Severity: Normal, Assigned to: Nobody, Status: New http://launchpad.net/malone/bugs/161205:28
kikoSPEAK NOW OR SILENT FOREVER05:28
SteveAokay... on staging i merged into rocketfuel@canonical.com/launchpad--devel--0--patch-2664 the branch mark.shuttleworth@canonical.com/launchpad--newpackageclasses--0--patch-36 by star-merge05:31
SteveAthere were eight conflicts05:31
SteveAC   lib/canonical/launchpad/browser/build.py05:31
SteveAC   lib/canonical/launchpad/browser/distrorelease.py05:31
SteveAC   lib/canonical/launchpad/browser/sourcepackage.py05:31
SteveAC   lib/canonical/launchpad/database/distrorelease.py05:31
SteveAC   lib/canonical/launchpad/interfaces/sourcepackagerelease.py05:31
SteveAC   lib/canonical/launchpad/zcml/configure.zcml05:31
SteveACA  lib/canonical/launchpad/zcml/.arch-ids/binarypackagepublishing.zcml.id05:31
SteveACA  lib/canonical/launchpad/zcml/binarypackagepublishing.zcml05:31
SteveA05:31
SteveAsalgado: i think this should wait until the 'vary' header fix05:32
kikopain05:32
SteveAso, jbailey reported a problem logging in today05:32
salgadoSteveA, what's the 'vary' header fix?05:32
SteveAand going to that page was a part of the workaround05:32
SteveAif you're connecting to launchpad via a cache, or have your browser set up in a particular way, then logging in can appear not to work05:33
SteveAbecause the cache doesn't know that the page you were on has now changed05:33
SteveAthe solution involves setting the Vary header to say about cookies, and making the cookie vary under certain circumstances05:33
SteveAkiko: i'm confused by these conflicts05:36
SteveAi thought mark said he'd synced up with RF05:36
SteveAah... maybe just with production.05:36
=== camilotelles [n=Camilo@20132203203.user.veloxzone.com.br] has joined #launchpad
Kinnisonis PQM stuck?05:37
SteveAKinnison: possibly.  celso's job has been there for a while05:37
salgadoKinnison, I don't think so05:37
SteveAnope... things are happening05:38
Kinnisonnaah, looks like chinstrap is busy05:38
Kinnisonthat's all05:38
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: [r=SteveA]  landing Slave Manual Mode flag, it allows us to observe/select build job for a suspicious slave w/o stressing the whole environment. (patch-2665: celso.providelo@canonical.com)05:38
kikolol05:39
SteveAkiko: i'm undoing the merge on staging05:40
SteveAwhere's this patch i can look at?05:41
kikoSteveA, I can commit it or I can send it to you, what's preferred?05:43
kikoit contains some changes I wouldn't call conservative05:43
SteveAcan i take a look at it in Kinnison's pastebin?05:44
kikono05:44
kikoI can send you a full diff though05:44
kikoI can also isolate parts of it for you05:44
SteveAsure05:44
kikolet me baz diffify and commit then05:44
SteveAok05:45
kikoI suggest, SteveA, using baz replay05:45
sabdflhi guys05:45
kikoit's the sab!05:45
kikoman am I hungry05:46
SteveAsabdfl: rocketfuel@canonical.com/launchpad--devel--0--patch-2664 is what i have on staging05:46
kikoDST makes me hungry05:46
SteveAand i get 8 conflicts merging your branch into that05:46
sabdflkiko: that will work for now. but make sure you are using real files, not names + versions (because the ubuntu one and the debian one will be different, and gina will in due course be importing both).05:47
sabdflSteveA: python ./upgrade.py -d datebasename i think05:47
=== matsubara is now known as matsubara-lunch
kikoKinnison, do you grasp what sabdfl is telling you?05:47
kikoor rather, telling me? :)05:47
sabdflSteveA: hmm... why don't you have --production-1.37 on staging?05:47
=== bradb_ [n=bradb@modemcable033.209-70-69.mc.videotron.ca] has joined #launchpad
SteveAsabdfl: i guess stu put rocketfuel@canonical.com/launchpad--devel--0--patch-2664 on there because we're going to be rolling out HEAD05:48
sabdflwe are? shit05:48
Kinnisonkiko: he's being confused because he doesn't realise you're restricting name+version to "within this distro"05:48
SteveAwe discussed that this morning05:48
sabdflKinnison: nonetheless, gina should be using bit-for-bit comparisons, via the librarian, not relying on name guessing magic05:49
sabdflyou have no idea how broken most of soyuz was until this weekend05:49
=== zyga [n=zyga@2-mi2-1.acn.waw.pl] has joined #launchpad
sabdflits still borken, i'm sure, but in new and exciting ways05:49
Keybukrandom question ... is pqm ok?05:49
Kinnisonsabdfl: if name+version+within-distro isn't enough then we have larger and more scary problems05:49
Keybukit looks stuck05:49
KinnisonKeybuk: yeah, chinstrap was busy busy busy05:49
sabdflmost of the old brokenness was because the people who wrote it, and they are the same people behind gina, don't have a deep understanding of the data model and archive structures05:49
sabdflhere's what gina needs to be doing05:50
Kinnisonsabdfl: the archive mandates that name+version+distro is unique05:50
Kinnisonsabdfl: full stop05:50
sabdflKinnison: yes05:50
sabdflbut05:50
sabdfldebian + foo + 2.1-1 05:50
sabdflubuntu + foo + 2.1-105:50
sabdflcould be EXACTLY THE SAME SOURCEPACKAGE RELEASE05:50
sabdfland gina will import it as two entries if it makes that kind of assumption05:51
Keybuknot just that05:51
sabdflthat's exactly the kind of assumptin that created this problem in the first place05:51
Keybukubuntu warty, hoary and breezy foo 2.1-1 are the same05:51
Kinnisonsabdfl: Oh Christ05:51
Keybukand only appear once in the pool05:51
KinnisonKeybuk: yes, don't confuse the issue please05:51
Keybukbut gina tries to import it treetimes05:51
KinnisonKeybuk: We're already on that, please don't confuse the issue now05:51
Kinnisonsabdfl: I thought we were simply trying to get *Ubuntu* imported cleanly for now05:52
Kinnisonsabdfl: If you want gina fixed to work for when we import Debian *too* then we're gonna be here for longer05:52
sabdflKinnison: if there are fixes to be made, i'm trying to argue for basing the import loging on librarian file based intelligence, not on "hey this is how the thing is supposed to work" handwaving05:52
sabdflnow just listen please05:52
kikoKeybuk, I've fixed that now.05:52
kikohowever05:52
kikosabdfl is right05:52
kikoI knew this was fragile between distributions05:53
sabdflwhen importing a source package release, first step is to find out if the librarian knows about that file, and then if there is a SourcePackageRelease for it05:53
sabdflnext05:53
sabdflwhen importing a BinaryPackageRelease, do the same thing05:53
sabdflnow05:53
sabdflbinaries come in sets05:53
sabdflwe call that a Build05:53
sabdflso do an assertion check that the previously-imported-binary came from a Build that also has all the binaries you currently want to import05:54
sabdflif not HOLLER05:54
sabdfli can't think of a way to deal with that, it should never happen, so HOLLER05:54
sabdflmoving on05:54
kikosabdfl, that fix is more intrusive than what I have now05:54
sabdflnow you know that the binary you are wanting to import is already imported, and the Build for it is good. So use that previously-imported one05:55
sabdflthat is all05:55
sabdflin both cases, source and binary, its important to start from the librarian ID, which we KNOW is checked bit for bit05:55
sabdflthe extra trick that is required on the binary front is to deal with a case where for some reason something screwed up, and the previous Build was created without all the binaries, and now we are importing and are seeing extra binaries. i don't know how to deal with that case.05:56
kikoyeah, that's tricky but reasonable too05:56
sabdfli don't know for example if we ever throw binaries away05:56
kikosabdfl, do you want to review the emergency fix? I'm not suggesting to do it your way today05:56
kiko(because, if anything, SteveA needs to go to bed at some point)05:56
sabdfli don't think we should be going live with stuff constructed in an emergency fix05:57
sabdfli thought this was being worked on over the weekend05:57
sabdflso lets delay the rollout a day05:57
sabdflget it done properly05:57
sabdfltest it05:57
sabdfland go05:57
=== zyga [n=zyga@2-mi2-1.acn.waw.pl] has joined #launchpad
sabdflSteveA: do you want me to merge launchpad--0--patch-2664?05:57
sabdflor to land my stuff on HEAD?05:58
kikoI am not the best candidate for this fix because my knowledge of the librarian isn't top-notch but I can do it -- sabdfl?05:58
SteveAkiko: do it, and give spiv to review05:58
sabdflkiko: hmm... basically, i think there is an api to say to the librarian "here is a file"05:58
sabdflit then gives you a unique pointer to that05:58
SteveAsabdfl: HEAD, because we'll be rolling out some other changes that haven't quite landed yet05:58
sabdflyou can check to see if there is already a source pacakge release that points at that pointer05:59
sabdfletc05:59
sabdflSteveA: ok05:59
kikoyeah, I assume that, but I'll need to cargo-cult05:59
SteveAthe conflicts seem fairly minor05:59
SteveAbut i don't feel confident dealing with them05:59
sabdfllord knows what baz will do with this...05:59
SteveAKinnison: got something for me to review?06:00
sabdflSteveA: do you really think its a good idea to roll out HEAD? I thought stub meant that he was updating the target to TODAY's head, not HEAD-at-the-instant-he-does-it06:00
sabdflsorry guys06:00
sabdflanother06:00
sabdflcall06:00
KinnisonSteveA: Just committing now06:01
kikosheesh06:01
=== lifeless_ [n=robertc@dsl-27.7.240.220.rns01-kent-syd.dsl.comindico.com.au] has joined #launchpad
SteveAthe HEAD stub will be rolling out is meant to include some of today's landings.  for example, i have some important bugfixes at #6 in the pqm queue06:02
SteveAat #7, we have a trivial from salgado to make voting work properly06:02
SteveAthese are things that would be cherrypicked06:02
SteveAthere have been no big landings that aren't bugfixes recently06:03
SteveAso, i'm not saying 'keep your branch up to date with HEAD until it is rolled out'06:03
SteveAi am saying that the patch level of RF that will be chosen will be now + a few hours still.06:03
SteveAright after salgado's voting fixes land is a good bet06:04
kikoSteveA, I have some fixes from gneuman for voting too, so..06:04
=== Kinnison has a patch which must go in too
Kinnisonto do with queue stuff06:04
Kinnisonstub has blessed the db bits06:04
SteveAkiko: we need to be a bit careful.  if someone lands a big new feature / refactor, then we probably don't want to roll that out06:05
kikoit's not big06:05
kikoadds tests and fixes traversals06:05
SteveAsure.  i mean, don't let some big thing land between now and your landing that06:05
SteveAotherwise, it will have to be a cherrypick later06:05
kikosure thing06:06
KinnisonSteveA: I've added a branch to your queue06:07
KinnisonSteveA: it's mirroring now06:07
SteveAKinnison: do you happen to have a diff for it to hand?06:07
KinnisonSteveA: mirrored06:07
KinnisonSteveA: No, but I guess I can make one06:07
KinnisonSteveA: but I can't easily filter it06:07
SteveAdon't worry about that06:07
SteveAbut a diff would help me a lot06:08
KinnisonCan we still not trigger a run of jamesh's scripts?06:08
SteveAi don't know how to do so06:08
SteveAperhaps only james can06:08
Kinnisonright06:08
Kinnisondo we know when they run?06:08
SteveAi don't.  looking in jamesh's crontab would probably say...06:09
Kinnisonelmo: Can you tell us when jamesh's pending-reviews stuff will next update?06:09
elmo42 2,6,10,14,18,22 * * *  $HOME/pending-reviews/update-pending-reviews.sh06:10
kikosabdfl, note that I wasn't suggesting rolling out without testing -- that's what SteveA and I were going to do06:10
kikosabdfl, the difference between my fix and your suggestion is coping with multiple distributions properly, which could be done later because we are only importing a single distro today.06:11
=== WaterSevenUb [n=WaterSev@azevedo.astro.up.pt] has joined #launchpad
Kinnisonso 18:4206:11
SteveAKinnison: i need to be getting home soon.  i can, however, do the review from my laptop at home later on, if there's a diff waiting on the pending-reviews page06:12
KinnisonSteveA: well, I imagine it'll make a diff later06:13
KinnisonSteveA: so go home and look later when you've rested a bit06:13
KinnisonSteveA: btw, the waitress who most often gave me coffee at the KK over the past two weeks... was called Aiste06:13
SteveAcool.  say "labas vakaras" to her. (if it is the evening)06:14
Kinnisonwell, I'm at home again now *phew*06:14
Kinnisontwo weeks in london was too much06:14
=== Kinnison seriously doesn't like london
elmolondon's a lot more dealable when you're living, and not in a hotel06:15
Kinnisonaye06:16
KinnisonI managed to live there for a year06:16
=== Nafallo_away is now known as Nafallo
bradb_Does it make sense for zopeless code to have its MAIL FROM be our standard bounce address?06:18
KinnisonDunno, but I'm gonna need to know how to send mail zopeless fairly soon06:19
=== niemeyer giggles diffing and reverting launchpad stuff on bzr..
SteveAgiveittomenow06:20
bradbKinnison: I'll make it be our standard bounce address (I can't see that being any worse than using whatever email is being used in the From header) and if anybody whines, I can change it.06:20
sabdfllifeless_, ddaa: help06:21
sabdflslinky% baz status --conflicted                     ~/projects/ubuntu/launchpad06:21
sabdfl C  database/schema/.arch-ids/patch-25-40-0.sql.id06:21
sabdfl C  database/schema/patch-25-40-0.sql06:21
sabdfli did a --star-merge where i should not have06:21
kikosabdfl, undo is not a possibility?06:21
sabdflkiko: yes06:21
Kinnisonbradb: okay, can you then mail me with info on how to send mail when zopeless?06:21
ddaaundo barfs because of the duplicate ids06:21
sabdflthose files have just conflicted with themselves06:21
kikosabdfl, just delete the id files?06:22
sabdflcan i just move the .orig's back into position06:22
kikoand baz undo06:22
bradbKinnison: I can email you with how I /think/ it's done, if you want. :) I only know that this bit I'm looking at is zopeless-specific, because of the "if isZopeless():" block. :)06:22
ddaado as kiko says, but remove anything that looks vaguely suspect in the database/schema/.arch-ids06:23
kikothat's how I do it06:23
sabdflddaa: here's the thing. there is NO file called database/schema/.arch-ids/patch-25-40-0.sql.id or  database/schema/patch-25-40-0.sql06:23
sabdfleach of those just has a .orig and a .rej06:23
ddaafunny06:24
kikoodd indeed06:24
kikoand baz undo still fails, sabdfl?06:24
ddaaalso "baz resolved --all"06:24
ddaasabdfl: just remove all the weird stuff and "baz resolved --all", then baz undo to get right back you were before.06:25
ddaait's not even funny anymore to see it demonstrated again and a again that conflating metadata and user data is  a bad idea...06:25
bradbEmacs++ # multi-line search-and-replace that Just Works06:26
sabdflddaa: and then retry the merge? not with --star-merge? i'm *afraid* at what might conflict then06:26
Kinnisonbradb: If you can mail me that then yes, that'll be good06:26
bradbKinnison: sure, I'll do that shortly06:26
Kinnisonbradb: star06:26
ddaasabdfl: maybe if you have a patch-25-40-0.sql already, rename it before06:27
ddaayour problem sounds like a conflicting file addition06:27
ddaabut without some lengthy diagnostic, I cannot tell more...06:28
sabdflah, bugger it, i'll just rebuild the working directory06:28
kikosabdfl, I'm mailing you a diff with what I have right now06:29
kikohoping you understand the caveats06:29
sabdflkiko: i've never looked at gina, not sure i'll understand whatever you send me06:29
kikoI suspect you will06:29
=== looksaus [n=looksaus@ip-83-134-125-62.dsl.scarlet.be] has joined #launchpad
looksausI had posted a bounty on the ubuntu wiki a few months ago06:32
=== matsubara-lunch is now known as matsubara
looksausI see aigarius has migrated it to Launchpad, which is fine on its own06:32
looksausbut it's lacking some info, and formulated somewhat suboptimal...06:33
looksausonly I have no rights to edit it06:33
looksauseven if my name is mentioned inside06:33
looksauscan anyone help?06:33
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: r=salgado Seriously whack the team membership edit view, improving the way validation  is done, preserving form values when submitting, and reducing the wordiness everywhere. De-indent some main page silliness. Simplify the template by using macros. Add a test that checks the form's behaviour (patch-2666: christian.reis@canonical.com)06:34
=== azeem_ [n=mbanck@host109.natpool.mwn.de] has joined #launchpad
looksauskiko, that was a fast reply to #3285, thx!06:36
SteveAkiko, sabdfl: i'm going out for some food.  i'll be back using the laptop at home a bit later to do Kinnison's code review and any staging work that's needed then.06:37
SteveAwhere "a bit later" is in a few hours.06:37
sabdfloh baz baz baz06:39
=== azeem__ [n=mbanck@host45.natpool.mwn.de] has joined #launchpad
sabdfllooksaus: hmm... file a bug on the bounty system, assign to me06:40
sabdflthere should be a "issuer",  who can be a person, who then gets to edit it06:40
looksausk, will do06:40
Nafallowhat's decided now? dapper opens ~wednesday? :-)06:40
sabdflNafallo: looks that way06:42
NafalloI've read through some of the specs yesterday night. looks awesome :-).06:42
=== terrex [n=terrex@84-122-90-162.onocable.ono.com] has joined #launchpad
=== SnakeBite [n=SnakeBit@84.242.143.50] has joined #launchpad
=== lifeless [n=robertc@dsl-215.16.240.220.rns02-kent-syd.dsl.comindico.com.au] has joined #launchpad
ddaaSteveA: is there any way to make creating POST pagetests easy?07:04
sabdflah.07:04
sabdflstub gave out two patch-40's07:04
ddaathat's the time where the git fans giggle07:06
=== bradb & # lunch
=== terrex [n=terrex@84-122-90-162.onocable.ono.com] has joined #launchpad
kikoddaa, makepagetest.py?07:13
ddaakiko: thanks07:13
ddaain case it's not absolutely clear yet, I'm entirely clueless about launchpad devel practises07:14
kikoddaa, if I can help you in whatever way, please ask07:15
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: [trivial]  Create empty override and file lists for apt-ftparchive (patch-2667: daniel.silverstone@canonical.com)07:15
kikoddaa, remember that functional doctests are preferred to pagetests07:15
ddaakiko: you know that learning machine in Matrix... could come in handy07:15
ddaakiko: where can I learn more about what you just said?07:16
kikoddaa, we have doctests and pagetests, right?07:17
ddaaTell me more about doctests.07:18
kikopagetests operate almost exclusively on the http level07:18
kikodoctests import modules and try doing things to them07:18
kikotake a look at doc/person.txt07:18
kikoand pagetests/foaf/40-*.py07:19
ddaayou mean, that's the only difference? Just do normal doctests in a patgetest .txt file?07:19
kikoyes, that's the only difference07:19
kiko(what you described is a pagetest)07:19
ddaaI guess it's going to take some practice to know where to draw the line.07:19
kikopagetests test web pages using an http interface07:19
kikothey are what tests the templates, for instance07:20
ddaayup, of course07:20
kikonothing else can test templates (beyond trivial syntax verification)07:20
ddaaack that much, that were you test that some specific bit is there. For example that there's a "add branch" link on the product index page.07:20
ddaaor that a branch is displaying in the branch listing for a product07:21
kikoexactly07:21
kikoyou could do the latter using a functional doctest normally, though07:22
ddaawhat's not clear to me is where to draw the line for "I do not want to test this bit of code using a pagetest" when said bit of code is used solely for generating pages07:22
kikobecause that listing comes from some method in the view or content class, right ddaa?07:22
kikoddaa, maybe we can discuss a concrete situation?07:22
ddaakiko: well, right, but on still needs to test that the template for displaying the listing is correct07:23
ddaaRight now I'm reading docs.07:23
looksauswhere's the right place and time to discuss the bounty system in Launchpad (apart from Montral in the beginning of november :)07:23
ddaaI'm thinking about getting rid of the annoying-to-maintain sampledata I introduced and just fill the db from the tests07:24
looksausURL maybe?07:24
kikoddaa, I guess I normally assume that trivial page templates don't need to be tested.07:24
ddaabecause, asides from being annoying to maintain, it's also annoyingly nonsensical07:24
kikoddaa, but they should be pagetested using xx-notfound-traversals07:24
kikopossibly the right thing to do, yes07:24
kikobut sampledata helps us web QA people07:24
ddaa:) tell me more about web QA07:25
=== ddaa cannot helps talking like a Lucasfilm adventure game character
kikowe click click click till it hurts07:25
ddaawith what?07:25
kikoso if there's nothing in the database we need to do extra clicking07:26
ddaagood, better test coverage07:26
kikothat has short and long-term effects, not all of which are beneficial :)07:26
ddaahu... I guess that was the wrong answer :)07:26
kikothere's no such thing as a wrong answer07:26
kikojust bad context07:26
kikoremember that07:27
ddaaI'm thinking, maybe I could use the pagetest to create the sampledata07:27
ddaa...07:27
ddaanah... that's too circular...07:27
kikowell07:28
kikoyou can create sampledata using the web, yes07:28
kikojust make newsampledata07:28
kikoin database/schema07:28
ddaayup07:28
ddaaIt's just that I need to put my sample data on different product and person than those the pagetests use07:28
ddaaIs there some policy about that?07:28
ddaabut then, this sampledata will end up bitrotten07:29
ddaathis starts to really feel like a no-win situation :(07:30
kikothat sounds fine07:30
kikonot the rotten bitdata07:30
kikothe other part07:31
uwsPlease look at the bottom of https://launchpad.net/people/uws/+karma   Where do these "Translation Suggestion Approved" numbers come from? I've never been involved in translations via launchpad/rosetta07:31
Nafallouws: but your translations have been imported from upstream, right? :-)07:31
uwsNafallo: I do translate some GNOME modules, yes. But how does it find out it's me?  email?07:32
uwsAnother question:07:32
Nafallouws: I don't know. I've just seen the same thing happens to Christian Ros ;-)07:32
uwsif you're looking at a people/teamname page07:33
=== Nafallo is now known as Nafallo_away
uwsthere's _no_ way to view which produccts this team manages07:33
kikouws, known bug, filed07:34
ddaakiko: so is there a way to make newsampledata out of a db modified by a pagetest?07:36
kikono07:36
kikothat's a caveat07:36
kikowell07:36
kikonot directly07:36
ddaaso, there's a way :)07:36
kikoyou could grep for the http() calls in the pagetests and issue them directly07:37
kikothe test machinery has one important caveat07:37
kikoit resets the database after every story or standalone test07:37
ddaaright, that's why I asked07:38
ddaaa standalone test is one that starts with xx-, right?07:38
kikohmm07:38
kikoI guess :)07:38
bradbddaa: pagetests/README.txt should help clarify07:40
ddaakiko: so would it be right to have a doctest that contains the code used to create the sampledata, inactive, and a few functional tests to check the sampledata is indeed there?07:40
kikoddaa, that's unusual -- you'd ned to check with SteveA 07:41
ddaakiko: I have it before my eye, but it does not seem to say anything about standalone tests07:41
ddaaand when the db is reset07:41
kikowhat I said is true though07:42
ddaasure, it's just missing a definition for standalone :)07:42
ddaabah... in the short term I'll just get rid of the sampledata, I'll look for a better solution later07:43
uwsEHm07:51
uwshttps://launchpad.net/products/bazaar/+series/ng/+edit  I can edit this page07:51
uwsEven though I'm NOT in any way connect to this project07:51
kikotalk to ddaa 07:51
ddaauws: can you actually commit changes?07:52
ddaaI cannot test that, since I'm myself part of the owning team :)07:53
uwsddaa: I can07:53
uwsI just changed the . to ...07:53
ddaaArguably, that's bad...07:54
ddaakiko: can you assign one of your minions to look into the issue?07:55
kikoddaa, yes07:55
ddaathat should be a private bug, but I sort of gathered that private bugs were problematic now...07:55
kikouws, is it too much to ask you to file a bug?07:55
uwsddaa: That's really bad07:55
kikoddaa, problematic?07:56
uwsBtw, what's the way to add a URL to the tarball of a release?07:56
uwsediting a release doesn't work :(07:56
ddaakiko: like they were not visible to those who need to see it...07:56
kikoddaa, that was mostly a red herring07:56
=== ddaa files a bug
uwsddaa: Okay, so you take care of this issue for now?07:58
=== niemeyer [n=niemeyer@200.103.240.66] has joined #launchpad
=== sabdfl [n=mark@pdpc/supporter/silver/sabdfl] has joined #launchpad
=== Kinnison heads out, back later
=== auth [n=auth@fiji.grd.sgsnet.se] has joined #launchpad
authGood evening08:22
authI want to know who I should talk to about deleting an account in launchpad. I managed to create 2 accounts..08:23
salgadoauth, you don't need to delete one. you can merge them08:24
authok, that seems nice. Where in the menus should I look for that option?08:25
salgadoauth, login with the account you want to keep and then go to https://launchpad.net/people/+requestmerge08:25
sabdflevening sports fans08:26
authsabdfl: Thanks!08:31
kikoevening sabdfl 08:31
authsorry, salgado: Thanks!08:31
kikois there a way to do slices in TAL?08:32
sabdflauth: i was about to say you're extremely, defiintely, welcome08:32
sabdflkiko: nup08:32
kikosnarl snarl08:32
sabdflbe nice to do a bit more stuff in tal, like..08:33
=== azeem__ is now known as azeem
sabdfl<tal:foo repeat="bar context/bars">08:33
bradbkiko: they should work in a python: expression, shouldn't they?08:33
sabdfl  <div tal:content="context/xxx.bar">08:33
sabdflor something08:33
sabdflbradb: python: in tal is a bad bad sign08:34
sabdflalarm bells all over the show08:34
kikoit depends08:34
bradbnot always, IMHO. practicality has been known to beat purity in many cases.08:34
=== bradb watches his patch snail its way up the pqm queue
bradbWho wrote sending-mail.txt?08:41
bradbI want to give Kinnison a good example of how to send mail in LP, Zopeless. AIUI, it's identical to Zopeful, but just wanted to be sure.08:42
sabdfl(19:35:13) bradb: not always, IMHO. practicality has been known to beat purity in many cases.08:43
sabdflerrr.. that's pretty funny, Mr IUpstreamEditableBugTask08:43
sabdfl;-)08:43
bradbI knew that was crack when I wrote it. I just couldn't figure out a better way to do it at that point in team and wanted to get something working.08:44
bradbs/in team/in time/08:44
=== SnakeBite [n=SnakeBit@84.242.143.50] has joined #launchpad
BjornTbradb: i wrote sending-mail.txt. and yes, sending mail in zopeless is exactly the same as in lp. the only thing is that if you use zopeless in tests, you can't test that the mail has been sent.08:46
sabdflkiko: ok, i'll take a look at that gina patch now08:47
kikothanks08:47
sabdflis there a sane testing strategy now for whatever we come up with?08:47
bradbBjornT: presumably that's a bug (that zopeless email sending code can't be tested, if I understand you correctly)?08:48
kikosabdfl, I think there is08:49
kikosabdfl, privmsg?08:49
BjornTbradb: yeah, you could call it a bug. you can work around it, though. with the latest cronscript i wrote sending mail, i test the mail sending in a normal test environment, then i run the scripts and look for log statements that say that mails have been sent.08:51
kikompt, bradb already has a fix for that, are you trying to conflict with him?08:52
bradbkiko: has a fix for what?08:53
kikobradb, look at your mail08:54
=== bradb doesn't see anything yet
bradbKinnison: so there you have it. doc/sending-mail.txt should contain everything you need to know about sending mail Zopeless (which appears to be identical to sending mail Zopefully)08:58
=== einheit [n=steve@195.182.78.95] has joined #launchpad
ddaakiko: https://launchpad.net/products/launchpad/+bug/329209:02
UbugtuError: I cannot access this bug09:02
kikoddaa, I can't see it. can you add me and launchpad as a CC:09:04
ddaayeah... that's the problem with private bugs09:04
kikoonly if you forget to CC: people :)09:05
ddaakiko: try again09:05
bradbkiko: BTW, have you had a chance to look at the sortorder patch again? I'm dying to merge this one. ;)09:05
kikobradb, I told you my comments09:06
kikodid you address them?09:06
kikothanks ddaa 09:06
SteveA_kiko: time for some asuka action?09:06
=== SteveA_ has Weather Report playing
SteveA_yeah09:07
bradbkiko: Well, I could address them by simply deleting the code that looks for an "orderby" parameter, because the code that was using that should all be inactive now. That would mean that the table sorting would put the table code out of sync (i.e. break it), but unbreaking would mean actually making it visible again in the UI to begin with, which is a different patch not yet written.09:08
bradb"table code", i.e. the bi-directional column-click sorting09:08
kikobradb, why don't you just use the same name instead of two different ones that do the same thing?09:08
kikoI am missing some part of the puzzle I am sue09:09
kikosure09:09
kikoSteveA_, always!09:09
bradbkiko: because of the workflow that i outline in the earlier email. but you appear to say that that workflow sucks. *shrug*.09:10
kikobradb, you said you were going to post a site for me...09:10
bradbkiko: sure, i can do that now.09:11
bradbthat should make it clearer09:11
kikothanks09:11
kikoelmo?09:13
SteveA_kiko: okay.  i'm reviewing a patch for Kinnison too.  do you have some gina stuff for me to merge into staging?09:14
kikoSteveA_, yepperulas09:16
kikochristian.reis@canonical.com--lozenge/launchpad--devel--0--patch-21509:16
kikoSteveA_, you may replay up to that patch09:16
kikoyou can start with patch-20609:17
bradbkiko: http://69.70.209.33:8086/products/firefox/+bugs09:17
bradbHm, I wonder if Ubugtu just hit me there09:18
bradbEither that or kiko's fast on the draw09:18
SteveA_kiko: replay up to that patch?09:19
SteveA_can't i just merge it in?09:19
fabbionehey guys09:20
fabbionehow do we look?09:20
=== Virtuall[BZA] [i=virtuall@who.is.virtuall.info] has joined #launchpad
sabdflis PQM borked?09:29
kikoSteveA_, sure you can09:29
=== BjornT [n=bjorn@84.32.140.183] has joined #launchpad
kikobradb, I conferred with mpt09:29
kikobradb, we both agree the sort again button should go, and the optionmenu should be offered as an extra option under the search box, above the search button09:30
kikobradb, both simplifying UI and backend code. whee!09:30
sabdflSteveA: i'm ready to go, tests are all passing, and I even fixed the most embarrassing almost-bug09:30
sabdflbut... there are like NINE items in the pqm queue09:30
=== jinty [n=jinty@205.134.224.215] has left #launchpad ["Leaving"]
SteveA_Kinnison: reviewed!09:32
bradbkiko: how can it be under the search box while still being above the search button? are you suggesting some kind of three row layout?09:32
SteveA_sabdfl: pqm has been really slow today.  i think chinstrap is busy doing other stuff, and this slows pqm down.09:33
SteveA_maybe we need our own integration box...09:33
SteveA_kiko: okay, i'll try merging that new gina stuff09:33
SteveA_sabdfl: are you particularly keen to see your stuff running on staging before gina has run there?09:34
sabdflSteveA_: no, i can't see my new pages without the results of a gina run09:36
kikobradb, three rows, yes09:36
bradbouch09:36
sabdflan integration box would be good. elmo, can we have one please? dedicated box for pqm? little disk, but lots of ram and CPU?09:37
=== BjornT [n=bjorn@84.32.140.183] has joined #launchpad
bradbkiko: ok, so if i change it to look like that, and change the parameter to be named "orderby", will you pre-approve this/09:37
kikobradb, you'll notice the code gets a lot simpler!09:37
SteveA_sabdfl: i'll mail rt with that request09:38
bradbkiko: dude, it gets 2 lines of Python code simpler :)09:39
sabdflok SteveA_09:39
sabdflwith bzr, pqm will get much faster09:39
bradbkiko: which is more than made up for by the hopefully-works-everywhere .js addition you suggest :)09:39
sabdfli think it spends quite a lot of time doing the build-config, the merge, and then the commit09:39
SteveA_yes, it does09:40
kikobradb, there's no JS09:40
kikobradb, I think you are confused09:40
SteveA_and running baz-related tests09:40
sabdflwith bzr that should be down to a minute or two, total09:40
bradbkiko: oh, you don't want js, ok09:40
sabdfland a faster machine will blaze through the tests09:40
SteveA_the test suite still takes a while, but it would cut the time to 1/3 what it is, i reckon09:40
sabdflbe nice to get the whole cycle below 5 minutes09:40
kikobradb, dead-simple: optionmenu that applies to searches09:40
bradbeither way, it's exactly 2 lines of Python code simpler, FTR :)09:40
bradb(changing it now)09:41
kikominus 4 lines of comments09:41
kikoand it may become even simpler09:41
kikoI need to look at the code to see09:41
SteveA_strange... moz thunderbird doesn't have enigmail included by default in breezy09:41
fabbioneSteveA: no, enigmail is a plugin.. you nees to install it separately09:42
=== BjornT_ [n=bjorn@84.32.140.183] has joined #launchpad
=== bradb has been in the pqm queue for 1h 40m and moved from #8 to #6. ROCK ON AGILE DEVELOPMENT!
sabdfli think its wedged09:43
SteveA_stub, elmo and lifeless can unwedge it09:43
SteveA_and karl09:43
mptsabdfl: Do you see anything at http://async.com.br:8081/ ? It's the design-fascism branch09:44
sabdflZnarl, elmo, lifeless: help unwedge pqm please, if it is in fact wedged?09:44
sabdflmpt: ok, where do i look for the listing stuff?09:44
mpthttp://async.com.br:8081/ http://async.com.br:8081/malone http://async.com.br:8081/support09:45
mptthey're much more consistent now09:45
SteveA_kiko: okay, gina improvements merged with no conflicts09:45
mptthough we still have too many macros for "show me a bug listing"09:45
kikoSteveA_, cool as juice09:46
SteveA_kiko: do you have a database query you want me to run before i run gina?09:46
SteveA_or to look for one of the examples of packages?09:46
sabdflmpt: ok, +1, looks good09:48
SteveA_hurrah09:48
kikohmmm09:49
sabdflmpt: one thing - the line spacing seems to have widened a bit09:49
sabdflcould you tighten that up again plese?09:49
sabdflplease09:49
sabdflseems to be across the board09:49
mptsure09:49
SteveA_fabbione: you still around09:49
SteveA_?09:49
fabbioneSteveA: yeps..09:50
mptp {margin: 0.5em 0em 1em 0em; line-height: 1.5em;}09:50
mptthat's the badger09:50
SteveA_can you suggest any packages in main that didn't change between hoary and breezy?09:50
Lathiat~[1~[4~mpt: /malone/distros/ubuntu -> has a list heading, but the listing isnt organized in a list like that (is that intentional?)09:50
fabbioneSteveA: probably... none?09:51
SteveA_if not, in universe?09:51
mptLathiat: What does "~[1~[4~" mean? :-)09:51
fabbioneSteveA: i can try to check.. gimme a few minutes09:51
SteveA_thanks09:51
mptLathiat: bradb is fixing that bug right now09:51
sabdflmpt: nudge the badger in a more compact direction?09:52
Lathiatmpt: its the result of ssh lag and me hitting a few arrow keys and it coming into irssi in one packet and it using paste mode to write them out properly rather than interpreting them as control codes09:52
mptsabdfl: done, overridden in launchpad.css09:52
sabdflmpt: thanks. did that change in plone.css recently?09:53
fabbioneSteveA: libpam-radius-auth in universe09:53
SteveA_fabbione: awesome, thanks09:53
fabbioneSteveA: both hoary and breezy have Version: 1.3.16-309:53
Lathiatmpt: ok 09:54
fabbioneSteveA: no problem.. i knew that slacking on a package i maintain would have been somewhat useful in the future :)09:54
mptsabdfl: I don't know, I don't change plone.css09:54
mptbut the line-height was noticable in bug descriptions/comments09:54
sabdflmpt: did you change root-portlet-rosetta.pt?09:55
sabdflin that branch?09:55
sabdflit needs a <br /> after each drl barchart09:56
sabdflwhich is in my branch09:56
sabdfli think i fixed it in my branch09:56
mptsabdfl: I don't think I changed it in this branch, except that I may have added alt="" to the <img> tags09:57
sabdflok. it looks like i added a <br />09:58
sabdflif you touched those lines, its going to conflict shortly, please don't drop the <br />09:58
sabdflok, we are still jammed on pqm10:00
bradbkiko, mpt: just to be sure, how much more do you want that page to be tweaked from how I've changed it to look now?10:05
SteveA_sabdfl: i've talked with kiko about a plan for testing gina on staging.  i can't do it right now for two reasons: 1. the old gina data is still on staging, and it needs to be gone, and i don't know how.  2. it is late here and i want to sleep.10:06
kikobradb, I think mpt would like the fields aligned, but apart from that, that's what I wanted10:06
SteveA_so i'm mailing stu with the plan of what we want to do to test this, and your code, out on staging10:06
bradbkiko: how is the search button aligned?10:07
SteveA_what is the branch / patchlevel you have to try out?10:07
SteveA_(just in case it doesn't make it in to pqm shortly)10:07
sabdflSteveA_: no problem. i will review kiko's proposed gina diff tonight10:07
sabdfli don't have a katie handy10:07
sabdflwill ask elmo for a dump or something to make gina run locally, where i can test it10:07
sabdfli have pleny of space and speed on the desktop10:07
mptbradb: in the second column of a <table>, said second column containing the other controls while the first column contains their labels in <th><label>...</label></th> fashion10:07
SteveA_okay.  however, stu can straightforwardly run this on staging tomorrow10:08
sabdfli will land my code on HEAD tonight, if we can unwedge pqm10:08
SteveA_the only information i'm missing is your branch and patchlevel10:08
sabdflSteveA_ please get yourself and kiko fabulous pqm unwedging powerz10:08
SteveA_i'll ask lifeless about it10:08
SteveA_so... you're going to work on gina tomorrow, locally?10:09
SteveA_no need for running on staging by stu first thing?10:09
=== gneuman [n=gneuman@200-171-140-32.dsl.telesp.net.br] has joined #launchpad
kikohey gneuman 10:10
gneumanhey10:10
bradbmpt: mm, isn't it kind of evil to use tables to do this alignment?10:10
kikogneuman, I have a new bug or two for you10:10
gneumanok10:11
kikoI tried to merge your fixes today, but snif, overburdened by other chores, will try tonight10:11
gneumannp10:11
mptbradb: no, it's evil to use tables that don't make sense when linearized10:11
mptthis one does10:11
bradbi was of the impression that text-to-speech agents make special noises for tables, and for when a new row starts in a table, which makes table-for-layout-rather-than-for-presenting-tabular-data seem all the more evil10:13
bradbbut i'll go with what you said10:14
mptbradb: http://www.joeclark.org/book/sashay/serialization/Chapter10.html10:17
SteveA_i'm going to ask stu to do the gina / mark's branch stuff on staging anyway.  i think it's worth it, given how important this is10:17
kikoagreed10:18
kiko-afksabdfl, what's your branch name?10:19
SteveA_mark.shuttleworth@c.c/launchpad--newpackageclasses--010:20
SteveA_i guess10:20
SteveA_that's the one that is in needs-reply on the reviews page10:20
bradbmpt: my reference is Chapter 1 of http://tinyurl.com/8qyed. Jakob Nielsen's preferred CSS book, written by the two guys who invented CSS. *shrug*. :)10:21
mptbradb: If it contains a non-<table> way of achieving the same layout in real-world browsers, I'd be very interested in knowing what it is10:25
kiko-afkso would I10:25
bradbmpt: The way it looks now, is that way you had in mind?10:28
bradbs/way/what/10:29
mptno, the way it looks now doesn't have multiple rows10:30
Znarlsabdfl, SteveA,  unwedged pqm.10:30
bradbmpt: are we looking at the same /products/firefox/+bugs page? That's got multiple rows.10:31
kiko-afkmpt?10:31
bradbmpt: i.e. the page off my server you're looking at, right?10:31
kiko-afkmpt, bradb: shouldn't there be a ":" after the labels, btw?10:32
mptbradb: No, I was looking at rocketfuel10:32
bradboh10:32
mptbradb: kiko showed me your layout, I didn't notice the URL10:32
kiko-afkhttp://69.70.209.33:8086/products/firefox/+bugs?field.searchtext=&current_sortorder=datecreated&sortorder=datecreated&search=Search&advanced=&status=10&status=20&assignee=all10:32
=== bradb gets hit by Ubugtu again
bradb(i think)10:33
mptthat's good, apart from the colons10:33
kiko-afkbradb, hit by ubugtu?10:33
bradbkiko-afk: it swam all over that URL, it appears10:33
bradbagain10:33
kiko-afkubugtu? weird10:34
lifelessmoin10:34
bradbmpt: when will this "Search" button not look like a text entry?10:36
bradbi'd say that bugfix just became that much more important with this layout change :)10:37
mptDon't know10:37
mptI've still got a fair bit of dead CSS to cut out10:37
bradbok10:37
=== SteveA_ --> sleep
=== kiko-afk -> gone
bradbkiko-afk: can i land this after i finish making the UI change suggested?10:43
bradbthe only thing that really changes is 1. remove 2 lines of Python code and 2. shift around some HTML.10:43
=== Virtuall[BZA] [n=virtuall@who.is.virtuall.info] has joined #launchpad
ajmitchmorning10:51
fabbionegood night guys10:55
ajmitchbye fabbione 10:56
zygahey guys11:05
zygacan anyone check the logs11:05
zygahttps://launchpad.net/products/launchpad/+bug/316811:05
UbugtuMalone bug #3168: Public polls are broken Fix req. for: launchpad (upstream), Severity: Normal, Assigned to: Guilherme Salgado, Status: New http://launchpad.net/malone/bugs/316811:05
salgadozyga, would you try adding an option other than "Frdric Logier", but with non-ascii characters?11:07
zygasalgado: sure, no problem11:07
zygasalgado: strange - check this out11:07
zygahttps://launchpad.net/people/moturuby/+poll/elect-team-leader/+vote-simple11:08
zygaI hope you can see the same stuff as I can11:08
zygaI see 'Frederic' twice11:08
=== BjornT [n=bjorn@84.32.140.183] has joined #launchpad
zygaonce with all accents and once without11:08
dilysMerge to rocketfuel@canonical.com/launchpad--devel--0: [r=SteveA]  landing Slave Manual Mode flag, it allows us to observe/select build job for a suspicious slave w/o stressing the whole environment. (patch-2668)11:08
zygasalgado: it worked11:08
zygasalgado: I've added anothe option and there was no problem11:08
salgadozyga, okay, I guess I know what happened11:09
salgadozyga, first you added an option with the accents ("Frdric Logier")?11:09
zygayes11:09
salgadoand then it crashed?11:09
zygaactually...11:09
salgadothen you added one without the accents?11:09
zygaI've always added it with all accents11:09
zygaor maybe, no ... I did add the one without accents later11:09
zygaso: fist with accents, crash, then wihout accents, crashed11:10
salgadookay, in both cases, it didn't crash while adding the option, it crashed later11:10
salgadoso, both options were added11:10
zygasalgado: I didn't actually notice that those options were already present11:10
salgadothat's why I changed the description of the bug report. although it looked like the crash was when adding the option, the crash was actually after11:11
zygasalgado: OTOH: can you remove all options later on? I'd like to make an usefull poll in the end11:11
zygaah11:11
salgadoso, that problem is, in fact, fixed11:11
salgadothe problem you saw now, when trying to add another "Frdric Logier" is because there can't have two options with the same name11:11
salgadoit should tell you that instead of giving you a system error, though11:12
zygahmm but I didn't get any message saying 'you cannot add this'11:12
zygaright11:12
salgadoand gneuman is working on that11:12
zygagreat11:12
zygaokay I get it now11:12
zygacan you please remove all options?11:12
salgadonow, what to do with all the options11:12
salgadoI can't delete them11:13
salgadobut you can mark them as inactive11:13
salgadoI mean, the ones you want11:13
salgadoan inactive option won't show up for people to vote11:13
zygahmm11:13
zygaI cannot11:13
zygaI get system errro on each 11:13
zygahttps://launchpad.net/people/moturuby/+poll/elect-team-leader/+option/411:13
zygaand /2 and /611:13
zygasorry /3 not /211:13
zygastill something not right11:14
salgadodammit. kiko was going to merge a fix for this today11:14
salgadobut it looks like he left without merging it. :-(11:15
Lathiatwow11:15
Lathiati just realised how those buttons up the top11:16
Lathiatspread onto two lines right aligned11:16
Lathiatthats cool!11:16
zygaLathiat: ?11:16
Lathiatzyga: resize yoru window horizontaly11:16
Lathiatto about half 102411:16
Lathiaton launchpad11:16
zygaLathiat: ah, nice indeed11:17
zygaLathiat: no div, span :)11:17
ajmitchLathiat: and it gets messy as you make it smaller11:17
ajmitchI know everyone here just loves the plone.css though :)11:17
zygaplone.css?11:18
ajmitchyes11:18
zygawhat is it?11:18
Lathiatheh11:18
ajmitchthe css style11:18
Lathiatanyway, im going back to bed, laters all11:18
salgadozyga, I'll find a way to either merge that fix so you can mark the option inactive or ask someone to delete the option11:18
salgadozyga, please poke me if it's not fixed by tomorrow morning. and sorry for the trouble11:19
ajmitchbye Lathiat 11:19
zygasalgado: thanks :-)11:19
zyganp11:19
=== salgado => home
=== BjornT_ [n=bjorn@84.32.140.183] has joined #launchpad
sabdflthanks Znarl11:25
sabdflhmm... there are 4 patches from salgado in the pqm queue, from 2 different branches. i wonder if it would be possible to delete the earlier from each, snce they will then both go in together with the second in each branch. make sense? znarl, do you have the ability to do that?11:32
sabdflwe really need a web interface to the pqm queue11:32
sivangzyga: how do you start a poll for something on launchapd ?11:32
sabdflsivang: on a team, you should have a poll creation page11:33
sabdfleveryone in the team can vote11:33
zygare11:33
sivangsabdfl: ah cool , I'll check that 11:33
zygasivang: answered already :)11:33
sivangzyga: yes 11:35
=== mpt [n=mpt@200-171-140-32.dsl.telesp.net.br] has left #launchpad []
ddaaAre the passwords for the sampledata users documented somewhere?11:38
=== Kinnison [n=dsilvers@haddenham.pepperfish.net] has joined #launchpad
=== xbow [n=alex@84.17.229.6] has joined #launchpad
=== bradb heads off
=== bradb [n=bradb@modemcable033.209-70-69.mc.videotron.ca] has left #launchpad []
=== BjornT [n=bjorn@84.32.140.183] has joined #launchpad

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!