=== Nafallo is now known as Nafallo_away === khorben [n=cufk_tis@cac94-6-82-232-184-118.fbx.proxad.net] has joined #launchpad [12:38] anyway [12:38] night guys [12:52] night === tambaqui [n=patricia@200-247-68-185-mns.cpe.vivax.com.br] has joined #launchpad [01:24] who would be a good person to start to talk to about integration between launchpad and the ubuntu documentation team svn repository? [01:25] someone knows if there are still actual bounties opened? [01:26] mdke: what kind of integration? [01:26] automatic import of pos? [01:28] mdke: Or commit privileges based on launchpad team membership? [01:29] spiv, yeah that [01:29] Ah :) [01:29] jordi, pos? [01:30] oh doh [01:30] yeah [01:30] no, not that [01:30] ok [01:30] mdke: So, we have something like this for bzr coming fairly soon. [01:30] then I have no idea :) [01:30] just commit privs and such [01:30] ah [01:30] that's cool [01:31] maybe karma :D [01:31] Where every member of a team will be able to commit to bzr branches at sftp://bazaar.launchpad.net/~team-name/product-name/branch-name [01:31] spiv, we are quite slow with technology, we have to get our heads around bzr eventually and see if we can use it [01:32] And that gets republished at http://... (same url, aside from http/sftp). [01:32] mdke: Right. [01:32] if so, then that would be cool [01:32] mdke: At the moment, bzr is probably slightly rough for svn users. [01:32] spiv, got a simple guide anywhere? [01:32] mdke: But there's stuff that was spec'd at UBZ that would make it pretty friendly. [01:33] sounds good [01:34] Specs about "lockstep development" iirc, but the bzr guys will know more :) [01:34] mdke: So, it's probably a case of "not yet, but soon" for you. [01:34] Where is soon is only a month or two, hopefully. [01:35] cool === mdke goes lookin for a guide [01:35] spiv, so given that, it's probably not worth arranging any svn integration [01:37] ah the guides look comprehensive [01:38] mdke: #bzr are pretty helpful too. [01:38] thanks [01:38] Yeah, we're hoping that everyone will think bzr is better than svn :) [01:38] i need to understand the why's and wherefores of decentralised version control [01:39] i suppose there must be some projects where decentralisation is bad? [01:39] For sufficiently simple stuff, it can be a complication you don't need. === mdke nods [01:39] I think you may be in that basket, from what I've heard. [01:39] me too [01:39] Hence the lockstep development stuff :) [01:39] is there a way round that with bzr? [01:39] ah, ok [01:40] There's specs about this on bazaar.canonical.com [01:40] http://bazaar.canonical.com/LockStepDevelopment?highlight=%28Lock%29 [01:40] Or just http://bazaar.canonical.com/LockStepDevelopment [01:40] :) [01:41] yeah that sounds like what we do a lot [01:41] With that you could still use the decentralised bits if you need them, but the default mode of operation has everyone working with the same branch. [01:42] ok that sounds promising stuff [01:43] spiv, by the way do you know if that MoinMoin user.py hack of yours would work on Moin 1.3.5? [01:43] mdke: Probably -- that's roughly the version we're using, I think. [01:43] on the off chance [01:43] https://wiki.ubuntu.com/SystemInfo says 1.3.4 [01:44] yeah, same on the canonical one [01:44] Which is probably 1.3.4 + debian patches + my hack. [01:44] okay cool [01:45] spiv, thanks for your help [01:45] You're welcome. === kiko [n=kiko@200-171-140-32.dsl.telesp.net.br] has joined #launchpad === mpool [n=mbp@ozlabs.org] has left #launchpad [] === shawarma [n=sh@3E6B503C.rev.stofanet.dk] has joined #launchpad === dewd [n=dewd@201009186135.user.veloxzone.com.br] has joined #launchpad [02:33] Hmm, I can't seem to add a comment to a malone bug in the web UI using only the keyboard. [02:33] Because I can't tab to the "Add a comment to this bug" expander. [02:34] Time for shift-numlock I guess... [02:50] lifeless: I'm getting this error on a merge from rocketfuel: [02:50] bzr: ERROR: Branch /home/james/src/rocketfuel is missing revision Arch-1:rocketfuel@canonical.com%launchpad--devel--0--patch-1071 of x_Carlos_Perello_Marin__Sun_Oct__3_15:36:08_2004_9002.0 [02:51] jamesh: hmm [02:51] jamesh: I would try a reweave-branches/ [02:52] my bzr doesn't seem to have a reweave-branches command [02:53] its a plugin [02:53] checks the plugins page ;0 === jamesh checks the plugins page [02:53] so reweave my branch, or rocketfuel, or both? [02:54] reweave rocketufel yourbranch [02:54] one command === Kinnison heads off === kiko [n=kiko@200-171-140-32.dsl.telesp.net.br] has joined #launchpad === kiko [n=kiko@200-171-140-32.dsl.telesp.net.br] has joined #launchpad === stub [i=stub@sweep.bur.st] has joined #launchpad [04:32] lifeless: doesn't seem to make any difference [04:33] jamesh: garh. [04:33] let me see [04:34] the branch is /home/warthogs/archives/jamesh/launchpad/bzimport [04:34] s/bzimport/bugzilla-import/ === robitaille [n=robitail@ubuntu/member/robitaille] has joined #launchpad === khorben [n=cufk_tis@cac94-6-82-232-184-118.fbx.proxad.net] has left #launchpad ["oh] [04:57] lifeless: any ideas? [04:59] jamesh: not yet, juggling things [04:59] okay === bradb [n=bradb@modemcable033.209-70-69.mc.videotron.ca] has left #launchpad [] === Ubugtu [n=bugbot@ubuntu/member/seveas] has joined #launchpad === zerokarmaleft [n=zerokarm@ip68-12-45-133.ok.ok.cox.net] has joined #launchpad [05:51] jamesh: try a fetch-ghosts [05:51] that revision *is* in rocketfuel [05:51] (bzr log -r revid:Arch-1:rocketfuel@canonical.com%launchpad--devel--0--patch-1071) [05:52] fetch-ghosts from rocketfuel to my branch, or the reverse? [05:52] the error message claims that the revision is missing from a file in the rocketfuel branch [05:54] the "bzr log" command you gave prints a log message in both my branch and rocketfuel [05:54] oh I see [05:56] the file ID appears to correspond to database/sampledata/current.sql [05:57] lifeless: Can you please tag launchpad/devel rev 2848 as production/1.40 (or should I attempt PQM again?) [05:57] stub: I shall do so [05:58] stub: I think pqm needs some tweaks in tag, so if you have a problem do this: [05:58] sudo to pqm [05:58] bzr branch -r 2848 launchpad/devel launchpad/production/1.40 [05:58] in the pqm home [05:58] and copy that to the public copy in /home/warthogs/archives/ [05:59] Ok. In tomboy for next time. [06:05] the last commit that that pulled was [06:05] revno: 2848 [06:05] committer: Canonical.com Patch Queue Manager [06:05] timestamp: Wed 2005-11-23 22:10:04 +0000 [06:05] message: [06:05] Speed up search for shipit orders, which was causing lots of RequestTimeOuts in production. r=stub [06:05] Yup - that is the one [06:05] copying to public now [06:07] I think I was wrong suggesting category/version/branch btw. [06:08] I'll try to debug it for tuesday [06:09] that missing revision error [06:09] which way around made it work ? [06:10] stub: ^^ [06:11] The dud branch is stub/launchpad/LibrarianGarbageCollection.unmergable. You get the error message merging trunk into that branch. [06:11] Merging that branch into trunk works, however. [06:12] hmm [06:12] was it baz2bzr'd ? [06:12] Nope. Pure bzr. [06:12] funky cold medina [06:12] stub: was your error anything like mine? [06:13] Missing patch (blah blah Arch1 carlos blah blah) [06:15] jamesh: same thing [06:16] Yah launchpad/production/1.40/1.40. lifeless - You want me to nuke it and recopy ? [06:17] stub: huh? did you do it while I was ? [06:17] Nope [06:17] ... [06:20] well we have a 1.40 which has teh right tip [06:20] what do you want me to do ? [06:22] Nuke the 1.40/1.40 directory so I only have 200MB to transfer around instead of 400MB? [06:22] done [06:26] I'll look more closely at this missing revision error tomorrow [06:26] I have to go for SLUG now [06:28] Reverting... [06:28] Traceback (most recent call last): [06:28] File "./refuel.py", line 382, in ? [06:28] main() [06:28] File "./refuel.py", line 378, in main [06:28] config.buildMirror() [06:28] File "./refuel.py", line 126, in buildMirror [06:29] self.buildBranchMirror(source, launchpad=True) [06:29] File "./refuel.py", line 165, in buildBranchMirror [06:29] Branch.open_containing('.')[0] .set_pending_merges([] ) [06:29] AttributeError: '_Branch' object has no attribute 'set_pending_merges' [06:29] :-( [06:29] I'll try some work arounds later [06:29] (pull the prebuilt rocketfuel and bzr pull --overwrite on it) [06:29] erm [06:30] that looks like a mismatch in bzr [06:30] are you using the bzr from sourcecode/rollouts ? [06:30] because it definately does not do that [06:30] ok - could me my cut&paste revert implementation in refuel.py - I'll do it manually [06:31] Yes - that is it. My problem. [06:34] code in refuel should use the bzr in the lp tree I think [06:34] does that make sense to you? [06:34] Yes - I'll invoke it using subprocess. It was previously using cargo culted code from bzrlib's revert command [06:35] thats not -quite- what I meant [06:35] I mean, it can either subprocess, or it can use the bzrlib library from sourcecode/bzr [06:35] but it cant use a random system one, bzr is moving too fast [06:36] Refuel can't use bzr form the lp tree, because its function is to *build* the lp tree. That is what rollouts/bzr.integration is to avoid (?) [06:36] isn't refuel to *update* the lp tree? [06:37] Unless I start by rsyncing the prebuild rocketfuel tree and working back from there. [06:37] thats what it was before [06:37] It does both. [06:37] then it should be *in* the lp tree, surely? [06:37] It is in the configs tree [06:37] ah [06:37] Anyway - go to SLUG. I have enough to work with for now. [06:38] lifeless: re: your mail to launchpad-devel, will the sftp paths passed to pqm have to change like the ones to bzr are changing? [06:38] jamesh: hmmm ? [06:38] i.e. sftp://chinstrap.ubuntu.com//home/warthogs/archives/login/launchpad/branch instead of sftp://chinstrap.ubuntu.com/home/warthogs/archives/login/launchpad/branch [06:38] presumably [06:38] I should check that spec, as I think that that is a very dubious thing [06:39] section 2.2 of http://www.ietf.org/internet-drafts/draft-ietf-secsh-scp-sftp-ssh-uri-03.txt [06:39] It would be nice if we can shorten those URLs sometime - the '/home/warthogs' bit could go with the simple addition of a symlink in chinstraps root directory [06:39] later, byte [06:48] so the arch patch log for rocketfuel@canonical.com/launchpad--devel--0--patch-1071 doesn't actually modify database/sampledata/current.sql [06:48] weird [07:06] I'm off for an hour or three. === robitaille [n=robitail@ubuntu/member/robitaille] has joined #launchpad === raketti [n=kikkeli@a84-230-189-48.elisa-laajakaista.fi] has joined #launchpad === StevenK [n=stevenk@14.5.233.220.exetel.com.au] has joined #launchpad === zhavick [n=syafiq_s@202.155.90.29] has joined #launchpad === zhavick [n=syafiq_s@202.155.90.29] has left #launchpad [] === Keybuk [n=scott@descent.netsplit.com] has joined #launchpad === lbm [n=lbm@cpe.atm4-0-1301006.0x50a0824e.vgnxx6.customer.tele.dk] has joined #launchpad === sabdfl [n=mark@ubuntu/member/pdpc.silver.sabdfl] has joined #launchpad === carlos_ [n=carlos@81.Red-83-49-60.dynamicIP.rima-tde.net] has joined #launchpad [09:56] morning [10:11] morning === stub [i=stub@sweep.bur.st] has joined #launchpad [10:13] hi stub [10:15] SteveA: Hi [10:17] i skimmed the channel scrollback. was there some stuff about xmlrpc interfaces earlier? [10:23] lifeless, SteveA: http://www.linux.com/article.pl?sid=05/09/23/1954240 [10:23] linux softphones [10:26] SteveA: Not when I was online [10:29] carlos: hello [10:29] SteveA, hi [10:30] Launchpad will be going down in 30 mins. Downtime estimate is 45 mins total. [10:30] i just looked over your code review responses, and i'll make a full reply when you send me the new diff. [10:30] carlos: can we look into the pending plural forms and country languages? [10:30] i think if you use "return None" rather than "raise NotFoundError" in the places I pointed out, it will result in less code, and less complex code overall. [10:31] jordi, as soon as I finish with UploadTranslations review I will do it [10:31] jordi, don't worry ;-) [10:31] k [10:31] that is, there isn't any point in raising NotFoundError in database code if you always catch that error and use some other value in other code [10:31] SteveA, ok [10:31] __getitem__ should always raise NotFoundError [10:31] because NotFoundError is a subclass of KeyError [10:32] and __getitem__ has a contract that says it raises KeyError if it is not found [10:32] (actually, the mail libraries in python break this, and it is confusing because of that) === \sh [n=shermann@ubuntu/member/backslash-sh] has joined #launchpad [10:37] <\sh> morning [10:38] hello \sh [10:40] <\sh> guys...is there any way to have a global ML for all bugreports coming into malone...no matter which product and which person/team is assigned to a product [10:40] maybe. what would it be for? [10:42] <\sh> but only bugs, which are affecting one distro (as add) [10:42] <\sh> to have a similar functionality like bugzilla === koke [n=koke@ubuntu/member/koke] has joined #launchpad [10:43] you want to be able to subscribe to all new bugs filed on a particular distro? [10:43] <\sh> as an example: affects /distros/ubuntu/ace where ubuntu is the distro, ace the package/product...but the mail is now only received or send out to the assignee [10:43] <\sh> yes [10:44] so, this list wouldn't get changes in those bugs or resolutions to those bugs [10:44] <\sh> SteveA: well..this should be implemented := [10:44] <\sh> :) even [10:44] i'm trying to understand exactly what you're asking for, and what it could be used for [10:45] <\sh> right now I'm only able to see changes to a bug report, when the assignee has a ML for the bugreports (e.g. universe-bugs for the MOTU team) [10:45] sometimes, making launchpad send mail is the answer. sometimes, this reveals something that launchpad itself should offer that isn't necessarily mail. [10:46] <\sh> but if someone else (an individual) is assigning the bug to himself, only the assignee and requestor are seeing the changes..but nobody else (via mail) [10:47] <\sh> I would like to see such a feature like sending out emails for all new reports, changes and all status changes towards a global distro specific ML or email address... [10:47] \sh: bradb is working on https://wiki.launchpad.canonical.com/InitialBugContacts, that should cover your use case [10:47] okay, i understand what you're asking for now. [10:47] <\sh> regarding all bugs filed against a distro product [10:48] https://wiki.launchpad.canonical.com/InitialBugContacts does this, as BjornT points out. Although, it is for all bug traffic. [10:49] if you just wanted new bugs, you'd have to filter it at the mail-receiving end. [10:50] \sh: the bug contact for ubuntu will probably be ubuntu-bugs, which will receive all the notifications, so you would have to subscribe to that ml and filter out the ones your interested in. [10:50] <\sh> so reading this spec...it should work like this: distro X has several bug contacts (means teams in LP) and I can assign the teams as bug contacts..the team itself has a ML for email support [10:50] carlos: as to returning SelectResults, we do it quite a lot. The main problem with doing so is that SelectResults is a very broad interface, and hard to use in unit tests. But it works out okay in general. [10:51] SteveA, is there any problem if I leave the code as it is? or do you prefer the SelectResults? [10:52] \sh: well. a distro only has one bug contact (but that will probably be a ml you can subscribe to). then each source package in the distro can have a bug contact as well. === ddaa [n=ddaa@nor75-18-82-241-238-155.fbx.proxad.net] has joined #launchpad [10:53] carlos: it should be simpler to just return the SelectResults. and simpler code is easier to maintain. [10:53] <\sh> BjornT: ok..I'm asking because e.g. ubuntu is splitted in 2 halfs, main and universe, and I don't want to subscribe to two or more MLs :) [10:53] \sh: the long term plan is that you should be able to subscribe to distribution and package bugs in launchpad itself, but we don't have time to implement that at the moment. [10:54] SteveA, ok [10:54] it should be possible to filter based on component [10:54] if the email has the component in it [10:54] \sh: well. you'll only have to subscribe to ubuntu-bugs, it will receive both main and universe bugs [10:54] and i see that it does [10:54] <\sh> BjornT: cool :) [10:54] in X-Launchpad-Bug [10:54] in that header [10:54] <\sh> thx for all the informations :) [10:55] np, happy to help [10:58] btw, is it possible to get a list of all open bugs I'm currently subscribed to? [10:59] stub, how could I know from a pagetemplate if there are error messages in the notification queue after using BrowserNotificationMessages ? [10:59] stub, request/getNotifications ? [11:05] siretart: not at the moment, but soon. bug 4788 is reported about this, and it's in pending upload state, so the fix is waiting to be rolled out. [11:05] Error: Could not parse data returned by Malone: Connection to Malone bugzilla failed: HTTP Error 503: Service Unavailable [11:06] BjornT: cool. and thanks! === camilotelles [n=Camilo@20132194128.user.veloxzone.com.br] has joined #launchpad [11:31] carlos: Yes - that would work. webapp.interfaces.INotificationRequest and INOtificationResponse for the API [11:32] (sorry - sound was off again) [11:33] carlos: But it isn't designed for message passing, so you might want to consider storing your status flags elsewhere rather than attempting to parse and understand the notifications [11:33] stub, ok [11:33] stub, I just need to know if there was any error or not [11:33] carlos: Just because there is a notification, doesn't mean there is an error. [11:33] so I thought that perhaps the new system has a way to know that [11:33] yeah [11:33] I know [11:33] I will use my own flag then [11:34] with old code I check if the 'alerts' list was empty or not [11:34] stub, thanks [11:39] stub: the interfaces should really be in interfaces/launchpad.py === Nafallo_away is now known as Nafallo [11:57] launchpad is back up [11:58] yay === ajmitch was waiting to lookup some bugs :) [11:59] ajmitch: did you DO IT? [12:01] need to merge in a patch before I upload! [12:01] cooome on man === matsubara [i=matsubar@200-171-140-32.dsl.telesp.net.br] has joined #launchpad [12:13] good morning! [12:14] hi diogo [12:14] stub: what things should go in a launchpad development deb that shouldn't go on a production server one? [12:15] stub: um... ctags, vi, gnu id tools, submit to pqm scripts === SteveA was joking about vi === gneuman [n=gneuman@200-171-140-32.dsl.telesp.net.br] has joined #launchpad === salgado [n=salgado@200-171-140-32.dsl.telesp.net.br] has joined #launchpad === niemeyer [n=niemeyer@200.138.37.140] has joined #launchpad === GoRoDeK [n=gorodek@p5083D57C.dip.t-dialin.net] has joined #launchpad [12:28] SteveA, dude, after all changes I'm doing you will need a new full review... === LarstiQ [n=larstiq@cust.7.157.adsl.cistron.nl] has joined #launchpad === cprov [n=cprov@200-171-140-32.dsl.telesp.net.br] has joined #launchpad [12:34] carlos: that's fine. it should be a straightforward review, with lots of familiar code. [12:35] you're doing important work. [12:35] i'll review it for you as soon as you're ready. [12:37] SteveA, I know, don't worry [12:38] it's just that I'm changing many code at the same time I'm changing the methods [12:38] not a big deal ;-) === cprov -> good morning people === sssss [n=wafiq23@61.94.173.237] has joined #launchpad === heyko [n=heyko@tor/session/x-4ca27d52cba2b774] has joined #launchpad [12:46] SteveA, running tests [12:46] SteveA, should I sent the diff directly to you or with the answer to last review ? === thisfred [n=thisfred@a80-127-80-154.adsl.xs4all.nl] has joined #launchpad [12:50] Morning cprov, morning everyone [12:51] mornig niemeyer [12:51] niemeyer: moning gustavo, how is it going with grumpy ? [12:53] cprov: Slowly and constantly :) [12:54] niemeyer: right, did you set your local buildfarm ? [12:54] cprov: Is the plan for changing the soyuz build system for hct still up? [12:55] cprov: Nope.. still mirroring, and I've spent some time helping David with some bits this week as well [12:55] niemeyer: in thesis, yes, but practically speaking, we are way busy til soyuz production [12:56] cprov: And what does it mean, in practice? :) === carlos workraves [12:56] carlos: it is easier for me if you send the answer to me and the reviews list, and send the new diff directly to me [12:57] niemeyer: I see, mirroring is painfull, since you get the stuff in a hard drive you need to protect them as you protect your child ;) [12:57] SteveA, ok [12:57] niemeyer: how did things go yesterday? [12:57] niemeyer: the plan is not up for this year :( [12:57] SteveA: Quite good.. 9.4 out of 10.. I just have to fix a few bits in the paper to keep the grade. [12:58] cprov: And when do you see yourself starting to work on it, and finishing it? [12:59] niemeyer: sounds good :-) [01:00] SteveA, also, you want a diff against my previous code or a diff against rocketfuel? [01:01] niemeyer: huuu, hard to say, in fact, no schedule was done for it yet and the priority is low, IMO any ETA I can give you would be blue sky idea, sorry [01:01] SteveA: Yeah.. but what is really good is getting over that step. I wasn't looking for a nice grade like that even.. getting over it is the biggest prize.. :-) [01:01] niemeyer: how much does it affects you and grumpy ? [01:01] carlos: there was a lot to change. can you send me both? [01:01] sure [01:01] One year writing something is.. erm.. boring.. [01:02] cprov: Let's say that without this Grumpy doesn't exist :) [01:03] cprov: We'll have to change that priority somehow, to put it on schedule [01:04] niemeyer: I see, jump to ##soyuz1.0, let's sort it out (if you have time now) [01:07] SteveA, ping [01:07] hi salgado [01:08] SteveA, I'm having some problems with ShipItReports. do you have some time to talk about it? (should be quick) [01:09] okay. can we talk in 10 mins time? [01:09] sure [01:09] is there any code you want me to look at? [01:09] or is it a design issue? [01:10] SteveA, I think it can be considered a design issue. [01:10] ok [01:21] hi salgado [01:21] talk here okay? [01:24] sure [01:24] maybe not [01:24] okay. #c-m [01:24] SteveA: PostgreSQL 8 and friends and any setup scripts [01:26] salgado: If shipitreports gives you trouble, punt it to me. I can throw it together with psql and cron fairly easily which will keep people happy. === stub goes back to TV [01:27] stub, is it possible to get csv filed out of cricket? [01:28] salgado: cricket isn't really suitable for this. psql can spit out csv if you ask nicely though. [01:28] stub: can you talk with mdz (email perhaps) about what should go in what launchpad dependency packages to make it useful for you to use in production? [01:29] SteveA: I can't use it in production - I can't install debs. This would be for elmo/Znarl [01:29] yeah [01:29] but, how often do these things change? [01:30] and when they do, getting admins to install a deb is a nice way to do it [01:30] and to update a dev [01:30] deb [01:30] Enough that nearly every time we setup a new box something is missing ;) [01:30] so a deb would help [01:30] yes [01:31] I'll talk to mdz anyway - it is pretty obvious what is dev and what is base [01:31] ok [01:31] i'd like to get the ctags and idtools in a development package [01:31] basically, get all recommended tools in one place for developers [01:33] SteveA: I started writing the announcement for the import policy last night [01:33] I want to run it through carlos and you before sending to the list though [01:34] jordi, URL to the annoucement? [01:36] carlos: scp://nubol/Mail/postponed :) [01:36] ie, not yet :) [01:36] ok [01:36] :-) [01:41] elmo: can you please email myself and cprov with how to get at the uploads on rockhopper for testing the launchpad uploader? [01:42] stub, .... where is the getNotifications implementation? [01:42] stub, I'm able to see the interface, but I don't find the implementation [01:42] stub, I have a test that uses "from zope.publisher.browser import TestRequest" [01:43] and I need to get the notifications that the test produced [01:44] and If it's possible, I don't want to add my own boolean variable in this case as it's only needed to run the tests... [01:50] jamesh: did you get the "turn mail off on bugzilla import" thing sorted? === lbm [n=lbm@x1-6-00-13-10-7a-d1-e4.k233.webspeed.dk] has joined #launchpad [02:11] SteveA: i've braindumped the implementation part in https://wiki.launchpad.canonical.com/LaunchpadFormLayout, could you take a look at it and see if it makes sense, or if we should try to do it in some other way? [02:12] carlos: I don't think it is possible except as a page test - brad was looking into it. [02:12] BjornT: can you ask me for feedback on it using launchpad? [02:12] SteveA: sure [02:12] ta [02:12] stub, ok, then I need to reduce the test checks removing the info message check and relay on the database changes... [02:13] carlos: But I still suspect you are going about the problem the wrong way - remember that other code might start adding notifications too that you don't control [02:13] eh? [02:13] stub, it's a test that Is checking the "the submit worked, thanks" message [02:13] using the old way to do notifications [02:13] is not a new test [02:14] and I'm trying to adapt it without rewrite it completely [02:14] It should be a page test really. [02:14] we already have such page tests [02:14] Just because you used to set the alerts list doesn't mean it was ever displayed ;) [02:14] so I suppose I can leave the other tests and just remove the info message test [02:15] The implementation is in webapp/notifications.py anyway. Brad might have had some success looking into this - ask him when he is online [02:16] It would be possible to do the test as you describe, but needs more infrastructure to wire it up. [02:16] (extend the TestRequest, adding a stub implementation of the notifications machinery) [02:17] Which wouldn't be hard really - it doesn't need to actually work or propogate the messages - just store them where tests can look [02:18] Feel like extending TestRequest and making it implement INotificationRequest enough for your test to work? [02:18] It would just need to stuff the arguments in a list where your tests can inspect them [02:20] stub, I suppose that would work... [02:20] I will take a look after lunch [02:22] stub, hmmm the implementation lacks the getNotifications method [02:22] stub, but I suppose it's the same as getting the notifications property, right? === Seveas [n=seveas@ubuntu/member/seveas] has joined #launchpad [02:23] Oh - looks like that should be removed. notifications is a property [02:25] But I doubt accessing the real implementation in your tests will work, because the session machinery won't be hooked up. Anyway - a mock implementation is fine. [02:25] stub, I was just noting that the interface and the implementation was out of sync, I don't think I will use it ;-) [02:31] ok :) [02:31] Feel free to remove the unused method from the interface while you are there. [02:32] ok [02:32] stub, should I update the spec? === carlos -> lunch [02:33] I don't know. The spec is implemented, and I don't think we bother to keep them in sync with future code changes. [02:34] stub, well, the spec is supposed to reflect the implementation... [02:34] anyway, will talk about that later [02:34] lunch time! [02:43] kiko: Looks like the gina run finished 5 hours ago. [02:43] that's not bad news, thanks stub [02:44] stub, mdz, Kinnison: gina run 100% successful. [02:44] SteveA, did you get my emails from yesterday? [02:47] i got some emails from you yesterday [02:48] thanks. I'm concerned about getting the show on the road [02:48] SteveA, also, could you formalize the "catching exceptions" thread into a FAQ of sorts? [02:49] kiko: project G ? [02:50] SteveA, well, that one I'm scratching my head about. but the other ones, related to soyuz [02:50] i just had part in a discussion about hct and soyuz infrastructure with niemeyer, Kinnison and cprov. cprov is summarizing, and will mail you a summary. [02:50] okay, cool [02:51] niemeyer, what's on your plate at the moment? [02:51] there are other soyuz things of course === SteveA goes for lunch [02:54] kiko: the summary will be delayed for 14:00[BRT] , I'm still working on it === cprov lunch [02:54] sure === mgalvin_ [n=mgalvin@host-66-202-95-170.spr.choiceone.net] has joined #launchpad === matsubara is now known as matsubara-lunch [03:13] kiko: I was (am) away for lunch.. sorry.. [03:13] sure [03:13] kiko: No outstanding individual tasks for the moment [03:13] so what are you looking at starting today? :) [03:13] kiko: Planning to have a look at soyuz [03:13] hmmmm [03:14] may I interest you in some soyuz work? [03:14] kiko: Btw, I have a system that redirects personal messages as SMS to my mobile phone when I'm out [03:14] kiko: Was quite funny to get "what's on your plate at the moment?" in the restaurant. :-) [03:15] kiko: Sure [03:15] heh :) [03:15]