| === dsas [n=dean@host81-129-229-196.range81-129.btcentralplus.com] has joined #launchpad | ||
| === SkyTalker [n=michael@p549D96B5.dip0.t-ipconnect.de] has joined #launchpad | ||
| === ubuntu_ [n=ubuntu@r2m7.chello.upc.cz] has joined #launchpad | ||
| === SkyTalker [n=michael@p549D96B5.dip0.t-ipconnect.de] has left #launchpad ["bye] | ||
| === pinhanarcat [n=pac@85.96.208.206] has joined #launchpad | ||
| BenC | any chance you guys can make it so that when adding a comment to a bug, that after it takes in the info, it redirects back to the bug? | 01:09 |
|---|---|---|
| BenC | As it is now, I have lots of duplicate comments coming to me because folks don't know that after adding a comment, hitting reload sends the same comment | 01:10 |
| === cprov [i=cprov@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| === spiv_ [n=andrew@218-214-66-203.people.net.au] has joined #launchpad | ||
| === niemeyer [n=niemeyer@200.103.242.131] has joined #launchpad | ||
| === pinhanarcat [n=pac@85.96.208.206] has left #launchpad [] | ||
| === mpt [n=mpt@198.142.90.109] has joined #launchpad | ||
| === LeeJunFan [n=junfan@adsl-69-210-207-5.dsl.klmzmi.ameritech.net] has joined #launchpad | ||
| === rpedro [n=rpedro@87-196-47-173.net.novis.pt] has joined #launchpad | ||
| === stub [n=stub@ppp-58.8.2.92.revip2.asianet.co.th] has joined #launchpad | ||
| === tambaqui [n=tambaqui@200-183-98-244-mns.cpe.vivax.com.br] has left #launchpad [] | ||
| lifeless | hihi | 06:34 |
| jamesh | hi lifeless | 06:48 |
| === dsas [n=dean@host81-129-229-196.range81-129.btcentralplus.com] has joined #launchpad | ||
| === glatzor [n=sebi@ppp-62-245-208-121.mnet-online.de] has joined #launchpad | ||
| === spiv [n=andrew@218-214-66-203.people.net.au] has joined #launchpad | ||
| SteveA | morning | 08:39 |
| === benzai [n=zaheda@82-71-18-29.dsl.in-addr.zen.co.uk] has joined #launchpad | ||
| === rpedro [n=rpedro@87-196-7-188.net.novis.pt] has joined #launchpad | ||
| === Kinnison [n=dsilvers@spoo.flarn.net] has joined #launchpad | ||
| === carlos [n=carlos@13.Red-88-15-198.dynamicIP.rima-tde.net] has joined #launchpad | ||
| === purple [i=purple@80.74.172.29] has joined #launchpad | ||
| purple | hi guys | 09:59 |
| purple | im first time here brought by registration for shipit.ubuntu | 09:59 |
| purple | can u tell me what is major point of this chanell? | 10:00 |
| SteveA | hello | 10:02 |
| SteveA | this channel is where we discuss launchpad.net | 10:02 |
| purple | hm.. | 10:03 |
| purple | can u be mora specific? | 10:03 |
| purple | im not really into it so.. | 10:03 |
| SteveA | i'll need a more specific question than that | 10:03 |
| purple | what is launchpad.net? | 10:03 |
| SteveA | https://launchpad.net/ | | 10:03 |
| purple | thnxx | 10:03 |
| purple | as far as i get it | 10:04 |
| purple | launchpad is some for bug tracking thing? | 10:04 |
| purple | correct me if i wrong | 10:05 |
| SteveA | launchpad is about bug tracking, making translations of software, support tickets, that kind of thing | 10:06 |
| purple | yeah | 10:06 |
| purple | u use ubuntu i supose? | 10:06 |
| === malcc [n=malcolm@host81-159-193-176.range81-159.btcentralplus.com] has joined #launchpad | ||
| SteveA | i do | 10:09 |
| purple | which kernel build ubuntu 6 use? | 10:09 |
| Ubugtu | Ubuntu bug 6 in gdb "gdb package contains non-free GNU FDL documentation" [Normal,Resolved: notwarty] http://bugzilla.ubuntu.com/show_bug.cgi?id=6 | 10:09 |
| SteveA | i have no idea | 10:09 |
| SteveA | i just use ubuntu | 10:09 |
| SteveA | i don't develop it | 10:09 |
| purple | ok but as a distro user | 10:09 |
| SteveA | #ubuntu is a good channel for that question | 10:09 |
| purple | oh.. | 10:09 |
| purple | thnxx | 10:09 |
| === ddaa [n=ddaa@nor75-18-82-241-238-155.fbx.proxad.net] has joined #launchpad | ||
| === doko_ [n=doko@dslb-088-073-101-034.pools.arcor-ip.net] has joined #launchpad | ||
| === purple [i=purple@80.74.172.29] has left #launchpad [] | ||
| ddaa | lifeless: ping | 10:34 |
| ddaa | mpool: ping | 10:35 |
| lifeless | ddaa: pong | 10:35 |
| ddaa | lifeless: hello, can you reply to my mail about cscvs and targetBranchName | 10:35 |
| ddaa | I looks like an easy decision, but I do not want to start putting time in it before I have your green light | 10:36 |
| lifeless | ddaa: change it from a branch name to a url or revision id or something I think | 10:36 |
| ddaa | lifeless: I think it would make sense to remove -b from the UI, and have the API get the branch from the tree | 10:37 |
| lifeless | the branch matters because the data about defaults may be in a different branch to the rtarget - unless you are removing the current support for multiple-branches | 10:37 |
| ddaa | what current support for multiple branches? | 10:37 |
| ddaa | what defaults? | 10:37 |
| ddaa | I thought it was just about reconciling the catalog with the cscvs metadata for imported revisions | 10:39 |
| lifeless | the default branch in cvs is the freaky-deaky unversioned support for where 'HEAD' actually is. | 10:39 |
| ddaa | you mean cvs branches then? | 10:39 |
| lifeless | yes | 10:39 |
| mpool | ddaa: hello? | 10:40 |
| lifeless | so the option to totla is used to figure out where this changed in the past so that catalog building works correctly. | 10:40 |
| ddaa | mpool: clan sent me an email saying sabdfl wanted me and Keybuk at the bzr sprint and that you would tell me more about it today | 10:40 |
| mpool | ddaa: yes; how would you feel about coming here for say tues-thurs? | 10:40 |
| ddaa | mpool: last I and SteveA heard about it, I was not to come at the bzr meeting with the hg guys | 10:40 |
| mpool | yes, that's after the meeting with hg, but with some bzr people | 10:41 |
| lifeless | this branch will be different to the tree we are importing into when the tree we are importing into is new, but there is an import of HEAD | 10:41 |
| mpool | including jelmer, abentley, jam | 10:41 |
| === ddaa tries to make sense of lifeless | ||
| ddaa | lifeless: do you mean that catalog creation depends on cscvs metadata in revisions that are not part of the ancestry of the branch we are importing into??? | 10:43 |
| lifeless | it can, but if we only care about HEAD that stops being an issue. | 10:44 |
| ddaa | mpool: remind me where and when, exactly, please | 10:44 |
| ddaa | lifeless: I thought non-MAIN branches must be imported in a target whose ancestry was filled with MAIN up to the "branch point" | 10:45 |
| ddaa | lifeless: so if I understand correctly, we only care about the ancestry of the target... Where am I wrong? | 10:46 |
| lifeless | could be right | 10:46 |
| lifeless | if you think you are please go ahead, I am in the hg meeting now and have no cycles spare | 10:46 |
| ddaa | in other words, what is the use case for specifying a branch to scan that's different from the target? | 10:46 |
| ddaa | lifeless: I really need your help for that, you are the only one to understand this filler revision stuff | 10:47 |
| ddaa | actually, you are the only one to understand cscvs catalog creation | 10:49 |
| Kinnison | spiv: ping? | 11:07 |
| === tarzeau [n=tarzeau@80-219-67-157.dclient.hispeed.ch] has joined #launchpad | ||
| === Znarl [n=karl@bb-82-108-14-161.ukonline.co.uk] has joined #launchpad | ||
| tarzeau | is the launchpad web form broken? | 11:25 |
| tarzeau | how can i check if my submission worked? | 11:25 |
| tarzeau | i've used links2 to submit, it works with all other webforms (like gmail.com, freshmeat etc) | 11:26 |
| tarzeau | i went to https://launchpad.net/token/srB0r1lmZGMD994K36sZ and landed on https://shipit.ubuntu.com/myrequest | 11:26 |
| === fabbione [n=fabbione@217.205.109.249] has joined #launchpad | ||
| === mdz [n=mdz@217.205.109.249] has joined #launchpad | ||
| === siretart_ is now known as siretart | ||
| === Seveas [n=seveas@ubuntu/member/seveas] has joined #launchpad | ||
| stub | tarzeau: We need more of a hint - Launchpad has literally hundreds of forms. It sounds like you have successfully created an account via https://shipit.ubuntu.com. Was that what you were trying to do? | 11:54 |
| === benzai [n=zaheda@82-71-18-29.dsl.in-addr.zen.co.uk] has joined #launchpad | ||
| tarzeau | stub: ubuntu 6.06 thingy | 12:09 |
| === Kamping_Kaiser [n=kgoetz@ppp218-91.lns1.adl2.internode.on.net] has joined #launchpad | ||
| tarzeau | stub: i also wanted to order the 8,1,1 cd's | 12:09 |
| tarzeau | when i tried to open that url i gotten by mail in another browser it didn't work anymore | 12:09 |
| BjornT_ | SteveA: i want to bring in some bugfixes to testbrowser. should i bring in only the specific revisions that fix the bugs, or is it ok to bring in all changes made to testbrowser since our copy of it? | 12:15 |
| SteveA | i think it's okay to bring in all changes, assuming our tests continue to pass | 12:17 |
| BjornT_ | cool, i'm quite sure they will pass, nothing major has changed. | 12:18 |
| BjornT_ | does commits to the zope3 tree cause launchpad tests to be run? | 12:18 |
| SteveA | i don't know | 12:18 |
| BjornT_ | lifeless: ^^^^ | 12:18 |
| === SkyTalker [n=michael@p549DB33E.dip0.t-ipconnect.de] has joined #launchpad | ||
| lifeless | spiv was reenabling that and has done so IIRC. | 12:43 |
| Kinnison | stub: Any idea when the librarian will be upgraded to fully support md5sums? | 12:45 |
| Kinnison | stub: There appear to be a large bunch of rows in libraryfilecontent still missing their md5sums | 12:45 |
| stub | There is probably a script I'm supposed to run or something | 12:46 |
| Kinnison | Can you bug spiv about it? | 12:46 |
| Kinnison | I was kinda expecting it to have been done by now | 12:46 |
| stub | scripts/migrate-librarian-content-md5.py seems to be the trick | 12:52 |
| stub | Might take a while though... | 12:52 |
| Kinnison | better to get it going now then I guess | 12:52 |
| stub | Yup | 12:52 |
| Kinnison | Anyone know when the brazilians are due? | 01:10 |
| carlos | stub: hi, do you have time for a fast review of a DB patch? | 01:15 |
| ddaa | I pity the reviewers that will go over the miles of non-semantic cleanups for cscvs I'm doing... | 01:16 |
| ddaa | otoh, thanks to advanced merging, I can keep semantic changes separate | 01:17 |
| Kinnison | :-) | 01:17 |
| carlos | stub: It's one of the changes that need to be merged into production to open Edgy | 01:19 |
| ddaa | Kinnison: I could go on for a while, about how I'm learning about the various degrees of lint-cleanness of python code | 01:19 |
| ddaa | starting from "hey, that stuff could not POSSIBLY work" | 01:20 |
| Kinnison | ddaa: heh | 01:20 |
| ddaa | think I'll rant a bit about in a blog | 01:21 |
| Kinnison | Have fun :-) | 01:24 |
| stub | carlos: yer | 01:28 |
| carlos | stub: https://chinstrap.warthogs.hbd.com/~dsilvers/paste/filel4UmYi.html | 01:28 |
| === BenC [n=bcollins@debian/developer/bcollins] has joined #launchpad | ||
| stub | carlos: That is buggy - the subquery can retrieve multiple rows. Also needs a comment in comments.sql | 01:31 |
| carlos | stub: oh, I forgot the LIMIT 1... | 01:31 |
| carlos | sorry | 01:31 |
| carlos | stub: https://chinstrap.ubuntu.com/~dsilvers/paste/fileBaigsH.html | 01:33 |
| stub | carlos: approved as patch-40-60-0.sql provided you add a comment to comments.sql | 01:34 |
| carlos | sure | 01:34 |
| carlos | stub: thanks | 01:35 |
| === Kinnison [n=dsilvers@spoo.flarn.net] has joined #launchpad | ||
| === cprov [i=cprov@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| cprov | good morning, hackers | 01:49 |
| SteveA | jamesh: ping | 01:56 |
| carlos | cprov: morning | 01:57 |
| cprov | carlos: hey, how is rosetta for edgy, did you face any issue ? | 01:57 |
| carlos | implementing a small fix to have dapper as our default translatable target | 01:58 |
| cprov | carlos: are you using 'translation_focus' approach instead of CURRENT status ? | 02:00 |
| carlos | cprov: hmm kiko said translation_target | 02:00 |
| carlos | I don't remember the exact term we talk in London | 02:01 |
| SteveA | kiko-zzz: ping | 02:01 |
| cprov | carlos: sure, don't bother with name | 02:01 |
| mdz | cprov: good morning | 02:02 |
| mdz | cprov: Kinnison has done a small fix for us on drescher to be able to process a dist-upgrader upload through unapproved | 02:02 |
| cprov | carlos: should work and I think you can also test something in mawson, launchpad_dogfood DB is a frozen copy from 18th May with dapper released and edgy in place | 02:02 |
| carlos | cprov: ok, I will tell you when the branch is ready so we can test it there. Thanks for pointing me to it | 02:03 |
| cprov | mdz: hi, yes, I'm talking with him right now, he had some issues to _cowboying_ his code in drescher ... fixing | 02:03 |
| cprov | carlos: ok | 02:04 |
| === richips [n=richi@37.Red-83-46-127.dynamicIP.rima-tde.net] has joined #launchpad | ||
| === salgado [n=salgado@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| === lincao [n=lincoln@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| mdz | cprov,Kinnison: what's the story? | 02:14 |
| mdz | will this publisher run give us the updated dist-upgrader we want, or no? | 02:14 |
| cprov | mdz: do you have new d-u upload in place ? | 02:15 |
| mdz | cprov: it was already uploaded by mvo and accepted by kinnison | 02:15 |
| cprov | mdz: only process-accept should so | 02:15 |
| mdz | cprov: but since you said there were problems, I am wondering whether it is affected | 02:16 |
| cprov | mdz: np, let's Kinnison patch drescher's mainline and run p-a, will do the job | 02:16 |
| === janimo [n=jani@Home03207.cluj.astral.ro] has joined #launchpad | ||
| mdz | cprov: ./accepted/upload-20060601-211312-005603/dist-upgrader_20060601.1853_all.changes | 02:18 |
| mdz | that is the one I am interested in | 02:18 |
| cprov | mdz: right, should go smoothly, just wait Kinnison's patch | 02:19 |
| mdz | cprov: I'm confused; Kinnison said that it was already done | 02:19 |
| === matsubara [n=matsubar@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| cprov | mdz: if he said so, I can only nod ...let me check in drescher | 02:21 |
| === WaterSevenUb [n=WaterSev@azevedo.astro.up.pt] has joined #launchpad | ||
| cprov | mdz: yes, queue accepted is empty now | 02:23 |
| mdz | cprov: ok, and the publisher run is complete | 02:25 |
| mdz | lrwxrwxrwx 1 lp_publish lp_publish 13 Jun 2 13:04 current -> 20060601.1853 | 02:26 |
| mdz | looks good | 02:26 |
| cprov | good | 02:26 |
| mdz | ah, Kinnison sent an SMS to say that his internet connection is down | 02:27 |
| mdz | that explains | 02:27 |
| === beyond [n=beyond@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| cprov | mdz: yes, yes, looks like he has managed to buy a brazilian-like conectivity in manchester ;) | 02:28 |
| === bradb [n=bradb@modemcable092.66-130-66.mc.videotron.ca] has joined #launchpad | ||
| === carlos -> lunch | ||
| janimo | hi all, what is the status of importing upstream svns into bzr? | 02:31 |
| === alexandros_se [n=a@2-1-1-18a.spa.sth.bostream.se] has joined #launchpad | ||
| === cprov [i=cprov@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| === Kinnison [n=dsilvers@spoo.flarn.net] has joined #launchpad | ||
| === Kinnison [n=dsilvers@spoo.flarn.net] has joined #launchpad | ||
| === janimo [n=jani@Home03207.cluj.astral.ro] has left #launchpad [] | ||
| salgado | spiv, ping? | 03:31 |
| === Keybuk [n=scott@217.205.109.249] has joined #launchpad | ||
| === thierryn [n=thierry@modemcable199.142-201-24.mc.videotron.ca] has joined #launchpad | ||
| === mykal [i=Pawel@ip-225-110.elb.vectranet.pl] has joined #launchpad | ||
| === mykal [i=Pawel@ip-225-110.elb.vectranet.pl] has left #launchpad ["Leaving"] | ||
| kiko | good morning! | 04:14 |
| kiko | I have long phone calls! | 04:15 |
| kiko | spiv, spiv, spiv | 04:15 |
| Kinnison | hehi kiko | 04:15 |
| kiko | Kinnison!11! | 04:16 |
| === Kinnison is about to scare kiko by sending some patches to pqm | ||
| Kinnison | bwuahahaha | 04:16 |
| kiko | r=unreviewed reimplement soyuz | 04:16 |
| Kinnison | snerk | 04:17 |
| Kinnison | r=stevea thankyouverymuch | 04:17 |
| Kinnison | Mr kiko doesn't trust me | 04:17 |
| === Kinnison sobs | ||
| kiko | keep high spirits I have a wad of good news | 04:17 |
| Kinnison | coo | 04:18 |
| === Kinnison likes good news | ||
| kiko | to start of it is SUNNY today! | 04:18 |
| kiko | off | 04:18 |
| Kinnison | that's good, it's sunny here too | 04:19 |
| kiko | second, it has been decreed that today is national soyuz-appreciation day! so all must bow once to Kinnison cprov and malcc and then face east or west depending on where you are located wrt to the datacenter | 04:19 |
| === kiko bows and looks northeast | ||
| Keybuk | kiko: can we in the distro team wait until edgy has been opened on Soyuz without it breaking into little pieces before appreciating it? :p | 04:20 |
| kiko | well | 04:20 |
| kiko | no | 04:20 |
| kiko | you need to appreciate it now | 04:20 |
| === Keybuk debates whether it is worth appreciating | ||
| malcc | There's also no need to bow to me, I haven't done anything useful to Soyuz yet | 04:20 |
| Keybuk | after all, we didn't appreciate katie | 04:20 |
| kiko | or else it might rust catastrophic and instantly and the switch may not work | 04:20 |
| cprov | malcc: that's not truth, I have shiny testbrowser stuff in my tree ;) | 04:21 |
| malcc | cprov: Ok, so I've done a little bit... | 04:21 |
| === richi_ [n=richi@134.Red-83-52-166.dynamicIP.rima-tde.net] has joined #launchpad | ||
| kiko | where's spiv? | 04:40 |
| === kiko waaah | ||
| LarstiQ | not at the bzr sprint I suppose | 04:41 |
| kiko | SteveA, jamesh: review requested? | 04:51 |
| === dako_oten [n=ptongco@202.84.109.107] has joined #launchpad | ||
| SteveA | review of what | 04:55 |
| SteveA | ? | 04:55 |
| mdz | cprov: do you have the procedure for opening edgy written down anywhere? | 04:55 |
| kiko | SteveA, of a patch to helpers.py:Snapshot, and of an sqlobject patch if you feel brave. | 04:55 |
| cprov | cprov: yes, kiko is reviewing it | 04:55 |
| kiko | SteveA, it blocks a massive landing that moves us to SQLRelatedJoin | 04:56 |
| SteveA | kiko: snapshot functionality has been hacked into zope transactions lately, btw | 04:56 |
| kiko | nice | 04:56 |
| cprov | mdz: for now you can create the distrorelease with the proper summary and description | 04:56 |
| kiko | our snapshots are hackshots | 04:56 |
| mdz | cprov: and later? | 04:56 |
| kiko | mdz, cprov: hold on | 04:57 |
| cprov | mdz: I'm only affraid about people starting uploading, but hopefully the cron are stopped | 04:57 |
| kiko | there is a rosetta impact when doing that | 04:57 |
| kiko | carlos, ping? | 04:57 |
| cprov | kiko: ohh yes, sorry | 04:57 |
| carlos | kiko: pong | 04:57 |
| carlos | kiko: working on it | 04:57 |
| kiko | carlos, tell me about this translation_focus patcheroo | 04:57 |
| carlos | kiko: the db patch is already approved | 04:57 |
| kiko | how does it look? | 04:57 |
| cprov | mdz: later a script called initialise-from-parent will run over edgy and setup everything to start processing uploads | 04:57 |
| SteveA | kiko: <zztop>gimme all your patchin', all your love and kisses too</zztop> | 04:58 |
| kiko | SteveA, is that an actual zz top quote? | 04:58 |
| carlos | kiko: fine, is soyuz ready ? | 04:58 |
| kiko | carlos, soyuz was BORN ready | 04:58 |
| SteveA | i think the original is | 04:58 |
| SteveA | <zztop>gimme all you lovin', all your hugs and kisses too</zztop> | 04:58 |
| === ..[topic/#launchpad:kiko] : WORLDWIDE SOYUZ APPRECIATION DAY | https://launchpad.net/ | developer meeting: Thu 8 Jun, 1200UTC (wiki:MeetingAgenda) | launchpad-users@lists.canonical.com (wiki:MailingLists) | Channel logs: http://tinyurl.com/72w39 | ||
| kiko | I just upgraded the celebration | 04:59 |
| mdz | kiko: I'll have you know that we toasted Soyuz at the release celebration lunch | 04:59 |
| kiko | toast Soyuz is better than burnt soyuz I guess | 05:00 |
| ddaa | is that perceived as actually helping? | 05:00 |
| Keybuk | how does one delete an accidentally created Release Series in doap? | 05:03 |
| kiko | Keybuk, with SQL fu | 05:04 |
| Keybuk | kiko: can you do the SQL fu for me? | 05:04 |
| kiko | Keybuk, only one person can and that person is not me :-( | 05:04 |
| Keybuk | I created "dapper" and "edgy" series for the ubuntu-seeds product, thinking one attached branches to series, when it appears they get attached to products | 05:04 |
| Keybuk | who is that person? | 05:04 |
| kiko | ddaa, can you not attach branches to series? | 05:05 |
| kiko | Keybuk, stub | 05:05 |
| Keybuk | stub is not awake? | 05:05 |
| SteveA | Keybuk: probably awake, but finished for the day. | 05:08 |
| SteveA | Keybuk: if it is of great importance, i can contact him. if not, better to email him cc launchpad list. | 05:08 |
| Keybuk | it's not greatly important | 05:09 |
| === Kinnison 's merges are being rejeced | ||
| Kinnison | erm rejected | 05:09 |
| kiko | Kinnison, for what so reason? | 05:09 |
| Kinnison | kiko: gpgv exit(1) | 05:09 |
| kiko | that's news | 05:09 |
| carlos | kiko: ok, I did the basic changes | 05:16 |
| carlos | kiko: I would like to do another change at launchpad.net/rosetta/ so we only show products that actually have templates associated, instead of showing them if there is an ubuntu package with translations for it | 05:17 |
| ddaa | kiko: bug 31308 | 05:17 |
| Ubugtu | Malone bug 31308 in launchpad-bazaar "Cannot set branch associated to a productseries" [Critical,Confirmed] http://launchpad.net/bugs/31308 | 05:17 |
| carlos | kiko: but I can do it as another different branch | 05:17 |
| carlos | kiko: it should be also easy to change | 05:17 |
| kiko | ddaa, mmmmm | 05:20 |
| carlos | jordi: ping | 05:22 |
| Keybuk | spiv: when will the "knit support patch" for the "sftp server" be rolled out? | 05:24 |
| kiko | spiv, ping | 05:36 |
| kiko | SteveA, no luck for a review? | 05:36 |
| SteveA | gimme | 05:37 |
| carlos | cprov: could I update dogfood's code? | 05:37 |
| ddaa | Keybuk: normally, on the next general launchpad rollout | 05:37 |
| ddaa | kiko: is there a general rollout planned next week? | 05:37 |
| SteveA | tuesday | 05:38 |
| SteveA | yes | 05:38 |
| kiko | ddaa, yes, tuesday, as per the meeting | 05:38 |
| kiko | SteveA, https://chinstrap.ubuntu.com/~dsilvers/paste/fileQk2W1k.html | 05:38 |
| kiko | SteveA, the email I sent has more details | 05:38 |
| cprov | carlos: could you merge you code over the current codeline ? | 05:38 |
| carlos | cprov: I'm pushing it atm | 05:38 |
| kiko | SteveA, I believe it will have performance issues | 05:38 |
| kiko | SteveA, so I am digging for an alternative that I can do in the short term | 05:38 |
| SteveA | hmm | 05:39 |
| SteveA | don't use hasattr | 05:39 |
| SteveA | it will get the property | 05:39 |
| SteveA | if it is a property | 05:39 |
| SteveA | mucho extra processing | 05:39 |
| SteveA | make it use getattr and only once in the code | 05:39 |
| kiko | I can't tell | 05:39 |
| salgado | carlos, please make sure that we have at least r3633 there | 05:39 |
| salgado | I'm testing some things there and I need this revision | 05:39 |
| kiko | SteveA, but okay. but that's not the main problem | 05:40 |
| cprov | carlos: uhm, just rsync you tree there and use it, don't need to merge anything ... | 05:40 |
| kiko | SteveA, the main problem is that I /don't/ want to listify /most/ select results | 05:40 |
| SteveA | i think that should be an explicit argument | 05:40 |
| carlos | salgado: I branched from r3635 | 05:40 |
| kiko | SteveA, in the interface? | 05:41 |
| kiko | is that hard to do? | 05:41 |
| SteveA | no | 05:41 |
| SteveA | in the use of snapshot | 05:41 |
| kiko | SteveA, can you explain further? | 05:41 |
| carlos | cprov: where's the tree path? | 05:41 |
| kiko | I think an interface attribute would not be a bad idea, SteveA | 05:42 |
| kiko | (if at all possible) | 05:42 |
| kiko | it would make things much safer from the callsite's point of view. | 05:42 |
| kiko | snapshot=False | 05:42 |
| carlos | cprov: last time I touched it was more than one year ago... | 05:42 |
| cprov | current usually points to the code running | 05:42 |
| cprov | carlos: np, I can guide you | 05:42 |
| salgado | carlos, cool. that should be okay | 05:43 |
| carlos | cprov: where is current? | 05:44 |
| carlos | ;-) | 05:44 |
| cprov | carlos: create your own tree there, cp current <carlos> && rsync chinstrap | 05:44 |
| salgado | carlos, btw, ping me when/if you need to restart launchpad there. I'm running a script which depends on it | 05:44 |
| SteveA | s = Snapshot(obj, providing=IFoo, deepcopy=['foo', 'bar'] ) | 05:44 |
| kiko | what is deepcopy? | 05:44 |
| carlos | cprov: but where is 'current'? | 05:44 |
| SteveA | a name | 05:44 |
| kiko | what does it mean I mean | 05:45 |
| SteveA | an optional argument | 05:45 |
| carlos | salgado: sure | 05:45 |
| cprov | carlos: check the symlink, in the path i told you | 05:45 |
| SteveA | it means that you want attributes foo and bar to be copied deeply | 05:45 |
| SteveA | rather than just referenced as now | 05:45 |
| cprov | carlos: current -> soyuz/ | 05:45 |
| kiko | SteveA, okay so far. but what does that mean implementation-wise? that I list()ify selectresults? | 05:45 |
| carlos | cprov: sorry, but I'm blind and didn't see such path | 05:45 |
| SteveA | i'd rather have two properties -- one that returns a SelectResults and one that returns a list, in the content object's API | 05:45 |
| kiko | that I copy.deepcopy() them? | 05:46 |
| carlos | cprov: /srv/ ... ? | 05:46 |
| SteveA | that adds to the API, but means we have less magic going on | 05:46 |
| bradb | kiko: you can't deepcopy a sec proxied object, afaik | 05:46 |
| kiko | SteveA, I don't like that idea at all | 05:46 |
| cprov | carlos: yep, /srv/launchpad.net/codelines | 05:46 |
| carlos | codelines! | 05:46 |
| carlos | cprov: ok, thanks | 05:46 |
| === kiko frowns | ||
| === bradb hasn't yet had a use case for deepcopying snapshot attributes | ||
| kiko | bradb, well, what does deepcopying mean? | 05:47 |
| kiko | that's what I'm driving towards | 05:47 |
| kiko | SteveA, grumble. this is terrible. | 05:47 |
| cprov | carlos: copy soyuz to <rosetta> or something else, rsync down your changes from chinstrap, ping me when it's done | 05:47 |
| carlos | doing it atm | 05:47 |
| carlos | cprov: thanks | 05:47 |
| SteveA | kiko: why don't you like making it explicit in the API? | 05:47 |
| cprov | carlos: don't blow salgado's things, he will cry ;) | 05:48 |
| kiko | SteveA, well, for starters, this is an SQLRelatedJoin. so I need to create a foo_list property or something. | 05:48 |
| SteveA | and remember, use shortlist | 05:48 |
| carlos | cprov: don't worry, I will just kill it :-P | 05:49 |
| kiko | SteveA, second, I'd like to find a solution which allowed us to avoid the perf problems we already have with Snapshot without having to add a method everywhere. | 05:49 |
| SteveA | how many properties in our entire codebase do you want to do this for? | 05:49 |
| kiko | many | 05:49 |
| SteveA | under 5 ? | 05:50 |
| bradb | kiko: deep copying is making copies not only of object referenced by foo.bar, but also all the objects that bar itself might have references to, like bar.sourcepackagename, bar.distribution, etc. | 05:50 |
| SteveA | under 10? | 05:50 |
| kiko | most calculated properties should not be snapshotted | 05:50 |
| kiko | but some of them need to be | 05:50 |
| bradb | kiko: (recursively) | 05:50 |
| kiko | bradb, yeah, but in this context? | 05:50 |
| kiko | SteveA, more than 20 | 05:50 |
| SteveA | kiko: then... another suggestion | 05:50 |
| kiko | okay | 05:50 |
| kiko | go ahead | 05:50 |
| SteveA | define schemas particularly for snapshotting. s = Snapshot(obj, snapshotschema=IBugTaskSnapshot) | 05:51 |
| bradb | kiko: it means the same thing, afaics. | 05:51 |
| SteveA | everything given in that interface gets snapshotted | 05:51 |
| kiko | SteveA, and inherit from the original schema? I don't want to duplicate the interface. | 05:51 |
| SteveA | and the rule is to shortlistify selectresults | 05:51 |
| SteveA | no, do not inherit from the original schema | 05:51 |
| SteveA | if you need to, make a shortcut like: | 05:51 |
| SteveA | IBugTaskSnapshot = SnapshotSchema(IBugTask, 'foo', 'bar', 'baz') | 05:52 |
| kiko | mmmm | 05:52 |
| mdz | cprov: could you make 'queue fetch 40671 40669 40668 40667 40666 40665 40664 40663 40662 40654' work? | 05:52 |
| mdz | cprov: it'd be much more convenient to fetch a batch of pending updates all at once | 05:52 |
| kiko | SteveA, strawman strawman. what is wrong with a snapshot=False default argument in Attribute()? | 05:52 |
| cprov | carlos: df is quite strange right now, I'm running a librarian instance from soyuz tree and salgado is running the UI and his scrips from m-m tree, if you need your UI need to ask him to stop his | 05:52 |
| kiko | I just want to understand where my thinking is flawed SteveA | 05:52 |
| cprov | mdz: yes, I think it's feasible, file a bug, maybe I can work on it today | 05:53 |
| carlos | cprov: my tree needs a db schema change | 05:53 |
| carlos | cprov: and then, I need an UI update | 05:54 |
| SteveA | kiko: because that is changing such infrastructure. | 05:54 |
| mdz | cprov: ok, thanks | 05:54 |
| kiko | SteveA, is Attribute() not in the launchpad tree? | 05:54 |
| mdz | cprov: on which product? | 05:54 |
| SteveA | kiko: if you really want to, and you really dislike SnapshotSchema(...) then | 05:54 |
| cprov | carlos: ask salgado, if you can update the DB, he already did | 05:54 |
| SteveA | you can make a SnapshottableAttribute() | 05:54 |
| kiko | SteveA, I don't dislike it, I am just curious | 05:54 |
| carlos | ok | 05:54 |
| cprov | mdz: soyuz | 05:54 |
| SteveA | Attribute is a core part of zope interfaces | 05:54 |
| SteveA | i do not want to change the functioning of Attribute | 05:55 |
| kiko | SteveA, gotcha. | 05:55 |
| SteveA | but you could do SnapshottableAttribute | 05:55 |
| kiko | or LPAttribute? | 05:55 |
| SteveA | no | 05:55 |
| kiko | yeah, I see the drawbacks in that. | 05:55 |
| SteveA | so, you can make SnapshottableAttribute very easily | 05:56 |
| SteveA | it is just a subclass of Attribute | 05:56 |
| kiko | yes yes | 05:56 |
| salgado | carlos, are you going to apply a single patch manually or you want to run the upgrade script to apply all patches? | 05:56 |
| carlos | salgado: my db patch is already approved by stuart | 05:56 |
| kiko | SteveA, do you endorse this approach? I think it leads to more clarity and reduced duplication, and I think I know how to do it. | 05:57 |
| carlos | salgado: whatever is more easy for you | 05:57 |
| SteveA | i'm happy with SnapshotAttribute | 05:57 |
| kiko | SteveA, one question I have is whether it is easy to find out the type of the attribute in the interface. isinstance(getattr(iface, name), SnapshottableAttribute): ? | 05:57 |
| SteveA | but please do this -- move Snapshot + SnapshotAttribute out of helpers | 05:57 |
| salgado | carlos, I applied a patch manually there, so it's better to apply yours manually | 05:57 |
| kiko | SteveA, yes | 05:57 |
| kiko | will do | 05:57 |
| carlos | ok | 05:57 |
| SteveA | it can go in webapp | 05:57 |
| SteveA | because it can be part of project elizium | 05:58 |
| kiko | SteveA, Snapshot is useful beyond webapp | 05:58 |
| SteveA | what does that mean? | 05:58 |
| kiko | SteveA, the impression I get is launchpad.fields or something | 05:58 |
| SteveA | is it used elsewhere than launchpad? | 05:58 |
| kiko | yeah | 05:58 |
| kiko | mail interface IIRC | 05:58 |
| SteveA | that is part of launchpad | 05:58 |
| kiko | but not webapp AFAICT | 05:58 |
| === lincao is now known as lincao_fora | ||
| SteveA | mail interfaces are goingn to be part of project el | 05:58 |
| kiko | archivepublisher too IIRC | 05:58 |
| kiko | I mean I am easy | 05:59 |
| SteveA | so don't get hung up on the name "webapp" | 05:59 |
| kiko | but webapp.snapshot is a bit weird | 05:59 |
| kiko | okay | 05:59 |
| SteveA | it won't be "webapp" for long | 05:59 |
| kiko | webapp.snapshot it is | 05:59 |
| kiko | it will be canonical.eBLAZER | 05:59 |
| kiko | it needs an e-suffix | 05:59 |
| kiko | to be enterprise and e-commerce ready | 05:59 |
| SteveA | the "E" is everything | 06:02 |
| SteveA | ebapp | 06:02 |
| kiko | and nothing all at once | 06:02 |
| === kiko gets back to work | ||
| === Seveas [n=seveas@ubuntu/member/seveas] has joined #launchpad | ||
| carlos | WTF | 06:06 |
| carlos | carlos@mawson:~/dogfood $ bzr revert | 06:07 |
| carlos | bzr: ERROR: Can't decode username in /etc/passwd as ANSI_X3.4-1968. | 06:07 |
| carlos | ? | 06:07 |
| elmo | shouldn't fedora in launchpad be marked as read only? :P | 06:07 |
| carlos | salgado, cprov: ok, it's ready | 06:14 |
| carlos | salgado, cprov: /srv/launchpad.net/codelines/carlos | 06:15 |
| salgado | okay, I'm going to restart launchpad on that branch | 06:15 |
| carlos | salgado: I guess I should apply db changes first, right? | 06:15 |
| salgado | no need to, I think | 06:16 |
| kiko | elmo, we're hacking everything | 06:16 |
| salgado | carlos, does your patch has anything to do with translation_target? | 06:18 |
| carlos | salgado: yes | 06:18 |
| salgado | so, do it! we're all waiting for you. :) | 06:19 |
| carlos | salgado: seems like I don't have permissions | 06:19 |
| carlos | launchpad_dogfood=> ALTER TABLE Distribution ADD COLUMN translation_target integer REFERENCES DistroRelease(id); | 06:19 |
| carlos | ERROR: must be owner of relation distribution | 06:19 |
| salgado | carlos, psql -U postgres launchpad_dogfood | 06:20 |
| carlos | I'm connected as the user launchpad | 06:20 |
| carlos | ok | 06:20 |
| carlos | salgado: done | 06:21 |
| bradb | BjornT_: ping | 06:22 |
| BjornT_ | hi bradb | 06:22 |
| bradb | hi | 06:22 |
| bradb | I don't understand this OOPS: https://chinstrap.ubuntu.com/~jamesh/oops.cgi/2006-06-01/B521 | 06:22 |
| bradb | the query string: field.searchtext=adsl&search=Search&field.status%253Alist=Unconfirmed&field.status%253Alist=Confirmed&field.status%253Alist=In+Progress&field.status%253Alist=Needs+Info&field.status%253Alist=Fix+Committed&field.assignee=&field.owner=&field.omit_dupes=on&field.has_patch=&field.has_no_package=&orderby=-priority%252C-severity | 06:22 |
| bradb | any idea where those %253A's and such come from? | 06:23 |
| bradb | i'm guessing the url was sent in unicode, but i'm unsure if i'm interpreting that info correctly | 06:24 |
| bradb | (utf-8) | 06:25 |
| BjornT_ | bradb: no, no idea. are there any other oops like this? this one doesn't have a referrer set, so it could be some external source manipulating the url. | 06:25 |
| bradb | not that i've seen | 06:25 |
| === bradb has spirals of confusion in his eyes | ||
| BjornT_ | bradb: my guess is that %3A==',' and %25=='%', meaning that something quoted the already quoted url. | 06:26 |
| matsubara | BjornT_, bradb fwiw, it's the first time i've seen that oops too | 06:26 |
| BjornT_ | ah, right, %3a==':' | 06:27 |
| matsubara | %2C==',' | 06:28 |
| carlos | kiko: are you busy? | 06:30 |
| kiko | carlos, not right now. what's up? | 06:30 |
| carlos | kiko: https://dogfood.ubuntu.com/distros/ubuntu/+translations | 06:30 |
| carlos | kiko: that page should be fixed | 06:31 |
| bradb | BjornT_: hm, yeah, that may be it | 06:31 |
| kiko | carlos, you mean timing out? | 06:31 |
| === bradb made urllib.quote spit out: | ||
| bradb | 'field.searchtext%3D%26search%3DSearch%26orderby%3D-priority%252C-severity%26field.status%253Alist%3DUnconfirmed%26field.status%253Alist%3DNeeds%2BInfo%26field.status%253Alist%3DConfirmed%26field.status%253Alist%3DIn%2BProgress%26field.status%253Alist%3DFix%2BCommitted%26assignee_option%3Dany%26field.assignee%3D%26field.owner%3D%26field.component-empty-marker%3D1%26field.omit_dupes.used%3D%26field.omit_dupes%3Don%26field.has_patch. | 06:31 |
| carlos | kiko: no, in dogfood, the default is breezy | 06:32 |
| carlos | kiko: and we show first dapper | 06:32 |
| carlos | kiko: which is wrong | 06:32 |
| kiko | carlos, oh. can you fix that as well? | 06:32 |
| carlos | yeah | 06:32 |
| carlos | kiko: I was thinking on showing first the translation_target, and then sort the distributions by version | 06:33 |
| carlos | kiko: and remove the ones that are unsupported | 06:33 |
| kiko | carlos, sounds quite good. | 06:33 |
| carlos | so we would have 4 distributions there | 06:33 |
| kiko | 4? dapper edgy breezy hoary? | 06:33 |
| carlos | three released and one being developed | 06:33 |
| carlos | kiko: right | 06:34 |
| kiko | sounds double plus ultra | 06:34 |
| kiko | carlos, thanks for checking that out | 06:34 |
| carlos | np | 06:34 |
| === bradb & # lunch | ||
| === Kinnison attempts one more time to make pqm love him | ||
| === dsas [n=dean@host81-129-229-196.range81-129.btcentralplus.com] has joined #launchpad | ||
| === lincao [n=lincoln@200-171-140-32.dsl.telesp.net.br] has joined #launchpad | ||
| carlos | salgado: I need to do another code update | 08:09 |
| salgado | carlos, will it overwrite any change done on that branch? | 08:12 |
| carlos | do you need to do any change? | 08:12 |
| carlos | I was preparing a fresh merge | 08:13 |
| salgado | carlos, yes, we need to change dogfood's config file to not start a librarian | 08:13 |
| carlos | oh | 08:13 |
| carlos | hmm | 08:13 |
| carlos | I will do a commit on that branch | 08:13 |
| carlos | and a bzr merge | 08:13 |
| carlos | so your changes will stay there | 08:13 |
| carlos | ok? | 08:13 |
| salgado | I think it should be fine | 08:14 |
| carlos | salgado: done, could you restart it? | 08:22 |
| salgado | carlos, restarted | 08:23 |
| carlos | salgado: thanks | 08:24 |
| salgado | np | 08:24 |
| carlos | kiko-fud: https://dogfood.ubuntu.com/distros/ubuntu/+translations | 08:25 |
| === okaratas [n=devnull@unaffiliated/okaratas] has joined #launchpad | ||
| === okaratas [n=devnull@unaffiliated/okaratas] has left #launchpad [] | ||
| === lbm [n=lbm@0x555298ca.adsl.cybercity.dk] has joined #launchpad | ||
| === jonux_ [n=jonuxx@201.144.152.254] has joined #launchpad | ||
| jonux_ | hola | 08:56 |
| === tiffiniycheng [n=tiffiniy@66-189-115-194.dhcp.oxfr.ma.charter.com] has joined #launchpad | ||
| tiffiniycheng | hi all, this is tiffiniy from pcf. we just added our democracy player project to rosetta. we love it. i was wondering how i can change my user permissions so i can add some text on template pages... anyone know? | 08:58 |
| matsubara | carlos: ^^ | 09:13 |
| carlos | tiffiniycheng: translation template? | 09:13 |
| carlos | matsubara: thanks | 09:14 |
| clahey | carlos: She wants to add text to the web page. | 09:14 |
| clahey | https://launchpad.net/products/democracy/trunk/+pots/democracyplayer | 09:14 |
| carlos | tiffiniycheng: you need to be the owner of either the template or the product | 09:14 |
| clahey | carlos: Can we have multiple admins? | 09:14 |
| carlos | clahey: you would need to create a team for your product | 09:14 |
| carlos | and give the ownership to that team | 09:15 |
| tiffiniycheng | ok thanks | 09:15 |
| clahey | Ah, that makes sense. | 09:15 |
| clahey | Where do I create a team? | 09:15 |
| tiffiniycheng | that's really helpful | 09:15 |
| carlos | clahey: launchpad.net/people/ | 09:15 |
| clahey | Yep, just found it. :) | 09:16 |
| clahey | Thanks much. | 09:22 |
| tiffiniycheng | yeah thanks | 09:23 |
| carlos | np | 09:23 |
| bradb | mdz: Might you have a chance to give some feedback for my "Permissions for editing Milestone and Importance" email in the next few days? | 09:35 |
| === BenC [n=bcollins@debian/developer/bcollins] has joined #launchpad | ||
| === glatzor [n=sebi@ppp-62-245-208-121.mnet-online.de] has joined #launchpad | ||
| === jonux_ [n=jonuxx@201.144.152.254] has left #launchpad ["Leaving"] | ||
| kiko-fud | carlos, you should say "Other releases of Ubuntu" before the second table | 09:49 |
| === Znarl [n=znarl@dark.roundabout.org] has joined #launchpad | ||
| glatzor | hi carlos. where can I get any information about our further plans for Rosetta and feature specs? | 09:58 |
| bradb | BjornT_: around? | 09:59 |
| salgado | hey kiko, how's that code review going? :) | 10:01 |
| kiko | salgado, r=kiko | 10:01 |
| kiko | if you remove or rewrite that docstring | 10:01 |
| kiko | salgado, actually | 10:02 |
| kiko | I have a better idea | 10:02 |
| kiko | for etQuantityWidgetsInitialValuesFromExistingOrder | 10:02 |
| kiko | err | 10:02 |
| kiko | for getQuantityWidgetsInitialValuesFromExistingOrder | 10:02 |
| kiko | instead of supplying the attrname | 10:02 |
| kiko | I suggest you supply "approved=True" | 10:02 |
| kiko | and have a default of approved=False | 10:02 |
| kiko | how does that sound? | 10:02 |
| kiko | salgado? | 10:02 |
| === jbailey [n=jbailey@modemcable139.249-203-24.mc.videotron.ca] has joined #launchpad | ||
| jbailey | bradb: Around? | 10:03 |
| bradb | jbailey: hey | 10:03 |
| salgado | sure. sounds like a good idea | 10:03 |
| jbailey | bradb: I can't seem to assign https://launchpad.net/distros/ubuntu/+source/apmd/+bug/46091 to nobody. | 10:03 |
| Ubugtu | Malone bug 46091 in apmd "APM error on shutdown" [Critical,Confirmed] | 10:03 |
| bradb | jbailey: the bug is fixed, but not yet rolled out | 10:03 |
| jbailey | bradb: Great, thanks. =) | 10:03 |
| bradb | np | 10:03 |
| jbailey | I'm only concerned about nobody looking after the critical bug. | 10:03 |
| jbailey | Is there a workaround for now? | 10:04 |
| kiko | jbailey, yes. | 10:04 |
| === SkyTalker [n=michael@p549DB33E.dip0.t-ipconnect.de] has left #launchpad ["bye] | ||
| kiko | jbailey, assign to kiko-bichodomato | 10:04 |
| jbailey | kiko: Done, thanks. | 10:04 |
| bradb | i almost forgot about that work around :) | 10:04 |
| bradb | s/k a/ka/ | 10:05 |
| kiko | I take all the bullets | 10:05 |
| kiko | salgado, I think that change is enough for an r=kiko, but consider also removing or unifying some of the comments you are adding to ShippingRequestApproveOrDenyView | 10:06 |
| kiko | salgado, because the repeated text is weird. | 10:06 |
| salgado | you mean the comments in all branches of the process() method? | 10:07 |
| kiko | I think that's process() salgado but I don't have enough context. | 10:10 |
| kiko | salgado, the three identical comments. | 10:10 |
| salgado | hmmm. they used to be slightly different | 10:11 |
| salgado | I wonder who changed them to be exactly the same in all three cases. :P | 10:11 |
| === moitio [n=Moitio@spc1-stkp1-0-0-cust438.bagu.broadband.ntl.com] has joined #launchpad | ||
| === bradb epiphanizes that BugTaskSearchListingView should not be a GeneralFormView | ||
| kiko | salgado, I WONDER | 10:16 |
| === LeeJunFan [n=junfan@adsl-69-210-207-5.dsl.klmzmi.ameritech.net] has joined #launchpad | ||
| bradb | kiko: There's a TON of cruft in the BTSLV code and templates. What do you think of me blowing away *all* template/macro code that isn't currently used in bug listings? I think resurrecting the list view would be nice, and I think we're much better spending two fresh hours on making something that looks good for the current Malone (including the two-column layout change) whenever it becomes a priority to do so. Meanwhile, I'd love t | 10:23 |
| kiko | bradb, why don't you instead ressurect the list view? :-) | 10:24 |
| bradb | kiko: I could, but even then, I'd still prefer to start by blowing everything away. It's probably easier to start from where we are now, rather than retrofit this crufty poo. | 10:25 |
| bradb | I've already converted BTSLV to not be a GFV, because it just doesn't need to be at all, and it makes modifying it (e.g. for the validation fix I was trying to do) unnecessarily confusing. | 10:26 |
| kiko | I don't know if I agree | 10:26 |
| kiko | I mean, the macros are not that complicated, are they? they take an iterable of bugtasks and.. that's all right? | 10:27 |
| === moitio [n=Moitio@spc1-stkp1-0-0-cust438.bagu.broadband.ntl.com] has left #launchpad ["Leaving"] | ||
| bradb | they date back to the days of having that lame advanced search form shown above the listing! | 10:27 |
| salgado | kiko, I'm not sure the change on getQuantityWidgetsInitialValuesFromExistingOrder will be good. it'll make the method itself clearer, but the callsites will remove some clarity from the callsites | 10:28 |
| kiko | salgado, only one callsite will send in an approved=True parameter. that sounds safe enough to me | 10:30 |
| salgado | yeah, but this callsite has an if block to decide if it needs to pass approved=True or not, and this if has a comment explaining why we do something that may not be obvious. it'd be silly to keep the conditional after the change, and removing it would force me to remove the comment | 10:32 |
| kiko | you can still keep the comment | 10:33 |
| kiko | anyway I think that is much better than supplying strings to APIs | 10:34 |
| kiko | another option | 10:34 |
| kiko | is to have two separate methods | 10:34 |
| kiko | that call a single method which does the actual query | 10:34 |
| kiko | your option | 10:34 |
| kiko | btw | 10:44 |
| kiko | does anyone | 10:44 |
| kiko | BjornT_, spiv, SteveA, lifeless, etc | 10:44 |
| kiko | know how to run a single test | 10:44 |
| kiko | when running the test suite | 10:44 |
| kiko | by an exact name | 10:44 |
| kiko | bradb, carlos etc | 10:45 |
| kiko | salgado, matsubara, cprov etc | 10:45 |
| bradb | the only tests you can run individually are standalone ones and doctests, afaik | 10:45 |
| matsubara | python test.py -vvf --test=testname.txt | 10:45 |
| bradb | kiko: wiki:LaunchpadHackingFAQ has all the answers | 10:45 |
| bradb | and good thing too, because i can never remember the syntax since it changed :) | 10:46 |
| kiko | matsubara, that matches a substring -- a stem I think :-/ | 10:46 |
| bradb | running selected tests seems to be somewhat broken now, yeah | 10:47 |
| matsubara | you can also use --layer=LAYER to indicate only FunctionLayer for doctests or PageTestLayer to run only pagetests | 10:47 |
| matsubara | s/FunctionLayer/FunctionalLayer/ | 10:47 |
| === AlinuxOS [n=AlinuxOS@d81-211-243-92.cust.tele2.it] has joined #launchpad | ||
| kiko | SteveA, where should I put shortlist() :-( | 11:03 |
| === lucasvo [n=lucasvo@wservices.ch] has joined #launchpad | ||
| === lbm [n=lbm@0x555298ca.adsl.cybercity.dk] has joined #launchpad | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!