[12:19] <ondrej> hi there, I seem to have problems with signing new CoC 1.0.1, although signed correctly it is not accepted
[12:21] <matsubara> ondrej: what's the error message?
[12:22] <ondrej> something about text not equal to CoC text...  but one moment, I'll try it right now again
[12:23] <matsubara> ondrej: when was it the last time you tried?
[12:23] <matsubara> ondrej: today we rolled out a fix for that problem
[12:23] <ondrej> yesterday
[12:24] <ondrej> confirmed, bug was fixed
[12:24] <matsubara> ondrej: it's problem fixed by now.
[12:25] <matsubara> ondrej: nice. :)
[12:25] <ondrej> just one more (aesthetic) thing, page with listing of signatures on CoC shows whole signed text of CoC on one line
[12:26] <matsubara> ondrej: known bug, let me find the number
[12:27] <matsubara> ondrej: bug 39995
[12:27] <Ubugtu> Malone bug 39995 in launchpad "No Line break in CoC active signatures" [Low,Confirmed]  http://launchpad.net/bugs/39995
[12:28] <ondrej> thanks, I'll subscribe it; one more thing, I continuosly get subscribed to gnome-power bugs in launchpad, which is quite annoying, and I can't find a reason why...
[12:28] <mdke> nice, CoC bug is fixed? rock on
[12:30] <matsubara> ondrej: maybe it's because bug 48860
[12:30] <Ubugtu> Malone bug 48860 in malone ""Also notified" makes difficult to unsubscribe" [Untriaged,Unconfirmed]  http://launchpad.net/bugs/48860
[12:33] <ondrej> I am not sure, I was subscribed to several new bug report; it may be related to my DD part on gnome debian team?
[12:33] <ondrej> s/report/reports/
[12:35] <ondrej> and I was able to unsubscribe
[12:36] <matsubara> ondrej: oh, I misunderstood you
[12:39] <matsubara> ondrej: what's your launchpad name?
[12:40] <ondrej> ondrej
[12:41] <ondrej> unfortunately I already unsubscribed from all bug reports I was getting mail from and already deleted all email related to that
[12:41] <ondrej> if you are unable to find any relation on gnome-power-manager and my username, then let's just postpone it and I will ping this channel again when it happens
[12:42] <matsubara> ondrej: now I see, you're the registrant of the gnome-power product, right?
[12:44] <ondrej> well, I am not aware of it, but it could have happened in far past
[12:45] <ondrej> ah, now I see, I registered gnome-power, propably so I could report a bug
[12:46] <matsubara> ondrej: that's probably the cause. everytime someone reports a bug against gnome-power, I think you'll also be notified. bradb could really confirm that.
[12:46] <ondrej> could you change it to "Registry Administrators"?
[12:47] <matsubara> ondrej: I can't, but I know who can. I'll ask kiko to do it.
[12:48] <ondrej> excelent, I was really clueless what was happening :-)
[12:54] <kiko> matsubara, what happens?
[12:54] <matsubara> so, ondrej registered gnome-power product some time ago
[12:55] <matsubara> kiko: to be able to report bugs against it. He's receiveing lots of bugemails and would like to transfer ownership to registry admins
[12:55] <kiko> that's fine.
[01:02] <ondrej> ok, people, it's 01:00 (deep night) here, time to go sleep...  have a nice rest of day whatever timezone you are in...
[01:11] <bradb> kiko: do you have time for a drive-by of the Importance perms patch in a few ins?
[01:11] <bradb> s/ins/mins/. also includes a lot of refactoring.
[01:17] <bradb> or anyone else have time for a drive-by?
[01:25] <kiko> hmmm
[01:25] <kiko> not really tonight
[01:25] <kiko> but I can queue it
[01:25] <kiko> do you want it done now?
[01:27] <bradb> kiko: well, i queued it. but tonight or tomorrow'd be ok.
[01:27] <kiko> where's the patch?
[01:29] <bradb> kiko: https://chinstrap.ubuntu.com/~dsilvers/paste/fileChhDb9.html
[01:39] <sivang> hmm , is there no "remove from a meeting" action on the left portlet ? :)
[01:47] <Keybuk> sivang: I could decline it for you
[01:48] <sivang> Keybuk: okay, so please decline the old one that I resubmitted, I want to have distinction betwene the "old" and then edgy plans
[01:49] <sivang> such that we have only the edgy-... one approvd for uds-paris
[01:49] <Keybuk> which one?
[01:49] <sivang> sec
[01:51] <sivang> actually the other way around. I see so many people sub'd to the original name in LP, I'll leave it for their sake to get updated of what happens with this spec.
[01:51] <sivang> please decline https://launchpad.net/distros/ubuntu/+spec/edgy-home-user-backup
[01:51] <sivang> I will just relink wiki pages instead
[01:52] <sivang> sorry for the hassle ...
[01:54] <Keybuk> kiko: ping (urgent)
[02:12] <kiko> Keybuk, what's up?
[02:12] <Keybuk> we need a database field changing in production
[02:12] <kiko> Keybuk, which field?
[02:12] <Keybuk> UPDATE distrorelease SET changeslist='edgy-changes@lists.ubuntu.com' WHERE name='edgy';
[02:13] <kiko> and what's the context.
[02:13] <Keybuk> s'ok, looks like we found a writable user <g>
[02:13] <kiko> Keybuk, cprov already has a patch up for review which allows you to edit that in the web ui btw
[02:13] <Keybuk> kiko: context is we'd like to upload to edgy without process-upload hitting a NULL :p
[02:13] <kiko> I'm supposed to look at it tonight
[02:13] <kiko> Keybuk, context is "uploading is currently broken" then? :)
[02:14] <Keybuk> yeah
[02:14] <Keybuk> s'ok, we monkeyed it :p
[02:14] <kiko> cowboy'd it
[02:16] <Keybuk> then I could ride the publisher and go "Yee! Haw!"
[02:20] <sivang> heh, night Keybuk 
[02:20] <kiko-zzz> I will let you guys fight it out
[02:21] <kiko-zzz> right now it's been 12+h on this seat
[02:21] <kiko-zzz> and my eyes are melting
[02:21] <sivang> night kiko-zzz 
[03:42] <Keybuk> aha!  WE HAVE ACHIEVED TIMEOUT ERROR!
[03:42] <Keybuk> the ponies are spinning hard, and the hamsters are at full burn!
[06:53] <nenolod> hi, I would like to know what the procedure is for making a correction to:
[06:53] <nenolod> http://launchpad.net/products/audacious
[06:53] <nenolod> I'm upstream, and feel that it is described grossly inaccurately (it's displayed as being dependant on GST, when in reality it gets nowhere near GStreamer at this time.)
[06:55] <nenolod> (oh, and did I mention I am upstream?)
[06:59] <jamesh> nenolod: does the name of the person who registered it mean anything to you?
[06:59] <jamesh> Bruno de Oliveira Abinader  
[07:01] <jamesh> looks like he registered that and bmpx as part of the gstreamer project
[07:11] <nenolod> jamesh: no, it doesn't. which is why I am asking here
[07:11] <nenolod> ;p
[07:11] <nenolod> at any rate those two things should probably be cleaned up
[07:11] <nenolod> as they don't make much sense under 'gstreamer'
[07:11] <nenolod> well, bmpx does
[07:11] <nenolod> sort of, i guess
[07:12] <nenolod> but then you'd probably want to put rhythmbox, et al there
[07:16] <nenolod> yeah, neither nhjm449 nor myself have heard of this guy
[07:16] <nhjm449> nope
[07:19] <jamesh> nenolod: it would probably be best to send a message to the launchpad-users mailing list
[07:19] <jamesh> nenolod: one of the admins can change alter the registrant of the product to you.
[07:20] <jamesh> you can then remove edit the product details to remove the link to the gstreamer project in LP
[07:20] <jamesh> (it probably doesn't make sense for bmpx to be under the gstreamer project either, btw
[07:22] <nenolod> well, I'm not M. Derezynski, so I can't make that call :)
[07:22] <nenolod> thanks :)
[08:06] <jamesh> http://blogs.gnome.org/view/mortenw/2006/06/07/0 <- nice description of bug severities by one of the Gnumeric developers
[09:40] <sabdfl> morning all
[09:40] <sabdfl> where do i find pytz?
[09:45] <sabdfl> SteveA: did we introduce a new dependency on pytz?
[09:52] <SteveA> hi
[09:53] <SteveA> it is in zope
[09:53] <SteveA>   launchpad/zope/src/pytz
[09:54] <SteveA> are you getting some kind of failure running launchpad, sabdfl ?
[09:57] <carlos> morning
[10:04] <SteveA> hi carlos
[11:04] <sabdfl> SteveA: yes, failure to run it, no such module as pytz
[11:06] <SteveA> sabdfl: i'd like to see the traceback.     https://chinstrap.warthogs.hbd.com/~dsilvers/paste/
[11:06] <SteveA> it's strange that you'd get such an error
[11:07] <SteveA> also, do you have the pytz symlink at launchpad/lib/pytz ?
[11:19] <sabdfl> SteveA: https://chinstrap.ubuntu.com/~dsilvers/paste/file0sgfOg.html
[11:19] <sabdfl> yes
[11:20] <sabdfl> to sourcecode/pytz/build/dist/pytz
[11:20] <sabdfl> which is odd
[11:20] <sabdfl> i use kiko's utilities/link-external-sourcecode.sh
[11:21] <sabdfl> and it seems not to have made that link
[11:21] <sabdfl> kiko-zzz: ?
[11:21] <sabdfl> i don't have pytz in sourcecode/
[11:22] <SteveA> ah
[11:22] <SteveA> that's not good
[11:22] <SteveA> ah, wait
[11:22] <SteveA> you won't have pytz in sorcecode
[11:23] <SteveA> it is in zope/src/pytz
[11:23] <SteveA> so try symlinking from sourcecode/zope/src/pytz to lib/pytz
[11:24] <sabdfl> i don't want to overwrite a link in lib/
[11:24] <sabdfl> because those are versioned, iirc
[11:25] <SteveA> there is something strange going on here
[11:25] <SteveA> my link to pytz goes to  ../sourcecode/zope/src/pytz
[11:25] <SteveA> do you get notice of changed links if you do bzr status in the launchpad tree?
[11:26] <sabdfl> only lib/pytz which I just modified
[11:27] <sabdfl> SteveA: this is very recent rocketfuel-get tree, copied over
[11:28] <SteveA> i'll grab a new tree and see if something has changed
[11:28] <SteveA> mine is only about 4 days old, though
[11:28] <sabdfl> hmm...
[11:28] <sabdfl> ok, so i fixed the pytz link
[11:28] <sabdfl> now i get another weird error with generalform
[11:28] <sabdfl>   File "/home/mark/lptrees/development/meeting-agenda-approvals/utilities/../lib/canonical/launchpad/webapp/generalform.py", line 14, in ?
[11:28] <sabdfl>     from transaction import get_transaction
[11:28] <sabdfl> ImportError: cannot import name get_transaction
[11:28] <sabdfl> make: *** [stop]  Error 1
[11:29] <SteveA> i have never used the link-external-sourcecode.sh script
[11:29] <SteveA> your symlinks are screwed
[11:36] <BjornT> sabdfl: it seems like somehow you have an old tree, there's no such import in generalform.py.
[11:38] <SteveA> i just got a fresh tree from rocketfuel-get, and the pytz symlink is correct there
[11:44] <sabdfl> is this correct: /home/warthogs/archives/rocketfuel-built/
[11:44] <sabdfl> ?
[11:44] <SteveA> ROCKETFUEL="/home/warthogs/archives/rocketfuel-built/*"
[11:44] <SteveA> so, yes
[11:45] <SteveA> that's from the rocketfuel-get script on my system
[11:45] <SteveA> what does bzr info say for your launchpad tree?
[11:46] <sabdfl> Branch history:
[11:46] <sabdfl>       3255 revisions
[11:46] <sabdfl>        716 days old
[11:46] <sabdfl>    first revision: Tue 2004-06-22 05:34:14 +0000
[11:46] <sabdfl>   latest revision: Sat 2006-03-11 14:54:44 +0000
[11:46] <sabdfl> oh
[11:46] <sabdfl> weird
[11:46] <sabdfl> let me blow this one away and try again
[11:46] <SteveA> Related branches:
[11:46] <SteveA>       parent branch: sftp://chinstrap.ubuntu.com/home/warthogs/archives/rocketfuel/launchpad/devel/
[11:46] <SteveA>   publish to branch: sftp://chinstrap.ubuntu.com/home/warthogs/archives/stevea/launchpad/devel
[11:46] <SteveA> 
[11:47] <SteveA> that's the part i thought might be wrong
[11:47] <SteveA> but yeah, 700 days old...
[11:47] <SteveA> oh, mine too
[11:47] <SteveA> latest revision from march, though...
[12:16] <aimaz> hi
[12:32] <sabdfl> stub: could I trouble you for a dba approval and patch number, please?
[12:32] <stub> sabdfl: Sure
[12:34] <aimaz> are there any guidelines on registering a product somewhere
[12:34] <aimaz> i wish to register something for which i'm not the original developer
[12:35] <sabdfl> stub: privmsg
[12:44] <SteveA> sabdfl: some blueprint love on the way?
[12:45] <sabdfl> SteveA: trivialities for mdz
[01:23] <sivang> hmm, have all the pages on wiki.launchpad.canonical.com become immutable?
[01:23] <sivang> I can't seem to be editing a spec proposal I've put there, https://wiki.launchpad.canonical.com/DistroPolicyTracker
[01:27] <sivang> ah, it's okay , my mistake.
[01:35] <Keybuk> so, err
[01:35] <Keybuk> Kinnison, cprov
[01:35] <Keybuk> I appaer to have managed to put something in the pool without it being attached to any particular distrorelease
[01:39] <Keybuk> Kinnison: ok, slightly more urgent now with a hint of panic
[01:39] <Keybuk> please be somewhere near a keyboard
[01:43] <Keybuk> we're at full panic now
[01:43] <Keybuk> the publisher has been shut down
[01:43] <SteveA> hi scott
[01:43] <Keybuk> so, err, could somebody find kinnison or cprov
[01:43] <Keybuk> we appear to have a problem
[01:43] <SteveA> have you phoned Kinnison?
[01:43] <Keybuk> his phone went straight to voice mail
[01:43] <SteveA> cprov will be here in 15 mins
[01:44] <Keybuk> thank you
[01:44] <Keybuk> context: all syncs just went to dapper, and got accepted straight though
[01:44] <SteveA> i didn't do anything.. he's due to be here for the launchpad meeting anyway
[01:45] <Kinnison> Keybuk: Okay, explain
[01:45] <SteveA> hi cprov 
[01:45] <Keybuk> Kinnison: the sync-queue's process incoming script had a hard-coded dapper in it
[01:46] <Kinnison> Keybuk: and the policy let it in?!
[01:46] <Keybuk> so it was shoving syncs directly into dapper, bypassing all policy and checks
[01:46] <Kinnison> feck
[01:46] <Keybuk> they're in the pool
[01:46] <Keybuk> and publishinghistory
[01:46] <cprov> SteveA: hi, good morning 
[01:46] <Keybuk> we appear to only be saved by the publisher not generating new Sources/Packages files for dapper
[01:46] <Kinnison> Keybuk: Yeesh, fortunately they'll not be in packagesfiles
[01:46] <Keybuk> which appears to prove elmo wrong, fortunately
[01:47] <Kinnison> The Packages files were being dsync de-duped which is what confused him
[01:47] <SteveA> Kinnison, cprov: i propose you skip the launchpad meeting today to sort this out.
[01:47] <Kinnison> because edgy was equal to dapper
[01:47] <cprov> SteveA: okay
[01:47] <Kinnison> SteveA: noted. For reference, I am not up-to-date on daily reports, but I have the info to send out. DONE: prep for and opening edgy, TODO: more edgy related stuff, BLOCKED: no
[01:48] <Kinnison> Keybuk: care to join ##soyuz1.0 and let's deal with it there
[01:48] <SteveA> cprov: your 3 sentences please
[01:49] <cprov> SteveA: so am I, not up-to-date in activities reported: DONE initialise-from-parent-script + fixes for open edgy TODO: open edgy related issues BLOCKED: none
[01:51] <SteveA> launchpad meeting in about 8 minutes
[01:56] <mdz> SteveA: I just tried to phone kiko unsuccessfully; is he expected for the meeting as well?
[01:56] <mdz> SteveA: thanks for letting cprov get on this immediately
[01:57] <salgado> kiko just arrived here
[01:57] <SteveA> mdz: he should be here very shortly for the launchpad meeting
[01:58] <mdz> salgado: could you ask him to call me so that I can bring him up to date quickly?
[01:58] <salgado> sure
[01:59] <kiko> me
[02:00] <kiko> mdz, I think I know what happened, eh.
[02:00] <SteveA> LAUNCHPAD DEVELOPMENT MEETING
[02:00] <mdz> kiko: you are quick
[02:00] <kiko> anyway me
[02:00] <SteveA> Welcome to the thursday 8 june launchpad development meeting
[02:00] <SteveA> soyuz personnel are firefighting
[02:01] <SteveA> who else is here today?
[02:01] <bradb> me
[02:01] <carlos> me
[02:01] <spiv> me
[02:01] <SteveA> ddaa sends apologies, as he is traveling back from a sprint
[02:01] <salgado> me
[02:01] <stub> me
[02:01] <matsubara> me
[02:01] <sivang> me
[02:01] <BjornT> me
[02:01] <SteveA> mpt is on vacation
[02:01] <jamesh> me
[02:02] <SteveA> i think that's everyone accounted for
[02:02] <SteveA> == Agenda ==
[02:02] <SteveA>  * Roll call
[02:02] <SteveA>  * Agenda
[02:02] <SteveA>  * Next meeting
[02:02] <SteveA>  * Activity reports
[02:02] <SteveA>  * Actions from last meeting
[02:02] <SteveA>  * Launchpad oops milestone report
[02:02] <SteveA>  * Sysadmin requests
[02:02] <SteveA>  * Production and staging (stub)
[02:02] <SteveA> ----
[02:02] <SteveA>  * (other items)
[02:02] <SteveA> ----
[02:02] <SteveA>  * Keep, Bag, Change
[02:02] <SteveA>  * Three sentences
[02:02] <SteveA> 
[02:02] <SteveA> next meeting, one week from now
[02:02] <SteveA> any problems with that, speak now
[02:02] <SteveA>  * Activity reports
[02:03] <SteveA> i'm bad again.  i have not been formally reporting my activity.  who can do better than me? 
[02:03] <carlos> I'm up to date
[02:03] <bradb> up to date
[02:03] <matsubara> i'm up to date
[02:03] <stub> up to date
[02:03] <salgado> up to date
[02:03] <BjornT> i'm up to date
[02:03] <spiv> I'm up to date
[02:03] <malcc> me too
[02:03] <kiko> me 2
[02:04] <jamesh> I'm not up to date.  
[02:04] <SteveA> cprov reports he is not up todate
[02:04] <SteveA> Kinnison reports he is not up to date
[02:04] <SteveA> but has the info to send out
[02:04] <SteveA> MeetingAction: Kinnison to send out that info
[02:04] <Kinnison> thanks
[02:04] <SteveA>  * Actions from last meeting
[02:04] <SteveA> i didn't write up the meeting summary, but i have a rough summary here.  the actions were:
[02:05] <SteveA> MeetingAction: SteveA to write up braindump spec of how we want pqm to output stuff
[02:05] <SteveA> which i haven't done.  So that's a MeetingAction for this time as well.
[02:05] <SteveA> stub to improve the request logging code to cope with UnicodeDecode errors and log stuff
[02:05] <stub> I saw the bug logged on that but haven't dealt with it yet.
[02:05] <SteveA> BjornT: look at fixing __unicode__ of request upstream, user-agent and language headers.
[02:06] <BjornT> i didn't do that
[02:06] <SteveA> BjornT: do we have bugs filed about this in the zope collector or malone?
[02:06] <BjornT> i'll check, i don't think so. i'll make sure one is filed in the zope collector.
[02:06] <SteveA> stub: what's the bug number?  are you the assignee?  is it confirmed?
[02:07] <SteveA> MeetingAction: BjornT to get bug filed in zope collector about __unicode__ of request
[02:07] <SteveA> (on activity reports, ddaa is not up to date, as he's been in sprint meetings)
[02:07] <SteveA>  * Launchpad oops milestone report
[02:08] <SteveA> matsubara: please go ahead
[02:08] <matsubara> SteveA: the bug you're looking for is 47034
[02:08] <SteveA> thanks!
[02:08] <SteveA> but 47034
[02:08] <matsubara> the one about the UnicodeDecodeError
[02:08] <SteveA> bug 47034
[02:08] <Ubugtu> Malone bug 47034 in launchpad "We should log URLs being processed at the start of transaction" [Medium,Confirmed]  http://launchpad.net/bugs/47034
[02:08] <stub> Yer - that one
[02:08] <matsubara> at least is the one I'm using to keep track of that issue
[02:09] <matsubara> so, the oops reports, until yesterday weren't printing the line that triggered the error. Is that a known issue? compare for instance the traceback output in OOPS-156B640 and OOPS-158B395. It seems to be fixed, but I'd like to know for sure.
[02:09] <Ubugtu> https://chinstrap.ubuntu.com/~jamesh/oops.cgi/156B640
[02:09] <Ubugtu> https://chinstrap.ubuntu.com/~jamesh/oops.cgi/158B395
[02:09] <SteveA> i'm changing it to high importance
[02:09] <SteveA> because it stops some people using launchpad entirely
[02:10] <SteveA> bug 47034
[02:10] <Ubugtu> Malone bug 47034 in launchpad "We should log URLs being processed at the start of transaction" [High,Confirmed]  http://launchpad.net/bugs/47034
[02:10] <kiko> good.
[02:11] <matsubara> well moving on, jamesh, did you manage to land Steve's tickcount extension that will help us debugging Non-sql timeouts?
[02:11] <SteveA> matsubara: i don't see what you mean about comparing those two oops reports
[02:11] <salgado> so, what about the issue of not printing the last lines of the traceback?
[02:12] <matsubara> SteveA: the line where the error occurred weren't printed
[02:12] <jamesh> matsubara: I didn't have time to work on it this week.  Will try and get it into a state where we can use it next week
[02:12] <SteveA> matsubara: like:     raise WidgetsError(errors, widgetsData=result)  ?
[02:12] <matsubara> jamesh: thanks
[02:12] <matsubara> SteveA: exactly
[02:13] <SteveA> that is rather strange
[02:13] <SteveA> jamesh, stub: did you land anything that changed that
[02:13] <SteveA> ?
[02:13] <stub> Not me
[02:13] <SteveA> matsubara: maybe worth looking at the OOPS .txt files to see if the final line is there in the original
[02:14] <SteveA> matsubara: that will see if it is a problem with the formatting cgi script, or the oops generation stuff
[02:14] <jamesh> SteveA: the error report code just calls a zope function to format the exception
[02:14] <matsubara> SteveA: they're not. I already looked into it
[02:14] <SteveA> hmm
[02:14] <jamesh> SteveA: has there been any updates to our zope that might have changed things?
[02:14] <SteveA> BjornT was looking at updating something in zope
[02:14] <SteveA> for the testbrowser stuff
[02:15] <stub> We are running the old Zope still (Bjorns update of zope.testbrowser didn't go out yesterday)
[02:15] <BjornT> yeah, that was only in zope.testbrowser, nothing else
[02:15] <SteveA> then it is mysterious.  matsubara: mail the launchpad list if you notice the last line missing in future oops reports please
[02:15] <matsubara> SteveA: ok
[02:15] <matsubara> Fix bug 44872 would help debug xmlrpc exceptions. I'd like to try to fix that one if possible. Who could help me with that?
[02:16] <Ubugtu> Malone bug 44872 in launchpad "xmlrpc should use the OOPS system" [Medium,Confirmed]  http://launchpad.net/bugs/44872
[02:16] <salgado> it's not on a single oops report
[02:16] <salgado> there's lots of them with this problem
[02:16] <SteveA> salgado: yes, but as i understand it, they are all before a certain date
[02:16] <SteveA> is that so?
[02:17] <matsubara> SteveA: yes. that's what I noticed
[02:17] <salgado> well, we noticed it only yesterday
[02:17] <SteveA> if we can get a reproducable error that causes a truncated oops, then we can look into it more
[02:17] <stub> Is it using the standard Python traceback formatter, or something in Z3 to format the traceback?
[02:17] <SteveA> something in z3
[02:17] <SteveA> so that it gets the __supplement__ data
[02:18] <stub> If it is a problem, we could use the standard traceback formatter and log that output too, giving us a baseline to compare with.
[02:18] <SteveA> yeah, we can do that.  good idea
[02:20] <SteveA> it's not just that the last line is missing
[02:20] <SteveA> it is that in the newer TB, we get the line of code with each line of TB except when it is in page templates
[02:20] <SteveA> and with the older one, we just get the lines of TB
[02:20] <SteveA> actually, scratch the "except when it is in page templates"
[02:21] <SteveA> so, i don't think there's a bug here in either case
[02:21] <SteveA> but somehow we've changed what exception formatter settings we're using
[02:21] <SteveA> so, one way to work out what happened is to find the code that controls this
[02:21] <SteveA> and see with annotations who changed it and when
[02:21] <SteveA> anyway, not a bug, and i see no reason why it should change back
[02:22] <SteveA> matsubara: please continue
[02:22] <matsubara> Fix bug 44872 would help debug xmlrpc exceptions. I'd like to try to fix that one if possible. Who could help me with that?
[02:22] <jamesh> matsubara: re: the missing line numbers info, the only thing I can think of is that the .pyc files for the appserver contained invalid paths for the .py files that 
[02:22] <Ubugtu> Malone bug 44872 in launchpad "xmlrpc should use the OOPS system" [Medium,Confirmed]  http://launchpad.net/bugs/44872
[02:23] <SteveA> jamesh: good point
[02:23] <SteveA> stub: could it be related to the specific app server used?
[02:23] <jamesh> e.g. quite possible with the build-tree-then-rsync-to-app-server methodology
[02:23] <SteveA> stub: like, if the code was built on one, and then rsynced across to the other?
[02:24] <SteveA> jamesh: is there an easy way to "lint" pycs to see if they have correct path info for their sibling py files?
[02:24] <stub> jamesh: That could happen if our 'make clean' isn't clearing .pyc files, as the .pyc files could have been generated on balleny before the push out and not regenerated on the appserver.
[02:24] <SteveA> BjornT: after your current tasks, would you help matsubara with xmlrpc error reporting?
[02:24] <stub> I just checked and our push script isn't excluding them
[02:24] <BjornT> SteveA, matsubara: sure, i can do that.
[02:25] <SteveA> okay
[02:25] <SteveA> matsubara: next?
[02:25] <matsubara> Our top timeout is at $distroarchrelease/+lang page. kiko, does your work on SQLObject fixes or minimizes that?
[02:25] <jamesh> SteveA: it should be possible
[02:25] <matsubara> and thanks BjornT 
[02:26] <SteveA> matsubara: kiko's kinda busy with the firefighting, so move on and kiko will answer later
[02:26] <kiko> matsubara, yes!
[02:26] <kiko> my work does improve that
[02:26] <kiko> it's actually rather broken
[02:26] <carlos> matsubara: that page needs to be using batching
[02:26] <kiko> and there's an API change I can make to avoid querying
[02:26] <kiko> carlos, maybe.
[02:26] <carlos> matsubara: it's near 800KB
[02:26] <kiko> wow
[02:27] <matsubara> indeed the bug reported about it says that
[02:27] <carlos> mark is against using batching there
[02:27] <carlos> but I think we MUST do it
[02:27] <SteveA> or find a way to cache it
[02:27] <carlos> kiko: the only problem with batching there is that the sort functionality will be lost
[02:27] <SteveA> and perhaps represent it in a more compact form
[02:27] <kiko> we could cut down the html
[02:27] <carlos> SteveA: downloading 800KB to load that page is still too much
[02:28] <carlos> yeah, trying to reduce its size would be another option, yes
[02:28] <SteveA> we must get a move on
[02:28] <SteveA> several more agenda items
[02:28] <matsubara> ok, I'm done. Thanks guys.
[02:28] <carlos> but I think the problem is the amount of links we have there
[02:28] <SteveA> thanks matsubara 
[02:28] <stub> And any unbatched page is a bug waiting to happen unless we have a max number of items that can possibly be displayed.
[02:28] <jordi> hi!
[02:28] <SteveA> hi jordi 
[02:28] <SteveA>   * Sysadmin requests
[02:28] <jordi> I had to be away for a while
[02:28] <SteveA> 8
[02:29] <SteveA> 7
[02:29] <SteveA> 6
[02:29] <SteveA> 5
[02:29] <carlos> SteveA: I sent yesterday the bzr update in asuka
[02:29] <SteveA> 4
[02:29] <jordi> I'm up to date on activity reports
[02:29] <SteveA> thanks carlos 
[02:29] <SteveA> 3
[02:29] <kiko> SteveA, I have a number of permission rts
[02:29] <SteveA> 2
[02:29] <SteveA> permission?
[02:29] <Hobbsee> thanks for the "sort by most recently changed" guys!  Much appreciated!
[02:29] <kiko> I think that request access for salgado and matsubara to certain boxes
[02:29] <kiko> Hobbsee, enjoy!
[02:29] <bradb> Hobbsee: no prob :)
[02:29] <SteveA> ah, right
[02:29] <Hobbsee> :D
[02:29] <SteveA> kiko: are they urgent?
[02:29] <SteveA> i know that the admins have had a very busy spell, but are more available now
[02:30] <SteveA>  * Production and staging (stub)1
[02:30] <SteveA> 1
[02:30] <carlos> SteveA: oh, and would be good if I would get access to drescher.ubuntu.com
[02:30] <SteveA> 0
[02:30] <SteveA>  * Production and staging (stub)
[02:30] <stub> Nothing interesting happening with staging - business as usual.
[02:30] <stub> Production rollout went fine. I expect there to be a rollout next Wednesday using whatever has landed on Friday. Connection ids are now being logged in the OOPS reports so we will be able to see if connections are being used as they should or if they are being shared where they shouldn't. Next daily report might have some out-of-order-sql issues which will be interesting to look at.
[02:30] <carlos> SteveA: to debug OO.org language packs
[02:30] <SteveA> carlos: RT ticket number?
[02:31] <carlos> SteveA: I didn't send it, doko asked to elmo yesterday, But I guess I should send the RT email....
[02:31] <SteveA> carlos: it must be in RT
[02:31] <carlos> ok
[02:31] <carlos> will send the request after the meeting
[02:31] <SteveA>  * other items
[02:31] <SteveA>  - reviewer voip calls
[02:31] <kiko> SteveA, not really, but pending.
[02:32] <SteveA> quick poll: who has made a call with a reviewer to discuss code so far?  say "called $name" if you've made a call, say "reviewed $name" if you're a reviewer and have accepted a call.  say "not called" if you haven't made or accepted a call.
[02:32] <SteveA> not called
[02:32] <stub> not called
[02:32] <bradb> not called
[02:32] <matsubara> not called
[02:32] <spiv> called jamesh
[02:32] <BjornT> called kiko
[02:32] <jamesh> reviewed spiv
[02:32] <BjornT> reviewed carlos
[02:33] <salgado> not called
[02:33] <malcc> not called
[02:33] <carlos> called BjornT
[02:33] <SteveA> bradb, bjorn: please have a call together today 
[02:33] <kiko> bradb's going to call me though
[02:33] <kiko> he wants me
[02:33] <SteveA> cool
[02:34] <SteveA> did you give him your number?
[02:34] <SteveA> the one you actually answer?
[02:34] <kiko> ha ha
[02:34] <SteveA> bradb, BjornT: i'd like you guys to have a call every day, just 15-30 mins depending on what's to discuss
[02:34] <SteveA> see how it goes for a week.  5 calls.
[02:34] <BjornT> sure
[02:34] <bradb> sounds good
[02:35] <SteveA> matsubara, stub: i'd like to get you two talking on skype.  QA and production should have lots in common
[02:35] <stub> I've cleared the .pyc's and bounced the appserver so if James' theory is correct the oops reports should be fixed
[02:36] <SteveA> salgado: i think we had a call about shipit stuff.  or was that on irc?
[02:36] <salgado> that was a call
[02:36] <salgado> a voip call
[02:36] <SteveA> cool, that counts :-)
[02:36] <SteveA> so, just malcc and perhaps cprov and Kinnison to have a call still
[02:36] <SteveA> maybe try a soyuz conf call sometime?
[02:37] <SteveA> okay... next item
[02:37] <malcc> Sounds good
[02:37] <SteveA>  * launchpad summer (northern hemisphere) sprint dates
[02:37] <SteveA> kiko: go ahead
[02:38] <kiko> wonderful
[02:38] <kiko> a flowery nymph whispered some sprint dates into my ear yesterday
[02:39] <kiko> I'd like to show the dates and preliminary lists of people
[02:39] <malcc> Did she also promise to attend?
[02:39] <kiko> https://chinstrap.ubuntu.com/~dsilvers/paste/file0wdMT8.html
[02:39] <SteveA> a succubus came to you in the night
[02:39] <kiko> now the list of attendees are strong suggestions but there is some room to add or remove people depending on interest and availability
[02:39] <jamesh> do the stars have a significance?
[02:39] <kiko> the stars mean "maybe"
[02:40] <kiko> maybe. :)
[02:41] <SteveA> more on this after the meeting, if there are issues or questions
[02:41] <stub> Do we know if we are stuck in London?
[02:41] <SteveA> we are
[02:41] <kiko> it is all london
[02:41] <kiko> ALL LONDON
[02:41] <SteveA> i want to see if the cute blonde latvian receptionist is still there 
[02:42] <kiko> so the theme song for this announcement is track 4 on the chemical brother's latest album
[02:42] <SteveA>   * Keep, Bag, Change
[02:42] <sivang> heh
[02:42] <carlos> kiko: the first one is in Paris :-P
[02:42] <stub> I'll need to take a few days leave after to pick up a fresh visa in Penang
[02:42] <stub> I'll swap someone Paris for London
[02:42] <SteveA> with a countdown for KBC
[02:42] <SteveA> 6
[02:42] <SteveA> 5
[02:42] <SteveA> 4
[02:42] <stub> And throw in a latvian receptionist
[02:42] <SteveA> 2
[02:43] <carlos> Change: kill canonical.supermirrorsftp.tests. creation with every test run
[02:43] <SteveA> spiv: please!
[02:43] <stub> Bag: London sprints
[02:43] <SteveA> 1
[02:43] <SteveA> MeetingAction: carlos ^^^
[02:43] <jamesh> stub: it'll be summer this time
[02:43] <SteveA> 0
[02:43] <SteveA> okay
[02:43] <SteveA>  * Three sentences
[02:43] <jamesh> DONE: code reviews, work on bugs 45987 (record branch scan timestamps), 46306 (getBranchPullQueue test robustness) and 45984 (branch pull queue ordering)
[02:43] <jamesh> TODO: code reviews, finish work on above bugs, get tickcount extension ready
[02:43] <jamesh> BLOCKED: no
[02:43] <salgado> DONE: Found and fixed a bug in the mirror prober that was preventing it to check lots of mirrors at once, fixed bugs that were causing OOPSes on shipit, lots of phone calls/IRC about shipit, improved some other things on shipit to help Marilize
[02:43] <salgado> TODO: Do the fixes I discussed with Steve on a voip call so that we can finally have the db constraint to fix bug 5812, some other small fixes on shipit and any other bugs shipit and/or mirror prober bugs that show up
[02:43] <salgado> BLOCKED: No
[02:43] <BjornT> DONE: various bug fixes, landed my pending branches. reviews.
[02:43] <BjornT> TODO: fix bug 32282 (reduce long comments). add bug tracker to products.reviews.
[02:43] <BjornT> BLOCKED: no
[02:43] <spiv> SteveA, carlos: ok
[02:43] <Ubugtu> Malone bug 45987 in launchpad-bazaar "supermirror branch scanner should record last scanned timestamp" [High,Confirmed]  http://launchpad.net/bugs/45987
[02:43] <stub> jamesh: In that case I promise to not slit my wrists
[02:44] <malcc> DONE: process-upload tidying work, understanding Soyuz
[02:44] <carlos> DONE: Finished POMsgSetPage using the standard batch code,  bug #40550, #47824, #47080, #46459, #47870, #35631, Distribution translation focus, Discussion with doko about oo.org problems, pre-implementation call about #44214, phone call with pitti about language packs for universe
[02:44] <malcc> TODO: nascentupload tidying work, understanding Soyuz
[02:44] <malcc> BLOCKED: No
[02:44] <carlos> TODO: Fix #44214, Fix OO.org language packs, write a spec about language packs for universe, Remove the restriction in Rosetta so we can import universe translations
[02:44] <carlos> BLOCKED: No
[02:44] <SteveA> Kinnison: DONE: prep for and opening edgy
[02:44] <SteveA> Kinnison: TODO: more edgy related stuff
[02:44] <SteveA> Kinnison: BLOCKED: no
[02:44] <bradb> DONE: Fixed various bugs. Malone xmlrpc. Requirements discussions.
[02:44] <bradb> TODO: Hopefully get xmlrpc running on mawson. Implement release bug management. Fix OOPS bugs, etc.
[02:44] <bradb> BLOCKED: No.
[02:44] <matsubara> DONE: fixed some oops bugs, oops report analysis, triage
[02:44] <spiv> DONE: Reviews, helped salgado with Twisted stuff, work on bug 33223
[02:44] <spiv> TODO: bug 33223, bug 48813, bug 44869, bug 36879, bug 36888 -- and kill canonical.supermirrorsftp.tests garbage.
[02:44] <matsubara> TODO: more of the same
[02:44] <spiv> BLOCKED: no
[02:44] <matsubara> BLOCKED: no
[02:44] <stub> DONE: Bug fixes, firefighting, text search work
[02:44] <stub> TODO: Text search work
[02:44] <stub> BLOCKED: Nope
 DONE: some cscvs/native-bzr
 TODO: more cscvs/native-bzr
 BLOCKED: no
[02:44] <Ubugtu> Malone bug 32282 in malone "Try to reduce of the amount of LONG comments" [Medium,In progress]  http://launchpad.net/bugs/32282
[02:44] <Ubugtu> Malone bug 40550 in rosetta "Further filtering options for the Queue" [Medium,In progress]  http://launchpad.net/bugs/40550
[02:44] <Ubugtu> Malone bug 47824 in ktorrent "translations in rosetta are broken" [Medium,Rejected]  http://launchpad.net/bugs/47824
[02:44] <Ubugtu> Malone bug 47080 in amarok "translation in rosetta are broken" [Medium,Fix released]  http://launchpad.net/bugs/47080
[02:44] <kiko> DONE: SQLObject hackery, database class deXXXification, sprint date arrangement, management, interviews, bug triage, you know, the usual
[02:44] <Ubugtu> Malone bug 46459 in rosetta "potemplate exports are empty" [Medium,Fix committed]  http://launchpad.net/bugs/46459
[02:44] <Ubugtu> Malone bug 47870 in language-pack-gnome-es-base "Incorrect date layout" [Medium,Fix committed]  http://launchpad.net/bugs/47870
[02:44] <Ubugtu> Malone bug 33223 in launchpad-bazaar "SFTP server should give human-friendly errors for name restrictions" [Medium,Confirmed]  http://launchpad.net/bugs/33223
[02:44] <Ubugtu> Malone bug 33223 in launchpad-bazaar "SFTP server should give human-friendly errors for name restrictions" [Medium,Confirmed]  http://launchpad.net/bugs/33223
[02:44] <Ubugtu> Malone bug 48813 in launchpad-bazaar "Mirroring sftp hosted branches takes much too long" [Untriaged,Unconfirmed]  http://launchpad.net/bugs/48813
 DONE: initialise-from-parent-script + fixes for open edgy
 TODO: open edgy related issues
 BLOCKED: none
[02:44] <jordi> DONE: email, lists, inviting wxwidgets + gaim to join rosetta, queue processing, IRC meetings
[02:44] <Ubugtu> Malone bug 44869 in bzr "pushing to team-shared sftp bazaar branch fails with IOError" [Medium,Unconfirmed]  http://launchpad.net/bugs/44869
[02:44] <Ubugtu> Malone bug 36879 in launchpad-bazaar "rmdir confuses supermirror" [Medium,Unconfirmed]  http://launchpad.net/bugs/36879
[02:44] <Ubugtu> Malone bug 36888 in launchpad-bazaar "supermirror sftp shows branches for non-hosted branches" [Medium,Confirmed]  http://launchpad.net/bugs/36888
[02:44] <kiko> TODO: finish my SQLObject sprint, land deXXXifications, some performance work, and the launchpad report
[02:45] <jordi> TODO: queue clearing, weeding out product translations that need to be disabled
[02:45] <jordi> BLOCKED: no
[02:45] <kiko> BLOCKED: salgado refuses to review my code!
[02:45] <SteveA> DONE: management, JS debugging for menus, menus implementation, reviews
[02:45] <SteveA> TODO: menus testing with production data
[02:45] <SteveA> BLOCKED: no
[02:45] <SteveA> okay...
[02:45] <SteveA> i think that's all folks
[02:45] <salgado> kiko, I'm going to do it today, for sure. I didn't review it yesterday because I needed to finish that shipit changes
[02:46] <SteveA> countdown of doom
[02:46] <SteveA> 6
[02:46] <SteveA> 5
[02:46] <SteveA> 4
[02:46] <SteveA> 3
[02:46] <SteveA> 2
[02:46] <SteveA> 1
[02:46] <SteveA> thusa sez: MEETING ENDS
[02:46] <jordi> SALGADO
[02:46] <SteveA> thulsa sez: MEETING ENDS
[02:46] <bradb> kthxbye
[02:46] <salgado> JORDI
[02:47] <kiko> salgado, yeah yeah
[02:47] <jamesh> kiko: did you see my reply on Monday about that two-oops-in-one-request issue you mailed about?
[02:47] <kiko> jamesh, yes, I appreciated that (but I was not sure what to do with the answer :)
[02:47] <kiko> sorry for not replying
[02:48] <kiko> my inbox is in a sorry state
[02:48] <jamesh> kiko: as I see it, (a) fix LaunchBag.user to work when no interaction is in process, and (b) work out how to trigger the problem in a test
[02:49] <kiko> b) sounds harder than a)
[02:49] <SteveA> well
[02:49] <SteveA> it is very dodgy to render a page when there is no interaction for the thread
[02:50] <SteveA> so i would rather not fix LaunchBag.user for this
[02:50] <SteveA> but instead ensure that we have an interaction when rendering error pages
[02:50] <stub> If there is no interaction, LaunchBag.user should be None. The only problem I see is if it is a cachedproperty
[02:50] <spiv> kiko: I see I'm marked as a maybe for the sprint ending July 28th -- I have a flight booked very early on July 29th (Sydney time) to get to my holiday, so I'd have to leave on the 27th if I did go.
[02:50] <jamesh> SteveA: the page being rendered is oops.pt, and it is in response to a transaction serialisation error in the session setup code
[02:52] <kiko> spiv, that's a maybe attendence. I suggest you take that up with SteveA 
[02:53] <spiv> kiko: ok, thanks.
[02:53] <SteveA> spiv: and i'm going to point you at mpool for that :-)
[02:53] <spiv> SteveA: ?
[02:54] <SteveA> spiv: it depends on your contributions to bzr etc., so whether mpool thinks you should attend the sprint at all
[02:54] <kiko> well
[02:54] <spiv> Ah, I see.
[02:55] <kiko> spiv, there's also the fact that mark suggested you'd like working with ddaa for a while
[02:55] <SteveA> stub: I agree that LaunchBag.user should be None outside of an interaction
[02:55] <SteveA> i also think that we shouldn't render any pages at all when there is no interaction for that thread
[02:59] <spiv> kiko: Yeah, that could be good, but perhaps another time would work out better... maybe after the infrastructure meeting?  Anyway, it's late here, I just wanted to warn as far as possible in advance.
[02:59] <kiko> spiv, yes it's late and you haven't reviewed my patch yet!
[02:59] <spiv> Heh.
[02:59] <spiv> You have a one-track mind.
[03:00] <spiv> And all it does is produce patches for me to review! ;)
[03:00] <kiko> I have done MANY other things this week
[03:00] <kiko> but you have been on my mind constantly
[03:04] <kiko> spiv, is all this chit-chat devised to make me forget about the pending review? :)
[03:25] <kiko> spiv, the only thing I want to see is "add more tests and r=spiv"
[03:27] <spiv> kiko: it's actually looking pretty good, but it's complex so it takes a lot of time to read.
[03:30] <kiko> yay!
[03:30] <kiko> I just fixed that XXX in my code
[03:30] <kiko> spiv, https://chinstrap.ubuntu.com/~dsilvers/paste/fileDAq3ZT.html
[03:31] <kiko> that's the only thing that changed
[03:31] <kiko> I dreamed on how to fix that XXX
[03:31] <kiko-afk> afk for a sec
[03:55] <matsubara> bradb: ping
[04:03] <spiv> kiko-afk: sent.  enjoy!
[04:25] <bradb> matsubara: pong (have to leave right away)
[04:26] <matsubara> bradb: have you seen bug 48996?
[04:26] <Ubugtu> Malone bug 48996 in malone "Comment on change is broken when don't change anything" [High,Confirmed]  http://launchpad.net/bugs/48996
[04:26] <matsubara> bradb: I'll assign it to you, ok?
[04:26] <bradb> matsubara: sure
[04:31] <kiko-afk> spiv, many thanks
[04:32] <siretart> is there a spec which describes how I can use the supermirror? I'd like to branch from imported projects, namely this branch: https://launchpad.net/products/xine-lib/head
[04:38] <sabdfl> siretart: smart guy :-)
[04:38] <sabdfl> look at the branch details
[04:39] <sabdfl> should be as simple as bzr branch <url>; bzr commit, bzr commit, bzr commit,... bzr push <sftp://url>
[04:39] <sabdfl> it needs a bit of work and polish
[04:39] <sabdfl> but this will be a great service soon
[04:39] <sabdfl> spiv and ddaa are working on it if you have more questions
[04:39] <sabdfl> ok?
[04:39] <siretart> sabdfl: what would be <url> for this case?
[04:39] <sabdfl> hmm... look at the product page, click "Branches", click on the branch, there's a url you can cut and paste
[04:40] <sabdfl> it's a bit slow at the moment
[04:40] <sabdfl> will be fast for 1.0, by end of August-ish
[04:40] <sabdfl> the push URL is an sftp URL at Launchpad
[04:40] <sabdfl> spiv will get you the details
[04:40] <ajmitch> looks rather useful
[04:40] <sabdfl> could you turn whatever they tell you into a short wiki page summarizing the experience?
[04:40] <siretart> https://launchpad.net/products/xine-lib/+branches tells me that there were no branches registered for this product :/
[04:41] <sabdfl> ok, so it is not being imported
[04:41] <sabdfl> talk with ddaa
[04:41] <siretart> allright, will do
[04:41] <jsgotangco> hmm thought supermirror used sftp
[04:41] <siretart> just wanted to experiment with that feature. thanks a lot for this service!
[04:42] <jsgotangco> hence you need paramiko
[04:42] <jsgotangco> or does it do http as well?
[04:42] <ajmitch> looks to do http for branching 
[04:42] <ajmitch> since it has a few changes I want to get into dapper-updates :)
[04:43] <ajmitch> we'll see if it's up-to-date, the revision history on the page doesn't look promising
[04:44] <jsgotangco> i tried checking out my mentee's archive in supermirror but i get authentication errors on his side, but i promised him i'll sort it out later
[04:45] <ajmitch> yeah, I should look at getting my soc code on launchpad once there's something to speak of
[04:46] <ajmitch> though plenty of what I want would be done with personal package archives & then stuck in edgy :)
[04:48] <jsgotangco> although i am rather embarrassed a bit to my mentee because i told him im more useful on feature and usability guidance rather than code
[04:49] <ajmitch> what one are you mentoring?
[04:49] <ajmitch> ah, the quiz one?
[04:49] <jsgotangco> yes
[04:50] <jsgotangco> we've done some stuff already and collaborating on improving the look in glade
[04:51] <sabdfl>     /home/mark/lptrees/development/meeting-agenda-nominator/lib/canonical/launchpad/pagetests/standalone/xx-pofile-translate-html-tags-escape.txt
[04:51] <sabdfl>     test_tearDownDatabase (canonical.launchpad.ftests.test_pages.EndStory)
[04:51] <sabdfl>     test_setUpDatabase (canonical.launchpaTests hung - no output for 600 seconds. Killing.
[04:51] <sabdfl> SteveA: ?
[04:51] <sabdfl> Not dead yet! - slaughtering mercilessly
[04:51] <sabdfl> that normal?
[04:53] <kiko-afk> oh that happened to me as well yesterday
[04:53] <kiko-afk> I'm not sure why
[04:57] <sabdfl> ok
[04:57] <sabdfl> i'll try run them again
[06:07] <salgado> so, kiko-afk, let's exchange some diffs? you send me your new one and I review it and I send you my shipit one for you to review
[06:07] <salgado> how does it sound?
[06:08] <highvoltage> hi #launchpad
[06:08] <highvoltage> ogra told me yesterday that you can't sign the CoC with an unsigned GPG key, but I've done it in the past, and just did it today again.
[06:09] <highvoltage> he said that if I can do it, I should log a bug.
[06:09] <salgado> highvoltage, no, that's not a bug. that's how it's supposed to work
[06:09] <highvoltage> i just want to check first if this is indeed a bug, or if this is intentional.
[06:09] <highvoltage> ok, thanks.
[06:10] <salgado> and thanks for asking here before. :)
[06:10] <highvoltage> np
[06:12] <kiko-afk> salgado, it sounds like all I will do today is reviewing :-(
[06:15] <salgado> that's good... no context switching. :)
[06:24] <kiko-afk> salgado, BjornT, SteveA, bradb: help fixing this:
[06:24] <kiko-afk> There were 3 imports of names not appearing in the __all__.
[06:24] <kiko-afk> You should not import alsoProvides from zope.interface:
[06:24] <kiko-afk>     canonical.launchpad.components.bugtask
[06:24] <kiko-afk>     canonical.launchpad.database.bugtask
[06:24] <kiko-afk>     canonical.launchpad.database.person
[06:24] <kiko-afk> what should I do?
[06:25] <bradb> my guess would be to import it from zope.interface.declarations
[06:27] <BjornT> kiko-afk: hmm, alsoProvides probably should be added to IInterfaceDeclaration. for now, bradb's suggestion should do.
[06:31] <kiko-afk> thanks!
[07:29] <SteveA> BjornT: maybe you can fix IInterfaceDeclaration upstream when you do the unicode fix
[07:30] <BjornT> SteveA: sure, i'll do that.
[07:30] <SteveA> cool
[07:31] <SteveA> if you are not going to do it immediately, please open a collector issue or malone issue for it
[07:36] <BjornT> ok, i'll probably fix it tomorrow, i'll open an issue meanwhile.
[07:39] <BjornT> oh, it's already fixed upstream. i'll see if the fix is self-contained so we can pull it in easily.
[07:42] <SteveA> kiko-fud: ping
[07:43] <SteveA> BjornT: should just be a new zope.interface
[07:43] <SteveA> jamesh: still around at all?
[09:10] <kiko> SteveA, pong?
[09:10] <kiko> what's up?
[09:38] <cprov> kiko: insta-review, https://chinstrap.ubuntu.com/~dsilvers/paste/fileCwlSKh.html, thank you ;)
[09:38] <kiko> cprov, self.policy.checkUpload(self)
[09:38] <kiko> that should be the name of the method
[09:38] <kiko> +            "Policy specifics checks must be implemented in child policies.")
[09:38] <kiko> -> Policy specific checks
[09:39] <kiko> +    @property
[09:39] <kiko> +    def is_released(self):
[09:39] <kiko> -> isOpenForUploads()
[09:39] <kiko> is_released is confusing because the status may actually not be released
[09:41] <kiko> cprov, are we missing asserts in other places?
[09:42] <cprov> kiko: okay .. will fix
[09:42] <cprov> isOpenForUploads is boring :(
[09:42] <kiko> looks very very good
[09:42] <kiko> b_a
[09:42] <kiko> call it breezy_autotest
[09:43] <kiko> okay I'll explain
[09:43] <cprov> kiko: no, I don't think we allow uploads via other paths
[09:43] <kiko> I /hate/ methods like that
[09:43] <kiko> but in this case
[09:43] <kiko> there is nothing else we  can do about it
[09:43] <kiko> okay
[09:43] <kiko> so the policies already check it
[09:43] <kiko> and nascentupload and the queue tool will now blow up if they try to accept the package, right?
[09:44] <cprov> key place it IDRQ.setAccepted
[09:44] <kiko> cprov, what about process-accepted? is it worth protecting there?
[09:44] <kiko> cprov, or is it too late by then?
[09:44] <kiko> cprov, and what about the build scanner, shouldn't we use it there as well, or should it be something else?
[09:44] <cprov> kiko: it only move introduce accepted queue items to SSPPH
[09:45] <kiko> cprov, process-accepted creates the SSPPH entries? I think it would be nice to have an assert there. just in case. ;)
[09:45] <cprov> kiko: I can assert in IDRQ.publish  then
[09:45] <kiko> cprov, sounds perfect
[09:46] <cprov> slavescanner sounds confusing right now, handles huge set of stuff, it's easier to deny access via the p-u itself when collecting binaries
[09:51] <cprov> kiko: isOpenForUploads is wrong, because it is isOpenForUploadsInReleasePocket .... so my vote it to remove this method (there is no call site in this change)
[09:51] <kiko> hmmm. 
[09:51] <kiko> I /think/ okay
[09:52] <kiko> cprov, I think the slavescanner should do a check
[09:52] <kiko> otherwise how will you avoid it trying to build the dapper release stuff?
[09:52] <cprov> kiko: good, okay, give me some minutes to find the best place fo ss 
[09:52] <kiko> cool.
[09:52] <kiko> cprov, actually, do it as a separate patch if you want
[09:53] <cprov> kiko: good idea, let me fix the current one
[09:53] <kiko> smaller patches are gooder
[09:59] <kiko> https://launchpad.net/products/k2-nb-no
[09:59] <kiko> tada!
[10:03] <cprov> kiko: again https://chinstrap.ubuntu.com/~dsilvers/paste/fileGmhHCh.html
[10:04] <kiko> cprov, s/policyCheckUpload/checkUpload/
[10:04] <kiko> as I said before (three times :-P)
 cprov, self.policy.checkUpload(self)
[10:04] <cprov> kiko: okay, just wanted to be clever :(
[10:05] <kiko> cprov, well, the thing is, the code already makes it clear that it is on a policy
[10:05] <kiko> self.policy.checkUpload()
[10:05] <kiko> so the policy ends up being redundant
[10:05] <kiko> it is already on a policy object
[10:05] <cprov> kiko: yes, yes, realized it 
[10:05] <kiko> +is_released and canUploadToPocket are a property and a method,
[10:05] <kiko> cprov, is_released is gone
[10:06] <kiko> cprov, r=kiko very nice change
[10:06] <kiko> very nice indeed
[10:06] <cprov> kiko: that's why text document as __bad__ they pass on test
[10:07] <kiko> cprov, heh, well, use grep when you remove stuff. :)
[10:08] <cprov> kiko: oh, futuristic developments tools ;), thank you for the quick review 
[10:14] <bradb> kiko: What are the chances of you reviewing the perms patch today? I could pluck it from BjornT's queue if you have time.
[10:15] <kiko> bradb, is it the one you gave me yesterday in a pastebin?
[10:15] <bradb> yer
[10:15] <kiko> I am likely to do it
[10:15] <bradb> woo
[11:07] <cprov> kiko: fresh diff for assertions in builddmaster land -> https://chinstrap.ubuntu.com/~dsilvers/paste/filetDdSXX.html
[11:20] <kiko> reviewed
[11:21] <kiko> bradb, salgado: I have prioritized soyuz stuff because it's zero-day but I'm moving on to yours now
[11:21] <bradb> woo
[11:25] <kiko> bradb, what does this patch do?
[11:25] <bradb> Importance permission!
[11:25] <kiko> gotcha.
[11:28] <kiko> bradb, I really don't like the fieldNames manipulation. is there a way to do this in a better way?
[11:28] <kiko> I can see you are already cleaning up
[11:28] <kiko> I am just trying to see if we know of a way to clean up further
[11:29] <kiko> bradb, can you place the entire new method in a pastebin for me?
[11:29] <bradb> sure
[11:30] <kiko> it's hard to read the diff
[11:30] <kiko> or maybe it's all this blood in my eyes
[11:31] <bradb> kiko: https://chinstrap.warthogs.hbd.com/~dsilvers/paste/fileH2JJR4.html
[11:32] <kiko> argh my eyes are burning!
[11:32] <kiko> this method looks like an umbrella
[11:33] <bradb> it's pretty simple, actually
[11:33] <bradb> particularly because of the refactoring i did
[11:33] <kiko> it's better I agree
[11:34] <kiko> but pretty simple is pushing it!
[11:34] <kiko> okay
[11:34] <kiko> bradb, would you be against moving the _widget* crap out of the else clause
[11:34] <kiko> and then having something like:
[11:35] <kiko>    edit_field_names, display_field_names = self._calculateFieldNames()
[11:36] <kiko> it would make the method simpler, keep the widget setup inside it, and allow me to read it without crying
[11:37] <bradb> I'm going to take one more run at that method right now.
[11:37] <kiko> okay.
[11:37] <kiko> you do it, hit it hard and it may not get up again
[11:48] <kiko> bradb, sent review of everything but the girl
[11:59] <bradb> kiko: thanks, was just going through it
[11:59] <bradb> BjornT: do you know why you have to call logout() after you login(), if you want to do a browser.addHeader("Authorization", ...) after that?