=== mpt_ [n=mpt@203.118.156.188] has joined #launchpad [12:25] re === niemeyer [n=niemeyer@200.193.155.149] has joined #launchpad [12:29] kiko: had a chance to review my patch ? [12:30] sivang, you must have gotten your email by now no? [12:31] kiko: yes, I have, reading it now, damn thunderbird doesn't refresh the mbox if you don't go out of it and reclick the mbox folder. === sivang is reading. [12:35] cool. [12:38] kiko: okay, so you'd rather I merged the test to one of the existing tests regarding the spec tracker or better, change an existing test that already tests for the status of a spec upon cretion? [12:38] creation, even [12:38] exactly. === dsas [n=dean@host86-129-14-249.range86-129.btcentralplus.com] has joined #launchpad [12:50] kiko: cool, however before that, running make check still failes and I'd like to know why. just after pagetests/foaf/20-make-team-moderated.txt , it says it was hung for 600 secs, and then got killed mercilessly. How can I drill down to the source of this? [12:50] kiko: (I gotta make sure this is not related to something I've changed) [12:52] sivang, it's not, you can be sure. it's something else (and it's weird) [12:52] kiko: also note that sivang's branch is outdated [12:52] yeah, I know. [12:53] kiko: okay, good to know. [12:57] night all, see you tomorrow [12:57] night matsubara === Keybuk [n=scott@quest.netsplit.com] has joined #launchpad === niemeyer [n=niemeyer@200.193.155.149] has joined #launchpad === jsgotangco [n=jsg123@ubuntu/member/jsgotangco] has joined #launchpad [01:16] kiko: is it okay to merge old style tests with testbrowser stuff? [01:16] kiko: as in, have a pagetest all in the old method, and have one testbrowser action in [01:17] sivang, change the old pagetest to be testbrowsered! [01:18] kiko: I know I know :p bonus points are given even, I was going to, but what if I have a way out of it by just replacing the two occurences you've found with grep -ril , which incidently cater for testing that a sepc by default is statused as 'New' ? :) [01:19] kiko: (although that feels like editing a patch that was created with dpatch, e.g. feels somewhat wrong) [01:20] sivang, you could do that, but then your patch would be less cool! [01:22] hmm, wonder at that google code thing [01:24] kiko: agreed. MOreoer, realizing how ugly the old ones compared to the new test browser makes me wanna turn all the test there to the new format, after I finish with this patch. [01:28] anyway, continue this tomorrow, it's sleep time. [01:29] good night all, thanks kiko. [01:30] night sivan === _mholthaus [n=mholthau@johnny33.dersbach.ch] has joined #launchpad === mholthaus_ [n=mholthau@johnny33.dersbach.ch] has joined #launchpad === niemeyer [n=niemeyer@200.193.155.149] has joined #launchpad === rpedro_ [n=rpedro@87-196-73-153.net.novis.pt] has joined #launchpad === niemeyer [n=niemeyer@200.193.155.149] has joined #launchpad === niemeyer [n=niemeyer@200.193.155.149] has joined #launchpad === jsgotangco [n=jsg123@ubuntu/member/jsgotangco] has joined #launchpad === chaddy_ [n=chaddy@host81-132-76-226.range81-132.btcentralplus.com] has joined #launchpad [03:34] o/ === niemeyer [n=niemeyer@200.193.155.149] has joined #launchpad === stub [n=stub@ppp-58.8.2.93.revip2.asianet.co.th] has joined #launchpad === ChanServ [ChanServ@services.] has joined #launchpad [04:48] lifeless: wierd. pqm-submit is choosing the wrong target branch. https://sodium.ubuntu.com/~andrew/paste/file0z53Qp.html [04:48] I think spiv: had that the other day [04:49] I'm about to ensure I'm running the current version of the plugin, as per the wiki [04:49] That sourcecode/bzr subtree is always causing trouble. It was also being pushed along with the launchpad tree as well (open bug on that I think...) [04:50] how are you pushing? [04:55] rsyncing the entire repository now. The extraneous sourcecode/bzr push I can't remember. === stub looks for the bug report [04:55] spiv: any input for stub ? [04:58] lifeless: you fixed it for me last time. [04:59] stub: in my case, I think it was that my branches.conf had a section that matched the branch specifically, meaning that bzr didn't read the config for the containing directory (i.e. the config our wiki page tells you to add), so pqm-submit just falls back to assuming you want to submit to bzr.dev. [05:00] stub: deleting the unnecessary specific entry for my branch in branches.conf fixed it. [05:00] [/home/stub/.canonical-bzr/launchpad/PostgreSQLSession] [05:00] push_location = sftp://sodium/home/warthogs/archives/stub/launchpad/PostgreSQLSession === stub nukes it [05:02] That seems to be the trick. So bzr push breaks bzr pqm-submit (at least in our setup) [05:02] It should still figure out the right push_location without that, because of the public_repository setting. [05:07] Bug 54161 [05:07] Malone bug 54161 in bzr-pqm "If pqm_branch is not configured for branch path, check if it is configured for the repository path" [High,Confirmed] http://launchpad.net/bugs/54161 === ChanServ [ChanServ@services.] has joined #launchpad === ChanServ [ChanServ@services.] has joined #launchpad === mpt__ [n=mpt@203.118.156.188] has joined #launchpad === mpt_ [n=mpt@203.118.156.188] has joined #launchpad === raphink [n=raphink@ubuntu/member/raphink] has joined #launchpad === mpt [n=mpt@203.118.156.188] has joined #launchpad [07:49] lifeless: Can I get pqm rights to merge to rocketfuel/zope/3.2? Or should I just do it manually on balleny === stub investigates pqm.conf and gives himself access === Fujitsu [n=Fujitsu@c58-107-168-5.eburwd7.vic.optusnet.com.au] has joined #launchpad === raphink [n=raphink@ubuntu/member/raphink] has joined #launchpad === raphink [n=raphink@ubuntu/member/raphink] has joined #launchpad [08:30] spiv: Does https://sodium.ubuntu.com/~andrew/paste/fileIAwj0M.html look familiar? Its on my librarian-layer branch, so I probably broke something. [08:33] morning [08:35] stub: is your Twisted up to date? [08:35] stub: because an old Twisted would cause that. [08:36] Probably not. Ta. [08:38] stub: not sure if I told ya, but what was failing make schema was dash which is now default in edgy. [08:40] stub: (it's replacing bash) [08:40] Hmm, database/schema/Makefile does do a fair bit of shell stuff. [08:42] spiv: yes, so for edgy either we set up the shell at the top of each snippet or document somewhere to use bash instead of dash [08:44] sivang: or we make our shell usage posixly correct. [08:51] spiv: or that :) [08:59] does anyone else find LP's karma system to be slightly insane at the moment? === rpedro_ [n=rpedro@87-196-40-71.net.novis.pt] has joined #launchpad === mpt_ [n=mpt@203.118.156.188] has joined #launchpad [09:08] Kamping_Kaiser, what aspect of it? [09:08] sivang: https://sodium.ubuntu.com/~andrew/paste/filesj6IVH.html seems to make it work with bash and dash for me. [09:09] sivang: there may be a cleaner fix. [09:10] spiv: could forward that to me by email? sivan _AT_ ubuntu dot com? [09:10] Fujitsu, the number of points going around - i went from 10k -> 110k in ~2 weeks of not doing anything... that means something i've done has recieved *lots* of extra points in the latest scoreshift. [09:10] the numbers basicly meaningless :) [09:10] sivang: sure. [09:13] spiv: thanks === malcc [n=malcolm@host86-134-233-12.range86-134.btcentralplus.com] has joined #launchpad === bk [n=root@59.144.72.168] has joined #launchpad [10:01] ah, good to have X back === carlos [n=carlos@82.109.136.116] has joined #launchpad [10:03] Hi, is there anyway to list all the packages contained in https://launchpad.net/distros/ubuntu/dapper/i386 [10:03] morning [10:03] the option +allpackages is not working [10:05] good morning [10:07] mornig SteveA === danilos [n=danilo@82.109.136.116] has joined #launchpad === jamesh [n=james@82.109.136.116] has joined #launchpad === ddaa [n=ddaa@82.109.136.116] has joined #launchpad [10:24] hey carlos [10:25] sivang: hey dude! [10:25] seems like you live on this channel ;-) [10:26] carlos: hehe [10:31] he does :) === ploum [n=ploum@ubuntu/member/ploum] has joined #launchpad === doko [n=doko@dslb-088-073-095-026.pools.arcor-ip.net] has joined #launchpad === Spads [n=crack@217.205.109.249] has joined #launchpad [11:32] spiv: are you going to commit that fix to RF btw? === frodon_ido [n=patrick@ip-213-49-150-10.dsl.scarlet.be] has joined #launchpad === LittleMouse [n=iDLE@164.100.210.2] has joined #launchpad === mpt_ [n=mpt@203.118.156.188] has joined #launchpad === SteveA [n=steve@82.109.136.116] has joined #launchpad === marcin_ant [n=marcin@194.114.146.122] has joined #launchpad [01:14] I'm going to stop Staging for 5 minutes for a code update [01:14] please complain now or I will do it in 5 minutes [01:22] staging is back [02:02] is staging getting updated? [02:02] i landed a branch that was supposed to hide bounties a day or two ago - but it's not reflected on staging [02:04] carlos: Are your staging code updates a private branch or have you merged launchpad/devel in there recently? === raphink [n=raphink@ubuntu/member/raphink] has joined #launchpad [02:05] it's a private branch but I think it has also merged launchpad/devel as it was yesterday === matsubara [n=matsubar@200-171-140-32.dsl.telesp.net.br] has joined #launchpad [02:05] stub: anyway, I did a bzr merge of my branch on whatever staging had [02:06] so any code changes until yesterday night should be there [02:08] hmmm [02:08] stub: seems like there is something wrong: [02:08] revno: 3819 [02:08] committer: Canonical.com Patch Queue Manager [02:08] branch nick: launchpad [02:08] timestamp: Sat 2006-07-22 18:25:33 +0100 [02:08] that's the last merge on staging [02:09] Hmm... booger. [02:09] sabdfl: anyway, your patch is on my branch [02:09] so it should be on staging atm [02:11] At least, this is latest merge I did from rocketfuel: [02:11] merged: pqm@pqm.ubuntu.com-20060726101620-1e7c2aff80ab77f0 [02:11] committer: Canonical.com Patch Queue Manager [02:11] branch nick: launchpad [02:11] timestamp: Wed 2006-07-26 11:16:20 +0100 [02:11] message: [02:11] [trivial] Hide bounty links till bounty tracker is in beta [02:11] carlos, sabdfl: I think it is still updating daily. However, it is using chinstrap instead of sodium. [02:11] I'll fix that ;) [02:11] thanks much :-) [02:12] stub: please, don't force any code update [02:12] stub: I will do it when I finish my testing session, ok? [02:13] carlos: Ok. I'll leave you and Mark to fight over it ;) [02:13] i'm easy [02:13] in this one, specific case :-) [02:13] sabdfl: isn't your patch already included on my branch ? [02:15] carlos: I've updated Makefile.staging anyway [02:15] stub: ok, thanks [02:15] launchpad sprinters -> lunch === cprov [n=cprov@monga.dorianet.com.br] has joined #launchpad === niemeyer [n=niemeyer@200.181.177.45] has joined #launchpad === JanC [n=janc@lugwv/member/JanC] has joined #launchpad === WaterSevenUb [n=WaterSev@195-23-238-138.nr.ip.pt] has joined #launchpad === jsgotangco [n=jsg123@ubuntu/member/jsgotangco] has joined #launchpad === flacoste [n=francis@modemcable207.210-200-24.mc.videotron.ca] has joined #launchpad [03:14] man you guys mailbombed me [03:34] is it a bug that we can't add tags while reporting bugs? === mpt [n=mpt@203.118.156.188] has joined #launchpad [03:40] yeah [03:40] and you can't query for tags either, can you? [03:42] kiko: You can, but it's less obvious than it should, IMO [03:42] really? how do you do it? [03:43] kiko: In the bugs page there's a list in the bottom left [03:44] ?field.tag=something [03:44] I see === raphink [n=raphink@ubuntu/member/raphink] has joined #launchpad === cprov [n=cprov@monga.dorianet.com.br] has joined #launchpad [03:48] sorry, was offline for 30 minutes due a power outage in my area. === lfittl [n=lfittl@85-125-145-190.dynamic.xdsl-line.inode.at] has joined #launchpad [04:01] kiko: do you think you'll be able to review tt-search today? [04:01] yes. [04:01] kiko: great! [04:02] I almost did it last night but was very tired [04:17] kiko, ping v3 [04:17] Seveas, I'm battling it out on the mailing list, waiting to chat to SteveA [04:17] kiko, ok [04:18] kiko: hi [04:20] tsu [04:20] man, I never thought of using that as an emoticon. [04:21] hi [04:21] http://www.inference.phy.cam.ac.uk/cjb/codepoints.html [04:21] the snowman is pretty cool [04:21] and I always appreciate calling someone a "dong" [04:23] matsubara, est atualizando? [04:29] kiko: I'm ready to get ready [04:29] SteveA: I wonder how long does it take to write the last "thai character" with a pen.. [04:31] sabdfl: I'm updating staging with latest rocketfuel code + my changes [04:35] niemeyer: probably depends on how obsessive compulsive you are === matsubara [n=matsubar@200-171-140-32.dsl.telesp.net.br] has joined #launchpad === kjcole [n=chatzill@pchb1f.gallaudet.edu] has joined #launchpad [04:47] matsubara, it's updating. slowly though as there is a lot to update [04:47] jamesh, the CVE thing is just a URL change [04:47] jamesh, willing to r+ a patch? [04:48] see email [04:48] kiko: thanks. [04:50] kiko: any reason you chose allcves.xml.gz rather than allitems.xml.gz? [04:50] kiko: we won't get any of the candidate CVEs with that feed [04:51] with CVEs, an issue is usually pretty old once it leaves candidate state [04:52] jamesh, uhhh, no. [04:52] you're absolutely right [04:52] I'll change that [04:53] kiko: okay. The code changes look trivial and correct. If you change it to allitems.xml.gz and it still works, merge it. [04:53] will do. thank you. [04:55] staging is down atm because patch-67-04-0.sql (related with shipit) is taking ages to be applied... === ddaa [n=ddaa@82.109.136.116] has joined #launchpad [04:59] Znarl: can you have a look at whether pqm looks like it's stuck? [05:05] kiko: i'm looking at bug 41972 [05:05] Malone bug 41972 in launchpad-support-tracker "You can linkbug to answered support request." [Medium,In progress] http://launchpad.net/bugs/41972 [05:05] kiko: should we allow or disallow linking bugs to answered support requests? [05:06] bug report is about the fact that the items aren't in the menu but using the +linkbug URL works [05:06] flacoste, I don't see why we shouldn't link a bug to an answered request. restricting that seems arbitrary. [05:07] kiko: i agree [05:07] that's great. [05:07] kiko: on a more general note, i see a source of problems between the menu and the views that implement them [05:08] go on? [05:08] i mean that conditions on menu should really be duplicated in the view that implement the actions [05:08] otherwise, that kind of bug will always occur [05:09] oh, I see what you mean. the pages accessible because they are registered in zcml may not be consistent with the menu [05:09] for example, the Change Source Package and Edit Request have the same error [05:09] kiko: exactly [05:10] Edit Request and Change Source Package are not available on Answered requests, but they will work using the URL directly [05:15] kiko: as part of the 41972 fix, do you think Edit Request and Change Source Package should still be available on 'Answered' tickets? === flacoste is not sure about those two [05:15] well.. [05:16] currently, they are not, but the URL will work [05:16] what does edit request allow? === ploum [n=ploum@ubuntu/member/ploum] has joined #launchpad [05:16] changing the title and description of the tickets [05:17] and the original description is lost (it's not saved in a comment like for bugs) [05:17] I'd allow changing them.. any reason why not? [05:18] actually, at the sprint we talked about dropping that possibility entirely [05:18] the rationale being that a ticket is more like a conversation than a bug report where you might want to consolidate comments in the description [05:19] well, that's orthogonal as to whether we should include that item in the menu or not :) [05:19] indeed :-) [05:20] so leave them all on then? [05:20] makes it easier to fix mistakes [05:20] I'd do that yes. and I'd also bring the larger issue up with SteveA/mailing list [05:21] matsubara, I don't think -devel syncing is getting us anything at the moment [05:21] matsubara, given that it's in a repository now [05:21] kiko: well, I never use that one anyway. [05:21] okay, I'll kill it. [05:22] I think the only thing that was missing was for me to ssh in the first time [05:22] which is kinda weird [05:23] ddaa: yes [05:24] pqm 399 0.0 3.6 210544 74568 ? S 12:04 0:03 \_ python2.4 -t ./lib/importd/test_all.py [05:24] pqm 2826 0.0 0.0 14112 1048 ? S 12:05 0:00 \_ cvs server [05:24] pqm 2976 0.0 0.0 14112 1048 ? S 12:05 0:00 \_ cvs server [05:24] pqm 3383 0.0 0.0 14116 1048 ? S 12:05 0:00 \_ cvs server [05:24] pqm 3844 0.0 4.3 221992 89664 ? Sl 12:05 0:02 \_ /usr/bin/python2.4 -W ignore::DeprecationWarning:: /srv/pqm.ubuntu.com/chroot-amd64/home/pqm/pqm-workdir/home/---devel/launchpad/lib/importd/baz2bzr.pyc 10 /srv/pqm.ubuntu.com/chroot-amd64/home/pqm/pqm-workdir/home/---devel/launchpad/,,job_test/blacklist [05:25] kiko: will send an email to the list about the menu/view inconsistency [05:25] ddaa: I can kill it if you want, dunno if I'm meant to tho. that's not one of the known normal hangs [05:26] cool. [05:26] elmo: I have been actively turning this code upside down in the last days [05:26] so I think it's safe to add it to your repertoire of known hangs [05:26] ddaa: ok - and kill it? [05:28] elmo: please do so [05:28] ddaa: done === SteveA [n=steve@82.109.136.116] has joined #launchpad [05:33] elmo: does pqm look idle again? [05:35] ddaa: it started doing another test and got in the same hang :/ shall I just forcefully kill the top level test runner? [05:35] that's very weird [05:35] you just did a third kill? [05:36] yeah, I keep killing them as they hang [05:36] okay, it's a dead parrot [05:36] I'll fix that urgently but just nuking away the baz2bzr test suite [05:36] kill the whole lot? [05:36] elmo: please [05:37] it's really gone now [05:38] elmo: it's likely to get wedged in the same way for the next merge [05:38] until I nuke the code away [05:38] will keep you posted [05:38] ok [05:43] what's with "DASHDASHDASHdevel" anyway? pqm is so the home of old school tla fan boys [05:43] elmo: it's robert's code [05:44] hehe [05:44] write often, cleanup tomorrow [06:04] ProgrammingError: ERROR: function ensure_session_client_id("unknown") does not exist [06:04] HINT: No function matches the given name and argument types. You may need to add explicit type casts. [06:04] matsubara, make schema? [06:04] did already [06:05] hmmm [06:05] make schema && make run and when I tried to access the local instance it gave me that === matsubara tries again [06:06] matsubara: try "dropdb session_dev" [06:07] matsubara: the database/schema/Makefile has a comment "creating session database if necessary" === fantamaxx3 [n=mholthau@65.193.63.81.fix.bluewin.ch] has joined #launchpad [06:12] now it works, thanks jamesh [06:20] so [06:20] staging is broken atm [06:20] and I don't have enough permissions to fix that [06:20] just so everyone is clear about this, carlos broke staging [06:20] looks like this merge is going to go in smoothly [06:20] and anyway, tonight will be broken again until stub fixes it [06:20] jamesh: fuck off [06:21] better let it break on staging, eh! [06:21] carlos didn't break staging, he "just" uploaded some code which broke staging [06:21] ha right, carlos don't kill people, bullets do === carlos is so happy to be on vacations in a couple of hours.... [06:21] :-) [06:23] people, please pay attention for a minute === raphink [n=raphink@ubuntu/member/raphink] has joined #launchpad [06:24] if pqm starts breaking on the baz2bzr tests in importd in a way that becomes a serious problem [06:24] just merge david/launchpad/nuke-baz2bzr-tests [06:24] rs=SteveA === lfittl [n=lfittl@85-125-145-190.dynamic.xdsl-line.inode.at] has joined #launchpad === bradb [n=bradb@modemcable048.58-130-66.mc.videotron.ca] has joined #launchpad [07:07] bradb! [07:08] yo :) [07:08] fud but chat to you when I'm back [07:09] sounds good === SteveA [n=steve@82.109.136.116] has joined #launchpad === fantamaxx3 [n=mholthau@65.193.63.81.fix.bluewin.ch] has left #launchpad [] === sabdfl [n=mark@ubuntu/member/pdpc.silver.sabdfl] has joined #launchpad [08:09] GOOD NEWS [08:10] the bzr-native back-end for importd is operational [08:10] rollout will happen early next week [08:10] now, I have a long evening of celebration in front of me! [08:12] wooo! [08:14] nice :) === lbm [n=lbm@0x535d8908.vgnxx5.adsl-dhcp.tele.dk] has joined #launchpad [08:46] ddaa: congratulations! [08:54] so _thats_ the reason the naming was switched to Bazaar? ;) [08:55] bradb! [08:55] kiko! [08:55] how's it going my man [08:55] feeling better? [08:56] pretty much [08:56] i switched to a dentist that uses lasers. he seems pretty cool. [08:56] wow [08:56] lasers [08:57] a root canal still seems in my future. [08:57] you brush those teeth [08:57] but, hard to say when [08:57] i do! twice a day, even. [08:57] and floss [08:57] and floss! [08:57] it's all about flossing at night though, instead of the morning [08:57] and fewer macadamia nuts [08:57] really? [08:57] macadamias are not particularly hard on the teeth are they? [08:58] er, macadamias, i meant [08:58] i.e. sugary cookies [08:58] oh. yeah, sugar is not good. [09:02] bradb, can you check out https://sodium.ubuntu.com/~andrew/paste/fileS7uGTV.html [09:02] it's a small change [09:03] containing one XXX and a few simplifications === LeeJunFan [n=junfan@adsl-69-210-207-5.dsl.klmzmi.ameritech.net] has joined #launchpad === stub [n=stub@ppp-58.8.1.92.revip2.asianet.co.th] has joined #launchpad [09:20] hey stub === bradb [n=bradb@modemcable048.58-130-66.mc.videotron.ca] has joined #launchpad [09:22] hmph, i seem to have lost my irc connection 20 minutes ago. [09:22] bradb, did you get my /msg? [09:22] kiko: nope [09:22] bradb, can you check out https://sodium.ubuntu.com/~andrew/paste/fileS7uGTV.html [09:22] it's a small change [09:22] containing one XXX and a few simplifications [09:22] matsubara, did you see stub's latest email to carlos on launchpad-list? === cr0n [i=d@dsl-146-242-180.telkomadsl.co.za] has joined #launchpad === matsubara checks [09:23] kiko: ok, just a couple mins while i finish this email [09:24] sure thing. [09:25] kiko: any particular thing I should pay attention to? [09:25] matsubara, the session database bustage? [09:25] matsubara: try "dropdb session_dev" [09:25] matsubara: the database/schema/Makefile has a comment "creating session database if necessary" [09:25] now it works, thanks jamesh [09:25] kiko ^^ [09:26] that fixed it. [09:26] aha! === niemeyer_ [n=niemeyer@200.181.177.45] has joined #launchpad [09:39] kiko: maybe that method would be easier to follow if it were like: [09:39] if binarypackagename: [09:39] ... [09:39] else: [09:39] .... [09:40] bradb, not really, though I could break it into separate methods. [09:40] bradb, my questioning was more if selectFirst would actually work there, AND if my XXX is relevant. === niemeyer__ [n=niemeyer@200.181.177.45] has joined #launchpad === [PUPPETS] Gonzo [i=gonzo@80.69.47.16] has joined #launchpad === bradb_ [n=bradb@modemcable048.58-130-66.mc.videotron.ca] has joined #launchpad [09:46] my wireless sucks [09:46] kiko: presumably you didn't see my comments? [09:46] heh [09:46] I did [09:46] well, only one comment [09:46] so, to recap [09:47] i think it would read easier if it were formatted as: [09:47] if binarypackagename: [09:47] ... [09:47] return ... [09:47] else: [09:47] ... [09:47] return ... [09:47] and that the variables should be called source_package_publishing and published_package, instead of both being called publishing. [09:47] bradb_, again, else: after return makes no sense.. [09:48] bradb, my questioning was more if selectFirst would actually work there, AND if my XXX is relevant. [09:48] kiko: why doesn't else after a return make sense? [09:49] because it's extra text and indentation that doesn't add any clarity, and because that's not what's confusing about the method [09:49] my question is more if selectFirst could be used there, and if the XXX is relevant. [09:52] kiko: it's clearer to me anyway, because it makes it easier to see that there's a return in the middle of the method. the distribution.txt test should be able to tell you if .selectFirst will work. [09:52] bradb_: is there any bug open to implement a milestone command in the email interface? [09:53] matsubara: doesn't look like it [09:55] matsubara: ok, thanks. [09:57] kiko: the first selectFirst is missing an orderBy, btw [09:58] good catch [09:59] bradb_, and it's an actual bug, too! === bradb_ ponders the XXX thing [09:59] or more, the code around it [10:01] kiko, have you been able to fight with SteveA? [10:02] Seveas, he said he's fine with it [10:02] I am mustering the guts to go out and do it [10:02] hehe, good luck ;) [10:02] since I have to change this in multiple places [10:02] sure thing [10:03] let me know when you did it, it requires some configuration on my side after that to prevent an inital mailflood [10:03] sure === niemeyer [n=niemeyer@200.181.177.45] has joined #launchpad [10:03] (well, it is prevented now by making sure NO new bug reports are sent in here, will have to undo it properly) [10:03] kiko: it looks to me that non-context is a bug there. it looks like it could happily return a published binary/source package name combo from another distribution, which would be a bug. [10:05] bradb_, so should I restrict to distribution=self? [10:05] kiko: first, i'd write a test to verify. i /think/ we have enough sample data to even make it work. [10:05] which is to say, make it break === bradb_ tries [10:14] kiko: do you know if salgado was working on something related to this: OOPS-208A141? [10:14] https://chinstrap.ubuntu.com/~jamesh/oops.cgi/208A141 [10:18] matsubara, hmmm, that's very strange. I don't know. [10:18] it seems to be complaining that the user would have two approved.. well, actually [10:18] salgado's change /would/ modify that [10:18] I'm not sure it would fix the problem though [10:19] kiko: hm, i don't think we have the test data to write a test for that bug, atm [10:19] bradb_, what are we missing -- packages? === Spads [n=crack@host-87-74-89-130.bulldogdsl.com] has joined #launchpad === ploum [n=ploum@ubuntu/member/ploum] has joined #launchpad === bradb_ [n=bradb@modemcable048.58-130-66.mc.videotron.ca] has joined #launchpad [10:39] lost connection again, even though i'm sitting /beside my router/ [10:39] kiko: in case you missed it, the failure can be reproduced by 1. adding a current release for gentoo, and 2. filing a bug on bp linux-2.6.12 === cr0n [i=d@dsl-146-242-180.telkomadsl.co.za] has left #launchpad [] [10:40] bradb_, cool. === Fujitsu [n=Fujitsu@c58-107-168-5.eburwd7.vic.optusnet.com.au] has joined #launchpad === Seveas [n=seveas@ubuntu/member/seveas] has joined #launchpad [11:28] kiko: have you seen https://sodium.ubuntu.com/~jamesh/oops.cgi/2006-06-11/A728 about the Build/BuildQueue prejoin hack ? Do have a minute to talk about it ? [11:29] not yet, lemme see [11:30] kiko: check query 17 & 21, for instance. [11:30] cprov, okay, the problem is the following: you need to change the way you grab the data. [11:30] kiko: how ? [11:31] cprov, well... [11:31] currently what you do is grab builds and then for each build you traverse over a join column to buildqueue, right? [11:31] kiko: the query 21 should not be issues since the 17 lready populated the cache with BQ.build=202097 row, isn't it ? [11:32] cprov, the cache is only accessed by id. if you look at that query it is specifying a build id in the where clause.. [11:32] cprov, what template is that? [11:33] kiko: ahhh, I see [11:33] builds-list.pt [11:34] mmm, a batch. [11:34] kiko: can't I change BQ.build to be an alternateID or something similar, would it help ? [11:34] it could help, but I doubt it [11:34] cprov, is it a singlejoin? [11:35] kiko: yes, do we have it from upstream sqlobject ? [11:35] yes, but that won't help you here. [11:35] kiko: yeah, I was about to say that ... [11:35] cprov, so what causes those queries to be issued? is it traversing through to buildqueue_record? [11:36] kiko: exactly, a selectOne property [11:36] that's bad. [11:37] singleJoin could make the code saner, even if doesn't help to not issue multiple queries, do you agree ? [11:38] not really [11:38] it wouldn't improve things very much [11:38] kiko: wow I got a weird mail involving you today [11:38] involving ME? [11:39] cprov, one thing you can do which is easy, is caching the buildqueue record so you at least don't fetch it 3 times [11:39] cprov, putting it into a dictionary [11:39]