| jeckers` | hey all i've submitted a patch to a bug in partman-auto | 12:42 |
|---|---|---|
| jeckers` | https://bugs.launchpad.net/ubuntu/+source/partman-auto/+bug/83897 | 12:42 |
| jeckers` | should be a quick one somebody can bang out in a minute | 12:42 |
| cjwatson | I'm not convincd | 12:43 |
| cjwatson | convinced, even | 12:43 |
| jeckers` | $dev is the directory | 12:44 |
| jeckers` | e.g. =dev=hda | 12:44 |
| cjwatson | I know, but your patch is in the wrong place | 12:44 |
| cjwatson | I think it's the code calling get_auto_disks which is incorrect | 12:44 |
| cjwatson | get_auto_disks is called from more than one place and your patch would break the other callers, AFAICS | 12:45 |
| jeckers` | perhaps, although i ran through the install ok after applying that | 12:45 |
| cjwatson | specifically select_auto_disk | 12:45 |
| cjwatson | you'd need a >1-disk system without preseeding to see the breakage | 12:46 |
| jeckers` | ah i see | 12:46 |
| jeckers` | and just when i thought i was being clever. doh. | 12:47 |
| jeckers` | well then auto.d/initial_auto must need to do some massaging then? | 12:47 |
| cjwatson | jeckers`: try the patch I just posted to your bug? | 12:47 |
| jeckers` | will do | 12:48 |
| cjwatson | jeckers`: thanks for the report, though, this was the first I'd realised that was broken | 12:48 |
| cjwatson | jeckers`: and don't be put off, partman is a hairy piece of code to try to work on; good effort for getting as far as you did :-) | 12:48 |
| jeckers` | i spent the better part of 3 hours trying to figure out what the heck it was doing :) | 12:49 |
| cjwatson | my fault for not testing the fix in the first place - I was in Oslo and nowhere near any of my test rigs | 12:50 |
| === jeckers` is now known as jeckers | ||
| jeckers | yup your patch did the trick | 01:01 |
| jeckers | thanks a lot | 01:02 |
| jeckers | you'll probably be seeing more of me in the coming months | 01:02 |
| jeckers | i'm going to be following along with feisty closely as it develops | 01:02 |
| jeckers | hopefully i'll catch a few more good ones along the way :) | 01:03 |
| cjwatson | great, look forward to more installer manpower :) | 01:07 |
| cjwatson | will upload that patch now | 01:08 |
| jeckers | cool thanks | 01:09 |
| jeckers | and i'd be glad to give more installer manpower :) | 01:09 |
| cjwatson | feel free to ping me here for help | 01:10 |
| === kro [n=user@pool-72-84-46-79.clrkwv.east.verizon.net] has joined #ubuntu-installer | ||
| jeckers | and my partner in crime has arrived | 01:11 |
| === cr3 [n=marc@pdpc/supporter/bronze/cr3] has joined #ubuntu-installer | ||
| saispo | hi all | 11:22 |
| CIA-4 | ubiquity: cjwatson * r1848 ubiquity/ (83 files in 3 dirs): | 11:23 |
| CIA-4 | ubiquity: * Display a warning message next to the password entry box if running in | 11:23 |
| CIA-4 | ubiquity: debug mode, since the password will then end up in the log file via | 11:23 |
| CIA-4 | ubiquity: debconf debugging. | 11:23 |
| CIA-4 | ubiquity: cjwatson * r1849 ubiquity/ (debian/changelog ubiquity/components/console_setup.py): * Don't crash if /etc/X11/xorg.conf is unaccountably missing (LP: #83927). | 11:33 |
| CIA-4 | ubiquity: cjwatson * r1850 ubiquity/ (configure configure.ac): bump to 1.3.19 | 11:35 |
| saispo | cjwatson: it's possible for me to backport this fix on edgy ? (https://bugs.launchpad.net/ubuntu/+source/partman-auto/+bug/83897) | 12:07 |
| cjwatson | saispo: yes, but only on top of the change in feisty that it was fixing ... | 12:17 |
| saispo | ok | 12:18 |
| saispo | it may fix the error with /dev/disc/disc0 things... | 12:18 |
| cjwatson | well, you can't use /dev/discs/disc0/disc any more either way, but yes, it could make that situation easier | 12:20 |
| saispo | because today i use a script but don't work on installer... | 12:24 |
| saispo | if [ cat /sys/block/hda/devices/media = "cdrom" ] ; then echo part-auto-sda.cfg; else echo part-auto-hda.cfg; fi | 12:25 |
| saispo | if it != cdrom he don't get the other file... | 12:25 |
| cjwatson | well, that's just bogus shell syntax | 12:38 |
| cjwatson | if that's literally what your script says | 12:38 |
| cjwatson | correct would be if [ "$(cat /sys/block/hda/devices/media)" = cdrom ] ; then echo part-auto-sda.cfg; else echo part-auto-hda.cfg; fi | 12:39 |
| saispo | ok, thanks | 12:39 |
| evand | cjwatson: Are you shooting for an FF exception for the new partitioner work? | 01:22 |
| evand | s/an/a/ | 01:22 |
| cjwatson | yeah | 01:24 |
| evand | cjwatson: how comfortable would you be with me attempting one on say, Saturday morning, for Opera bookmarks importing and email account information importing? I've basically got the former done. | 01:26 |
| evand | Or should I let it wait for Feisty+1? | 01:26 |
| cjwatson | well, can we land the ubiquity m-a work today? :) | 01:26 |
| cjwatson | if so extra little bits don't count for FF IMO | 01:26 |
| evand | really? That's amazing. | 01:26 |
| evand | But yeah, it's there for you to merge | 01:26 |
| evand | I figured you were waiting for m-a main promotion | 01:27 |
| cjwatson | oh, I need to hassle about that, yes | 01:27 |
| cjwatson | brb, preparing meeting agenda for today and then lunch | 01:27 |
| evand | lazy core devs :-) | 01:27 |
| evand | ok | 01:27 |
| saispo | how can i debug why a package for a local repository i make on the cd is installing in the base installer without any apt-install command or other ? | 01:51 |
| saispo | s/for/from/ | 01:51 |
| === cr3 [n=marc@pdpc/supporter/bronze/cr3] has joined #ubuntu-installer | ||
| saispo | cjwatson: where i can find docs about seeds structure files ? | 04:39 |
| cjwatson | http://wiki.ubuntu.com/SeedManagement | 04:40 |
| cjwatson | oh you mean the STRUCTURE file? | 04:41 |
| saispo | nono | 04:41 |
| saispo | description of a seeds | 04:41 |
| saispo | with = or == | 04:41 |
| cjwatson | you mean the text bits at the top of the seed files? | 04:41 |
| cjwatson | they're ignored - the only reason they have that format is that the seeds used to be stored in a wiki | 04:42 |
| saispo | ok | 04:42 |
| saispo | no difference between = or == ? | 04:42 |
| cjwatson | in the wiki two years ago, they were different heading levels | 04:43 |
| cjwatson | it makes no difference whatsoever now | 04:43 |
| cjwatson | germinate ignores all lines that don't start with " * " | 04:44 |
| saispo | k | 04:46 |
| saispo | i have a problem which i don't understand... | 04:47 |
| saispo | when i include a package in my seeds file wich is in my local repository on the cd, the base installer install it | 04:47 |
| saispo | and i don't want... | 04:47 |
| saispo | Dependency problem ? | 04:47 |
| saispo | Germinate Problem ? | 04:47 |
| saispo | i have no clue... | 04:52 |
| cjwatson | you probably gave it a Priority: of required, important, or standard | 04:59 |
| saispo | in the packaging ? | 05:00 |
| saispo | Priority: optional | 05:01 |
| cjwatson | or else something depends on it in the base system | 05:01 |
| saispo | maybe..., how can i see germinate output ? | 05:01 |
| cjwatson | or you put it in the minimal seed and cdimage inflated the priority for you | 05:01 |
| cjwatson | sudo apt-get install germinate | 05:01 |
| cjwatson | man germinate | 05:01 |
| saispo | k :) | 05:02 |
| saispo | thanks for your help, will search in this road | 05:02 |
| CIA-4 | ubiquity: cjwatson * r1851 ubiquity/ (73 files in 4 dirs): | 05:50 |
| CIA-4 | ubiquity: * Import translations for Cancel, Back, Forward etc. buttons from gtk+2.0 | 05:50 |
| CIA-4 | ubiquity: 2.10.9-0ubuntu1 (LP: #43915). | 05:50 |
| cjwatson | blink, this is a fun merge | 06:12 |
| === cjwatson attempts the m-a merge the other way round to see if that's any easier | ||
| evand | Really? I thought I was fairly up to date. | 06:18 |
| evand | The only issue should be glade, but that's as easy as just cutting the MA section out and pasting it into the most recent copy. | 06:19 |
| evand | Did I do something wrong in bzr? | 06:36 |
| === secureboot_ [n=lstclair@coriakin.cse.psu.edu] has joined #ubuntu-installer | ||
| secureboot_ | is there any way to do encrypted partitions from the installer in feisty? any plans to enable this? | 07:09 |
| secureboot_ | if not, is there any way to use etch's partman when building your own custom installer? | 07:11 |
| cjwatson | evand: I just made a bunch of changes ... | 07:13 |
| cjwatson | ow, merging .po files is so insanely painful | 07:18 |
| cjwatson | I'll just msgmerge it | 07:19 |
| cjwatson | evand: could you set your editor to never use tabs in Python code? space-indentation is usually considered better there | 07:33 |
| evand | cjwatson: I thought I was, but sure thing. | 07:38 |
| cjwatson | looks like maybe you did part-way through the project | 07:40 |
| evand | ah | 07:40 |
| cjwatson | anyway, not *right* now, mid-merge :-) | 07:40 |
| cjwatson | just setting up the test rig | 07:40 |
| evand | heh | 07:40 |
| cjwatson | note that there was a diff in bin/ubiquity which I dropped (@VERSION@ -> 1.3.8, looked accidental) and an extra change in gtkui.py where it looked like you missed a new-partitioner bug fix (it was an "if 'UBIQUITY_NEW_PARTITIONER' not in os.environ:" around gparted_loop()) | 07:41 |
| cjwatson | hmm, dinnertime | 07:41 |
| cjwatson | will return afterwards and hopefully commit | 07:42 |
| evand | ah, I probably did that recently, in the last merge | 07:42 |
| cjwatson | secureboot_: don't think the pieces are in place; if cryptsetup is ever moved to main it may be possible to assemble them from Debian | 07:42 |
| cjwatson | secureboot_: not unless you're a d-i god | 07:42 |
| cjwatson | (etch's partman) | 07:42 |
| evand | cjwatson: thanks again, hopefully this will be much easier going forward. | 07:43 |
| cjwatson | yeah, I expect so | 07:43 |
| secureboot_ | cjwatson: sad. | 07:43 |
| cjwatson | evand: I think you get to write the changelog entry, too. Any suggestions? | 07:45 |
| evand | cjwatson: uh, "Merged in migration-assistant work, moved the user-setup page to after migration-assistant..." | 07:52 |
| evand | here be dragons? | 07:53 |
| evand | everything is pretty high level as this is going in all at once | 07:54 |
| evand | those two things were obviously the main focus | 07:54 |
| evand | oh, and made user-setup able to use users from m-a | 07:56 |
| evand | if you want me to describe the feature set in the commit, let me know and I'll give you a run down | 08:02 |
| CIA-4 | ubiquity: cjwatson * r1852 ubiquity/ (92 files in 8 dirs): merge migration-assistant branch from Evan | 08:27 |
| cjwatson | blam | 08:28 |
| cjwatson | [ Evan Dandrea ] | 08:28 |
| cjwatson | * Merged in migration-assistant work. Moved the user-setup page to after | 08:28 |
| cjwatson | migration-assistant (and thus also after the partitioner, since | 08:28 |
| cjwatson | migration-assistant needs to know which partitions are to be left | 08:28 |
| cjwatson | evand: let me know if that's inaccurate | 08:28 |
| cjwatson | intact). Made user-setup able to make use of users from | 08:28 |
| cjwatson | migration-assistant. | 08:28 |
| evand | looks good | 08:30 |
| evand | cjwatson: thanks | 08:30 |
| === evand crosses fingers and hopes everything works as well as it did in his testing | ||
| CIA-4 | ubiquity: cjwatson * r1853 ubiquity/ (4 files in 3 dirs): indentation, minor style nits | 08:36 |
| cjwatson | (easier to do it straight away, I think) | 08:36 |
| evand | et in vim will do it, right? | 08:37 |
| cjwatson | yeah | 08:38 |
| cjwatson | augroup myauto | 08:38 |
| cjwatson | au! | 08:38 |
| cjwatson | [blah] | 08:38 |
| cjwatson | au FileType python setlocal tabstop=8 softtabstop=4 shiftwidth=4 expandtab | 08:38 |
| cjwatson | augroup END | 08:38 |
| cjwatson | is what I have | 08:38 |
| evand | thanks | 08:38 |
| cjwatson | but my .vimrc has all sorts of stuff in it and some of it's global; I have autoindent on for everything | 08:39 |
| cjwatson | oh, and let python_highlight_all = 1 is handy too | 08:39 |
| evand | I have the habit of just doing a :syn on | 08:40 |
| cjwatson | I'm not sure it necessarily highlights everything by default | 08:40 |
| evand | hrm, I'll have to play around with it then | 08:40 |
| cjwatson | ooh, there's a changelog plugin | 08:41 |
| === cjwatson makes the productivity error of reading vim's help files | ||
| CIA-4 | ubiquity: cjwatson * r1854 ubiquity/ubiquity/frontend/gtkui.py: iter -> iterator (avoid shadowing builtins) | 08:41 |
| evand | whoops | 08:41 |
| cjwatson | r1854 is one that python_highlight_all is handy for catching | 08:42 |
| cjwatson | it highlights builtins in cyan (here, anyway) | 08:42 |
| evand | ah, indeed it does. Very nice. | 08:44 |
| cjwatson | evand: I think UBIQUITY_MIGRATION_ASSISTANT is implemented slightly dubiously - doesn't it need to fix up the page numbers too after removing a page? | 08:46 |
| cjwatson | as it is the page numbers skip if you're running without --migration-assistant | 08:47 |
| cjwatson | these are all nits though, it's looking pretty good | 08:47 |
| cjwatson | of course I've not run it on a system that actually has anything to migrate ;-) | 08:47 |
| cjwatson | evand: btw, might be fun for you to set up bzr-cia and have your commits logged here too | 08:48 |
| evand | cjwatson: definitely to cia | 08:48 |
| evand | cjwatson: It's skipping pages? | 08:48 |
| cjwatson | evand: mkdir -p ~/.bazaar/plugins; cd ~/.bazaar/plugins; bzr get http://bazaar.launchpad.net/~jelmer/bzr-cia/main/ cia | 08:48 |
| evand | thanks | 08:49 |
| cjwatson | then 'bzr cia-project ubiquity' in your branch and make sure the bzr nick is right | 08:49 |
| evand | ok | 08:49 |
| cjwatson | in ~/.bazaar/bazaar.conf, 'cia_user = evand' or whatever you're comfortable with and 'cia_send_revno = true' | 08:49 |
| cjwatson | at least that's what I prefer | 08:50 |
| evand | ok | 08:50 |
| evand | when you say page numbers, do you mean it's skipping actual pages or just the numbers on the labels? | 08:50 |
| cjwatson | and finally, 'bzr submit-cia' after each commit, or put 'post_commit = bzrlib.plugins.cia.post_commit' in the appropriate bit of ~/.bazaar/locations.conf | 08:50 |
| cjwatson | evand: just the numbers, the "Step N of M" bit | 08:50 |
| evand | ahh, I actually kind of completely forgot about that | 08:51 |
| cjwatson | it goes up to "Step 8 of 8" now even if m-a is disabled | 08:51 |
| cjwatson | like I say, a nit | 08:51 |
| evand | ok, so I'm assuming the workflow you'd prefer is what we've been doing? I'll pull trunk, make some changes and then when I fix a bug you'll merge again. Or would you prefer plain old patches or something else? | 08:52 |
| evand | I'd imagine not the latter. | 08:52 |
| cjwatson | the former, definitely | 08:53 |
| evand | I figured :) | 08:53 |
| cjwatson | ideally you should be in core-dev eventually and maintain it directly, of course | 08:53 |
| evand | Yeah, I really need to get on the getting work into REVU so I can first get into MOTU | 08:54 |
| cjwatson | in retrospect maybe I should have made it writable by ubuntu-installer | 08:54 |
| cjwatson | but never mind now | 08:54 |
| evand | eh, it's something I've been aiming for anyway, so this is just more incentive. | 08:55 |
| CIA-4 | ubiquity: cjwatson * r1855 ubiquity/ (d-i/manifest debian/changelog): | 08:55 |
| CIA-4 | ubiquity: * Automatic update of included source packages: apt-setup 1:0.16ubuntu3, | 08:55 |
| CIA-4 | ubiquity: migration-assistant 0.3.1, partman-auto 62ubuntu4, | 08:55 |
| CIA-4 | ubiquity: partman-basicfilesystems 51ubuntu1. | 08:55 |
| evand | ok, I should be all set up for CIA | 09:02 |
| evand | Should I do it on both m-a and my ubiquity branch or would you prefer just one of them? | 09:02 |
| cjwatson | why not both, and I'll tell the CIA bot to mention those commits here | 09:03 |
| CIA-4 | ubiquity: cjwatson * r1856 ubiquity/debian/changelog: releasing version 1.3.19 | 09:03 |
| evand | ok, great. Already done | 09:04 |
| cjwatson | what's the project name (cia-project)? | 09:04 |
| evand | hrmm, where do I set that? | 09:05 |
| evand | I have the post commit hooks | 09:05 |
| cjwatson | bzr cia-project <blah> in the branch | 09:05 |
| evand | oh, right! | 09:05 |
| cjwatson | it knows about the project name and the branch name - the branch name comes from 'bzr nick' | 09:05 |
| cjwatson | the bot only needs to be told about project names though | 09:06 |
| cjwatson | there you go, ubiquity 1.3.19 uploaded, just under the feature freeze wire. :-) | 09:06 |
| evand | ok I did a bzr cia-project migration-assistant in m-a | 09:06 |
| evand | haha, awesome! Thanks again for all of your help. | 09:06 |
| cjwatson | all right, the bot'll know about that now | 09:06 |
| evand | and bzr cia-project ubiquity.ma | 09:07 |
| evand | creative, I know | 09:07 |
| cjwatson | no, that should be bzr cia-project ubiquity and bzr nick ma | 09:07 |
| evand | oh crap | 09:07 |
| cjwatson | otherwise it won't link it up properly | 09:07 |
| cjwatson | it's ok, you can change it easily | 09:07 |
| evand | ok, just did | 09:07 |
| evand | do I need to do anything else, like add these to my projects list on cia.navi.cx? | 09:08 |
| cjwatson | I think it should do that magically when you commit | 09:08 |
| evand | great | 09:09 |
| cjwatson | oh, I forgot to note in the changelog how to invoke it | 09:14 |
| cjwatson | maybe you could post to ubuntu-devel@ about that? | 09:14 |
| cjwatson | I left a note in the spec status whiteboard about it | 09:14 |
| evand | will do | 09:15 |
| evand | I was planning on doing a planet post as well | 09:15 |
| cjwatson | good plan | 09:19 |
| === philwyett [n=philwyet@bb-87-81-146-45.ukonline.co.uk] has joined #ubuntu-installer | ||
| CIA-4 | migration-assistant: evand * r33 migration-assistant/ (firefox-import.c firefox-import.h import.c): Added Opera support. | 10:14 |
| evand | neat! | 10:15 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!