[01:25] <Ubugtu> New bug: #64428 in acpi-support (main) "Mouse cursor gone after hibernate/resume (dup-of: 63258)" [Undecided,Unconfirmed]  https://launchpad.net/bugs/64428
[01:30] <Ubugtu> New bug: #64333 in acpi (main) "Mouse cursor disappears after suspend (dup-of: 63258)" [Undecided,Unconfirmed]  https://launchpad.net/bugs/64333
[04:55] <Ubugtu> New bug: #55108 in xorg "radeon driver, INVALID IO ALLOCATION" [Undecided,Confirmed]  https://launchpad.net/bugs/55108
[08:19] <tepsipakki> ok, I'm now going to merge xorg
[08:32] <tepsipakki> bah
[08:32] <tepsipakki> we have 7.1.1, debian has 7.1.0
[08:33] <jcristau> does that matter?
[08:33] <tepsipakki> not really
[08:34] <tepsipakki> but I bet there will be someone who demands it to be 7.2* ;)
[08:34] <tepsipakki> you haven't done one for 7.2 yet?
[08:35] <jcristau> no
[08:37] <tepsipakki> debdiff is 3.5MB, yikes
[08:37] <tepsipakki> because of the translations, mostly
[08:37] <jcristau> yay, fun :)
[08:37] <jcristau> oh, ok
[08:37] <jcristau> less fun, then ;)
[08:37] <tepsipakki> don't hold your breath ;)
[08:37] <tepsipakki> sigh
[08:39] <tepsipakki> I guess the new one can be called 7.2-0ubuntu1
[08:39] <jcristau> yeah
[08:41] <tepsipakki> latest merge was with 7.0.22, 18 revisions after that
[08:59] <tepsipakki> ok, diff is only 190kB
[08:59] <tepsipakki> without po
[09:00] <jcristau> a lot better then
[09:01] <tepsipakki> yep
[09:05] <tepsipakki> nice to have Depends/Conflicts etc in multiple lines.. a lot easier to actually find what has changed
[09:05] <tepsipakki> not that the current one in Ubuntu has so...
[09:05] <tepsipakki> gr
[09:05] <jcristau> yeah I changed that for the x11-common conflicts recently
[09:06] <jcristau> that line was really too fucking long
[09:06] <tepsipakki> that's one massive list :)
[09:44] <tepsipakki> ok, maybe best to keep the metapackages for now (xlibs-dev, xbase-clients, xutils), not touching those
[09:45] <tepsipakki> later we can drop at least xutils and sync it from Debian
[09:45] <tepsipakki> since there are some bugs open about missing xon
[09:49] <tepsipakki> * debian/local/Xsession: set temporary umask when creating $ERRFILE.
[09:49] <tepsipakki> -if (umask 077 && touch "$ERRFILE") 2> /dev/null && [ -w "$ERRFILE" ]  &&
[09:49] <tepsipakki> +if touch "$ERRFILE" 2> /dev/null && [ -w "$ERRFILE" ]  &&
[09:49] <tepsipakki> old version is from ubuntu
[09:51] <tepsipakki> jcristau: I'll put a diff available when I'm ready, so you can see if some of the changes (like above) is something Debian might want too
[09:51] <jcristau> cool, thanks
[09:51] <tepsipakki> a security update too
[09:51] <tepsipakki> "Fix race condition when chown'ing .xsession-errors."
[09:52] <tepsipakki> CVE-2006-5214
[09:56] <jcristau> indeed
[09:56] <jcristau> can you file a bug about that?
[09:56] <tepsipakki> sure, when I'm done with this
[09:56] <jcristau> thanks
[09:59] <tepsipakki> eh, the ubuntu dexconf still uses /usr/share/X11/fonts/*
[09:59] <tepsipakki> but Debian still has /usr/X11R6?-)
[10:00] <tepsipakki> both that and /usr/share/fonts/X11/*
[10:00] <jcristau> yeah, for partial upgrades
[10:01] <jcristau> I guess we'll change that post-etch
[10:01] <tepsipakki> ooh, preseeding support
[10:01] <tepsipakki> me like
[10:01] <tepsipakki> not that we use fontservers..
[10:03] <tepsipakki> hi seb128 
[10:03] <seb128> Hi tepsipakki
[10:03] <tepsipakki> I'm doing xorg now, but it'll take a while
[10:04] <tepsipakki> lots of funky stuff in it
[10:05] <seb128> k, I've been busy with other things yesterday, I'll have a look to your libx11 merge if nobody else is on it yet
[10:06] <tepsipakki> cool
[10:14] <tepsipakki> no mention on the changelog as to why dexconf has entries for wacom
[10:14] <tepsipakki> not in Debian
[10:17] <jcristau> tepsipakki: actually no need to file a bug for the Xsession umask stuff, I just committed the fix
[10:18] <tepsipakki> heh
[10:53] <tepsipakki> I'll add 2560x1600 to DEFAULT_DCRESOLUTIONS :)
[10:53] <tepsipakki> I have such a beast
[11:22] <tepsipakki> heh, nice typo on vars.i386
[11:22] <tepsipakki> SERVER_XORG_DETECT_DEPENDS="laptop-detect, xresprobe, mdetect, discover1, dmidecode"
[11:22] <tepsipakki> missing X
[11:25] <tepsipakki> jcristau: vars.amd64 lacks  xserver-xorg-video-vmware for XSERVER_XORG_VIDEO_DEPENDS
[11:27] <jcristau> I'm not sure if the bug is in vars.amd64 or all the others ;)
[11:30] <tepsipakki> * Readd xserver-xorg-driver-vmware to vars.amd64 and remove it from non x86* arches. (Closes Ubuntu: #38070)
[11:31] <tepsipakki> so yes
[11:32] <jcristau> hmm
[11:32] <jcristau> it's both, then :)
[11:32] <tepsipakki> right :)
[11:45] <tepsipakki> 3000 lines of diff to go
[12:02] <tepsipakki> -[ -f /etc/default/rcS ]  && . /etc/default/rcS
[12:02] <tepsipakki> +. /etc/default/rcS
[12:02] <tepsipakki> * debian/x11-common.init: Only source /etc/default/rcS if it exists, allowing x11-common to be installed by debootstrap.
[12:02] <tepsipakki> jcristau: you might want that
[12:03] <jcristau> yeah, possibly
[12:03] <jcristau> (although I don't think debootstrap ever installs x11-common in debian)
[12:08] <cjwatson> not yet :-)
[12:08] <cjwatson> we did that because we were switching to console-setup
[12:08] <cjwatson> which needs xkb-data, which needs x11-common - if Debian ever makes that switch, then you'll need the same thing
[12:08] <jcristau> cjwatson: ok, thanks
[12:14] <tepsipakki> oh joy, next up: xserver-xorg.config.in
[12:15] <tepsipakki> hmm, Debian doesn't have one :)
[12:15] <tepsipakki> wondered why it looked strange
[12:15] <tepsipakki> ah, it's in postinst
[12:16] <tepsipakki>  * Incorporate the entire old xserver-xorg.config script in to the
[12:16] <tepsipakki>     postinst script. This is hideously dirty, but it should allow the script
[12:16] <tepsipakki>     to properly expect discover and xresprobe to be installed without having
[12:16] <tepsipakki>     gross hacks in tasksel just for this task. We'll junk all this for etch+1.
[12:16] <tepsipakki>     Thanks to Joey Hess for the solution.
[12:16] <tepsipakki> cjwatson: so, should we dump the old one and go with Debian?
[12:18] <cjwatson> we'd need to merge our changes to xserver-xorg.config.in into Debian's postinst
[12:18] <tepsipakki> sure
[12:18] <cjwatson> but yes, we should follow that change, imo
[12:18] <cjwatson> 'cos then I can remove *our* gross hacks in tasksel
[12:19] <tepsipakki> Ok, I'll do that after lunch.. my fingers are freezing which means that they scream for energy ;)
[12:19] <tepsipakki> bbl ->
[12:19] <jcristau> cjwatson: joeyh really pushed for that change :)
[12:21] <cjwatson> don't blame him
[12:21] <cjwatson> s/^/I /
[12:35] <Ubugtu> New bug: #4229 in totem (main) "Totem receives BadAlloc when playing very large movies using Xv (dup-of: 35229)" [Medium,Confirmed]  https://launchpad.net/bugs/4229
[01:01] <Hobbsee> tepsipakki: good point. 
[01:01] <tepsipakki> hah
[01:01] <tepsipakki> welcome
[01:02] <tepsipakki> :)
[01:03] <Hobbsee> :)
[01:35] <Ubugtu> New bug: #33753 in gnome-screensaver "don't use OpenGL savers if no hardware support" [Medium,Confirmed]  https://launchpad.net/bugs/33753
[01:36] <seb128> tepsipakki: ping?
[01:38] <tepsipakki> pong
[01:38] <seb128> tepsipakki: libxcb is dep waiting on libpthread-stubs0-dev and required for libx11
[01:38] <seb128> looking at it
[01:38] <tepsipakki> still?
[01:39] <tepsipakki> ok
[02:06] <tepsipakki> -  db_get debian-installer/language || debug_report_status "db_get debian-installer/language"
[02:06] <tepsipakki> -  REALLANG=${RET%%:*}
[02:06] <tepsipakki> -  REALLANG=${REALLANG%%@*}
[02:06] <tepsipakki> +  REALLANG=${LANG%%@*}
[02:06] <tepsipakki> hmm
[02:10] <cjwatson> not sure what stripping :* achieved
[02:10] <tepsipakki> REALLANG=${REALLANG%%.*} came after that
[02:10] <cjwatson> that makes more sense
[02:11] <tepsipakki> but the db_get -stuff.. do I leave it or not
[02:12] <tepsipakki> I'll leave it for now
[02:13] <cjwatson> using LANG should be OK I think
[02:13] <tepsipakki> ok, cleaner that way
[02:13] <cjwatson> tepsipakki: you are doing a merge from the base version of the merge to Debian's version, not just looking at the diff between Ubuntu and Debian, right?
[02:13] <cjwatson> i.e. a proper three-way merge
[02:15] <tepsipakki> no.. diffing latest ubuntu vs latest debian
[02:15] <tepsipakki> grab-merge doesn't work
[02:15] <tepsipakki> since xorg isn't in mergers.u.c
[02:16] <jcristau> where is this debian-installer/language stuff? I don't see it in git
[02:16] <cjwatson> argh
[02:16] <cjwatson> you must do a three-way merge
[02:16] <cjwatson> use snapshot.debian.net
[02:16] <cjwatson> (to get the base version)
[02:16] <cjwatson> you can't merge packages sanely without a three-way merge
[02:17] <cjwatson> it's far too easy to lose stuff by mistake
[02:17] <jcristau> oh, it's only in ubuntu
[02:17] <tepsipakki> alright, looking
[02:21] <tepsipakki> debdiff 7.0.22 - 7.1.1ubuntu8 is a measly 65kB :)
[03:14] <seb128> tepsipakki: not good, after xcb installation and libx11 upgrade my gnome-session crashes directly
[03:14] <seb128> gnome-session: xcb_xlib.c:50: xcb_xlib_unlock: Assertion `c->xlib.lock' failed.
[03:15] <jcristau> seb128: there are patches in a few other X libs, did you upgrade them?
[03:15] <seb128> jcristau: I'm uptodate with feisty
[03:15] <jcristau> hmm
[03:15] <seb128> might be that something didn't get synced or didn't build yet
[03:15] <jcristau> can you get a backtrace?
[03:15] <seb128> in which case the libx11 Depends needs to enforce the update
[03:16] <seb128> #1  0xb7661df0 in raise () from /lib/tls/i686/cmov/libc.so.6
[03:16] <seb128> #2  0xb7663641 in abort () from /lib/tls/i686/cmov/libc.so.6
[03:16] <seb128> #3  0xb765b43b in __assert_fail () from /lib/tls/i686/cmov/libc.so.6
[03:16] <seb128> #4  0xb71d4651 in xcb_xlib_unlock () from /usr/lib/libxcb-xlib.so.0
[03:16] <seb128> #5  0xb79c9bd4 in _XCBUnlockDisplay (dpy=0x8076140) at ../../src/xcb_lock.c:34
[03:16] <seb128> #6  0xb7ab1601 in XRRQueryVersion () from /usr/lib/libXrandr.so.2
[03:16] <seb128> #7  0xb7ab1762 in XRRSetScreenConfigAndRate () from /usr/lib/libXrandr.so.2
[03:16] <seb128> let me install debug packages for it
[03:16] <tepsipakki> ok, that's strange
[03:16] <seb128> oh
[03:16] <jcristau> probably a bug in libxrandr then
[03:16] <seb128> my GNOME session set an another resolution than the xorg one with xrandr
[03:16] <seb128> yep
[03:17] <jcristau> unlockdisplay without holding the lock
[03:17] <seb128> weird that it's triggered after the libxcb installation or the libx11 upgrade though
[03:17] <seb128> let me downgrade libx11
[03:17] <jcristau> looks like #400441
[03:19] <tepsipakki> indeed
[03:20] <seb128> ii  libxrandr2                1.1.1-0ubuntu1            X11 RandR extension library
[03:21] <cjwatson> http://lists.debian.org/debian-devel-announce/2006/11/msg00010.html
[03:21] <cjwatson> "Both of these represent bugs in a caller of libX11, and *not* in libX11
[03:21] <cjwatson> or libxcb."
[03:23] <seb128> I blame libxrandr
[03:23] <seb128> let's see if 1.1.1 has the pointed patch
[03:25] <seb128> bah
[03:25] <seb128> libxrandr 1.1.1 doesn't have the patch
[03:27] <seb128> tepsipakki: any reason we can't update libxrandr to 1.2.0 now?
[03:27] <tepsipakki> jcristau: ^^ :)
[03:27] <seb128> Debian has it
[03:28] <tepsipakki> was it just released
[03:28] <jcristau> yes, yesterday or so
[03:28] <tepsipakki> oh, that old
[03:28] <jcristau> it needs x11proto 1.2
[03:28] <jcristau> err
[03:28] <jcristau> x11proto-randr 1.2
[03:29] <tepsipakki> maybe it won't break anything
[03:29] <seb128> x11proto-randr |    1.2.0-1 | http://archive.ubuntu.com feisty/main Sources
[03:29] <seb128> grumpf
[03:29] <seb128> 99_configure
[03:29] <seb128> Applying patches...failed! (check stampdir/log/patch for details)
[03:29] <seb128> I hate that quilt patch
[03:29] <seb128> s/patch/bug
[03:29] <seb128> when there is no patch it tries to apply a 99_configure for whatever reason
[03:30] <tepsipakki> sih
[03:30] <seb128> mkdir debian/patches fixes it
[03:30] <seb128> build new libxrandr
[03:30] <jcristau> tepsipakki: by the way the server needs a patch in randr/randr.c
[03:30] <tepsipakki> or run debian/rules prepare?
[03:30] <cjwatson> jcristau: same as the damage patch?
[03:31] <jcristau> yeah s/RANDR_MAJOR/1/;s/RANDR_MINOR/1/
[03:31] <seb128> ok
[03:31] <seb128> new libxrandr fixes gnome-session for me
[03:31] <seb128> anybody has an objection with syncing 1.2.0 from Debian now?
[03:31] <jcristau> libxrandr from experimental is buggy
[03:31] <jcristau> I forgot to bump the shlibs
[03:31] <seb128> ah :/
[03:31] <jcristau> :/
[03:31] <seb128> ah, only that
[03:32] <jcristau> yeah
[03:32] <seb128> I can fix that ;)
[03:32] <jcristau> as far as I know :)
[03:32] <seb128> should be safe to update before libx11, mesa, server, etc?
[03:32] <jcristau> it's fixed in git, I guess I could just upload it
[03:32] <seb128> would be nice
[03:32] <seb128> that way we could just sync it
[03:33] <jcristau> I have crappy uplink, but let's try it
[03:33] <seb128> libxrandr is quite small
[03:33] <seb128> especially if you don't have to upload the orig
[03:34] <seb128> brb, restarting a proper GNOME session
[03:48] <jcristau> seb128: you can get http://incoming.debian.org/libxrandr_1.2.0-3_i386.changes
[03:48] <jcristau> should be fine now
[03:48] <seb128> jcristau: nice, thank you!
[04:08] <seb128> libxrandr sync done
[04:21] <tepsipakki> finally.. xorg close to being ready
[04:26] <tepsipakki> cjwatson: actually, it was a lot easier to merge that way..
[04:27] <tepsipakki> since there wasn't a lot of upstream changes to distract you
[04:27] <cjwatson> yeah, it can often be that way
[04:40] <tepsipakki> I should probably keep the changelog as well
[04:42] <tepsipakki> easy
[05:03] <tepsipakki> ok, xorg is now in http://users.tkk.fi/~tjaalton/xorg/new
[05:03] <tepsipakki> and also on my repository
[05:03] <tepsipakki> tested it and it installed fine, but I guess it should
[05:04] <tepsipakki> 've updated the xorg.conf font-paths
[05:04] <tepsipakki> which it didn't do
[05:24] <tepsipakki> ah
[05:24] <tepsipakki> if [ -z "$UPGRADE" ]  || dpkg --compare-versions "$2" le "1:7.0.14"; then
[05:24] <tepsipakki> we might want to bump that
[05:25] <tepsipakki> but sadly, I need to go now..
[05:27] <tepsipakki> xorg took longer than expected
[06:31] <Ubugtu> New bug: #20283 in xserver-xorg-video-ati "[fgl v5000]  really bad sync" [Medium,Needs info]  https://launchpad.net/bugs/20283
[06:32] <seb128> tepsipakki: libpthread-stubs has been accepted which should make libxcb build
[06:56] <Ubugtu> New bug: #27466 in xserver-xorg-video-ati "[radeon]  can't do dual-link tmds, or second tmds transmitter" [Medium,Confirmed]  https://launchpad.net/bugs/27466
[07:19] <tepsipakki> seb128: phew, progress :)
[07:20] <seb128> tepsipakki: I think libx11 will be ready to go tomorrow morning
[07:20] <seb128> I don't want to upload before stopping working today
[07:27] <tepsipakki> thats fine
[07:28] <tepsipakki> I packaged a new xorg-server which has a patch that makes it use randr protocol 1.1
[07:30] <seb128> tepsipakki: why?
[07:30] <seb128> tepsipakki: we have xrandr 1.2.0 now
[07:30] <jcristau> seb128: xserver 1.2 doesn't speak randr 1.2
[07:30] <tepsipakki> but xserver doesn't support that :)
[07:30] <jcristau> 1.3 will
[07:31] <tepsipakki> I took the damage-patch approach
[07:31] <seb128> ah, ok
[07:31] <tepsipakki> we don't seem to have an operator on this channel
[07:31] <seb128> do we need one?
[07:31] <seb128> ah, to set topic?
[07:31] <tepsipakki> the url to my repo could be on topic
[07:31] <tepsipakki> yes
[07:32] <jcristau> the channel doesn't seem to be +t?
[07:57] <Ubugtu> New bug: #85811 in xorg (main) "[Feisty-Herd4-alternate-amd64]  Cannot change screen resolution at installation time" [Undecided,Confirmed]  https://launchpad.net/bugs/85811
[09:17] <seb128> tepsipakki, jcristau: can mesa be updated before libx11?
[09:17] <jcristau> yes
[09:17] <seb128> ok
[09:17] <seb128> compiz just crash now
[09:17] <jcristau> heh :)
[09:17] <seb128> #3  0xb7cb343b in __assert_fail () from /lib/tls/i686/cmov/libc.so.6
[09:17] <seb128> #4  0xb7c5f651 in xcb_xlib_unlock () from /usr/lib/libxcb-xlib.so.0
[09:17] <seb128> #5  0xb7eabbd4 in _XCBUnlockDisplay (dpy=0x8075388) at ../../src/xcb_lock.c:34
[09:17] <seb128> #6  0xb7e13475 in __glXInitialize () from /usr/lib/libGL.so.1
[09:17] <seb128> I think that's the same lock problem than libxrandr
[09:18] <seb128> just for libgl
[09:18] <jcristau> hmm, I'll have a look at mesa 6.5.2
[09:24] <jcristau> seb128: that's probably fixed in 6.5.2, there are a number of fixes that seem related
[09:24] <seb128> good
[09:24] <seb128> that's next on the updates list then ;)
[09:28] <jcristau> maybe https://bugs.freedesktop.org/show_bug.cgi?id=8521
[09:28] <Ubugtu> Freedesktop bug 8521 in GLX "AllocAndFetchScreenConfigs unlocks twice" [Normal,Resolved: fixed]  
[09:34] <jcristau> I wonder if xlib/xcb should conflict with previous versions of libs that have known locking bugs
[09:36] <seb128> probably yep
[09:37] <seb128> because otherwise it just breaks lot of things for people doing partial upgrades
[09:37] <seb128> like the libxrandr bug broke gnome-session on my desktop
[09:48] <jcristau> or is that a use case for Breaks?
[09:48] <seb128> it's an usecase for Breaks
[09:48] <seb128> but is Debian use Breaks yet?
[09:48] <cjwatson> almost every use of Conflicts << is a use case for Breaks ;-)
[09:48] <cjwatson> indeed, Breaks can't be deployed in Debian yet AFAIK
[09:49] <cjwatson> talk to iwj ...
[10:12] <Ubugtu> New bug: #86550 in xorg (main) "Video card no longer supported by Ubuntu" [Undecided,Needs info]  https://launchpad.net/bugs/86550
[10:21] <Ubugtu> New bug: #86301 in xorg (main) "Feature Request: Dynamic head configuration in X.org" [Undecided,Unconfirmed]  https://launchpad.net/bugs/86301
[10:46] <Ubugtu> New bug: #85451 in Ubuntu "Switch tty, shutdown, reboot cause colorful screen with Nvidia proprietary driver (dup-of: 63558)" [Undecided,Needs info]  https://launchpad.net/bugs/85451
[10:52] <tepsipakki> jcristau: so, xserver 1.3 will be mostly a bugfix-release, and not targeted for 7.3?
[10:52] <tepsipakki> reading http://wiki.x.org/wiki/XDC2007Notes
[10:52] <jcristau> err
[10:53] <tepsipakki> updates to the protocols yes.. can't blame that being just bugfixing :)
[10:53] <jcristau> maybe if you count output-hotplug (randr 1.2) as bugfixing
[10:53] <jcristau> :)
[10:54] <jcristau> I think keithp wants to release 1.3 next week or so
[10:56] <tepsipakki> so I've heard too
[10:58] <seb128> tepsipakki: did you work on the mesa update yet?
[10:58] <tepsipakki> seb128: it's in the same place as the rest
[10:58] <seb128> ok
[10:58] <seb128> can it be uploaded next?
[10:59] <tepsipakki> http://users.tkk.fi/~tjaalton/xorg72/new
[10:59] <tepsipakki> hell, why not :)
[10:59] <seb128> just making sure if you consider it ready before looking at it
[11:00] <tepsipakki> well, the changelog seems funny
[11:00] <tepsipakki> need to fix it
[11:00] <seb128> looks fine to me
[11:01] <tepsipakki> the one in diff.gz isn't ;)
[11:01] <seb128> I'll do mesa next tomorrow morning if nobody has an objection
[11:01] <seb128> I looked at the .changes for the moment :p
[11:01] <seb128> mesa needs to go before libx11
[11:01] <tepsipakki> that sounds ok for me
[11:01] <tepsipakki> oh it does?
[11:01] <seb128> did you read what I wrote like an hour ago?
[11:01] <tepsipakki> ah, you mean the libxcb breakage?
[11:02] <seb128> right
[11:02] <seb128> it's not libxcb which is broken though
[11:02] <tepsipakki> right
[11:02] <seb128> it's other packages
[11:02] <seb128> and the mesa bug makes compiz crash after libx11 update
[11:03] <seb128> so better to get the mesa update done first
[11:03] <tepsipakki> yep
[11:04] <seb128> ok, anyway enough work for today, I'll build mesa locally, install it and we will see for the upload tomorrow morning if it doesn't break half of my desktop ;)
[11:04] <tepsipakki> you can delete the ubuntu0.1 part of the changelog while you're at it :)
[11:05] <seb128> ok
[11:05] <seb128> did you build it?
[11:05] <tepsipakki> yes, it
[11:05] <tepsipakki> damn
[11:05] <seb128> it refuses to build due Maintainer not changer
[11:05] <seb128> changed
[11:06] <seb128> just wondering :p
[11:06] <tepsipakki> oh
[11:06] <tepsipakki> well maybe it was with older tools
[11:06] <tepsipakki> a week ago or something
[11:06] <seb128> ok, building now
[11:06] <tepsipakki> it takes ~1h with my laptop
[11:06] <seb128> we will see how it works
[11:07] <tepsipakki> so didn't bother building it too often
[11:07] <seb128> I'll tell you that tomorrow morning
[11:07] <seb128> right
[11:07] <tepsipakki> sure, g'night
[11:07] <seb128> 'night