asac | can you paste the original patch as well please ? | 12:28 |
---|---|---|
asac | e.g. the one that is still in debian/patches ? | 12:28 |
gnomefreak | yes | 12:28 |
asac | gnomefreak: you sure you saved? | 12:28 |
asac | I don't see any PROGRAM lines in that diff | 12:28 |
gnomefreak | http://pastebin.mozilla.org/114364 | 12:28 |
gnomefreak | asac: yes i was looking at that too let me see | 12:29 |
asac | you didn't save | 12:29 |
asac | as you can see the diff for mozilla.orig/browser/app/Makefile.in is now completely missing in your new quilt diff | 12:30 |
gnomefreak | http://pastebin.mozilla.org/114367 | 12:30 |
asac | please do the change | 12:30 |
gnomefreak | still missing and yes i saved | 12:30 |
gnomefreak | i did already | 12:30 |
asac | look into that file again | 12:30 |
asac | (open in new editor) | 12:30 |
gnomefreak | ifeq ($(USE_SHORT_LIBNAME), 1) | 12:31 |
gnomefreak | PROGRAM = $(MOZ_APP_NAME)-trunk$(BIN_SUFFIX) | 12:31 |
gnomefreak | else | 12:31 |
gnomefreak | PROGRAM = $(MOZ_APP_NAME)-trunk-bin$(BIN_SUFFIX) | 12:31 |
gnomefreak | endif | 12:31 |
asac | you sure you are in right directory tree? | 12:32 |
gnomefreak | yes i opened it up new and save never saved it | 12:32 |
=== gnomefreak thinks gedit issue | ||
asac | ah | 12:32 |
asac | please save it :) | 12:32 |
asac | when your change shows up in quilt diff ... let me know :) | 12:32 |
gnomefreak | http://pastebin.mozilla.org/114369 | 12:33 |
asac | yeah ... that looks better | 12:33 |
gnomefreak | i did save it the whole time :( | 12:33 |
asac | ok ... updating patch is now really simple ;) | 12:33 |
asac | just do | 12:33 |
asac | quilt refresh --diffstat -U8 | 12:33 |
gnomefreak | in mozilla dir still i take it | 12:34 |
gnomefreak | ok refreshed | 12:34 |
asac | do it whereever you ran quilt diff | 12:34 |
asac | ok ... now you can stay in that directory and see if all other patches apply as well | 12:34 |
asac | (e.g. lets excercise quilt a bit) | 12:34 |
gnomefreak | k | 12:34 |
asac | run quilt top | 12:34 |
asac | it should show you the currently top-most patch applied | 12:35 |
asac | (which should be trunk-fsh) | 12:35 |
gnomefreak | trunk-fsh | 12:35 |
asac | you see that? | 12:35 |
asac | yeah | 12:35 |
asac | run quilt series | 12:35 |
asac | what do you see? | 12:35 |
gnomefreak | 3 of them | 12:35 |
asac | the whole series, right? | 12:35 |
gnomefreak | no-have-stdint-h-ftbfs.patch | 12:35 |
gnomefreak | trunk-fsh | 12:35 |
gnomefreak | ftbfs-with-branding-dir | 12:35 |
gnomefreak | yes | 12:35 |
asac | that should be all patches listed in series | 12:36 |
asac | you can do quilt applied | 12:36 |
asac | to see which ones are currently applied | 12:36 |
gnomefreak | although there are 5 or so in debian/patches so i may get rid of the non used patches | 12:36 |
asac | yeah ... might be that i removed them from series weithout removing the in patches | 12:36 |
gnomefreak | no-have-stdint-h-ftbfs.patch | 12:36 |
gnomefreak | trunk-fsh | 12:36 |
asac | yeah ... and unapplied? | 12:36 |
gnomefreak | missing one | 12:36 |
asac | -> quilt unapplied | 12:36 |
gnomefreak | ftbfs-with-branding-dir | 12:37 |
asac | which is what we expected, right? | 12:37 |
gnomefreak | why did we expect that one to not be applied | 12:37 |
asac | because the trunk-fsh failed | 12:37 |
gnomefreak | other than the other 2 were wuilt applied | 12:37 |
gnomefreak | ah ok | 12:37 |
asac | we now applied it manually | 12:37 |
asac | and now we can apply the last one with | 12:38 |
asac | quilt push | 12:38 |
asac | try that | 12:38 |
asac | does it fail? | 12:38 |
gnomefreak | its patched | 12:38 |
asac | cool | 12:38 |
asac | ok ... don't go out | 12:38 |
asac | just get a feeling for what quilt does | 12:38 |
asac | try quilt pop | 12:38 |
asac | then look at unapplied and applied again | 12:38 |
asac | then do another pop | 12:38 |
gnomefreak | hey | 12:38 |
gnomefreak | pop redoes the last thing you did ? | 12:39 |
gnomefreak | or just last patch applied | 12:39 |
asac | pop unapplies what is currently on top | 12:39 |
gnomefreak | ah ok | 12:39 |
asac | with pop you unapply ... with push you apply | 12:39 |
asac | you can pop all by | 12:39 |
asac | quilt pop -a | 12:39 |
asac | then all patches should be in unapplied | 12:39 |
asac | and applied should be none | 12:40 |
asac | do you see? | 12:40 |
asac | then you can apply all again by quilt push -a | 12:40 |
asac | :) | 12:40 |
gnomefreak | yes | 12:40 |
asac | after that all should be in applied | 12:40 |
asac | and non in unapplied | 12:40 |
asac | ok ...fine | 12:40 |
asac | the trunk-fsh patch is not fixed and applies cleanly | 12:40 |
asac | just ensure that you copy it to the debian/patches directory of bzr tree | 12:41 |
asac | (so you don't loose it) | 12:41 |
gnomefreak | not fixed because we need to add quilt diff inplace of whats there? | 12:41 |
asac | no | 12:41 |
gnomefreak | oh | 12:41 |
asac | you did quilt refresh | 12:41 |
asac | that updated the patch for you | 12:41 |
asac | its already fine | 12:41 |
gnomefreak | cool | 12:41 |
asac | otherwise you would not be able to pop | 12:41 |
asac | or push it | 12:41 |
gnomefreak | makes sense | 12:41 |
asac | cool :) | 12:42 |
asac | well done | 12:42 |
asac | you merged the patch ;) | 12:42 |
gnomefreak | :) sweet ty | 12:42 |
gnomefreak | now lets see if it works | 12:42 |
asac | yeah (but please remember that bzr bd wipes your build-area) | 12:42 |
asac | so copy the new trunk-fsh patch there | 12:42 |
gnomefreak | im using dpkg-buildpackage | 12:42 |
asac | you can of course just build in build-area | 12:42 |
asac | right | 12:42 |
asac | (but don't forget to copy it) | 12:43 |
asac | :) | 12:43 |
gnomefreak | copy it | 12:43 |
asac | to bzr tree ... so its preserved | 12:43 |
asac | (unless you are in bzr of course) :) | 12:43 |
asac | i don't know how you build ... and i don't really care ;) | 12:43 |
gnomefreak | wait you mean the .bzr dir? | 12:43 |
gnomefreak | or you mean push to branch? | 12:43 |
asac | gnomefreak: commit the new patch :) | 12:43 |
gnomefreak | ah yes | 12:44 |
asac | do you use bzr bd or not? | 12:44 |
asac | if you don't use bzr bd ... its just commit | 12:44 |
asac | and publish it | 12:44 |
asac | once the build went well | 12:44 |
asac | (probably not before) | 12:44 |
asac | gnomefreak: so basically what you did was the same what you do when you do a merge | 12:45 |
asac | e.g. manually applying changes that patch is to stupid to apply | 12:45 |
gnomefreak | ok lets try this again :) | 12:48 |
asac | you can just use | 12:48 |
asac | dpkg-buildpackage -rfakeroot -nc | 12:48 |
asac | to go on | 12:48 |
asac | e.g. without unpacking and stuff like that | 12:49 |
asac | is fucking mp3 player is driving me nuts | 12:49 |
asac | it just refuses to get back to a sane state after you disconnnet it without pulling the plug | 12:50 |
asac | who knows ... maybe it just cannot reconfigure at all | 12:51 |
asac | and i have to write a server that keeps line up until the plug is physically reset | 12:51 |
asac | am i still here? | 12:54 |
asac | lag is hitting me again | 12:55 |
gnomefreak | irc lag? | 12:56 |
asac | yeah ... but apparently my connection worked well | 12:57 |
asac | gnomefreak: do you have access to a windows box? | 12:58 |
gnomefreak | no | 12:58 |
gnomefreak | win box is all fudged up from what im hearing i told her id get to it this weekend so shes using laptop until than | 12:58 |
asac | i already have lag | 12:59 |
asac | i probably will not survive long | 12:59 |
asac | gnomefreak: let me know when you have access to win :) | 01:00 |
asac | i just need to get a spec that is only shipped in .exe | 01:00 |
asac | which i cannot extract | 01:00 |
asac | http://msdn2.microsoft.com/en-us/library/ms867188.aspx | 01:00 |
asac | there is the spec | 01:00 |
asac | these bastards | 01:00 |
asac | i hate ms so much | 01:02 |
asac | these ignorant bastards | 01:02 |
asac | hopefully they will suffocate from in their own ignorance | 01:02 |
gnomefreak | why are you using it :) | 01:02 |
asac | i don't use it | 01:03 |
asac | i want to enable these shitty devices they force upon the world on linux | 01:04 |
asac | almost all high-end mp3 players use MTP | 01:04 |
asac | nowadays | 01:04 |
asac | no usb-storage anymore | 01:04 |
asac | everything that is more than a mp3-stick | 01:04 |
asac | is mtp | 01:04 |
gnomefreak | ah | 01:04 |
gnomefreak | brb smoke now that i got this to start | 01:05 |
=== cjwatson_ [n=cjwatson@82-69-40-219.dsl.in-addr.zen.co.uk] has joined #ubuntu-mozillateam | ||
gnomefreak | bug 123829 | 01:56 |
ubotu | Launchpad bug 123829 in dhcp "Latest Gutsy Upgrade does not connect to DHCP anymore." [Undecided,Confirmed] https://launchpad.net/bugs/123829 | 01:56 |
=== DarkMageZ [n=richard@238.101.233.220.exetel.com.au] has joined #ubuntu-mozillateam | ||
asac | probably a network manager issue ./ | 02:37 |
asac | :/ | 02:37 |
gnomefreak | grrrrrr | 03:26 |
gnomefreak | asac: can you please test bug 123882 on feisty 64bit when you get time | 03:31 |
ubotu | Launchpad bug 123882 in firefox "Some web sites reload infinitely, but not on Opera" [Low,Incomplete] https://launchpad.net/bugs/123882 | 03:31 |
asac | gnomefreak: not reproducible .. added comment | 03:32 |
gnomefreak | ah ok ty i added one he had said more than 1 site so i wanna see the others | 03:33 |
gnomefreak | asac: trunk failed to build | 03:33 |
gnomefreak | i will look into it more in the morning im going to bed | 03:34 |
=== DarkMageZ [n=richard@238.101.233.220.exetel.com.au] has joined #ubuntu-mozillateam | ||
hjmf_ | asac: I've submitted bug 123926 | 08:04 |
ubotu | Launchpad bug 123926 in totem "added Xb-Npp-xxx tags accordingly to "firefox distro add-on suport" spec" [Undecided,New] https://launchpad.net/bugs/123926 | 08:04 |
=== hjmf_ 's out for the morning | ||
hjmf_ | cu | 08:04 |
=== shirish [n=shirish@59.95.54.99] has joined #ubuntu-mozillateam | ||
=== shirish [n=shirish@59.95.54.99] has left #ubuntu-mozillateam [] | ||
=== shirish [n=shirish@59.95.32.111] has joined #ubuntu-mozillateam | ||
=== shirish [n=shirish@59.95.32.111] has left #ubuntu-mozillateam [] | ||
=== gnomefreak is in for a while | ||
asac | hjmf_: great | 10:54 |
asac | i just want to verify that plugin-id is the right one ... then i push it | 10:54 |
asac | lets see | 10:54 |
gnomefreak | asac: is there a way to crash firefox just for shits and giggles? | 10:56 |
=== gnomefreak doesnt seem to be affected by libcairo(if causing crashes) | ||
gnomefreak | this is annoying as hell | 11:01 |
gnomefreak | gonna see if restarting fixes this brb | 11:04 |
=== jerome___ [n=jerome@gra94-2-82-66-142-60.fbx.proxad.net] has joined #ubuntu-mozillateam | ||
=== gnomefreak [n=gnomefre@ubuntu/member/gnomefreak] has joined #ubuntu-mozillateam | ||
gnomefreak | who has ~256mb ram that i can borrow to test something? | 11:16 |
gnomefreak | why is it no matter what string i search for i can never find upstream bugs maybe i need to search for somethin unrelated :( | 11:22 |
asac | gnomefreak: you say its because of too little mem? | 11:22 |
asac | gnomefreak: what bug do you try to triage? | 11:22 |
gnomefreak | i get crash and it cant send crash report due to not enough memory | 11:22 |
gnomefreak | bug 80964 | 11:23 |
ubotu | Launchpad bug 80964 in mozilla-thunderbird "MASTER mozilla-thunderbird crashed [@nsNSSCertificateDB::ImportCertsFromFile] " [High,Confirmed] https://launchpad.net/bugs/80964 | 11:23 |
gnomefreak | asac: do you remember seeing a thunderbird crash while deleting Imap message? i found upstream and i thought i remembered seeing it. | 11:34 |
asac | hjmf_: all sponsored ... rock! | 11:37 |
asac | hjmf_: i had to adapt changelog because uploads happened in the meantime ... though my bad | 11:38 |
asac | gnomefreak: can you please verify that this crash happens with latest upstream binary release as well? | 11:39 |
asac | gnomefreak: otherwise, they will probably hunt us down :) | 11:39 |
gnomefreak | k | 11:39 |
asac | if we post upstream | 11:39 |
asac | hjmf_: would be great if you could verify tonight that the packages succeeded to build | 11:40 |
gnomefreak | let me know when you have a few minutes strange feeling we are gonna need a few patches for trunk | 11:43 |
=== jeromeg_ [n=jerome@gra94-2-82-66-142-60.fbx.proxad.net] has joined #ubuntu-mozillateam | ||
asac | gnomefreak: yeah ... i always have a few minutes for you ;) | 11:46 |
gnomefreak | :) | 11:46 |
gnomefreak | well your not gonna like this im sure http://pastebin.mozilla.org/114392 | 11:46 |
=== jeromeg [n=jerome@gra94-2-82-66-142-60.fbx.proxad.net] has joined #ubuntu-mozillateam | ||
asac | gnomefreak: first think you should do if things fail on trunk is to look in bonsai | 11:54 |
asac | if there has been a checkin after that .... if it fails for all | 11:54 |
asac | there is most likely a checkin that fixes this pretty quick | 11:55 |
asac | http://bonsai.mozilla.org/ | 11:55 |
asac | look what was checked in last week in mozilla/toolkit/xre directory | 11:55 |
asac | on HEAD | 11:55 |
asac | maybe you just need to take a new snapshot | 11:55 |
asac | and things will be done | 11:55 |
asac | (that said: from a first glance, this looks like a bug in Makefile.in of that directory) | 11:56 |
gnomefreak | hmmmm i cant open links from irssi anymore :( | 12:06 |
gnomefreak | asac: do i want to look in thunderbirdtinderbox? | 12:08 |
asac | why thunderbird? | 12:10 |
asac | its firefox trunk that fails, right? | 12:10 |
asac | gnomefreak: open the bonsai url above | 12:10 |
asac | you can fill in the fields | 12:10 |
asac | e.g. just set the directory like above | 12:10 |
asac | ensure that Branch is HEAD (should be default) | 12:10 |
gnomefreak | oh damn | 12:10 |
asac | and set how far you want to look in the past (e.g. today, week, month, since beginning of time) | 12:11 |
asac | usually a week should give you enough info | 12:11 |
gnomefreak | it lists the same as the thunderbird search i did by mistake | 12:13 |
gnomefreak | http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaBranchTinderboxAll&branch=HEAD&branchtype=match&dir=mozilla%2Ftoolkit%2Fxre&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=week&mindate=&maxdate=&cvsroot=%2Fcvsroot | 12:13 |
gnomefreak | should i diff http://lxr.mozilla.org/mozilla/source/toolkit/xre/Makefile.in against the makefile.in from the source i have? oh and i dont know how to do snapshots :( | 12:18 |
gnomefreak | thunder crashes upstream as well | 12:19 |
=== asac_ [n=asac@debian/developer/asac] has joined #ubuntu-mozillateam | ||
asac_ | sprry this sucky connection is shaky again | 12:23 |
=== asac_ [n=asac@debian/developer/asac] has joined #ubuntu-mozillateam | ||
gnomefreak | i dont see anything that jumps out and smacks me in face with this FTB | 12:24 |
asac_ | gnomefreak: do you have build failure again? | 12:30 |
asac_ | i lost my irssi history | 12:30 |
bluekuja | heya guys | 12:30 |
asac_ | bluekuja: hey | 12:31 |
bluekuja | asac_: is possible to add something to previous changelog's entries? | 12:31 |
bluekuja | documenting it in new one | 12:31 |
asac_ | bluekuja: imo yes ... but you should document that in new ... yes | 12:31 |
bluekuja | asac_: I'll do that for regex | 12:31 |
bluekuja | seems it's what we need | 12:32 |
asac_ | yes right ... fix the changelog to be more readable and add it to outstanding merges | 12:32 |
bluekuja | asac_: I prepare a diff and I push it on pastebin | 12:32 |
bluekuja | for you | 12:32 |
asac_ | of the merge changelog | 12:33 |
gnomefreak | asac_: http://pastebin.mozilla.org/114392 build failure | 12:33 |
asac_ | if this connection resets one more time ... i will go kamikaze | 12:36 |
asac_ | i see lag already | 12:36 |
asac_ | still here? | 12:36 |
asac_ | ping | 12:36 |
asac_ | gnomefreak: ?? | 12:37 |
asac_ | am i still here? | 12:37 |
gnomefreak | yes | 12:37 |
gnomefreak | did you get the failure? | 12:37 |
gnomefreak | asac_: you still here or did you get dissconnected again | 12:38 |
asac_ | yeah i am here | 12:39 |
asac_ | please cross-fingers that i stay for an hour or so | 12:39 |
gnomefreak | k good | 12:39 |
asac_ | until this mozilla bzr branch is completely scp'ed to people.ubuntu.com at lsat | 12:39 |
gnomefreak | what branch is this? | 12:39 |
asac_ | mobile | 12:40 |
gnomefreak | ah | 12:40 |
asac_ | a complete 350M branch | 12:40 |
asac_ | e.g. not just debian | 12:40 |
gnomefreak | omg that is huge | 12:40 |
asac_ | like what i did for git ... but using bzr | 12:40 |
asac_ | gnomefreak: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Ftoolkit%2Fxre&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=week&mindate=&maxdate=&cvsroot=%2Fcvsroot | 12:40 |
asac_ | if you look there | 12:40 |
asac_ | there is a change to Makefile.in | 12:40 |
asac_ | he? | 12:41 |
asac_ | its not really huge | 12:41 |
asac_ | anyway ... its broken | 12:41 |
gnomefreak | upstream is broken? | 12:41 |
asac_ | yeah ... look at the libs:: line they added | 12:41 |
asac_ | they should have done the same for install | 12:41 |
asac_ | so lest do a quilt patch for that | 12:41 |
asac_ | you ready? | 12:41 |
asac_ | have tree that failed lying around? | 12:41 |
gnomefreak | give me 1 minute to get set up for it | 12:42 |
gnomefreak | ok do i need to be in build-tree? | 12:43 |
=== gnomefreak there since we did that lastnight :) | ||
gnomefreak | ok ready when you are :) | 12:44 |
asac | ok | 12:52 |
asac | you have to go to build-tree | 12:52 |
asac | mozillla | 12:52 |
asac | you in that directory? | 12:52 |
gnomefreak | yep | 12:52 |
asac | please verify with quilt applied /unapplied that actually all current patches are applied | 12:53 |
asac | like we did yesterday | 12:53 |
gnomefreak | all applied | 12:53 |
asac | then you create a new patch by | 12:53 |
asac | quilt new PATCHNAME .... use ftbfs_toolkit_xre_Makefile_in | 12:54 |
asac | as PATCHNAME | 12:54 |
gnomefreak | end with .patch or no need to end with anything? | 12:54 |
asac | no ... we usually don't use .patch in the end | 12:56 |
gnomefreak | k | 12:56 |
asac | or can you see .patch in any applied? | 12:56 |
gnomefreak | its now on top | 12:56 |
gnomefreak | just one | 12:56 |
asac | yeah | 12:56 |
asac | right | 12:56 |
asac | ok | 12:56 |
asac | now quilt is not like bzr | 12:56 |
asac | it doesn't know anything about the state | 12:57 |
asac | so you have to tell quilt that it should observe the file you are going to touch | 12:57 |
asac | in order to do that you have to | 12:57 |
asac | quilt add path/to/file/you/want/to/Edit | 12:57 |
asac | in our case its toolkit/xre/Makefile.in , right? | 12:57 |
gnomefreak | /toolkit/xre | 12:57 |
gnomefreak | ah yes makefile | 12:58 |
gnomefreak | thats a good question but yes i think it is makefile.in | 12:58 |
gnomefreak | im looking at failure | 12:58 |
asac | look at bonsai | 12:59 |
asac | its definitly toolkit/xre/Makefile.in | 12:59 |
gnomefreak | ah yes | 12:59 |
asac | because it failed in toolkit/xre | 12:59 |
gnomefreak | right | 12:59 |
asac | so add that file to be tracked in that patch | 12:59 |
asac | like above | 12:59 |
asac | then go into that file and fix the install:: target | 12:59 |
gnomefreak | File toolkit/xre/Makefile.in added to patch ftbfs_toolkit_xre_Makefile_in | 12:59 |
asac | (look how the libs:: line looks | 12:59 |
asac | yeah | 01:00 |
gnomefreak | where is the patch at this point? | 01:00 |
asac | its been created in debian/patches/ | 01:00 |
asac | but you don't need to care | 01:00 |
gnomefreak | its not there | 01:01 |
asac | it might even be not yet created (until first content is added) | 01:03 |
gnomefreak | ah ok | 01:03 |
asac | it gets created lazily | 01:03 |
asac | so edit makefile.in ... and look at your changes by | 01:03 |
asac | quilt diff | 01:03 |
gnomefreak | k let me see what we have | 01:03 |
gnomefreak | http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/toolkit/xre&command=DIFF_FRAMESET&root=/cvsroot&file=Makefile.in&rev1=1.79&rev2=1.80 | 01:03 |
gnomefreak | that page (shows diff) | 01:03 |
asac | yeah | 01:03 |
asac | they added new targets for platform.ini | 01:03 |
asac | but failed to do it right for install:: target | 01:03 |
asac | because nobody upstream uses make install | 01:03 |
asac | so we ran into this | 01:03 |
asac | look how the libs:: line looks like | 01:04 |
asac | the install:: line should be similar | 01:04 |
asac | just fix that and show me quilt diff | 01:04 |
gnomefreak | oh so just use whats on the right hand side | 01:05 |
asac | yeah | 01:05 |
asac | they forgot | 01:05 |
asac | because they never use install | 01:05 |
asac | its always the same | 01:05 |
asac | install is always broken if they add something | 01:05 |
asac | either it forgets something ... or it has a typo | 01:05 |
gnomefreak | i have to find right makefile :( | 01:07 |
asac | hey ... its the one you just added to patch | 01:07 |
asac | remember? | 01:07 |
asac | gnomefreak: you should learn to use vi at some point | 01:08 |
asac | gedit will bring you to a mental institution at some point | 01:08 |
asac | anyway ... not today ;) | 01:08 |
asac | gnomefreak: you said: | 01:10 |
asac | 12:59 < gnomefreak> File toolkit/xre/Makefile.in added to patch ftbfs_toolkit_xre_Makefile_in | 01:10 |
asac | if that helps ;) | 01:10 |
gnomefreak | yeah i know but it looks exactly the same | 01:10 |
asac | same like what? | 01:11 |
gnomefreak | i guess its not hte green part i need to be looking for | 01:11 |
asac | the green part is what was added | 01:12 |
asac | so naturally its the same | 01:12 |
gnomefreak | the libs:: lines are the same but the makefile is missing the section above | 01:12 |
asac | but the green part has a fault | 01:12 |
asac | just fix the install:: line | 01:12 |
asac | but look closer if you want to understand | 01:12 |
asac | take your time | 01:12 |
asac | gnomefreak: maybe you got this wrong ... the patch you see in bonsai is the patch that broke this thing | 01:13 |
gnomefreak | it looks like the makefile.in has different indentions but that shouldnt matter | 01:13 |
asac | (its not the cure) | 01:13 |
gnomefreak | oh | 01:13 |
asac | we are developing the cure right now | 01:13 |
asac | and will submit upstream | 01:13 |
gnomefreak | ah ok | 01:13 |
gnomefreak | what should i be comparing it to? | 01:13 |
asac | you should not compare against anything | 01:14 |
asac | you have to fix the install:: line | 01:14 |
asac | and then produce a patch by quilt refresh | 01:14 |
gnomefreak | ah ok | 01:14 |
asac | but you can take alook | 01:14 |
asac | and show me your changes | 01:14 |
asac | before refresh | 01:14 |
asac | with quilt diff | 01:14 |
asac | just run quilt diff after you fixed the makefile | 01:14 |
asac | and show :) | 01:14 |
asac | so i can confirm that you did right ;) | 01:14 |
asac | though the change is pretty trivial | 01:15 |
gnomefreak | it is? | 01:17 |
gnomefreak | im lookingt at error i got from build atm | 01:17 |
asac | its just a one line change | 01:17 |
asac | gnomefreak: you see that the nsinstall run is missing an argument | 01:17 |
asac | if you look to makefile you see that $^ is empty | 01:17 |
asac | do you see that | 01:17 |
asac | ? | 01:17 |
asac | install:: | 01:17 |
asac | $(INSTALL) $(IFLAGS1) $^ $(DESTDIR)$(mozappdir) | 01:17 |
asac | $^ will be replaced with whatever is after instal:: | 01:17 |
gnomefreak | i have that in makefile | 01:17 |
asac | and since there is nothing ... this will be replaced by empty | 01:17 |
asac | so the error you see during build will happen | 01:17 |
asac | (e.g. wrong arguments to nsinstall) | 01:17 |
gnomefreak | k | 01:17 |
asac | you understand? | 01:17 |
asac | just assume: | 01:17 |
asac | there would be | 01:17 |
asac | install:: | 01:17 |
gnomefreak | ^ == nothing | 01:17 |
asac | cp $^ /tmp/ | 01:17 |
asac | when make is run | 01:17 |
asac | it will be just cp /tmp | 01:17 |
asac | so it would fail | 01:18 |
gnomefreak | k | 01:18 |
asac | same goes for $(INSTALL) .... | 01:18 |
asac | so fix the install:: line will cure you | 01:18 |
asac | like it is for libs:: | 01:18 |
asac | a few lined above | 01:18 |
gnomefreak | $^ $(DIST)/bin | 01:18 |
asac | no | 01:19 |
asac | just fix the install:: line | 01:19 |
gnomefreak | is the line for libs:: | 01:19 |
asac | no | 01:19 |
asac | the line for libs:: | 01:19 |
asac | is | 01:19 |
gnomefreak | i no im not changing that line | 01:19 |
asac | 01:19 | |
asac | libs:: platform.ini | 01:19 |
asac | while install:: is just | 01:19 |
asac | install:: | 01:19 |
gnomefreak | ah | 01:19 |
asac | you look at the line below libs:: :) | 01:19 |
gnomefreak | yes | 01:19 |
asac | so fix the install:: line ;) | 01:20 |
gnomefreak | install:: should have something after it | 01:20 |
asac | yeah | 01:20 |
asac | the same | 01:20 |
asac | install should install platforms.ini | 01:20 |
gnomefreak | oh | 01:20 |
gnomefreak | i couldnt find that in error from build :( | 01:21 |
asac | yeah ... just look again ... $^ is empty ... which causes a command line error in build | 01:21 |
asac | so of course you cannot see it ;) | 01:21 |
asac | anyway ... now fix it :) | 01:21 |
asac | and show me quilt diff :) | 01:21 |
asac | libs:: platform.ini | 01:22 |
asac | install:: platform.ini | 01:22 |
gnomefreak | http://pastebin.mozilla.org/114512 | 01:22 |
asac | good | 01:22 |
asac | now the standard refresh we use: | 01:22 |
asac | quilt refresh --diffstat -U8 | 01:22 |
gnomefreak | it was refreshed | 01:23 |
asac | yeah then you are done ... add the new patch to bzr and commit series and the new patch | 01:23 |
asac | e.g. bzr add debian/patches/howver_the_new_patch_is_called | 01:23 |
asac | bzr commit debian/patches/series debian/patches/howver_the_new_patch_is_called | 01:23 |
gnomefreak | ok so i can get out of buil-tree now | 01:24 |
asac | yeah | 01:24 |
gnomefreak | k | 01:24 |
asac | bzr status should show you one unknown file (the new patch) | 01:24 |
asac | and modified series | 01:24 |
asac | can you confirm that? | 01:24 |
asac | if so you need to add the unknown file and commit | 01:24 |
asac | use bzr add debian/patches/however_new_patch_is_called to add | 01:25 |
asac | before commit | 01:25 |
gnomefreak | ok its added | 01:26 |
gnomefreak | now just commit | 01:26 |
asac | yeah | 01:26 |
asac | afterwards you should not see it as unknown file with bzr status anymore, right? | 01:27 |
gnomefreak | give me a minute :) | 01:28 |
asac | sure | 01:28 |
gnomefreak | it shows a bunch of unknown files | 01:31 |
gnomefreak | but not that patch | 01:31 |
asac | so you committed the patch? | 01:34 |
asac | what revision is latest? | 01:34 |
asac | bzr log | more | 01:34 |
gnomefreak | 24 | 01:34 |
asac | ok show me a bzr diff -r 23..24 | 01:34 |
gnomefreak | 23 is commited and 24 is commited | 01:35 |
gnomefreak | http://pastebin.mozilla.org/114513 | 01:35 |
gnomefreak | brb more coffee | 01:35 |
asac | looks good | 01:36 |
asac | please try to build now | 01:36 |
gnomefreak | im thinking of pulling them both and commiting the whole patches dir. since i removed those 2 patches | 01:41 |
gnomefreak | and ill do it all as one commit with rules and changelog (rules i have to check on first | 01:41 |
asac | he? | 01:44 |
asac | please rephrase | 01:44 |
asac | i don't understand what you want to do | 01:45 |
asac | please test if build works now first | 01:45 |
asac | and bring up the patch somewhere so i can submit upstream ;) | 01:45 |
gnomefreak | i changed rules to not use png so needs to be commited changelog as well and patches dir. since i added 1 patch modified series and antoher patch | 01:46 |
gnomefreak | patch you can wget http://gnomefreak.youmortals.com/ftbfs_toolkit_xre_Makefile_in | 01:47 |
asac | gnomefreak: please do a distinct commmit | 01:48 |
asac | for the series and ftbfs | 01:48 |
asac | otherwise merging that to granparadiso branch becomes a crux | 01:48 |
gnomefreak | so dont do them all together | 01:48 |
gnomefreak | oh ok | 01:48 |
asac | always commit changelog in its own commit | 01:48 |
asac | at the end | 01:48 |
asac | because that will always cause conflicts | 01:48 |
asac | if you merge it somewhere | 01:48 |
asac | no ... commit per issue | 01:48 |
asac | commit for the ftbfs | 01:48 |
asac | then commit if you want to do cleanup (like removing patches) | 01:49 |
asac | then commit changelog documenting all this | 01:49 |
asac | gnomefreak: please verify first that the build succeeds now | 01:49 |
asac | i want to be sure before submitting (though its a safe bet) | 01:49 |
gnomefreak | k | 01:50 |
gnomefreak | why is trunk depending on quilt and cdbs arnt they both for patching? | 01:54 |
asac | no | 01:57 |
asac | cdbs is build system | 01:57 |
asac | quilt is a patchsystem | 01:57 |
asac | cdbs allows you to use multiple patch systems | 01:57 |
asac | e.g. quilt, dpatch, simple-patchsys | 01:58 |
gnomefreak | ah ok | 01:58 |
asac | we use quilt as its most sophisticated and we can use it without cdbs-edit-patch (e.g. which does the same stupid thing as dpatch-edit-patch) | 01:58 |
gnomefreak | ah | 01:59 |
gnomefreak | when you get time (its not important) take a look at https://launchpad.net/~mozillateam and let me know if i am missing packages in the list | 02:00 |
asac | firefox-granparadiso | 02:02 |
asac | don't know what install-flash-player is | 02:02 |
asac | maybe drop it from that list | 02:02 |
asac | unless you know that its still valid | 02:02 |
gnomefreak | ok ill look into it | 02:08 |
gnomefreak | feisty was last time it was uploaded | 02:09 |
gnomefreak | its not in feisty hmmmm | 02:10 |
gnomefreak | only flash packages now is gnash and flashplugin-nonfree as none of the others showed up in feisty or gutsy | 02:14 |
gnomefreak | asac: for granparadiso did you forget to add name and email time and date to changelog? | 02:19 |
gnomefreak | https://launchpad.net/ubuntu/gutsy/+source/firefox-granparadiso/+changelog | 02:19 |
asac | no its just how its displayed in launchpad | 02:23 |
asac | i explicitily included both changelog entries in changes | 02:23 |
gnomefreak | ah ok | 02:24 |
gnomefreak | now our homepage should be up to date | 02:24 |
=== DarkSun88 [n=Ma@ubuntu/member/darksun88] has joined #ubuntu-mozillateam | ||
DarkSun88 | Hi all | 02:32 |
DarkSun88 | I'm off now. | 02:32 |
DarkSun88 | Sya | 02:32 |
=== gnomefreak gonna take a break since it is a holiday ;) but it shouldnt be too long as holiday or not i want trunk done | ||
asac | DarkSun88: hey ... cya | 02:51 |
=== jeromeg [n=jerome@gra94-2-82-66-142-60.fbx.proxad.net] has joined #ubuntu-mozillateam | ||
asac | DarkSun88: pushed | 03:09 |
DarkSun88 | asac: Thanks for upload. | 03:13 |
DarkSun88 | :) | 03:13 |
DarkSun88 | Change I the status of bug as "Fix Committed"? | 03:14 |
asac | DarkSun88: sorry no idea :) ... i am not the man to ask about exact motu procedures | 03:24 |
DarkSun88 | :D | 03:24 |
DarkSun88 | Ok, sorry. | 03:24 |
DarkSun88 | :) | 03:24 |
asac | my bet would be that its released as soon as builds have finished ... but no idea | 03:24 |
asac | maybe ask on -motu and let me know :) | 03:25 |
DarkSun88 | Usually, the MOTU changes the status of bug as Fix Committed after to have uploaded the package. | 03:28 |
DarkSun88 | So, change the status. :) | 03:28 |
asac | so i shall change it? | 03:28 |
asac | ah | 03:28 |
asac | so the sponsor changes it? | 03:28 |
asac | ok | 03:28 |
DarkSun88 | Yes. | 03:28 |
asac | done | 03:29 |
DarkSun88 | Thanks :) | 03:29 |
DarkSun88 | Are you the sponsor of bluekuja, right? | 03:29 |
asac | yes his mentor | 03:30 |
asac | actually i don't like sponsoring ;) | 03:30 |
asac | unless its mozilla related of course | 03:30 |
DarkSun88 | :) | 03:31 |
DarkSun88 | I've read the Andrea's MOTU Application in this days. | 03:31 |
DarkSun88 | s/read/readed | 03:31 |
asac | read is right i guess :) | 03:32 |
asac | read read read :) | 03:32 |
asac | read red red | 03:32 |
asac | (pronounced) | 03:32 |
asac | though i might be wrong | 03:32 |
=== DarkMageZ [n=richard@238.101.233.220.exetel.com.au] has joined #ubuntu-mozillateam | ||
jeromeg | no it's ok :) | 03:34 |
DarkSun88 | :) | 03:34 |
=== DarkMageZ [n=richard@238.101.233.220.exetel.com.au] has joined #ubuntu-mozillateam | ||
=== jeromeg [n=jerome@gra94-2-82-66-142-60.fbx.proxad.net] has joined #ubuntu-mozillateam | ||
asac | gnomefreak: did build go well | 04:16 |
=== bluekuja [n=andrea@ubuntu/member/bluekuja] has joined #ubuntu-mozillateam | ||
=== shirish [n=shirish@59.95.6.121] has joined #ubuntu-mozillateam | ||
shirish | asac: what is that ubufox , can you tell me something about it? | 05:29 |
asac | its a package where ubuntu specific tweaks will go | 05:30 |
asac | e.g. for now it ships all preference changes we have | 05:30 |
asac | later report a bug menu entry et al will go there | 05:30 |
asac | the efford is to bring our firefox closer to upstream | 05:31 |
asac | so we only carry patches that are prefetched bugfixes from bugzilla | 05:31 |
asac | package ... aka an extension | 05:31 |
asac | shirish: ^^ | 05:31 |
shirish | asac: ok but this is just good for firefox or also for firefox-granparadiso? | 05:31 |
asac | currently only for firefox | 05:32 |
asac | maybe i will develop ubufox for firefox 3 ... which could be installed in-granparadiso then | 05:32 |
asac | but not yet in pipeline | 05:32 |
shirish | asac: one thing though, the description is kinda off for this, maybe you could set it right | 05:33 |
shirish | Description: modifications for ubuntu firefox (default) install | 05:33 |
shirish | Extension package for firefox, that ships various modifications for the ubuntu default install of firefox. | 05:33 |
shirish | 05:33 | |
shirish | You can uninstall this package if you prefer to use a genuine firefox install. | 05:33 |
shirish | asac: see you buddy, will be bbl | 05:34 |
=== shirish [n=shirish@59.95.6.121] has left #ubuntu-mozillateam [] | ||
asac | DarkSun88: thanks | 05:37 |
DarkSun88 | asac: ;) | 05:38 |
DarkSun88 | asac: Your version is *ubuntu2, right? | 05:39 |
asac | for xulrunner? | 05:43 |
asac | probably | 05:43 |
asac | yes | 05:43 |
asac | did it fail or what? | 05:43 |
DarkSun88 | asac: Ok. | 05:43 |
DarkSun88 | No no. | 05:44 |
DarkSun88 | asac: Currently building again | 05:45 |
asac | good ... ;) | 05:46 |
asac | for a secod i felt this pain ... you know ;) | 05:46 |
DarkSun88 | :D | 05:46 |
DarkSun88 | asac: On i386 it's ok. | 05:58 |
DarkSun88 | Waiting for others arch. | 05:59 |
=== hjmf [n=hjmf@150.Red-83-44-175.dynamicIP.rima-tde.net] has joined #ubuntu-mozillateam | ||
hjmf | asac: howdy, just stepping in! | 05:59 |
hjmf | bug 124016 | 05:59 |
ubotu | Launchpad bug 124016 in sun-java5 "added Xb-Npp-xxx tags accordingly to "firefox distro add-on suport" spec" [Undecided,New] https://launchpad.net/bugs/124016 | 05:59 |
hjmf | probably tonight when I'll be back I'll do sun-java6-plugin | 05:59 |
hjmf | if not then tomorrow morning | 05:59 |
=== hjmf will be back at night (hopes) | ||
asac | hjmf_: great ... thanks | 06:04 |
asac | probably upload tonight ... everything else went in already | 06:04 |
asac | DarkSun88: two architectures failed? | 06:31 |
DarkSun88 | asac: No, three successfully built. :) | 06:31 |
asac | ah ;) | 06:31 |
asac | gnomefreak: build succeeded? | 06:34 |
DarkSun88 | asac: Last architecture. | 06:41 |
DarkSun88 | (i64) | 06:42 |
DarkSun88 | ia* | 06:42 |
=== JenFraggle [n=jen@host86-134-24-44.range86-134.btcentralplus.com] has joined #ubuntu-mozillateam | ||
asac | gone for a few hours | 07:05 |
gnomefreak | asac: yep it did | 07:41 |
gnomefreak | asac: are you updating granparadiso or did they not release a tarball for it | 08:08 |
=== hjmf [n=hjmf@150.Red-83-44-175.dynamicIP.rima-tde.net] has joined #ubuntu-mozillateam | ||
=== hjmf [n=hjmf@150.Red-83-44-175.dynamicIP.rima-tde.net] has joined #ubuntu-mozillateam | ||
hjmf | asac: sun-java6-plugin: bug 124059 | 09:05 |
ubotu | Launchpad bug 124059 in sun-java6 "added Xb-Npp-xxx tags accordingly to "firefox distro add-on suport" spec" [Undecided,New] https://launchpad.net/bugs/124059 | 09:05 |
=== shirish [n=shirish@59.95.10.162] has joined #ubuntu-mozillateam | ||
shirish | guys anybody here has firefox-granparadiso? | 09:13 |
gnomefreak | shirish: what ubuntu and what is the question | 09:15 |
shirish | gnomefreak: I'm on FF3 alpha 5 & there is no option to save page as a pdf | 09:16 |
shirish | gnomefreak: wired tells me that this was introduced in FF3 alpha 3 | 09:16 |
shirish | http://blog.wired.com/monkeybites/2007/04/firefox_3_alpha.html | 09:16 |
gnomefreak | do you have a link for pdf | 09:16 |
shirish | gnomefreak: look up :) | 09:16 |
gnomefreak | shirish: wired isnt working on it and you didnt give me link to the pdf | 09:17 |
shirish | gnomefreak: right, wired isn't working on it, would investigate & report further. They reported it hence thought its there. | 09:17 |
gnomefreak | shirish: your missing point. not everything happens when it is first said to happen. can i have a link to the pdf please | 09:18 |
shirish | gnomefreak: I think I must have jumped the gun, there is no link to the pdf atm, I'm trying to find out | 09:19 |
=== gnomefreak goes back to work | ||
=== shirish goes back to investigating & finding more about FF3 | ||
gnomefreak | shirish: http://www.mozilla.org/projects/firefox/3.0a3/releasenotes/ doesnt say anything about it | 09:23 |
shirish | that's what I got, dunno from where the wired guys got that added. | 09:24 |
gnomefreak | neither does a1 or a2 | 09:24 |
gnomefreak | if you dont hear it from a source that would know be very carefull what you believe, im not saying its not there but its a good chance that it was postponed | 09:25 |
shirish | gnomefreak: got it, although it would be cool to have that | 09:27 |
gnomefreak | yeah and its proibly in the windows or mac versions | 09:30 |
shirish | gnomefreak: will check out l8ter & let u know if its there, as they have moved on alpha 7 | 09:32 |
shirish | gnomefreak: another thing, .xpi are not associated with either firefox or firefox-granparadiso, shouldn't they be or are there other apps. (besides archives which can use .xpi) | 09:38 |
shirish | besides archive managers like Xarchiver & like | 09:39 |
gnomefreak | .xpi are different source | 09:39 |
gnomefreak | they are not built with firefox (except for lang packs | 09:40 |
shirish | right, what I was thinking is its just an extension, just like .odt for openoffice.org, so shouldn't they be associated with each other, or is this something that should be done upstream? | 09:43 |
gnomefreak | is firefox the only ones that use .xpi? | 09:44 |
gnomefreak | .odt == open office doc .exe == windows archive(for most part) | 09:45 |
gnomefreak | shirish: btw afaik both of these are wrong: # Boomarks are now called Places, new menu structure | 09:47 |
gnomefreak | # Save web pages as PDF | 09:47 |
gnomefreak | atleast on linux | 09:47 |
shirish | gnomefreak: wikipedia talks of all mozilla browsers, but 4 other apps. which I don't think have nothing to do with browsers, seems to be similar to the .exe you were stating. | 09:48 |
shirish | gnomefreak: you are right, bookmarks is known as places & they got that one wrong also, save pages on pdf (isn't even in the alpha 6 release notes also). | 09:49 |
gnomefreak | and if you look at link they gave you to release notes none of those are stated | 09:49 |
gnomefreak | and they are behind | 09:49 |
gnomefreak | im uploading alpha 6 atm they are still on 4 | 09:50 |
gnomefreak | :) | 09:50 |
shirish | wow, you are doing this on ubuntu straight alpha 6 or on debian also | 09:50 |
gnomefreak | just feisty atm | 09:51 |
shirish | I am sure you noticed the wishlist bug I had put yesterday about alpha 6 | 09:51 |
gnomefreak | debian can get thier own | 09:51 |
shirish | ah ok, feisty, on gutsy :( | 09:51 |
gnomefreak | shirish: nope | 09:51 |
gnomefreak | maybe | 09:51 |
shirish | :) | 09:51 |
gnomefreak | i saw alot of bugs yesterday | 09:51 |
shirish | I'm sure | 09:51 |
gnomefreak | 40+ bugs yesterday iirc | 09:52 |
shirish | wow, that's a big big triage | 09:53 |
gnomefreak | no not really | 09:53 |
gnomefreak | hjm^f does alot more | 09:53 |
gnomefreak | alot maybe like 100+ a day | 09:53 |
gnomefreak | when he does them | 09:54 |
shirish | wow, that's quite a lot of bugs | 09:54 |
gnomefreak | when firefox has 500+ bugs you have to | 09:54 |
gnomefreak | asac: i finally got my first bug on iceape (that i didnt file) and its a damn crash if i had to guess without seeing the debugging info its cario | 09:55 |
gnomefreak | i guess i can replace old tarball with new one | 10:02 |
shirish | gnomefreak: enjoy yourself, will be looking forward to alpha 6 whenever its ready to hit gutsy :) | 10:08 |
shirish | cheers | 10:08 |
=== shirish [n=shirish@59.95.10.162] has left #ubuntu-mozillateam [] | ||
gnomefreak | when is sprint week? | 10:23 |
gnomefreak | alphs6 in feisty preview archives | 10:26 |
asac | gnomefreak: does trunk build? | 10:38 |
asac | gnomefreak: does it crash for you? | 10:38 |
asac | or display wierd stuff on shutdown on console? | 10:39 |
gnomefreak | so far it built i havent gotten crash in feisty yet | 10:39 |
gnomefreak | give me a few minutes to finish email and ill run through a series of tests | 10:39 |
asac | hjmf: i dropped a comment on your java5 debdiff | 10:39 |
gnomefreak | wtf is wrong with people | 10:40 |
asac | hjmf: in your java6 diff it locks good though | 10:40 |
hjmf | asac: ok looking | 10:40 |
asac | ok i am out ... have to arrive really before i can seriously do anything | 10:40 |
asac | 30 minutes i guess | 10:40 |
gnomefreak | asac: someone replied to your answer on the ML | 10:40 |
gnomefreak | we dont work fast enough is how i read it | 10:41 |
hjmf | asac: bug 123687 is the same problem than bug 117575 | 10:41 |
ubotu | Launchpad bug 123687 in firefox-granparadiso "/usr/lib/firefox-granparadiso/firefox doesnt run" [Undecided,New] https://launchpad.net/bugs/123687 | 10:41 |
ubotu | Launchpad bug 117575 in firefox "[GUTSY] Cannot execute /usr/lib/firefox/x-www-browser-bin." [High,Fix released] https://launchpad.net/bugs/117575 | 10:41 |
gnomefreak | why is bug #1 in our bugs :( | 10:42 |
ubotu | Launchpad bug 1 in Ubuntu "Microsoft has a majority market share" [Critical,In progress] https://launchpad.net/bugs/1 | 10:42 |
gnomefreak | son of a bitch | 10:43 |
hjmf | yeah gnomefreak :) | 10:43 |
gnomefreak | asac: this isnt good! and i think it might have been granparadiso in gutsy i tested :( | 10:43 |
gnomefreak | (Feisty)gnomefreak@GutsyGibbon:~$ firefox-trunk | 10:43 |
gnomefreak | Couldn't read application.ini | 10:43 |
gnomefreak | the patch seems to not have worked | 10:43 |
=== asac_ [n=asac@debian/developer/asac] has joined #ubuntu-mozillateam | ||
gnomefreak | no patch maybe ok since i didnt add applications.ini to it | 10:51 |
hjmf | asac: gnomefreak, I'm not sure if it is the same problem, I think I'm too tired to be productive at this hour, I'll look at it tomorrow evening | 10:58 |
hjmf | cu | 10:58 |
gnomefreak | anyway in my chroot it doesnt launch crash or anything else except couldnt read applications.ini | 10:59 |
gnomefreak | asac: did you try granparadiso yet? | 11:00 |
asac_ | sorry had a call | 11:00 |
gnomefreak | its k | 11:00 |
asac_ | ok | 11:00 |
asac_ | whats the problem? | 11:01 |
asac_ | but let me get something to eat first | 11:01 |
gnomefreak | ok ill be in a nd out | 11:01 |
asac_ | i built granparadiso a6 ... | 11:01 |
asac_ | however its somehow instable | 11:01 |
gnomefreak | and? | 11:01 |
asac_ | which i refer to cairo | 11:01 |
asac_ | when i shutdown i get crash | 11:01 |
asac_ | 100% reproducible | 11:01 |
asac_ | its an assertion crash | 11:02 |
gnomefreak | cant be any worse than getting Couldn't read application.ini on start up | 11:02 |
asac_ | do you see it in console on trunk? | 11:02 |
asac_ | hmm application.ini | 11:02 |
asac | gnomefreak do you steill have built directory? | 11:02 |
gnomefreak | i get that error and it brings me back to prompt | 11:02 |
gnomefreak | yes | 11:02 |
asac | its probably just not installed | 11:02 |
asac | go to debian/firefox& | 11:02 |
asac | debian/firefox/ | 11:02 |
asac | directory | 11:02 |
asac | inside it try to find that file | 11:02 |
asac | is it there? | 11:03 |
asac | somewhere beneath | 11:03 |
asac | do a deep search | 11:03 |
asac | in console like find | grep application.*ini | 11:03 |
gnomefreak | debian/firefox-trunk? | 11:03 |
asac | yeah | 11:03 |
asac | sorry forgot that you are using trunk ;) | 11:03 |
gnomefreak | no | 11:04 |
gnomefreak | find | grep application.*ini just gives me prompt | 11:04 |
asac | hm | 11:05 |
asac | ko | 11:05 |
asac | and if you do that find in build-tree ? | 11:05 |
asac | might give you garbage | 11:05 |
asac | please just look careful if there is any application.ini in between | 11:05 |
gnomefreak | they seem to be in build-tree/mozilla | 11:07 |
gnomefreak | there are 4 or so | 11:07 |
gnomefreak | ./browser/app/application.ini seems likely to be the one? | 11:07 |
asac | probably | 11:07 |
asac | whatothers? | 11:07 |
asac | do exist? | 11:07 |
gnomefreak | ./extensions/python/dom/test/pyxultest/application.ini | 11:08 |
gnomefreak | ./extensions/layout-debug/application.ini | 11:08 |
gnomefreak | ./dist/bin/application.ini | 11:08 |
gnomefreak | ./browser/app/application.ini | 11:08 |
asac | yeah | 11:08 |
asac | stupid mob | 11:08 |
asac | you see ... its exactly like with our build failure | 11:08 |
asac | they give a damn shit about standard way of doing linux build | 11:08 |
asac | they just forget to add that file to install:: target | 11:08 |
asac | as they just don't remember that there is somebody out there who runs make install | 11:09 |
asac | ok | 11:09 |
asac | lets look | 11:09 |
asac | it should be missing in browser/app/Makefile.in | 11:09 |
gnomefreak | they are all there | 11:09 |
asac | he? | 11:09 |
gnomefreak | all the application.ini are there | 11:09 |
asac | yes ... but not installed, right? | 11:09 |
gnomefreak | how would i find out if installed? | 11:10 |
gnomefreak | they werent in debian/ | 11:10 |
asac | yeah then they are not installed | 11:11 |
asac | it looks complicated | 11:11 |
asac | e.g. they just have in that makefile | 11:11 |
asac | DIST_FILES = application.ini | 11:11 |
asac | which means they have some generic make rule coded for that variable | 11:11 |
asac | probably in config/rules.mk | 11:12 |
asac | (which is where most of their generic make system code lies) | 11:12 |
gnomefreak | i dont see a config/rules.mk | 11:13 |
asac | yeah they just coded it and ignored install target | 11:13 |
asac | its in mozilla/config/rules.mk | 11:13 |
asac | http://lxr.mozilla.org/mozilla/source/config/rules.mk | 11:13 |
asac | thats the file | 11:13 |
asac | search for dist_files | 11:14 |
asac | and you see that they just have a libs:: target for it | 11:14 |
asac | nothing about install:: | 11:14 |
asac | gnomefreak: do you have orig.tarball somwhere? | 11:14 |
asac | of what you try to build? | 11:14 |
asac | and pushed your changes to mt branch or so? | 11:14 |
gnomefreak | yes the one made with build | 11:14 |
gnomefreak | asac: already done | 11:15 |
asac | good ... where can i get the orig? | 11:15 |
asac | is it on your server? | 11:15 |
gnomefreak | yep | 11:15 |
asac | i have to do a patch for that ... again | 11:15 |
gnomefreak | give me a sec ill get link | 11:15 |
asac | do you have url at hand? | 11:15 |
asac | cool | 11:15 |
gnomefreak | http://gnomefreak.youmortals.com/mozilla-testing/dists/feisty/main/source/firefox-trunk_2.99+2cvs20070703.orig.tar.gz | 11:16 |
asac | gratias | 11:16 |
asac | and bzr branch url? | 11:17 |
gnomefreak | getting | 11:17 |
asac | sftp of mozilla branch or something | 11:17 |
asac | though i should be able to figure out | 11:17 |
asac | how is the branch called? | 11:17 |
asac | trunk? | 11:17 |
gnomefreak | do you want sftp or http | 11:17 |
asac | just tell me the name | 11:17 |
asac | the rest i can see on my own | 11:17 |
gnomefreak | trunk i think | 11:18 |
gnomefreak | im frozen | 11:18 |
gnomefreak | cant do anything but type here | 11:18 |
gnomefreak | brb | 11:18 |
=== gnomefreak [n=gnomefre@ubuntu/member/gnomefreak] has joined #ubuntu-mozillateam | ||
asac | there you are :) | 11:28 |
gnomefreak | brb strange dog | 11:29 |
gnomefreak | n-m is borked | 11:29 |
asac | nm is my realm :( | 11:30 |
asac | i don't feel good about it | 11:30 |
asac | tomorrow i have to wlan router + usb dongle ... and pray that this works | 11:31 |
asac | in my lunchtime :( | 11:31 |
asac | and i need a power adapter for uk | 11:31 |
asac | gnomefreak: did you push to mt branch? | 11:33 |
gnomefreak | its not connecting i have to disconnect and reconnect it :( ok whats up with firefox-trunk | 11:33 |
gnomefreak | yes | 11:33 |
gnomefreak | i hope so | 11:33 |
gnomefreak | bzr push sftp://gnomefreak@bazaar.launchpad.net/~mozillateam/firefox/trunk | 11:33 |
gnomefreak | yep i did | 11:34 |
gnomefreak | looked with arrow ;) | 11:34 |
asac | ok | 11:34 |
asac | i got it | 11:34 |
asac | lets see | 11:34 |
gnomefreak | k | 11:34 |
asac | this might take some time ;) | 11:34 |
gnomefreak | take your time | 11:35 |
gnomefreak | when did you adopt n-m? | 11:35 |
asac | as was voluntold | 11:35 |
asac | i was | 11:36 |
gnomefreak | lol | 11:36 |
gnomefreak | sorry to hear that | 11:36 |
asac | actually if i don't have enough time i can push it away | 11:36 |
asac | but i like the challange | 11:36 |
=== gnomefreak wants to know how your gonna fix this issue with it | ||
asac | actually i am more a high level programmer and always hated things that have remotely todo with hardware | 11:36 |
asac | me too :-D | 11:36 |
=== gnomefreak here if needed | ||
asac | quilt new config_rules_install_dist_files | 11:38 |
asac | Patch config_rules_install_dist_files is now on top | 11:38 |
asac | quilt add config/rules.mk | 11:38 |
asac | File config/rules.mk added to patch config_rules_install_dist_files | 11:38 |
asac | ok ... now lets fix rules.mk ;) | 11:38 |
gnomefreak | 2 patches? | 11:38 |
gnomefreak | oh and next time you might want to type that in terminal | 11:38 |
gnomefreak | hmmmmm | 11:39 |
gnomefreak | places menu changed i think | 11:39 |
gnomefreak | starting to look alot like windows :( | 11:39 |
asac | in fox? | 11:40 |
gnomefreak | no in gnome menu | 11:40 |
asac | what is windowish now? | 11:41 |
gnomefreak | places>Documents and places>bookmarks | 11:41 |
gnomefreak | asac: problem | 11:46 |
gnomefreak | i saw this in -devel and i didnt even know we had a middle click patch | 11:46 |
gnomefreak | asac: bug 124084 | 11:47 |
ubotu | Launchpad bug 124084 in firefox "patch dropped: disable middle-click paste" [Undecided,New] https://launchpad.net/bugs/124084 | 11:47 |
asac | ok lets see whats worth this patch | 11:49 |
gnomefreak | im looking into lost patch maybe we took it out for a reason | 11:50 |
asac | gnomefreak: rejected | 11:53 |
asac | its now in ubufox | 11:53 |
asac | as almost every preference tweak | 11:53 |
asac | i commented accordingly | 11:53 |
gnomefreak | asac: i dont think hes gonna like that | 11:53 |
asac | doesn't matter | 11:53 |
asac | its just the smarter way | 11:54 |
gnomefreak | i agree | 11:54 |
gnomefreak | grabbing firefox now so i can merge to mozillateam branch | 11:54 |
asac | k | 11:55 |
asac | gnomefreak: if he complains ... let me know | 11:55 |
asac | i have a huge bugmail backlog atm | 11:55 |
gnomefreak | k | 11:55 |
asac | because i worked too much on other things | 11:55 |
asac | time is getting short of getting all my specs implemented | 11:55 |
asac | and the mobile browser eats time too | 11:56 |
asac | i want almost all of my specs be done by end of july | 11:56 |
asac | so i can concetrate on stabilizing and bug fixing till gutsy is out | 11:57 |
asac | gnomefreak: if there is something serious popping up ... like firefox doesn't run for a bunch of users anymore, please raise | 11:57 |
asac | otherwise it might go unseen for too long | 11:58 |
asac | same for thunderbird ... my picture of thunderbird state is atm a bit too blurry imo | 11:58 |
asac | gnomefreak: http://people.ubuntu.com/~asac/config_rules_install_dist_files | 11:59 |
asac | thats the path | 11:59 |
asac | its not verified if it fixes it | 11:59 |
asac | but i think so | 11:59 |
asac | build still going | 11:59 |
asac | if you want to prefetch it go ahead | 11:59 |
asac | and tell me if you want to push this to mt branch or if i should push it | 12:00 |
asac | just add to series at the end | 12:00 |
asac | gnomefreak: now its good ... i uploaded a bogus version | 12:01 |
asac | first | 12:01 |
asac | you can pull if you want or wait till i confirmed that it works | 12:02 |
asac | pull == prefetch the patch from my p.u.c account | 12:02 |
gnomefreak | ok | 12:08 |
gnomefreak | ill grab it throw it in and wait | 12:08 |
gnomefreak | once you confirm ill build and make sure it works on feisty build (im assuming your doing gutsy) and ill push it | 12:10 |
gnomefreak | i can use the practice with bzr | 12:11 |
asac | sure | 12:14 |
asac | its your branch | 12:14 |
asac | gnomefreak: ok ... you have to add application.ini to firefox-trunk.install | 12:17 |
asac | same goes for platform.ini ? | 12:18 |
asac | otherwise the patch looks good | 12:18 |
asac | if you want i can do the firefox-trunk.install modification | 12:18 |
asac | but maybe just try | 12:18 |
gnomefreak | ok i have to add it | 12:18 |
asac | its /usr/lib/firefox/application.ini | 12:18 |
asac | and probably platform.ini in same directory | 12:18 |
asac | just verify after build if both files are installed in debian/firefox-trunk/usr/lib/firefox/ | 12:19 |
gnomefreak | i dont see application.ini in debian/firefox-trunk/usr/lib/firefox-trunk | 12:20 |
asac | gnomefreak: look in the patch | 12:21 |
asac | gnomefreak: it will not be there until you applied patch and build | 12:21 |
asac | the patch is to install it there ;) | 12:21 |
asac | actually it will end up in debian/tmp/usr/lib/firefox-trunk by make install | 12:22 |
asac | you have to add that file to firefox-trunk.install to get it installed in package target directory | 12:22 |
asac | -- which is debian/firefox-trunk/usr/lib/firefox-trunk | 12:22 |
asac | like i just said :) | 12:22 |
asac | gnomefreak: look in the patch ... there is a typo in it | 12:22 |
gnomefreak | in the config/rules.mk patch? | 12:23 |
asac | in documentation (in the top) DEST_FILES --> should be DIST_FILES | 12:23 |
asac | yes its just a documentation typo | 12:23 |
asac | look in | 12:23 |
asac | you will see | 12:23 |
gnomefreak | yes i see it | 12:23 |
gnomefreak | in the comments under --evaluation | 12:24 |
gnomefreak | ok so in debian/firefox-trunk.install i add application.ini and platform.ini right? | 12:26 |
gnomefreak | debian/firefox-trunk/usr/lib/firefox-trunk/application.ini | 12:27 |
gnomefreak | like that? | 12:27 |
asac | gnomefreak: ok ... please add another documentation line to the patch ... right on top: | 12:27 |
gnomefreak | k | 12:27 |
asac | This is from: | 12:27 |
asac | https://bugzilla.mozilla.org/show_bug.cgi?id=386904 | 12:27 |
ubotu | Mozilla bug 386904 in Build Config "DIST_FILES and DIST_CHROME_FILES not implemented for install:: target in config/rules.mk" [Normal,New] | 12:27 |
asac | https://bugzilla.mozilla.org/attachment.cgi?id=270967 | 12:28 |
asac | ^^ those three lines ... then add two new-lines before text begins | 12:28 |
asac | thanks | 12:28 |
gnomefreak | above --summary | 12:28 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!