[12:29] yeah [12:30] inster it in such a way that it looks nice [12:30] e.g. with a bit indentation [12:30] et al [12:30] gnomefreak: do the same for ftbfs_toolkit_xre_Makefile_in [12:30] same bugs? [12:31] i added the bug to the blocks field in bugzilla [12:31] take a look [12:31] (so you learn about bug dependencies in bugzilla) [12:31] document the bug url as well as the attachment url [12:33] should be on top of the -- [12:33] as there is no other documentation [12:33] maybe paste my initial bug comment as documentation in as well [12:33] and use summary as summary as well [12:33] https://bugzilla.mozilla.org/show_bug.cgi?id=386904 doesnt have anything about the ftbfs_toolkit [12:33] Mozilla bug 386904 in Build Config "DIST_FILES and DIST_CHROME_FILES not implemented for install:: target in config/rules.mk" [Normal,Assigned] [12:34] he? [12:34] it has a patch attached [12:34] its named differently [12:34] if you want rename our patch filename as well [12:35] you see the attachment? [12:35] document the url of that :) [12:35] what bug number are you looking at [12:35] the one you showed me [12:35] 10 lines above [12:35] gnomefreak: no [12:35] sorry [12:35] as i said [12:35] https://bugzilla.mozilla.org/show_bug.cgi?id=386904 [12:35] Mozilla bug 386904 in Build Config "DIST_FILES and DIST_CHROME_FILES not implemented for install:: target in config/rules.mk" [Normal,Assigned] [12:35] ^^^ that one [12:36] i set that bugs as blocks of our toolkit bug [12:36] look in the bug ... you will find [12:36] there is a link to the other bug in there :) [12:36] i could give you the bug id of toolkit ... however i think its good if you learn about the blocks/depends feature of bugzilla :) [12:36] just take a close look ... its in there ;) [12:37] ah i see it [12:37] yeah [12:37] and in the toolkit bug [12:37] this bug is Depends On [12:37] https://bugzilla.mozilla.org/show_bug.cgi?id=386866 [12:37] Mozilla bug 386866 in Build Config "toolkit/xre/Makefile.in install:: target broken on trunk" [Normal,Assigned] [12:37] yeah [12:37] so i add this bug URL to the part i added above the 2 patches? [12:38] do it like you did for the other patch [12:38] (however that was) [12:38] and put in a link to the patch as well (the attachment) [12:38] ok yeah i added those 3 lines already [12:38] into the toolkit patch [12:39] huh? [12:39] i think you added the wrong ones [12:39] the initial urls i posted where about bug 386904 [12:39] mozilla bug 386904 [12:39] Mozilla bug 386904 in Build Config "DIST_FILES and DIST_CHROME_FILES not implemented for install:: target in config/rules.mk" [Normal,Assigned] http://bugzilla.mozilla.org/show_bug.cgi?id=386904 [12:39] oh ok so im adding the bug above and https://bugzilla.mozilla.org/attachment.cgi?id=270920 only to the toolkit patch and the other ones to the new patch [12:39] yeah [12:40] and add the attchment of the *toolkit* patch to the toolkit patch as well [12:40] e.g. you see the line ;) ? [12:40] fixed [12:40] good [12:40] now you have to install the files [12:40] in firefox-trunk.install [12:40] if you already did that ... it might be worth a spin [12:40] i didnt [12:41] yeah. .. and add the new patch to series ... if not done [12:41] otherwise it will not be used [12:41] thats done [12:41] ok [12:41] then just firefox-trunk.install [12:41] then go [12:41] i have it open [12:41] look in history for the path that will be used [12:41] i already pasted how the files are called and in what dir they are [12:42] debian/firefox-trunk/usr/lib/firefox-trunk/application [12:42] .ini [12:42] you will see how you can insert them just see how simliar files are installed [12:42] and platform? [12:42] in same directory (most likely) [12:42] \brb phone [12:42] yes ack ... same directory [12:42] show me how you modified before you spin === red_herring [n=rj@c-24-14-245-251.hsd1.il.comcast.net] has joined #ubuntu-mozillateam [12:59] but you wanted debian/firefox-trunk/usr/lib/firefox-trunk/application [12:59] .ini [12:59] and debian/firefox-trunk/usr/lib/firefox-trunk/platform.ini [12:59] in the firefox-trunk install file [01:05] asac: http://pastebin.mozilla.org/114886 those are the changes to firefox-trunk.install and the 2 patches [01:13] gnomefreak: show me a diff [01:13] my eyes are tired ;) [01:13] but lets see [01:14] gnomefreak: look closer [01:14] try to compare what other lines in that file do [01:14] you miss something ;) [01:14] tmp? [01:14] for instance ... but there is more [01:14] th e-* [01:14] no [01:14] the firefox-* [01:14] or yes [01:15] that can be improved as well [01:15] but there is more [01:15] space [01:15] lol [01:15] he? [01:15] no [01:15] damn [01:15] you are talking about the install file right? [01:15] yeah [01:15] firefox-trunk.install [01:16] yes [01:16] for instance: [01:16] compare the line: [01:16] # [01:16] debian/tmp/usr/lib/firefox-*/chrome/icons/default/default.xpm usr/share/firefox-trunk/chrome/icons/default/ [01:16] # [01:16] (thats one line) [01:16] with [01:16] debian/firefox-trunk/usr/lib/firefox-trunk/application.ini [01:16] you see the difference? [01:16] except the ones you already outlined [01:16] (e.g. tmp + -* --- those are the ones you found) [01:17] the /usr/lib/firefox-trunk.... [01:17] hey [01:17] what does such a a line mean? [01:17] any idea? [01:17] e.g. [01:17] what does [01:17] debian/firefox-trunk.desktop usr/share/applications [01:17] do? [01:17] it should install application.ini [01:17] why the space? [01:18] yeah ... thats the question [01:18] just consider how you would copy something :) [01:18] well debian/firefox.install will install applications.ini somewhere [01:18] telling the computer: install application.ini will not bring you anywhere [01:18] to computer needs more information [01:18] in the /usr/lib dir [01:19] does everything go into the usr/lib dir? [01:19] no [01:19] so? [01:19] depends on what it is [01:19] no [01:19] it depends on what you tell [01:19] not what it is [01:19] you have to tell where to install [01:19] naturally [01:19] but i tell it where depnding on what it is [01:20] yeah ... but thats you .. not the computer ;) [01:20] right [01:21] so maybe it should look more like debian/tmp/firefox-trunk/application.ini /usr/lib/firefox-trunk/ [01:21] notice space after ini === tonyyarusso [n=anthony@ubuntu/member/tonyyarusso] has joined #ubuntu-mozillateam [01:23] what a minute [01:24] mozilla/toolkit/xre/ no this isnt right either [01:25] maybe /usr/bin since its a launching issue [01:37] < gnomefreak> so maybe it should look more like debian/tmp/firefox-trunk/application.ini /usr/lib/firefox-trunk/ [01:37] thats almost right [01:37] and would probably work [01:37] but just keep the style like the other lines [01:37] and drop the / from the beginning [01:37] of the target folder [01:37] gnomefreak: ^^ [01:38] k [01:39] same with the platform.ini i guess [01:40] thats it ill try spinning it now [01:40] and eat something [01:42] bbl ill let you know what happens === tonyyarusso [n=anthony@ubuntu/member/tonyyarusso] has joined #ubuntu-mozillateam [01:43] gnomefreak: great [01:44] i didnt need to re gen orig.tar? [01:44] gnomefreak: what was the sunbird issue? [01:44] maybe something similar? [01:44] gnomefreak: no [01:44] orig is the same [01:44] sunbird failed on xul? [01:44] i dont remember off hand [01:44] i cannot remember anymore [01:44] it was something strange [01:45] oh you got it to build dpkg-buildpacckage? [01:45] and bzr was failing? [01:45] no ... but running just make ... make install after it fails succeeds === gnomefreak couldnt build with dpkg-buildpackage either [01:45] which is completely strange [01:45] ah [01:46] ill be back in ~30 minutes if you still dont have it ill see if i can find it [01:46] so i cannot really fix it ... because its not reproducible in mozilla build system [01:46] cannot really see the issue [01:46] hard to figure out [01:46] there must be something obvious that i am missing [01:46] maybe ill run it in bzr again and give you errors in morning [01:46] don't need to [01:47] ah ok [01:47] unless you figure a way out to make it succeed [01:47] :) [01:47] don't think you will though ... but who knows :) [01:47] you never know i might get smart over night [01:47] ;) [01:47] ill be back [01:47] hehe ... i never said that === DarkMageZ [n=richard@238.101.233.220.exetel.com.au] has joined #ubuntu-mozillateam [02:16] asac: is it possible the rules file is doing something the makefile.in doesnt like? [02:16] ^^^ sunbird [02:17] only thing that comes to my mind is some setting [02:17] gnomefreak: the toolkit patch might be bad [02:17] already? [02:17] just made that [02:19] yeah ... there was a nother bug [02:19] which i oversaw [02:19] because i didn't assume that benjamin would do such a bad error [02:19] anyway [02:19] wait a sec [02:20] should i kill build? [02:20] i hand edited ... lets see if it applies [02:20] gnomefreak: yes [02:20] killed :) [02:20] currently platform.ini is installed as a symlink [02:20] it should be SYSINSTALL instead of INSTALL in install:: [02:20] wait a second [02:20] ah [02:21] http://people.ubuntu.com/~asac/ftbfs_toolkit_xre_Makefile_in [02:23] hmmm looks like you just replaced the last line [02:24] ok lets try it now [02:25] gnomefreak: i updated patch in bugzilla as well [02:25] https://bugzilla.mozilla.org/show_bug.cgi?id=386866 [02:25] Mozilla bug 386866 in Build Config "toolkit/xre/Makefile.in install:: target broken on trunk" [Normal,Assigned] [02:25] so change attachment url documented [02:25] k [02:25] gnomefreak: yeah ... you can try ... but don't forget to change documentation :) [02:25] in the end [02:25] in the end? [02:25] the line? [02:26] no before you publish bzr [02:26] and push sources to mt repo [02:26] sources in repo are not that important [02:26] more important is bzr [02:27] because i will merge your changes over to paradiso [02:27] for next milestone [02:27] most likely thats beta1 [02:28] k [02:38] ERROR: Path(s) are not versioned: debian/patches/config_rules_install_dist_files [02:38] what does not versioned mean? [02:42] that its not under revision control [02:43] you have to add files explicitily [02:43] under the revision control [02:43] otherwise you would always take risk to commit lots of garbage stuff like binaries and things generated during build [02:43] use bzr add to do that [02:43] gnomefreak: please do one checkin [02:43] for that patch [02:43] e.g. not together with other stuff [02:44] k [02:44] this should be distinct so it can be merged over easily [02:44] i can do the rest as 1 or everythiong separate? [02:45] don't know what the rest ist [02:45] never checkin changelog together with something else [02:45] checkin per feature you implement [02:45] keep changelog and patches separate [02:45] the changelog the tollkit patch revised the .install file [02:46] toolkit patch deserves single checkin [02:46] same for install [02:46] so everything gets its own checkin [02:46] and as last checkin changelog [02:55] pushed [02:57] ill let you know (more than likely in morning) if pass fail or what not [03:00] k [03:01] btw we are in bug 1 because somebody claimed that firefox can contribute to that bug [03:01] Launchpad bug 1 in Ubuntu "Microsoft has a majority market share" [Critical,In progress] https://launchpad.net/bugs/1 [03:01] :) [03:01] i think he claimed that bug 1 can never be solved because firefox is so broken compared to windows ;) [03:02] but might have been just my imagination [03:04] i only remember walther ;) who constantly raised the story that we ship trunk changes because he saw the same crash in ubuntu as on trunk ... but didn't see it in upstream tarball [03:04] luckily ignoring him helped [03:04] he stopped to drop these comments to random crash bugs at some point [03:08] Bug 120811 is getting strange [03:08] ubotu: ? [03:08] Launchpad bug 120811 in firefox "firefox displays fonts smaller than it should have" [Undecided,New] https://launchpad.net/bugs/120811 [03:19] Bug 122648 [03:19] Launchpad bug 122648 in firefox "majority of bookmarks have dissappeared" [Undecided,Incomplete] https://launchpad.net/bugs/122648 [03:19] makes me wonder how just a majority of bookmarks can disappear ... but not all? [03:20] maybe there are just a few missing [03:20] and he deleted them by accident? [03:35] ok out [03:35] cu tomorrow [05:53] asac: im not here just wanted to let you know it fails to build binaies (it cant stat ./debian/tmp/firefox-trunk/application.ini anyway ill figure it out tomorrow. let me know when i get here in morning how yours did, its either the -trunk.install file or the patch(s) good night === asac [n=asac@debian/developer/asac] has joined #ubuntu-mozillateam === hjmf_ [n=hjmf@150.Red-83-44-175.dynamicIP.rima-tde.net] has joined #ubuntu-mozillateam === Admiral_Chicago [n=FreddyM@adsl-68-72-80-116.dsl.chcgil.ameritech.net] has joined #ubuntu-mozillateam [10:20] asac: im running build again on trunk cause i cant remember the error (im not fully awake either [10:42] gnomefreak: that path is wrong [10:42] fix it [10:43] in the .install file? [10:43] yes of course [10:43] its obvious [10:43] why would applicatiohn.ini be at that place? [10:44] just look in history ... or search for application.ini to see where it is [10:44] i mean you definitly had it almost right [10:45] and now you use something completely different [10:46] look at this again [10:46] http://pastebin.mozilla.org/11488 [10:46] cant its empty [10:47] you pointed out two issues ... and finally found the third one ... but then you just came up with a path that is completely different [10:47] gnomefreak: the path you now use is wrong [10:47] i took /usr/lib out of the first path [10:47] yeah ... why? [10:47] hehe [10:47] fix it [10:47] 19:37 < asac > < gnomefreak> so maybe it should look more like debian/tmp/firefox-trunk/application.ini /usr/lib/firefox-trunk/ [10:47] 19:37 < asac > thats almost right [10:47] 19:37 < asac > and would probably work [10:48] hey [10:48] debian/tmp/usr/lib/firefox-trunk/application.ini usr/lib/firefox-trunk/ [10:48] that look better? [10:49] just think a bit :) ... and don't act as a bot ;) [10:49] yes [10:49] except that you can use -* [10:49] like everywhere else in that file [10:49] then its easier to reuse in paradiso for instance [10:49] there is quite a bit using firefox-trunk [10:50] yeah i saw that [10:50] anyway ... on the lefthand size [10:50] its a mess that its not the same way on right hand size [10:50] right [10:50] but ... if we want it on right hand size, then we need to maintain a proper .dirs file [10:50] because otherwise dh_install has no idea what -* means [10:51] want me to correct them and commit it? [10:51] just correct the left hand size ... for consistency [10:51] if that works ... you can play with what we can do on right size [10:53] cool ... lets see if the coffee is ready :/ [11:05] gnomefreak: is there -* used anywhere on right hand side? [11:05] hmmm no its not [11:05] i didnt see any [11:05] yeah [11:05] its still before coffee [11:05] so lets finish build and then see [11:06] yeah ... for me too [11:06] no coff yet [11:07] mines ready im just not sure if im gonna stay up or lay back down [11:08] hmm [11:08] no idea ;) [11:08] mines just finishing [11:08] though I just could swueeze about half litre out of the miserable rest of coffee powder i had [11:08] and thats not much [11:09] no lunch ... no chance to get new one ... because i need wireless hardware [11:12] damn he sounds unhappy with mozilla [11:12] who is he :) [11:12] ? [11:12] mike [11:12] mike hommey? [11:12] new blog entry? [11:12] yeah [11:12] you have a link [11:13] i will in a sec [11:13] my firefox bookmarks are broken ... so i have no rss atm [11:13] http://web.glandium.org/blog/?p=145 [11:14] hehe ... he is unhappy with epiphany et al [11:15] last update for gnash (did it include garbage collector? [11:15] we just had a respin [11:16] nothing new [11:16] because of libcurl went mad [11:16] debian upgraded to libcurl4 [11:16] we followed [11:16] ah [11:16] now debian returned to libcurl3 temporarily ... nobody here appears to read debian-devel-announce [11:16] lol [11:16] so people got panic and reverted to libcurl3 as well [11:17] and respun 70 packges or so [11:17] i found that out after prodding stevenk [11:17] libcurl3 wont even upgrade its blocked because noone respun the other packages [11:17] on your system? [11:18] yeah [11:18] libcurl3-gnutls [11:21] thats not updated or what? [11:24] so is gutsy state now broken? [11:24] because of libcurl? [11:24] or just respins missing? [11:25] if you see packages that are holding this back, look if there has already been an upload ... otherwise prod stevenk [11:26] ubuntu-desktop and others need to be spun on it im assuming [11:28] curl is in the done section assuming that is the source package name but will find out in a sec [11:28] yep [11:29] ubuntu-desktop is probably just waiting for something else [11:29] as ubuntu-desktop is just a meta package [11:29] OO.o is a huge one [11:29] it should have no real opinion on what lib gets installed [11:29] yeah [11:29] its just wasted imo [11:29] but lets see [11:30] its also waiting on libcurl4-gnutls [11:30] python-uno and lang pack [11:31] most are OO.o [11:32] its really great that i have such a well thought out backup setup :) [11:32] i could just [11:32] cp -r /backup/hector\:home-asac-.mozilla/2007-07-01\@01\:24\:22/* ~/.mozilla/ [11:32] and now i have my bookmarks back [11:32] yau [11:33] i lost a few bookmarks on latest update for some reason like mozilla.pastebin and one or 2 others [11:34] hmm [11:34] no idea [11:34] i will now respin alpha5 in gutsy [11:34] to see if the crashes come from firefox changes or mess in libcairo [11:34] why alpha5? [11:34] who is fixing libcario? us? [11:35] first i have to see if its firefox or libcairo that causes this mess [11:35] thats why i spin alpha5 against latest cairo [11:35] better not be firefox [11:35] because alpha5 worked [11:36] unfortunately we probably need to blame firefox until proved different... which is why i am doing this now [11:36] k [11:36] brb coffee [11:37] yeah [11:37]