=== Starting logfile irclogs/ubuntu-mozillateam.log | ||
=== ubuntulog [i=ubuntulo@ubuntu/bot/ubuntulog] has joined #ubuntu-mozillateam | ||
=== Topic for #ubuntu-mozillateam: Home of Ubuntu Mozilla Team - https://wiki.ubuntu.com/MozillaTeam | Bug Triagers please read: https://wiki.ubuntu.com/MozillaTeam/Bugs/ | Firefox trunk package source : https://code.launchpad.net/~asac/firefox/trunk | Mailing List: ubuntu-mozillateam@lists.ubuntu.com | | ||
=== Topic (#ubuntu-mozillateam): set by Admiral_Chicago at Sun Jun 24 10:33:47 2007 | ||
=== Admiral_Chicago_ [n=FreddyM@st074039212101.monm.edu] has joined #ubuntu-mozillateam | ||
=== Admiral_Chicago_ [n=FreddyM@st074039212101.monm.edu] has joined #ubuntu-mozillateam | ||
=== Admiral_Chicago_ [n=FreddyM@st074039212101.monm.edu] has joined #ubuntu-mozillateam | ||
=== jbs [n=Bernardo@89.181.211.185] has joined #ubuntu-mozillateam | ||
Jazzva|away | asac, there is another package I prepared few weeks ago. I've uploaded it to bazaar, you can see it at https://code.launchpad.net/~jazzva/fakenes/ubuntu | 08:46 |
---|---|---|
Jazzva|away | asac, that is if you have some free time to take a look at it :). Thanks... | 08:46 |
=== Bernardo [n=Bernardo@sourcemage/Bernardo] has joined #ubuntu-mozillateam | ||
=== shirish [n=shirish@59.95.37.118] has joined #ubuntu-mozillateam | ||
=== shirish [n=shirish@59.95.37.118] has left #ubuntu-mozillateam ["Leaving."] | ||
asac | Jazzva: there? | 10:16 |
Jazzva | asac: Yep, will just go to make a coffee... be back in a minute... | 10:18 |
asac | oh coffee ... good point ;) | 10:19 |
Jazzva | asac: Always ;)... Back | 10:21 |
asac | well ... now I am brewing coffee ;) | 10:22 |
asac | ok wait ... so ubufox is available | 10:22 |
asac | aeh sorry ... i mean a plugin finder service so one can look at the latest ubufox features is available | 10:22 |
Jazzva | Hmm... you "beautified" it :)? | 10:23 |
asac | no ... i fixed things that were still broken :) | 10:23 |
Jazzva | Oh, ok :)... | 10:23 |
asac | ... made it work flawless i hope | 10:23 |
asac | can you test if it works for you as well? | 10:23 |
Jazzva | Can I help with it? (though, I never wrote anything in python) | 10:23 |
Jazzva | Hmm, sure... | 10:23 |
asac | cool ... to take a look you just need the latest ubufox from bzr | 10:24 |
asac | (the upstream branch not the debian/ubuntu one) | 10:24 |
Jazzva | Just to download it :)... | 10:24 |
asac | cool | 10:25 |
asac | and you need to tweak the pfs.datasource url preference | 10:25 |
asac | i think its kind of url lik people.ubuntu.com/~asac/.... | 10:25 |
Jazzva | upstream == main? | 10:26 |
asac | ---> jxtaim.dyndns.org/~alex | 10:26 |
asac | Jazzva: yes | 10:26 |
Jazzva | Ok :) | 10:26 |
asac | the one without debian directory< | 10:26 |
asac | the one you worked on ;) | 10:26 |
Jazzva | ...and there was I, wondering why there's no debian/ :lol:... | 10:27 |
asac | hehe | 10:27 |
Jazzva | I'm stupid :) | 10:27 |
asac | no ... stupid is something else ;) | 10:28 |
Jazzva | Where do I set pfs.datasource? | 10:28 |
Jazzva | grep? :) | 10:29 |
asac | goto about:config | 10:29 |
asac | then search pfs | 10:29 |
asac | (do it manually in firefox) | 10:29 |
Jazzva | Ok :) | 10:29 |
asac | is there people.ubuntu.com already set at all ? or is it still pfs.mozilla.org? | 10:29 |
Jazzva | The first one | 10:31 |
Jazzva | :) | 10:31 |
Jazzva | But it seems wrong | 10:31 |
Jazzva | http:///people... | 10:31 |
asac | good ... replace people.ubuntu.com -> jxtaim.dyndns.org | 10:31 |
asac | yes ;) | 10:31 |
Jazzva | Note the three backslashes (or are they slashes?) | 10:31 |
asac | and asac -> alex :) | 10:32 |
asac | yes i already know :) | 10:32 |
Jazzva | Replaced | 10:32 |
asac | Jazzva: ok | 10:33 |
asac | when you have it installed there are test html pages | 10:33 |
asac | in pfs/test/ | 10:33 |
Jazzva | Ok | 10:33 |
asac | (in ubufox tree) | 10:33 |
asac | ok i pushed revision 34 (which fixes the triple-slash) | 10:35 |
asac | not worth an update though ;) | 10:35 |
Jazzva | Do I need to uninstall the flash plugin first? :) (but I don't think that it's installed in gutsy :/) | 10:35 |
Jazzva | Oh, there's a search in second test :) | 10:35 |
asac | yes for movie | 10:36 |
Jazzva | Nice :D | 10:36 |
Jazzva | And you know about the label not showing up? | 10:36 |
Jazzva | &pluginWizard.availablePluginsPage.description.label; (video/mpeg) | 10:37 |
Jazzva | Instead of something like "Choose plugin..." (I suppose) | 10:37 |
Jazzva | Hmm, here's the report | 10:38 |
Jazzva | Well, all codecs fail installation (it's not implemented yet?)... | 10:38 |
asac | huh? | 10:39 |
asac | codecs? | 10:39 |
asac | ah you are on feisty? | 10:39 |
Jazzva | Plugins :)... | 10:39 |
asac | you need apturl package from gutsy | 10:39 |
asac | you can just apt-get source it and build it in feisty | 10:39 |
Jazzva | Well, yes, but I'm running firefox from chroot... though profile dir is shared with feisty | 10:39 |
asac | it hasn't much dependencies | 10:39 |
asac | Jazzva: then try install apturl package | 10:39 |
Jazzva | Installing.. | 10:40 |
asac | and yes ... that plugin wizard needs to be beautified .... | 10:40 |
asac | 1st: the title needs to be fixed | 10:40 |
asac | 2nd: the choice box needs to be CSSed (so its white background) | 10:41 |
asac | 3rd: icons/images should be displayed for each result | 10:41 |
Jazzva | There is another thing. There are three different plugins, the gxine is selected as default. But, if you leave it as is it is and click "Next", the mplayer-plugin is installed instead... | 10:42 |
asac | yeah thats a bug | 10:43 |
asac | i forget to set some variable when preselecting it | 10:43 |
asac | actually i think we should drop the "no plugin for content type choice" | 10:43 |
Jazzva | And clicking "Cancel" on "Do you want to install..." returns me to the wizzard and shows that the plugin is installed :/... | 10:43 |
asac | however we word it ... it might confuse users | 10:43 |
asac | huh? | 10:44 |
asac | maybe its installed ? | 10:44 |
asac | so cancel in "apturl" dialog? | 10:44 |
Jazzva | Yes, that one... | 10:44 |
asac | yes ... that is an apturl bug, because it doesn't have a good exit coe | 10:45 |
asac | code | 10:45 |
asac | you can fix it by editing /usr/bin/apturl | 10:45 |
asac | its just a sys.exit(2) where the "Cancel" is processed | 10:45 |
asac | dia.format_secondary_text(body) | 10:45 |
asac | res = dia.run() | 10:45 |
asac | if res != gtk.RESPONSE_YES: | 10:45 |
asac | sys.exit(2); | 10:45 |
asac | thats what my version has | 10:45 |
asac | (which allows us to see if install fails) | 10:46 |
Jazzva | Ok... | 10:46 |
asac | i think sys.exit(2) is currently continue | 10:46 |
Jazzva | Hmm, wouldn't know... But mine has "continue" instead of "sys.exit(2)" | 10:47 |
Jazzva | Yep, changing it to "sys.exit(2)" corrects the problem. | 10:49 |
asac | good | 10:50 |
Jazzva | So far the installation goes nice... | 10:50 |
asac | i asked mvo ... he will fix it | 10:50 |
Jazzva | Downloading the packages... | 10:50 |
Jazzva | (just to check if everything will go nice) | 10:50 |
Jazzva | Off for a smoke... brb | 10:51 |
asac | ok nice | 10:52 |
Jazzva | Everything went well :)... | 11:01 |
Jazzva | asac ^ | 11:01 |
asac | cool | 11:01 |
asac | at best uninstall the package again :) ... so you can later test something ;) | 11:01 |
Jazzva | K... | 11:02 |
asac | ok in createPluginSetGroupBox ... we need to use this.getFormattedString | 11:03 |
asac | instead of just setting &....; to labe | 11:03 |
asac | as xml entities will not be parsed if just inject them by javascript | 11:04 |
asac | (in pluginInstallerWizard.js) | 11:04 |
Jazzva | Just a wild guess (based on C and stuff). Couldn't we just use something like: ("label", &...; + " (" + mimetype + ")")? | 11:06 |
Jazzva | or is that this.getFormattedString(&...)+...? | 11:07 |
Jazzva | :) | 11:07 |
=== asac_ [n=asac@debian/developer/asac] has joined #ubuntu-mozillateam | ||
Jazzva | <asac> (in pluginInstallerWizard.js) | 11:10 |
Jazzva | [11:06] <Jazzva> Just a wild guess (based on C and stuff). Couldn't we just use something like: ("label", &...; + " (" + mimetype + ")")? | 11:10 |
Jazzva | [11:07] <Jazzva> or is that this.getFormattedString(&...)+...? | 11:10 |
Jazzva | [11:07] <Jazzva> :) | 11:10 |
asac_ | oh right ... was off | 11:11 |
Jazzva | Well, it seems we can't... it searches for plugins forever... | 11:11 |
asac_ | its getFormattedString | 11:11 |
asac_ | there are examples in code | 11:11 |
asac_ | huh? | 11:11 |
Jazzva | Well, I replaced the "&...;"+... with &...+";"+ | 11:12 |
Jazzva | Just to get the string stored in label variable... | 11:12 |
asac_ | no that won't help | 11:12 |
Jazzva | But it's not working... | 11:12 |
asac_ | if you put that stuff in xul its expanded by xml parser | 11:12 |
asac_ | but if you inject elements into dom tree ... parser is not used anymore ... so we have to resolve the string programmatically bin javascript | 11:13 |
Jazzva | ...and that is done by getFormattedString? | 11:14 |
asac_ | yes ... getString gives you translated entity ... getFormattedString allows you to get translated + substitution | 11:14 |
asac_ | i think we just need getString() + "(" + mimetype +")" | 11:14 |
Jazzva | Ok, I'll give it a try now | 11:14 |
Jazzva | BTW, as for the first option | 11:15 |
Jazzva | Maybe we could set it as last | 11:15 |
Jazzva | And rename it to "Don't install any plugin" or something.. | 11:16 |
asac_ | haha | 11:16 |
asac_ | no the problem will go on | 11:16 |
asac_ | we have to properly select whatever we select | 11:16 |
asac_ | ah | 11:16 |
asac_ | yes | 11:16 |
Jazzva | I meant for the "no plugin..." | 11:16 |
Jazzva | :) | 11:16 |
asac_ | sorry mixed things up | 11:16 |
Jazzva | No prob... | 11:16 |
asac_ | well ... its not that simple | 11:16 |
asac_ | point is: if you have multiple content types on one page and you press the "install missing plugins ..." button | 11:17 |
asac_ | the idea is to allow users to install plugin for each missing content type | 11:17 |
asac_ | "Don't install any plugin" would imply that user doesn't want anything for other content types as well | 11:17 |
Jazzva | "Don't install this plugin" :)? | 11:18 |
asac_ | ... which is already served perfectly well with "cancel" :) | 11:18 |
asac_ | i think its too hard to understand for normal users | 11:18 |
Jazzva | Hm, is there a wizard launched per plugin? | 11:18 |
asac_ | right wording would be like it is: "don't install plugin for content type XXX" | 11:18 |
Jazzva | Or one wizard to bound them? :) | 11:18 |
asac_ | Jazzva: no there should be multiple wizard pages | 11:18 |
asac_ | e.g. first you select which plugin you want for which content type ... in the end everything gets installed | 11:18 |
Jazzva | Oh, I see :)... | 11:19 |
asac_ | currently its broken ... but that doesn't need to be fixed for feature freeze | 11:19 |
asac_ | its broken for plain upstream wizard as well | 11:19 |
asac_ | so we can deal later with that ,) | 11:19 |
Jazzva | Ok... | 11:19 |
Jazzva | Hmm.. not working :/. I tried with "this.getString(pluginWizar...)+..", but it didn't work. Then with "getString(&...", which also didn't work... | 11:39 |
Jazzva | I took a look at MDC reference for getString, and it says that I need key for string... I supposte that's "pluginWizard...label". | 11:40 |
asac | you need to use the string | 11:40 |
asac | look at other examples in the same file | 11:40 |
asac | yes | 11:41 |
asac | thats the yes | 11:41 |
asac | s/yes/key/ | 11:41 |
Jazzva | Damn... Ok, trying to find (with very little knowledge of JS and XUL (next to nothing) :)) why it doesn't work. Wish me luck... | 11:42 |
asac | Jazzva: he? | 12:00 |
Jazzva | asac: Nvm :)... | 12:01 |
asac | Jazzva: just try getString() first | 12:01 |
asac | if that works see formatted string | 12:01 |
asac | this.getString("pluginWizard...") ... doesn't that work? | 12:01 |
Jazzva | Hmm... That's not working :) | 12:01 |
asac | what happens? | 12:01 |
Jazzva | Oooh... I need quotes :) | 12:01 |
asac | yeah ... i already pointed that out | 12:01 |
asac | above :) | 12:01 |
asac | oh ... no i wanted to point out but since you | 12:02 |
asac | 11:40 < Jazzva> I took a look at MDC reference for getString, and it says that I need key for string... I supposte that's "pluginWizard...label". | 12:02 |
asac | i thought you use "" :) | 12:02 |
Jazzva | Oh... No, I use them here when I want to write something that is part of the code :). | 12:02 |
asac | yeah i noticed that now | 12:04 |
Jazzva | Well, here's the result | 12:07 |
Jazzva | "Press Next to install these plugins" | 12:07 |
Jazzva | <empty page> | 12:07 |
=== Jazzva pressed Next | ||
Jazzva | "No plugins were installed." | 12:07 |
=== Jazzva pressed Finish | ||
asac | ok | 12:09 |
asac | Jazzva: | 12:10 |
asac | statMsg = this.getString("pluginInstallation.complete"); | 12:10 |
asac | this is known to work | 12:10 |
Jazzva | And then to use "setAttribute("label", statMsg+...);"? | 12:11 |
asac | if you use that it works? | 12:11 |
Jazzva | I'll try now :)... | 12:11 |
asac | and if you place the entitiy-id with the one we wnat it doesn't ? | 12:11 |
asac | s/place/replace/ | 12:11 |
Jazzva | Nope, it doesn't... | 12:13 |
asac | what doesn't work? | 12:15 |
asac | if you use this this.getString("pluginInstallation.complete") ? | 12:15 |
Jazzva | No, I tried to use "labelMsg = this.getString("pluginWizard...");" (the one that was supposed to be used as label text), but that didn't work. I'll test it with "pluginInstallation.complete" | 12:16 |
asac | try this.getString("pluginInstallation.complete") ... if that works we have to add something | 12:17 |
Jazzva | Does this look good: | 12:22 |
Jazzva | caption.setAttribute("label", "; this.getString("pluginInstallation.complete")+"; ("+mimetype+")"); | 12:22 |
Jazzva | ? | 12:22 |
asac | no | 12:24 |
Jazzva | ";? :) | 12:24 |
asac | you have mesed up quotes + ; | 12:24 |
asac | ; are only at end of line | 12:24 |
Jazzva | I see it now... | 12:24 |
Jazzva | I'm stupid... but this morning, I'm enormously stupid... *smacksheadagainstwall* | 12:25 |
asac | hehe | 12:25 |
asac | if it works you will remember ;) | 12:25 |
Jazzva | caption.setAttribute("label", this.getString("pluginInstallation.complete")+"; ("+mimetype+")"); | 12:27 |
Jazzva | Ok, I supposed that this one is good, but no... | 12:28 |
asac | well ... that might work ... is the ; in the mids of the string is intentional? | 12:28 |
Jazzva | Yes, it's the way it was in the star | 12:29 |
Jazzva | *start | 12:29 |
asac | k | 12:29 |
Jazzva | But it's not working... | 12:29 |
asac | try an window.alert("test: "+this.getString("pluginInstallation.complete")); right before that line | 12:29 |
asac | Jazzva: the ; in the mids of the string was just there because i copied the whole xml entity expression | 12:32 |
asac | which ends with ; | 12:32 |
Jazzva | Hmm, no alert :/... | 12:32 |
asac | &key.id; .... thats replaced by an entity when xmp parser sees it | 12:32 |
asac | Jazzva: you have messed something else up most likely | 12:32 |
asac | introspect your changes with bzr diff | 12:32 |
Jazzva | I suppose... | 12:32 |
asac | maybe you accidentially inserted something you didn't want | 12:33 |
Jazzva | This is the only thing: | 12:33 |
Jazzva | var caption = document.createElement("caption"); | 12:33 |
Jazzva | - caption.setAttribute("label", "&pluginWizard.availablePluginsPage.description.label; ("+mimetype+")"); | 12:33 |
Jazzva | + window.alert("test: "+this.getString("pluginInstallation.complete")); | 12:33 |
Jazzva | + caption.setAttribute("label", this.getString("pluginInstallation.complete")+"; ("+mimetype+")"); | 12:33 |
Jazzva | gbox.appendChild(caption); | 12:33 |
Jazzva | Hmm, I'll try without concatenating func result with other strings... | 12:34 |
Jazzva | Dunno if that'll change anything | 12:34 |
Jazzva | Still the same... :/ | 12:39 |
asac | wierd | 12:39 |
Jazzva | Maybe something went wrong with the uninstallationof plugin :/ | 12:39 |
asac | what function is that code in? | 12:39 |
asac | try to open alert with just this ... to see if its set at all | 12:39 |
asac | just "..." + this); | 12:40 |
Jazzva | function createPluginSetGroupBox (document, mimetype, aPluginInfoSet) | 12:40 |
asac | ok | 12:40 |
asac | this is not set there | 12:40 |
asac | add a parameter "self" to that function | 12:40 |
asac | and pass this into that from the caller | 12:40 |
asac | wait | 12:40 |
asac | just rename the fuction like below: | 12:41 |
asac | nsPluginInstallerWizard.prototype.showPluginList = function () { | 12:41 |
asac | and call it with this.createPluginSetGroupBox instead of just createPluginSetGroupBox | 12:41 |
asac | then this will be set | 12:41 |
Jazzva | Umm, so "nsPlug...prototype.createPlug..."? | 12:42 |
asac | because the function becomes an "instance" function | 12:42 |
asac | yeah | 12:42 |
asac | its the way Object-Orientation is done in javascript :) | 12:42 |
Jazzva | Riiight :)... Will have to read up on that, I see :) | 12:43 |
Jazzva | It works :)... | 12:45 |
Jazzva | So, just to check if I got your point :)... | 12:45 |
Jazzva | nsPluginInstallerWizard is an object | 12:46 |
Jazzva | and "function createPluginSetGroupBox" isn't a method of that object (obviously) | 12:47 |
Jazzva | But I still used "this" to reference to the object, which was wrong | 12:47 |
Jazzva | right? | 12:47 |
asac | yes | 12:50 |
asac | which didn't exist | 12:50 |
asac | because your scope was "outside" of the object | 12:50 |
asac | objects implicitly define "this" variable | 12:50 |
asac | createPluginSetGroupBox was just a plain old function | 12:51 |
asac | now its a method of that object | 12:51 |
Jazzva | Just like in C++ | 12:51 |
Jazzva | :) | 12:51 |
Jazzva | It's not working with "this.getString("pluginWizard.availablePluginsPage.description.label")" though :/... You sure that key exists? | 12:53 |
Jazzva | Oh, lemme check with window.alert () :) | 12:53 |
Jazzva | Hm, no alert window :/... | 12:56 |
Jazzva | Does that mean that we should add it to locale/../ubufox.dtd? | 12:56 |
Jazzva | But we can't since it's a plugin name? | 12:57 |
Jazzva | Or is it some generic text like "Choose plugin"? | 12:57 |
asac | probably it doesn't exist then | 12:59 |
asac | maybe it needs to be in a properties file | 01:00 |
asac | Jazzva: try to add it to ./locale/en-US/ubufox.properties | 01:00 |
asac | then include that properties file in pluginfinderWizard.xul | 01:00 |
Jazzva | Ok... | 01:01 |
asac | i think you have to extend | 01:02 |
asac | <stringbundleset id="pluginSet"> | 01:02 |
asac | <stringbundle id="brandStrings" src="chrome://branding/locale/brand.properties"/> | 01:02 |
asac | <stringbundle id="xpinstallStrings" src="chrome://global/locale/xpinstall/xpinstall.properties"/> | 01:02 |
asac | <stringbundle id="pluginWizardString" src="chrome://mozapps/locale/plugins/plugins.properties"/> | 01:02 |
asac | </stringbundleset> | 01:02 |
Jazzva | Ok | 01:02 |
asac | with a ubufox/locale/plugins.properties ... and add that to locale/en-US | 01:02 |
asac | with the key you want | 01:02 |
asac | like | 01:02 |
asac | key.id=value | 01:02 |
asac | value gets no quotes | 01:02 |
Jazzva | But there is already ubufox.properties... Why don't I just add to that one? | 01:03 |
asac | sure | 01:03 |
Jazzva | :) | 01:03 |
asac | i have to do a break ... this "wrong plugin selected without click problem" twists my mind a bit ;) | 01:04 |
Jazzva | How does "ubufox.pluginfinder.availableplugins.label" sound? | 01:04 |
Jazzva | Or just ".available." | 01:04 |
asac | well | 01:06 |
asac | lets use ubufox.pluginWizard.availablePluginsPage.description.label | 01:06 |
Jazzva | Ok... | 01:07 |
asac | just prepend the entities we overload from current pfw | 01:07 |
Jazzva | How do I find the chrome url? Is the right one "chrome://ubufox/locale/ubufox.properties"? | 01:08 |
Jazzva | uri... | 01:08 |
Jazzva | Never mind :).. | 01:10 |
asac | Jazzva: you can test chrome urls in firefox location bar | 01:13 |
asac | e.g. chrome://ubufox/content/pluginFinderWizard.xul | 01:13 |
Jazzva | And define them in chrome.manifest :) | 01:13 |
asac | should show you the wizard embedded in browser window ;) | 01:13 |
asac | same for .js and css and dtd and whatever file | 01:13 |
asac | o its already pretty cool | 01:14 |
asac | http://people.ubuntu.com/~asac/Screenshot-Plugin%20Finder%20Service-1.png | 01:14 |
asac | now fix title | 01:14 |
asac | then i think we are done for feature freeze | 01:15 |
asac | we can make a table out of the choice box during freeze i guess ... as its just "layout" | 01:15 |
asac | ah maybe we want an agenda? | 01:15 |
asac | e.g. so users understand what those icons mean? | 01:15 |
asac | e.g the globe: installs from internet | 01:16 |
asac | the ubuntu sign: ubuntu managed package | 01:16 |
Jazzva | It's pretty :) | 01:16 |
asac | its prettier when run outside chroot | 01:17 |
asac | with an actual gnome theme :) | 01:17 |
asac | but since i have amd64 i don't get any internet result there that would show the globe | 01:17 |
asac | hmmm maybe we want to remove the frame border around the choice box | 01:18 |
asac | and just put a title | 01:18 |
Jazzva | Hmm... It would be ok | 01:19 |
Jazzva | :) | 01:19 |
asac | that would remove the GetString() again ... it was in xul before ... hmm | 01:20 |
Jazzva | Lol... | 01:20 |
asac | Jazzva: for now just make a vbox out of the groupbox in createGroup thing | 01:22 |
asac | that will remove the border | 01:22 |
Jazzva | Umm... ok | 01:22 |
Jazzva | :) | 01:22 |
asac | let me know when you are done | 01:23 |
asac | i will look if i can split up the work i did now in multiple commits and then merge in your changes | 01:23 |
Jazzva | Mhm... | 01:23 |
asac | :) | 01:23 |
Jazzva | Hmm, it says that it's not well-formed uri: chrome://ubufox/locale/ubufox.properties | 01:29 |
Jazzva | In this tag: | 01:29 |
Jazzva | <stringbundle id="ubufoxPluginWizardString" src=chrome://ubufox/locale/ubufox.properties"/> | 01:29 |
asac | well look closer ;) | 01:29 |
asac | the problem is in that line | 01:29 |
asac | itsnot well-formed ;) | 01:29 |
Jazzva | Damn... | 01:30 |
Jazzva | I hate this day... and quotes :) | 01:30 |
asac | should be too obvious to see by oneself :) | 01:30 |
Jazzva | Yes, it is... | 01:30 |
asac | have you tried if chrome://ubufox/locale/ubufox.properties is ok (in location bar) ? | 01:31 |
Jazzva | It is | 01:31 |
Jazzva | I have tried, it listes the strings... | 01:31 |
asac | pleae commit the groupbox -> vbox change in a separate checkin ;) | 01:31 |
asac | then fine | 01:31 |
Jazzva | Sure :)... | 01:31 |
asac | if that works you probably want to use formatted string | 01:32 |
asac | syntax examples should be available in ubufox.properties | 01:32 |
Jazzva | Ok... but the plugin finder is not working with this added string :/... | 01:33 |
Jazzva | Is it a problem if I go and get something to eat, and to continue fixing after? :) | 01:33 |
Jazzva | In about ... 20-30 minutes... | 01:33 |
asac | no | 01:34 |
asac | go ahead | 01:34 |
Jazzva | And maybe I'll stop making the missing-quotes errors after brunch :)... | 01:34 |
Jazzva | Ok, see you later | 01:35 |
Jazzva | Back... Will try to correct the problem with message now and to change gbox to vbox. | 02:05 |
asac | Jazzva: thanks | 02:07 |
asac | Jazzva: there is one more feature request | 02:07 |
asac | the Get Addons link should only be displayed when we are in the extensions tab for now | 02:08 |
asac | you probably have to search elements for some specific element id or label or something to figure out, which is currently active | 02:08 |
asac | you should be able to find that using dom inspector | 02:08 |
Jazzva | I thought of that too... | 02:09 |
Jazzva | I noticed that it appears when you need to restart firefox after installation of extensions, which didn't make much sense... | 02:09 |
asac | right | 02:14 |
asac | it appears in every tab | 02:14 |
asac | (which is the root issue) | 02:14 |
asac | cool i fixed the multi content type case | 02:14 |
asac | well at least the UI | 02:15 |
Jazzva | Weee :) | 02:15 |
asac | cool it just works | 02:16 |
asac | lets test cancel szenarios | 02:16 |
Jazzva | Hmm, what's the difference between dtd and properties file? I can't find info right now on Google and MDC doesn't work well right now :/... | 02:16 |
asac | e.g. user cancels first install ... is second one still tried? | 02:16 |
asac | well .dtd is a xml mechanism ... | 02:16 |
asac | among other things you can specify entities which are then replaced when xml document is parsed | 02:16 |
asac | you mark entities with &...; | 02:16 |
asac | properties is just a mapping file | 02:17 |
asac | nothing more | 02:17 |
asac | so if you want to localize i nxul you need .dtd | 02:17 |
asac | while in code you want .properties | 02:17 |
Jazzva | Ok... | 02:17 |
Jazzva | Thanks | 02:17 |
asac | if you don't want to duplicate translations used in code + xul you can just put the chrome:// uri of the properties file in the .dtd value | 02:18 |
asac | mozilla will automagically resolve that for you | 02:18 |
Jazzva | Hmm, I think this is why it doesn't recognize my string | 02:23 |
Jazzva | This is the function that fetches the string: | 02:23 |
Jazzva | nsPluginInstallerWizard.prototype.getString = function (aName){ | 02:23 |
Jazzva | return document.getElementById("pluginWizardString").getString(aName); | 02:23 |
Jazzva | } | 02:23 |
Jazzva | ...brb, phone... | 02:23 |
Jazzva | Back... | 02:30 |
Jazzva | So, i gets he strinbundle which has that id, which is at chrome://mozapps/locale/pl...., while my string is at chrome://ubufox/locale/... | 02:32 |
Jazzva | I'll try to fetch my string with getElementById... | 02:32 |
asac | huh` | 02:35 |
asac | who implements that? | 02:35 |
asac | right :) | 02:36 |
Jazzva | Ok :)... | 02:36 |
asac | you got it ;) | 02:36 |
asac | maybe add object method: getUbufoxString | 02:36 |
asac | or better yet | 02:36 |
asac | in getString ... try first to resolve from our properties | 02:36 |
asac | if that fails try the pristine ones | 02:36 |
Jazzva | Uh-huh... Ok. | 02:36 |
Jazzva | Yay "Choose a plugin (video/mpeg)" :) | 02:37 |
asac | Jazzva: lets change it: | 02:39 |
asac | choose plugin for media type %s | 02:39 |
asac | or choose plugin to enable media "...:" | 02:39 |
asac | because in ffox main window when there is a plugin missing it reads: | 02:39 |
Jazzva | Ok, where %s will be replaced by "(video/mpeg)" or something in that format? | 02:40 |
asac | "Additional plugins required to display all the media on this page." | 02:40 |
asac | so we should say: | 02:40 |
asac | "Choose plugin you want to use to display %s media" | 02:41 |
asac | or something like that | 02:41 |
Jazzva | Ok... | 02:41 |
asac | so the user doesn#t get confused by deviated workding for the same things | 02:41 |
asac | then we can add a choice to the bottom that reads "I don't want to display this media" | 02:43 |
asac | :) | 02:43 |
asac | sounds good? | 02:43 |
asac | (now that we have multi media types working :)) | 02:43 |
Jazzva | Very ;)... | 02:43 |
asac | Jazzva: look http://people.ubuntu.com/~asac/Screenshot-Plugin%20Finder%20Service-2.png | 02:44 |
asac | or did i show that already ;) | 02:44 |
Jazzva | Well, you showed one... | 02:44 |
Jazzva | Dunno if this is the one | 02:44 |
asac | the scroll bar will disappear when we remove the groupbox (at least it does for me) | 02:45 |
Jazzva | It's cool :) | 02:45 |
Jazzva | getString returns null if no string is found? | 02:46 |
asac | most likely | 02:46 |
asac | ah ... yes | 02:46 |
asac | like it does now | 02:46 |
Jazzva | I'll also edit the getFormattedString... | 02:47 |
asac | right | 02:47 |
asac | please commit those in a separate commit | 02:47 |
Jazzva | Sure... | 02:47 |
asac | e.g. i mean both string fixes in the same commit... but without the rest | 02:48 |
Jazzva | I'm still doing in the develop branch, which is local... Then I'll have to edit the files in the uploading branch... | 02:49 |
Jazzva | :) | 02:49 |
asac | ah | 02:49 |
asac | i do it more or less similar | 02:49 |
asac | if i mix things i do a bzr diff > changes.diff | 02:49 |
Jazzva | I suppose it's cool for not too big updates | 02:49 |
asac | then i open emacs changes.diff | 02:49 |
asac | and apply manually | 02:49 |
asac | (using diff-mode) | 02:49 |
Jazzva | Hmm... I don't know for that... :) | 02:50 |
Jazzva | Sounds nice... | 02:50 |
asac | hunk-by-hunk ... committing for each single issue approached | 02:50 |
Jazzva | Damn... this new getString is not working... | 02:54 |
=== Ubulette [n=Ubulette@APuteaux-153-1-65-16.w82-124.abo.wanadoo.fr] has joined #ubuntu-mozillateam | ||
Jazzva | asac, how does this look to you? | 02:56 |
Jazzva | nsPluginInstallerWizard.prototype.getString = function (aName){ | 02:56 |
Jazzva | var result = document.getElementById("ubufoxPluginWizardString").getString(aName); | 02:56 |
Jazzva | if (!result) | 02:56 |
Jazzva | result = document.getElementById("pluginWizardString").getString(aName); | 02:56 |
Jazzva | return result; | 02:56 |
Jazzva | } | 02:56 |
Jazzva | I'm not sure how is (!result) evaluated in JS... | 02:56 |
Jazzva | Switching to "if (result == null)" | 02:58 |
asac | !result is equivalent result != null | 03:04 |
ubotu | I'll remember that, asac | 03:04 |
asac | ups | 03:05 |
asac | damn | 03:05 |
asac | thats a mess now | 03:05 |
asac | ;) | 03:05 |
asac | !result | 03:05 |
ubotu | result is equivalent result != null | 03:05 |
asac | hehe | 03:05 |
asac | !result | Jazzva | 03:05 |
ubotu | Jazzva: please see above | 03:05 |
Jazzva | Hmm... now that's an interesting concept :P | 03:06 |
asac | !!result is equivalent result != null | 03:06 |
ubotu | But result already means something else! | 03:06 |
asac | !forget result | 03:06 |
ubotu | I'll forget that, asac | 03:06 |
asac | !result | 03:06 |
ubotu | Sorry, I don't know anything about result - try searching on http://bots.ubuntulinux.nl/factoids.cgi | 03:06 |
asac | ok ... hope there was no fact for result before ;) | 03:07 |
Jazzva | :) | 03:07 |
Jazzva | Hmm, but "result" is equivalent to "result != null" | 03:10 |
asac | is wrong :) | 03:10 |
Jazzva | ...anyway, the new getString's not working for some reason | 03:11 |
asac | the bot just ate the ! because it was instructions | 03:11 |
Jazzva | wrong? :) | 03:11 |
asac | .... !result is equiv. to result != null | 03:11 |
asac | oh :) | 03:11 |
asac | hehe | 03:11 |
Jazzva | And "result" to "result == null"? | 03:11 |
Jazzva | :) | 03:11 |
asac | forget about it :) | 03:11 |
asac | flip it ;) | 03:11 |
asac | result <=> result != null .... so fact was correct | 03:12 |
Jazzva | Well, I got confused too for a while... | 03:12 |
asac | ok i think rev 39 + yur changes will be good for beta | 03:13 |
Jazzva | Anyway, getString is not working, and I've tried three variations. Probably because getString doesn't return null (though, I can't think of some other value, -1 maybe :))... | 03:13 |
asac | i will now make the server side work even without calling to mozilla (of course we will only get ubuntu results then) | 03:13 |
Jazzva | Ok, should I merge your rev 39 with my branch before applying my changes to this? | 03:14 |
asac | but i don't feel like i want to use my jxtaim.dyndns.org as default setting ;) | 03:14 |
asac | Jazzva: if you still have the chance, just pull my branch | 03:14 |
asac | otherwise i would merge your changes into mine | 03:14 |
Jazzva | Well, I have.. I'm still working on local branch... | 03:15 |
Jazzva | Lunchtime... brb | 03:17 |
=== asac lunchy | ||
IdleOne | I was sent an email asking me to get a backtrace for bug 132235 following the steps provide in https://wiki.ubuntu.com/MozillaTeam/Bugs . I installed the packages in step 1 but now in step 2 it says to run firefox from terminal. what I am wondering is do I eed to change firefox -g 2>&1 | tee ~/Desktop/gdb-firefox.log to firefox-granparadiso -g 2>&1 | tee ~/Desktop/gdb-firefox-granparadiso or run the commands as they are?.log | 03:39 |
ubotu | Launchpad bug 132235 in firefox-granparadiso "[GUTSY] firefox-granparadiso crashed" [Medium,Incomplete] https://launchpad.net/bugs/132235 | 03:39 |
IdleOne | when running firefox-granparadiso -g 2>&1 | tee ~/Desktop/gdb-firefox-granparadiso.log paradiso doesnt seem to be doing anything ( doesnt start ) | 03:45 |
IdleOne | http://pastebin.ubuntu-nl.org/33820/ this is output of running the above command. just sits there not doing anything I can see with cursor blinking | 03:49 |
IdleOne | I am not sure if I am doing something wrong but the .log has the exact same info as the pastebin http://pastebin.ubuntu-nl.org/33820/ | 03:54 |
IdleOne | Ubulette: if you are around I would appreciate any help you can give with this | 03:57 |
asac | re | 04:03 |
IdleOne | Ubulette: bug 132235 updated with backtrace. doubt it will help any. | 04:03 |
ubotu | Launchpad bug 132235 in firefox-granparadiso "[GUTSY] firefox-granparadiso crashed" [Medium,Incomplete] https://launchpad.net/bugs/132235 | 04:03 |
IdleOne | wb asac | 04:03 |
IdleOne | can you take a look at what I said/did with this backtrace? | 04:03 |
asac | in a second | 04:04 |
IdleOne | k ty be right back also | 04:04 |
IdleOne | back | 04:06 |
IdleOne | ciggy | 04:08 |
asac | IdleOne: yes | 04:15 |
asac | IdleOne: however there are no -dbg packages available | 04:15 |
asac | you need to get the dbgsym package | 04:15 |
asac | i think deb http://people.ubuntu.com/~pitti/ddebs/ ./ should allow you to install | 04:16 |
asac | firefox-granparadiso-dbgsym | 04:16 |
asac | well | 04:16 |
asac | http://people.ubuntu.com/~pitti/ddebs/ | 04:16 |
asac | ouch | 04:17 |
asac | IdleOne: https://lists.ubuntu.com/archives/ubuntu-devel-announce/2006-September/000195.html | 04:17 |
asac | IdleOne: and if you are in the (gdb) shell you have to start the application: | 04:17 |
asac | (gdb) run | 04:17 |
asac | its in the wiki (you mussed have missed it) | 04:17 |
asac | Jazzva|away: ok when you have hidden the get ubuntu addons link, then we are ready for 0.4~beta1 release | 04:19 |
asac | well ... string sof course as well ;) | 04:19 |
IdleOne | ok so I need to install this https://lists.ubuntu.com/archives/ubuntu-devel-announce/2006-September/000195.html first? | 04:19 |
asac | you have to install firefox-granparadiso-dbgsym | 04:19 |
asac | adapt the apt/sources.list line for gutsy | 04:20 |
IdleOne | so I add https://lists.ubuntu.com/archives/ubuntu-devel-announce/2006-September/000195.html to sources.list then apt-get firefox-granparadiso-dbgsym | 04:20 |
IdleOne | k | 04:20 |
IdleOne | lemme do that | 04:20 |
asac | IdleOne: welll the line that is announced in that mail ... yes | 04:20 |
Ubulette | hi | 04:22 |
asac | ole | 04:25 |
IdleOne | asac: Couldn't find any package whose name or description matched "firefox-granparadiso-dbgsym" | 04:26 |
asac | you probably didn't adapt for gutsy | 04:26 |
IdleOne | ahhh | 04:27 |
IdleOne | :/ | 04:27 |
asac | rewad what i say with care ... it usually contains all info needed ;) | 04:27 |
IdleOne | will try to remember that :P | 04:28 |
Ubulette | guys, why do you need another backtrace ? I've already provided 2.. | 04:28 |
IdleOne | not sure I got an email asking for one | 04:28 |
IdleOne | should I provide the backtrace or not? | 04:29 |
Ubulette | well, for me, that's is enough: | 04:30 |
Ubulette | (gdb) bt | 04:30 |
Ubulette | #0 0xb6963576 in XSync () from /usr/lib/libX11.so.6 | 04:30 |
Ubulette | #1 0xb2423a6d in JavaPluginInstance5::SetWindow () from /usr/lib/jvm/java-1.5.0-sun-1.5.0.12/jre/lib/i386/libjavaplugin_nscp.so | 04:30 |
Ubulette | gdb) bt | 04:30 |
Ubulette | #0 0xb692c576 in XSync () from /usr/lib/libX11.so.6 | 04:30 |
Ubulette | #1 0xb0a45c5d in JavaPluginInstance5::SetWindow () from /usr/lib/jvm/java-6-sun-1.6.0.02/jre/lib/i386/libjavaplugin_nscp.so | 04:30 |
Ubulette | so both java 5 and 6 failed in XSync() | 04:30 |
Ubulette | seems to be the same code: JavaPluginInstance5::SetWindow() so at least it's coherent | 04:31 |
IdleOne | then me doing another backtrace would be redundant is what you are saying | 04:31 |
Ubulette | if you get the same thing, probably yes :P | 04:31 |
Ubulette | asac, thoughts ? | 04:32 |
IdleOne | will give it a shot anyway just so I can learn how to do this properly | 04:33 |
IdleOne | havent ever done a backtrace | 04:33 |
IdleOne | learning something new is never redundant :) | 04:34 |
asac | about java? | 04:36 |
asac | Ubulette: ?? | 04:36 |
IdleOne | believe Ubulette is asking if I should also provide a backtrace seeing how she has already done two of them | 04:37 |
=== IdleOne assumes Ubulette is a she | ||
IdleOne | ... # full backtrace output | 04:39 |
IdleOne | (gdb) thread apply all backtrace full | 04:39 |
IdleOne | ... # all threads full backtrace output | 04:39 |
IdleOne | (gdb) quit | 04:39 |
IdleOne | ooops | 04:39 |
IdleOne | sorry | 04:39 |
Ubulette | "she has already done" ? lol | 04:43 |
IdleOne | well your name is feminine in nature | 04:43 |
Ubulette | maybe, but i'm not | 04:43 |
IdleOne | atleast to me it is. I am guessing it is french derived and in french words ending in ette are feminine | 04:44 |
IdleOne | sorry Ubulette didnt mean to insult or anything | 04:44 |
Ubulette | np | 04:44 |
IdleOne | so anyway doesnt seem like this backtrace is working out for me keep getting : no debug symbols found | 04:45 |
=== Admiral_Chicago [n=FreddyM@st074039212101.monm.edu] has joined #ubuntu-mozillateam | ||
asac | IdleOne: dbgsym installed? | 04:47 |
IdleOne | yes | 04:47 |
asac | hmm | 04:47 |
asac | Ubulette: for you dbgsym works, right? | 04:48 |
Ubulette | never tried that | 04:48 |
IdleOne | firefox-granparadiso-dbgsym: | 04:48 |
IdleOne | Installed: 3.0~alpha7-0ubuntu5 | 04:48 |
IdleOne | Candidate: 3.0~alpha7-0ubuntu5 | 04:48 |
Ubulette | I did my traces with trunk alone, not even trunk-dbg | 04:48 |
asac | IdleOne: well what do you get when running bt full? | 04:48 |
asac | Ubulette: from within dist/bin ? | 04:49 |
Ubulette | no | 04:49 |
IdleOne | asac: hold a sec | 04:49 |
asac | Ubulette: well the ones above are not symbolized | 04:49 |
asac | Ubulette: please try with -dbgsym package installed | 04:49 |
asac | Ubulette: you might see more and can check if paradiso passes sane parameters into XSync | 04:49 |
IdleOne | asac: http://paste.ubuntu-nl.org/33837/ | 04:51 |
asac | IdleOne: what size is the dbgsym .deb ? | 04:51 |
IdleOne | not sure how do I check? | 04:51 |
asac | ls -l /var/cache/apt/archives iirc | 04:52 |
asac | somewhere below /var is an apt.archives file | 04:52 |
asac | there are all .debs downloaded (since last time you ran apt-get clean) | 04:52 |
IdleOne | 8136 2007-08-13 19:24 firefox-granparadiso-dbgsym_3.0~alpha7-0ubuntu5_i386.ddeb | 04:53 |
Ubulette | -dev-dbgsym is 45M | 04:54 |
IdleOne | how did you get that info? | 04:55 |
IdleOne | I ot 8.0K | 04:55 |
IdleOne | got | 04:55 |
IdleOne | du -h /var/cache/apt/archives/firefox-granparadiso-dbgsym_3.0~alpha7-0ubuntu5_i386.ddeb | 04:56 |
IdleOne | 8.0K /var/cache/apt/archives/firefox-granparadiso-dbgsym_3.0~alpha7-0ubuntu5_i386.ddeb | 04:56 |
IdleOne | hmmm | 04:56 |
Ubulette | -dev-xxx | 04:57 |
Ubulette | asac, it's no different | 05:01 |
Ubulette | oh, i need to tweak LD_LIBRARY_PATH | 05:03 |
IdleOne | so what am I missing so I can run backtrace? | 05:04 |
=== IdleOne is a little lost here | ||
asac | Ubulette: usually LD_LIBRARY_PATH should be just correct if you run firefox-granparadiso -g | 05:13 |
asac | for firefox -g it works | 05:13 |
asac | IdleOne: your dbgsym package is definitly broken | 05:14 |
Ubulette | how does it knows it has symbols in usr/lib/debug/usr/lib/firefox-granparadiso-devel-3.0a7/sdk/lib/*.so ? | 05:14 |
asac | Ubulette's looks good | 05:14 |
Ubulette | it's not the same deb | 05:14 |
asac | does it? | 05:14 |
asac | i mean firefox-granparadiso-dbgsym should have symbols for granparadiso | 05:15 |
asac | libs | 05:15 |
Ubulette | -rw-r--r-- 1 fta fta 8136 2007-08-14 01:24 firefox-granparadiso-dbgsym_3.0~alpha7-0ubuntu5_i386.ddeb | 05:15 |
Ubulette | -rw-r--r-- 1 fta fta 46449324 2007-08-14 01:25 firefox-granparadiso-dev-dbgsym_3.0~alpha7-0ubuntu5_i386.ddeb | 05:15 |
asac | Ubulette: yes ... thats a problem then | 05:15 |
asac | Ubulette: do you disable--strip-libs in configure? | 05:16 |
Ubulette | dont remember me doing that | 05:16 |
asac | look please | 05:16 |
asac | if there is strip-libs disabled | 05:16 |
asac | otherwise thats the reason | 05:17 |
asac | for sure | 05:17 |
Ubulette | http://people.ubuntu.com/~pitti/ddebs/pool/universe/f/firefox-granparadiso/ ppc is different | 05:17 |
asac | let me look | 05:17 |
asac | ok strip is disabled ...s ot this isn't the problem | 05:18 |
Ubulette | --disable-strip \ | 05:18 |
Ubulette | --disable-strip-libs \ | 05:18 |
asac | and we pass -g in CFLAGS and CXXFLAGS ? | 05:18 |
asac | yes we do | 05:18 |
asac | ok | 05:18 |
asac | Ubulette: powerpc is still alpha5 | 05:19 |
=== Admiral_Chicago [n=FreddyM@st074039212101.monm.edu] has joined #ubuntu-mozillateam | ||
Ubulette | oh | 05:19 |
IdleOne | asac: if my dbgsym is broken how do I fix it? | 05:20 |
asac | no idea ;) | 05:22 |
asac | would have to look into it | 05:22 |
asac | its probably a packaging bug which you cannot do much about | 05:22 |
IdleOne | will installing the one from http://people.ubuntu.com/~pitti/ddebs/pool/universe/f/firefox-granparadiso/ fix it? | 05:23 |
asac | no | 05:23 |
asac | thats the same ;) | 05:23 |
asac | you are out of luck atm | 05:23 |
IdleOne | hmmm well then | 05:23 |
IdleOne | heh okie dokie | 05:23 |
asac | wait till we have a better dbgsym | 05:23 |
Ubulette | http://pastebin.mozilla.org/184682 | 05:25 |
Ubulette | that's /w trunk | 05:25 |
IdleOne | Ubulette: unfortunately I dont really understand much of that or enough to know what it means | 05:27 |
asac | Ubulette: that backtrace doesn't yield much ... we need symbols | 05:29 |
Ubulette | we have | 05:30 |
asac | ah right | 05:30 |
Ubulette | except in java | 05:30 |
asac | install dbg-sym packages for x11 as well | 05:30 |
asac | maybe you can see more details about XSynx | 05:30 |
asac | Jazzva|away: are you on? | 05:31 |
asac | oh | 05:31 |
asac | ;) | 05:31 |
=== Admiral_Chicago [n=FreddyM@st074039212101.monm.edu] has joined #ubuntu-mozillateam | ||
Ubulette | there's no dbgsym for java | 05:34 |
asac | right | 05:37 |
asac | but for x | 05:37 |
Ubulette | #0 XSync (dpy=0x0, discard=0) at ../../src/Sync.c:46 | 05:39 |
Ubulette | #1 0xb0e2cc5d in JavaPluginInstance5::SetWindow () from /usr/lib/jvm/java-6-sun-1.6.0.02/jre/lib/i386/libjavaplugin_nscp.so | 05:40 |
Ubulette | #2 0xb0e5dca7 in CNSAdapter_JavaPlugin::SetWindow () from /usr/lib/jvm/java-6-sun-1.6.0.02/jre/plugin/i386/ns7/libjavaplugin_oji.so | 05:40 |
Ubulette | #3 0xb79ea9ad in nsPluginNativeWindowGtk2::CallSetWindow (this=0x977ef58, aPluginInstance=@0xbff535e0) at nsPluginNativeWindowGtk2.cpp:144 | 05:40 |
Ubulette | pb is without java, difficult to guess | 05:40 |
Ubulette | mozilla bug 386844 | 05:46 |
ubotu | Mozilla bug 386844 in Plug-ins "Crash when running Java Applets [@ XSync - JavaPluginInstance5::SetWindow] " [Critical,Assigned] http://bugzilla.mozilla.org/show_bug.cgi?id=386844 | 05:46 |
asac | what is dpy ? | 05:51 |
asac | ah display | 05:51 |
asac | well | 05:51 |
asac | can you look at level #3 | 05:51 |
Ubulette | cool, they have a patch, not committed though. I'll merge it into trunk, if it's okay, i can backport to gp | 05:51 |
asac | ok | 05:52 |
asac | please show me the patch as well | 05:52 |
Ubulette | pretty long patch... | 05:52 |
Ubulette | https://bugzilla.mozilla.org/attachment.cgi?id=271973 | 05:52 |
asac | afaik there was even discussion about dropping java support ... forcing java to reimplement their plugin with more modern means | 05:52 |
asac | but that is probably pretty far taken | 05:52 |
asac | Ubulette: pleaes bug number | 05:52 |
Ubulette | above | 05:52 |
asac | no attachment | 05:52 |
asac | well bugnumber ;) | 05:53 |
Ubulette | <Ubulette> mozilla bug 386844 | 05:53 |
IdleOne | 386844 | 05:53 |
asac | k | 05:53 |
ubotu | Mozilla bug 386844 in Plug-ins "Crash when running Java Applets [@ XSync - JavaPluginInstance5::SetWindow] " [Critical,Assigned] http://bugzilla.mozilla.org/show_bug.cgi?id=386844 | 05:53 |
asac | Ubulette: https://bugzilla.mozilla.org/show_bug.cgi?id=386844#c19 | 05:57 |
ubotu | Mozilla bug 386844 in Plug-ins "Crash when running Java Applets [@ XSync - JavaPluginInstance5::SetWindow] " [Critical,Assigned] | 05:57 |
asac | ah ... nevermind | 05:57 |
Ubulette | ? | 05:58 |
asac | if we have luck it fixed the gtk_style_realize master crash as well | 05:58 |
asac | test totem et al please | 05:58 |
=== Admiral_Chicago_ [n=FreddyM@st074039212101.monm.edu] has joined #ubuntu-mozillateam | ||
asac | not that we buy-in crashes for them instead | 05:59 |
Ubulette | well, I fixed totem plugin independently | 05:59 |
asac | Ubulette: no ... not that crash | 05:59 |
Ubulette | so for me totem is fine in both gp and trunk | 05:59 |
Ubulette | oh, yep sure | 05:59 |
asac | please test *after* the crash i mean | 05:59 |
asac | s/crash/patch/ | 06:00 |
asac | :) | 06:00 |
Ubulette | well, I have to rebuild everything to be safe as my files were not recompiled with -nc and I had to force them | 06:22 |
Ubulette | hm, I'm good for a 45m rebuild :P | 06:24 |
asac | wierd | 06:24 |
asac | hehe | 06:24 |
asac | yeah | 06:24 |
asac | i will be off soon ... sport then meeting a friend | 06:25 |
Ubulette | could we quickly discuss nspr 1st | 06:25 |
Ubulette | ? | 06:25 |
asac | soon == 35 min | 06:25 |
asac | sure | 06:25 |
asac | do you have questions? | 06:26 |
Ubulette | package names and .so bump | 06:26 |
Ubulette | so for, I've built those: | 06:27 |
Ubulette | libnspr4-0d_4.7.0~cvs20070713-0ubuntu1_i386.deb | 06:27 |
Ubulette | libnspr4-0d-dbg_4.7.0~cvs20070713-0ubuntu1_i386.deb | 06:27 |
Ubulette | libnspr4-dev_4.7.0~cvs20070713-0ubuntu1_i386.deb | 06:27 |
Ubulette | nspr-trunk_4.7.0~cvs20070713-0ubuntu1.dsc | 06:27 |
Ubulette | nspr-trunk_4.7.0~cvs20070713-0ubuntu1_i386.changes | 06:27 |
Ubulette | nspr-trunk_4.7.0~cvs20070713-0ubuntu1.tar.gz | 06:27 |
Ubulette | should I still call the debs libnspr4 ? | 06:28 |
Ubulette | and what about -0d ? | 06:28 |
asac | i think we are backports compatible, but have new symbols/header defines | 06:29 |
asac | so we can keep -0d | 06:29 |
asac | and libnspr4 | 06:29 |
asac | but we have to check that | 06:29 |
asac | hmm | 06:29 |
Ubulette | so src pkg could drop -trunk ? | 06:29 |
asac | i think so ... yes | 06:30 |
asac | but then we have a problem | 06:30 |
Ubulette | ok | 06:30 |
Ubulette | ? | 06:30 |
asac | we almost certainly cannot ship firefox with trunk nspr ... so we cannot replace stable nspr | 06:31 |
Ubulette | why would it break firefox ? | 06:32 |
asac | s/cannot/are not allowed | don't want/ | 06:33 |
asac | maybe try nspr-trunk package that produces libnspr4-0d.trunk, which conflicts/replaces/provides libnspr4-0d | 06:34 |
asac | but ship libnspr4.so and libnspr4.so.0d (same so name) | 06:35 |
asac | so people that install paradiso will get libnspr4-0d replaced | 06:35 |
asac | but keeping main archive clean from these scary trunk things | 06:36 |
Ubulette | most people installing gp also have ff2 | 06:36 |
asac | yes ... the idea is that it doesn't crash :) | 06:36 |
asac | however we cannot ship it by default nor on cd | 06:36 |
asac | nor in main | 06:36 |
asac | maybe another idea we might wanna test is to lower version of trunk, like: | 06:37 |
asac | libnspr4-0d~trunk | 06:37 |
asac | so people will get back to stable libnspr4 if they run dist-upgrade :) | 06:37 |
asac | no idea if apt would refuse to downgrade libnspr4 if you install -paradiso | 06:37 |
asac | we would need to test | 06:37 |
asac | what do you think? | 06:39 |
asac | what soname version does debian ship atm? | 06:40 |
Ubulette | well, a lower version will never be used by gutsy users | 06:41 |
asac | he? | 06:41 |
asac | i mean ... the idea is that it gets pulled in when you install -paradiso | 06:41 |
Ubulette | so change the name, not the version | 06:41 |
asac | most likely yes | 06:42 |
Ubulette | libnspr-trunk-0d providing libnspr4-0d | 06:42 |
Ubulette | but it's not really trunk either | 06:42 |
asac | i think nspr is a tag on HEAD | 06:42 |
asac | so trunk it is somehow | 06:42 |
asac | nss is from a branch | 06:43 |
asac | i am not sure atm | 06:43 |
asac | will let you know when i return | 06:43 |
asac | maybe start with xulrunner | 06:43 |
Ubulette | this is a taggued version = frozen so it's not head | 06:43 |
asac | and don't use system-nss/nspr | 06:43 |
asac | Ubulette: yes ... but its tagged on trunk :) | 06:43 |
=== Starting logfile irclogs/ubuntu-mozillateam.log | ||
=== ubuntulog [i=ubuntulo@ubuntu/bot/ubuntulog] has joined #ubuntu-mozillateam | ||
=== Topic for #ubuntu-mozillateam: Home of Ubuntu Mozilla Team - https://wiki.ubuntu.com/MozillaTeam | Bug Triagers please read: https://wiki.ubuntu.com/MozillaTeam/Bugs/ | Firefox trunk package source : https://code.launchpad.net/~mozillateam/firefox/trunk | Mailing List: ubuntu-mozillateam@lists.ubuntu.com | Next Meeting, Monday August 20th at 20 UTC in #ubuntu-meeting | ||
=== Topic (#ubuntu-mozillateam): set by Admiral_Chicago at Wed Aug 15 18:48:45 2007 | ||
(Jazzva/#ubuntu-mozillateam) asac: Online now :/... I got carried away with short, afternoon sleep that turned out to be not so short... | 08:26 | |
(Jazzva/#ubuntu-mozillateam) I'll try to fix the strings and "get ubuntu addons" tonight... | 08:27 | |
Jazzva | asac: The string is now fetched correctly... And the mistake was too obvious. | 09:01 |
Jazzva | Off to hiding "Get Ubuntu addons" | 09:02 |
=== ubotu [n=ubotu@ubuntu/bot/ubotu] has joined #ubuntu-mozillateam | ||
=== red_herring [n=rj@c-24-14-245-251.hsd1.il.comcast.net] has joined #ubuntu-mozillateam | ||
Jazzva | Off for a while, be back in 50-60 minutes... | 10:43 |
Jazzva | asac: O | 10:43 |
Jazzva | Oops... asac, I'll need to ask you few things about XUL when I come back. I have an idea how to hide the label, but I'm not sure which approach to use. | 10:44 |
=== Admiral_Chicago [n=FreddyM@st074039212101.monm.edu] has joined #ubuntu-mozillateam | ||
asac | Jazzva: here i am | 11:30 |
Jazzva | Yay :)... | 11:30 |
Jazzva | So, here's the thing... | 11:31 |
asac | k | 11:31 |
asac | go ahead ... i will be here in 2 minutes ... got to smoke | 11:31 |
Jazzva | The event listener only catches load event, which doesn't occur on tab change... | 11:32 |
Jazzva | For example, it will occur when Add-ons dialog opens, but it won't when you switch from Extensions to Themes... | 11:32 |
Jazzva | Now, I could try to hide getUbuntuAddons label either when getMore lable has "hidden" set to "true" (that's the one that shows "Get extensions"), or when extensions-vies has "selected" set to "false"... | 11:34 |
Jazzva | And I thought of two approaches to implement this: | 11:34 |
Jazzva | The first would be through event listener, but to add some other event that will include the tab switching | 11:35 |
Jazzva | The second would be by using observers... Something like: | 11:35 |
Jazzva | In ubuntuAddonsOverlay.xul: | 11:35 |
Jazzva | <label id="getUbuntuAddons" .....> | 11:35 |
Jazzva | <observes element="getMore" attribute="hidden"> | 11:36 |
Jazzva | </label> | 11:36 |
asac | ok | 11:36 |
Jazzva | Sorry... | 11:36 |
asac | let me read ;) | 11:36 |
asac | he? why sorry? | 11:36 |
Jazzva | <observes element="getMore" attribute="hidden" onbroadcast="ubufoxCheckFile"> | 11:36 |
Jazzva | That's why :) | 11:36 |
asac | ah :) | 11:37 |
asac | welll i must admit that observers are something more or less new to me | 11:37 |
asac | if they work it might be cool | 11:37 |
Jazzva | I think that would only react when "hidden" changes state and will set the state of getUbuntuAddons label to be the same... | 11:37 |
asac | otherwise i would just use a dom mutation even listener | 11:37 |
asac | http://developer.mozilla.org/en/docs/XUL:Events#Mutation_DOM_events | 11:37 |
Jazzva | And I hope it will also check for gnome-app-install presence... | 11:37 |
asac | Jazzva: what element to you want to listen on? | 11:38 |
asac | did you already find the right one? | 11:38 |
asac | e.g. which element do you want to observe the hidden attribute on? | 11:38 |
Jazzva | on "Get extensions" label | 11:39 |
Jazzva | that is element with id="getMore" | 11:39 |
asac | ah | 11:39 |
asac | so that gets hidden? | 11:40 |
Jazzva | Well, I suppose... | 11:40 |
asac | ;) | 11:40 |
asac | try to find it with dom inspector | 11:40 |
asac | when you have themes or something selected | 11:40 |
Jazzva | Since the bottomStatusBar (or whatever is it's name :)) contains all the labels | 11:40 |
asac | if its still in the xul but hidden then its probably the right way to go | 11:40 |
asac | yeah | 11:40 |
asac | if all is in there, but just hidden then go for it | 11:40 |
asac | either by listening for dom attribute changes (and filtering those for "hidden") ... or by observer | 11:41 |
Jazzva | I tried to check it with DOM inspector, but I couldn't get it to show attributes in real time, for example, all of them had hidden="false"... | 11:41 |
asac | maybe try both and let me know about the observer mechanism | 11:41 |
asac | Jazzva: you might need to close and open dom inspector again | 11:41 |
Jazzva | Oh... ok :) | 11:41 |
asac | maybe you can even say reload in menu? | 11:42 |
asac | now smoke | 11:42 |
Jazzva | Hmm, but I loaded the Add-ons window in DOM inspector... | 11:42 |
Jazzva | Same here :)... brb | 11:42 |
Ubulette | back | 11:46 |
asac | Jazzva: do you have a local firefox build (with source tree) on your system? | 11:46 |
asac | it often helps a lot to look into the code | 11:46 |
Ubulette | ported and tested java fix on granparadiso, all fine | 11:46 |
asac | Ubulette: cool | 11:46 |
asac | Ubulette: did someone take a look at your totem patch already? | 11:48 |
asac | and forward upstream? | 11:48 |
Jazzva | Hello Ubulette... | 11:50 |
Jazzva | asac, no, I don't... I thought about that... To look into extensions.xul... Ok, I'll download it now... | 11:50 |
Ubulette | got no feedback whatsoever | 11:51 |
Ubulette | good or bad | 11:51 |
asac | we maintain a git branch that tracks upstream 1.8 branch | 11:51 |
asac | Jazzva: ^^ | 11:51 |
asac | maybe branch that one | 11:51 |
Jazzva | Hmm... ok | 11:51 |
asac | http://git.debian.org/?p=pkg-mozilla/upstream.git;a=summary | 11:52 |
asac | mozilla-1.8 branch is the one tracking pristine upstream 1.8 (2.0) | 11:52 |
asac | it contains more than just firefox, but to get the source its pretty nice ... and simpler | 11:52 |
Ubulette | ? what is it for ? | 11:56 |
Jazzva | What do I use to download a git repo? I installed git package, but there seems to be no git command :/ | 12:07 |
Ubulette | you have /usr/bin/git | 12:08 |
Ubulette | or tons of git-xxx | 12:08 |
Ubulette | it's in git-core | 12:09 |
Jazzva | Oh, thanks :) | 12:10 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!