=== Starting logfile irclogs/ubuntu-mozillateam.log === ubuntulog [i=ubuntulo@ubuntu/bot/ubuntulog] has joined #ubuntu-mozillateam === Topic for #ubuntu-mozillateam: Home of Ubuntu Mozilla Team - https://wiki.ubuntu.com/MozillaTeam | Bug Triagers please read: https://wiki.ubuntu.com/MozillaTeam/Bugs/ | Firefox trunk package source : https://code.launchpad.net/~asac/firefox/trunk | Mailing List: ubuntu-mozillateam@lists.ubuntu.com | === Topic (#ubuntu-mozillateam): set by Admiral_Chicago at Sun Jun 24 10:33:47 2007 === Admiral_Chicago_ [n=FreddyM@st074039212101.monm.edu] has joined #ubuntu-mozillateam === Admiral_Chicago_ [n=FreddyM@st074039212101.monm.edu] has joined #ubuntu-mozillateam === Admiral_Chicago_ [n=FreddyM@st074039212101.monm.edu] has joined #ubuntu-mozillateam === jbs [n=Bernardo@89.181.211.185] has joined #ubuntu-mozillateam [08:46] asac, there is another package I prepared few weeks ago. I've uploaded it to bazaar, you can see it at https://code.launchpad.net/~jazzva/fakenes/ubuntu [08:46] asac, that is if you have some free time to take a look at it :). Thanks... === Bernardo [n=Bernardo@sourcemage/Bernardo] has joined #ubuntu-mozillateam === shirish [n=shirish@59.95.37.118] has joined #ubuntu-mozillateam === shirish [n=shirish@59.95.37.118] has left #ubuntu-mozillateam ["Leaving."] [10:16] Jazzva: there? [10:18] asac: Yep, will just go to make a coffee... be back in a minute... [10:19] oh coffee ... good point ;) [10:21] asac: Always ;)... Back [10:22] well ... now I am brewing coffee ;) [10:22] ok wait ... so ubufox is available [10:22] aeh sorry ... i mean a plugin finder service so one can look at the latest ubufox features is available [10:23] Hmm... you "beautified" it :)? [10:23] no ... i fixed things that were still broken :) [10:23] Oh, ok :)... [10:23] ... made it work flawless i hope [10:23] can you test if it works for you as well? [10:23] Can I help with it? (though, I never wrote anything in python) [10:23] Hmm, sure... [10:24] cool ... to take a look you just need the latest ubufox from bzr [10:24] (the upstream branch not the debian/ubuntu one) [10:24] Just to download it :)... [10:25] cool [10:25] and you need to tweak the pfs.datasource url preference [10:25] i think its kind of url lik people.ubuntu.com/~asac/.... [10:26] upstream == main? [10:26] ---> jxtaim.dyndns.org/~alex [10:26] Jazzva: yes [10:26] Ok :) [10:26] the one without debian directory< [10:26] the one you worked on ;) [10:27] ...and there was I, wondering why there's no debian/ :lol:... [10:27] hehe [10:27] I'm stupid :) [10:28] no ... stupid is something else ;) [10:28] Where do I set pfs.datasource? [10:29] grep? :) [10:29] goto about:config [10:29] then search pfs [10:29] (do it manually in firefox) [10:29] Ok :) [10:29] is there people.ubuntu.com already set at all ? or is it still pfs.mozilla.org? [10:31] The first one [10:31] :) [10:31] But it seems wrong [10:31] http:///people... [10:31] good ... replace people.ubuntu.com -> jxtaim.dyndns.org [10:31] yes ;) [10:31] Note the three backslashes (or are they slashes?) [10:32] and asac -> alex :) [10:32] yes i already know :) [10:32] Replaced [10:33] Jazzva: ok [10:33] when you have it installed there are test html pages [10:33] in pfs/test/ [10:33] Ok [10:33] (in ubufox tree) [10:35] ok i pushed revision 34 (which fixes the triple-slash) [10:35] not worth an update though ;) [10:35] Do I need to uninstall the flash plugin first? :) (but I don't think that it's installed in gutsy :/) [10:35] Oh, there's a search in second test :) [10:36] yes for movie [10:36] Nice :D [10:36] And you know about the label not showing up? [10:37] &pluginWizard.availablePluginsPage.description.label; (video/mpeg) [10:37] Instead of something like "Choose plugin..." (I suppose) [10:38] Hmm, here's the report [10:38] Well, all codecs fail installation (it's not implemented yet?)... [10:39] huh? [10:39] codecs? [10:39] ah you are on feisty? [10:39] Plugins :)... [10:39] you need apturl package from gutsy [10:39] you can just apt-get source it and build it in feisty [10:39] Well, yes, but I'm running firefox from chroot... though profile dir is shared with feisty [10:39] it hasn't much dependencies [10:39] Jazzva: then try install apturl package [10:40] Installing.. [10:40] and yes ... that plugin wizard needs to be beautified .... [10:40] 1st: the title needs to be fixed [10:41] 2nd: the choice box needs to be CSSed (so its white background) [10:41] 3rd: icons/images should be displayed for each result [10:42] There is another thing. There are three different plugins, the gxine is selected as default. But, if you leave it as is it is and click "Next", the mplayer-plugin is installed instead... [10:43] yeah thats a bug [10:43] i forget to set some variable when preselecting it [10:43] actually i think we should drop the "no plugin for content type choice" [10:43] And clicking "Cancel" on "Do you want to install..." returns me to the wizzard and shows that the plugin is installed :/... [10:43] however we word it ... it might confuse users [10:44] huh? [10:44] maybe its installed ? [10:44] so cancel in "apturl" dialog? [10:44] Yes, that one... [10:45] yes ... that is an apturl bug, because it doesn't have a good exit coe [10:45] code [10:45] you can fix it by editing /usr/bin/apturl [10:45] its just a sys.exit(2) where the "Cancel" is processed [10:45] dia.format_secondary_text(body) [10:45] res = dia.run() [10:45] if res != gtk.RESPONSE_YES: [10:45] sys.exit(2); [10:45] thats what my version has [10:46] (which allows us to see if install fails) [10:46] Ok... [10:46] i think sys.exit(2) is currently continue [10:47] Hmm, wouldn't know... But mine has "continue" instead of "sys.exit(2)" [10:49] Yep, changing it to "sys.exit(2)" corrects the problem. [10:50] good [10:50] So far the installation goes nice... [10:50] i asked mvo ... he will fix it [10:50] Downloading the packages... [10:50] (just to check if everything will go nice) [10:51] Off for a smoke... brb [10:52] ok nice [11:01] Everything went well :)... [11:01] asac ^ [11:01] cool [11:01] at best uninstall the package again :) ... so you can later test something ;) [11:02] K... [11:03] ok in createPluginSetGroupBox ... we need to use this.getFormattedString [11:03] instead of just setting &....; to labe [11:04] as xml entities will not be parsed if just inject them by javascript [11:04] (in pluginInstallerWizard.js) [11:06] Just a wild guess (based on C and stuff). Couldn't we just use something like: ("label", &...; + " (" + mimetype + ")")? [11:07] or is that this.getFormattedString(&...)+...? [11:07] :) === asac_ [n=asac@debian/developer/asac] has joined #ubuntu-mozillateam [11:10] (in pluginInstallerWizard.js) [11:10] [11:06] Just a wild guess (based on C and stuff). Couldn't we just use something like: ("label", &...; + " (" + mimetype + ")")? [11:10] [11:07] or is that this.getFormattedString(&...)+...? [11:10] [11:07] :) [11:11] oh right ... was off [11:11] Well, it seems we can't... it searches for plugins forever... [11:11] its getFormattedString [11:11] there are examples in code [11:11] huh? [11:12] Well, I replaced the "&...;"+... with &...+";"+ [11:12] Just to get the string stored in label variable... [11:12] no that won't help [11:12] But it's not working... [11:12] if you put that stuff in xul its expanded by xml parser [11:13] but if you inject elements into dom tree ... parser is not used anymore ... so we have to resolve the string programmatically bin javascript [11:14] ...and that is done by getFormattedString? [11:14] yes ... getString gives you translated entity ... getFormattedString allows you to get translated + substitution [11:14] i think we just need getString() + "(" + mimetype +")" [11:14] Ok, I'll give it a try now [11:15] BTW, as for the first option [11:15] Maybe we could set it as last [11:16] And rename it to "Don't install any plugin" or something.. [11:16] haha [11:16] no the problem will go on [11:16] we have to properly select whatever we select [11:16] ah [11:16] yes [11:16] I meant for the "no plugin..." [11:16] :) [11:16] sorry mixed things up [11:16] No prob... [11:16] well ... its not that simple [11:17] point is: if you have multiple content types on one page and you press the "install missing plugins ..." button [11:17] the idea is to allow users to install plugin for each missing content type [11:17] "Don't install any plugin" would imply that user doesn't want anything for other content types as well [11:18] "Don't install this plugin" :)? [11:18] ... which is already served perfectly well with "cancel" :) [11:18] i think its too hard to understand for normal users [11:18] Hm, is there a wizard launched per plugin? [11:18] right wording would be like it is: "don't install plugin for content type XXX" [11:18] Or one wizard to bound them? :) [11:18] Jazzva: no there should be multiple wizard pages [11:18] e.g. first you select which plugin you want for which content type ... in the end everything gets installed [11:19] Oh, I see :)... [11:19] currently its broken ... but that doesn't need to be fixed for feature freeze [11:19] its broken for plain upstream wizard as well [11:19] so we can deal later with that ,) [11:19] Ok... [11:39] Hmm.. not working :/. I tried with "this.getString(pluginWizar...)+..", but it didn't work. Then with "getString(&...", which also didn't work... [11:40] I took a look at MDC reference for getString, and it says that I need key for string... I supposte that's "pluginWizard...label". [11:40] you need to use the string [11:40] look at other examples in the same file [11:41] yes [11:41] thats the yes [11:41] s/yes/key/ [11:42] Damn... Ok, trying to find (with very little knowledge of JS and XUL (next to nothing) :)) why it doesn't work. Wish me luck... [12:00] Jazzva: he? [12:01] asac: Nvm :)... [12:01] Jazzva: just try getString() first [12:01] if that works see formatted string [12:01] this.getString("pluginWizard...") ... doesn't that work? [12:01] Hmm... That's not working :) [12:01] what happens? [12:01] Oooh... I need quotes :) [12:01] yeah ... i already pointed that out [12:01] above :) [12:02] oh ... no i wanted to point out but since you [12:02] 11:40 < Jazzva> I took a look at MDC reference for getString, and it says that I need key for string... I supposte that's "pluginWizard...label". [12:02] i thought you use "" :) [12:02] Oh... No, I use them here when I want to write something that is part of the code :). [12:04] yeah i noticed that now [12:07] Well, here's the result [12:07] "Press Next to install these plugins" [12:07] === Jazzva pressed Next [12:07] "No plugins were installed." === Jazzva pressed Finish [12:09] ok [12:10] Jazzva: [12:10] statMsg = this.getString("pluginInstallation.complete"); [12:10] this is known to work [12:11] And then to use "setAttribute("label", statMsg+...);"? [12:11] if you use that it works? [12:11] I'll try now :)... [12:11] and if you place the entitiy-id with the one we wnat it doesn't ? [12:11] s/place/replace/ [12:13] Nope, it doesn't... [12:15] what doesn't work? [12:15] if you use this this.getString("pluginInstallation.complete") ? [12:16] No, I tried to use "labelMsg = this.getString("pluginWizard...");" (the one that was supposed to be used as label text), but that didn't work. I'll test it with "pluginInstallation.complete" [12:17] try this.getString("pluginInstallation.complete") ... if that works we have to add something [12:22] Does this look good: [12:22] caption.setAttribute("label", "; this.getString("pluginInstallation.complete")+"; ("+mimetype+")"); [12:22] ? [12:24] no [12:24] ";? :) [12:24] you have mesed up quotes + ; [12:24] ; are only at end of line [12:24] I see it now... [12:25] I'm stupid... but this morning, I'm enormously stupid... *smacksheadagainstwall* [12:25] hehe [12:25] if it works you will remember ;) [12:27] caption.setAttribute("label", this.getString("pluginInstallation.complete")+"; ("+mimetype+")"); [12:28] Ok, I supposed that this one is good, but no... [12:28] well ... that might work ... is the ; in the mids of the string is intentional? [12:29] Yes, it's the way it was in the star [12:29] *start [12:29] k [12:29] But it's not working... [12:29] try an window.alert("test: "+this.getString("pluginInstallation.complete")); right before that line [12:32] Jazzva: the ; in the mids of the string was just there because i copied the whole xml entity expression [12:32] which ends with ; [12:32] Hmm, no alert :/... [12:32] &key.id; .... thats replaced by an entity when xmp parser sees it [12:32] Jazzva: you have messed something else up most likely [12:32] introspect your changes with bzr diff [12:32] I suppose... [12:33] maybe you accidentially inserted something you didn't want [12:33] This is the only thing: [12:33] var caption = document.createElement("caption"); [12:33] - caption.setAttribute("label", "&pluginWizard.availablePluginsPage.description.label; ("+mimetype+")"); [12:33] + window.alert("test: "+this.getString("pluginInstallation.complete")); [12:33] + caption.setAttribute("label", this.getString("pluginInstallation.complete")+"; ("+mimetype+")"); [12:33] gbox.appendChild(caption); [12:34] Hmm, I'll try without concatenating func result with other strings... [12:34] Dunno if that'll change anything [12:39] Still the same... :/ [12:39] wierd [12:39] Maybe something went wrong with the uninstallationof plugin :/ [12:39] what function is that code in? [12:39] try to open alert with just this ... to see if its set at all [12:40] just "..." + this); [12:40] function createPluginSetGroupBox (document, mimetype, aPluginInfoSet) [12:40] ok [12:40] this is not set there [12:40] add a parameter "self" to that function [12:40] and pass this into that from the caller [12:40] wait [12:41] just rename the fuction like below: [12:41] nsPluginInstallerWizard.prototype.showPluginList = function () { [12:41] and call it with this.createPluginSetGroupBox instead of just createPluginSetGroupBox [12:41] then this will be set [12:42] Umm, so "nsPlug...prototype.createPlug..."? [12:42] because the function becomes an "instance" function [12:42] yeah [12:42] its the way Object-Orientation is done in javascript :) [12:43] Riiight :)... Will have to read up on that, I see :) [12:45] It works :)... [12:45] So, just to check if I got your point :)... [12:46] nsPluginInstallerWizard is an object [12:47] and "function createPluginSetGroupBox" isn't a method of that object (obviously) [12:47] But I still used "this" to reference to the object, which was wrong [12:47] right? [12:50] yes [12:50] which didn't exist [12:50] because your scope was "outside" of the object [12:50] objects implicitly define "this" variable [12:51] createPluginSetGroupBox was just a plain old function [12:51] now its a method of that object [12:51] Just like in C++ [12:51] :) [12:53] It's not working with "this.getString("pluginWizard.availablePluginsPage.description.label")" though :/... You sure that key exists? [12:53] Oh, lemme check with window.alert () :) [12:56] Hm, no alert window :/... [12:56] Does that mean that we should add it to locale/../ubufox.dtd? [12:57] But we can't since it's a plugin name? [12:57] Or is it some generic text like "Choose plugin"? [12:59] probably it doesn't exist then [01:00] maybe it needs to be in a properties file [01:00] Jazzva: try to add it to ./locale/en-US/ubufox.properties [01:00] then include that properties file in pluginfinderWizard.xul [01:01] Ok... [01:02] i think you have to extend [01:02] [01:02] [01:02] [01:02] [01:02] [01:02] Ok [01:02] with a ubufox/locale/plugins.properties ... and add that to locale/en-US [01:02] with the key you want [01:02] like [01:02] key.id=value [01:02] value gets no quotes [01:03] But there is already ubufox.properties... Why don't I just add to that one? [01:03] sure [01:03] :) [01:04] i have to do a break ... this "wrong plugin selected without click problem" twists my mind a bit ;) [01:04] How does "ubufox.pluginfinder.availableplugins.label" sound? [01:04] Or just ".available." [01:06] well [01:06] lets use ubufox.pluginWizard.availablePluginsPage.description.label [01:07] Ok... [01:07] just prepend the entities we overload from current pfw [01:08] How do I find the chrome url? Is the right one "chrome://ubufox/locale/ubufox.properties"? [01:08] uri... [01:10] Never mind :).. [01:13] Jazzva: you can test chrome urls in firefox location bar [01:13] e.g. chrome://ubufox/content/pluginFinderWizard.xul [01:13] And define them in chrome.manifest :) [01:13] should show you the wizard embedded in browser window ;) [01:13] same for .js and css and dtd and whatever file [01:14] o its already pretty cool [01:14] http://people.ubuntu.com/~asac/Screenshot-Plugin%20Finder%20Service-1.png [01:14] now fix title [01:15] then i think we are done for feature freeze [01:15] we can make a table out of the choice box during freeze i guess ... as its just "layout" [01:15] ah maybe we want an agenda? [01:15] e.g. so users understand what those icons mean? [01:16] e.g the globe: installs from internet [01:16] the ubuntu sign: ubuntu managed package [01:16] It's pretty :) [01:17] its prettier when run outside chroot [01:17] with an actual gnome theme :) [01:17] but since i have amd64 i don't get any internet result there that would show the globe [01:18] hmmm maybe we want to remove the frame border around the choice box [01:18] and just put a title [01:19] Hmm... It would be ok [01:19] :) [01:20] that would remove the GetString() again ... it was in xul before ... hmm [01:20] Lol... [01:22] Jazzva: for now just make a vbox out of the groupbox in createGroup thing [01:22] that will remove the border [01:22] Umm... ok [01:22] :) [01:23] let me know when you are done [01:23] i will look if i can split up the work i did now in multiple commits and then merge in your changes [01:23] Mhm... [01:23] :) [01:29] Hmm, it says that it's not well-formed uri: chrome://ubufox/locale/ubufox.properties [01:29] In this tag: [01:29] [01:29] well look closer ;) [01:29] the problem is in that line [01:29] itsnot well-formed ;) [01:30] Damn... [01:30] I hate this day... and quotes :) [01:30] should be too obvious to see by oneself :) [01:30] Yes, it is... [01:31] have you tried if chrome://ubufox/locale/ubufox.properties is ok (in location bar) ? [01:31] It is [01:31] I have tried, it listes the strings... [01:31] pleae commit the groupbox -> vbox change in a separate checkin ;) [01:31] then fine [01:31] Sure :)... [01:32] if that works you probably want to use formatted string [01:32] syntax examples should be available in ubufox.properties [01:33] Ok... but the plugin finder is not working with this added string :/... [01:33] Is it a problem if I go and get something to eat, and to continue fixing after? :) [01:33] In about ... 20-30 minutes... [01:34] no [01:34] go ahead [01:34] And maybe I'll stop making the missing-quotes errors after brunch :)... [01:35] Ok, see you later [02:05] Back... Will try to correct the problem with message now and to change gbox to vbox. [02:07] Jazzva: thanks [02:07] Jazzva: there is one more feature request [02:08] the Get Addons link should only be displayed when we are in the extensions tab for now [02:08] you probably have to search elements for some specific element id or label or something to figure out, which is currently active [02:08] you should be able to find that using dom inspector [02:09] I thought of that too... [02:09] I noticed that it appears when you need to restart firefox after installation of extensions, which didn't make much sense... [02:14] right [02:14] it appears in every tab [02:14] (which is the root issue) [02:14] cool i fixed the multi content type case [02:15] well at least the UI [02:15] Weee :) [02:16] cool it just works [02:16] lets test cancel szenarios [02:16] Hmm, what's the difference between dtd and properties file? I can't find info right now on Google and MDC doesn't work well right now :/... [02:16] e.g. user cancels first install ... is second one still tried? [02:16] well .dtd is a xml mechanism ... [02:16] among other things you can specify entities which are then replaced when xml document is parsed [02:16] you mark entities with &...; [02:17] properties is just a mapping file [02:17] nothing more [02:17] so if you want to localize i nxul you need .dtd [02:17]