=== tehk [n=tehk@c-69-249-157-157.hsd1.nj.comcast.net]  has joined #ubuntu-x
[01:06] <tormod> good night
=== tormod [n=tormod@80-219-112-71.dclient.hispeed.ch]  has left #ubuntu-x ["Ex-Chat"] 
[01:25] <ubotu> New bug: #140820 in xserver-xorg-input-synaptics (main) "synaptics touchpad won't left click, right click, or vscroll after recent change in gutsy" [Undecided,New]  https://launchpad.net/bugs/140820
[01:31] <ubotu> New bug: #38498 in xserver-xorg-video-ati (main) "xorg does not preserve acpi/ibm/video mode" [Medium,Incomplete]  https://launchpad.net/bugs/38498
[01:31] <ubotu> New bug: #38653 in xserver-xorg-video-ati (main) "[RV350]  Permanent resolution degradation after external CRT usage" [Medium,Incomplete]  https://launchpad.net/bugs/38653
[02:05] <ubotu> New bug: #39684 in xserver-xorg-video-ati (main) "Screen wents blank on system beep" [Medium,Incomplete]  https://launchpad.net/bugs/39684
[02:31] <ubotu> New bug: #41357 in linux-restricted-modules-2.6.15 (restricted) "TV-OUT no longer works" [Medium,Incomplete]  https://launchpad.net/bugs/41357
[02:36] <ubotu> New bug: #41244 in linux-restricted-modules-2.6.15 (restricted) "Fritz!Card PCMCIA driver does not work" [Medium,Incomplete]  https://launchpad.net/bugs/41244
[02:46] <ubotu> New bug: #41845 in linux-restricted-modules-2.6.15 (restricted) "nvidia xorg driver stopped working when upgrading to dapper" [Medium,Incomplete]  https://launchpad.net/bugs/41845
[03:00] <ubotu> New bug: #42248 in xserver-xorg-input-synaptics (main) "[Dapper]  Can not turn off touch tapping on Alps touch pad" [Medium,Incomplete]  https://launchpad.net/bugs/42248
[03:00] <ubotu> New bug: #140836 in xserver-xorg-video-intel (main) "latest xserver-xorg-video-intel breaks desktop effects" [Undecided,New]  https://launchpad.net/bugs/140836
[03:05] <ubotu> New bug: #42445 in xserver-xorg-video-ati (main) "Cannot change screen resolution. refresh rate" [Medium,Incomplete]  https://launchpad.net/bugs/42445
[03:11] <ubotu> New bug: #43413 in xserver-xorg-video-ati (main) "strange striped screen" [Medium,Incomplete]  https://launchpad.net/bugs/43413
=== tehk [n=tehk@c-69-249-157-157.hsd1.nj.comcast.net]  has joined #ubuntu-x
[05:45] <ubotu> New bug: #45474 in xserver-xorg-input-synaptics (main) "touchpad kills keyboard and itself" [Medium,Incomplete]  https://launchpad.net/bugs/45474
[06:01] <ubotu> New bug: #46934 in xserver-xorg-input-synaptics (main) "Touchpad Scrolling on Laptop Samsung X20" [Medium,Incomplete]  https://launchpad.net/bugs/46934
=== Q-FUNK [n=q-funk@dsl-hkibrasgw1-ff19c100-129.dhcp.inet.fi]  has joined #ubuntu-x
=== tehk [n=tehk@c-69-249-157-157.hsd1.nj.comcast.net]  has joined #ubuntu-x
[08:22] <tepsipakki> yay, there goes a new ati... uploaded
[08:22] <tepsipakki> s/a/the/
[08:23] <tepsipakki> and a new nvidia blob released
[08:25] <tepsipakki> adds support for quadro fx 570 among other things.. and the stinkpad T61p which I'll get in a week or so has one..
[08:40] <bryce> heya
[08:41] <tepsipakki> hi, I uploaded the new ati
[08:41] <tepsipakki> hobbsee and pitti ack'ed it
[08:42] <bryce> awesome
[08:42] <bryce> yeah I talked with hobbsee earlier about it
=== seb128 [n=seb128@ubuntu/member/seb128]  has joined #ubuntu-x
=== seb128_ [n=seb128@ANancy-151-1-113-50.w90-13.abo.wanadoo.fr]  has joined #ubuntu-x
=== mvo [i=egon@nat/canonical/x-f597534000592247]  has joined #ubuntu-x
=== mvo [i=egon@nat/canonical/x-50f0a08b12f37860]  has joined #ubuntu-x
[11:06] <ubotu> New bug: #140904 in xorg (main) "Mouse set up suboptimal in vmware VM." [Undecided,New]  https://launchpad.net/bugs/140904
=== mvo [i=egon@nat/canonical/x-98bf37136636594b]  has joined #ubuntu-x
=== mvo [i=egon@nat/canonical/x-94fd3a31dbadef02]  has joined #ubuntu-x
=== mvo [i=egon@nat/canonical/x-812101a953be07c3]  has joined #ubuntu-x
=== tormod [n=tormod@138.131.206.233]  has joined #ubuntu-x
=== seb128 [n=seb128@ubuntu/member/seb128]  has joined #ubuntu-x
[11:50] <tormod> tepsipakki, your new stinkpad: you'll get hands-on with bug #138718 then.
[11:50] <ubotu> Launchpad bug 138718 in xorg "gdm greeter crashes when X is using vesa driver" [Undecided,New]  https://launchpad.net/bugs/138718
[12:53] <tepsipakki> tormod: great, sounds fun :)
[01:33] <tormod> bryce, does discover guess around if it doesn't find a full pci id match?
=== mvo [i=egon@nat/canonical/x-4c64cf2d99647b0d]  has joined #ubuntu-x
=== TomaszD [n=tom@unaffiliated/tomaszd]  has joined #ubuntu-x
[03:23] <TomaszD> tormod, ?
[03:23] <tormod> are you able to identify what change made the sis driver work?
[03:24] <TomaszD> according to the sis gitlog, there weren't that many changes 0.9.3 -> current, but no, I can't
[03:25] <TomaszD> it just started working flawlessly and even a bit quicker than in feisty, so I'm all happy
[03:25] <tormod> if we can backport the needed change into Gutsy, everybody will be happy :)
[03:25] <TomaszD> however, it would be nice to include a proper fix for gutsy, we can't expect people to compile drivers :] 
[03:26] <TomaszD> yeah, that would be nice
[03:26] <TomaszD> however I'm just a translator with some compiling experience, but by no means a dev, I write articles about Ubuntu for money, not programs :] 
[03:27] <tormod> if you already can compile, and have a sis card to test, you can be very useful
[03:29] <TomaszD> tormod, cool, I'm here if need be
[03:29] <tormod> there are not many git changes since 0.9.1, shouldn't be too difficult to narrow it down
[03:29] <TomaszD> exactly
[03:30] <TomaszD> you mean 0.9.3 right? this is the version gutsy has
[03:32] <TomaszD> tormod, ? 
[03:32] <tormod> TomaszD: yes I guess so :)
[03:32] <TomaszD> ok
[03:33] <tormod> did you try just recompiling the gutsy package as well?
[03:33] <tormod> anyway what is the bug report number?
[03:33] <TomaszD> tormod, but the gitlog got me thinking that quite possibly the original package just needs a recompile
[03:34] <TomaszD> https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-sis/+bug/118325
[03:34] <ubotu> Launchpad bug 118325 in xserver-xorg-video-sis "sis dri DDX interface outdated" [Medium,Triaged]  
[03:34] <TomaszD> brb
[03:39] <tormod> maybe it just needs "Define SIS_*_VERSION using PACKAGE_VERSION*"
[03:54] <tormod> TomaszD: with beta-freeze tomorrow, today is a good day to sort this out :)
[03:56] <tormod> or it needs "Get rid of the XFree86Server macro." but I just keep guessing here. I'll need to look at the code later.
[04:00] <TomaszD> tormod, holy crap
[04:00] <TomaszD> tormod, how do I re-compile the ubuntu package?
[04:00] <TomaszD> damn it, brb
[04:01] <tormod> TomaszD: see Building Drivers on https://wiki.ubuntu.com/XorgOnTheEdge
[04:10] <ubotu> New bug: #140984 in xorg (main) "X server crashes reproducably with vnc viewer for java (4.0) via firefox" [Undecided,New]  https://launchpad.net/bugs/140984
[07:09] <ubotu> New bug: #140880 in xserver-xorg-input-keyboard (main) "Swedish keyboard is not working - gutsy" [Undecided,New]  https://launchpad.net/bugs/140880
[07:15] <bryce> tormod, I don't think that discover guesses around, but the xserver postinst script isn't shy about making bold guesses if it has incomplete info
[07:16] <tormod> bryce: are you sure there are no default to nv for a "default nVidia card" or similar?
[07:17] <bryce> it may, I'm not sure there
[07:17] <tormod> bryce: re bug #133385, I can not see the pci id in discover-data, but it chooses nv
[07:17] <ubotu> Launchpad bug 133385 in xserver-xorg-driver-nv "[gutsy]  "nv" is not new enough to support my chipset (Quadro FX 570M), but is detected as the most appropriate display driver during installation" [Undecided,Confirmed]  https://launchpad.net/bugs/133385
[07:18] <bryce> like, if it knows its an nvidia pci-id but doesn't match the model number, it'd probably be safe for it to guess -nvidia
[07:19] <tormod> bryce: how do I patch discover-data correctly? is .lst generated from .xml or visa versa?
[07:19] <bryce> .xml is the thing to update
[07:20] <bryce> then run `make pci-26.lst pci.lst`
[07:24] <tormod> what would the canonical model_name be? what I get from http://pci-ids.ucw.cz ?
[07:25] <bryce> You can try looking them up on the discover-data sourceforge website, however if it's not already in the .xml it's likely not to be on that website
[07:26] <bryce> I don't know that there is a programmatic way to get the name... maybe from dmesg?  worst case, if you have the packaging for the product, or can look it up on the manufacturer website, that would give a suitable name
[07:26] <bryce> you can submit missing pciid mappings through the pciid sourceforge project page; they will sanity check the names
[07:27] <bryce> sorry, Isaid 'discover data sourceforge website', I meant pciid sourceforge website
=== TomaszD [n=tom@unaffiliated/tomaszd]  has joined #ubuntu-x
[07:40] <TomaszD> tormod, sorry for leaving for so long, but I had major issues with my wireless router
[07:40] <tormod> bryce: so I run `make pci-26.lst pci.lst` before I rebuild the source package?
[07:40] <bryce> yup
[07:41] <TomaszD> tormod, I'm gonna try recompiling the gutsy sis package if you can guide me how to do that
[07:41] <TomaszD> ah, just noticed the link in the log
[07:42] <bryce> TomaszD: I suspect that your issue may not be an issue in the packages themselves, but rather could be due to mixing self-compiled packages with ones from the ubuntu repos
[07:42] <tormod> bryce: that failed: xml.sax._exceptions.SAXParseException: pci-device.xml:35150:2: mismatched tag
[07:42] <tormod> bryce: he was using repo packages. His own works.
[07:43] <TomaszD> yep.
[07:43] <bryce> ah, then maybe we simply need to put in a rebuild request for one of the packages (-sis?) in the repository
[07:43] <TomaszD> it's worth a try
[07:44] <TomaszD> there doesn't seem to be any major changes between the git version and the ubuntu version, only some minor cleanups
[07:45] <bryce> yup
[07:45] <tormod> bryce: I just missed a / in the xml. "make" works now.
[07:45] <bryce> also I ran across a similar error someone saw, but not with -sis and not on ubuntu.  The issue in that case was just needing to rebuild one of the packages
[07:46] <bryce> tormod, luv xml
[07:46] <TomaszD> bryce, so will you do it? :] 
[07:46] <bryce> tormod, kylem and I are thinking we should rip all that data out of the xml discover-data package and create a new thing, maybe more flatfile-ish
[07:47] <tormod> bryce: and we'll have discover2 as well :)
[07:47] <tormod> or discover-3 or whatever
[07:47] <bryce> yup, -3
[07:48] <TomaszD> a rebuild won't hurt and may certainly help
[07:48] <bryce> TomaszD: one sec
[07:48] <bryce> keescook: would you mind kicking a rebuild for xserver-xorg-video-sis?
[07:49] <bryce> keescook: it hasn't gotten updated in a while, and we think there's an abi mismatch that should resolve if it is just rebuilt against current gutsy libs
[07:50] <jcristau> an abi mismatch?
[07:50] <TomaszD> yes, SiS DRI driver expected DDX version 0-0.8.x but got version 0.7.1
[07:54] <jcristau> 391dad44fa305be4cded31cf2f9a4fba7420af99 would fix that afaics
[07:58] <jcristau> #if XORG_VERSION_CURRENT >= XORG_VERSION_NUMERIC(6,8,99,900,0) isn't going to be true just because the driver gets rebuilt
[08:00] <tormod> bryce: I made a debdiff for 133385. Can you bless it?
[08:01] <tormod> TomaszD: would you be able to try out the gutsy version with the patch from http://cgit.freedesktop.org/xorg/driver/xf86-video-sis/diff/?id=391dad44fa305be4cded31cf2f9a4fba7420af99 ?
[08:01] <bryce> tormod, certainly
[08:03] <TomaszD> tormod, after supper, but I don't know how to apply patches
[08:03] <TomaszD> brb
=== tehk [n=tehk@c-69-249-157-157.hsd1.nj.comcast.net]  has joined #ubuntu-x
[08:09] <ubotu> New bug: #121906 in xorg (main) "Gutsy Tribe 1 installer does not configure X to use ATI driver for ATI All-In-Wonder Radeon 8500 DV (R200 chipset)" [Medium,Incomplete]  https://launchpad.net/bugs/121906
[08:11] <tormod> keescook: can you sponsor 133385 please?
[08:12] <keescook> tormod: sure, I'll look in a second, just finishing some email now
[08:15] <ubotu> New bug: #141043 in xrandr (main) "xrandr doesn't work with non-rectangular display" [Undecided,New]  https://launchpad.net/bugs/141043
=== tehk [n=tehk@c-69-249-157-157.hsd1.nj.comcast.net]  has joined #ubuntu-x
[08:19] <tormod> TomaszD: I explained how to patch and build in the bug report.
[08:21] <TomaszD> tormod, thanks
[08:26] <TomaszD> patching...
[08:27] <TomaszD> compiling...
[08:30] <TomaszD> built, installed, reloding session, keep your fingers crossed
[08:31] <keescook> tormod: thanks, uploaded.
=== TomaszD [n=tom@unaffiliated/tomaszd]  has joined #ubuntu-x
[08:32] <TomaszD> tormod, direct rendering: Yes
[08:32] <tormod> TomaszD: great
[08:32] <TomaszD> either the patch worked or just the rebuild worked :] 
[08:32] <tormod> bryce, I'll make a debdiff for it
[08:33] <bryce> awesome
[08:34] <jcristau> TomaszD: there's no way a simple rebuild would have changed anything...
[08:34] <TomaszD> jcristau, if you say so :]  I'm just guessing
[08:36] <TomaszD> apt wants to update that package now, from version 1:0.9.3-2 to... 1:0.9.3-2, so the same version
[08:36] <TomaszD> interesting :] 
[08:37] <tormod> TomaszD: nothing to care about, it just prefers packages from the repo.
[08:37] <TomaszD> ah ok
[08:37] <tormod> bryce: debdiff attached, can you bless it?
[08:38] <bryce> bug id?
[08:38] <jcristau> i guess i should update the debian package to git master... but it seems nobody uses sis :)
[08:38] <jcristau> bryce: bug 118325
[08:38] <ubotu> Launchpad bug 118325 in xserver-xorg-video-sis "sis dri DDX interface outdated" [Medium,Triaged]  https://launchpad.net/bugs/118325
[08:39] <tormod> jcristau: the one user is on Ubuntu :)
[08:39] <TomaszD> lol
[08:39] <bryce> jcristau, have you heard of a bug on 965 with display artifacts or lockups after xrandr -o 1?
[08:39] <TomaszD> people use them, but they don't care about dri
[08:39] <TomaszD> probably don't even know what dri is
[08:40] <tormod> only a few of the sis cards runs DRI anyway
[08:40] <TomaszD> true
[08:40] <TomaszD> I get mind boggling 230FPS in glxgears
[08:41] <TomaszD> :] 
[08:42] <tormod> TomaszD: that makes it worth the effort :) It's in gusty now - thanks keescook.
[08:43] <TomaszD> thanks everyone, glad it made through before beta freeze :] 
[08:43] <bryce> tormod: done
[08:43] <bryce> good work you two :-)
[08:43] <tormod> oops it's not in yet - that was the other debdiff...
[08:44] <keescook> oop, did I miss something?
[08:44] <tormod> keescook: can you sponsor #118325 please?
[08:47] <keescook> tormod: sure, building now
[08:47] <tormod> keescook: thanks!
[08:49] <jcristau> bryce: not that i remember
[08:50] <bryce> yeah I can't find a bug report on it at fdo other; I'll submit a new one
[08:50] <bryce> (bug #129380)
[08:50] <ubotu> Launchpad bug 129380 in xorg "It does not refresh well when dragging a window in the rotated screen" [Low,Triaged]  https://launchpad.net/bugs/129380
[08:51] <jcristau> we're a bit drowning under reports about 1.4 atm :)
[08:52] <bryce> heh, I can imagine
[08:55] <ubotu> New bug: #141050 in xserver-xorg-driver-ati (main) "xorg crashes when xv is running, compiz is enabled and switch the desktop" [Undecided,New]  https://launchpad.net/bugs/141050
[08:57] <TomaszD> while I have your attention, where is the best place for laptop acpi whitelisting in Ubuntu? https://bugs.launchpad.net/ubuntu/+source/linux-source-2.6.22/+bug/92806
[08:57] <ubotu> Launchpad bug 92806 in linux-source-2.6.22 "N340S8 laptop needs to have ACPI enabled" [Undecided,Confirmed]  
[08:58] <keescook> tormod: uploaded.  :)
[08:58] <tormod> keescook: thanks again!
[08:58] <keescook> tormod: no problem; thanks for getting the diffs together.  :)
=== joumetal [n=jouni@laku34.adsl.netsonic.fi]  has joined #ubuntu-x
[09:31] <bdmurray> bryce: have you seen bug 137604?
[09:31] <ubotu> Launchpad bug 137604 in xorg-server "Black Bar Across Screen with gutsy i810" [High,Triaged]  https://launchpad.net/bugs/137604
[09:34] <joumetal> it has some boring comments, but if there is something I could do, let me know.
=== tormod [n=tormod@138.131.206.233]  has left #ubuntu-x ["Ex-Chat"] 
=== tehk [n=tehk@c-69-249-157-157.hsd1.nj.comcast.net]  has joined #ubuntu-x
=== seb128 [n=seb128@ubuntu/member/seb128]  has joined #ubuntu-x
[10:05] <ubotu> New bug: #141063 in xserver-xorg-video-intel (main) "experimental Intel driver freezes system on video play after suspend" [Undecided,New]  https://launchpad.net/bugs/141063
[10:12] <ubotu> New bug: #139849 in xorg (main) "DRI (direct rendering) has stopped working in Gutsy" [Medium,Confirmed]  https://launchpad.net/bugs/139849
=== seb128 [n=seb128@ubuntu/member/seb128]  has joined #ubuntu-x
=== tormod [n=tormod@80-219-112-71.dclient.hispeed.ch]  has joined #ubuntu-x
[10:49] <bdmurray> bryce: where would bug 140999 go?
[10:49] <ubotu> Launchpad bug 140999 in ubuntu "gutsy xorg detects 1280x800, gnome thinks its 1024x768" [Undecided,New]  https://launchpad.net/bugs/140999
[10:55] <bryce> bdmurray: gnome-system-tools probably
[10:55] <bryce> I'm not super familiar with how it determines what resolutions to display, so it's possible it's depending on another lower level tool.
[11:05] <bdmurray> bryce: cool, looking that the file xresprobe reports 1024x768 but xorg.conf has 1280x800
[11:06] <bryce> right
[11:06] <bryce> he said xresprobe reports 1280x800 too, so it's not likely to be an xorg issue directly
[11:06] <bryce> for some reason this sounds familiar
[11:07] <bryce> ohh
[11:07] <bdmurray> I don't think he said xresprobe reports 1280x800
[11:07] <bryce> gnome must be failing to retrieve resolutions and defaulting to 1024x768
[11:07] <bryce> sounds related to bug 3731 
[11:07] <ubotu> Launchpad bug 3731 in xorg "Xorg resolution falling back to 640x480 and/or 800x600 when h/v freqs incorrect" [Critical,Confirmed]  https://launchpad.net/bugs/3731
[11:07] <bryce> nope
[11:08] <bryce> it's dupe of 49827
[11:09] <bdmurray> bug 49827
[11:09] <ubotu> Launchpad bug 49827 in xorg "Available resolutions incompletely set to 1024x768, 800x600, 640x480" [High,Confirmed]  https://launchpad.net/bugs/49827
[11:11] <bdmurray> really?
[11:12] <tormod> not a dupe, in 49827 xorg gets it wrong
[11:12] <bdmurray> Right, this seems like the desktop gets it wrong not xorg
[11:13] <bryce> well, my guess is that gnome is querying gconf for resolutions, which returns those three resolutions when it doesn't know
[11:13] <tormod> why does gnome try to figure out available modes instead of just looking at the size of the root window? or even something like xdpyinfo?
[11:16] <bryce> anyway, it sounds a lot like 49827.  but who knows.  In any case, it should be investigated from the gnome angle.
[11:17] <bryce> oh wait
[11:17] <bryce> I finally looked at the screenshot
[11:18] <bryce> this looks like he's got a second input that's getting detected as 1024
[11:20] <tormod> he's running "clone" with a ghost screen?
[11:20] <bryce> something like that yeah
[11:21] <bryce> I've run across something like that before when attaching a clone projector running at a lower rez
[11:25] <bryce> bdmurray: regarding bug 137604, yeah tepsipakki was looking into that one the other day
[11:25] <ubotu> Launchpad bug 137604 in xorg-server "Black Bar Across Screen with gutsy i810" [High,Confirmed]  https://launchpad.net/bugs/137604
[11:26] <bryce> sounds like it's due to one of the backported patches, but we're not sure which one
[11:29] <tormod> bryce, I forgot to set maintainer on the sis package (ubuntu1). bad me. does that call for a new upload?
[11:30] <bryce> maybe; I think it'll kick it out if the maintainer is not @ubuntu.com
[11:31] <tormod> well the changes file says Ubuntu/i386 Build Daemon <buildd@palmer.buildd>
[11:34] <jcristau> buildds set the Maintainer in .changes with dpkg-buildpackage -m
[11:37] <tormod> I just downloaded the source and it has been properly changed in debian/control :)
[11:37] <tormod> I don't know if keescook did it or it was done automatically.
[11:38] <tormod> I guess https://wiki.ubuntu.com/DebianMaintainerField is in good progress.
[11:43] <bdmurray> Does anybody have any ideas about bug 130429?
[11:43] <ubotu> Launchpad bug 130429 in xorg "[feisty]  brief glitch at the bottom of the screen after gdm starts with i915 graphics card" [Undecided,Incomplete]  https://launchpad.net/bugs/130429
[11:43] <bryce> jcristau: btw, are you packaging radeonhd for debian, or waiting on a release?
[11:44] <bryce> bdmurray: for that intel blackbar bug, it looks like its due to one of the patched Ibackported.  i'm going to build some debs disabling various things to see if we can narrow in on which one caused it
[11:45] <jcristau> bryce: http://lists.debian.org/debian-devel-changes/2007/09/msg01755.html
[11:45] <tormod> bdmurray: must be the intel driver that is not initializing correctly
[11:45] <bdmurray> bryce: that sounds great.  I can imagine it is rough for those effected.
[11:46] <bryce> jcristau: thx
[12:01] <ubotu> New bug: #139845 in ubuntu "no videoplayer works correctly" [Undecided,Confirmed]  https://launchpad.net/bugs/139845
[12:06] <bryce> bdmurray: I think I've seen bug 130429 on my dell 945gm laptop too, or at least something similar
[12:06] <ubotu> Launchpad bug 130429 in xorg "[feisty]  brief glitch at the bottom of the screen after gdm starts with i915 graphics card" [Undecided,Incomplete]  https://launchpad.net/bugs/130429
[12:10] <ubotu> New bug: #141101 in xorg (main) "[UVFe]  Please sync xserver-xorg-video-radeonhd (universe) from Debian experimental" [Undecided,New]  https://launchpad.net/bugs/141101
[12:12] <jcristau> bryce: -radeonhd build-deps on xserver-xorg-dev (>= 2:1.4), so it can't be synced directly
[12:12] <bryce> erf.
[12:13] <bryce> will it compile against 1.3 or is it depending on1.4-isms?
[12:13] <jcristau> i haven't tried, but i expect 1.3 will be fine