[01:17] in the new image, you open it by clicking on the icon or through an external link. [01:17] asac, did benjamin tell you by luck where/how easy it is to look into two ext dirs ? [01:20] cwong1: ok [01:21] Ubulette: he said its easy ... they dropped it at some point but he wants it in now again [01:21] someone else provided this pointer: http://mxr.mozilla.org/seamonkey/source/xpcom/io/nsAppFileLocationProvider.cpp#600 [01:21] might or might not be the right place [01:22] i was in there: http://mxr.mozilla.org/seamonkey/source/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#2279 [01:22] but didnt lookright [01:23] oh, yours is good for plugins [01:23] hmmm ... so maybe the one i provided is for plugin dirs [01:23] yes [01:23] i'm looking for ext now [01:24] your place looks reasonable then [01:25] KEY_APPDIR ... maybe there is something for XREDIR [01:25] ? [01:25] var appGlobalExtensions = getDirNoCreate(KEY_APPDIR, [DIR_EXTENSIONS] ); [01:25] -> var xulGlobalExtensions [01:25] ?? [01:25] somehow [01:25] ;) [01:25] but actually he said that he dropped it at some point so maybe looking at bonsai gives us the right pointer [01:26] he = ? [01:27] he = bsmedg [01:40] can't find it [01:40] yeah me neither :/ [01:43] Ubulette: ok the idea is probably to add NS_APP_EXTENSIONS_DIR_LIST [01:43] hmm, the whatsnew url for minefield is wrong [01:43] to http://mxr.mozilla.org/seamonkey/source/xpcom/io/nsAppFileLocationProvider.cpp#600 [01:43] and then adapt extensin manage to look at all [01:44] Ubulette: trunk urls are almost certainly wrong [01:44] they just update the content on milestone releases [01:46] should be straight forward to do what i said above [01:47] i dont think this function is called for extensions/themes. looks like just for plugins [01:47] which function? [01:48] the one in nsAppFileLocationProvider? [01:48] nsAppFileLocationProvider::GetFiles() [01:48] yes its not called because the em just looks for a single path [01:48] it needs to be adapted [01:49] #define NS_APP_EXTENSIONS_DIR_LIST "AExtensionsDL" [01:49] in [01:49] http://mxr.mozilla.org/seamonkey/source/xpcom/io/nsAppDirectoryServiceDefs.h [01:49] then add the constant to AppFileLocationProvider [01:49] and use that to look up the dir list in EM [02:00] bug 141233 [02:00] Launchpad bug 141233 in network-manager "MASTER network-manager crashes when wpasupplicant ctrl socket is not available" [High,Fix released] https://launchpad.net/bugs/141233 [02:29] you grabbing 2.0? [02:30] gnomefreak, ? [02:30] i planed on fixing something in iceape this week? i see seamonkey all over hte screen [02:31] do i still need to fix it? [02:31] no, we brainstormed on xul/ff3 using seamonkey sources [02:33] ah ok plans for gutsy+1 enable xul for iceape/seamonkey (im thinking leaving it iceape thh.) hopfully 2.0 will be released soon after gutsy is (but unlikely) and maybe using quilt for 2.0 as well [02:34] i don't think seamonkey is ready for xul [02:34] Ubulette: let me know when you get the sources (from where) i will try xul in 1.1.4 [02:34] Ubulette: not here afaik [02:34] Ubulette: what should i be looking for (somethign give it away that is easy to locate?) [02:34] sources of what ? [02:34] seamonkey [02:35] iceape = seamonkey [02:35] i havent seen anything in current seamonkey release that has anything to do with xul [02:37] I've read somewhere that seamonkey is not ready to be compiled with xulrunner. [02:37] part of it may work, but not all of it [02:37] parts [02:37] oh ok i thought you said it was i miss read [02:38] thats why i was gonna wait for 2.0 to make sure but if it was ready i would have tried it in 1.1.43 [02:38] -3 === Paddy_EIRE [n=patrick@89.240.241.165] has joined #ubuntu-mozillateam [03:17] asac, strange, it seems links added through dh_link are not properly installed if there's already a directory [04:18] night [04:21] gnomefreak: [04:21] you still here [04:21] how do I solve this error [04:21] E: Could not get lock /var/lib/apt/lists/lock - open (11 Resource temporarily unavailable) [04:21] E: Unable to lock the list directory === shirish [n=shirish@59.95.16.59] has joined #ubuntu-mozillateam [05:12] anybody up? === shirish [n=shirish@59.95.16.59] has left #ubuntu-mozillateam [] [05:47] !fixapt [05:47] Sorry, I don't know anything about fixapt - try searching on http://ubotu.ubuntu-nl.org/factoids.cgi [05:47] !aptfix [05:47] If Adept crashed on you and your database is locked, try this in konsole: sudo fuser -vki /var/lib/dpkg/lock;sudo dpkg --configure -a [05:47] IdleOne: ^^^ [05:48] without the << >> [06:01] why does that say in konsole? [06:20] why does what say in konsole? [06:47] asac: nspluginwrapper needs upload as well as iceape maybe tomorrow (im working on getting iceape built after fixes so i can test before pushing to branch/revu/or where ever you want to do it from [07:27] ok going to bed finally === jbs [n=Bernardo@89-180-165-161.net.novis.pt] has joined #ubuntu-mozillateam === jbs is now known as Bernardo === Bernardo [n=Bernardo@84.39.87.157] has joined #ubuntu-mozillateam === jbs [n=Bernardo@84.39.112.55] has joined #ubuntu-mozillateam === jbs is now known as Bernardo [11:28] whats the problem with nspluginwrapper gnomefreak ? [11:28] can't this wait until after beta? === Jazzva [n=sasa@cable-89-216-130-161.dynamic.sbb.co.yu] has joined #ubuntu-mozillateam [01:34] Hello... [01:38] hi [01:38] now lunch :) [01:38] Have fun ;)... [02:21] asac: I have the new diff-ext deb [02:21] asac: can you check if it crashes there? [02:21] seems to work fine here [02:32] Jazzva: where can i look at the patch? [02:38] asac: Just a sec... [02:39] http://paste.ubuntu-nl.org/38567/ [02:39] asac ^ [02:42] Hmm, I think maybe we should use a different name for wizardCheckAdmin()... something that will be more obvious, like userIsAdmin()... [02:43] asac: can you test there? [02:43] The code will be more readable... for example, "if (userIsAdmin()) {...}" [02:43] asac: ftp://gnome-btdownload.alioth.debian.org/pub/gnome-btdownload/diff-ext_0.2.3-1_i386.deb [02:43] asac: let me know if it does not crash anymore [02:43] bluekuja: i don't have sid ... please provide me with a gutsy build ;) [02:44] asac: that's gutsy build [02:44] :P [02:44] asac: should work for you [02:44] where are sources? [02:45] Jazzva: yes ... userIsAdmin is ok [02:46] asac: need diff, dsc and origin too? [02:46] Jazzva: ok just to be sure ... what happens if user isn't admin and there are no other results? [02:46] asac: it's not ready for upload [02:46] asac: just wanted to know if the bug is fixed [02:46] bluekuja: make it redy then [02:46] asac: ok [02:46] bluekuja: if it fixes the bug for oyu ... it should [02:46] yep [02:48] asac: Well, it always shows apturl's results. If user isn't admin then they're grayed-out and there's a note below vbox, which says that user needs admin permissions to install the grayed-out plugins. The user can click Next or Cancel. Clicking Next takes him/her to summary screen, which says that no plugins were installed. [02:49] asac: And if there're no apturl and xpi results, I suppose the plugin box is empty. That isn't tampered in this patch... [02:49] ah right [02:50] Jazzva: normally if ther eis no result at all the plugin wizard goes to a page that states that [02:50] can you verify that this is still the case? [02:50] asac: Umm, hmm... Is the only way to disable apturl support in ubufox? [02:50] Jazzva: you can verify upstream behaviour by disabling ubufox and trying to install a video player [02:51] file:///home/asac/ubuntu_bzr/ubufox/pfs/test/2_multicontent.html [02:51] ups [02:51] :) [02:51] I know the link :)... [02:51] ah ok [02:51] Umm... btw, can I use the same name for a variable and a function? [02:51] upstream database should not have a video player for linux in their database [02:52] Jazzva: no idea for javascript ... either try or go the safe way [02:52] Ok... safe way :)... [02:52] bluekuja: do you understand what the issue was? [02:53] asac: bug report says "nautilus crash when installed" [02:53] @schedule [02:53] Schedule for Etc/UTC: 26 Sep 20:00: Edubuntu | 27 Sep 12:00: Desktop Team Development | 27 Sep 15:00: Community Council meeting | 02 Oct 16:00: Kernel Team | 02 Oct 17:00: Ubuntu Artwork Team | 06 Oct 17:00: Xubuntu Developers [02:53] asac: so just installing it [02:53] caused the crash [02:53] bluekuja: well ... please dig out the checkin that fixed it ;) [02:54] asac: what do you mean? [02:54] find the diff that fixes it [02:54] asac: oh, it has been fixed upstream [02:54] after our report [02:54] yes ... find the diff ;) [02:55] oki :) [02:55] shouldn't be too hard because diff-ext is small piece of software [02:56] asac: yep, gonna debdiff [02:56] old and new revision [02:56] and we will have the diff [02:56] .orig are different [02:56] so gonna be quite easy [02:59] asac: do you know debarchiver software? === Bernardo [n=Bernardo@89-180-165-161.net.novis.pt] has joined #ubuntu-mozillateam [03:04] bbl [03:20] asac: Hmm, tested... I changed the URL for PFS from yours to Mozilla's... [03:21] In Ubufox's PFS it just popped a window with no plugins and line "Press next to install these plugins". Pressing next takes you to the last page and says that there were no plugins found. I think we should skip the plugin selection page in that case... [03:22] Using Mozilla's PFS... well, I just get the window that keeps checking for plugins forever... [03:23] lunch... brb [03:31] Jazzva: you don't need to change the url ... just disable ubufox [03:31] in addons manager [03:31] that should bring you back to pristine upstream behaviour [03:33] back [03:33] asac: That brings the window and the PFS keeps searching for plugins forever... [03:34] hmm [03:34] asac: On the other hand, if no plugins were found in Ubufox, it shows a window with "Press Next to install those plugins"... Pressing Next takes user to the last window... I thought we could skip the first one in case no plugins were found. [03:35] right ... but from what i know the pristine dialog does exaclty that [03:35] strange that it doesn't for you [03:35] Really? [03:35] usually yes [03:35] http://releases.mozilla.org/pub/mozilla.org/firefox/releases/ [03:35] As far as I can remember, it did that all the time :/... [03:35] please grab a build from there and try with that ... and a fresh profile [03:36] Ok... [03:36] just to be sure that we don't hunt a bug that is really upstream [03:36] I'll have to do that in the evening... [03:36] maybe ;) ... but then its a bug :) [03:36] ok [03:36] I'll have to go out in about 20-30 minutes [03:37] Ok, which version? 2.0.0.7 or Granparadiso? [03:37] Umm... latest-2.0 or latest :)? [03:38] 2.0.0.7 [03:38] Ok... [03:38] cool [03:38] then lets see :) [03:39] I'm off now... Have fun. [03:39] u2 [03:51] asac ? [03:53] asac, I've replaced a directory by a symlink but it doesn't work as long as the directory is there === asac_ [n=asac@debian/developer/asac] has joined #ubuntu-mozillateam === hawke [n=amauer@home.hawkesnest.net] has joined #ubuntu-mozillateam [04:04] asac: ping? [04:14] hawke: yeah [04:14] I can't reproduce that network-manager crash entirely reliably [04:14] Ubulette: yes thats true [04:15] but it happens quite regularly for me [04:15] asac_: so what's the solution for that ? [04:16] Ubulette: moving stuff in preinst [04:16] the dir is empty at that point [04:16] Ubulette: empty? ... why isn't it removed? [04:16] isn't the dir listed in .dirs ? [04:17] no [04:18] asac: I've got about 2 minutes before I leave for work (switching networks, and most likely causing the crash) -- my plan was to simply attach gdb to network manager, and see the backtrace from there. Is that a good plan? [04:18] hawke: problem is that you don't have debug symbols [04:18] hawke: please start now and test when you return: [04:18] asac: yes I do [04:18] you have? [04:19] find then do as you suggest [04:19] run gdb NetworkManager [04:19] (gdb) run --no-daemon [04:19] what else were you going to suggest? [04:19] hawke: build the source ... apt-get build-dep network-manager [04:19] ah [04:19] apt-get source network-manager [04:19] cd network-manager* [04:19] dpkg-buildpackage -rfakeroot [04:19] cd src [04:19] ./NetworkManager [04:19] (hit ctrl-c) [04:20] gdb .libs/lt-NetworkManager [04:20] (gdb) run --no-daemon [04:20] then bt and bt full when it crashes [04:20] Is there a way to ensure that gdb doesn't pause at each screenful of information? [04:21] not that i know ... its not a big problem i guess :) [04:21] shouldn't be a too deep backtrace [04:21] for now just a bt is enough [04:21] if i need a full i would ask for it [04:21] alright. Well, I'll get back to you in about ... 40 minutes, then [04:21] thanks a lot! [04:22] np [04:22] i can't reproduce it ... so i rely on external backtraces ;) [04:35] asac, http://mxr.mozilla.org/seamonkey/source/toolkit/xre/nsXULAppAPI.h#176 === bluekuja [n=andrea@ubuntu/member/bluekuja] has joined #ubuntu-mozillateam [04:43] asac: iceape and nspluginwrapper can wait until after beta neither are blockers, im just reminding you (and me) since we both forgot about iceape last time ;) [04:43] Ubulette: yes ... thats good. [04:43] gnomefreak: ok [04:43] thanks [04:44] asac, good but not used [04:44] god i hope this works [04:50] asac: do you have link handy for changelogs for iceape 1.1.4 === gnomefreak lost everything during ISO testing === asac_ [n=asac@debian/developer/asac] has joined #ubuntu-mozillateam [05:01] either i got lucky and they applied it upstream and that is highly possible since this started with 1.1.4 or the patch is no good (highly unlikely since i just checked it again the file it patched :( [05:01] brb figure this out sometime this week [05:02] but if the patch was applied upstream the patch should fail to apply (and that bothers me a bit) goes to think === asac [n=asac@debian/developer/asac] has joined #ubuntu-mozillateam [05:09] asac: meeting pretty much just started === asac_ [n=asac@debian/developer/asac] has joined #ubuntu-mozillateam === hawke [n=amauer@208.255.6.238] has joined #ubuntu-mozillateam === asac_ [n=asac@debian/developer/asac] has joined #ubuntu-mozillateam [05:31] asac: i was looking at the list of milestone bugs for final/rc looks like atleast one is fixed and in archive but the bug is still open, bug 131410 should we close it or leave it? [05:31] Launchpad bug 131410 in thunderbird-quickfile "[gutsy] Doesn't depend on thunderbird" [High,Fix released] https://launchpad.net/bugs/131410 [05:31] it is closed :( its still listed on the milestone list [05:31] seems that list isnt up to date === bluekuja [n=andrea@ubuntu/member/bluekuja] has joined #ubuntu-mozillateam [06:05] gnomefreak: the list doesn't exclude fix released bugs [06:05] its just all ... you can sort by status though [06:06] ah ok === Jazzva [n=sasa@cable-89-216-130-161.dynamic.sbb.co.yu] has joined #ubuntu-mozillateam [06:09] asac: I took a look at the 2.0.0.7 with a clean profile... It does what you said... It must have been something wrong with my profile or something... [06:09] yes [06:09] hopefully its not us that broke it [06:10] I'm gonna take a look at it... Maybe it was wrong to change the PFS URL to Mozilla's... Do you know the way to get no plugin results in ubufox? [06:11] Jazzva: you can just modify the test page to require a non-existing mime-type [06:11] then there shouldn't be a result [06:11] Ok... [06:12] I'll try that now [06:18] Hmm, nope... It seems that it puts the page to install no plugins... [06:18] yeah ... it definitly worked at some point :) [06:18] I'll try to fix that now... To make it jump to the page which says that no page was found... [06:18] Or should I go down the revisions and check? :) [06:55] asac: It's fixed... Here's the diff http://paste.ubuntu-nl.org/38667/ . Take a look at line 42, that's the only place where I found mPluginInfoAptArrayLength. [07:07] Jazzva: why don't we check for both anymore? [07:08] Hmm, I couldn't find mPluginInfoAptArrayLength anywhere else :/... [07:09] Ok, I grep'd other files to check, that's the only place where it's mentioned... [07:11] So, I suppse that's why it doesn't jump to the last page if no results are find... mPluginInfoAptArrayLength is undeclared, and we check if it's equal to 0... I suppose that gives false and it doesn't jump to the last page. [07:11] *suppose [07:13] asac: So, what do you think? Is it ready to push to branch? [07:21] Jazzva: feel free to push to your branch [07:21] if we need more we can improve that before merging === shirish [n=shirish@59.95.16.150] has joined #ubuntu-mozillateam [07:22] asac: Ok :)... [07:22] hi guys [07:22] hi [07:22] ok out for sport .... cu later [07:22] Ubulette: hey :) [07:22] Should I push both to ubuntu and ff3 branch, or is pushing to ff3 enough? They're both pretty much the same for now, the only difference is maxVersion in install.rdf. [07:23] Hey shirish... [07:23] Ubulette: so Ubulette what you were saying about latest updates [07:23] shirish, about what ? [07:34] I've played with intlclock, looks nice: http://www.sofaraway.org/ubuntu/tmp/intlclock.png === jamesh [n=james@canonical/launchpad/jamesh] has joined #ubuntu-mozillateam [07:37] asac: bug 144882 (looks like a regression in n-m) you told me to ping you about them. ill be gone most of day just checking on iceape build atm [07:37] Launchpad bug 144882 in network-manager "ioctl[SIOCSIWAUTH] : Operation not supported" [Undecided,New] https://launchpad.net/bugs/144882 [07:45] Ubulette: what is so cool about that int clock? [07:46] you mean, compared to the default one ? [07:51] shirish, that's the default: http://www.sofaraway.org/ubuntu/tmp/clock.png === gnomefreak needs a domain :( i miss mine [07:52] Ubulette: is that in repos? [07:52] that is cool [07:52] gnomefreak, no [07:53] Ubulette: you have a branch for it i can build from? [07:53] there's a 4 bzr branchs on lp [07:53] e [07:53] there're 4 bzr branches on lp [07:53] under your LP page? [07:53] nope [07:53] yep i see one [07:53] I've modified one of the 4 [07:54] I can push to my page if you want [07:54] please i would like to take a look at that [07:54] shoot you have tarball or mozclient build one? [07:56] for that ? [07:56] yes [07:57] it's not a moz app ;) [07:57] unless it uses the clock-applets source from repos [07:57] the branch contains the sources [07:57] Ubulette: yeah i know i thought about that aftewards (im on alot of pain meds atm [07:58] Ubulette: sweeet [07:58] pushing in /~fta/intlclock/intlclock.trunk [07:58] saw that [07:59] just branch that and dpkg-buildpackage it as usual [07:59] ok will do once its up === gnomefreak goes for smoke while you push [07:59] done on my side [08:00] ok Lp hasnt updated yet than [08:00] there it is [08:14] asac: hey, I just sent you some updated .png files [08:16] shirish, http://www.netsplit.com/blog/articles/2007/09/26/why-i-choose-bazaar-a-history-of-revision-control === Paddy_EIRE [n=patrick@89.240.241.165] has joined #ubuntu-mozillateam === jamesh [n=james@canonical/launchpad/jamesh] has joined #ubuntu-mozillateam [08:37] Ubulette: thanx, gotta go sleep, had lot of work today :) === shirish [n=shirish@59.95.16.150] has left #ubuntu-mozillateam [] === jamesh [n=james@canonical/launchpad/jamesh] has joined #ubuntu-mozillateam === rexbron [n=rexbron@62.6.158.161] has joined #ubuntu-mozillateam [09:19] gnomefreak, did it work ? [09:19] yes i just have to figure out how to move n-m applet [09:19] it's a tray icon right ? [09:20] i dont know if i can remove it or not [09:20] yes the one uip by date and time [09:20] in gnome [09:21] if it's an icon in the notification area, I don't think you can move it. you can just move the notification area [09:21] i cant get the time to the right of the icon but i will fix it later i think [09:21] i don't use nm so i don't know [09:21] either do it this icon is there by default [09:22] screenshot ? [09:25] cant im in alot of pain atm i am suffering just to get this POS iceape building [09:25] ill figure it out tonight if not than i will post one [09:33] Ubulette: once i figure out how to take a screen shot and find where to post it ill post it :) [09:34] i cant even remove the n-m thingy or whatever it is [09:34] Application / Accessories / Take Screenshot [09:34] its the default black screen icon (looks like a pc screen) [09:35] ok ihave the screenshot where is there a free place to post it? [09:35] i lost domain for some reason (i havent seen the guy that gave me the space on it) === jamesh [n=james@canonical/launchpad/jamesh] has joined #ubuntu-mozillateam [09:44] gnomefreak, http://tinypic.com/ [09:44] ty [09:45] its uploading [09:46] Unpacking replacement xulrunner-1.9 ... [09:46] dpkg: error processing xulrunner-1.9_1.9~a8-0ubuntu1~mt2_i386.deb (--install): [09:46] trying to overwrite `/usr/bin/xulrunner', which is also in package xulrunner [09:46] we need a diversion :p [09:46] http://tinypic.com/view.php?pic=ei70jo&s=2 [09:47] checking to see if that is right link [09:47] yep [09:47] what are you trying to move ? === gnomefreak [n=gnomefre@ubuntu/member/gnomefreak] has joined #ubuntu-mozillateam [09:55] sorry locked up badly [09:56] what are you trying to move ? [09:56] Ubulette: looking at screen shot you see the top far right the little black screen? [09:56] i want that to the left of the clock/date applet [09:56] Cant you right click it and unlock it ? [09:57] right clicking on it gives me enable network/about/connection info [09:57] Ubulette: do we really need that binary in /usr/bin ? [09:57] aeh script i mean ;) [09:57] no lock to panel no move nothing like that [09:57] asac: just the man that could fix this ;) [09:57] if so please use an alternative ... not a diversion [09:58] asac, I jsut renamed it to xul-1.0 [09:58] 9 [09:58] the little network applet thingy (the connection info little black screen icon) [09:58] how in gods name do you move this or remove this and readd it [09:58] Ubulette: i don't think that its wise to do that. after all its again a diversion from upstream [09:59] so renaming it is as good as not shipping it in /usr/bin imo [09:59] hm [09:59] with a difference that people will start to use it and then we are locked for ever ;) [10:00] Ubulette: imo we can accept the conflict for now ... once gutsy is open again we can reupload xulrunner 1.8 with an alternative === gnomefreak figured after THAW you would upload 1.9 [10:01] asac, when would that be ? [10:02] we should be clear by monday [10:02] hopefully tomorrow night ... otherwise friday [10:02] no idea if beta has been pushed back [10:02] oh thats right today is only wed [10:03] plan was to release beta tomorrow [10:03] asac: it looked like they were spinning finals earlier [10:03] earlier than what? [10:03] but only say it breifly [10:03] asac: maybe hour or 3 ago [10:03] gnomefreak: i doubt that we will release today [10:03] no spinning final betas for tomorrow [10:03] gnomefreak: if we release tomorrow its on schedule ... which would be pretty great [10:03] right [10:04] asac: it would be the first time [10:04] mozilla bug 396209 [10:04] yay :) [10:04] Mozilla bug 396209 in XRE Startup "Allow applications to specify a profile directory from application.ini" [Normal,Assigned] http://bugzilla.mozilla.org/show_bug.cgi?id=396209 [10:04] we are always normally 1 day behind [10:04] Ubulette: yeah ... its currentyl implicitly defined isn't it? === jamesh [n=james@canonical/launchpad/jamesh] has joined #ubuntu-mozillateam [10:06] now you can add a Profile in app.ini [10:06] ok do i really have to live with that connection applet (or is there a trick to move/remove it [10:07] Ubulette: yes ... its implicitly defined by product + vendor id, isn't it? [10:07] gnomefreak, trick it, try to move everything else on the far right :) [10:07] asac, yes [10:08] Ubulette: cant it wont go past it === gnomefreak tried that first === gnomefreak might beg asac to add a move option to it after meds wear off [10:09] gnomefreak: move option? [10:09] what are you talking about? [10:09] asac: to the little n-m thingy in task bar by clock [10:09] i cant move or remove it [10:10] asac, can you add an alternative to xul 1.8 ? [10:10] gnomefreak: you can only move the whole tray [10:11] Ubulette: yes ... i am eager to do that :) [10:11] oh crap thats right [10:11] Ubulette: lets give 1.9 higher priority [10:11] gnomefreak, told you ;) [10:11] damn i forgot about that, thank you its fixed :) [10:11]