[16:54] <Keybuk> right, so that's all the tests able to be built again
[16:54] <Keybuk> just got to fix a few more test failures
[16:54] <Keybuk> and then I can push the commit of doom!
[16:55] <Keybuk>  18 files changed, 2271 insertions(+), 3012 deletions(-)
[17:39] <ion_> :-)
[17:41] <Keybuk> being the commit that splits Job into Job and JobConfig
[17:43] <Keybuk> though I might try and turn it into lots of bi-sectable commits
[17:43] <Keybuk> not sure how likely that is
[17:48] <Keybuk> WOO!
[17:48] <Keybuk> ALL TESTS PASS!
[17:48] <Keybuk> I cannot tell you how happy this makes me! :D
[17:48] <Keybuk>  18 files changed, 2549 insertions(+), 3105 deletions(-)
[17:49] <ion_> Whee
[17:51]  * Keybuk checks the build with optimisations
[17:57] <Keybuk> (and fixes the usual gcc "I'm stupid" issues)
[18:11] <Keybuk> ok, now the coverage check
[19:04] <phsdv> it seems that the link on http://upstart.ubuntu.com/download.html to the readme file for 0.3.9 is broken...
[19:06] <Keybuk> phsdv: thanks, fixed
[19:06] <phsdv> thanks, starting to read it
[21:36] <CNW8835> hello
[21:47] <Keybuk> hello
[21:47] <CNW8835> do you  happen to know how to make upstart listen to kernel boot options (like "3" to make init/upstart boot into runlevel 3)?
[21:48] <CNW8835> It's my understanding that you just have to put a "3" as a kernel boot parameter, but this doesn't seem to work with upstart
[21:49] <Keybuk> right, it doesn't work
[21:49] <Keybuk> it's a bug
[21:49] <CNW8835> oh, ok
[21:49] <CNW8835> thanks
[21:49] <Keybuk> https://bugs.edge.launchpad.net/upstart/+bug/74664
[21:50] <Keybuk> (and also)
[21:50] <Keybuk> https://bugs.edge.launchpad.net/upstart/+bug/85014
[21:50] <Keybuk> depending which side of the bug you care about ;)
[21:50] <CNW8835> thanks for the links
[22:56] <Keybuk> http://codebrowse.launchpad.net/~keybuk/upstart/main/revision/scott%40netsplit.com-20071019214909-iyq8ua9epn5wsmfw?start_revid=scott%40netsplit.com-20071019214909-iyq8ua9epn5wsmfw
[23:21] <mbiebl> wow
[23:23] <ion_> Hehe
[23:39] <Keybuk> ba
[23:39] <Keybuk> I hate it when I find bugs just by looking
[23:39] <Keybuk> wing-commander init% ./test
[23:39] <Keybuk> test (#0) goal changed from stop to start
[23:39] <Keybuk> test (#0) state changed from waiting to starting
[23:39] <Keybuk> event_new: Pending starting event
[23:39] <Keybuk> test (#0) goal changed from start to stop
[23:39] <Keybuk> Handling starting event
[23:39] <Keybuk> event_finished: Finished starting event
[23:39] <Keybuk> test (#0) state changed from starting to waiting
[23:39] <Keybuk> event_new: Pending stopped event
[23:39] <Keybuk> Handling stopped event
[23:39] <Keybuk> event_finished: Finished stopped event
[23:39] <Keybuk> ...
[23:39] <Keybuk> if the goal changes to stop while the starting event is blocked, you never get a stopping event
[23:39] <Keybuk> just a stopped one
[23:54] <Keybuk> bugger
[23:54] <Keybuk> need two different next states from waiting
[23:55] <Keybuk> from starting, I mean