| === mrevell is now known as mrevell-lunch | ||
| === mrevell-lunch is now known as mrevell | ||
| === statik` is now known as statik | ||
| barry | i'll be right with you guys. my machine is acting stupid | 15:00 |
|---|---|---|
| barry | #startmeeting | 15:01 |
| MootBot | Meeting started at 15:01. The chair is barry. | 15:01 |
| MootBot | Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] | 15:01 |
| barry | hello and welcome everyone to the ameu launchpad reviewers meeting | 15:02 |
| barry | who's here today? | 15:02 |
| sinzui | me | 15:02 |
| statik | me | 15:02 |
| bac | me | 15:02 |
| intellectronica | me | 15:02 |
| bigjools | me | 15:02 |
| gmb | me | 15:02 |
| gmb | (sprinting) | 15:02 |
| allenap | me | 15:02 |
| BjornT | me (at least partly) | 15:02 |
| bigjools | which part? :) | 15:03 |
| danilos | me | 15:03 |
| barry | flacoste, schwuk ping? | 15:04 |
| flacoste | me | 15:04 |
| schwuk | me | 15:04 |
| barry | [TOPIC] agenda | 15:04 |
| MootBot | New Topic: agenda | 15:04 |
| barry | * Roll call | 15:04 |
| barry | * Next meeting | 15:04 |
| barry | * Action items | 15:04 |
| barry | * Queue status | 15:04 |
| barry | * Mentoring update | 15:04 |
| barry | * jtv graduates | 15:04 |
| barry | * schwuk to be mentored by sinzui | 15:04 |
| barry | * Review process | 15:04 |
| barry | * Tool update | 15:04 |
| barry | * Release-critical review (flacoste) | 15:04 |
| barry | [TOPIC] next meeting | 15:04 |
| MootBot | New Topic: next meeting | 15:04 |
| barry | same time, week += 1? | 15:04 |
| barry | anybody know they can't make it? | 15:05 |
| bigjools | me | 15:05 |
| bigjools | I will be on leave | 15:05 |
| barry | actually, it's possible i might be late. i have a meeting at my son's school an hour before that | 15:05 |
| barry | bigjools: cool | 15:05 |
| barry | i might ask someone else to chair it just in case the meeting goes long | 15:05 |
| schwuk | I'll be in leave as well | 15:05 |
| barry | schwuk: cool | 15:06 |
| schwuk | s/in/on/ | 15:06 |
| barry | [TOPIC] action items | 15:06 |
| MootBot | New Topic: action items | 15:06 |
| barry | * intellectronica to put cover letter draft on wiki | 15:06 |
| intellectronica | ehm | 15:06 |
| barry | :) | 15:06 |
| intellectronica | didn't, i suck | 15:07 |
| barry | we'll just carry it over then | 15:07 |
| barry | * (continued) gmb to work on the review web site | 15:07 |
| barry | this topic came up on the asiapac meeting | 15:07 |
| barry | thumper has thoughts about using launchpad to help kill off PR and not spending a lot of extra time on a separate project | 15:08 |
| barry | thumper is going to write his thoughts up on the wiki | 15:08 |
| gmb | Well I haven't had a lot of time to spend, so that's fine with me ;) | 15:08 |
| barry | gmb: have you gotten a chance to look at review-board? | 15:08 |
| gmb | barry: No, as I'm sprinting this week without a hotel internet connection :(. But I will as soon as I get chance. | 15:09 |
| barry | i wonder if we could do something quick and dirty, like bring that up on devpad while we wait for uber-reviews on lp | 15:09 |
| barry | i read the article but haven't had time to grab the code and fire it up | 15:09 |
| gmb | I wonder how easy it would be to get lp-review working with it... | 15:10 |
| barry | does anybody else have thoughts on using review-board in the short term? | 15:10 |
| barry | gmb: that, and bzr | 15:10 |
| gmb | Yes. | 15:10 |
| statik | the tricky thing with review-board is getting it to accept our diffs | 15:10 |
| statik | I never finished adding bzr support to review-board | 15:10 |
| statik | due to lack of time | 15:10 |
| barry | statik: did it seem like a lot of work? | 15:11 |
| statik | it shouldn't be that hard, but it's more time than I have right now | 15:11 |
| statik | the devs would be happy to get a patch for that | 15:11 |
| BjornT | is review-board web-only, or can you access it via a command line tool, or e-mail? | 15:11 |
| statik | no email (well, notifications I think) | 15:11 |
| statik | web and rest api | 15:11 |
| statik | but the review itself is done by clicking in ajaxy things in the web ui | 15:12 |
| BjornT | then it gets a big -1 from me. i don't want to use a browser to do reviews | 15:12 |
| flacoste | -1 | 15:12 |
| flacoste | same here | 15:13 |
| sinzui | -1 | 15:13 |
| flacoste | review-board doesn't solve the PendingReviews problem at all | 15:13 |
| * sinzui likes his tools | 15:13 | |
| barry | ok, then let's not waste any more time on it | 15:13 |
| barry | thanks for the feedback! | 15:13 |
| barry | * (continued) sinzui to look into running `make lint` and output PR stanza by default in `review-submit` | 15:13 |
| sinzui | barry: I have not...I completely forgot. | 15:14 |
| * sinzui sets a todo | 15:14 | |
| barry | sinzui: np, thanks | 15:14 |
| barry | [TOPIC] queue status | 15:14 |
| MootBot | New Topic: queue status | 15:14 |
| barry | i know we had a ton of branches while the sprints were happening last week. thanks everyone for working hard to clear the backlog! | 15:14 |
| barry | there's still a lot of pink in pending-reviews, but i think we'll catch up | 15:15 |
| barry | anybody have any comments on the queue? | 15:15 |
| barry | how have on-calls gone this week? any comments on that? | 15:16 |
| barry | 5 | 15:16 |
| bac | yesterday was fine. didn't have much on-call traffic so i caught up on PR reviews | 15:16 |
| jtv | For which we thank bac | 15:16 |
| bigjools | I think a couple of sprints have reduced on-call significantly | 15:16 |
| barry | indeed, thanks bac! | 15:17 |
| bigjools | we should consider having backup reviewers on-call | 15:17 |
| gmb | It wouldn't have been so bad, but most of the remaining reviewers were mentees :/ | 15:17 |
| bigjools | indeed | 15:17 |
| barry | yep | 15:18 |
| bigjools | I dread putting something on PR and wondering when it will get reviewed! | 15:18 |
| barry | bigjools: PR needn't be post-and-forget. even if you have a branch on PR, you can still ping an on-caller if they're available, or your reviewer if need be | 15:19 |
| barry | but yeah, if we have more branches than cycles to review them, we need more reviewers or fewer branches | 15:20 |
| bigjools | barry: I can but with timezone issues plus a lack of on-call reviewer it makes it harder | 15:20 |
| barry | bigjools: yep | 15:20 |
| jtv | Could we also ping the on-call and say "have a branch for me?" | 15:20 |
| barry | jtv: you mean if you have spare cycles to review stuff? | 15:21 |
| jtv | barry: right | 15:21 |
| barry | jtv: you have spare cycles?! :) | 15:21 |
| bac | jtv: grand idea | 15:21 |
| jtv | barry: no, but I do get pangs of guilt sometimes | 15:21 |
| * bigjools has an 800-line soyuz branch waiting for someone just like jtv :) | 15:22 | |
| barry | jtv: ah yes, guilt can overcome oppressively stressful overworking sometimes :) | 15:22 |
| jtv | bigjools: jtv is currently reviewing a 2000-line one | 15:23 |
| bigjools | ! | 15:23 |
| barry | :-o | 15:23 |
| * bac remembers when 2000+ was the norm... :( | 15:23 | |
| barry | moving on? | 15:23 |
| barry | 5 | 15:23 |
| barry | 4 | 15:23 |
| barry | 3 | 15:24 |
| barry | 2 | 15:24 |
| barry | 1 | 15:24 |
| barry | [TOPIC] mentor updates | 15:24 |
| MootBot | New Topic: mentor updates | 15:24 |
| barry | first off: congratulations jtv on graduating | 15:24 |
| * jtv bows | 15:24 | |
| barry | give all your 2000+ branches to him :) | 15:24 |
| * jtv runs | 15:24 | |
| barry | also, welcome schwuk who is joining the team, mentored by sinzui | 15:25 |
| barry | thanks sinzui for volunteering to mentor schwuk | 15:25 |
| * bigjools high-fives schwuk | 15:25 | |
| * schwuk starts to wonder what he's let himself in for | 15:25 | |
| barry | where "volunteering" means "allowing himself to be volunteered by barry" :) | 15:25 |
| barry | [TOPIC] review process | 15:26 |
| MootBot | New Topic: review process | 15:26 |
| barry | * Tool update | 15:26 |
| barry | jtv: weren't you having some trouble with lpreviews? did that get cleared up? | 15:26 |
| jtv | barry: it did, thanks. | 15:27 |
| barry | jtv: great! | 15:27 |
| jtv | barry: provider may have been guilty. | 15:27 |
| barry | jtv: you mean your isp? | 15:27 |
| jtv | barry: yes. | 15:28 |
| barry | jtv: glad it's working now. | 15:28 |
| barry | anybody have anything else to discuss on the tool? | 15:28 |
| barry | 5 | 15:29 |
| barry | 4 | 15:29 |
| barry | 3 | 15:29 |
| barry | 2 | 15:29 |
| barry | 1 | 15:29 |
| barry | * Release-critical review (flacoste) | 15:29 |
| barry | flacoste: the floor is yours | 15:29 |
| flacoste | ok, this is about clarifying the process around release-critical reviews | 15:29 |
| flacoste | the process should be this: | 15:29 |
| flacoste | 1- when submitting a RC branch for review, make sure that the reviewer is aware that this is a RC branch | 15:30 |
| flacoste | 2- if you cannot complete the RC review, make sure that there is someone assigned to complete the review before you leave | 15:30 |
| flacoste | this means talking to another available reviewer that will do the job once you leave | 15:30 |
| flacoste | we probably need to make the whole team aware of (1) | 15:31 |
| flacoste | any comments? | 15:31 |
| bigjools | sounds good to me | 15:32 |
| barry | +1. flacoste, can you capture this on a wiki page? | 15:32 |
| flacoste | barry: i can send an email to the list about this, and I'll let you find a proper place to put that on the wiki | 15:33 |
| flacoste | how does that sound? | 15:33 |
| barry | flacoste: +1 | 15:33 |
| barry | [ACTION] flacoste to email RC review policy to list | 15:33 |
| MootBot | ACTION received: flacoste to email RC review policy to list | 15:33 |
| barry | [ACTION] barry to capture RC review policy in a wiki page | 15:33 |
| MootBot | ACTION received: barry to capture RC review policy in a wiki page | 15:33 |
| barry | flacoste: done? | 15:34 |
| flacoste | yep | 15:34 |
| barry | flacoste: thanks | 15:34 |
| barry | that's it for the agenda. we have 10 minute left if anybody has anything else | 15:34 |
| barry | otherwise we can end early! | 15:35 |
| barry | 5 | 15:35 |
| barry | 4 | 15:35 |
| barry | 3 | 15:35 |
| barry | 2 | 15:36 |
| barry | 1 | 15:36 |
| barry | #endmeeting | 15:36 |
| MootBot | Meeting finished at 15:36. | 15:36 |
| barry | thanks everyone! | 15:36 |
| bigjools | cheers barry | 15:36 |
| jtv | thanks barry | 15:36 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!