=== mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell === statik` is now known as statik [15:00] i'll be right with you guys. my machine is acting stupid [15:01] #startmeeting [15:01] Meeting started at 15:01. The chair is barry. [15:01] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:02] hello and welcome everyone to the ameu launchpad reviewers meeting [15:02] who's here today? [15:02] me [15:02] me [15:02] me [15:02] me [15:02] me [15:02] me [15:02] (sprinting) [15:02] me [15:02] me (at least partly) [15:03] which part? :) [15:03] me [15:04] flacoste, schwuk ping? [15:04] me [15:04] me [15:04] [TOPIC] agenda [15:04] New Topic: agenda [15:04] * Roll call [15:04] * Next meeting [15:04] * Action items [15:04] * Queue status [15:04] * Mentoring update [15:04] * jtv graduates [15:04] * schwuk to be mentored by sinzui [15:04] * Review process [15:04] * Tool update [15:04] * Release-critical review (flacoste) [15:04] [TOPIC] next meeting [15:04] New Topic: next meeting [15:04] same time, week += 1? [15:05] anybody know they can't make it? [15:05] me [15:05] I will be on leave [15:05] actually, it's possible i might be late. i have a meeting at my son's school an hour before that [15:05] bigjools: cool [15:05] i might ask someone else to chair it just in case the meeting goes long [15:05] I'll be in leave as well [15:06] schwuk: cool [15:06] s/in/on/ [15:06] [TOPIC] action items [15:06] New Topic: action items [15:06] * intellectronica to put cover letter draft on wiki [15:06] ehm [15:06] :) [15:07] didn't, i suck [15:07] we'll just carry it over then [15:07] * (continued) gmb to work on the review web site [15:07] this topic came up on the asiapac meeting [15:08] thumper has thoughts about using launchpad to help kill off PR and not spending a lot of extra time on a separate project [15:08] thumper is going to write his thoughts up on the wiki [15:08] Well I haven't had a lot of time to spend, so that's fine with me ;) [15:08] gmb: have you gotten a chance to look at review-board? [15:09] barry: No, as I'm sprinting this week without a hotel internet connection :(. But I will as soon as I get chance. [15:09] i wonder if we could do something quick and dirty, like bring that up on devpad while we wait for uber-reviews on lp [15:09] i read the article but haven't had time to grab the code and fire it up [15:10] I wonder how easy it would be to get lp-review working with it... [15:10] does anybody else have thoughts on using review-board in the short term? [15:10] gmb: that, and bzr [15:10] Yes. [15:10] the tricky thing with review-board is getting it to accept our diffs [15:10] I never finished adding bzr support to review-board [15:10] due to lack of time [15:11] statik: did it seem like a lot of work? [15:11] it shouldn't be that hard, but it's more time than I have right now [15:11] the devs would be happy to get a patch for that [15:11] is review-board web-only, or can you access it via a command line tool, or e-mail? [15:11] no email (well, notifications I think) [15:11] web and rest api [15:12] but the review itself is done by clicking in ajaxy things in the web ui [15:12] then it gets a big -1 from me. i don't want to use a browser to do reviews [15:12] -1 [15:13] same here [15:13] -1 [15:13] review-board doesn't solve the PendingReviews problem at all [15:13] * sinzui likes his tools [15:13] ok, then let's not waste any more time on it [15:13] thanks for the feedback! [15:13] * (continued) sinzui to look into running `make lint` and output PR stanza by default in `review-submit` [15:14] barry: I have not...I completely forgot. [15:14] * sinzui sets a todo [15:14] sinzui: np, thanks [15:14] [TOPIC] queue status [15:14] New Topic: queue status [15:14] i know we had a ton of branches while the sprints were happening last week. thanks everyone for working hard to clear the backlog! [15:15] there's still a lot of pink in pending-reviews, but i think we'll catch up [15:15] anybody have any comments on the queue? [15:16] how have on-calls gone this week? any comments on that? [15:16] 5 [15:16] yesterday was fine. didn't have much on-call traffic so i caught up on PR reviews [15:16] For which we thank bac [15:16] I think a couple of sprints have reduced on-call significantly [15:17] indeed, thanks bac! [15:17] we should consider having backup reviewers on-call [15:17] It wouldn't have been so bad, but most of the remaining reviewers were mentees :/ [15:17] indeed [15:18] yep [15:18] I dread putting something on PR and wondering when it will get reviewed! [15:19] bigjools: PR needn't be post-and-forget. even if you have a branch on PR, you can still ping an on-caller if they're available, or your reviewer if need be [15:20] but yeah, if we have more branches than cycles to review them, we need more reviewers or fewer branches [15:20] barry: I can but with timezone issues plus a lack of on-call reviewer it makes it harder [15:20] bigjools: yep [15:20] Could we also ping the on-call and say "have a branch for me?" [15:21] jtv: you mean if you have spare cycles to review stuff? [15:21] barry: right [15:21] jtv: you have spare cycles?! :) [15:21] jtv: grand idea [15:21] barry: no, but I do get pangs of guilt sometimes [15:22] * bigjools has an 800-line soyuz branch waiting for someone just like jtv :) [15:22] jtv: ah yes, guilt can overcome oppressively stressful overworking sometimes :) [15:23] bigjools: jtv is currently reviewing a 2000-line one [15:23] ! [15:23] :-o [15:23] * bac remembers when 2000+ was the norm... :( [15:23] moving on? [15:23] 5 [15:23] 4 [15:24] 3 [15:24] 2 [15:24] 1 [15:24] [TOPIC] mentor updates [15:24] New Topic: mentor updates [15:24] first off: congratulations jtv on graduating [15:24] * jtv bows [15:24] give all your 2000+ branches to him :) [15:24] * jtv runs [15:25] also, welcome schwuk who is joining the team, mentored by sinzui [15:25] thanks sinzui for volunteering to mentor schwuk [15:25] * bigjools high-fives schwuk [15:25] * schwuk starts to wonder what he's let himself in for [15:25] where "volunteering" means "allowing himself to be volunteered by barry" :) [15:26] [TOPIC] review process [15:26] New Topic: review process [15:26] * Tool update [15:26] jtv: weren't you having some trouble with lpreviews? did that get cleared up? [15:27] barry: it did, thanks. [15:27] jtv: great! [15:27] barry: provider may have been guilty. [15:27] jtv: you mean your isp? [15:28] barry: yes. [15:28] jtv: glad it's working now. [15:28] anybody have anything else to discuss on the tool? [15:29] 5 [15:29] 4 [15:29] 3 [15:29] 2 [15:29] 1 [15:29] * Release-critical review (flacoste) [15:29] flacoste: the floor is yours [15:29] ok, this is about clarifying the process around release-critical reviews [15:29] the process should be this: [15:30] 1- when submitting a RC branch for review, make sure that the reviewer is aware that this is a RC branch [15:30] 2- if you cannot complete the RC review, make sure that there is someone assigned to complete the review before you leave [15:30] this means talking to another available reviewer that will do the job once you leave [15:31] we probably need to make the whole team aware of (1) [15:31] any comments? [15:32] sounds good to me [15:32] +1. flacoste, can you capture this on a wiki page? [15:33] barry: i can send an email to the list about this, and I'll let you find a proper place to put that on the wiki [15:33] how does that sound? [15:33] flacoste: +1 [15:33] [ACTION] flacoste to email RC review policy to list [15:33] ACTION received: flacoste to email RC review policy to list [15:33] [ACTION] barry to capture RC review policy in a wiki page [15:33] ACTION received: barry to capture RC review policy in a wiki page [15:34] flacoste: done? [15:34] yep [15:34] flacoste: thanks [15:34] that's it for the agenda. we have 10 minute left if anybody has anything else [15:35] otherwise we can end early! [15:35] 5 [15:35] 4 [15:35] 3 [15:36] 2 [15:36] 1 [15:36] #endmeeting [15:36] Meeting finished at 15:36. [15:36] thanks everyone! [15:36] cheers barry [15:36] thanks barry