=== jamesh_ is now known as jamesh === mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell === barry-away is now known as barry [15:01] #startmeeting [15:01] Meeting started at 15:01. The chair is barry. [15:01] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:01] hello everyone and welcome to this week's ameu reviewer's meeting [15:01] who's here today? [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me === gmb_ is now known as gmb [15:02] [TOPIC] agenda [15:02] New Topic: agenda [15:02] me [15:02] * Roll call [15:02] * Next meeting [15:02] * Action items [15:02] * Queue status [15:02] * Mentoring update [15:02] * Review process [15:02] me [15:03] i think we have a fairly light agenda today so maybe we can end early [15:03] [TOPIC] next meeting [15:03] New Topic: next meeting [15:03] anybody know they cannot make it same bat time next week? [15:04] 5 [15:04] 4 [15:04] 3 [15:04] 2 [15:04] 1 [15:04] [AGREED] meeting same time next week [15:04] AGREED received: meeting same time next week [15:04] [TOPIC] action items [15:04] New Topic: action items [15:04] * intellectronica to put cover letter draft on wiki [15:05] intellectronica: shall we just continue that 'til next week? [15:05] damn, another week passed and i haven't done that [15:05] yes, please [15:05] k [15:05] * (continued) gmb to work on the review web site [15:05] No time to do much really. [15:05] But wasn't reviewboard mooted last week? [15:06] gmb: yeah. i should just take that off [15:06] Right. [15:06] thumper has an action item to write up his thoughts of doing it all in lp [15:06] [ACTION] review web site mooted in favor of an in-LP solution [15:06] ACTION received: review web site mooted in favor of an in-LP solution [15:07] * (continued) sinzui to look into running `make lint` and output PR stanza by default in `review-submit` [15:07] I did not work on lint integration. I do however have a rudimentary doctest style checker and reformatter. [15:07] The PR stanza is have not done as well [15:07] sinzui: will the doctest checker look for things like duplicate or unused imports? [15:08] barry: Not yet...that is one of my promptings to write it [15:08] sinzui: yeah, it's something that's fairly difficult to review [15:09] sinzui: we'll just continue this item to next week then, ok? [15:09] barry: I' [15:09] m torn between simple pyflakes style checking verses extracting the script to run it. [15:09] ok [15:09] sinzui: maybe discuss on the m.l.? [15:09] barry: sure [15:10] sinzui: great. thanks for all the awesome work on make lint [15:10] [TOPIC] * Queue status [15:10] New Topic: * Queue status [15:10] no branches pending review. yay [15:10] pending-reviews looks pretty good to me actually. any feedback from on-call reviewers? [15:11] (except for yours, barry, which you said flacoste is taking care of) [15:11] intellectronica: yep, and that's now in flacoste's queue [15:11] intellectronica: you have number of branches that have not landed yet [15:12] of course, this /is/ week 3 :) [15:12] intellectronica: Do you have dependencies (database?) blocking their landing? [15:12] sinzui: i know. i am landing all of them in one big branch (i am just now looking at why my attempt to land this yesterday failed) [15:14] anything else on the queue topic? [15:14] 5 [15:14] 4 [15:14] 3 [15:14] 2 [15:14] 1 [15:14] [TOPIC] mentoring update [15:14] New Topic: mentoring update [15:15] any feedback from mentors or recruits? [15:15] things going okay? [15:15] no news is good news then :) [15:15] 5 [15:15] 4 [15:16] 3 [15:16] 2 [15:16] things going very well as far as i'm concerned [15:16] intellectronica: great! [15:16] 1 [15:16] [TOPIC] review process [15:16] New Topic: review process [15:16] i really have nothing for this topic. seems to me things are going as smoothly as possible with PR still alive :) [15:17] any concerns, glitches, problems? [15:17] a slight problem [15:18] we sometimes forget to allocate branches that are left on the general queue at the end of a shift [15:18] intellectronica: i realize i forgot to allocate one yesterday. sorry. [15:18] then, we often take fresh on-call reviews before dealing with the ones on the queue [15:18] intellectronica: I am guilty of that. I decided not to allocate a branch that 1400 lines. [15:19] i really think it would be good if we systematically allocate left-over branches, for that reason [15:19] that was 1400 lines [15:19] sinzui: i think that's fine. it's unfair to dump a 1400 line branch on someone (but of course they can always reject it) [15:20] we have a policy with 1400 branches [15:20] the developer was supposed to discuss this with a reviewer first [15:21] so i think it's fair game that the branch linger in PR [15:21] we should contact the developer though [15:21] bac, sinzui: i wasn't referring to any particular instance, just that if we don't do this regularly we penalize people who didn't manage to 'fight' for their branch on #launchpad-reviews [15:22] intellectronica: understood [15:23] me (late) [15:23] I think when allocating branches, we need to review jamesh's page to see how many lines are allocated to each review. [15:23] intellectronica: agreed [15:23] sinzui: yes, i definitely try to do that [15:23] s/review/reviewer/ [15:24] I think I was mean to some review the first time I allocated by not checking how many lines they had in their queue. [15:24] sinzui: remember! reviewers can reject branches by putting them in the reject queue [15:24] i know you feel guilty when you do it, but feeling guilty is better than feeling mad :) [15:25] anything else? [15:26] any topics not on the agenda? [15:26] 5 [15:26] 4 [15:26] 3 [15:26] 2 [15:26] 1 [15:26] #endmeeting [15:26] Meeting finished at 15:26. [15:27] thanks everyone! short and sweet [15:27] thanks barry [15:27] thanks, barry [15:27] Cheers barry === salgado is now known as salgado-lunch === salgado-lunch is now known as salgado