=== kiko is now known as kiko-zzz === mwhudson_ is now known as mwhudson === mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell === kiko-zzz is now known as kiko [15:00] #startmeeting [15:00] Meeting started at 15:00. The chair is barry. [15:00] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:00] hi everybody, and welcome to this week's ameu reviewer's meeting [15:01] who's here today? [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me === danilo_ is now known as danilos [15:02] [TOPIC] agenda [15:02] New Topic: agenda [15:02] me [15:02] == Agenda == [15:02] * Roll call [15:02] * Next meeting [15:02] * Action items [15:02] * Queue status [15:02] * Mentoring update [15:02] * gmb graduates [15:02] * Review process [15:02] [TOPIC] next meeting [15:02] New Topic: next meeting [15:03] same time next week? anybody know they won't be able to attend? [15:03] I won't be here. [15:03] allenap: k, thanks [15:03] On holiday all week to move house. [15:03] me? [15:04] okay, same time next week [15:04] flacoste: hi! :) [15:04] flacoste: yes, you! [15:04] [TOPIC] * Action items [15:04] New Topic: * Action items [15:04] * (continued) intellectronica to put cover letter draft on wiki [15:04] * intellectronica stares at the floor silently [15:04] carry over - i'll get to it one day :( [15:05] intellectronica: ;) ok [15:05] * (continued) sinzui to look into running `make lint` and output PR stanza by default in `review-submit` [15:05] mwhudson accepted by `make lint addition` I have not checked if it is in trunk [15:05] output PR stanza by default is still pending? [15:06] I have not added the PR stanza by default. I'll submit that one line change next [15:07] sinzui: great. i'll leave this item on the list one more week. sounds like next week we can kill it! [15:07] barry: you can edit it though [15:07] flacoste: yes, i'll remove the 'make lint' part [15:08] [TOPIC] queue status [15:08] New Topic: queue status [15:08] the queue looks pretty good from where i stand [15:09] the general queue has two 1.2.3 branches [15:09] and only sinzui's branch is over the sla [15:09] My branch is really needs-reply [15:09] cool [15:09] * sinzui was replying before the meeting [15:09] yeah, danilo and i should be able to finish the general queue by the end of today, if no one requests on call reviews [15:10] intellectronica: excellent! [15:10] any other comments on the queue status? [15:11] 5 [15:11] 4 [15:11] Should we have a limit to how long a branch can be [15:11] in work in progress [15:11] 3 days [15:11] :-) [15:11] sinzui: and if you're over the limit then what, you have to delete the branch and start from scratch? [15:11] intellectronica: from PR at least :) [15:12] guidelines are better than limits [15:12] intellectronica: I'm not certain some of these branches are valid [15:12] we should probably at least remove wips from people who are no longer with the company [15:12] I think it depends upon how people are actually using the WIP section. [15:13] I don't see how's that bothering us? [15:13] When I use it, it's to register that a branch which has been looked at by a reviewer needs more work before it can really be reviewed (i.e. it's been rejected for some reason). [15:13] Does anyone use it for any other reason? For example, does anyone track every branch through WIP? [15:13] i use it just to get pending-reviews to start tracking it [15:13] gmb: same. i never put a branch there until it's already entered the review process [15:13] gmb: it used to be a recommended practice to do that [15:14] gmb: I have used it when I had to rethink a branch when the first review required a reimplementation [15:14] sinzui: Yes, I've encountered that situation too. [15:14] for the reason barry mentioned (put it on pending-reviews, get more visibility to a branch, etc.) [15:14] danilos: Well, that's okay, but does anyone here actually look at WIP regularly? It's not on my radar. [15:15] gmb: i don't, and i don't think it /needs/ to be, except for the occasionally culling by the dev, or maybe in general to remove ex-employee branches [15:15] [ACTION] barry will cull ex-employee branches from wip [15:15] ACTION received: barry will cull ex-employee branches from wip [15:16] i do look at wip branches [15:16] BjornT: you mean you look at the diffs? [15:17] barry: yeah. to see that the implementation approach is sane. [15:18] i don't do it that frequently, but it happens. [15:18] BjornT: do you usually have contact with the dev first, to get some context for the branch? [15:19] does anybody think we need to do more about wip? [15:20] barry: it depends. i usually contact the developer, since the branch might not be on pending-reviews, or it might not be up-to-date [15:20] me! [15:20] salgado: hi! [15:20] anything more about wip branches? [15:20] or the queue in general? [15:21] well, speaking of wip branches [15:21] i wouldn't mind if there was an easy way of looking at current diffs. i don't think PendingReviews is the way to go, though; i rarely add my branches there, since i'm too lazy [15:22] BjornT: do it for all branches in /code/*/launchpad/*? [15:22] That's a looooot of branches. [15:22] i.e. show diffs for them, having developers move them out once they land [15:22] danilos: but devs would have to be more diligent about clearing out devpad (which i don't do very often) [15:23] barry: I don't either, but I know some who do (like jtv :)) [15:23] it shouldn't be too hard to do a 'mv branch archive/' once you land something, imo [15:23] * barry only does it when there's a naming conflict with one of his old branches ;) [15:23] danilos: no. i'd rather have some meta-data to track which branches are wip [15:23] barry: push --overwrite ;) [15:24] gmb: yay! [15:24] BjornT: people will still be lazy to update meta-data [15:24] danilos: not if it's done pretty much automatically :) [15:25] BjornT: I guess you have some idea about how that would work then [15:25] for example. when a branch is created, it's wip. when it's submitted for review, it's needs-review. [15:25] all branches could be considered wip until you review-submit them [15:25] flipping a state from wip to needs-review would be nice [15:26] that's meta-data saying that a branch is _not_ wip :0 [15:26] s/0/)/ [15:27] well, unless there's a specific proposal, maybe we should move on? [15:28] 5 [15:28] 4 [15:28] 3 [15:28] 2 [15:28] 1 [15:28] [TOPIC] mentoring update [15:28] New Topic: mentoring update [15:28] * gmb graduates [15:28] yay, gmb! [15:28] * flacoste cheers [15:28] \0/ [15:28] excellent [15:28] well done [15:28] gmb: do you keep the same review shift? [15:29] hurrah! [15:29] intellectronica, good question [15:29] gmb, I think one of us should change the shift [15:29] salgado: I agree. [15:30] since always when we were doing the same shift I was mostly mentoring your reviews and there as nothing else for me to review [15:30] Actually, we've got pretty good coverage on most days. Hmm. [15:30] salgado: I'll change shift. I think it's better that you stay on on Thursdays. [15:30] we need more on-call euro reviewers monday, tuesday and Friday for Europe AM [15:30] if that's the case I guess we could both stay on Thusday... [15:31] * flacoste votes for friday [15:31] yeah, before sinzui arrives on Friday :) [15:31] monday only has barry PM [15:31] yeah, but nothign is left on monday :-) [15:31] lol [15:31] I'll happily take Friday if that's okay with sinzui. [15:31] and nobody is ever rushed to get something reviewed on monday [15:31] gmb: i'd love to get another monday asiapac or eu slot at least to cover for us holidays, which tend to be on monday [15:31] flacoste: I leave branches that are over 800 lines for barry [15:31] barry: Monday's good for me too. [15:31] sinzui: :) [15:32] gmb: \o/ [15:32] barry: I'll leave the choice to you; you're best placed to know where I'd be more useful. [15:32] sinzui: you gotta stop working weekends, man! [15:32] barry: ...and do what, crosswords? [15:32] * sinzui hacked on his editor on the weekend [15:32] gmb: let's try mondays and see how it goes. it's easy to switch [15:32] sinzui: i hear gedit development is stalled since you started doing review shifts ;) [15:33] barry: Okay. I'll update the OCR page. [15:33] gmb: thanks! though i think it's gonna be a while before the next us holiday (easter maybe?) [15:34] [ACTION] gmb to take eu monday OCR slot [15:34] ACTION received: gmb to take eu monday OCR slot [15:34] [TOPIC] review process [15:34] New Topic: review process [15:34] well, i really have nothing here. anybody have any further comments or observations? [15:35] our review team tocks! [15:35] And ticks [15:35] rocks even! [15:35] indeed! [15:35] big round of applause for the team! [15:36] * barry claps [15:36] hurrah [15:36] not golf applause barry: footban hooligans style please! [15:37] * barry slams his hands raw and screams his voice hoarse [15:37] * flacoste rocks the casbah [15:37] * barry ignores the concerned look from his cat [15:37] * sinzui just bangs the rocks together. [15:37] * bigjools sings songs about the referee being a wanker [15:37] :) [15:38] * barry thinks this meeting might be over [15:38] anything else? [15:38] 5 [15:38] 4 [15:38] 3 [15:38] 3 [15:38] 2 [15:38] 1 [15:39] :) [15:39] #endmeeting [15:39] Meeting finished at 15:39. [15:39] thanks barry [15:39] thanks barry [15:39] yay, thanks everyone... especially danilos :) [15:39] thanks guys, especially barry :) [15:39] ciao [15:39] see ya === salgado is now known as salgado-lunch === kiko is now known as kiko-fud === salgado-lunch is now known as salgado === kiko-fud is now known as kiko === salgado is now known as salgado-afk