[03:00] <barry> hello and welcome to this week's asiapac launchpad reviewer's meeting
[03:00] <barry> is anybody here today? :)
[03:01] <barry> jamesh, mwhudson ?
[03:01] <jamesh> hi
[03:01] <barry> jamesh: hi.  is it even worth having this meeting today?
[03:01] <mwhudson> hello
[03:02] <jamesh> barry: a short meeting wouldn't hurt
[03:02] <barry> great.  i'm just glad i remembered this week :)
[03:02] <barry> [TOPIC] agenda
[03:02] <barry> == Agenda ==
[03:02] <barry>  * Roll call
[03:02] <barry>  * Next meeting
[03:02] <barry>  * Action items
[03:02] <barry>  * Queue status
[03:02] <barry>  * Mentoring update
[03:02] <barry>  * Review process
[03:02] <barry>    * sabdfl request: make sure enums to be in the same interface files as the schemas where they are expressed.
[03:02] <barry>    * thumper - unwrapping import statements (line wrapping that is)
[03:03] <barry>    * drive-by copyright year updates
[03:03] <barry> (we can blow through this pretty quickly)
[03:03] <barry> [TOPIC] next meeting
[03:03] <barry> same time next week?  i guess most people will be back from sprinting and meetings by then?
[03:03] <jamesh> sure.
[03:03] <mwhudson> makes sense to me
[03:03] <barry> great
[03:03] <barry> [TOPIC] action items
[03:04] <barry> thumper's not here and his was the only continued item
[03:04] <barry> [TOPIC] queue status
[03:04] <barry> #startmeeting
[03:04] <MootBot> Meeting started at 03:04. The chair is barry.
[03:04] <MootBot> Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE]
[03:04] <barry> crap, helps if i turn on mootbot
[03:04] <mwhudson> :)
[03:05] <barry> [TOPIC] queue status
[03:05] <MootBot> New Topic:  queue status
[03:05] <jamesh> I'm currently working on stub's one, and am also on call
[03:05] <mwhudson> jml's is merge-approved, really
[03:05] <barry> jamesh: great thanks. i couldn't quite finish sinzui's before i had to leave for the evening, but i'm going to try to finish it tonight
[03:06] <jamesh> jml is assigned one of cprov's branches which could be a problem
[03:06] <barry> it's a big branch iirc
[03:06] <jamesh> the other branches owned by jml and thumper are for other people who are sprinting
[03:07] <barry> are they generating the branches during the sprint?
[03:07] <jamesh> I have no idea
[03:07] <mwhudson> i don't think so
[03:07] <jamesh> the team leads probably won't, and the bzr sprinters would be working on bzr stuff
[03:08] <barry> so they're probably not itching for their lp branches
[03:08] <barry> anything else going on about the queue?
[03:09] <barry> [TOPIC] mentoring update
[03:09] <MootBot> New Topic:  mentoring update
[03:09]  * mwhudson is slightly surprised to see a branch he thought he'd landed still on there
[03:09] <mwhudson> (but not on-topic for this meeting)
[03:09] <mwhudson> barry: a bit fat "n/a" to this one?
[03:09] <barry> i think so!
[03:10] <barry> [TOPIC] review process
[03:10] <MootBot> New Topic:  review process
[03:10] <barry>    * sabdfl request: make sure enums to be in the same interface files as the schemas where they are expressed.
[03:10] <barry> this was from a couple of weeks ago, but because i missed last week's meeting here, i wanted to keep it on the list
[03:10] <mwhudson> noted
[03:10] <jamesh> noted.
[03:11] <barry> great, thanks
[03:11] <barry>    * thumper - unwrapping import statements (line wrapping that is)
[03:11] <barry> there was a vote on this at the last ameu meeting.  it was rejected ;)
[03:11] <barry> i'm thinking of keeping it on the list so thumper has a chance to defend his position
[03:11] <jamesh> I had no real opinion on this one way or the other when it came up in the branch I was reviewing
[03:12] <jamesh> barry: did you see thumper's reasoning in the review where it came up?
[03:12] <barry> jamesh: i didn't
[03:12]  * jamesh looks
[03:13] <jamesh> """I have personally found that the import areas are a high source of merge conflicts.
[03:13] <jamesh> Something that the bzr hackers do is to split them like this once there is more than
[03:13] <jamesh> one line of imports.  This is especially useful in places where there is a high likelyhood
[03:13] <jamesh> of different people editing the file at the same time.  This way the bzr merge code
[03:13] <jamesh> and just insert the new imports instead of conflicting."""
[03:14] <barry> ah.  that did come up when we discussed it. the general consensus was that it wasn't hard to resolve the conflicts and people didn't want to read through a page of imports
[03:14] <jamesh> so his reasoning is for usability reasons rather than style
[03:14] <jamesh> okay.
[03:15] <jamesh> It hasn't often been a problem for me -- if the list of imports is so large that it is a problem, then the file probably has too much code in it :)
[03:15] <mwhudson> we need an import-aware merge algorithm!
[03:15] <barry> jamesh: agreed! :)
[03:15] <mwhudson> but i don't really see this as a big problem
[03:15] <barry> mwhudson: +1
[03:15] <mwhudson> mash the import statements together, M-x sort-imports, run pyflakes
[03:15] <barry> i'll relay the decision to thumper and we can put it back on the agenda if he wants
[03:15] <barry> mwhudson: yep, that was basically the consensus!
[03:16] <barry> moving on...
[03:16] <barry>    * drive-by copyright year updates
[03:17] <barry> i've started to see some branches trickle in with updates to the copyright line.  i guess we don't have a script that fixes these, but do we have a policy about them?
[03:17] <barry> or is it cool to just fix 'em as you see em?
[03:17] <jamesh> Is there a particular problem we're trying to solve here?
[03:18] <mwhudson> i'm never really sure what these copyright lines are for, truth be told
[03:18] <barry> not a particularly serious one imo since we don't release the code
[03:18] <jamesh> I mean, there is no problem with people updating the copyright lines, but it probably doesn't make a difference
[03:18] <barry> but ianal
[03:18] <barry> jamesh: that's the way i feel about
[03:18] <barry> it
[03:18] <jamesh> any code that does get released will need the copyright headers changed to something other than "All rights reserved" anyway
[03:19] <barry> it's kind of silly that those lines are there at all i guess :)
[03:19] <mwhudson> right
[03:19] <jamesh> barry: it is worth having there in case a file gets separated from the tree
[03:20] <jamesh> for the same reason people license headers in the source code that they release
[03:20] <barry> right, but anything that gets released will need to be vetted anyway
[03:20] <barry> but i guess we're getting off track.
[03:21] <jamesh> yes
[03:21] <barry> it's okay if people update them in their branch, but we don't care too much
[03:21] <barry> anyway, that's it for me.  anything you guys want to relay to the ameu crowd?
[03:21] <jamesh> yep (although reviewers should still be making sure that a license header appears in new files)
[03:21] <barry> yep, definitely
[03:22] <jamesh> nothing from me.
[03:22] <mwhudson> me neither
[03:23] <barry> cool
[03:23] <barry> well, thanks guys and talk to you soon!
[03:23] <barry> #endmeeting
[03:23] <MootBot> Meeting finished at 03:23.