[03:00] hello and welcome to this week's asiapac launchpad reviewer's meeting [03:00] is anybody here today? :) [03:01] jamesh, mwhudson ? [03:01] hi [03:01] jamesh: hi. is it even worth having this meeting today? [03:01] hello [03:02] barry: a short meeting wouldn't hurt [03:02] great. i'm just glad i remembered this week :) [03:02] [TOPIC] agenda [03:02] == Agenda == [03:02] * Roll call [03:02] * Next meeting [03:02] * Action items [03:02] * Queue status [03:02] * Mentoring update [03:02] * Review process [03:02] * sabdfl request: make sure enums to be in the same interface files as the schemas where they are expressed. [03:02] * thumper - unwrapping import statements (line wrapping that is) [03:03] * drive-by copyright year updates [03:03] (we can blow through this pretty quickly) [03:03] [TOPIC] next meeting [03:03] same time next week? i guess most people will be back from sprinting and meetings by then? [03:03] sure. [03:03] makes sense to me [03:03] great [03:03] [TOPIC] action items [03:04] thumper's not here and his was the only continued item [03:04] [TOPIC] queue status [03:04] #startmeeting [03:04] Meeting started at 03:04. The chair is barry. [03:04] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [03:04] crap, helps if i turn on mootbot [03:04] :) [03:05] [TOPIC] queue status [03:05] New Topic: queue status [03:05] I'm currently working on stub's one, and am also on call [03:05] jml's is merge-approved, really [03:05] jamesh: great thanks. i couldn't quite finish sinzui's before i had to leave for the evening, but i'm going to try to finish it tonight [03:06] jml is assigned one of cprov's branches which could be a problem [03:06] it's a big branch iirc [03:06] the other branches owned by jml and thumper are for other people who are sprinting [03:07] are they generating the branches during the sprint? [03:07] I have no idea [03:07] i don't think so [03:07] the team leads probably won't, and the bzr sprinters would be working on bzr stuff [03:08] so they're probably not itching for their lp branches [03:08] anything else going on about the queue? [03:09] [TOPIC] mentoring update [03:09] New Topic: mentoring update [03:09] * mwhudson is slightly surprised to see a branch he thought he'd landed still on there [03:09] (but not on-topic for this meeting) [03:09] barry: a bit fat "n/a" to this one? [03:09] i think so! [03:10] [TOPIC] review process [03:10] New Topic: review process [03:10] * sabdfl request: make sure enums to be in the same interface files as the schemas where they are expressed. [03:10] this was from a couple of weeks ago, but because i missed last week's meeting here, i wanted to keep it on the list [03:10] noted [03:10] noted. [03:11] great, thanks [03:11] * thumper - unwrapping import statements (line wrapping that is) [03:11] there was a vote on this at the last ameu meeting. it was rejected ;) [03:11] i'm thinking of keeping it on the list so thumper has a chance to defend his position [03:11] I had no real opinion on this one way or the other when it came up in the branch I was reviewing [03:12] barry: did you see thumper's reasoning in the review where it came up? [03:12] jamesh: i didn't [03:12] * jamesh looks [03:13] """I have personally found that the import areas are a high source of merge conflicts. [03:13] Something that the bzr hackers do is to split them like this once there is more than [03:13] one line of imports. This is especially useful in places where there is a high likelyhood [03:13] of different people editing the file at the same time. This way the bzr merge code [03:13] and just insert the new imports instead of conflicting.""" [03:14] ah. that did come up when we discussed it. the general consensus was that it wasn't hard to resolve the conflicts and people didn't want to read through a page of imports [03:14] so his reasoning is for usability reasons rather than style [03:14] okay. [03:15] It hasn't often been a problem for me -- if the list of imports is so large that it is a problem, then the file probably has too much code in it :) [03:15] we need an import-aware merge algorithm! [03:15] jamesh: agreed! :) [03:15] but i don't really see this as a big problem [03:15] mwhudson: +1 [03:15] mash the import statements together, M-x sort-imports, run pyflakes [03:15] i'll relay the decision to thumper and we can put it back on the agenda if he wants [03:15] mwhudson: yep, that was basically the consensus! [03:16] moving on... [03:16] * drive-by copyright year updates [03:17] i've started to see some branches trickle in with updates to the copyright line. i guess we don't have a script that fixes these, but do we have a policy about them? [03:17] or is it cool to just fix 'em as you see em? [03:17] Is there a particular problem we're trying to solve here? [03:18] i'm never really sure what these copyright lines are for, truth be told [03:18] not a particularly serious one imo since we don't release the code [03:18] I mean, there is no problem with people updating the copyright lines, but it probably doesn't make a difference [03:18] but ianal [03:18] jamesh: that's the way i feel about [03:18] it [03:18] any code that does get released will need the copyright headers changed to something other than "All rights reserved" anyway [03:19] it's kind of silly that those lines are there at all i guess :) [03:19] right [03:19] barry: it is worth having there in case a file gets separated from the tree [03:20] for the same reason people license headers in the source code that they release [03:20] right, but anything that gets released will need to be vetted anyway [03:20] but i guess we're getting off track. [03:21] yes [03:21] it's okay if people update them in their branch, but we don't care too much [03:21] anyway, that's it for me. anything you guys want to relay to the ameu crowd? [03:21] yep (although reviewers should still be making sure that a license header appears in new files) [03:21] yep, definitely [03:22] nothing from me. [03:22] me neither [03:23] cool [03:23] well, thanks guys and talk to you soon! [03:23] #endmeeting [03:23] Meeting finished at 03:23. === Odd_Blok1 is now known as Odd_Bloke === salgado is now known as salgado-lunch === salgado-lunch is now known as salgado === mwhudson_ is now known as mwhudson === thumper_laptop is now known as thumper === salgado is now known as salgado-afk === salgado-afk is now known as salgado