=== Fujitsu_ is now known as Fujitsu === thumper_laptop is now known as thumper === bigjools-afk is now known as bigjools === cprov is now known as cprov-lunch === thumper_laptop is now known as thumper [15:00] #startmeeting [15:00] Meeting started at 15:00. The chair is barry. [15:00] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:00] hello everybody and welcome to this week's ameu reviewer's meeting. who's here today? [15:00] me [15:01] me [15:01] me [15:01] me [15:01] * gmb listens to the wind blowing around the mostly empty meeting [15:01] yeah, the asiapac meeting was pretty sparse too. sprints and team-leads meeting [15:02] hopefully then we can make this quick. [15:02] [TOPIC] agenda [15:02] New Topic: agenda [15:02] * Roll call [15:02] * Next meeting [15:02] * Action items [15:02] * Queue status [15:02] * Mentoring update [15:02] * Review process [15:02] * sabdfl request: make sure enums to be in the same interface files as the schemas where they are expressed. [15:02] * thumper - unwrapping import statements (line wrapping that is) [15:02] * drive-by copyright year updates [15:03] [TOPIC] next meeting [15:03] New Topic: next meeting [15:03] i will be traveling to pycon next week. can someone else chair this meeting? [15:03] barry: can we have MootBot do it? :) [15:04] :) [15:04] other than that, does anybody else know they will not be here for the next meeting, same time and place? [15:04] also note that i will miss the 3/19 meeting too [15:04] barry: I think you're better mailing the list about next week's chair. [15:05] gmb: +1 [15:05] [ACTION] barry email list about needing a chair for the next two weeks [15:05] ACTION received: barry email list about needing a chair for the next two weeks [15:05] [TOPIC] action items [15:05] New Topic: action items [15:05] * intellectronica to solicit feedback on ReviewRequestTemplate from launchpad [15:05] mailing list. [15:05] i think this was done [15:05] Yes, it was. [15:06] cool [15:06] * barry to communicate to l-r list that when allocating general queue [15:06] reviews, please favor (but don't overwhelm) new recruits [15:06] done [15:06] * barry to communicate to l-r list that >800 line branches need to be [15:06] arranged with a reviewer '''before''' they are submitted [15:06] done [15:06] * gmb to hack review-submit to enforce 800 line limit. [15:06] Done, but I need to run it past mwhudson. [15:07] So leave it as an action for next week, I think. [15:07] gmb: cool, np [15:07] gmb: thanks [15:07] np [15:07] [TOPIC] queue status [15:07] New Topic: queue status [15:07] me! sorry i'm late [15:07] i think intellectronica and danilo kicked ass today [15:07] We have a volunteer for a chair [15:07] last night the general queue was huge. today, it's small [15:07] yeah, we are both on last branches in general queue [15:08] (both by barry) [15:08] statik: wow, thanks for chairing this meeting for the next two weeks! :) [15:08] danilos: you rock [15:08] * gmb chuckles at intellectronica's email. [15:08] we have 6 pink branches, with 3 of those in conflict [15:08] barry: I deserve that. sure , I can do that [15:09] statik: it's okay if you can't or don't want to :) [15:09] intellectronica would be here but millbank caught fire so he's gone home :) [15:09] jeebus [15:09] i vill do it [15:09] I think "caught fire" might be an exaggeration [15:09] statik: awesome thanks. [15:10] salgado: what's up with julian's embargoed-archive branch? [15:10] barry, I think it's been approved already [15:11] salgado: oh cool, PR probably wasn't update. no wories [15:11] and I forgot to update its status [15:11] [TOPIC] mentoring update [15:11] New Topic: mentoring update [15:11] any mentors or mentoree comments today? [15:12] I should give more branches to schwuk [15:13] sinzui: give them /all/ to schwuk and take the weekend off :) [15:14] barry: to hack of formatdoctest,py? [15:14] sinzui: :) [15:14] [TOPIC] review process [15:14] New Topic: review process [15:14] * sabdfl request: make sure enums to be in the same interface files as the schemas where they are expressed. [15:14] have i mentioned that one here before? [15:14] Yes, last week, I believe :) [15:14] yes [15:15] * barry needs some ginko [15:15] There is always an issue of circular imports that must be reconciled. [15:15] sinzui: yep [15:15] though for the one specific instance i changed, it wasn't a problem [15:16] e.g. from canonical.launchpad.interfaces.teammembership import TeamMembership [15:16] (or whatever) [15:16] * barry skips thumper's proposal which we rejected last week [15:16] * drive-by copyright year updates [15:16] I can fix that with sed in a few minutes. [15:17] sinzui: do you want to take that as an action item? [15:17] sinzui: you'll need something to do this weekend :) [15:18] barry: we /seriously/ want all the 2007 => 2008? [15:18] well, i don't think it's a big deal personally [15:18] I can do it. It wont take long. [15:19] i think it's fine to do it as a drive-by but if you're motivated, rs=barry :) [15:19] * sinzui still has a trailing whitespace script sitting in Tomboy [15:19] [ACTION] sinzui to sed-ify update to copyright years [15:19] ACTION received: sinzui to sed-ify update to copyright years [15:19] I'm pretty sure we've got files which have 2006 as the last year [15:19] or even 2005 or 2004 [15:19] danilos: we're all over the map [15:19] i'm sure we have files that have only one year in them [15:20] danilos: right [15:20] sinzui: oh, btw, i have a python script that does this for mailman. might be easily adapted, if sed isn't your bag [15:20] sinzui: it handles copyrights with only one year in them [15:21] I don't think it's a big deal either (once we start opening up parts of LP, we might want to take a look over that, but no big deal atm) [15:21] barry: I also have a my own find script written in Python that should be upgraded to do replace. [15:21] barry: sorry - got delayed [15:21] sinzui: cool. i'll leave it to you then [15:21] schwuk: np [15:21] danilos: agreed [15:22] well, anyway that's it for me today. i'll open up the floor in case y'all have anything not on the agenda [15:22] I have one thought. [15:22] Which is this: [15:22] Can people, devs and reviewers alike, *please* make sure to Reply All to review emails rather than just replying to the list. [15:23] The conversation should be between reviewer and developer with a copy going to the list. [15:23] +1 [15:23] gmb: +1 [15:23] +1 [15:23] Emailing the list directly and not at least CCing the reviewer means that it can get filtered away. [15:24] gmb: do you want me to send an email on that? [15:24] barry: If you would, yes. [15:24] * gmb gets off his soapbox [15:24] Thanks. [15:24] [ACTION] barry will email about cc policy on reviews [15:24] ACTION received: barry will email about cc policy on reviews [15:24] well, I'd say people should generally use "Reply-All" ("follow up") anyway, except when they specifically target a person (to exclude everybody else) [15:25] danilos: Yes. It seems, though, that quite a few people do "reply to list" instead of "reply all" [15:25] email is for old people [15:25] I think it's habit for mutt users to hit "L" when replying to mailing list messages ;) [15:25] gmb: I found that the headers sometimes seem a bit different when an email finally hits launchpad-reviews list [15:25] danilos: Is there some munching going on? [15:26] Munching? [15:26] Munging. [15:26] i don't think so. should definitely not be munging reply-to [15:26] for example, I've seen my emails get there without CCs to my mentor or a developer, even if they got their messages [15:26] Hmm. [15:27] danilos: Now that you mention it, I saw that whilst salgado was metoring me. His replies would go to the developer and the list, but not to me directly. [15:27] for example, look at my emails from today: I've sent them all to tom.berger@ as well, and that's not showing up in the list [15:28] barry: This might be worth looking into, though I haven't got the first clue about why it'd be happening. [15:28] gmb: what would barry know about mailing lists anyway? ;) [15:28] actually, nothing :) [15:28] Harsh. [15:28] * barry has no clothes [15:29] I hope that's an emperor metaphor... [15:29] * sinzui hands barry a banana leaf [15:29] gmb: i haven't noticed a problem with ml traffic. can you or danilos email specifics and/or an example? [15:29] barry: I'll see if I can find one in my archives. [15:30] gmb: take it anyway you want. i'm not saying :) [15:30] barry: sure, I can send you both what my client sent, and you can have a look at the same message in launchpad-reviews [15:30] gmb, danilos cool [15:30] anything else today? [15:31] 4 [15:31] 5 [15:31] er [15:31] 5 [15:31] 4 [15:31] 3 [15:31] 2 [15:31] 1 [15:31] #endmeeting [15:31] Meeting finished at 15:31. [15:31] thanks everyone! [15:31] Cool, thanks barry. === salgado is now known as salgado-lunch === salgado-lunch is now known as salgado === mwhudson_ is now known as mwhudson