=== mwhudson_ is now known as mwhudson === kiko is now known as kiko-zzz === kiko-zzz is now known as kiko === mrevell is now known as mrevell-luncheon === mrevell-luncheon is now known as mrevell === salgado is now known as salgado-brb === salgado-brb is now known as salgado [15:00] #startmeeting [15:00] Meeting started at 16:00. The chair is barry. [15:00] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:00] hello everyone and welcome to this week's ameu reviewer's meeting [15:00] who's here today? [15:00] me, myself, and I [15:00] me [15:00] me [15:00] me [15:00] me === gmb_ is now known as gmb [15:00] em [15:00] me [15:00] me [15:01] me [15:01] me [15:01] me [15:02] me [15:02] great! [15:03] [TOPIC] next meeting [15:03] New Topic: next meeting [15:03] same time and place? anybody know they won't be here or if that time is bad? [15:03] me [15:03] time isn't bad, i'm just late :-) [15:03] flacoste: not as bad as me with the last asiapac meeting ;) [15:04] great, next week, same time and place [15:04] [TOPIC] action items [15:04] New Topic: action items [15:04] * gmb to add lpreview to sourcecode and hack rf-setup to link it in [15:04] gmb: didn't i see some updates to that on the ml today? [15:04] So. [15:04] I've got a patch for rf-setup. [15:06] gmb's got some freenode connectivity problems [15:06] Oy. [15:06] Which are hopefully resolved. [15:07] gmb: np, if you want we can move on? [15:07] barry: did you see any of my messages about getting lpreview into sourcecode? [15:07] gmb: no, last thing you said was: [15:07] I've got a patch for rf-setup. [15:07] Ah, right. [15:07] So. [15:08] I finally remembered to contact mthaddon about getting it into sourcecode [15:08] But he's having problems pulling the branch from devpad (specifically bug 217701) [15:08] So I don't know when this is going to be complete. [15:08] I'll keep on top of it though. [15:08] gmb: thanks! do you want me to keep this action item on the list until it's completed? [15:09] barry: Please. [15:09] gmb: cool, thanks [15:09] There's nothing like a looming action item to remind me :) [15:09] speaking of which... [15:09] * barry to email about submit_branch vs public_branch [15:09] done. just. :) [15:10] we can discuss that one further on the ml [15:10] * allenap to update PR and communicate to team new rejection policy [15:10] I think I did that. [15:10] allenap: i think you did too! thanks [15:10] btw, i brought this up at the last asiapac meeting and everyone thought it was a good idea too [15:10] allenap: so thanks! [15:10] Great. [15:11] * bigjools to take brace closing policy to ml [15:11] which was done too [15:11] done, but sorry I've not pushed to a resolution yet [15:11] leading to an action item for me: [15:11] bikeshedding is going on [15:11] * bigjools to take brace closing policy to ml [15:11] * bigjools gets deja vu [15:11] flacoste: you read the asiapac notes, didn't you? :) [15:11] flacoste: That means something different to me than it does to you, I hope... [15:11] barry: indeed :-) [15:11] :-D [15:12] I liked the colours [15:12] * bigjools also wonders what bikeshedding is [15:12] bigjools: http://pink.bikeshed.org/ [15:12] flacoste: no, he wants http://mediumorchid.bikeshed.org/ [15:13] ah [15:13] anyway, i will try to drive us to a decision this week and we'll codify it in our style guide [15:13] bigjools: thanks, i'm marking your action item as done! [15:13] * bac to (re-)email the list about his PendingReviews notifier cronscript [15:13] done [15:13] PEP8 is generally "bikeshedding" in that case :) [15:14] bigjools: actually, that has a better explanation: http://www.freebsd.org/doc/en_US.ISO8859-1/books/faq/misc.html#BIKESHED-PAINTING [15:14] bac: yep, thanks! i tried it but i'm not getting the emails when run under cron so i have to figure out what's going on. but when run from hand, it worked just fine [15:14] barry I thought https://lists.ubuntu.com/mailman/private/launchpad/2008-April/027347.html was your final opinion on the closing brace. [15:15] sinzui: i'm happy to call the discussion over then :) [15:15] will follow up on the ml [15:15] [TOPIC] queue status [15:15] New Topic: queue status [15:16] i know there were 12 branches on PR when i finished my OCR. thanks everyone for cranking away on these [15:16] i think we're largely caught up? [15:16] completely [15:16] you guys totally rock [15:17] barry: the only problem was you put four branches on my queue on Monday, and I was out until today. [15:17] schwuk: sorry about that. didn't realize you were out. :( [15:17] Two went to on-call, one is done and one is in progress, so they're caught up with. [15:17] btw, my apologies to the mentorees. i loaded you guys up :) [15:17] schwuk: actually, you should put a note in your queue when not avqailable [15:18] that applies to everybody, btw ^^^ [15:18] flacoste: +1 [15:18] flacoste: I know - I realised afterwards. However the canonicaladmin and the team calendar was updated. [15:18] can I put a note in saying that soyuz is destroying my social life? :) [15:18] No worries barry, you gave me two of my own branches, which meant I had an opportunity to try out the new rejection policy :) [15:18] lol [15:19] allenap: i did that on purpose then :) [15:19] allenap: yeah, sorry about that [15:19] anything else on the queue? [15:19] barry: It was fine, I noticed it pretty soon, so they didn't get old. [15:20] allenap: great. and the rejection policy worked out okay? [15:20] barry: I can confirm that it went smoothly and according to expectations. [15:20] allenap: fantastic [15:20] 5 [15:20] barry: I've got a number of merge-approved branches in my queue from Friday. Can I just remove them, or wait for the owners to cleanup? [15:21] schwuk: the owners are supposed to clean them up, but i've found that often doesn't happen. if they're still in your queue after they land, you can delete them yourself [15:21] we should send an email to remind people to clean up PR when their branch lands - again [15:21] bigjools: +1 [15:21] schwuk: I often remove landed branches [15:22] it wastes my time to find out if they landed or not [15:22] bigjools: good idea. btw, pending-reviews will tell you if they've landed because the branch will have a strike-thru [15:22] bigjools: but i agree, owners should clean up after themselves. will you send that email? [15:22] sure [15:23] * schwuk nudges gmb_ intellectronica, cprov, BjornT, and bigjools to clean up their branches in his queue [15:23] [ACTION] bigjools to email list about curbing your branches [15:23] ACTION received: bigjools to email list about curbing your branches [15:23] mine's not landed yet :p [15:23] schwuk: be my guest, you can clean them yourself ;) [15:24] bigjools: fair enough [15:24] of course it would have if PQM had not gone fubar yesterday [15:25] [TOPIC] * Mentoring update [15:25] New Topic: * Mentoring update [15:25] Schwuk has kept me very bussy [15:25] schwuk: Done [15:25] any thing on this topic? just a reminder that i'll solicit for graduations and new recruits after week 4 [15:26] sinzui: Don't want you getting bored :) [15:26] * sinzui hacks on launchpad when he is board [15:26] or bored [15:26] or boared [15:26] * jtv doesn't want to know about that bit... [15:27] boring [15:27] * gmb_ resists a "squeal piggy" joke [15:27] * sinzui was thinking of Oblix [15:27] [TOPIC] * Review process [15:27] New Topic: * Review process [15:28] i have nothing on this topic, so i'll throw it open to the floor [15:28] * barry hears crickets [15:28] 5 [15:28] 4 [15:28] ehm [15:29] some folks can't use the review plugin [15:29] we should try to get it sorted, since using the review plugin is now mandatory [15:29] https://bugs.edge.launchpad.net/bzr-lpreview/+bug/195217 [15:29] https://bugs.edge.launchpad.net/bzr-lpreview/+bug/195217 [15:29] Launchpad bug 195217 in bzr-lpreview "ReadOnly error when running bzr review-submit" [Undecided,New] [15:29] bac, you win [15:30] i think i had that once, but i "fixed" it by blowing away my rf working tree and re-branching it [15:30] I suspect that there aren't that many eyeballs on the lpreview bugs. [15:30] I know I haven't had much chance to look at them recently. [15:31] And I suspect that mwhudson_ is in the same kind of position (or worse) [15:31] yeah, we should all chip in on this [15:31] +1 [15:32] barry: wow, could you comment in the bug. that's a bit brute force, but if it works... [15:32] intellectronica suggested we get abel to do more experimentation and add info to the bug report, since he can reproduce it. [15:32] [AGREED] we should all chip in on watching lpreview bugs [15:32] AGREED received: we should all chip in on watching lpreview bugs [15:32] intellectronica: will do [15:32] i'll contact abel to ask him for more info [15:32] barry: Could you add an action item for me to prod mwh about the 800-line limit patch I did? [15:33] I know he had some concerns about it but I haven't heard from him since, so I need to chase it up. [15:33] [ACTION] gmb to prod mwh again about the 800-line limit patch [15:33] ACTION received: gmb to prod mwh again about the 800-line limit patch [15:34] Ta [15:34] we have some time left; does anybody have anything else not on the agenda? [15:34] 5 [15:34] I was wondering if we all feel comfortable reviewing Javascript? [15:35] Hmm. [15:35] sinzui: and css [15:35] Do we have JS coding standards? [15:35] It's not really my forte certainly. [15:35] allenap: sort of, yes [15:35] who are our js experts? [15:35] intellectronica [15:35] SteveA [15:35] there's a wiki page, and we try to update it when we can [15:36] any one else? [15:36] I'm not bad at js. [15:36] probably sinzui [15:36] I was reviewing one of bigjools's branches. I knew several ways of doing something, but I decided to confer with intellectronica because we do not have a lot of rulings about how we write code. [15:36] i'm always happy to give advice if someone reviews js code and they aren't sure [15:37] * bigjools 's js came from Google, it must have been perfect already [15:37] and if, like sinzui did, this results in a nice addition to the coding standards wiki page, even better [15:37] intellectronica: can you add a link to the js styleguide on this page: https://launchpad.canonical.com/TipsForReviewers [15:37] barry: sure thing [15:38] [ACTION] intellectronica to add js styleguide link to TipsForReviewers [15:38] ACTION received: intellectronica to add js styleguide link to TipsForReviewers [15:38] intellectronica: thanks [15:39] intellectronica, SteveA, sinzui can you put together some resources or ideas for helping others on the team get more proficient at reviewing js? [15:39] barry: I have some I can add. [15:39] i think this would also help us as devs as we start incorporating more js onto the site [15:39] * sinzui may want css in there too since they are connected in the browser engines. [15:39] sinzui: awesome, thanks. add it to the js styleguide i think [15:39] sinzui: yes, definitely [15:40] i don't think we have a css styleguide, so i think it makes sense to combine the two, do you? [15:40] i don't think css and js should be together [15:41] barry: The style object in JS depends a lot on the CSS engine. You cannot make assumptions when working with that, but that is the only intersection. [15:41] and i think we should ask mpt to own the css guide, because he's probably the most knowledgable about it [15:41] fair enough [15:41] [ACTION] sinzui to update js styleguide page with helpful resources [15:41] ACTION received: sinzui to update js styleguide page with helpful resources [15:42] okay, 3 minutes left. anything else? [15:43] #1 on the CSS style guide: Stop ordering the style sheet chronologically! [15:44] Oh, that would be bad [15:44] mpt! is there a css styleguide and if not can you put one together? [15:44] mpt: how should we order them, then? === kiko is now known as kiko-afk [15:45] barry, no, and yes, in my copious spare time [15:45] mpt ;) [15:45] intellectronica, for starters, there are sections in the style sheet for each application [15:46] okay, we're out of time [15:46] nearest to the subject matter (related selectors) to take precedence without stealing precedence for other rules. [15:46] Code, Bugs, Blueprints, etc [15:46] #endmeeting [15:46] So one very helpful step would be putting app-specific styles in their proper sections. [15:46] Meeting finished at 16:46. [15:46] thanks everyone [15:46] thanks barry === kiko-afk is now known as kiko === kiko is now known as kiko-fud === salgado is now known as salgado-lunch === kiko-fud is now known as kiko === salgado-lunch is now known as salgado === kiko is now known as kiko-afk === salgado is now known as salgado-afk === mwhudson_ is now known as mwhudson