=== jml` is now known as jml === salgado-afk is now known as salgado === mrevell is now known as mrevell-lunch [15:00] #startmeeting [15:00] heh [15:00] hello everyone and welcome to this week's ameu reviewer's meeting [15:00] i know a lot of people are away, but who's here today? [15:00] me === sinzu1 is now known as sinzui [15:00] me [15:00] me [15:00] me [15:00] me [15:00] me [15:00] me [15:01] me [15:01] me [15:01] sorry, everyone, for allenap and mine no-show today. we've been working very hard on that hacking thing [15:01] http://farm3.static.flickr.com/2395/2511062130_f148267b7f.jpg [15:02] intellectronica: why is allenap smiling? that doesn't look like work! :) [15:02] barry: something to do with JSON marshaling, iirc [15:02] * Roll call [15:02] * Next meeting [15:02] * Action items [15:02] * Queue status [15:02] * Mentoring update [15:02] * Review process [15:02] * Help people learn how big branches can be split up (BjornT) [15:02] * Adopt mars suggestion for more-specific imports; don't do multiline imports; communicate decision. [15:03] * Next meeting [15:03] everyone okay with week += 1 [15:03] anybody know of sprints or holidays, or know you won't be here? [15:04] i won't be here, i'll be on vacation [15:04] I won't be here. vacation as well [15:04] me [15:04] cool [15:04] * Action items [15:04] as in, me here today, though late [15:04] * barry drive to decision about multiline sequences [15:05] so we've made a decision: we're going to adopt mars's suggestion and not multiline imports. hopefully that will cut down on conflicts, but even if it doesn't, it'll be a win [15:06] as we're all agreed __init__.py's import-*'s suck :) [15:06] [ACTION] barry to update style guides and email ml [15:06] * barry to solicit ideas to better handle review scheduling and workload [15:06] not done [15:07] * flacoste to add `safe_hasattr()` to `lazr.utils` [15:07] i suck [15:07] carry on [15:07] ;) [15:07] * bjorn to add recommendation to test style guide saying don't use asserts in doctests [15:07] That will wait until a week 0 [15:07] i don't think BjornT is here [15:07] so we'll just carry on [15:08] barry: He's in a UDS session, I think. [15:08] * Queue status [15:08] gmb: np [15:08] salgado: you're switching ocr today, is that right? [15:08] barry, that's right [15:09] will update the wiki [15:09] salgado: thanks for helping out w/coverage! [15:09] looks like we have a few pink branches [15:10] EdwinGrubbs: what's happening w/ the cprov and julian branches? [15:10] barry: I think they are done except for mentoring possibly. [15:10] they have been mentored [15:11] I think [15:11] cool, so just waiting to land? [15:11] I think it's just the status that hasn't been updated [15:11] np [15:11] schwuk: any word on the adeuring #1 branch? [15:12] barry: in progress [15:12] salgado: you did, I will reply it this evening. Sorry for the delay. [15:12] * schwuk forgot to check pending reviews and missed it [15:12] schwuk: cool, thanks. iirc, there was reluctance to start on the 2 and 3 branches until the first one got reviewed [15:12] I think splitting a large branch and submitting all the parts at once is unfair. [15:12] schwuk: you should check out bac's script :) [15:13] barry,sinzui : we talked to abel about it yesterday. he said they are pretty dependent. 2 & 3 should be withdrawn [15:13] barry: I had it running, but I broked it :( [15:13] sinzui: if they are highly intertwined [15:13] but due to abel being at UDS i didn't get to talk with him directly [15:13] bac: ok, thanks for the feedback. i'll remove those branches from PR [15:14] bac: and email abel so he knows to resubmit them when he gets #1 through [15:14] anything else on the queue? [15:14] barry: also make sure he knows about the depends option in review-submit [15:14] bac: good point! [15:15] moving on... [15:15] * Mentoring update [15:15] any feedback, issues? [15:16] * Review process [15:16] * Help people learn how big branches can be split up (BjornT) [15:17] well, we didn't really reach any conclusions on this one, but for the folks working on abel's branch, can you think about this some and make any (general) suggestions to the ml? [15:18] * Adopt mars suggestion for more-specific imports; don't do multiline imports; communicate decision. [15:18] already mentioned. [15:18] anyway, that's all i have on the agenda. does anybody have any other topics? [15:19] I think splitting a large branch and submitting all the parts at once is unfair. [15:19] sinzui: huh? [15:19] you should submit as soon as the code is available [15:19] I think that stands as a topic. The last branch is in a precarious position. [15:20] A mistake in the bottom of the design may topple the top branch [15:20] and even mundane changes can bubble through all parts causing the reviewers to do extra work [15:21] intellectronica: I agree that once a chunk of code is ready for review, it should be. [15:21] true, but i think if you already reached the point where you have all code ready at once there isn't much that can be done about this [15:21] we should pay attention to 'Depends:' in the submission, and try to spot problematic cases [15:22] also, it should be the responsibility of the developer to sort out effective reviews [15:22] well, the pre-impl should have helped with any design issues, no? [15:22] Yep [15:22] A pre-imp should estimate the number of lines required and plan the branches [15:23] sinzui: +1 [15:23] intellectronica: true, but devs should be conscious of not wasting reviewers time, so they should be highly confident their branches are solid [15:23] and if not, get more up-front help in planning the branches [15:23] If a branch is a few lines over the limit, fair enough. If it's 100+ lines over then the work hasn't been chunked properly (see pre-imp calls) [15:23] schwuk: b.t.w did you have a pre-imp with abel? you are the developer most likely to be able to have an effective one with him [15:24] intellectronica: no, and he's not listed a pre-imp call on the review request. [15:26] i will mention this to him, when i email him about his branches [15:26] barry: I've queried it in my review as well. [15:27] schwuk: thanks [15:28] anything else? [15:29] #endmeeting [15:29] thanks everyone! [15:29] thanks barry === salgado is now known as salgado-lunch === salgado-lunch is now known as salgado === Rinchen` is now known as Rinchen === salgado is now known as salgado-afk