| === Moot2 is now known as MootBot | ||
| barry | hello everybody and welcome to this weeks asiapac reviewers meeting | 03:00 |
|---|---|---|
| barry | who's here today? | 03:00 |
| jml | hi! | 03:00 |
| mwhudson | hi! | 03:00 |
| mwhudson | wow, i am _actually here_! | 03:00 |
| barry | :) | 03:01 |
| jml | also, I really need to make my IRC ident like yours barry | 03:01 |
| thumper | hi | 03:01 |
| barry | jml: use your time machine and sign up at freenode 12 years ago :) | 03:01 |
| thumper | hmm, mine used to be like barry's | 03:01 |
| jml | barry: I'm dead certain you weren't working at Canonical 12 years ago. | 03:02 |
| jml | barry: and it was called openprojects back then anyway :) | 03:02 |
| barry | oh that! ask kiko i think :) | 03:03 |
| barry | anyway... | 03:03 |
| barry | == Agenda == | 03:03 |
| barry | * Roll call | 03:03 |
| barry | * Next meeting | 03:03 |
| barry | * Action items | 03:03 |
| barry | * Queue status | 03:03 |
| barry | * Mentoring update | 03:03 |
| barry | * Review process | 03:03 |
| barry | * Help people learn how big branches can be split up (BjornT) | 03:03 |
| barry | * (Julian) Since I seem to be finding it hard to get my Soyuz comrades to follow our own informal coding standards, when reviewing Soyuz code please make sure you don't let code of the form: ` if archive.purpose == ArchivePurpose.PPA:` land, instead it should be the simpler: `if archive.is_ppa:` which not only encapsulates the decision in IArchive, it should remove an import of the DBEnum. | 03:03 |
| barry | * Next meeting | 03:03 |
| barry | week += 1? | 03:03 |
| jml | +1 | 03:03 |
| thumper | yeha | 03:04 |
| jml | I mean, r=jml | 03:04 |
| * thumper ment yeah | 03:04 | |
| barry | :) | 03:04 |
| thumper | not cowboy mode | 03:04 |
| mwhudson | sure | 03:04 |
| barry | thumper: that would be yee haw | 03:04 |
| barry | cool | 03:04 |
| barry | * Action items | 03:04 |
| barry | actually, i forgot to remove thumper's ai, so there really is nothing | 03:05 |
| mwhudson | hooray | 03:05 |
| barry | * Queue status | 03:05 |
| barry | 3 on PR | 03:05 |
| * jml looks | 03:06 | |
| barry | 6 pinks (tho we won't count stubs branch) | 03:06 |
| barry | jml: your branch got rejected? | 03:06 |
| * mwhudson tries to remember if jml asked him to look at the stacking puller | 03:07 | |
| jml | barry: because the bzr branch it depends on is unfetchable. | 03:07 |
| barry | jml: ! | 03:07 |
| jml | barry: I need to fix it up. | 03:07 |
| jml | I've had other things to do, I'm afraid. | 03:07 |
| barry | ah well | 03:07 |
| * barry didn't get to nearly as many branches as he'd hoped today | 03:08 | |
| jml | it's not an immediate concern because we aren't going to land it until the bazaar changes we need are in trunk. | 03:08 |
| jml | the review process doesn't have a clear place for this sort of thing. | 03:08 |
| barry | jml: not a WIP? | 03:08 |
| jml | barry: the Launchpad part of the code is done. | 03:09 |
| barry | jml: no biggie if the branch'll be ready soon. if not, just remove it from PR and add it back when you're ready | 03:09 |
| jml | ok. | 03:10 |
| barry | anything else on the queue? | 03:10 |
| jml | I'm not sure I understand the question | 03:11 |
| * thumper doesn't look very often any more | 03:11 | |
| barry | er, sorry. any other queue related comments? | 03:11 |
| jml | no :) | 03:11 |
| barry | i'll skip mentoring | 03:12 |
| jml | good good. | 03:12 |
| barry | i don't think i have anything else to say about bjorn's item, except that i think he was going to take it to the ml | 03:12 |
| barry | * (Julian) Since I seem to be finding it hard to get my Soyuz comrades to follow our own informal coding standards, when reviewing Soyuz code please make sure you don't let code of the form: ` if archive.purpose == ArchivePurpose.PPA:` land, instead it should be the simpler: `if archive.is_ppa:` which not only encapsulates the decision in IArchive, it should remove an import of the DBEnum. | 03:12 |
| barry | bigjools was going to start a page for product-specific coding guidelines | 03:13 |
| jml | hmm. | 03:13 |
| barry | e.g. what should soyuz devs and reviewers look for | 03:13 |
| barry | etc. | 03:13 |
| thumper | hah | 03:13 |
| thumper | I'm thinking of a bzrlp specific guidelines | 03:13 |
| thumper | * use unit tests | 03:13 |
| thumper | :-) | 03:13 |
| jml | barry: I'm not sure that this is such a good idea. | 03:14 |
| barry | jml: why not? | 03:14 |
| mwhudson | thumper: as opposed to doctests you mean? | 03:14 |
| jml | * are they really unit-y? no? go back and try again. | 03:14 |
| thumper | mwhudson: yeah | 03:14 |
| jml | barry: a couple of reasons | 03:14 |
| mwhudson | 'read xunit test patterns' | 03:14 |
| jml | barry: the example that Julian gives could probably be enforced in code, rather than by review, by making 'purpose' a private attribute | 03:15 |
| jml | or protected or however zope spells it. | 03:15 |
| jml | barry: also, it feels kind of a roundabout way of getting the soyuz team clear on their own abstractions. | 03:16 |
| barry | jml: it's also to get reviewers who aren't as familiar with the internal conventions, to know what to look for | 03:17 |
| jml | barry: I'm not strongly opposed to the idea, but... | 03:17 |
| barry | jml: i think what you're saying is that there should be one obvious way to do it, even if you're not dutch | 03:18 |
| jml | barry: yeah, that's kind of what I'm saying. | 03:18 |
| barry | it's a good point | 03:18 |
| jml | barry: in fact, that's very much what I'm saying :) | 03:18 |
| * barry chants the zop | 03:19 | |
| jml | barry: I think there's a stronger case for having review guidelines split by service types rather than by team. | 03:20 |
| barry | jml: i'll communicate that on to the ameus | 03:20 |
| mwhudson | jml: 'service types' ? | 03:20 |
| barry | jml: what do you mean? | 03:20 |
| jml | barry: webapp, package builder, codehosting etc. | 03:20 |
| jml | because they are actually quite different areas and hard to navigate if you aren't familiar | 03:20 |
| jml | but then the guidelines wouldn't be so much "Use the provided interface" as brief tours | 03:21 |
| barry | hard too to remember if you're not deep in it every day | 03:21 |
| jml | so maybe forget I said anything. | 03:21 |
| jml | or rather, I think it's a good idea, but it's heading off topic | 03:22 |
| barry | well, i agree that it would be good to have better roadmaps for functional areas. this would especially help new devs | 03:22 |
| jml | the sort of thing that fits on to one A3 page. | 03:22 |
| barry | yeah | 03:23 |
| barry | anyway, that's all i have for today. anything more from y'all? | 03:23 |
| * jml thinks | 03:23 | |
| jml | barry: nope. | 03:24 |
| barry | alrighty then, have a great week. g'night :) | 03:24 |
| mwhudson | g'night bazza | 03:25 |
| jml | barry: g'night. | 03:25 |
| jml | mwhudson: heh. | 03:25 |
| === mwhudson__ is now known as mwhudson | ||
| === cprov is now known as cprov-lunch | ||
| === cprov-lunch is now known as cprov | ||
| === salgado-afk is now known as salgado | ||
| === mrevell is now known as mrevell-lunch | ||
| === mrevell-lunch is now known as mrevell | ||
| === salgado is now known as salgado-lunch | ||
| === cprov is now known as cprov-out | ||
| === salgado-lunch is now known as salgado | ||
| Rinchen | yay! | 21:19 |
| Rinchen | Mootbot works! | 21:19 |
| === salgado is now known as salgado-afk | ||
| === mwhudson__ is now known as mwhudson | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!