| Jazzva | Sorry, xchat works (I tried to do something else before)... But still nothing for pidgin | 00:01 |
|---|---|---|
| Jazzva | Are you using the liferea from intrepid or hardy? | 00:01 |
| fta | intrepid | 00:02 |
| fta | but iirc, it was on hardy too | 00:02 |
| fta | started a few months ago | 00:02 |
| Jazzva | Ok, I'll test both... | 00:02 |
| Jazzva | If it happened few months ago, then it is probably a bug in liferea :/ | 00:02 |
| Jazzva | Yep. Liferea in hardy shows the same behaviour as Pidgin... | 00:05 |
| fta | maybe the notification area applet | 00:06 |
| Jazzva | I suppose... | 00:06 |
| Jazzva | To report a bug upstream? | 00:06 |
| Jazzva | (unless they say it's a feature :)) | 00:07 |
| fta | i doubt it, it's a regression imho | 00:07 |
| Jazzva | I suppose they have some sort of BTS... | 00:07 |
| fta | can't find anything related in launchpad | 00:28 |
| Jazzva | fta: This might be useful - http://sourceforge.net/tracker/?atid=581684&group_id=87005 | 00:29 |
| Jazzva | well, at least for reporting a new bug... it doesn't list any bug with "workspace" in summary | 00:31 |
| fta | hmm, could be a gtk bug | 00:38 |
| Jazzva | Well, if one group of programs has one behaviour, and the other has different behaviour, then it might be the way programmers wrote the programs. | 00:38 |
| fta | i'm reading liferea's code | 00:39 |
| Jazzva | I can help you with xchat's code in 10-20 minutes, if you want... | 00:39 |
| fta | xchat is fine for me | 00:40 |
| Jazzva | It's fine for me too... We could try to look for the code that does on_notification_hide/show/click/whatever_is_its_name in both programs and compare the differences :) | 00:41 |
| fta | ok, this is bogus | 00:48 |
| fta | if((gdk_window_get_state(GTK_WIDGET(mainwindow)->window) & GDK_WINDOW_STATE_ICONIFIED) || !GTK_WIDGET_VISIBLE(mainwindow)) { | 00:48 |
| Jazzva | that's for showing window? | 00:48 |
| fta | that's the test to see if the window must be hidden or made visible | 00:49 |
| Jazzva | Could you paste that piece of code to paste.ubuntu? I would like to see it | 00:51 |
| fta | gdk_window_get_state(GTK_WIDGET(mainwindow)->window) & GDK_WINDOW_STATE_ICONIFIED returns 2 when the window is visible in another workspace | 00:55 |
| Jazzva | And it's recognized as true, if it's not 0 | 00:55 |
| fta | and returns 0 when it's invisible (docked) or visible in the current worspace | 00:56 |
| Jazzva | Aha | 00:56 |
| fta | !GTK_WIDGET_VISIBLE(mainwindow)) is fine | 00:56 |
| ubottu | fta: Error: I am only a bot, please don't think I'm intelligent :) | 00:56 |
| fta | lol | 00:56 |
| Jazzva | hehe | 00:56 |
| Jazzva | Should the first part check if it in another dock, or invisible? | 00:57 |
| Jazzva | *it's | 00:58 |
| Jazzva | *Shouldn't | 00:58 |
| fta | http://paste.ubuntu.com/18200/ | 00:58 |
| Jazzva | ui_mainwindow_save_position() only saves X and Y values? | 00:59 |
| Jazzva | *saves only (note to self: learn to write) | 01:00 |
| fta | http://paste.ubuntu.com/18201/ | 01:00 |
| Jazzva | thanks | 01:00 |
| Jazzva | Yep, x, y and w, h | 01:01 |
| fta | and panes, but not workspace, it's window manager's business | 01:01 |
| fta | if i iconify liferea in the current workspace, the 1st test returns 2 too :( | 01:02 |
| fta | so visible in a different workspace = iconified for gtk | 01:03 |
| fta | damn | 01:03 |
| fta | damn, gdk_window_get_state(GTK_WIDGET(mainwindow)->window) returns 2 so it's not even a mask issue | 01:07 |
| Jazzva | http://library.gnome.org/devel/gdk/unstable/gdk-Event-Structures.html#GdkWindowState | 01:08 |
| fta | yes, that confirms it | 01:09 |
| fta | xchat may do something different | 01:10 |
| Jazzva | I'll take a look now | 01:10 |
| Jazzva | just to downlaod it | 01:11 |
| Jazzva | *download | 01:11 |
| Jazzva | fta: This is the code which is called when on window hide/show | 01:24 |
| Jazzva | http://paste.ubuntu.com/18207/ | 01:24 |
| Jazzva | for xchat | 01:24 |
| Jazzva | Do you thank that changing it to GTK_WIDGET_VISIBLE in liferea would do any good? | 01:25 |
| Jazzva | s/changing/using/ | 01:25 |
| Jazzva | s/it to // | 01:25 |
| Jazzva | That is, just removing the first check in if | 01:26 |
| Jazzva | leaving it to if(!GTK_WIDGET_VISIBLE(mainwindow)) | 01:26 |
| fta | maybe. but the code is there for a reason. do we have a vcs to look for blame ? | 01:28 |
| Jazzva | Found one in debian | 01:29 |
| Jazzva | Vcs-Browser: http://git.debian.org/?p=collab-maint/liferea.git | 01:29 |
| Jazzva | not useful... | 01:29 |
| Jazzva | here's upstream: http://liferea.svn.sourceforge.net/viewvc/liferea/ | 01:30 |
| fta | not enough history :( | 01:35 |
| fta | but this also means that code is old, so something else caused the regression | 01:36 |
| Jazzva | Well, maybe there was the change to that part... the revision list for it is long | 01:37 |
| Jazzva | http://liferea.svn.sourceforge.net/viewvc/liferea/trunk/liferea/src/ui/ui_mainwindow.c?view=log | 01:37 |
| fta | that function didn't change in 2.5y | 01:37 |
| fta | or more | 01:37 |
| Jazzva | damn | 01:38 |
| fta | indeed, that fixes it http://paste.ubuntu.com/18214/ | 01:41 |
| Jazzva | Woohoo, we rock :) | 01:41 |
| Jazzva | Are you gonna forward it upstream, to see if they want to include that change? :) | 01:42 |
| fta | the only problem is that if you iconify it, you have to click twice to make it reappear | 01:42 |
| Jazzva | And now it's only once? | 01:43 |
| fta | no, that's now | 01:43 |
| fta | after the patch | 01:43 |
| fta | that may be the purpose of the 1st test | 01:43 |
| Jazzva | Maybe... But, I don't see how it can be related to the mouse click | 01:44 |
| Jazzva | Maybe it's get_state function | 01:44 |
| fta | eh? ui_mainwindow_toggle_visibility() is called after the mouse click is detected | 01:45 |
| Jazzva | Then again, the function should be called based on event that is caused by a click. | 01:45 |
| fta | it is | 01:45 |
| Jazzva | Well, maybe we can just change it to react to a click, instead of a double-click | 01:45 |
| fta | i said click twice, not double click ;) | 01:46 |
| Jazzva | Oooh... right :) | 01:46 |
| fta | it's a status issue | 01:46 |
| Jazzva | So, if it's visible on another workspace, GTK_WIGDET_VISIBLE might return true, therefore going the the else-branch and hiding the window | 01:47 |
| fta | yes | 01:47 |
| Jazzva | And then on second click it shows the window, since G_W_V is false | 01:47 |
| fta | hence the GDK_WINDOW_STATE_ICONIFIED test | 01:47 |
| fta | which is buggy | 01:48 |
| Jazzva | damn | 01:48 |
| Jazzva | there must be some other way. | 01:48 |
| Jazzva | Do you know if GTK is aware of current workspace? | 01:48 |
| Jazzva | and the workspace window is on? | 01:48 |
| fta | no idea | 01:48 |
| fta | at least we've cornered the bug | 01:49 |
| Jazzva | Right :) | 01:49 |
| Jazzva | Now just to find something that will do the "curWorkspace != windowWorkspace" check | 01:50 |
| Jazzva | :) | 01:50 |
| fta | i'm not sure it's possible | 01:50 |
| Jazzva | Neither am I... As you said, it's WM's job. | 01:50 |
| Jazzva | Dunno if this check is worth it | 01:53 |
| Jazzva | GDK_WINDOW_STATE_WITHDRAWN the window is not shown. | 01:53 |
| fta | the test returns only 0 or 2 | 01:54 |
| fta | so GDK_WINDOW_STATE_ICONIFIED or nothing | 01:54 |
| Jazzva | But gtk_window_get_state can return any of the states (0, 1, 2, 4, ... ) | 01:55 |
| fta | yes, but here, it's 0 or 2 | 01:55 |
| fta | sorry :) | 01:55 |
| Jazzva | sniff | 01:55 |
| fta | indeed | 01:55 |
| Jazzva | liferea makes little bunny cry | 01:56 |
| Jazzva | But, should the withdrawn state mean something like "it's not on this workspace, or it's minimized, or something similar" | 01:56 |
| Jazzva | ? | 01:56 |
| fta | donno | 01:57 |
| Jazzva | Neither do I... Just guessing :) | 01:58 |
| fta | http://ubuntuforums.org/showthread.php?t=821994 | 02:06 |
| Jazzva | heh ... | 02:07 |
| Jazzva | fta, in what IDE did you test liferea? | 02:08 |
| fta | printf() | 02:09 |
| fta | :) | 02:09 |
| Jazzva | Nice one :)... so, you edited the file, built it and then just watched the result? | 02:09 |
| fta | yes | 02:09 |
| Jazzva | Ok, I just have to try that with withdrawn state ... it bugs me :) | 02:10 |
| fta | fprintf(stderr, "something"); to be sure it's not buffered or logged somewhere in X | 02:10 |
| Jazzva | (even if it won't work) | 02:10 |
| Jazzva | thanks :) | 02:10 |
| Jazzva | fta, xchat works with two clicks too... | 02:12 |
| Jazzva | And they also test just GTK_WIDGET_VISIBLE | 02:13 |
| fta | so that's expected | 02:13 |
| Jazzva | But, true... it would be good if it could just switch workspace with one click :) | 02:13 |
| Jazzva | fta: This is what I get from gtk_window_get_state: | 02:47 |
| Jazzva | gtk_w_g_s == 0gtk_w_g_s == 1gtk_w_g_s == 0gtk_w_g_s == 1gtk_w_g_s == 2gtk_w_g_s == 3gtk_w_g_s == 0 | 02:47 |
| Jazzva | for various clicks (depending on state and workspace) | 02:48 |
| Jazzva | and this is for output: fprintf(stderr, "gtk_w_g_s == %d", gdk_window_get_state(GTK_WIDGET(mainwindow)->window)); | 02:50 |
| Jazzva | fta: So, it seems it returns 0 when the window is on current workspace and we iconify it | 03:02 |
| Jazzva | 1 when we restore it and it was iconified it from the current workspace | 03:03 |
| Jazzva | 2 when the window is not on the current workspace, and we iconify it | 03:03 |
| Jazzva | and 3 when we restore it, and it wasn't iconified from the current workspace | 03:03 |
| Jazzva | Now I'm confused. How it returns this numbers, and GdkWindowState only knows for 0, 1, 2, 4, 8 (and 16) | 03:04 |
| Jazzva | Ok, let's change for 2, and 3 | 03:05 |
| Jazzva | for 2, is not on the current workspace, or it is minimised | 03:05 |
| Jazzva | same for 3, it also returns that if it was minimised | 03:06 |
| Jazzva | I'm gonna print all states, so to see which one is what number. I'm confused | 03:07 |
| Jazzva | fta: ok, all states are ok. 1, 2, 4, 8, 16, 32 and 64. But gtk_window_get_state() still returns 0... Why? | 03:26 |
| === asac_ is now known as asac | ||
| Jazzva | asac: there? Maybe? :) | 12:09 |
| Jazzva | gnomefreak: There? | 12:12 |
| gnomefreak | im here sort of | 12:13 |
| gnomefreak | i cant open bug 1 and i really need to | 12:13 |
| ubottu | gnomefreak: Error: Could not parse data returned by Launchpad: The read operation timed out (https://launchpad.net/bugs/1/+text) | 12:14 |
| gnomefreak | ubottu: its ok | 12:14 |
| ubottu | Factoid its ok not found | 12:14 |
| Jazzva | I think it's Launchpad... It is opening for me, but slowly | 12:15 |
| Jazzva | Regarding agenda items for the meeting. We shouldn't fill the "Decision" column before meeting. Can you move them to "Notes" column? I don't know where would you put them, so I didn't touch them. And I fixed that last agenda item, so now it's ok | 12:15 |
| Jazzva | gnomefreak: I was wondering if you know do we use #ubuntu-meeting or -mozillateam for the meeting? | 12:16 |
| Jazzva | And if we use the first channel, where do we "make a reservation for it" or something? | 12:17 |
| gnomefreak | Jazzva: we will use -meeting but i will set that up this week' | 12:19 |
| gnomefreak | Jazzva: i got that handled | 12:19 |
| gnomefreak | i hate assholes | 12:19 |
| Jazzva | gnomefreak: Ok, I'll just send the announcment to the list and members. | 12:20 |
| gnomefreak | Jazzva: hold off on that for now | 12:20 |
| gnomefreak | i need to make sure noone has claimed that spot yet | 12:20 |
| Jazzva | Ok | 12:20 |
| gnomefreak | i will do after i finish my email | 12:20 |
| gnomefreak | Jazzva: ok wiki is fixed | 12:32 |
| Jazzva | k | 12:32 |
| gnomefreak | next i will work on -meeting | 12:32 |
| gnomefreak | give me some time on that since its sunday morning | 12:32 |
| gnomefreak | Jazzva: wtf | 12:32 |
| gnomefreak | Jazzva: i got rid of the last comment and the whole fucking thing comes undone | 12:33 |
| gnomefreak | hmmmm | 12:34 |
| Jazzva | It's fixed. There was a space at the end of the line | 12:35 |
| gnomefreak | Jazzva: can you please let me know how to fix that so i can stop it from happening | 12:35 |
| gnomefreak | ah | 12:35 |
| gnomefreak | you have got to be kidding me | 12:35 |
| Jazzva | Nope... that breaks the formatting :) | 12:35 |
| gnomefreak | Jazzva: thanks | 12:35 |
| gnomefreak | thats not fixed | 12:35 |
| gnomefreak | now 2nd one is borkee | 12:35 |
| gnomefreak | borkled | 12:35 |
| Jazzva | Really? Ok, I'll look again. It's still saving the current one. | 12:36 |
| gnomefreak | thanks | 12:36 |
| Jazzva | np | 12:36 |
| gnomefreak | i need smoke | 12:36 |
| Jazzva | Ok... where can we check ubuntu-meeting availability? | 12:37 |
| gnomefreak | Jazzva: i have sunbird do that for me | 12:42 |
| gnomefreak | Jazzva: fridge.ubuntu.com | 12:42 |
| Jazzva | Thanks :) | 12:42 |
| gnomefreak | its clear | 12:42 |
| Jazzva | Can we reserve it for 22nd June, 20:00 UTC+2? | 12:43 |
| gnomefreak | Jazzva: working on it | 12:43 |
| Jazzva | Sent the announcement... | 12:46 |
| gnomefreak | Jazzva: i know a few people that edit the fridge and im trying them first there is also a email to request meetings with but #fridge is being moved to #ubuntu-news so im replying on editors i know since neither channel lists the email address | 12:46 |
| gnomefreak | Jazzva: thanks. where? | 12:47 |
| Jazzva | list and members. I couldn't find some members' e-mails, though. | 12:47 |
| gnomefreak | ah ok | 12:47 |
| Jazzva | [reed], if you read this the Mozilla team meeting is on 22nd June, 20:00 UTC+2 in #ubuntu-meeting. I couldn't find your e-mail, and I'm not sure if you're on the list | 12:49 |
| gnomefreak | wait a minute please use UTC not UTC+2 :( | 12:49 |
| * gnomefreak writing email | 12:49 | |
| gnomefreak | so thats -600 for me? | 12:50 |
| Jazzva | Yes. | 12:50 |
| Jazzva | I'll edit the wiki page. | 12:50 |
| gnomefreak | 1400 == 2pm | 12:50 |
| Jazzva | right | 12:50 |
| gnomefreak | im asking cody i wish i didnt have to | 12:53 |
| gnomefreak | i have email ready to send but he said i can ask there so lets see what he says | 12:53 |
| Jazzva | Ok, I changed the times on the wiki pages... | 12:54 |
| gnomefreak | and i added the time link | 12:55 |
| gnomefreak | wiki is slow today | 12:56 |
| Jazzva | :) | 12:56 |
| gnomefreak | Jazzva: now when you click the time/date you get a conversion chart | 12:57 |
| gnomefreak | :) once it saves | 12:57 |
| Jazzva | Right... but you set it for 3rd June, 9pm :) | 12:57 |
| gnomefreak | http://fridge.ubuntu.com/node/1516 | 12:57 |
| gnomefreak | Jazzva: i didnt change the date or time | 12:58 |
| gnomefreak | i just added the link | 12:58 |
| gnomefreak | When: [WWW] Sunday, 22nd June 2008, 18:00 UTC | 12:58 |
| gnomefreak | looks goo to me | 12:58 |
| gnomefreak | good | 12:58 |
| gnomefreak | our meeting is set up for #ubuntu-meeting | 12:59 |
| Jazzva | Following the link: "Time is fixed on Tuesday, June 3, 2008 at 21:00:00 UTC time" | 12:59 |
| gnomefreak | thats odd ok ill change it | 12:59 |
| Jazzva | k | 12:59 |
| gnomefreak | ok saving | 13:00 |
| gnomefreak | http://www.timeanddate.com/worldclock/fixedtime.html?month=6&day=22&year=2008&hour=18&min=0&sec=0&p1=0 | 13:00 |
| Jazzva | great :) | 13:01 |
| gnomefreak | and sunbird updated already :) | 13:02 |
| gnomefreak | Jazzva: ok i got your post, just one thing to add. If you add agenda item you should show up or it will be skipped and called at end of meeting if you still are not there i will be reviewed for another meeting time (god only know when that will be) i think i will add agenda item to regularize meetings maybe 1 a month or something | 13:06 |
| Jazzva | I'll be there :) | 13:07 |
| gnomefreak | me too as of right this minute | 13:07 |
| gnomefreak | i have my sister coming to town on the 15-16th and i think shes staying for a week so i should be good | 13:07 |
| gnomefreak | Jazzva: i accepted your post to list since you are not a member | 13:08 |
| Jazzva | I'm not? | 13:08 |
| gnomefreak | Jazzva: not from the email i got | 13:08 |
| Jazzva | Hmm... I thought I subscribed. | 13:08 |
| gnomefreak | As list administrator, your authorization is requested for the | 13:08 |
| gnomefreak | following mailing list posting: | 13:08 |
| gnomefreak | List: Ubuntu-mozillateam@lists.ubuntu.com From: jazzva@gmail.com Subject: Mozilla Team meeting Reason: Too many recipients to the message | 13:08 |
| gnomefreak | At your convenience, visit: | 13:09 |
| gnomefreak | https://lists.ubuntu.com/mailman/admindb/ubuntu-mozillateam | 13:09 |
| gnomefreak | maybe that email isnt but another one? | 13:09 |
| Jazzva | I don't use another one :)... | 13:09 |
| gnomefreak | oh | 13:10 |
| gnomefreak | dont know than | 13:10 |
| Jazzva | Ok, tried to subscribe again. It says I'm subscribed. Perhaps not everyone is allowed to post to the list :). | 13:12 |
| gnomefreak | not sure you should have been | 13:12 |
| Jazzva | It's no prob... | 13:12 |
| gnomefreak | i got post before the admin request | 13:12 |
| gnomefreak | and than after it too | 13:12 |
| gnomefreak | Jazzva: are you german or dutch? | 13:13 |
| Jazzva | Neither, I'm from Serbia :) | 13:15 |
| gnomefreak | asac: is so maybe he will read his email and translate this bug | 13:16 |
| shirish | gnomefreak: hey | 14:00 |
| shirish | ff3rc1 is in intrepid, not RC2 which got released just couple of days ago. | 14:00 |
| shirish | AFAIK | 14:00 |
| gnomefreak | oh yeah sorry, let me check something | 14:03 |
| gnomefreak | ah thats why i have it | 14:04 |
| gnomefreak | shirish: sorry i have RC2 in intrepid | 14:04 |
| gnomefreak | shirish: it will be done sometime this week but as i recall not much changed from RC1>RC2 and not sure if anything was linux side | 14:04 |
| shirish | gnomefreak: you're subscribed to somebody's PPA, for I don't see it in the builds. | 14:05 |
| gnomefreak | shirish: they will push it out as soon as they can, its a weekend though | 14:05 |
| gnomefreak | shirish: i have my own as well i have like 4 PPAs i grab packages from | 14:05 |
| shirish | right. I understand that | 14:05 |
| shirish | gnomefreak: can u just mail me the changelog so I know what the changes that have been pushed through in RC2. | 14:06 |
| gnomefreak | shirish: keep something in mind our PPAs always have latest snapshot <perrelease packages> and once we add our fixes they get uploaded to official repos | 14:06 |
| gnomefreak | shirish: i can give you link i think | 14:07 |
| shirish | that would be cool enough | 14:07 |
| shirish | gnomefreak: I'm not looking to subscribe to the PPA, but definitely interested in knowing what changes to expect. | 14:08 |
| gnomefreak | well mozillas release notes suck but here they are http://www.mozilla.com/en-US/firefox/3.0rc2/releasenotes/ as for our changes there hasnt been any yet from what i can tell just the .1 push | 14:12 |
| gnomefreak | give me a minute and i will have our changelog | 14:14 |
| gnomefreak | shirish: here is our changelog at the moment | 14:16 |
| gnomefreak | shirish: http://pastebin.mozilla.org/455144 | 14:16 |
| gnomefreak | this can be changed revised or totally forgotten about without any prior notice ;) | 14:16 |
| gnomefreak | sweet | 14:19 |
| gnomefreak | fta: did we remove DOM from our builds of Ffox-3 i know upstream did but i didnt see anything in changelog to match that | 14:20 |
| shirish | gnomefreak: thanx ;) | 14:27 |
| gnomefreak | shirish: np | 14:27 |
| shirish | gnomefreak: there should have been some note about fsync too, from what I read some issues of fsync have been solved. | 14:28 |
| gnomefreak | asac: fta looking at RC2 for fta's PPA we are still building DOM and upstream dropped it from source and is now a plugin should we do same? | 14:28 |
| gnomefreak | shirish: it might have been fixed in another release i never saw that bug more than just a passing by | 14:29 |
| fta | hi | 14:40 |
| fta | the improvements are mostly in xul1.9 for us | 14:40 |
| gnomefreak | yeah but i didnt feel like tracking that down too | 14:41 |
| * gnomefreak was hoping he knoew xul + ff == firefox | 14:41 | |
| gnomefreak | so much for RC2 being final | 14:42 |
| fta | the fsync thing is in xul, not ff | 14:42 |
| gnomefreak | 9 blockers atm | 14:43 |
| gnomefreak | fta: that could be why i havent seen much on it | 14:43 |
| fta | ? | 14:43 |
| gnomefreak | the fsync | 14:43 |
| gnomefreak | i was looking for it in ff not xul | 14:44 |
| gnomefreak | fta: do you have the wiki for the improvments/goals for intrepid (for our pakcages) | 14:51 |
| fta | https://wiki.ubuntu.com/MozillaTeam/Ideas/Intrepid | 14:51 |
| gnomefreak | thanks | 14:52 |
| fta | changed something ? | 15:12 |
| gnomefreak | no | 15:13 |
| gnomefreak | was looking for it the other day | 15:13 |
| gnomefreak | i was hoping UDS stuff got on there | 15:14 |
| fta | nope, no news from asac on that | 15:14 |
| gnomefreak | ah ok | 15:15 |
| fta | Jazzva, hm, since i've applied the asoundconf commands provided by crimsun and rebooted, i was happy with everything.. but teatime no longer has sound | 18:25 |
| Jazzva | What commands? | 18:26 |
| Jazzva | fta ^ | 18:27 |
| fta | asoundconf reset-default-card && asoundconf set-pulseaudio | 18:27 |
| Jazzva | fta, that's in intrepid? | 18:27 |
| Jazzva | With some newer package? I'm still on hardy... | 18:27 |
| Jazzva | Can it be reproduced in hardy :)? | 18:27 |
| fta | i've done that on intrepid | 18:28 |
| Jazzva | Ok. I'm doing an upgrade now. I think it contains the newer kernel version, so I'll have to restart. I'll test it in hardy after restart. | 18:29 |
| Jazzva | fta, did you see the messages I left in the morning (around 4, 5 am)? | 18:29 |
| fta | yes but it's strange as my tests only show 0 and 2, not 2 and 3 | 18:31 |
| Jazzva | You printed the result of "gdk_window_get_state()" only and not "g_w_g_s() & mask"? | 18:35 |
| fta | yes | 18:35 |
| Jazzva | Strange... | 18:36 |
| Jazzva | Did you print with fprintf(stderr, "%d", g_w_g_s(window_variable))? | 18:36 |
| Jazzva | I did it like that, and I got 0, 1, 2 and 3, depending on the sttate :/ | 18:37 |
| fta | hm, i've rebuilt it and i see 0, 1, 2, 3 too | 18:41 |
| fta | but that's with the patcj | 18:42 |
| fta | h | 18:42 |
| Jazzva | The patch? | 18:42 |
| Jazzva | I tested with .14 ver... The current in hardy | 18:42 |
| fta | - if((gdk_window_get_state(GTK_WIDGET(mainwindow)->window) & GDK_WINDOW_STATE_ICONIFIED) || !GTK_WIDGET_VISIBLE(mainwindow)) { | 18:42 |
| fta | + if(!GTK_WIDGET_VISIBLE(mainwindow)) { | 18:42 |
| Jazzva | Oh... that patch :). I think I tried to change _ICONIFIED to _WITHDRAWN, and it didn't change the actual result | 18:43 |
| Jazzva | Then I went on looking in the gdk functions, looking if it's maybe a bug in g_w_g_s, but it looked fine. I also noticed they have enum mainwindowState, which uses values 0, 1, 2 and 3, but it's only used in ui_mainwindow_init(). So, I'm confused :). | 18:44 |
| Jazzva | window state shouldn't change before actual gdk_window_restore, or _hide (whatever is the name of that function). And it shouldn't return 0-3, but 1, 2, 4, ... :/. | 18:47 |
| fta | no, it's a mask, so 3 = 2 + 1 | 18:49 |
| fta | it sets bits | 18:49 |
| Jazzva | Oh... so, it can be in more than one state atm? | 18:49 |
| Jazzva | :) | 18:49 |
| fta | yes | 18:50 |
| fta | some states are not incompatible | 18:50 |
| Jazzva | Well, then that's good :)... | 18:50 |
| fta | yes, i'm writing the patch | 18:50 |
| Jazzva | Yes, we don't need to change the condition in if, just add one more test in the if-branch | 18:51 |
| Jazzva | :) | 18:51 |
| fta | hm, do we want 2 clicks or just one when the window is visible in another workspace ? | 19:05 |
| fta | i'm used to 2 | 19:05 |
| Jazzva | Well, xchat uses that - 1 to hide window, and second to show it | 19:05 |
| Jazzva | Then we can just remove the first check, right? It worked that way last night | 19:06 |
| fta | yep, that's what i'm used to too | 19:06 |
| Jazzva | dinner time. see you soon | 19:09 |
| asac | ui | 19:18 |
| asac | soccer fever ;) | 19:18 |
| fta | hi | 19:19 |
| asac | hi fta | 19:19 |
| asac | i am heavily sunburned ;) | 19:19 |
| asac | well not heavily, but quite OK :) | 19:20 |
| asac | fta: on what no news? | 19:20 |
| fta | people are looking for our blueprints | 19:20 |
| asac | what except for largescalemaintenance do we need a blueprint for? | 19:21 |
| asac | ok, but processing is done (upstream wise) | 19:22 |
| asac | i have to redo the current ubuntu related docs about states and tags, but thats not a spec | 19:22 |
| asac | ubufox is in flashexperience spec as well as firefoxkdeexperience | 19:22 |
| asac | hmm ... maybe the addons thing could get a blueprint ... not sure though. | 19:23 |
| asac | do we need a spec for daily builds?= | 19:23 |
| asac | I'd say "just do it" | 19:23 |
| asac | the graceful upgrade thing most likely wont happen. its not really understood. if someone comes up with bright ideas: let me know :) | 19:24 |
| fta | i'm working on it, i needed the new mozclient for dyntag | 19:24 |
| fta | (daily builds) | 19:24 |
| asac | ok, i think we should link specs we already have on that page on top. | 19:26 |
| fta | Jazzva, could you please test that: http://paste.ubuntu.com/18534/ | 19:30 |
| fta | Jazzva, it's ok for me but it seems that function is sometimes called twice | 19:31 |
| fta | asac, if you have time, i need help for flock, i'm out of ideas | 19:32 |
| asac | fta: you sure you want to do _present? | 19:32 |
| asac | afaik that doesnt really deiconify in all cases | 19:33 |
| asac | though the behaviour might be what is wanted from the desktop side | 19:33 |
| fta | well, it was called in the initial code, and it seems to do what it is supposed to | 19:33 |
| fta | <fta> http://launchpadlibrarian.net/15023265/buildlog_ubuntu-intrepid-amd64.flock_2.0~a1~svn20080603r19205-0ubuntu1~fta4_FAILEDTOBUILD.txt.gz | 19:36 |
| fta | <fta> http://launchpadlibrarian.net/15024875/buildlog_ubuntu-intrepid-i386.flock_2.0~a1~svn20080603r19205-0ubuntu1~fta4_FULLYBUILT.txt.gz | 19:36 |
| fta | <fta> http://launchpadlibrarian.net/15025750/buildlog_ubuntu-hardy-lpia.flock_2.0~a1~svn20080603r19205-0ubuntu1~fta4~hardy_FAILEDTOBUILD.txt.gz | 19:36 |
| fta | asac, ^^ | 19:36 |
| fta | i've even tried shared clucene | 19:36 |
| fta | https://code.edge.launchpad.net/~mozillateam/flock/flock.head | 19:36 |
| fta | http://www.sofaraway.org/ubuntu/tarballs/flock_2.0~a1~svn20080607r19251+nobinonly.orig.tar.gz | 19:36 |
| fta | it builds fine only on intrepid/i386+lpia, not intrepid/amd64 and hardy/* | 19:37 |
| asac | /usr/bin/ld: /usr/lib/libclucene.a(FSDirectory.o): relocatio | 19:39 |
| fta | yep, that's before the shared patch | 19:39 |
| asac | ah | 19:40 |
| fta | asac, here is with shared on hardy/amd64: http://paste.ubuntu.com/18038/ | 19:40 |
| asac | fta: sure it picks everything from systme during build? | 19:41 |
| asac | maybe change to that directory and just strace -eopen -f make | 19:41 |
| fta | clucene is not included in the source | 19:41 |
| asac | the file that fails | 19:41 |
| asac | ok germany game starts ;) bbl | 19:44 |
| fta | enjoy | 19:46 |
| fta | http://jboriss.wordpress.com/2008/06/08/improving-tabs/ | 19:46 |
| fta | fta@ix:~ $ liferea | 19:49 |
| fta | dirname: extra operand `/usr/lib/xulrunner-1.9/libsqlite3.so.0' | 19:49 |
| fta | Try `dirname --help' for more information. | 19:49 |
| fta | lrwxrwxrwx 1 root root 13 2008-06-08 16:08 /usr/lib/xulrunner-1.9.1a1pre/libsqlite3.so.0 -> libsqlite3.so | 19:49 |
| fta | lrwxrwxrwx 1 root root 13 2008-06-08 16:07 /usr/lib/xulrunner-1.9/libsqlite3.so.0 -> libsqlite3.so | 19:49 |
| fta | another evil hack | 19:50 |
| Jazzva | fta: back, I'll test the patch now. | 19:59 |
| Jazzva | fta: Seems to work for me :) | 20:11 |
| fta | if i click fast (yet still not double clicks), it gets confused | 20:12 |
| Jazzva | I see... | 20:20 |
| Jazzva | It doesn't reappear | 20:21 |
| Jazzva | On double-click, the function is called three times | 20:21 |
| Jazzva | ? | 20:21 |
| fta | i only see it called twice | 20:34 |
| Jazzva | It writes me the output of g_w_g_s there times... | 20:37 |
| fta | ok | 20:41 |
| fta | but what is causing this ? | 20:41 |
| Jazzva | callback for double-click? | 20:43 |
| fta | is there one ? | 20:43 |
| Jazzva | Don't know... Just guessing. I'll look for it | 20:43 |
| asac | ok cool stuff | 21:28 |
| asac | debien dropped -common | 21:28 |
| asac | ok germany three points ;) | 21:38 |
| asac | fta: so to summarize: flock with system clucene works as long as its static? | 21:40 |
| fta | asac, for static, it's only ok for intrepid/i386+lpia | 21:41 |
| asac | ok ... so most likely flock upstream didnt notice/care and it doesnt work at all | 21:42 |
| fta | for shared, it fails on hardy/amd64 (i haven't tested anything else yet) | 21:42 |
| asac | fta: but it fails for static too there from what i saw in the pastes above | 21:42 |
| fta | a gentoo guy in the flock-dev channel said it's ok for him | 21:42 |
| asac | fta: what is ok for him? | 21:43 |
| asac | amd + static? | 21:43 |
| asac | while for us it fails? | 21:43 |
| fta | yes, default trunk = static. he said i have to -fPIC my clucene | 21:43 |
| fta | but it seems it is already | 21:43 |
| asac | yeah. have you tried gcc 4.2? | 21:43 |
| fta | http://launchpadlibrarian.net/14118910/buildlog_ubuntu-intrepid-amd64.clucene-core_0.9.20-3_FULLYBUILT.txt.gz | 21:43 |
| fta | http://launchpadlibrarian.net/10140586/buildlog_ubuntu-hardy-amd64.clucene-core_0.9.20-1_FULLYBUILT.txt.gz | 21:43 |
| fta | i've even rebuilt clucene to force -fPIC everywhere, nada | 21:44 |
| asac | the error looks a bit like a resurrection of the pragma visibility bug we had for a while in xulrunner builds | 21:44 |
| asac | (err, firefox 2 that was9 | 21:45 |
| asac | ) | 21:45 |
| asac | fta: i think its a compiler issue | 21:45 |
| fta | maybe a libtool issue (i can't see -fPIC on the last line | 21:45 |
| asac | fta: try to force gcc-4.2 and g++-4.2 | 21:45 |
| fta | hardy is still 4.2 | 21:45 |
| asac | maybe for clucene ... but try flock as well | 21:45 |
| asac | hmm | 21:45 |
| fta | my hardy/amd64 chroot has gcc = 4.2.3 | 21:46 |
| asac | fta: did you check that that symbol actually exists for us? | 21:46 |
| asac | maybe we are outdated and confiugre.in is not strict enough | 21:46 |
| fta | there's no version checking at all | 21:46 |
| asac | hmm ... but its c++ ... should fail i guess | 21:46 |
| asac | let me thinkg | 21:47 |
| asac | i think i mixed it up ... that issue was about something else not hidden | 21:47 |
| asac | fta: libclucene ... when was that last build? | 21:52 |
| asac | did you try a local build? | 21:52 |
| fta | yes (amd64/hardy only) | 21:52 |
| fta | if you want, i can push a shared flock to my ppa to see where it fails (to compare with static) | 21:53 |
| asac | fta: yeah please push | 21:58 |
| asac | how long does the build take? | 21:58 |
| fta | like a full ff3 | 21:58 |
| fta | so ~40 min | 21:58 |
| asac | thought you are on xulrunner already | 21:58 |
| asac | fta: is the static thing available in ppa already? | 21:58 |
| asac | if it fails on amd64 i can use that one to look | 21:58 |
| fta | no, i said i made it build but at runtime it's borked | 21:59 |
| asac | how borked was it? | 21:59 |
| asac | in which particular way ;) ? | 21:59 |
| Jazzva | fta, try changing this function in ui_tray.c | 21:59 |
| fta | a window with garbage, i can't even read the eula text | 21:59 |
| Jazzva | http://paste.ubuntu.com/18572/ | 21:59 |
| Jazzva | it should work. Though, that way it reacts only on button click, and not on double- and triple-click | 22:00 |
| fta | Jazzva, hold on, i'm pushing flock | 22:00 |
| Jazzva | Sure thing... I'm off for 40 minutes now, so whenever you can see if it's good. It surely can be better :) | 22:00 |
| asac | fta: sounds wierd. so the static flock is in your ppa? | 22:00 |
| fta | asac, only intrepid/i386+lpia, everything else ftbfs | 22:01 |
| asac | yeah ... i ment sources ;) | 22:01 |
| fta | but i've packaged it on intrepid/i386 so i discovered the problem afterwards | 22:02 |
| fta | yes | 22:02 |
| asac | fta: flock failed everywhere on hardy ... ah now i see what you mean ;) | 22:02 |
| asac | are hardy | 22:02 |
| asac | and intrepid sources identical | 22:02 |
| asac | ? | 22:02 |
| fta | yes | 22:02 |
| asac | kk | 22:02 |
| asac | orig.tar.gz is huge ;) | 22:02 |
| fta | as long as it's same ~ftaX, it's also the same packaging | 22:02 |
| fta | it's a bit smaller now that it's mozclient | 22:03 |
| fta | embedded tarball + nobinonly | 22:03 |
| fta | take the new one instead | 22:04 |
| fta | asac, ^^ | 22:04 |
| asac | i have fta4~hardy now ;) | 22:05 |
| fta | asac, wait, i'm pushing the shared one. | 22:05 |
| fta | ah, so it's the old tarball ? | 22:05 |
| asac | oh, even embedded bz2 ;) | 22:05 |
| asac | and 53m :) | 22:05 |
| fta | old one | 22:05 |
| asac | old one? | 22:06 |
| asac | i dont see anything else in ppa | 22:06 |
| asac | anyway, have it now | 22:06 |
| asac | so should be fine | 22:06 |
| fta | it's coming | 22:06 |
| fta | <fta> https://code.edge.launchpad.net/~mozillateam/flock/flock.head | 22:07 |
| fta | <fta> http://www.sofaraway.org/ubuntu/tarballs/flock_2.0~a1~svn20080607r19251+nobinonly.orig.tar.gz | 22:07 |
| fta | it's also there | 22:07 |
| fta | -rw-r--r-- 1 fta fta 39916821 2008-06-07 13:31 flock_2.0~a1~svn20080607r19251+nobinonly.orig.tar.gz | 22:07 |
| asac | fta: you have amd64 at hand? | 22:10 |
| fta | yes | 22:10 |
| asac | is there a branch? | 22:10 |
| asac | got it | 22:11 |
| asac | fta: do you auto reconfigure during build? | 22:11 |
| fta | i think so | 22:12 |
| asac | fta: can you try? | 22:13 |
| asac | i committed and attempt | 22:13 |
| asac | is that xul 1.8? | 22:14 |
| fta | no, 1.9 | 22:15 |
| asac | hmm but 1.9a1? | 22:15 |
| asac | -DMOZILLA_LOCALE_VERSION=\"1.9a1\" -DMOZILLA_REGION_VERSION=\"1.9a1\" -DMOZILLA_SKIN_VERSION=\"1.8\" | 22:15 |
| asac | ok that patch might help then | 22:15 |
| fta | no, it's not a1, it should be rc or close | 22:16 |
| fta | voyager:~/bzr/build-area/flock-2.0~a1~svn20080607r19251+nobinonly/build-tree$ cat browser/config/version.txt | 22:17 |
| fta | 3.0 | 22:17 |
| fta | so it's an rc | 22:17 |
| fta | asac, ^^ | 22:18 |
| asac | ok | 22:18 |
| asac | try anyway | 22:18 |
| fta | building | 22:18 |
| asac | fta: do you see -fvisibility=hidden? | 22:23 |
| asac | during build? | 22:23 |
| fta | yes | 22:23 |
| asac | good | 22:23 |
| asac | failed yet? | 22:23 |
| asac | or is it later during build that this happens? | 22:23 |
| fta | later | 22:24 |
| asac | ok ... maybe the WRAP_ -line should have been removed to | 22:24 |
| asac | too | 22:24 |
| fta | ? | 22:25 |
| asac | http://people.ubuntu.com/~asac/simple_visibility_hidden.patch | 22:26 |
| asac | but well | 22:26 |
| asac | if -fvisibility=hidden is there it might be ok | 22:26 |
| fta | damn, i have 90 tabs | 22:28 |
| asac | reads like you have a workflow bug ;) | 22:29 |
| fta | damn, my branch was not up-to-date.. forgot to commit my last changes | 22:44 |
| fta | so i trashed them with that rebuild :( | 22:44 |
| asac | yeah, shit happens :) | 22:45 |
| asac | use --reuse :) | 22:45 |
| asac | maybe that helps | 22:45 |
| fta | the shared patch was not in the series :( | 22:53 |
| [reed] | boo at the Mozilla Team meeting time... I'm going to be in California canoing down a river ;) | 22:54 |
| fta | asac, seems it fixes it | 22:56 |
| asac | fta: good | 22:56 |
| asac | [reed]: sounds dangerous :) | 22:56 |
| [reed] | nah, not dangerous at all :) | 22:57 |
| [reed] | (I wish it was dangerous) | 22:57 |
| [reed] | I used to go whitewater rafting all the time | 22:57 |
| [reed] | in both kayaks and canoes | 22:57 |
| [reed] | just don't have the time anymore | 22:57 |
| Jazzva | [reed]: I wish I can do that soon ... | 23:19 |
| Jazzva | fta: Yep, the solution I proposed fixes the "bug" ... It recognizes double-click as two separate clicks, and triple-click as three clicks. | 23:21 |
| Jazzva | Dunno if it's right way to do it, though. | 23:22 |
| fta | is it http://paste.ubuntu.com/18572/ ? the else if seems misplaced | 23:25 |
| Jazzva | It is :) | 23:26 |
| Jazzva | I didn't notice it, while I was typing | 23:26 |
| Jazzva | let me paste the new one | 23:26 |
| Jazzva | http://paste.ubuntu.com/18590/ | 23:27 |
| Jazzva | that should work | 23:27 |
| fta | better :) | 23:27 |
| Jazzva | :) | 23:27 |
| Jazzva | Tell me if it works for you :) | 23:28 |
| fta | hm | 23:38 |
| Jazzva | Not working? | 23:39 |
| fta | no it's ok | 23:44 |
| fta | but i've done the patch slightly differently | 23:44 |
| Jazzva | Can you paste it? | 23:44 |
| fta | http://paste.ubuntu.com/18594/ | 23:45 |
| fta | it's the same, but simpler | 23:45 |
| Jazzva | I think you should keep put switch in if (event->type == GDK_BUTTON_PRESS), since there are some other eventsm, and maybe it might react on them | 23:47 |
| fta | works great now | 23:48 |
| fta | i think the other events are handled elsewhere | 23:48 |
| Jazzva | Does it do anything on scroll? | 23:48 |
| fta | no | 23:48 |
| Jazzva | ok :) | 23:48 |
| fta | only left and right clicks | 23:48 |
| Jazzva | Right ... the callback is called only for button_press_event... stupid me :) | 23:49 |
| Jazzva | You can check with upstream, if they would like to implement it :) | 23:51 |
| fta | let's try to have it in intrepid 1st, see side effects | 23:51 |
| Jazzva | cool :) | 23:52 |
| fta | i have to fix the xul19 patch too | 23:53 |
| Jazzva | Be my guest :)... | 23:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!