/srv/irclogs.ubuntu.com/2008/07/02/#launchpad-meeting.txt

=== salgado is now known as salgado-afk
=== Odd_Blok1 is now known as Odd_Bloke
=== mwhudson_ is now known as mwhudson
=== salgado-afk is now known as salgado
=== mrevell is now known as mrevell-lunch
=== mrevell-lunch is now known as mrevell
=== EdwinGrub is now known as EdwinGrubbs
barry#startmeeting15:00
MootBotMeeting started at 09:01. The chair is barry.15:00
MootBotCommands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE]15:00
barryyay!15:00
barryhi everyone and welcome to this week's ameu reviewer's meeting.  who's here today?15:00
allenapme15:00
sinzu1me15:00
salgadome15:00
bacme15:00
=== sinzu1 is now known as sinzui
sinzuime15:00
bigjoolsme15:00
EdwinGrubbsme15:01
BjornTme15:01
flacosteme15:02
intellectronicame15:02
barry[TOPIC] agenda15:03
MootBotNew Topic:  agenda15:03
barry * Roll call15:03
barry * Next meeting15:03
barry * Action items15:03
barry * Queue status15:03
barry * Mentoring update15:03
barry  * cprov mentor, abentley mentor15:03
barry * Review process15:03
barry  * Ensure that all outgoing http connections go through a proxy (intellectronica)15:03
barry[TOPIC] next meeting15:03
MootBotNew Topic:  next meeting15:03
barry+= week(1) ?15:03
cprovme15:03
barrysame time and place next week15:04
barryanybody know they will not be there?15:05
barry[TOPIC] action items15:05
MootBotNew Topic:  action items15:05
barry * intellectronica to file bug on lint issue regarding elementtree import15:05
intellectronicasorry, didn't yet15:05
intellectronicanor did i add any checlist items for js15:06
barryintellectronica: cool, we'll carry it over15:06
barryintellectronica: k15:06
barry * gmb to update PythonStyleGuide for long argument lists (use The Salgado Way)15:06
barryis gmb here today?15:06
sinzuiThat was done15:06
intellectronicano, he's on leave15:06
* sinzui should have removed it from the agenda15:06
barryintellectronica: k, thanks.  sinzui, thanks, np15:07
barry * barry to ask lifeless to summarize what he knows about the PQM Mysteries (e.g. autopacking bug losing branches)15:07
barrynot done15:07
barry[TOPIC]  * Queue status15:07
MootBotNew Topic:   * Queue status15:07
barryi don't really have anything on this today.  any comments from y'all on either the pqm queue or PR queue?15:08
barryguess not :)15:08
barry[TOPIC]  * Mentoring update15:09
MootBotNew Topic:   * Mentoring update15:09
barryso, abentley definitely wants to start up soon as a reviewer, and i'm all for that.  he needs a mentor.  any volunteers?15:09
barryokay, i'll do it15:10
cprovbarry: well, so do I.15:11
barryalso, and i haven't talked to cprov yet about this, but your name came up too.15:11
barrycprov: right, we need a mentor for cprov.  can someone in his timezone volunteer?15:11
intellectronicamaybe allenap and i can co-mentor? it's a bit easier, since we share the shift15:11
allenapI'm happy with that.15:12
intellectronicawe're a bit earlier than him, so if there's an american that can do it maybe it's better15:12
cprovintellectronica: allenap: I'd more than happy to follow you both.15:12
salgadointellectronica, you're a bit later than him, in fact15:12
intellectronicaof course, i forgot that :)15:12
sinzuithe Americans are harder?15:12
cprovsalgado: I'll be back to BR in August.15:13
flacosteis'nt cprov in +0200 these days15:13
bigjoolsbut only for 2 more weeks!15:13
intellectronicacprov: i'm sure you'll graduate by then ;)15:13
barry:)15:13
cprovintellectronica: ehe, couldn't start any better ;)15:14
barryintellectronica, allenap i'm okay with that if you and cprov are.15:14
cprov+115:14
allenap+115:14
barrygreat, thanks!15:14
intellectronica+115:14
bigjoolstwo mentors, is this a first? :)15:14
barrybigjools: it is!15:14
intellectronicatwo senators15:14
barrybigjools: that just means intellectronica and allenap have to be doubly hard on cprov :)15:14
bigjoolsso he should graduate in double quick time!15:15
barrybigjools: or take twice as long15:15
cprovbarry: why ?15:15
barrycprov: i'm kidding15:15
barry[TOPIC]  * Review process15:15
MootBotNew Topic:   * Review process15:15
bigjoolsplease don't leave him in a gibbering mess, I need him to fix Soyuz bugs :)15:15
barry:-D15:15
cprovbarry: uhm, I just thought you would come with a funny reason, nevermind ...15:16
barrycprov: i'm limited to one joke per meeting, if i'm lucky15:16
barry  * Ensure that all outgoing http connections go through a proxy (intellectronica)15:16
barryintellectronica: you have the floor15:16
intellectronicaso, on production, we can only make http connections to the outside world via a proxy15:16
intellectronicabut time and again we get code in that doesn'y handle proxies well15:17
intellectronicasince we can't really test this, we must pay attention in reviews when we notice code that makes connections to the outside world and make sure that it works via proxies15:17
bigjoolswhat sort of problems arise?15:18
intellectronicaehm ... we can't connent?15:18
sinzuibigjools: timeouts15:18
bigjoolsok - terminal problems then :)15:18
cprovintellectronica: do you remember any example ?15:18
allenapThe most recent problem was using xmlrpclib.15:18
allenapIt doesn't cope with proxies.15:19
flacostereally?15:19
intellectronicacprov: i'm currently working on one15:19
allenapAnd just hits its shiny head on the inside of the firewall.15:19
intellectronicaflacoste: yeah, xmlrpclib sux15:19
barryintellectronica: i wonder if a better xmlrpclib could be built ontop of httplib2?15:19
intellectronicabarry: there's a python bug, and a patch to fix it15:20
intellectronicaso hopefully not before long15:20
flacosteok, it seems you need a custom TRansport for this15:20
bacintellectronica: can you point us to an example of what is the right way to do it?15:20
intellectronicaflacoste: yeah, that's exactly my fix15:20
flacostebut i think this points to another problem15:20
flacostewe are lacking tests for things that connects to the outside15:21
flacoste"in end-to-end" kind of way15:21
intellectronicabac: there's no right way to do it. we simply have to scrutinise any new code that makes http connections to the outside world and ask questions15:21
barryintellectronica: can you forward to me the bug #?15:21
cprovcan we use pylint to find out callsites using xmlrpclib with bare HTTPTransport ?15:21
intellectronicaflacoste: indeed. but it's quite difficult to test, since we need to block normal connections15:21
bacand by "outside" you mean outside the data center.  this doesn't affect connections to niobium15:21
barryintellectronica: i might be able to at least convince the python RM to sneak it into py2.6 <wink>15:21
flacostewell, it's not a xmlrpclib problem pe-se15:21
flacosteright15:22
intellectronicacprov: i wouldn't worry too much about rpclib specifically. this is a general problem15:22
intellectronicabarry: see https://bugs.edge.launchpad.net/malone/+bug/24363415:22
cprovor in fact, monkey patch HTTPTransport in a way it couldn't be used.15:22
ubottuLaunchpad bug 243634 in malone "ExternalBugTrackers that use XML-RPC need an XML-RPC transport that can work across proxies" [Critical,In progress]15:22
cprovintellectronica: yes, it might be too much trouble.15:22
barryintellectronica: thanks15:23
intellectronicaand since we don't really open connections to the outside world in the test suite, i don't think there's any automated way to do that. we simply have to pay attention to that15:23
intellectronicawelcome15:23
barryintellectronica: is there some way we can catch and elevate these bugs when testing on staging?15:24
intellectronicabarry: i don't understand your question15:24
flacostewell15:24
intellectronicaon staging, things won't work15:24
flacostewe could have a proxy that has to be used wihtin the test suite15:25
flacosteto show that connections to the "outside" world are proxied15:25
intellectronicaflacoste: and what if we don't use it? how would the test fail?15:25
flacostewell, the test has to show that it goes through a proxy15:25
barryflacoste: yes15:25
intellectronicathat's a nice idea, actually15:25
flacostebut i guess this is just icing over your initial comment15:25
flacostewhich is reviewers: pay attention to the proxy issue15:26
flacosteif we had a standard way to show that it was handled, it would be easier15:26
flacostebut reviewers would still have to spot a missing test15:26
intellectronicayeah, i don't think there's much more to say about this issue other than that15:28
barryintellectronica: please send a message to the mailing list on this issue and please add a note to TIpsForReviewers15:28
intellectronicabarry: ok15:28
barry[ACTION] intellectronica to communicate on ml and wiki about watching for outside connections15:28
MootBotACTION received:  intellectronica to communicate on ml and wiki about watching for outside connections15:28
barrythanks15:28
barrythat's everything on the agenda.  does anybody have anything /not/ on the agenda?15:29
barrythat sounds like a no.  okay everybody, thanks!  we're done 15 minutes early today15:30
barry#endmeeting15:30
MootBotMeeting finished at 09:31.15:30
bigjoolsthanks barry15:30
intellectronicathanks barry15:31
=== mwhudson_ is now known as mwhudson
=== salgado is now known as salgado-afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!