saivann | asac : I'm trying to build to see if my patch apply correctly and the patch system here is dpatch. While building, I get this error : applying patch 04_xulrunner1.9_glue to ./ ...patch: **** malformed patch at line 80: @@ -96,29 +72,28 @@ | 00:07 |
---|---|---|
saivann | asac : current patch : http://paste.ubuntu.com/24562/ | 00:08 |
saivann | asac : At this point in the patch, no tricky modifications has been made | 00:08 |
saivann | asac : I wonder if dpatch needs a space before each hunks | 00:08 |
asac | saivann: no ... malformed usually means that you have the numbers wrong | 00:09 |
asac | could be that you miss a space somewhere ;) | 00:09 |
saivann | asac : Oh! That makes sense! I forgot to add 11.. thanks | 00:09 |
asac | but you should never remove anything else than complete lines | 00:09 |
saivann | asac : I switched back to the patch without modifications in the first lines and I still get the same error for line 280 | 00:25 |
saivann | asac : default-prefs-libxul.js does not exist, it is suposed to be created by that patch | 00:25 |
saivann | asac : but dpatch does not seem to share that point of view | 00:26 |
saivann | asac : Is there something missing, like @only_in_patch2 | 00:26 |
asac | saivann: how did you add the default-*js file to the patch? | 00:29 |
saivann | asac : I just copied the hunk from the complete diff | 00:31 |
saivann | asac : default-*js exist in 1.0.1 so it was in the original diff | 00:32 |
asac | saivann: not sure without looking. try to remove hunk by hunk until you find the intruder | 00:34 |
asac | double check that you dont miss a line break at the end of some patch | 00:34 |
asac | the original filterdiff patch should work | 00:35 |
saivann | Ah right.. missing break lines, that seems to work now | 00:40 |
asac | hehe | 00:41 |
saivann | asac : Bad new.. using the same rules file as 1.0.1 (with correct FLAGS), I still get a lot of /usr/lib/xulrunner-devel-1.9b5/lib/libxul.so: undefined reference to `JS_RemoveRoot' | 00:49 |
saivann | when I try to build in hardy | 00:49 |
saivann | The package build-depends on xulrunner-1.9-dev | 00:49 |
asac | saivann: right. we are not there yet | 00:50 |
asac | saivann: now you have a minimal xulrunner-1.9 patch | 00:50 |
asac | what you dont have is a patch that applies all the autoconf/make changes | 00:50 |
saivann | asac : Oh, right | 00:51 |
asac | so thats the next step | 00:51 |
asac | saivann: is there a 99_autoXXX patch already? | 00:51 |
saivann | asac : Actual patch still contains not necessary stuff | 00:51 |
saivann | asac : no | 00:51 |
asac | saivann: yeah. you can clean this afterwards. | 00:51 |
asac | lets get through the process | 00:51 |
saivann | asac : The patch applies correctly from now :) | 00:52 |
saivann | asac : Great! I'm ready to continue | 00:52 |
asac | you use dpatch-edit-patch to create a new patch that gets applied at the end of the patchset | 00:52 |
asac | saivann: its dpatch right? | 00:52 |
asac | read manpatch of that tool ;) | 00:52 |
saivann | asac : yes, the build system use dpatch | 00:52 |
asac | so when you are in "edit" mode you run the required autotools | 00:53 |
saivann | asac : Ok | 00:53 |
asac | not sure what that is | 00:53 |
asac | in worst case you just run autoreconf -i -f | 00:53 |
asac | when in edit mode and exit the mode to produce a full update | 00:53 |
saivann | asac : Do you mean man dpatch? | 00:54 |
asac | saivann: no dpatch-edit-patch ;) | 00:55 |
saivann | asac : I'm not sure but it seems to works like the cdbs patch edit tool | 00:59 |
asac | yes | 01:00 |
asac | saivann: you can use that two most likely ;) | 01:00 |
asac | i found that cdbs-edit-tools has more bugs though ;) | 01:00 |
asac | -patch | 01:00 |
saivann | asac : Oh I get it, I will use kind of sed command on all makefiles? | 01:00 |
saivann | asac : And then save the patch | 01:00 |
saivann | hehe :) | 01:01 |
asac | saivann: no, you just run the autotools | 01:01 |
saivann | asac : I just type "autotools" and then "exit" ? | 01:01 |
asac | like the autoreconf i suggested above | 01:01 |
saivann | asac : autoreconf and autotools are still unknown to me, where can I find more information? | 01:03 |
asac | saivann: autotools is just a word for a bunch of autoXXXX commands | 01:03 |
asac | autoreconf is quite simple helper that runs the autoXXX commands in right order for you | 01:04 |
asac | maybe you just need to run autoconf, but autoreconf should be safe ;) ... though a bit brute force-like | 01:04 |
asac | name the patch 99_autoreconf if you use autoreconf ;) | 01:04 |
saivann | asac : Ok I will try "autoconf" first :) | 01:04 |
asac | yeah | 01:05 |
asac | saivann: well at best try autoreconf first as this will most likely work | 01:05 |
asac | then you can try autoconf later and i can bail out :-D | 01:05 |
asac | good excercise | 01:06 |
asac | :) | 01:06 |
saivann | asac : Ok :P | 01:08 |
saivann | asac : autoreconf fails with error code 1 : http://paste.ubuntu.com/24570/ | 01:10 |
asac | saivann: does the source ship a autogen.sh ? | 01:14 |
saivann | looking.. | 01:14 |
saivann | asac : Yes | 01:14 |
asac | can you run that? sh autogen.sh ? | 01:14 |
asac | or does it give you problems too | 01:14 |
asac | in case it auto starts configure, abort | 01:15 |
saivann | asac : Strangely, same errors : http://paste.ubuntu.com/24573/ | 01:15 |
asac | saivann: is libtool package installed? | 01:16 |
saivann | asac : The source is un-touched, changes has been made in debian folder only | 01:16 |
saivann | asac : on my computer? | 01:16 |
asac | yes | 01:16 |
asac | aclocal must succeed | 01:17 |
asac | otherwise you miss a package | 01:17 |
saivann | asac : It was not, however, I installed it and tried again without success | 01:18 |
saivann | asac : Mmh, is there any way to have some clues about which package is missing? | 01:18 |
asac | saivann: whats the error now? | 01:18 |
asac | aclocal should not print AM_PROG_LIBTOOL error if you have libtool installed | 01:19 |
saivann | asac : http://paste.ubuntu.com/24574/ | 01:19 |
asac | saivann: do you have all build dependencies of that package installed? | 01:20 |
asac | that would be a good start i guess ;) | 01:20 |
saivann | asac : Ok then I should install glib, gtk, chmlib, etc. | 01:20 |
asac | chmlib wont exist | 01:20 |
asac | but run sh autogen.sh | 01:20 |
asac | then it should work | 01:20 |
asac | saivann: install build-dependencies ;) | 01:20 |
asac | sudo apt-get build-dep PACKAGENAME | 01:20 |
saivann | asac : Sorry | 01:21 |
saivann | asac : I did remember that command, it's installing now | 01:21 |
saivann | :) | 01:21 |
asac | hehe | 01:21 |
asac | welcome | 01:21 |
saivann | asac : since build-deps are installed, only AM_PATH_CHMLIB gives a error | 01:23 |
asac | saivann: right. use sh autogen.sh | 01:23 |
asac | did you use that? | 01:23 |
saivann | asac : No I was still using autoreconf | 01:24 |
asac | look at the output ... it uses aclocal -I m4 ... which means it looks for its _own_ m4 files | 01:24 |
asac | so that will give you that macro ;) | 01:24 |
asac | done | 01:24 |
saivann | asac : autogen.sh seems to have executed successfully | 01:24 |
asac | AM_PATH_CHMLIB == macro ;) | 01:24 |
asac | saivann: congrats :) | 01:24 |
saivann | asac : Thanks :D | 01:24 |
asac | saivann: the definition for that macro is in the m4/ directory if you care | 01:25 |
asac | saivann: ok if you have created a 99_autogen_sh.dpatch .. chances are high that things work ... if not completely at least somehow | 01:25 |
asac | it will break if you have forgotten to remove some GLADE rename things for sure | 01:25 |
asac | saivann: oh. i think you have to add that patch manually to 00list | 01:26 |
asac | but not sure | 01:26 |
saivann | asac : Yeah I'm looking at it | 01:26 |
asac | i have a bad opinion about dpatch and avoid to use it ;) | 01:26 |
saivann | asac : There is still GLADE renaming things in my patch which I did not succed to remove.. | 01:26 |
saivann | asac : ..Well I'm not an expert, but I prefer other patch systems too at this point | 01:27 |
asac | saivann: for now you can fix it by just making | 01:27 |
asac | + CHMSE | 01:27 |
asac | - CHMSE | 01:27 |
asac | :) | 01:27 |
asac | as a trick;) | 01:27 |
asac | just make the patch do nothing so you dont have to care about the hunk bounds ;) | 01:27 |
saivann | asac : Haha, yeah that's simple, but ugly :P | 01:28 |
asac | saivann: you can clean up later | 01:28 |
asac | but certainly before upload ;) | 01:28 |
asac | hehe | 01:28 |
saivann | asac : I agree :) | 01:28 |
saivann | asac : Ok let's try this | 01:28 |
asac | ha ... i already have almost 30 posts in the forums ;) | 01:29 |
asac | http://ubuntuforums.org/showthread.php?t=797059&page=9 | 01:29 |
saivann | asac : :) | 01:36 |
saivann | asac : Unfortunately.. still the same /usr/lib/xulrunner-devel-1.9b5/lib/libxul.so: undefined reference to `JS_RemoveRoot' | 01:36 |
asac | saivann: check that the linker flags are there | 01:37 |
asac | e.g. see if you see XPCOM_GLUE in the compile line | 01:37 |
asac | and -lxpcomglue | 01:37 |
saivann | asac : I confirm : DEB_CONFIGURE_EXTRA_FLAGS += --with-gecko=libxul | 01:37 |
asac | saivann: if thats the new --with-gecko? | 01:37 |
saivann | asac : No and it's not in the 1.0.1 either | 01:38 |
asac | saivann: use the --with-gecko from 1.0.1 | 01:38 |
saivann | asac : I used the same rules file as 1.0.1, which use DEB_CONFIGURE_EXTRA_FLAGS += --with-gecko=libxul | 01:38 |
asac | saivann: yeah. look at what the compiler spit out and if it had the xpcomglue linker flags | 01:39 |
saivann | asac : you speak about the configure.ac or Makefile.am?? | 01:40 |
saivann | asac : Or about the build logs? | 01:40 |
asac | saivann: about what you see on the command line right before it fails | 01:41 |
asac | thtas basically the compile command used | 01:41 |
saivann | asac : Ok, I'm looking to save build logs | 01:41 |
asac | saivann: if you see something like -DXPCOMGLUE and -lxpcomglue in there then its probably right | 01:44 |
asac | and we are likely missing some other hunk which i might have missed | 01:44 |
saivann | asac : cd . && CC="cc" CXX="g++" CFLAGS="-g -O2 -g -Wall -O2" CXXFLAGS="-g -O2 -g -Wall -O2" CPPFLAGS="" LDFLAGS="-Wl,-Bsymbolic-functions" LDFLAGS=" -Wl,--as-needed" /tmp/buildd/chmsee-1.0.0/./configure --build=x86_64-linux-gnu --prefix=/usr --includedir="\${prefix}/include" --mandir="\${prefix}/share/man" --infodir="\${prefix}/share/info" --sysconfdir=/etc --localstatedir=/var --libexecdir="\${prefix}/lib/chmsee" --di | 01:48 |
saivann | sable-maintainer-mode --disable-dependency-tracking --srcdir=. --with-gecko=libxul | 01:48 |
saivann | asac : I found the word lxpcomglue 2 times in the build logs, but not DXPCOMGLUE | 01:49 |
saivann | I come back in 2 seconds | 01:49 |
asac | saivann: sorry ... XPCOM_GLUE | 01:50 |
asac | most likely -DXPCOM_GLUE :) | 01:51 |
asac | like what you get with pkg-config --cflags libxul-embedding | 01:51 |
asac | and pkg-config --libs libxul-embedding | 01:51 |
saivann | back | 01:53 |
saivann | asac : DXPCOM_GLUE, XPCOM_GLUE, pkg-config --libs libxul-embedding, none of them are in build logs | 01:54 |
asac | saivann: thats bad | 01:54 |
asac | that means that the configure.ac changes are not applied | 01:54 |
saivann | asac : Not really?.. | 01:54 |
asac | nope | 01:55 |
asac | saivann: double check that the 99_autogen patch is in 00list | 01:55 |
saivann | asac : I looked at the build logs and the patches are reported to be applied | 01:55 |
asac | autogen too? | 01:55 |
saivann | asac : Yes it is, and build logs says that it was applied during build process | 01:55 |
saivann | asac : 99_autogen contains a huge amount of changes, made by autogen in dpatch edit | 01:56 |
asac | saivann: ok check that GECKO_CFLAGS and GECKO_LIBS are properly set in config.status | 01:56 |
saivann | asac : config.status, I can't find that file in sources | 01:57 |
asac | saivann: nothats in the build directory | 01:58 |
asac | not sources | 01:58 |
saivann | config.guess, config.h.in, config.sub | 01:58 |
asac | thats the result of configure basically | 01:58 |
saivann | asac : Oh, then that file appears after configure is executed? | 01:59 |
asac | yes | 01:59 |
asac | in the build tree | 01:59 |
asac | keep that tree | 01:59 |
asac | work in there ;) | 01:59 |
saivann | asac : s,@GECKO_CFLAGS@,|#_!!_#|-fshort-wchar -I/usr/include/xulrunner-1.9/unstable -I/usr/include/nspr -I/usr/include/xulrunner-1.9 -I/usr/include/xulrunner-1.9/commandhandler -I/usr/include/xulrunner-1.9/content -I/usr/include/xulrunner-1.9/dom -I/usr/include/xulrunner-1.9/find -I/usr/include/xulrunner-1.9/gfx -I/usr/include/xulrunner-1.9/gtkembedmoz -I/usr/include/xulrunner-1.9/locale -I/usr/include/xulrunner-1.9/p | 02:00 |
saivann | ref -I/usr/include/xulrunner-1.9/string -I/usr/include/xulrunner-1.9/webbrwsr -I/usr/include/xulrunner-1.9/xpcom -I/usr/include/xulrunner-1.9/xpconnect,g | 02:00 |
asac | that looks wrong | 02:00 |
asac | thats still mozilla-gtkmozembed | 02:00 |
asac | not libxul | 02:00 |
saivann | asac : s,@GECKO_LIBS@,|#_!!_#|-L/usr/lib/xulrunner-devel-1.9/lib -lxpcomglue_s -lxul -lxpcom -lplds4 -lplc4 -lnspr4 -lpthread -ldl ,g | 02:01 |
asac | saivann: yeah thats wrong too | 02:01 |
asac | thats the dependent glue | 02:01 |
saivann | asac : Wait, I will try to update my pbuilder environment. After all, xulrunner has been updated | 02:01 |
asac | so most likely the configure.ac patch is not properly applied in our 99_auto patch | 02:01 |
asac | or the configure flags we pass from rules are wrong | 02:02 |
asac | saivann: no that shouldnt be the problem here | 02:02 |
asac | (e.g. outdated xulrunner ) :) | 02:02 |
saivann | asac : No, that's my error, I'm was not working on the patched tree, wait, I will give you the right values | 02:02 |
asac | k | 02:03 |
saivann | asac : s,@GECKO_CFLAGS@,|#_!!_#|-fshort-wchar -I/usr/include/xulrunner-1.9/unstable -I/usr/include/nspr -I/usr/include/xulrunner-1.9 -I/usr/include/xulrunner-1.9/commandhandler -I/usr/include/xulrunner-1.9/content -I/usr/include/xulrunner-1.9/dom -I/usr/include/xulrunner-1.9/find -I/usr/include/xulrunner-1.9/gfx -I/usr/include/xulrunner-1.9/gtkembedmoz -I/usr/include/xulrunner-1.9/locale -I/usr/include/xulrunner-1.9/p | 02:08 |
saivann | ref -I/usr/include/xulrunner-1.9/string -I/usr/include/xulrunner-1.9/webbrwsr -I/usr/include/xulrunner-1.9/xpcom -I/usr/include/xulrunner-1.9/xpconnect,g | 02:08 |
saivann | s,@GECKO_LIBS@,|#_!!_#|-L/usr/lib/xulrunner-devel-1.9/lib -lxpcomglue_s -lxul -lxpcom -lplds4 -lplc4 -lnspr4 -lpthread -ldl ,g | 02:08 |
asac | still the same | 02:08 |
asac | check config.log | 02:08 |
saivann | asac : I see, and now that's with patches applied | 02:08 |
asac | yeah. so either configure doesnt have our changes | 02:09 |
saivann | asac : Right!! We did not patch configure! | 02:09 |
asac | well, there is no or ;) | 02:09 |
asac | saivann: 99_autogen patch should | 02:09 |
saivann | asac : ah. | 02:09 |
asac | try lsdiff debian/patches/99_* | 02:09 |
saivann | asac : I have config.log, what do you want to search in this file? | 02:10 |
asac | saivann: for GECKO_CFLAGS | 02:10 |
asac | :) | 02:10 |
saivann | asac : pkg_cv_GECKO_CFLAGS='-fshort-wchar -I/usr/include/xulrunner-1.9/unstable -I/usr/include/nspr ' | 02:11 |
saivann | pkg_cv_GECKO_LIBS='-L/usr/lib/xulrunner-devel-1.9/lib -lxpcomglue_s -lxul -lxpcom -lplds4 -lplc4 -lnspr4 -lpthread -ldl ' | 02:11 |
asac | thats wrong | 02:11 |
asac | maybe ther eis --with-gecko ? | 02:11 |
asac | in the log? | 02:11 |
saivann | asac : Is lsdiff suposed to find if patches has been applied? | 02:13 |
asac | list the files affected by a patch | 02:13 |
asac | so configure should be in there ;) | 02:13 |
saivann | asac : It is | 02:15 |
saivann | asac : In build logs, --with-gecko is at the end of the LDFLAGS : | 02:16 |
saivann | LDFLAGS=" -Wl,--as-needed" /tmp/buildd/chmsee-1.0.0/./configure --build=x86_64-linux-gnu --prefix=/usr --includedir="\${prefix}/include" --mandir="\${prefix}/share/man" --infodir="\${prefix}/share/info" --sysconfdir=/etc --localstatedir=/var --libexecdir="\${prefix}/lib/chmsee" --disable-maintainer-mode --disable-dependency-tracking --srcdir=. --with-gecko=libxul | 02:16 |
asac | that looks ok | 02:16 |
asac | in config.log you have to hunt why libxul-embedding-unstable is not used | 02:16 |
asac | even though --with-gecko=libxul is set | 02:16 |
saivann | ... | 02:17 |
saivann | I really don't understand why if we use the same files as 1.0.1 | 02:18 |
saivann | Except of course... is it possible that autogen.sh does not update files correctly? | 02:19 |
saivann | asac : would that be possible? | 02:20 |
asac | i doubt that | 02:21 |
saivann | oh.. autogen.sh is pretty short | 02:21 |
asac | however, the patch is most likely broken. you can try to look in configure file and asee if the changes we did for configure.ac are there | 02:22 |
asac | in any case night has to come here | 02:23 |
asac | sorry that it ended up harder than expected | 02:26 |
asac | but the procedure is good for other stuff for sure | 02:26 |
* asac off | 02:26 | |
asac | not saying that you should stop now ;) | 02:26 |
saivann | asac : Oh you go? Good night ;) Thanks for the time to spent with me, I will continue to search | 02:26 |
saivann | asac : And well this is not your fault if this package is frustrating ;) | 02:27 |
=== asac_ is now known as asac | ||
saivann | asac : I don't want to give false hopes, but I think that I found the problem! Working.. | 04:36 |
saivann | asac : I successfully applied the standalone glue! I'm still stuck with FTBFS problems with libltool and working around this. | 04:56 |
saivann | asac : When you have time for it, I still have a FTBFS but standalone glue works, here's the current package : http://upload.leservicetechnique.com/bugs/chmsee_1.0.0-1ubuntu1~hardy1.tar.gz | 06:36 |
saivann | asac : build logs : http://paste.ubuntu.com/24635/ | 06:36 |
* saivann off | 06:37 | |
gnomefreak | asac: you up yet? | 07:05 |
* gnomefreak wonders if we get redirected to new wiki | 07:16 | |
gnomefreak | I have finished with the roadmap wiki for now. Let me know if you want something added or have ideas for it. https://wiki.ubuntu.com/MozillaTeam/Roadmap | 07:55 |
gnomefreak | or maybe i should use mozillateam/roadmap/todolist but its fine for now | 07:57 |
gnomefreak | also i cant get sound now :( volume control everything is enabled(not muted) :( | 08:35 |
asac | gnomefreak: yes? | 09:15 |
gnomefreak | yes? | 09:15 |
asac | saivann: yeah. that look quite good | 09:15 |
asac | saivann: what was the problem? | 09:16 |
gnomefreak | that email about the dates is hardewr than it was needed adn why did the dates in each section not match any other dates on attachment | 09:18 |
gnomefreak | are these the dates? 20-07-2008 | 09:18 |
gnomefreak | 31-08-2008 | 09:18 |
gnomefreak | 19-10-2008 | 09:18 |
gnomefreak | 23-11-2008 | 09:18 |
gnomefreak | 04-01-2008 | 09:18 |
asac | reconnect | 09:30 |
asac | well more a disconnect ;) | 09:30 |
asac_ | bad thing | 09:34 |
asac_ | shaky connection | 09:34 |
asac_ | gnomefreak: i think at the bottom of the mail there are the actual release dates | 09:34 |
asac_ | err, meeting dates | 09:34 |
gnomefreak | asac_: not sure but i will ask volan(spelling) or wait for him to reply. if the last ones are it what the hell do the other ones hav eto do? | 09:35 |
asac__ | argh | 09:39 |
asac__ | reconnected again | 09:39 |
asac__ | gnomefreak: those are the mails we send out | 09:39 |
asac__ | with the dates _when_ they are send | 09:39 |
asac__ | (e.g. the preannonucements) | 09:39 |
=== asac__ is now known as asac | ||
gnomefreak | ah ok | 09:49 |
* gnomefreak needs a smoke. i havent fallen asleep yet and its not 4:49am | 09:49 | |
asac | gnomefreak: i doubt that you fall asleep if sit infront of the computer ;) | 09:52 |
asac | or smoke a cigarette | 09:52 |
gnomefreak | asac: almost fell asleep while smoking my eyes kept closing and i thought they were open :( | 09:58 |
asac | gnomefreak: then lay down and sleep ;) | 09:58 |
asac | thats simple | 09:58 |
gnomefreak | asac: i will soon | 09:58 |
asac | i mean if the eyes keep closing you will just fade a away | 09:58 |
gnomefreak | i would like to get sound working first | 09:58 |
asac | haha | 09:58 |
asac | thats your problem then ;)... dont complain about a lack of sleep | 09:59 |
gnomefreak | something changed maybe alsa or default card/driver or something adn the one person that knew didnt answer me | 09:59 |
gnomefreak | persia > gnomefreak: cat /proc/asound/cards Notice the new device. Change your default. Ask Hobbsee for details :) | 10:02 |
gnomefreak | me doesnt understand since you cant edit that file | 10:02 |
gnomefreak | hobbsee had left right before that comment | 10:03 |
gnomefreak | asac: so you know anything about this new device? | 10:03 |
asac | sound issues are not in my field of expertise | 10:06 |
asac | i'd love to get rid of all sound ;) | 10:06 |
gnomefreak | i kind oif like music while working more so working on wikis | 10:08 |
gnomefreak | asac: feel free to take a look at our roadmap wiki and add so other topics (or giv eme a list and i will. so far there is = TO DO = and == assigned tasks == and == unassigned tasks == | 10:10 |
gnomefreak | ok im off to bed ill ask crimsun if we see eachother in one of the channels | 10:16 |
* gnomefreak cant keep eyes open | 10:16 | |
=== asac_ is now known as asac | ||
saivann | asac : I'll probabl be there in ~4 hours, during the current day | 12:30 |
asac | kk | 12:30 |
saivann | asac : ping | 15:39 |
asac | saivann: yeah .. more or less here | 15:39 |
saivann | asac : I'm here for 5 hours | 15:39 |
asac | saivann: whats up? i read that you managed to get it done mostly | 15:40 |
saivann | asac : Yes! I found the problem which was in autoreconf patch, which is now correct. Now I still have FTBFS for another reason, see build logs here : http://paste.ubuntu.com/24635/ | 15:41 |
saivann | asac : I don't know if you can help me at this point.. | 15:41 |
asac | saivann: i think you have to run intltoolize -f -c and include the changes in the autogen patch | 15:42 |
asac | not sure why its not in the autgen.sh | 15:42 |
saivann | asac : autogen.sh contains this : libtoolize -c --automake | 15:43 |
saivann | ho. ok | 15:43 |
asac | found something? | 15:43 |
saivann | asac : No, not yet, but I will try what you suggest right now | 15:43 |
asac | saivann: maybe -f is just missing in autogen.sh | 15:44 |
asac | i think it omits the update if it thinks that all files are in place | 15:44 |
saivann | asac : autoget.sh use libtoolize -c --automake but not intltoolize -f -c | 15:45 |
asac | saivann: add an -f | 15:46 |
=== james_w_ is now known as james_w | ||
saivann | asac : Ok | 15:47 |
asac | bug 245184 | 15:47 |
ubottu | Launchpad bug 245184 in network-manager "[NM-0.7] nm-connection-editor fails to set/read certificates settings" [Undecided,New] https://launchpad.net/bugs/245184 | 15:47 |
armin76 | bumb | 15:53 |
* armin76 blames asac | 15:54 | |
asac | armin76: there is nothing left to bumb | 15:57 |
armin76 | asac: xulrunner :P | 15:58 |
saivann | asac : Does not FTBFS anymore, you're a genius | 16:00 |
asac | saivann: you are quite smart too | 16:01 |
asac | saivann: others dont get that far ... no matter what i do ;) | 16:01 |
saivann | asac : Really, it's not kind of encouraging words? :P | 16:02 |
asac | armin76: xulrunner is fresh and great ... we are far ahead of everyone | 16:02 |
armin76 | thank you thank you :D | 16:02 |
armin76 | asac: 1.8? | 16:02 |
asac | saivann: its encouraging that you fixed it ;) | 16:02 |
asac | armin76: oh :) ... its not in ubuntu, but universe | 16:02 |
saivann | asac : Thanks :) I'm glad to have worked until the end. I'm going to test the package now | 16:03 |
asac | saivann: yeah. enjoy ;) | 16:03 |
saivann | :) | 16:03 |
* asac has no idea what chmsee does ;( | 16:06 | |
asac | saivann: let me know when you attache a) the minimal patch + b) the complete debdiff to the bug | 16:22 |
asac | so i can test and sponsor | 16:22 |
saivann | asac : Ok, it should not be too long, I'm looking to be sure that I don't forget anything | 16:28 |
saivann | asac : chmsee is a good tool to open .chm files (it's a common help file format used by many programs, and opened by the help center in Windows XP) | 16:29 |
asac | saivann: take your time ;) | 16:35 |
saivann | asac : I want to build it in my PPA before, just a precaution | 16:35 |
asac | sure | 16:35 |
asac | its good to have for SRUs anyway | 16:35 |
asac | saivann: remember to lower the version by appending ~saivann1 | 16:36 |
asac | or something to the package revision | 16:36 |
saivann | asac : Yes, I added ~ppa1 :) As I do normally | 16:36 |
asac | good | 16:36 |
saivann | asac : And I will create the patch with hardy-proposed in the changelog | 16:36 |
asac | top | 16:37 |
saivann | asac : For the patch, chmsee_1.0.0-1ubuntu1~hardy1 is the good version name I guess? | 16:39 |
asac | usually we dont use codenames, but versions | 16:40 |
asac | e.g. 8.04.1 | 16:40 |
asac | (for 1 revision of 8.04 backports | 16:40 |
asac | ) | 16:40 |
saivann | So : chmsee_1.0.0-1ubuntu1~8.04.1 ? | 16:41 |
saivann | asac | 16:41 |
asac | bug 245184 | 16:41 |
ubottu | Launchpad bug 245184 in network-manager "[NM-0.7] nm-connection-editor fails to set/read certificates settings" [Undecided,New] https://launchpad.net/bugs/245184 | 16:41 |
saivann | asac : So is chmsee_1.0.0-1ubuntu1~8.04.1 correct? | 16:43 |
asac | looks good | 16:44 |
asac | or ubuntu0.8.04.1 :) | 16:44 |
asac | whatever you prefer | 16:44 |
saivann | ubuntu0.* ? Shouldn't we keep the existing *1ubuntu1* ? | 16:45 |
asac | saivann: where does 1ubuntu1 exist? | 16:45 |
asac | in intrepid we hvae 1.0.1 iirc | 16:45 |
saivann | asac : Current hardy version is : chmsee_1.0.0-1ubuntu1 | 16:45 |
asac | saivann: oh. then its wrong | 16:46 |
asac | it has to be _higher_ | 16:46 |
asac | ~ == lower ;) | 16:46 |
saivann | asac : Oh! | 16:46 |
saivann | asac : That's right :P I did not think about that | 16:47 |
saivann | asac Ok then chmsee_1.0.0-1ubuntu1.8.04.1 would be correct? | 16:51 |
asac | i think so | 16:51 |
saivann | asac : Thanks, and sorry I got a phone so I was not very active on the channel | 17:08 |
saivann | asac : Before I open the SRU bug, can you review the patch? http://upload.leservicetechnique.com/bugs/chmsee_1.0.0-1ubuntu1.8.04.1.debdiff | 17:21 |
asac | saivann: is there a bug for the desktop thing? | 17:29 |
asac | if not either open one, or be more verbose so archive admin can understand whats going on and why this is suitable for a SRU | 17:29 |
saivann | asac : Ok | 17:30 |
asac | saivann: and maybe tell more about what you did in rules: e.g. drop -rpath in favour of standalone glue + use --with-gecko=libuxl... to use standalone glue | 17:30 |
asac | + whatever you did | 17:30 |
asac | the patch itself looks great | 17:30 |
saivann | asac : If I give more details in the SRU bug report instead of the changelog, would it be ok? | 17:31 |
asac | if the .desttop files are not required just drop the changes | 17:31 |
asac | saivann: well. you currently have two of four entries linked to bugs | 17:31 |
saivann | asac : I believe that I will drop the .desktop file since it does not cause issues in up-to-date hardy, and since it's already fixed in intrepid | 17:31 |
asac | saivann: right | 17:32 |
asac | drop that | 17:32 |
asac | and wrap the debian/rules changes in a changelog entry for xulrunner 1.9 support | 17:32 |
asac | which is most likely bug 2044.. | 17:32 |
ubottu | Launchpad bug 2044 in whereami "whereami does not uninstall cleanly" [Medium,Fix released] https://launchpad.net/bugs/2044 | 17:32 |
saivann | asac : Ok, I do this | 17:33 |
asac | actually i would use only one bug: "xulrunner 1.9 support" and dupe the others into that | 17:33 |
asac | then just make changelog read: + xulrunner 1.9 support | 17:33 |
asac | - debian/rules: use --with-gecko=libxul... and drop -rpath LDFLAGS | 17:34 |
asac | - debian/patches/....: do this | 17:34 |
asac | - debian/patches/....: do that ;) | 17:34 |
asac | first line with (LP: #XXXX) | 17:34 |
saivann | asac : What about this : http://upload.leservicetechnique.com/bugs/chmsee_1.0.0-1ubuntu1.8.04.1.debdiff | 17:55 |
fta | SEAMONKEY_1_1_11_RELEASE | 18:07 |
=== ZrZ is now known as RzR | ||
asac | saivann: thats ok | 22:25 |
saivann | asac : Oh thanks, I uploaded the patch to the bug report | 22:26 |
asac | bug #232402 | 22:26 |
ubottu | Launchpad bug 232402 in chmsee "xulrunner 1.9 support for chmsee 1.0.0" [Medium,Fix released] https://launchpad.net/bugs/232402 | 22:26 |
asac | saivann: attach a debdiff with filtered out autogen | 22:27 |
asac | too | 22:27 |
asac | i will ack it then | 22:27 |
saivann | asac : But the patch doesn't work without autogen, are sure that you want this? | 22:27 |
asac | yes | 22:27 |
asac | for review | 22:27 |
saivann | asac : Ok, I do it right now | 22:28 |
asac | just say that its filtered out for brevity | 22:28 |
asac | nobody really wants to read the autofiles changes ;) | 22:28 |
saivann | asac : thanks for showing me filterdiff ;) | 22:28 |
saivann | asac : Attached | 22:32 |
=== marcus_ is now known as mredivo | ||
=== mredivo is now known as mredivo_ | ||
=== mredivo_ is now known as marcus_ | ||
marcus_ | quick question: can I get at this: http://bazaar.launchpad.net/~mozillateam/flock/flock.head/files/fta%40sofaraway.org-20080608215313-8sy67d8oualhhh3h?file_id=debian-20080603204533-7sw9230101gige8g-1 | 23:56 |
marcus_ | via svn or cvs? | 23:56 |
marcus_ | thanks. | 23:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!