/srv/irclogs.ubuntu.com/2008/07/03/#ubuntu-mozillateam.txt

saivannasac : I'm trying to build to see if my patch apply correctly and the patch system here is dpatch. While building, I get this error : applying patch 04_xulrunner1.9_glue to ./ ...patch: **** malformed patch at line 80: @@ -96,29 +72,28 @@00:07
saivannasac : current patch : http://paste.ubuntu.com/24562/00:08
saivannasac : At this point in the patch, no tricky modifications has been made00:08
saivannasac : I wonder if dpatch needs a space before each hunks00:08
asacsaivann: no ... malformed usually means that you have the numbers wrong00:09
asaccould be that you miss a space somewhere ;)00:09
saivannasac : Oh! That makes sense! I forgot to add 11.. thanks00:09
asacbut you should never remove anything else than complete lines00:09
saivannasac : I switched back to the patch without modifications in the first lines and I still get the same error for line 28000:25
saivannasac : default-prefs-libxul.js does not exist, it is suposed to be created by that patch00:25
saivannasac : but dpatch does not seem to share that point of view00:26
saivannasac : Is there something missing, like @only_in_patch200:26
asacsaivann: how did you add the default-*js file to the patch?00:29
saivannasac : I just copied the hunk from the complete diff00:31
saivannasac : default-*js exist in 1.0.1 so it was in the original diff00:32
asacsaivann: not sure without looking. try to remove hunk by hunk until you find the intruder00:34
asacdouble check that you dont miss a line break at the end of some patch00:34
asacthe original filterdiff patch should work00:35
saivannAh right.. missing break lines, that seems to work now00:40
asachehe00:41
saivannasac : Bad new.. using the same rules file as 1.0.1 (with correct FLAGS), I still get a lot of /usr/lib/xulrunner-devel-1.9b5/lib/libxul.so: undefined reference to `JS_RemoveRoot'00:49
saivann when I try to build in hardy00:49
saivannThe package build-depends on xulrunner-1.9-dev00:49
asacsaivann: right. we are not there yet00:50
asacsaivann: now you have a minimal xulrunner-1.9 patch00:50
asacwhat you dont have is a patch that applies all the autoconf/make changes00:50
saivannasac : Oh, right00:51
asacso thats the next step00:51
asacsaivann: is there a 99_autoXXX patch already?00:51
saivannasac : Actual patch still contains not necessary stuff00:51
saivannasac : no00:51
asacsaivann: yeah. you can clean this afterwards.00:51
asaclets get through the process00:51
saivannasac : The patch applies correctly from now :)00:52
saivannasac : Great! I'm ready to continue00:52
asacyou use dpatch-edit-patch to create a new patch that gets applied at the end of the patchset00:52
asacsaivann: its dpatch right?00:52
asacread manpatch of that tool ;)00:52
saivannasac : yes, the build system use dpatch00:52
asacso when you are in "edit" mode you run the required autotools00:53
saivannasac : Ok00:53
asacnot sure what that is00:53
asacin worst case you just run autoreconf -i -f00:53
asacwhen in edit mode and exit the mode to produce a full update00:53
saivannasac : Do you mean man dpatch?00:54
asacsaivann: no dpatch-edit-patch ;)00:55
saivannasac : I'm not sure but it seems to works like the cdbs patch edit tool00:59
asacyes01:00
asacsaivann: you can use that two most likely ;)01:00
asaci found that cdbs-edit-tools has more bugs though ;)01:00
asac-patch01:00
saivannasac : Oh I get it, I will use kind of sed command on all makefiles?01:00
saivannasac : And then save the patch01:00
saivannhehe :)01:01
asacsaivann: no, you just run the autotools01:01
saivannasac : I just type "autotools" and then "exit" ?01:01
asaclike the autoreconf i suggested above01:01
saivannasac : autoreconf and autotools are still unknown to me, where can I find more information?01:03
asacsaivann: autotools is just a word for a bunch of autoXXXX commands01:03
asacautoreconf is quite simple helper that runs the autoXXX commands in right order for you01:04
asacmaybe you just need to run autoconf, but autoreconf should be safe ;) ... though a bit brute force-like01:04
asacname the patch 99_autoreconf if you use autoreconf ;)01:04
saivannasac : Ok I will try "autoconf" first :)01:04
asacyeah01:05
asacsaivann: well at best try autoreconf first as this will most likely work01:05
asacthen you can try autoconf later and i can bail out :-D01:05
asacgood excercise01:06
asac:)01:06
saivannasac : Ok :P01:08
saivannasac : autoreconf fails with error code 1 : http://paste.ubuntu.com/24570/01:10
asacsaivann: does the source ship a autogen.sh ?01:14
saivannlooking..01:14
saivannasac : Yes01:14
asaccan you run that? sh autogen.sh ?01:14
asacor does it give you problems too01:14
asacin case it auto starts configure, abort01:15
saivannasac : Strangely, same errors : http://paste.ubuntu.com/24573/01:15
asacsaivann: is libtool package installed?01:16
saivannasac : The source is un-touched, changes has been made in debian folder only01:16
saivannasac : on my computer?01:16
asacyes01:16
asacaclocal must succeed01:17
asacotherwise you miss a package01:17
saivannasac : It was not, however, I installed it and tried again without success01:18
saivannasac : Mmh, is there any way to have some clues about which package is missing?01:18
asacsaivann: whats the error now?01:18
asacaclocal should not print AM_PROG_LIBTOOL error if you have libtool installed01:19
saivannasac : http://paste.ubuntu.com/24574/01:19
asacsaivann: do you have all build dependencies of that package installed?01:20
asacthat would be a good start i guess ;)01:20
saivannasac : Ok then I should install glib, gtk, chmlib, etc.01:20
asacchmlib wont exist01:20
asacbut run sh autogen.sh01:20
asacthen it should work01:20
asacsaivann: install build-dependencies ;)01:20
asacsudo apt-get build-dep PACKAGENAME01:20
saivannasac : Sorry01:21
saivannasac : I did remember that command, it's installing now01:21
saivann:)01:21
asachehe01:21
asacwelcome01:21
saivannasac : since build-deps are installed, only AM_PATH_CHMLIB gives a error01:23
asacsaivann: right. use sh autogen.sh01:23
asacdid you use that?01:23
saivannasac : No I was still using autoreconf01:24
asaclook at the output ... it uses aclocal -I m4 ... which means it looks for its _own_ m4 files01:24
asacso that will give you that macro ;)01:24
asacdone01:24
saivannasac : autogen.sh seems to have executed successfully01:24
asacAM_PATH_CHMLIB == macro ;)01:24
asacsaivann: congrats :)01:24
saivannasac : Thanks :D01:24
asacsaivann: the definition for that  macro is in the m4/ directory if you care01:25
asacsaivann: ok if you have created a 99_autogen_sh.dpatch .. chances are high that things work ... if not completely at least somehow01:25
asacit will break if you have forgotten to remove some GLADE rename things for sure01:25
asacsaivann: oh. i think you have to add that patch manually to 00list01:26
asacbut not sure01:26
saivannasac : Yeah I'm looking at it01:26
asaci have a bad opinion about dpatch and avoid to use it ;)01:26
saivannasac : There is still GLADE renaming things in my patch which I did not succed to remove..01:26
saivannasac : ..Well I'm not an expert, but I prefer other patch systems too at this point01:27
asacsaivann: for now you can fix it by just making01:27
asac+ CHMSE01:27
asac- CHMSE01:27
asac:)01:27
asacas a trick;)01:27
asacjust make the patch do nothing so you dont have to care about the hunk bounds ;)01:27
saivannasac : Haha, yeah that's simple, but ugly :P01:28
asacsaivann: you can clean up later01:28
asacbut certainly before upload ;)01:28
asachehe01:28
saivannasac : I agree :)01:28
saivannasac : Ok let's try this01:28
asacha ... i already have almost 30 posts in the forums ;)01:29
asachttp://ubuntuforums.org/showthread.php?t=797059&page=901:29
saivannasac : :)01:36
saivannasac : Unfortunately.. still the same /usr/lib/xulrunner-devel-1.9b5/lib/libxul.so: undefined reference to `JS_RemoveRoot'01:36
asacsaivann: check that the linker flags are there01:37
asace.g. see if you see XPCOM_GLUE in the compile line01:37
asacand -lxpcomglue01:37
saivannasac : I confirm : DEB_CONFIGURE_EXTRA_FLAGS += --with-gecko=libxul01:37
asacsaivann: if thats the new --with-gecko?01:37
saivannasac : No and it's not in the 1.0.1 either01:38
asacsaivann: use the --with-gecko from 1.0.101:38
saivannasac : I used the same rules file as 1.0.1, which use DEB_CONFIGURE_EXTRA_FLAGS += --with-gecko=libxul01:38
asacsaivann: yeah. look at what the compiler spit out and if it had the xpcomglue linker flags01:39
saivannasac : you speak about the configure.ac or Makefile.am??01:40
saivannasac : Or about the build logs?01:40
asacsaivann: about what you see on the command line right before it fails01:41
asacthtas basically the compile command used01:41
saivannasac : Ok, I'm looking to save build logs01:41
asacsaivann: if you see something like -DXPCOMGLUE and -lxpcomglue in there then its probably right01:44
asacand we are likely missing some other hunk which i might have missed01:44
saivannasac : cd . && CC="cc" CXX="g++" CFLAGS="-g -O2 -g -Wall -O2" CXXFLAGS="-g -O2 -g -Wall -O2" CPPFLAGS="" LDFLAGS="-Wl,-Bsymbolic-functions" LDFLAGS=" -Wl,--as-needed" /tmp/buildd/chmsee-1.0.0/./configure --build=x86_64-linux-gnu --prefix=/usr --includedir="\${prefix}/include" --mandir="\${prefix}/share/man" --infodir="\${prefix}/share/info" --sysconfdir=/etc --localstatedir=/var --libexecdir="\${prefix}/lib/chmsee" --di01:48
saivannsable-maintainer-mode --disable-dependency-tracking --srcdir=.   --with-gecko=libxul01:48
saivannasac : I found the word lxpcomglue 2 times in the build logs, but not DXPCOMGLUE01:49
saivannI come back in 2 seconds01:49
asacsaivann: sorry ... XPCOM_GLUE01:50
asacmost likely -DXPCOM_GLUE :)01:51
asaclike what you get with pkg-config --cflags libxul-embedding01:51
asacand pkg-config --libs libxul-embedding01:51
saivannback01:53
saivannasac : DXPCOM_GLUE, XPCOM_GLUE, pkg-config --libs libxul-embedding, none of them are in build logs01:54
asacsaivann: thats bad01:54
asacthat means that the configure.ac changes are not applied01:54
saivannasac : Not really?..01:54
asacnope01:55
asacsaivann: double check that the 99_autogen patch is in 00list01:55
saivannasac : I looked at the build logs and the patches are reported to be applied01:55
asacautogen too?01:55
saivannasac : Yes it is, and build logs says that it was applied during build process01:55
saivannasac : 99_autogen contains a huge amount of changes, made by autogen in dpatch edit01:56
asacsaivann: ok check that GECKO_CFLAGS and GECKO_LIBS are properly set in config.status01:56
saivannasac : config.status, I can't find that file in sources01:57
asacsaivann: nothats in the build directory01:58
asacnot sources01:58
saivannconfig.guess, config.h.in, config.sub01:58
asacthats the result of configure basically01:58
saivannasac : Oh, then that file appears after configure is executed?01:59
asacyes01:59
asacin the build tree01:59
asackeep that tree01:59
asacwork in there ;)01:59
saivannasac : s,@GECKO_CFLAGS@,|#_!!_#|-fshort-wchar -I/usr/include/xulrunner-1.9/unstable -I/usr/include/nspr   -I/usr/include/xulrunner-1.9 -I/usr/include/xulrunner-1.9/commandhandler -I/usr/include/xulrunner-1.9/content -I/usr/include/xulrunner-1.9/dom -I/usr/include/xulrunner-1.9/find -I/usr/include/xulrunner-1.9/gfx -I/usr/include/xulrunner-1.9/gtkembedmoz -I/usr/include/xulrunner-1.9/locale -I/usr/include/xulrunner-1.9/p02:00
saivannref -I/usr/include/xulrunner-1.9/string -I/usr/include/xulrunner-1.9/webbrwsr -I/usr/include/xulrunner-1.9/xpcom -I/usr/include/xulrunner-1.9/xpconnect,g02:00
asacthat looks wrong02:00
asacthats still mozilla-gtkmozembed02:00
asacnot libxul02:00
saivannasac : s,@GECKO_LIBS@,|#_!!_#|-L/usr/lib/xulrunner-devel-1.9/lib -lxpcomglue_s -lxul -lxpcom -lplds4 -lplc4 -lnspr4 -lpthread -ldl  ,g02:01
asacsaivann: yeah thats wrong too02:01
asacthats the dependent glue02:01
saivannasac : Wait, I will try to update my pbuilder environment. After all, xulrunner has been updated02:01
asacso most likely the configure.ac patch is not properly applied in our 99_auto patch02:01
asacor the configure flags we pass from rules are wrong02:02
asacsaivann: no that shouldnt be the problem here02:02
asac(e.g. outdated xulrunner ) :)02:02
saivannasac : No, that's my error, I'm was not working on the patched tree, wait, I will give you the right values02:02
asack02:03
saivannasac : s,@GECKO_CFLAGS@,|#_!!_#|-fshort-wchar -I/usr/include/xulrunner-1.9/unstable -I/usr/include/nspr   -I/usr/include/xulrunner-1.9 -I/usr/include/xulrunner-1.9/commandhandler -I/usr/include/xulrunner-1.9/content -I/usr/include/xulrunner-1.9/dom -I/usr/include/xulrunner-1.9/find -I/usr/include/xulrunner-1.9/gfx -I/usr/include/xulrunner-1.9/gtkembedmoz -I/usr/include/xulrunner-1.9/locale -I/usr/include/xulrunner-1.9/p02:08
saivannref -I/usr/include/xulrunner-1.9/string -I/usr/include/xulrunner-1.9/webbrwsr -I/usr/include/xulrunner-1.9/xpcom -I/usr/include/xulrunner-1.9/xpconnect,g02:08
saivanns,@GECKO_LIBS@,|#_!!_#|-L/usr/lib/xulrunner-devel-1.9/lib -lxpcomglue_s -lxul -lxpcom -lplds4 -lplc4 -lnspr4 -lpthread -ldl  ,g02:08
asacstill the same02:08
asaccheck config.log02:08
saivannasac : I see, and now that's with patches applied02:08
asacyeah. so either configure doesnt have our changes02:09
saivannasac : Right!! We did not patch configure!02:09
asacwell, there is no or ;)02:09
asacsaivann: 99_autogen patch should02:09
saivannasac : ah.02:09
asactry lsdiff debian/patches/99_*02:09
saivannasac : I have config.log, what do you want to search in this file?02:10
asacsaivann: for GECKO_CFLAGS02:10
asac:)02:10
saivannasac : pkg_cv_GECKO_CFLAGS='-fshort-wchar -I/usr/include/xulrunner-1.9/unstable -I/usr/include/nspr  '02:11
saivannpkg_cv_GECKO_LIBS='-L/usr/lib/xulrunner-devel-1.9/lib -lxpcomglue_s -lxul -lxpcom -lplds4 -lplc4 -lnspr4 -lpthread -ldl  '02:11
asacthats wrong02:11
asacmaybe ther eis --with-gecko ?02:11
asacin the log?02:11
saivannasac : Is lsdiff suposed to find if patches has been applied?02:13
asaclist the files affected by a patch02:13
asacso configure should be in there ;)02:13
saivannasac : It is02:15
saivannasac : In build logs, --with-gecko is at the end of the LDFLAGS :02:16
saivannLDFLAGS=" -Wl,--as-needed" /tmp/buildd/chmsee-1.0.0/./configure --build=x86_64-linux-gnu --prefix=/usr --includedir="\${prefix}/include" --mandir="\${prefix}/share/man" --infodir="\${prefix}/share/info" --sysconfdir=/etc --localstatedir=/var --libexecdir="\${prefix}/lib/chmsee" --disable-maintainer-mode --disable-dependency-tracking --srcdir=.   --with-gecko=libxul02:16
asacthat looks ok02:16
asacin config.log you have to hunt why libxul-embedding-unstable is not used02:16
asaceven though --with-gecko=libxul is set02:16
saivann...02:17
saivannI really don't understand why if we use the same files as 1.0.102:18
saivannExcept of course... is it possible that autogen.sh does not update files correctly?02:19
saivannasac : would that be possible?02:20
asaci doubt that02:21
saivannoh.. autogen.sh is pretty short02:21
asachowever, the patch is most likely broken. you can try to look in configure file and asee if the changes we did for configure.ac are there02:22
asacin any case night has to come here02:23
asacsorry that it ended up harder than expected02:26
asacbut the procedure is good for other stuff for sure02:26
* asac off02:26
asacnot saying that you should stop now ;)02:26
saivannasac : Oh you go? Good night ;) Thanks for the time to spent with me, I will continue to search02:26
saivannasac : And well this is not your fault if this package is frustrating ;)02:27
=== asac_ is now known as asac
saivannasac : I don't want to give false hopes, but I think that I found the problem! Working..04:36
saivannasac : I successfully applied the standalone glue! I'm still stuck with FTBFS problems with libltool and working around this.04:56
saivannasac : When you have time for it, I still have a FTBFS but standalone glue works, here's the current package : http://upload.leservicetechnique.com/bugs/chmsee_1.0.0-1ubuntu1~hardy1.tar.gz06:36
saivannasac : build logs : http://paste.ubuntu.com/24635/06:36
* saivann off06:37
gnomefreakasac: you up yet?07:05
* gnomefreak wonders if we get redirected to new wiki07:16
gnomefreakI have finished with the roadmap wiki for now. Let me know if you want something added or have ideas for it. https://wiki.ubuntu.com/MozillaTeam/Roadmap07:55
gnomefreakor maybe i should use mozillateam/roadmap/todolist but its fine for now07:57
gnomefreakalso i cant get sound now :( volume control everything is enabled(not muted) :(08:35
asacgnomefreak: yes?09:15
gnomefreakyes?09:15
asacsaivann: yeah. that look quite good09:15
asacsaivann: what was the problem?09:16
gnomefreakthat email about the dates is hardewr than it was needed adn why did the dates in each section not match any other dates on attachment09:18
gnomefreakare these the dates? 20-07-200809:18
gnomefreak31-08-200809:18
gnomefreak19-10-200809:18
gnomefreak23-11-200809:18
gnomefreak04-01-200809:18
asacreconnect09:30
asacwell more a disconnect ;)09:30
asac_bad thing09:34
asac_shaky connection09:34
asac_gnomefreak: i think at the bottom of the mail there are the actual release dates09:34
asac_err, meeting dates09:34
gnomefreakasac_: not sure but i will ask volan(spelling) or wait for him to reply. if the last ones are it what the hell do the other ones hav eto do?09:35
asac__argh09:39
asac__reconnected again09:39
asac__gnomefreak: those are the mails we send out09:39
asac__with the dates _when_ they are send09:39
asac__(e.g. the preannonucements)09:39
=== asac__ is now known as asac
gnomefreakah ok09:49
* gnomefreak needs a smoke. i havent fallen asleep yet and its not 4:49am09:49
asacgnomefreak: i doubt that you fall asleep if sit infront of the computer ;)09:52
asacor smoke a cigarette09:52
gnomefreakasac: almost fell asleep while smoking my eyes kept closing and i thought they were open :(09:58
asacgnomefreak: then lay down and sleep ;)09:58
asacthats simple09:58
gnomefreakasac: i will soon09:58
asaci mean if the eyes keep closing you will just fade a away09:58
gnomefreaki would like to get sound working first09:58
asachaha09:58
asacthats your problem then ;)... dont complain about a lack of sleep09:59
gnomefreaksomething changed maybe alsa or default card/driver or something adn the one person that knew didnt answer me09:59
gnomefreakpersia > gnomefreak: cat /proc/asound/cards  Notice the new  device.  Change your default.  Ask Hobbsee for  details :)10:02
gnomefreakme doesnt understand since you cant edit that file10:02
gnomefreakhobbsee had left right before that comment10:03
gnomefreakasac: so you know anything about this new device?10:03
asacsound issues are not in my field of expertise10:06
asaci'd love to get rid of all sound ;)10:06
gnomefreaki kind oif like music while working more so working on wikis10:08
gnomefreakasac: feel free to take a look at our roadmap wiki and add so other topics (or giv eme a list and i will. so far there is = TO DO = and == assigned tasks == and == unassigned tasks ==10:10
gnomefreakok im off to bed ill ask crimsun if we see eachother in one of the channels10:16
* gnomefreak cant keep eyes open10:16
=== asac_ is now known as asac
saivannasac : I'll probabl be there in ~4 hours, during the current day12:30
asackk12:30
saivannasac : ping15:39
asacsaivann: yeah .. more or less here15:39
saivannasac : I'm here for 5 hours15:39
asacsaivann: whats up? i read that you managed to get it done mostly15:40
saivannasac : Yes! I found the problem which was in autoreconf patch, which is now correct. Now I still have FTBFS for another reason, see build logs here : http://paste.ubuntu.com/24635/15:41
saivannasac : I don't know if you can help me at this point..15:41
asacsaivann: i think you have to run intltoolize -f -c and include the changes in the autogen patch15:42
asacnot sure why its not in the autgen.sh15:42
saivannasac : autogen.sh contains this : libtoolize -c --automake15:43
saivannho. ok15:43
asacfound something?15:43
saivannasac : No, not yet, but I will try what you suggest right now15:43
asacsaivann: maybe -f is just missing in autogen.sh15:44
asaci think it omits the update if it thinks that all files are in place15:44
saivannasac : autoget.sh use libtoolize -c --automake but not intltoolize -f -c15:45
asacsaivann: add an -f15:46
=== james_w_ is now known as james_w
saivannasac : Ok15:47
asacbug 24518415:47
ubottuLaunchpad bug 245184 in network-manager "[NM-0.7] nm-connection-editor fails to set/read certificates settings" [Undecided,New] https://launchpad.net/bugs/24518415:47
armin76bumb15:53
* armin76 blames asac 15:54
asacarmin76: there is nothing left to bumb15:57
armin76asac: xulrunner :P15:58
saivannasac : Does not FTBFS anymore, you're a genius16:00
asacsaivann: you are quite smart too16:01
asacsaivann: others dont get that far ... no matter what i do ;)16:01
saivannasac : Really, it's not kind of encouraging words? :P16:02
asacarmin76: xulrunner is fresh and great ... we are far ahead of everyone16:02
armin76thank you thank you :D16:02
armin76asac: 1.8?16:02
asacsaivann: its encouraging that you fixed it ;)16:02
asacarmin76: oh :) ... its not in ubuntu, but universe16:02
saivannasac : Thanks :) I'm glad to have worked until the end. I'm going to test the package now16:03
asacsaivann: yeah. enjoy ;)16:03
saivann:)16:03
* asac has no idea what chmsee does ;(16:06
asacsaivann: let me know when you attache a) the minimal patch + b) the complete debdiff to the bug16:22
asacso i can test and sponsor16:22
saivannasac : Ok, it should not be too long, I'm looking to be sure that I don't forget anything16:28
saivannasac : chmsee is a good tool to open .chm files (it's a common help file format used by many programs, and opened by the help center in Windows XP)16:29
asacsaivann: take your time ;)16:35
saivannasac : I want to build it in my PPA before, just a precaution16:35
asacsure16:35
asacits good to have for SRUs anyway16:35
asacsaivann: remember to lower the version by appending ~saivann116:36
asacor something to the package revision16:36
saivannasac : Yes, I added ~ppa1 :) As I do normally16:36
asacgood16:36
saivannasac : And I will create the patch with hardy-proposed in the changelog16:36
asactop16:37
saivannasac : For the patch, chmsee_1.0.0-1ubuntu1~hardy1 is the good version name I guess?16:39
asacusually we dont use codenames, but versions16:40
asace.g. 8.04.116:40
asac(for 1 revision of 8.04 backports16:40
asac)16:40
saivannSo : chmsee_1.0.0-1ubuntu1~8.04.1 ?16:41
saivannasac16:41
asacbug 24518416:41
ubottuLaunchpad bug 245184 in network-manager "[NM-0.7] nm-connection-editor fails to set/read certificates settings" [Undecided,New] https://launchpad.net/bugs/24518416:41
saivannasac : So is chmsee_1.0.0-1ubuntu1~8.04.1 correct?16:43
asaclooks good16:44
asacor ubuntu0.8.04.1 :)16:44
asacwhatever you prefer16:44
saivannubuntu0.* ? Shouldn't we keep the existing *1ubuntu1* ?16:45
asacsaivann: where does 1ubuntu1 exist?16:45
asacin intrepid we hvae 1.0.1 iirc16:45
saivannasac : Current hardy version is : chmsee_1.0.0-1ubuntu116:45
asacsaivann: oh. then its wrong16:46
asacit has to be _higher_16:46
asac~ == lower ;)16:46
saivannasac : Oh!16:46
saivannasac : That's right :P I did not think about that16:47
saivannasac  Ok then chmsee_1.0.0-1ubuntu1.8.04.1 would be correct?16:51
asaci think so16:51
saivannasac : Thanks, and sorry I got a phone so I was not very active on the channel17:08
saivannasac : Before I open the SRU bug, can you review the patch? http://upload.leservicetechnique.com/bugs/chmsee_1.0.0-1ubuntu1.8.04.1.debdiff17:21
asacsaivann: is there a bug for the desktop thing?17:29
asacif not either open one, or be more verbose so archive admin can understand whats going on and why this is suitable for a SRU17:29
saivannasac : Ok17:30
asacsaivann: and maybe tell more about what you did in rules: e.g. drop -rpath in favour of standalone glue + use --with-gecko=libuxl... to use standalone glue17:30
asac+ whatever you did17:30
asacthe patch itself looks great17:30
saivannasac : If I give more details in the SRU bug report instead of the changelog, would it be ok?17:31
asacif the .desttop files are not required just drop the changes17:31
asacsaivann: well. you currently have two of four entries linked to bugs17:31
saivannasac : I believe that I will drop the .desktop file since it does not cause issues in up-to-date hardy, and since it's already fixed in intrepid17:31
asacsaivann: right17:32
asacdrop that17:32
asacand wrap the debian/rules changes in a changelog entry for xulrunner 1.9 support17:32
asacwhich is most likely bug 2044..17:32
ubottuLaunchpad bug 2044 in whereami "whereami does not uninstall cleanly" [Medium,Fix released] https://launchpad.net/bugs/204417:32
saivannasac : Ok, I do this17:33
asacactually i would use only one bug: "xulrunner 1.9 support" and dupe the others into that17:33
asacthen just make changelog read: + xulrunner 1.9 support17:33
asac - debian/rules: use --with-gecko=libxul... and drop -rpath LDFLAGS17:34
asac - debian/patches/....: do this17:34
asac - debian/patches/....: do that ;)17:34
asacfirst line with (LP: #XXXX)17:34
saivannasac : What about this : http://upload.leservicetechnique.com/bugs/chmsee_1.0.0-1ubuntu1.8.04.1.debdiff17:55
ftaSEAMONKEY_1_1_11_RELEASE18:07
=== ZrZ is now known as RzR
asacsaivann: thats ok22:25
saivannasac : Oh thanks, I uploaded the patch to the bug report22:26
asacbug #23240222:26
ubottuLaunchpad bug 232402 in chmsee "xulrunner 1.9 support for chmsee 1.0.0" [Medium,Fix released] https://launchpad.net/bugs/23240222:26
asacsaivann: attach a debdiff with filtered out autogen22:27
asactoo22:27
asaci will ack it then22:27
saivannasac : But the patch doesn't work without autogen, are sure that you want this?22:27
asacyes22:27
asacfor review22:27
saivannasac : Ok, I do it right now22:28
asacjust say that its filtered out for brevity22:28
asacnobody really wants to read the autofiles changes ;)22:28
saivannasac : thanks for showing me filterdiff ;)22:28
saivannasac : Attached22:32
=== marcus_ is now known as mredivo
=== mredivo is now known as mredivo_
=== mredivo_ is now known as marcus_
marcus_quick question: can I get at this: http://bazaar.launchpad.net/~mozillateam/flock/flock.head/files/fta%40sofaraway.org-20080608215313-8sy67d8oualhhh3h?file_id=debian-20080603204533-7sw9230101gige8g-123:56
marcus_via svn or cvs?23:56
marcus_thanks.23:56

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!