[00:00]  * persia has a few things in /usr/share/icons, http://paste.ubuntu.com/34919/ is the package list.  Everything seems to be in subdirectories.
[00:00] <RainCT> k0p: also, please install the html (with it's images and everyting) in usr/share/doc/umit/html
[00:02] <k0p> RainCT, ok. so I need to fix it again
[00:02] <k0p> RainCT, if I lost advocate I fix icons too.
[00:02] <RainCT> k0p: I've done some little changes - I'm uploading them now so that you can see a diff and check if you are happy with them
[00:02] <RainCT> persia: I have those inside hicolor/??x??/apps/ directories
[00:04] <k0p> RainCT, I don't have.
[00:04] <k0p> so RainCT only fix html path?
[00:04] <RainCT> k0p: http://revu.ubuntuwire.com/diff.py?upid1=3212&upid2=3213
[00:04] <persia> k0p: Just fix, even though it costs you an advocate.  Most of those that do REVU watch this channel, and are less likely to give you a second ack with known issues.  Further, any of them can also cancel your advocation with a comment.
[00:05] <k0p> persia, so fix the icons and html right?
[00:05] <persia> RainCT: I have a direct /usr/share/icons/application-default-icon.png, and 17directories full of various stuff.
[00:05] <persia> k0p: If you fix it, RainCT will likely give you back the advocation.  If you don't, he might just comment and cancel your previous advocation :)
[00:06] <k0p> of course.
[00:06]  * persia hasn't reviewed the package, but very much doesn't think not updating because it might cost advocation makes any sense when the person suggesting the changes could override the advocation anyway...
[00:06] <k0p> but RainCT fix it in the diff
[00:06] <k0p> RainCT, do you fix it?
[00:07] <RainCT> k0p: the html one no (wasn't sure how to do that)
[00:07] <RainCT> and about the icons I still don't know if they are allowed to be there or not
[00:07] <k0p> RainCT, I'm seeing
[00:07] <k0p> I don't need ico
[00:07] <k0p> on ubuntu
[00:07] <k0p> so i'll remove it
[00:07] <k0p> it solves two problems. :)
[00:07] <RainCT> oh. why do you install them if they aren't necessary? o_O
[00:08] <k0p> well I'm looking the umit code
[00:08] <k0p> I don't totally sure yet
[00:08] <k0p> but may be it's
[00:08] <k0p> wait please
[00:09] <k0p> RainCT, lacks a setup patch
[00:09] <k0p> I need to change html dir ;)
[00:09] <k0p> RainCT, can you wait 10 minutes?
[00:09] <k0p> I'll made necessary fixes. ok?
[00:09] <k0p> persia, thanks for you words :)
[00:10]  * RainCT is asking about the icons in #ubuntu-desktop
[00:11] <k0p> yeap because it's needed
[00:11] <RainCT> k0p: Uhm, I think I'm going to bed (I wouldn't feel happy uploading while I'm half asleep anyway ;)), but I'll leave REVU open on a tab and look at it tomorrow morning
[00:12] <RainCT> good night all
[00:12] <k0p> RainCT, ok.
[00:12] <k0p> RainCT, i'll fix it.
[00:12] <k0p> tomorrow if you can see it
[00:12] <k0p> please :)
[00:12] <k0p> good night
[00:13] <RainCT> cy
[00:31] <nhandler> Quick question. How many characters long can the short description in debian/control be? I know this is listed on some wiki page, but I am currently unable to locate that page.
[00:35] <bobbo> nhandler: Debian policay says ~80 chars or less
[00:36] <ianm_> what needs to happen for this package to get to hardy?  http://packages.ubuntu.com/search?keywords=screenruler
[00:37] <nhandler> Thank you bobbo.
[00:37] <crimsun> it would need to enter intrepid first and then be built for hardy-backports
[00:37] <crimsun> nothing can go into hardy proper now.
[00:38] <ianm_> crimsun: new apps can't be made available in the repos of hardy?
[00:39] <crimsun> ianm_: correct.
[00:39] <ianm_> do you know why that is?  I mean that app was written on Hardy :)
[00:39] <crimsun> hardy is frozen; anything new has to go into hardy-{proposed,updates}, hardy-security, or hardy-backports
[00:40] <crimsun> ianm_: it's because nothing new (source package-wise) can enter a frozen pool
[00:40] <ianm_> is that to maintain some sort of sanity for past releases?  so they don't keep developing new problems?
[00:42] <emil-caucho> hello
[00:45] <crimsun> ianm_: yes (to the first).
[00:46] <ianm_> crimsun: understandable.  frustrating though (as an app developer)
[00:50] <nxvl> jcastro: around?
[00:50] <ianm_> oh-- I'd like to connect with a specific launchpad developer, he works for canonical, maybe he's in here (I'm bad with names...)--  I had lunch with you at OSCON, spanish on my shirt, give a shout if you're around
[00:50] <nxvl> jcastro: why do we haven't had Ubuntu Open Week this release still?
[00:52] <nxvl> err
[00:52] <nxvl> DeveloperWeek
[00:55] <emgent> nxvl: pong ?
[00:56] <beuno> ianm_, kiko maybe?
[00:57] <nxvl> emgent: check your mail
[00:57] <emgent> will do :)
[00:58] <nxvl> emgent: i CCed you something i will like you to reply
[00:58] <nxvl> :P
[00:58] <ianm_> beuno: did he do the OSCON presentation on launchpad?
[00:58] <beuno> ianm_, yeap. Him (Christian Reis) and Rinchen (Joey Stanford)
[00:59] <ianm_> beuno: were there any other canonical employees there?
[00:59] <beuno> ianm_, I don't know, I wasn't there  :)
[00:59] <james_w> ianm_: there were a few I think, was he Brazilian?
[00:59] <emgent> nxvl: yeah i saw. will do :)
[00:59] <ianm_> james_w: no
[01:00] <nhandler> ianm_: http://en.oreilly.com/oscon2008/public/schedule/proceedings. Scroll down and you will see the Launchpad presentation. It only lists Kiki and Joey
[01:00] <james_w> ianm_: American?
[01:00] <nhandler> Here is a direct link ianm_: http://en.oreilly.com/oscon2008/public/schedule/detail/3456
[01:00] <huats> nxvl: good luck :)
[01:00] <nxvl> huats: thank you! I'm scared as hell
[01:01] <huats> I am sure it'll be OK
[01:01] <huats> :)
[01:01] <huats> I would have +1 you but it is useless :)
[01:02] <ianm_> james_w: yeah
[01:03] <james_w> ianm_: if it's Joey his picture is on the second link nhandler gave you
[01:03] <ianm_> yeah that's him
[01:03] <nxvl> huats: heh
[01:03] <nxvl> huats: i apreciate it anyway :D
[01:04] <ianm_> this has got to be the most helpful irc channel I've ever been in ;)
[01:08] <ember> RainCT: thanks, i've updated on revu
[01:20] <k0p> ever I think that my package doesn't have issue some one discover ones.. :o lol
[01:25]  * ScottK wonders if "The Software shall be used for Good, not Evil" in the license means it has to go in multiverse
[01:25] <ianm_> k0p: clear lesson: never think that, and there will never be any problems
[01:26] <k0p> ianm_, yeap..
[01:26] <k0p> you're right :)
[01:45] <jcastro> nxvl: there's one this cycle yes, probably won't announce dates and such until after the global bug jam
[01:52] <nxvl> jcastro: awesome!
[01:52] <nxvl> jcastro: you ROCK
[01:53] <jcastro> nxvl: it's you guys that make it rock, I'm just a glorified calendar, heh
[01:54] <nxvl> jcastro: :D
[01:55] <nxvl> jcastro: the initial push is always the hardest
[01:59] <ApOgEE-> hehe
[02:11] <nxvl> emgent: can you please take a look at Bug 255367
[04:07] <foxbuntu> any able to check to see if my package made it to revu?
[04:07] <foxbuntu> I checked the site but it hasnt showed up and I sent it about an hour ago
[04:08] <ion_> What was the dput line you used?
[04:08] <foxbuntu> dput revu my-package_source.changes
[04:09] <ion_> Ok. And it was PGP signed for sure?
[04:09] <foxbuntu> yes
[04:09] <foxbuntu> I have had packages revu'd before
[04:11] <foxbuntu> ion_, the package is mythbuntu-log-grabber
[04:15] <foxbuntu> ion_, any thoughts?
[04:17]  * ScottK gives nxvl a smack.
[04:20] <ion_> I’ve got nothing.
[04:23] <tbielawa> I got a comment on a recent revu that it FTBFS. I am unable to replicate that error.
[04:23] <tbielawa> Can anyone take a minute and try to build this: http://revu.ubuntuwire.com/details.py?upid=3187
[04:23] <tbielawa> += please
[04:29] <james_w> tbielawa: it builds for me too
[04:29] <james_w> you may want to ask them how they built it
[04:29] <james_w> it may be something to do with build/clean interactions or something
[04:29] <tbielawa> james_w, thanks for testing that for me. I'll ask for how they built it when I submit my next upload
[04:30] <james_w> or even trying to build on a filesystem mounted noexec
[04:30] <tbielawa> do people do that? perhaps RainCT's home dir is mounted in that way.
[04:34] <james_w> I doubt it
[04:34] <james_w> it's a possibility though
[04:34] <foxbuntu> any one here able to look at the revu system and see if my package is stuck?
[04:34] <james_w> it's not a supported way to build a package there though
[04:34] <james_w> s/there//
[04:38] <TheMuso> james_w: You are up late.
[04:40] <james_w> TheMuso: yep, day off tomorrow, and a weekend away, so I'm practising staying up :-)
[04:40] <TheMuso> james_w: hahaha sounds good. :p
[04:41] <james_w> time to crash though
[04:41] <james_w> bye TheMuso
[04:43] <TheMuso> james_w: Enjoy your time off.
[04:45] <tbielawa> regarding man pages: I'm packaging a game, the game takes no command line options, is a man page going to be required anyway?
[04:47] <ScottK> Yes.
[04:48] <tbielawa>  :)
[04:55] <nxvl> ScottK: what are you applying the patch against?
[04:56] <nxvl> ScottK: the courier one
[04:56] <nxvl> ScottK: it's a debian new version vs merged version patch
[04:57] <foxbuntu> any one here able to look at the revu system and see if my package is stuck?
[04:58] <tbielawa> foxbuntu: have you attempted to upload it again?
[05:00] <foxbuntu> tbielawa, I havent, no
[05:01] <tbielawa> foxbuntu: might as well give it a try I think
[05:02] <foxbuntu> tbielawa, alright
[05:31] <foxbuntu> tbielawa, no luck
[05:32] <foxbuntu> tbielawa, any other help you can offer?
[05:35] <tbielawa> foxbuntu: I wish I could, I haven't got any administrative right to though. Sorry :(
[05:36] <RoAkSoAx> o/ tbielawa long time no see
[05:36] <tbielawa> RoAkSoAx, hi to you!
[05:36] <foxbuntu> tbielawa, thanks anyways
[05:36] <RoAkSoAx> tbielawa, how is it being going for ya?
[05:37] <fabrice_sp> foxbuntu: did you merge your old REVU account and the new Openid one?
[05:37] <persia> foxbuntu: Which package?
[05:37] <persia> myhbuntu-log-grabber?
[05:38] <foxbuntu> persia, yes
[05:38] <RoAkSoAx> can anyone review http://revu.ubuntuwire.com/details.py?package=plasmoid-qalculate please :)
[05:38] <tbielawa> RoAkSoAx, things are well. School begins in about two weeks, I just started a free software club! lp.net/~fsag
[05:38] <foxbuntu> fabrice_sp, I may not have
[05:38] <persia> foxbuntu: What's your LP page?
[05:38] <RoAkSoAx> tbielawa, cool, i'm already an engineer, supported my thesis 3 weeks ago :)
[05:39] <tbielawa> congrats RoAkSoAx
[05:39] <tbielawa> !
[05:39] <RoAkSoAx> ty :)
[05:39] <nxvl> persia: how did you check the queue? with REVU admin superpowers or it's open to public?
[05:39] <foxbuntu> persia, nickj-fox
[05:39] <persia> nxvl: REVU admin superpowers
[05:40] <nxvl> superpowers are kewl
[05:40] <tbielawa> haha
[05:41] <RoAkSoAx> nxvl, you back already?
[05:41] <nxvl> RoAkSoAx: cdbs, you lazy!
[05:42] <nxvl> RoAkSoAx: yeah, i'm in PdM again
[05:42] <foxbuntu> persia, https://launchpad.net/~nickj-fox
[05:43] <RoAkSoAx> nxvl, i was following the example of others plamoids so... i'll work on other packages later :) i need to finish task of  watchfiles/updates  :P
[05:44] <nxvl> RoAkSoAx: your package doesn't have a watch file
[05:44] <nxvl> RoAkSoAx: you should add one
[05:45] <RoAkSoAx> nxvl, i've tried but cant get the download hrefs from kde-look.org
[05:46] <nxvl> then try harder
[05:46] <nxvl> :D
[05:46] <RoAkSoAx> will do :P
[05:47] <tbielawa> atta'boy!
[05:49] <persia> foxbuntu: What do you get locally with `gpg --verify mythbuntu-log-grabber_0.1-0ubuntu1_source.changes`?  22D78758 seems to be in the keyring, but manual processing results in a ValidationFAILED!! message.
[05:50] <RoAkSoAx> well i'm tired, bye all
[05:50] <foxbuntu> persia, nick@work-lappy:~/Desktop/mythbuntu_branches$ gpg --verify mythbuntu-log-grabber_0.1-0ubuntu1_source.changes
[05:50] <foxbuntu> gpg: Signature made Wed 06 Aug 2008 08:47:43 PM CDT using DSA key ID 22D78758
[05:50] <foxbuntu> gpg: Good signature from "Nick Fox <nfox@foxmediasystems.com>"
[05:50] <persia> foxbuntu: Extra strange.  I'm really not sure why it doesn't work.
[05:51] <tbielawa> I wonder if this is related to an issue I had with revu today.
[05:51] <persia> I'll put it back in the queue, and we can see what happens automatically: maybe my manual attempt broke it.
[05:51] <tbielawa> I went and did a wget -x on my latest .dsc uploaded there and it couldn't verify the upload
[05:53] <foxbuntu> persia, alright I'll wait a bit longer, let me know if you want me to push it again
[05:53] <nxvl> persia: can you please try to apply the patch against debian package and reopen the bug if it works on https://bugs.launchpad.net/bugs/254681
[05:57] <foxbuntu> persia, awesome...its in now
[05:57] <foxbuntu> persia, you could look at it an try for an ACK too if you like ;)
[05:57] <persia> foxbuntu: In that case, the failure was related to your key and account: having fixed your account, it just needed to be put back in queue.  My attempt to manually jam it in place was apparently using a now deprecated procedure.
[05:58] <foxbuntu> persia, ok thanks
[05:58]  * persia may, but is currently catching up on ~6 hours of communications backlog
[05:59] <foxbuntu> persia, no big deal...thanks for your help
[06:01]  * RAOF is extremely glad he's inside, and not out in the thunderstorm.
[06:02] <nxvl> RAOF: where are you based?
[06:02] <RAOF> Sunny Sydney
[06:02]  * nxvl want's to visit Australia
[06:03] <RAOF> It's kinda fun watching the windows bulge in as the thunder hits.
[06:03] <tbielawa> has anyone used manedit for building man pages? does anyone have suggestions for other utilities to use?
[06:03] <RAOF> Dear lord.  Hibernate works!
[06:03] <nxvl> i have
[06:03] <nxvl> once
[06:03] <tbielawa> lol
[06:03] <nxvl> long time ago
[06:03] <RAOF> tbielawa: I've generally used docbook & docbook2x to generate manpages.
[06:04] <nxvl> it's cool and easy, as far as i remember
[06:04] <nxvl> i generally ask upstream for manpages
[06:04] <nxvl> <- lazy
[06:05] <tbielawa> nxvl: cool and easy? I wish it were _fun_ an easy :)
[06:05] <nxvl> cool is in some degree fun
[06:05] <tbielawa> :)
[06:06] <nxvl> but manpages aren't fun at all
[06:06] <tbielawa> :(\
[06:06] <tbielawa> I was writing one for a utility I wrote for my workplace. Writing as in: by hand. It made [ !cool && !easy && !fun ] true
[06:07] <nxvl> why? by hand is cooler, easier and less PITA than using tools
[06:08]  * nxvl hates using tools for formatting stuff
[06:08] <nxvl> what i would do is: take a manpage and edit it's content
[06:08] <nxvl> nice and easy
[06:09] <tbielawa> :)
[06:11] <TheMuso> RAOF: Interesting. We got rain up here, but no storms.
[06:11] <tbielawa> interesting:
[06:11] <tbielawa> public domain license
[06:11] <tbielawa> ack
[06:12] <tbielawa> $ manedit
[06:12] <tbielawa> Segmentation fault
[06:12] <nxvl> heh
[06:12] <nxvl> Seg faults are always fun
[06:12] <nxvl> but at some points can drive you crazy
[06:13] <dholbach> good morning
[06:13] <tbielawa> d'morning dholbach
[06:13] <dholbach> hi tbielawa
[06:14] <tbielawa> dholbach: do you recall me mentioning that my office names servers after motu and main devs?
[06:14] <dholbach> tbielawa: yes, I do - I still recall you saying "dholbach is about to be replaced" or something along those lines
[06:15] <tbielawa> dholbach: :p
[06:15] <tbielawa> well, the dholbach tftpserver has been virtualized, not depricated ;)
[06:15] <nxvl> dholbach: hi!
[06:16] <dholbach> tbielawa: man, those were the proudest 5 minutes of my life.... until you told me 'dholbach' was about to be replaced
[06:16] <dholbach> hey nxvl
[06:17] <tbielawa> sorry about that dholbach. you're still loved @wvu CS department yet though :)
[06:17] <StevenK> tbielawa: I'm idly curious if there is a 'stevenk' server
[06:17] <nxvl> what>
[06:17] <nxvl> tbielawa: your servers have our names (i still don't think one's got my)
[06:17] <dholbach> tbielawa: that's good to hear :)
[06:17] <persia> tbielawa: Is the list of machines public?
[06:18] <nxvl> someone need to blog about this
[06:18] <tbielawa> persia: it's not publicised anywhere, but I can aggregate a list pretty quickly :)
[06:19] <dholbach> nxvl: looks like everybody likes your video (http://www.youtube.com/watch?v=SLpoi5PlFP8) :-)
[06:21] <nxvl> wow
[06:21] <nxvl> 1220 people has saw my video in about 3 days?
[06:22] <TheMuso> nxvl: re segfaults, like failing hardware? :p
[06:22] <dholbach> yeah, and like 250 in the first 15 minutes - that was amazing
[06:22] <nxvl> \o/
[06:22]  * dholbach hugs nxvl
[06:22]  * nxvl HUGS dholbach back
[06:30] <tbielawa> http://csee.wvu.edu/~tbielawa/servers_of_fame
[06:30] <tbielawa> names collected from the planet.ubuntu blog
[06:31] <tbielawa> minus a few obvious ones here and there...
[06:32] <nxvl> like torvalds?
[06:32] <nxvl> and murdock
[06:32] <tbielawa> ;)
[06:33] <nxvl> dholbach: are you going to debconf?
[06:34] <tbielawa> my manager estated the law of server naming. He was a debian maintainer/contributer for DRBD back in the day
[06:39] <dholbach> nxvl: no, I'm not
[06:42] <nxvl> it's kind of long way from berlin :P
[06:43] <tuxmaniac> wgrant: thanks.
[06:43] <dholbach> nxvl: doko is going (from Berlin :-))
[06:45] <nxvl> i wanted to go, but i make a misunderstunding on the sponsorship thing i didn't confirm
[06:45] <nxvl> :(
[06:45] <nxvl> so, no debconf for me this year
[06:45] <nxvl> woohoo \o/ launchpad show all the e-mails again
[06:53] <nxvl> dholbach: would you do me a favor
[06:53] <dholbach> nxvl: I can try
[06:53] <nxvl> dholbach: can you please try to apply patch on https://bugs.edge.launchpad.net/ubuntu/+source/courier/+bug/254681 against debian package and confir is it patchs
[06:54] <nxvl> confirm*
[06:54] <dholbach> nxvl: you mean if the patch applies?
[06:54] <nxvl> yep
[06:54] <nxvl> not to review the patch
[06:54] <nxvl> just to check if the patch applies to the debian package
[06:54] <dholbach> hang on a sec
[06:56] <dholbach> nxvl: applies cleanly
[06:56] <dholbach> hi ara
[06:56] <nxvl> dholbach: ok, can you please reopen the bug report
[06:57] <dholbach> hm?
[06:57] <nxvl> dholbach: ScottK closes it as incomplete since he said it doesn't apply
[06:57] <StevenK> I thought it was set to Incomplete?
[06:57] <StevenK> Incomplete isn't closed
[06:57] <tuxmaniac> dholbach: sorry for interruption. But just a little ping onthe bug report I filed yesterday on 5-a-day
[06:57] <tuxmaniac> if you havent seen it yet
[06:57] <nxvl> StevenK: yeah, but for sponsoring queue it is
[06:57] <nxvl> :D
[06:57] <nxvl> or kind of
[06:57] <StevenK> Invalid would be closed. Incomplete is "more information"
[06:57] <nxvl> dholbach: and Thank you!
[06:58] <dholbach> tuxmaniac: I've seen it, but I just got up and am triaging my inbox
[06:58] <dholbach> tuxmaniac: so it will take a while until I get to it
[06:58] <nxvl> StevenK: and actually incomplete bugs are deleted, so they are kind of closed
[06:58] <tuxmaniac> dholbach: no no. I just wanted to confirm you have seen it. Just a little ping thats it.
[06:58] <dholbach> tuxmaniac: yes, got it
[06:59] <ara> morning all
[06:59] <nxvl> well
[06:59] <nxvl> i need to go back to work tomorrow
[06:59] <nxvl> i hate the end of holidays
[06:59] <nxvl> :(
[07:00] <nxvl> i really need a FOSS related work
[07:00] <nxvl> i hate suits
[07:00] <nxvl> read you tomorrow
[07:00] <nxvl> dholbach: thank you again!
[07:00] <dholbach> np :)
[07:01]  * nxvl HUGS everyone
[07:06] <Ash-Fox> Help, I has been hugged.
[07:06] <ion_> http://revu.ubuntuwire.com/details.py?package=compcache-setup anyone? :-)
[07:42] <silwol> good morning
[07:43] <silwol> I am packaging navit for http://launchpad.net/~openstreetmap/+archive
[07:43] <silwol> there are several different guis available: gtk, cegui...
[07:43] <silwol> navit needs at least one in order to run
[07:44] <silwol> I would split the package into several plugin packages (the guis are actually plugins as far as I can see for no)
[07:45] <persia> silwol: multiple binary packages would make sense: that way users only need to install what they need.
[07:45] <silwol> persia: how should the dependencies look like?
[07:46] <silwol> persia: should there be one package called navit which depends on navit-gui-gtk for example?
[07:46] <persia> I would expect the GUIs to Depends: on the core, and the core to Recommends each of the GUIs with a | relation
[07:46] <silwol> is there an easy way that the user can just choose to install navit and get the default (currently gtk) gui?
[07:47] <persia> Rather, nvait-gui-gtk depends on navit (as the GUI isn't going to work without the software), and navit Recommends: navit-gui-gtk | navit-gui-cegui | ...
[07:48] <persia> You could have a virtual navit-gui, and have navit Recommend navit-gui, and each of the GUIs Provide: navit-gui, but this makes a new virtual package, and somehow I feel that new virtual packages should only go in Debian unless they are critical to Ubuntu in some way.
[07:49] <silwol> well, I will send an email to the debian-gis mailing list anyway.
[07:49] <silwol> it is just to have packages for now
[07:49] <silwol> in the ppa
[07:50] <silwol> would it be possible to have some meta-package which contains all the dependencies to a minimal set of packages that run?
[07:54] <persia> You could, but I would expect that installing navit would do that in Recommends.
[07:54] <persia> Alternately, installing navit-gui-gtk should get me the GUI and navit, so I can run things.
[08:29] <RAOF> Any Kubuntu users here who would like to post the output of "echo $DESKTOP_SESSION"?
[08:31] <StevenK> RAOF: default, but I'm no Kubuntu user :-P
[08:31]  * StevenK hides
[08:31] <RAOF> StevenK: That's the output?  That's less helpful than I was hoping for.
[08:31] <StevenK> steven@liquified:~% echo $DESKTOP_SESSION
[08:31] <StevenK> default
[08:31] <RAOF> Crap.
[08:32] <RAOF> There goes the simple xdg-open fix :(
[08:32] <tbielawa> :(
[08:32] <RAOF> You're in gnome, aren't you?
[08:32] <StevenK> I am
[08:32] <RAOF> Why doesn't that say "gnome" then, damnit!
[08:33] <tbielawa> mine says default as well (running gnome)
[08:33] <RAOF> The fact that mine says 'gnome' is obviously a local artefact.
[08:33] <RAOF> Oh.  Are either of you running Intrepid?
[08:34] <tbielawa> RAOF: no
[08:34] <huats> morning everyone
[08:34] <tbielawa> good morning huats
[08:34] <huats> morning tbielawa
[08:34] <RAOF> StevenK: You running intrepid?
[08:35] <StevenK> RAOF: Nope
[08:35] <StevenK> RAOF: Mainly, I was trying to tease you
[08:35] <RAOF> Woot!  My hope is still alive that checking for DESKTOP_SESSION=gnome will be an accurate gnome-detection mechanism!
[08:35] <StevenK> RAOF: Ask seb?
[08:36] <RAOF> Good plan.
[08:36] <tbielawa> RAOF: you looked through all the values from `env', right?
[08:37] <RAOF> tbielawa: Yup, indeed.
[08:37] <tbielawa> *nod*
[08:37] <tbielawa> good luck.
[08:37] <RAOF> Candidates are GNOME_KEYRING, but that seems unreliable, and GDMSESSION, which is likewise.
[08:38] <crimsun> heh.  GNOME_DESKTOP_SESSION.
[08:38] <persia> RAOF: I've "default" on intrepid
[08:39] <persia> (mind you, I don't seem to have an underscore key on intrepid, but that's a different issue)
[08:39] <crimsun> err, sorry:  GNOME_DESKTOP_SESSION_ID
[08:39] <RAOF> crimsun: On Intrepid?
[08:39] <RAOF> Because that is _not_ set here.
[08:40] <RAOF> Which is why xdg-open is broken.
[08:40] <crimsun> no, this is 8.04.1
[08:40] <RAOF> Right.  All you sane people on Hardy can shut up now, this only affects insane people running Intrepid.
[08:42] <crimsun> silly insane people.
[08:49] <directhex> what are the rules regarding adding functionality to an app in the package rather than from upstream?
[08:56] <persia> directhex: Be very careful not to break anything, and also sent it upstream
[08:59] <directhex> hm, one itty bitty bug to iron out first
[08:59] <directhex> currently fails to work unless you use my new functionality :)
[09:00] <persia> See, that would be part of the "be very careful" part :)
[09:01] <directhex> well, you know what it's like hacking other peoples' code. at least the new functionality works, and barring typos, THAT part was right first time
[09:48] <directhex> done.
[09:49] <directhex>  FilePlugin.cs |   17 +++++++++++++++--
[09:49] <directhex>  1 file changed, 15 insertions(+), 2 deletions(-)
[09:53] <directhex> wait, still bugged
[10:02] <k0p> directhex, what do you need?
[11:46] <\sh> fresspire/linspire back to debian base and not ubuntu anymore? what went wrong? I wonder
[11:47] <sistpoty|work> hi folks
[11:48] <k0p> hi
[11:49] <directhex> hahaha, found a delightful genius bug
[11:49] <directhex> it's a really cute bug ^_^
[13:15] <joaopinto> Hello
[13:15] <joaopinto> can someone review http://revu.ubuntuwire.com/details.py?package=amoebax ? Thanks
[13:16] <coolbhavi> Hello
[13:16] <coolbhavi> is this the correct command? requestsync --lp -s <package> <target_version>
 isn't it? i.e. "intrepid"
[13:17] <james_w> yeah
[13:18] <coolbhavi> james_w, no response from requestsync
[13:19] <coolbhavi> james_w, Internet is fine
[13:21] <james_w> coolbhavi: you mean it sits there hung, or it just does nothing?
[13:22] <james_w> no output at all?
[13:23] <coolbhavi> james_w, exactly.... it was fine yesterday
[13:23] <james_w> no idea what that will be, sorry
[13:24] <coolbhavi> james_w, I mean its hung
[13:28] <coolbhavi> james_w, from pas 45 mins
[13:28] <coolbhavi> past*
[13:29] <cody-somerville> My guess is that it isn't working :P
[13:29] <coolbhavi> cody-somerville, maybe yes
[13:30] <cody-somerville> I'm pretty sure that script is python, you can probably modify the shebang to see which line it is hanging on
[13:31] <coolbhavi> cody-somerville, Ok
[13:31] <coolbhavi> cody-somerville, or shall I reinstall? it was working yesterday
[13:33] <cody-somerville> reinstalling would fix it how?
[13:34] <coolbhavi> cody-somerville, when I know that script was working yesterday why would I change it?
[13:34] <cody-somerville> coolbhavi, to see why?
[13:39] <ember> can someone have a look at http://revu.ubuntuwire.com/details.py?package=hamster-applet
[13:59] <coolbhavi> cody-somerville, here is the script http://pastebin.com/d6943ab6 and here is the trackback  http://pastebin.com/d544ce147
[14:05] <sistpoty|work> coolbhavi: looks like you're missing rmadison
[14:06] <sistpoty|work> (which should be in depends of ubuntu-dev-tools then)
[14:06] <coolbhavi> sistpoty|work, yes
[14:07] <RainCT> (it's in devscripts which is a dependency of u-d-t)
[14:07] <coolbhavi> sistpoty|work, I have installed ubuntu-dev-tools
[14:07] <k0p> hi RainCT :)
[14:07] <k0p> RainCT, tonight I fix what you ask.
[14:07] <sistpoty|work> coolbhavi: and devscripts (or whatever package rmadison is in) as well?
[14:07] <k0p> RainCT, can you take a look? :)
[14:08] <sistpoty|work> coolbhavi: just check, if you can run rmadison from shell
[14:09] <RainCT> k0p: yep, in a while :)
[14:09] <k0p> ok, thanks :)
[14:10] <k0p> RainCT, I discover that icons is only for packing for windows. So, now we don't have icons, and html it's on doc/html.
[14:12] <coolbhavi> sistpoty|work, E: need at least one package name as an argument.
[14:13] <jpds> coolbhavi: Then you have it installed.
[14:14] <jpds> coolbhavi: What command are you doing with requestsync?
[14:14] <coolbhavi> jpds, is this the correct command? requestsync --lp -s <package> <target_release>
[14:16] <jpds> Which package?
[14:19] <coolbhavi> jpds, its firebug
[14:21] <jpds> coolbhavi: Oh, I think rmadison is still broken on the Debian server.
[14:22] <coolbhavi> jpds, so I have to wait?
[14:22] <jpds> Which would explain why it cannot query the server.
[14:22] <jpds> coolbhavi: Or do the bug report by hand.
[14:22] <coolbhavi> jpds, ok
[14:26] <jpds> Hmm, qa.d.o appears to be down.
[14:27] <jpds> And #debian-devel /topic confirms.
[14:27] <coolbhavi> jpds, thanks
[15:20] <RainCT> hi dpm
[15:20] <dpm> hi RainCT, thanks for the prompt response to the e-mail
[15:55] <emgent> hello
[15:58] <lukehasnoname> hello
[15:59] <raphink> hello there :)
[15:59] <raphink> anyone ever wanted to view QTVR on linux ? :)
[15:59] <raphink> http://revu.ubuntuwire.com/details.py?package=freepv
[16:06] <persia> raphink: source lintian to begin with...
[16:07] <raphink> persia: yes, I saw
[16:07] <raphink> gonna fix these details ;)
[16:08] <huats> TheMuso: are you around ?
[16:08] <huats> raphink and persia hey there
[16:08] <raphink> hi huats
[16:08] <RoAkSoAx> heyall
[16:09] <persia> raphink: Also, doesn't close a bug, I think there are supposed to be some mozilla-plugin extras in debian/control (I may be wrong), no upstream in debian/copyright, preepv-doc would be a nifty package, and useless installation of all of NEWS, README, and TODO (0-byte files)
[16:09]  * persia postpones a proper review
[16:09] <raphink> hmpf
[16:10] <raphink> standards changed quite a bit since I was a reviewer
[16:10]  * raphink remembers when ITPs were only for Debian ;)
[16:10] <persia> Yes, the development of the needs-packaging bug :)
[16:11] <persia> Anyway, we got complaints from archive-admins about not being sufficiently critical about copyright, from Debian about not being sufficiently critical about policy, and from QA-type MOTU for not being sufficiently picky about package quality.
[16:11] <persia> So now it's rather stricter.
[16:12] <ember> persia: mind giving a review on hamster-applet on revu?
[16:13] <persia> ember: For me, it's a bit late for a real review, but I'd be happy to give a glance.
[16:13] <raphink> persia: I can tell
[16:13] <ember> persia: thanks
[16:13] <k0p> RainCT, what do you think about my last diff? :)
[16:14] <raphink> persia: what about the mozilla-plugin extras ?
[16:14] <persia> raphink: I think there's some tag one is encouraged to add to the binary stanza in debian/control when interacting with mozilla, but I don't know the details (and I may be wrong).  You might check with the mozillateam
[16:15] <persia> (#ubuntu-mozillateam I think)
[16:15] <raphink> ok
[16:15] <persia> On the other hand, it's possible I'm sending you on a wild goose chase, in which case I apologise in advance.
[16:15] <raphink> as for the freepv-doc, there would be a need for something to put in there
[16:16] <raphink> the doc that would be required is man pages for the two commands
[16:16] <raphink> whch I plan to do
[16:16] <persia> raphink: Yes, it was the TODO: Manuals in debian/rules that encouraged me to advocate that :)
[16:16] <persia> Oh, man pages don't need a separate -doc app :)
[16:16] <RainCT> k0p: I just started looking at it.. testing installation now :)
[16:16] <raphink> persia: that's what I meant by the TODO
[16:16] <raphink> ;)
[16:17] <persia> Oh.  I presumed there were some manuals available in the source somewhere, and just weren't built by default.
[16:18] <raphink> persia: no, sadly
[16:18] <raphink> not even a --help
[16:18] <raphink> but well, there's no options either ;)
[16:18] <persia> ember: Remember to reference each license from common licenses with a link when it is used in debian/copyright
[16:18] <k0p> RainCT, ok :)
[16:19] <persia> Trivial manpage to write then :)
[16:19] <ember> persia: right, thanks
[16:20] <persia> ember: Why debhelper 7 when you're using CDBS?  Especially so when you're not depending on a version of CDBS that requires debhelper 7?
[16:21] <ember> hmm that must have been dh_make who create that
[16:21] <persia> In the watch file, don't you want to also capture [02468] as part of the version number?
[16:22] <persia> (and I don't really see the point of "debian uupdate, but there's no special reason to omit it)
[16:23] <ember> persia: it's useful, i used it a lot with other gnome- stuff
[16:23] <persia> I also thought that you needed to define DEB_PYTHON_SYSTEM when using CDBS for python packaging.
[16:24] <ember> i didn't know about that, RainCT point me
[16:25] <persia> http://wiki.debian.org/DebianPython/NewPolicy
[16:25] <persia> That's all I see from a quick glance, but as I said, it's not a proper review.
[16:26] <ember> You will have to set DEB_PYTHON_SYSTEM to "pycentral" or "pysupport" before the CDBS include directives.
[16:26] <RainCT> persia: DEB_PYTHON_SYSTEM is only necessary if you use python-distutils.mk, but ember is calling dh_pycentral directly
[16:27] <ember> yap only with python-distutils.mk
[16:27] <RainCT> ember: does the application have a setup.py?
[16:27] <ember> RainCT: no
[16:27] <RainCT> ok, then you're doing it right (afaik) :)
[16:29] <persia> RainCT: Thanks for the correction.
[16:29] <persia> ember: I really don't know much about python packaging: for python, it's usually best to assume I may be mistaken if you've previously heard otherwise.
[16:29] <RainCT> k0p: I'm happy with everything except the .desktop and menu files :P
[16:30] <ember> persia: i don't much either, about the python part of hamster i was looking as example the deskbar-applet package
[16:30] <RainCT> k0p: first, I'm not sure wheter it really makes sense to have the entry in Network/Communications (for Debian) - at least, I'd never look there for a network scanner :P; just Network is probably better
[16:32] <slytherin> ember: have you looked at their packaging>?
[16:32] <slytherin> ember: I mean the packaging that hamster upstream provides.
[16:32] <RainCT> k0p: and then there's that root issue.. do you know if upstream is working on improving that (eg, using policykit or whatever)? if they are it's OK for me to have two entries, but I'd also add an "(as root)" entry to debian/menu
[16:32] <ember> slytherin: yes
[16:33] <k0p> RainCT, hmm
[16:33] <RainCT> ScottK: Thanks for looking at Julius :). Is that one with the description the only problem that you found?
[16:34] <ScottK> RainCT: I only took a glance at the diff.  That's all I found with that level of review.
[16:34] <k0p> RainCT, about desktop files
[16:34] <k0p> ok I'll change section.
[16:35] <k0p> RainCT, what is about policykit?
[16:35] <slytherin> persia: can you verify and ack bug 251973?
[16:36] <k0p> RainCT, i'm reading. no way.
[16:37] <k0p> RainCT, it doesn't working on policykit yet
[16:37] <k0p> RainCT, how I add another entry in debian/menu?
[16:37] <RainCT> k0p: if upstream is going to change the application so that it won't be necessary to run it as root anymore somewhen soon, because if they won't I think the best would be (IMHO) to patch the "non root user" dialog to add a "Run as root" button and have just one menu entry
[16:38] <RainCT> k0p: just duplicate the text in it, I think
[16:39] <k0p> RainCT, some scans could be done without root previligiues.
[16:39] <persia> slytherin: Do you need it night now, or can it wait 7-8 hours?
[16:39] <slytherin> persia: can wait.
[16:39] <k0p> RainCT, so we can't patch the dialog.
[16:39] <persia> slytherin: On the RSN list then
[16:39] <k0p> RainCT, we need to accept both options.
[16:39] <RainCT> k0p: of course we can: [Run as root] [Continue as $user]
[16:39] <k0p> oh.
[16:39] <k0p> but how I do (Run as root) ?
[16:39] <RainCT> k0p: as buttons on the dialog. but nevermind, I won't complain unless someone other does
[16:40] <k0p> RainCT, wait.
[16:40] <RainCT> k0p: python-gnome2-extras
[16:40] <k0p> I want undertand, if we can do that
[16:40] <RainCT> k0p: has pygtk2.sudo
[16:40] <k0p> soren, another depedencies?
[16:41] <RainCT> so you can do something like:   import pygtk2; pygtk2.sudo('umit'); sys.exit(0)
[16:41] <k0p> hmm
[16:42] <k0p> in the dialog?
[16:42] <k0p> RainCT, I like idea.
[16:42] <RainCT> k0p: :). Do you know Python?
[16:42] <k0p> yeap
[16:43] <k0p> but I don't know about sudo.
[16:43] <soren> k0p: Huh?
[16:43] <k0p> RainCT, So can you wait some minutes?
[16:43] <k0p> pygtk2.sudo*
[16:43] <k0p> sorry
[16:43] <k0p> I don't know about pygtk2.sudo.
[16:43] <k0p> I dind't*
[16:43] <RainCT> k0p: you can test it in an interactive session
[16:43] <k0p> my english is so bad. :\
[16:43] <slytherin> Shouldn't a url of this form https://bugs.edge.launchpad.net/ubuntu/intrepid/+source/electric redirect to https://bugs.edge.launchpad.net/ubuntu/+source/electric. First url shows no bugs while the second one does.
[16:44] <k0p> RainCT, I'm hacking :D
[16:44] <k0p> btw if how verify if I have UID = 0?
[16:44] <k0p> ok
[16:44] <k0p> I'll see in the code
[16:44] <k0p> :D
[16:44] <ember> persia: thanks for the quick review, i've fixed the issues you mentions, but i'm leaving the watch file with uupdate.
[16:44] <RainCT> k0p: if you have, the dialog won't be shown
[16:44] <k0p> hmm I don't need it lol.
[16:44] <k0p> RainCT, I'll patch dialog.
[16:44] <k0p> and put two buttons
[16:45] <k0p> RainCT, sounds nice for you?
[16:45] <RainCT> k0p: yeah; that's what I was suggesting :)
[16:45] <k0p> give me some minutes. :D
[16:47] <ember> RainCT: when you're done with k0p and still have time take another look at hamster-applet.
[16:48] <k0p> ember, oh my friend :D
[16:48] <ember> heh.
[16:48] <k0p> i'll hack in the while.
[16:52] <RainCT> ember: uscan warning: In watchfile debian/watch, reading webpage http://ftp.gnome.org/pub/GNOME/sources/hamster-applet/1/ failed: 404 Not Found
[16:52] <RainCT> ember: full message http://paste.ubuntu.com/35113/plain/
[16:53] <ember> RainCT: that's because of odd numbers, its misses the number 3 for 2.23 development releases as hamster just got into gnome and the only release is 2.23
[16:55] <RainCT> ember: ah. afaik you can't use wildcards/regex in the URL (only for the filename)
[16:57] <RainCT> ember: btw, I've just seen that there's an ITP for it, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=477972   are you in contact with Tim?
[17:00] <ember> RainCT: sorry. Most of gnome package uses that scheme of regex
[17:00] <ember> to retrieve only stable updates and etc
[17:07] <RainCT> ember: what I mean is that the watch file won't work if there's a regex in the URL, except for the filename (ie, downloadsite.com/(?:[0-9]+)/file-(.*)\.tar\.gz won't work; you have to use something like project.site.com/download.php download.site.com/(?:[0-9]+)/file-(.*)\.tar\,.gz instead)
[17:07] <RainCT> (unless I'm missing something)
[17:08] <RainCT> anyway, I'm away now. cya
[17:08] <persia> Actually, both formats work if directory display is enabled.
[17:09] <RainCT> really? that's nice :)
[17:09] <ember> RainCT: work, that one isn't working because of the missing 3. You can take as example many of other gnome packages
[17:09] <k0p> RainCT, later you review my package?
[17:09] <RainCT> k0p: yep
[17:10] <ember> libbonoui as example
[17:10] <ember> vte etc etc.
[17:11] <k0p> RainCT, can I put a awser dialog?
[17:11] <k0p> Do you want run as root or conitnue as user?
[17:11] <k0p> something like that
[17:11] <slytherin> LucidFox: around?
[17:11] <LucidFox> yes
[17:11] <RainCT> o, I didn't know that... I guess I can rewrite some of my watch files now
[17:11] <LucidFox> congratulations, by the way!
[17:12] <dpm> RainCT: in case you're still trying to do that, I've answered your question regarding the gmo files
[17:13] <RainCT> k0p: as long as it works and the buttons are "Runas  root" and something else (ie, not Yes/No), I'm happy
[17:13] <ember> RainCT: heh, try adding a 3 on the watch file and run uscan, i've fixed on the revu but as soon as it get into Debian it will be gone as Debian only do stable
[17:14] <k0p> RainCT, why not yes/no button? :S
[17:14] <RainCT> k0p: check the HIG :P
[17:15] <k0p> RainCT, hmm
[17:15] <k0p> RainCT, let me check STOCK buttons
[17:15] <slytherin> LucidFox: thanks. Can you please find some time for 'electric' upload?
[17:16] <RainCT> dpm: Where? Seems like I didn't get the answer
[17:16] <k0p> RainCT, so
[17:16] <k0p> RainCT, I can't use a dialog :/
[17:16] <LucidFox> let me check
[17:17] <k0p> I need make callbacks etc etc blah
[17:17] <tbielawa> hello everybody!
[17:17] <tbielawa> *hugs*
[17:18] <tuxmaniac> tbielawa:
[17:18] <dpm> RainCT: on PM, but you are currently marked as absent there. Can you join #softcatala? I guess it'll be easier there
[17:19] <RainCT> dpm: For some reason I can't connect to irc.gimp.org :/
[17:22] <tuxmaniac> dholbach: that was quick :-)
[17:22] <dholbach> :)
[17:28] <k0p> RainCT, need gtk.STOCK icons too the buttons? :S
[17:30] <SolarWar> i have a package that has two advocates, but would like to make a minor change to the control file (add the homepage)- would i need two advocates again?
[17:30] <SolarWar> after imake the change/
[17:34] <slayton> when building a deb can you make it trigger a restart after installation? if so how?
[17:37] <k0p> RainCT, pygtk2.sudo don't exists :S
[17:40] <LucidFox> slytherin> I can't find electric on REVU
[17:40] <LucidFox> is it somewhere else? (sorry for a stupid question)
[17:40] <slytherin> LucidFox: It is upgrade. Let me find the bug.
[17:40] <LucidFox> Off topic: http://www.leftmind.net/random/linuxbloat.jpg
[17:43] <slytherin> LucidFox: bug 242720
[17:44] <LucidFox> Okay, looking
[17:44] <tuxmaniac> slytherin: thanks for keeping in mind that bug :-)
[17:45] <slytherin> ﻿persia: there are too many java package failures on powerpc. Looks like some problem in default-jdk-builddep. The failures seem to be of sort - can not fine binary javac. Some problem with default-jdk-builddep.
[17:45] <LucidFox> slytherin> Why don't you add the LP: #xxx yourself?
[17:45] <LucidFox> just reupload the debdiff
[17:45] <LucidFox> * diff.gz
[17:47] <RainCT> k0p: it's in python-gnome2-extras
[17:47] <RainCT> k0p: and it's gksu2, not pygkt2
[17:47] <k0p> RainCT, hmm
[17:47] <k0p> hardy too?
[17:47] <k0p> oh!
[17:47] <RainCT> k0p: ^
[17:47] <k0p> lol
[17:47] <k0p> this make sense! :D
[17:47] <slytherin> LucidFox: have no time. :-(
[17:48] <LucidFox> Okay, I'll correct, although it's as simple as gunzipping the diff, correcting and gzipping it again :)
[17:50] <k0p> RainCT, it crash other application .. hmm it's weird
[17:50]  * sistpoty|work heads home... cya
[17:50] <slytherin> LucidFox: make sure you do thorough review. The app was using C previously now it is using java.
[17:51] <LucidFox> o_O
[17:51] <k0p> RainCT, done! :D
[17:51] <LucidFox> greeeeeeeeat....
[17:51] <LucidFox> ...and the 14MB jar is downloading...
[17:52]  * k0p patching!
[17:54] <NCommander> hey RainCT
[18:05] <k0p> RainCT, there?
[18:15] <LucidFox> slytherin> commented on electric
[18:15] <slytherin> LucidFox: checking, but don't expect any activity for next 2 days.
[18:17] <k0p> RainCT, can you review now?
[18:18] <slytherin> LucidFox: that is lot of comments. Will work on weekend.
[18:19] <RainCT> k0p: yep
[18:19] <k0p> RainCT, I put a dialog, remove root desktop, and add depends.
[18:19] <k0p> and fix section on menu
[18:23] <slytherin> LucidFox: What is java-wrappers?
[18:24] <LucidFox> http://launchpad.net/ubuntu/+source/java-wrappers
[18:37] <RainCT> k0p: awesome :D
[18:39] <k0p> RainCT, really?
[18:39] <RainCT> k0p: adovcated and commented with a last complaint :P
[18:40] <k0p> RainCT, can you complaint before? :P
[18:41] <k0p> thanks dude :)
[18:41] <k0p> RainCT, btw do you think that can reject package?
[18:41] <k0p> DktrKranz, there?
[18:41] <DktrKranz> k0p, dinner time now, I'll catch it later ;)
[18:42] <k0p> DktrKranz, you need advocate again later .. sorry dude :\
[18:42] <k0p> it's 3th time .. but I need it.
[18:42] <k0p> bon-apetit DktrKranz :)
[18:43] <directhex> is "(Closes: #494123, LP:255683)" the correct structure for bi-dist Closes: ?
[18:43] <sebner> directhex: LP: #blabla
[18:45] <directhex> sebner, "LP #blabla" definitely won't get parsed by debian's infrastructure? i thought "#blabla" would be
[18:46] <RainCT> k0p: I'm not sure
[18:46] <RainCT> directhex: is the bug on Launchpad or on bugs.debian.org?
[18:46] <directhex> RainCT, both!
[18:47] <RainCT> directhex: if the upload is for Ubuntu only include the LP bug number then
[18:47] <RainCT> directhex: that's documented somewhere on the wiki
[18:48] <k0p> RainCT, what?
[18:48] <RainCT> k0p: you asked if that can cause a rejection
[18:49] <k0p> oh sure.
[18:49] <k0p> RainCT, what do you advise me?
[18:50] <RainCT> k0p: to fix that :P
[18:50] <k0p> ok
[18:50] <k0p> RainCT, do you will adovcate me again, right?
[18:50] <k0p> ever same story...
[18:50] <RainCT> k0p: sure
[18:50] <RainCT> lol
[18:50] <k0p> I gain one. I lost ..
[18:50] <k0p> I'll nver get 2
[18:50] <k0p> lol
[18:51] <k0p> RainCT, do you know some package to see python licence? I see a package that have all python licence in debian.
[18:51] <k0p> so I copy the licence from there.
[18:53] <RainCT> k0p: in msgfmt.py
[18:53] <RainCT> k0p: just copy the licence from there
[18:53] <k0p> RainCT, sure.
[18:53] <k0p> give me a second.
[18:58] <k0p> RainCT, uploading.
[19:07] <k0p> RainCT, can you advocate again?
[19:08] <RainCT> k0p: done
[19:09] <k0p> RainCT, thanks
[19:09] <k0p> :)
[19:17] <Kopfgeldjaeger> DktrKranz: got some time today? ;) (sorry for bothering you)
[19:18] <dx9s_work> I just added some info to launchpad.net about HOW a patch (that is available in Hardy) is breaking (or better said, crippling) suPHP -> https://bugs.launchpad.net/ubuntu/+source/suphp/+bug/253268
[19:19] <DktrKranz> Kopfgeldjaeger, some ;)
[19:19] <k0p> DktrKranz, do you will review my package? :)
[19:20] <DktrKranz> k0p, work in progress ;)
[19:20] <k0p> :D:D
[19:20] <k0p> tks :)
[19:20] <Kopfgeldjaeger> I updated gtkhash and now have got one advocate (norsetto). One left ;d
[19:21] <DktrKranz> Kopfgeldjaeger, so... pretty ready already ;)
[19:22] <Kopfgeldjaeger> yeah :)
[19:30] <fabrice_sp> Hi.  apachelogger is getting this warning " manpage-has-bad-whatis-entry usr/share/man/man1/mm.1.gz " when building mountmanager package (http://revu.ubuntuwire.com/details.py?package=mountmanager). But I am not able to get this error. Can someone try to build it and see if he gets this error? Thanks!
[19:31] <Caesar> Hi, I was wondering if I could get sponsorship for #255819 please?
[19:35] <Laney> Caesar: Is it fixed in intrepid?
[19:36] <DktrKranz> bug 255819
[19:38] <DktrKranz> rm -rf / ???  OMG!
[19:39] <k0p> :o
[19:40] <DktrKranz> k0p, 2nd advocation \o/
[19:40] <k0p> finally :D
[19:40] <k0p> DktrKranz, so what I need to do now?
[19:41] <DktrKranz> k0p, nothing... I'll do next step myself
[19:41] <Laney> :O
[19:41] <k0p> DktrKranz, so umit will stay in intrepid?
[19:41] <k0p> or now it will to archives and will approve by others?
[19:41] <DktrKranz> probably
[19:41] <k0p> hmm
[19:42] <k0p> ok
[19:42] <DktrKranz> it will go through NEW queue waiting for archive-admin review
[19:42] <k0p> ok
[19:43] <DktrKranz> uploading
[19:43] <k0p> DktrKranz, so now I can't do nothing more, right?
[19:44] <DktrKranz> k0p, you could do once in Intrepid
[19:44] <Laney> Nice one k0p
[19:44] <Laney> \o/
[19:45] <Laney> If anyone has time for a review, I've got http://revu.ubuntuwire.com/details.py?package=goocanvasmm up that needs eyes. It should be fairly simple, I hope...
[19:45] <DktrKranz> Kopfgeldjaeger, your turn :)
[19:46] <k0p> Laney, tks
[19:47] <k0p> DktrKranz, do once in Intrepid? what sorry?
[19:47] <Laney> k0p: More updates
[19:48] <DktrKranz> Caesar, did you already request a sync from unstable for slack?
[19:49] <k0p> Laney, like new packages?
[19:49] <Laney> k0p: No, changes to umit
[19:49] <k0p> oh sure.
[19:49] <Laney> As in, there's nothing to do now until it's in the archive
[19:49]  * Kopfgeldjaeger is too stupid to interpret DktrKranz' hint
[19:50] <k0p> DktrKranz, thanks for help dude :D
[19:51] <DktrKranz> k0p, just landed in NEW, now just wait
[19:51] <DktrKranz> Kopfgeldjaeger, I'll review soon... icecream now ;)
[19:51] <Kopfgeldjaeger> aah, ok ;d
[19:52] <Kopfgeldjaeger> Laney: some upstream authors have 2 spaces between their names and their mail adresses, some others only one (i know, very cosmetical ;p )
[19:52] <Laney> Kopfgeldjaeger: Hah, I grepped that from the news file
[19:52] <k0p> DktrKranz,:)
[19:52] <Laney> shall change
[19:54] <Kopfgeldjaeger> Laney: and I think the NEWS file should already be included automatically by cdbs (see debhelper.mk). Maybe you could use it as upstream changelog (DEB_INSTALL_CHANGELOGS_ALL)
[19:55] <Laney> Kopfgeldjaeger: Yeah, I had that line because otherwise all the other junk documentation gets installed automatically
[19:55] <Laney> Like the useless AUTHORS and README file
[19:56] <Kopfgeldjaeger> DEB_INSTALL_DOCS_ALL =(newline here) would empty the var
[19:56] <RainCT> fabrice_sp: are you running lintian against the .deb?
[19:56]  * Kopfgeldjaeger hopes that empty is also a verb
[19:56] <Kopfgeldjaeger> \o/
[19:56] <Laney> 'tis
[19:57] <fabrice_sp> RainCT: yes. I'm running version Lintian v1.24.1~hardy1
[19:57] <Laney> Kopfgeldjaeger: Would unset DEB_INSTALL_DOCS_ALL work?
[19:58] <Kopfgeldjaeger> I don't know
[19:58]  * Laney will try
[19:59] <Laney> Apparently not
[20:57]  * Laney shatters the silence
[20:57] <lukehasnoname> WTF
[20:59]  * ScottK prepares an indictment against lukehasnoname for the CoC violation of using a forbidden acronym.
[20:59] <laga> OMGBBQ
[21:00] <ScottK> lukehasnoname: Kidding about the indictment, but that actual acronym did come up at the Community Council meeting this week.
[21:01] <laga> ScottK: were there any specific outcomes regarding this acronym?
[21:01] <DktrKranz> "do not use it on public channel", I guess ;)
[21:02] <ScottK> I think it was don't aim it at anyone.
[21:02]  * Laney is aggrieved
[21:02] <lukehasnoname> WTF is so widespread in online banter, and one great thing about acronyms is their ambiguity. What the flip?
[21:02] <ScottK> Hey, I don't make this stuff up.
[21:03] <ScottK> Actually I think that usage is permitted.
[21:03] <laga> yeah, i'd be like WTF if it wasn't.
[21:03] <ScottK> I think it's more like "WTF are you doing you blooming idiot.  Go RTFM and don't come back." that they didn't like.
[21:04] <ScottK> RTFM is, BTW, explicitly not OK.
[21:04] <crimsun> surely in context.
[21:04] <lukehasnoname> right, thats for me
[21:04] <ScottK> I'm not sure what people have against reading fine manuals, but that's just me.
[21:04] <laga> "read the fine manual" is not OK? well, here's my phone number. call me any time and i'll read it to you.
[21:04] <ScottK> ;-)
[21:05] <lukehasnoname> so I'm going to download and install Debian in a few weeks to see how things work on their end, so I can see how much Ubuntu changes it.
[21:05] <DktrKranz> ah... F stands for Fine? ;)
[21:05] <lukehasnoname> Then I'm going to download Solaris 10 and see how a REAL OS works :p
[21:05] <Laney> or fascinating
[21:06] <laga> i don't like that attitude :(
[21:06] <ScottK> DktrKranz: As long as you can't prove it doesn't.
[21:06]  * NCommander loves Solaris, but Linux has better tools ATM for general users
[21:08] <lukehasnoname> NCommander: I actually haven't used Osol, but I've heard good things. And my *nix experience started with FreeBSD, so I have a fondness for the way they do things.
[21:08] <NCommander> lukehasnoname, I got started back with FreeBSD 2.2.2 back in the day
[21:09] <NCommander> Still have my CD and printed manuals
[21:09] <lukehasnoname> o_O I started with FreeBSD 6.1 and Ubuntu 6.10 and FC4
[21:09]  * NCommander remembers compiling his kernel to get PPP support so he could use CompuServe's GO PPPCONNECT
[21:09] <NCommander> I was ... six or seven back then
[21:10] <NCommander> Then I ran OS/2
[21:11] <gastoni> If I delete all the files that a .deb installed by hand, would that cause problems in dpkg?
[21:12] <Laney> yes
[21:14] <gastoni> so how do I remove a bad .deb, if dpkg is not able of removing it?
[21:15] <norsetto> gastoni: what bad deb?
[21:16] <gastoni> one that I made and that I tested :-S
[21:16] <norsetto> NCommander: any idea why http://revu.ubuntuwire.com/details.py?package=tktreectrl doesn't show as a "need work" !?
[21:16] <norsetto> gastoni: what is the error?
[21:16] <NCommander> norsetto, you aren't an MOTU in the eyes of the system
[21:17] <NCommander> norsetto, did you merge your accounts?
[21:17] <norsetto> NCommander: thats not me, its pitti, I guess he didn't do that
[21:17] <NCommander> oh
[21:17] <NCommander> Tell him to merge accounts
[21:17] <NCommander> Or bug a REVU admin to mark him a Reviewer
[21:18]  * norsetto thinks that a system that doesn't recognise pitti as a MOTU should be shot (twice) ;-)
[21:18] <NCommander> User error
[21:18] <NCommander> You need to merge with your former life to become an MOTU
[21:18] <sebner> norsetto: why? pitti can't be motu! he is motu god :P
[21:18] <NCommander> Without merging, it just a weak halflife
[21:19] <gastoni> norsetto: the problem is that I added to the "postinst" and "prerm" scripts this command: update-menus
[21:19] <norsetto> sebner: are you part of the pitti fun club?
[21:19] <gastoni> norsetto: the system for some reason doesn't have that command, so it can't uninstall it.
[21:19] <sebner> norsetto: hm ^^ dunno. I'm fan of every motu/archive admin
[21:20]  * NCommander has no fans ;.;
[21:20]  * jpds hugs sebner.
[21:20]  * sebner hugs jpds back :)
[21:20] <Laney> \o/ NCommander \o/
[21:20]  * Laney does a one-man mexican wave
[21:20] <sebner> NCommander: become a motu :P
[21:20] <NCommander> sebner, I want to be one, but I don't think I've been around enough to survive the process
[21:21] <norsetto> gastoni: just install menu then
[21:21] <sebner> NCommander: don't worry ^^ I'm also no motu
[21:21] <norsetto> gastoni: usually, one would use a test construct (or dh_installmenu) to avoid exactly these kind of problems
[21:22] <norsetto> gastoni: for instance: if [ -x "`which update-menus 2>/dev/null`" ]; then update-menus ; fi
[21:23] <gastoni> oooh, thanks for the tip
[21:24] <norsetto> gastoni: np, if you want to avoid installing menu, you can edit the postinst/prerm which are already installed in your system
[21:28] <gastoni> norsetto: where do I find them?
[21:29] <Laney> gastoni: /var/lib/dpkg/info
[21:31] <gastoni> Great, found them. Thank you norsetto and Laney
[21:32] <Laney> Welcome
[21:32] <ffm|sh> How hard would it be for https://bugs.edge.launchpad.net/ubuntu/+source/sugar-toolkit/+bug/255850 to occur?
[21:33] <Laney> ffm|sh: Why did you subscribe the sponsors? There's nothing to sponsor
[21:34] <ffm|sh> Laney: I'm assuming they need to make the change, right?
[21:34] <ffm|sh> Laney: alternitively, I could make a sync request, right?
[21:34] <Laney> I guess it would be a sync+removal request (two separate ones).
[21:35] <Laney> You'd need to test the new package works and everything though
[21:38] <Laney> DktrKranz: Can I bug you for a review? I believe you indicated you'd do one earlier...
[21:40] <DktrKranz> Laney, which package?
[21:40] <Laney> DktrKranz: http://revu.ubuntuwire.com/details.py?package=goocanvasmm
[21:41] <DktrKranz> Laney, queued, I'll probably have a look later... that "rm -fr /" stuff was bigger priority
[21:41] <Laney> Right, thanks in advance for your time!
[21:42] <Laney> 'tis difficult to get reviewers ;)
[21:42] <DktrKranz> Laney, 150 € per review, sebner is happy to pay the bill for everyone
[21:43] <sebner> DktrKranz: really? :
[21:44] <Laney> Now that's a way to contribute to Ubuntu :O
[21:45] <DktrKranz> sebner, I thought you will ;)
[21:46] <sebner> DktrKranz: :P
[21:46] <emgent> lol
[21:47] <sebner> DktrKranz: I don't even have enough money to pay my reviews :P
[21:47]  * Laney puts reviewers on the endangered species list
[21:47] <Laney> Adopt a reviewer for €10/month
[21:48] <DktrKranz> Laney, "will review for food"
[21:48] <ffm|sh> ffm@merlin:~$ requestsync -s -n -k 5649E681 python-sugar-toolkit intrepid
[21:48] <ffm|sh> curl: (7) couldn't connect to host
[21:48] <ffm|sh> python-sugar-toolkit doesn't appear to exist in Debian.
[21:48] <Laney> Will you send me a postcard once a year?
[21:48] <ffm|sh> Laney: Any idea why it'd be doing that?
[21:48] <ffm|sh> Laney: Cause the package exists.
[21:48] <Laney> The page you asked doesn't exist. However it looks like you were trying to look for `python-sugar-toolkit' binary package. The Package Tracking System is source based, therefore you should have looked for `sugar-toolkit'.
[21:48] <Laney> ffm|sh: ^
[21:49] <sebner> gn8 folks
[21:49] <Laney> ffm|sh: Have you tested it works?
[21:50] <Laney> nn sebner
[21:50] <ffm|sh> Laney: ah.
[21:56] <Caesar> DktrKranz: I'm in the process of doing that now
[21:57] <ffm|sh> ffm@merlin:~$ requestsync -s -k 5649E681 sugar-toolkit intrepid
[21:57] <ffm|sh> curl: (7) couldn't connect to host
[21:57] <ffm|sh> sugar-toolkit doesn't appear to exist in Debian.
[21:57] <DktrKranz> Caesar, np... I already sponsored your version in hardy-proposed and requested the sync. Many thanks for the tip :)
[21:57] <ffm|sh> Laney: Still borked...
[21:57] <Caesar> DktrKranz: oh, okay, I won't request a sync then
[21:58] <Caesar> I tried using requestsync earlier, but it fails because rmadison fails because qa.debian.org is down
[21:58] <RoAkSoAx> heya guys, got a question, when requesting an update of a package for a new upstream release, should it be suscribed to u-u-s for example?
[21:58] <jpds> ffm|sh: Several Debian machines are down thanks to a subnet ourage.
[21:58] <Laney> RoAkSoAx: Yes, *after* the fix is uploaded to the beug
[21:58] <Laney> (.diff.gz in this case)
[21:58] <ffm|sh> jpds: Ah.
[21:58] <DktrKranz> Caesar, I had similar issues, so I filed a sync request by hand. BTW, do you plan to ask a freeze exception soon for Lenny?
[21:58] <ffm|sh> In other news, is it easy/hard to do debian package development on an ubuntu system?
[21:59] <directhex> ffm|sh, learn about schroot
[21:59] <Caesar> DktrKranz: already done, and its been accepted
[21:59] <directhex> ffm|sh, and using more than one base.tgz in pbuilder
[21:59] <DktrKranz> cool
[21:59] <RoAkSoAx> Laney, so for example, should i suscribe this:  https://bugs.launchpad.net/ubuntu/+source/event-rpc/+bug/255853 ??
[21:59] <directhex> ffm|sh, i've done debian packages on ubuntu before. typically, make it for intrepid, then clean up ubuntisms
[22:00] <Laney> RoAkSoAx: Yes, if you want it to be sponsored
[22:00] <RoAkSoAx> Laney, ok cool thanks :)
[22:01] <Laney> ffm|sh: There usually aren't that many problems porting, hence why we can sync the bulk of our packages. But you should still test on a real Debian installation (VM is fine) to be sure.
[22:01] <Laney> (or schroot/whatever for console apps)
[22:13] <apachelogger> fabrice_sp: run lintiang on the debfile
[22:17] <fabrice_sp> apachelogger: I can find lintiang. How can I install it?
[22:18] <apachelogger> apt-get install lintian ;-)
[22:18] <fabrice_sp> o sea que es lintian y no lintiang :-)
[22:19] <jpds> fabrice_sp: La verdad es que... no.
[22:19] <fabrice_sp> Sorry for the spanish. to many chats...
[22:20] <fabrice_sp> apachelogger: I ran lintian on the deb, and I did'nt get this error (only empty directories)
[22:21] <apachelogger> hm
[22:21] <apachelogger> maybe it's intrepid lintian only
[22:23] <fabrice_sp> the version of lintian in intrepid is 1.24.2. I'm using 1.24.1, so I have to update my version. I'll try with newer one. Thanks
[22:35] <fabrice_sp> apachelogger: Tried with lintian 1.24.2, and I don't get this error in mm.1 manpage....
[22:42] <DktrKranz> Kopfgeldjaeger, advocated
[22:43] <Kopfgeldjaeger> thanks a bunch :)
[22:43] <DktrKranz> on its way to NEW...
[22:44] <Laney> yahoo
[22:44] <Laney> !
[22:45] <DktrKranz> done... Laney, your turn now ;(
[22:45] <DktrKranz> erm.... ;)
[22:46] <Laney> DktrKranz: Hooray! You're a sponsoring star you know
[22:46] <DktrKranz> not really...
[22:47] <DktrKranz> mh, gnome-panel is definitely buggy tonight...
[22:47] <Laney> Sure you are, anyone who takes the time to do reviews deserves recognition for it
[22:48] <DktrKranz> I try to be useful for someone, that's enough
[22:49] <RainCT> DktrKranz: Can you have a look at http://revu.ubuntuwire.com/details.py?package=julius while you are at it? (After Laney, of course) :)
[22:49] <DktrKranz> what time is it? gnome-clock is buggy too...
[22:50] <Laney> 22.50 BST
[22:50] <DktrKranz> it can't be 21:56 CEST!
[22:50] <jpds> Thu Aug  7 22:50:29 BST 2008
[22:50] <DktrKranz> what the ...
[22:51] <DktrKranz> 23:50 cest, and it says 21:56 ?!?!?
[22:51] <jpds> DktrKranz: Use NTP.
[22:52] <DktrKranz> I use it!
[22:52] <jpds> DktrKranz: local server to update / manual ntpdate?
[22:52] <huats> hey everyone
[22:52] <huats> I have one question
[22:53] <huats> I am trying for the first  time to use pbuilder hooks...
[22:53] <tbielawa> hello
[22:53] <huats> does anyone can help me a bit ?
[22:53] <DktrKranz> jpds, I'll try to switch to a different server, this one in Turin seems broken, or doesn't like latest GNOME
[22:53] <huats> I am trying to run the B01debuildtest from revu-tools...
[22:53] <tbielawa> huats, have you don't any searching online about them or are you having trouble working with them?
[22:54] <jpds> DktrKranz: http://www.pool.ntp.org/zone/it
[22:54] <huats> tbielawa: I have done some searching but couldn't find  any interesting stuffs (from my point of view of someone who don't know to use it)
[22:55] <tbielawa> huats, what happens when you run B01debuildtest? what were you expecting to happen?
[22:57] <k0p> DktrKranz, when a packaged is archived is no way to make anothers fixes?
[22:58] <huats> tbielawa: the thing is I don't know how to use it :)
[22:58] <Laney> I think it'll unarchive if you upload another revision k0p
[22:58] <Laney> But you can't make any more changes to umit now until it's in the archive.....!
[22:58] <Laney> (at least, not easily)
[22:59] <k0p> Laney, after it in archive, can I change a little?
[22:59] <DktrKranz> k0p, better wait and fix directly in Intrepid
[22:59] <k0p> or its finally ?
[22:59] <Laney> You can file bugs and attach debdiffs for whatever you want after then
[22:59] <Laney> just like any other package
[22:59] <RainCT> Laney: for changes in umit you've to wait until it passes new and then create a bug report, attach a debdiff to it and subscribe ubuntu-universe-sponsors
[22:59] <RainCT> bah :P
[22:59] <Laney> haha
[22:59] <k0p> sure
[23:00]  * RainCT goes back to break REVU ;)
[23:00] <Laney> RainCT: Not until I've had my review damn it!
[23:00] <k0p> So now wait, after that I can public fixes on Interpid right?
[23:00] <Laney> k0p: After then it's just like any other package
[23:00] <DktrKranz> RainCT, wait! I'll grab Laney's package first!
[23:00] <RainCT> DktrKranz, Laney: don't worry, I've to break it locally first :P
[23:01] <k0p> Laney, sure :D
[23:01] <k0p> thanks for the help :)
[23:01] <DktrKranz> RainCT, naaaaaah... broke it on production
[23:01] <tbielawa> huats, have you tried anything? I haven't used it's hooks too extensively but I imagine that using the --hooksdir option and having the B01debuildtest in the folder you point to should be a start
[23:01]  * Laney slaps launchpad
[23:01] <tbielawa> huats, try that and then put the result in the pastebin if anything happens or doesn't happen
[23:01] <Laney> Why can't I find the queues :(
[23:02] <DktrKranz> Laney, which one?
[23:02] <Laney> DktrKranz: I'm looking for hardy-proposed, but I'd like to be able to find them in general
[23:02] <huats> tbielawa: that is what I tryed
[23:03] <DktrKranz> Laney, https://edge.launchpad.net/ubuntu/hardy/+queue?queue_state=1&queue_text=
[23:03] <huats> but the thing is that I don't know if it is called...
[23:03] <huats> that is what I want to be sure...
[23:03] <Laney> DktrKranz: That's the one, but where is the link to it?
[23:03] <jfcgauss1> how can i get a maintainer to package wesnoth 1.4.4 (right now we have 1.4) ? :)
[23:04] <DktrKranz> Laney, launchpad.net/ubuntu, choose hardy, then choose "show uploads" on the right
[23:04] <Laney> jfcgauss1: File a bug for it and tag it "upgrade"
[23:04] <Laney> DktrKranz: Nice one, got it now
[23:05] <Laney> jfcgauss1: Actually you don't need to, we have bug #
[23:05] <Laney> bug #252287 which will get it already (sorry for the enter)
[23:06] <Laney> Hey, why didn't he get that sync request ACKed?
[23:06] <Laney> tsk tsk...
[23:07] <tbielawa> huats, you'll need to find the script you want to be executed and give the path to it.
[23:07] <tbielawa> once you do that put the result in pastebin and send that to us
[23:10]  * NCommander wonders how he got into debugging dak ...
[23:11] <jfcgauss1> thx
[23:28] <DktrKranz> Laney, since it's a library, it will take me more time, I'll probably have a better look tomorrow
[23:28] <Laney> DktrKranz: OK, in your own time. I used the examples that came with it to verify that it was working properly, btw
[23:29] <DktrKranz> library has a strange naming, though
[23:29] <Laney> Lintian told me to name it that
[23:29] <Laney> i had libgoocanvasmm0 first
[23:29] <DktrKranz> O.T. shame on you, gnome-panel!
[23:29] <DktrKranz> strange SONAMEs then?
[23:29] <Laney> Must be
[23:31] <Laney> laney@chicken:~/dev/ubuntu/packaging/goocanvasmm/usr/lib$ objdump -x libgoocanvasmm-0.1.so.2 | grep SONAME SONAME      libgoocanvasmm-0.1.so.2
[23:31] <DktrKranz> bah...
[23:31] <DktrKranz> but that's how it should be named
[23:34] <Laney> So it's alright?
[23:35] <DktrKranz> package name is correct
[23:35] <Laney> \o/
[23:35]  * Laney bows down to lintian
[23:36] <DktrKranz> http://www.netfort.gr.jp/~dancer/column/libpkg-guide/libpkg-guide.html has some useful info to package libraries
[23:36] <Laney> Yeah, I used that page a bit
[23:40] <RainCT> http://rainct.homelinux.net/revu/uploads.py?user=rainct - suggestions?
[23:44] <Laney> RainCT: Can you add an anchor to each comment and link to it from that page?
[23:44] <Laney> package=pyclamd#commentX
[23:44] <k0p> RainCT, do you male revu website?
[23:44] <k0p> make*
[23:47] <RainCT> k0p: I'm one of the devs, yea. (siretart and sistpoty and NCommander are the other ones)
[23:47] <k0p> :)
[23:47] <RainCT> Laney: I'll do :)
[23:47] <NCommander> huh what?
[23:47] <k0p> nice
[23:48] <RainCT> NCommander: that you should finish the PPA Importer :P
[23:48] <NCommander> It's done
[23:48] <NCommander> I've just been lazy on merging it
[23:48] <RainCT> xD
[23:49] <NCommander> I have to merge the openid and mako branches into it :-/
[23:49] <RainCT> NCommander: right, that will be funny :)
[23:49] <NCommander> Might just be easier to rm -r that source and start again
[23:49] <NCommander> (considering I can do things now that I couldn't do before)
[23:50] <RainCT> it's your code..