[00:01] hello [00:01] spiv, jam, good morning [00:02] morning [00:03] hi poolie [00:03] hello beuno, lifeless [00:04] https://bugs.edge.launchpad.net/bzr/+bug/256409 [00:04] Launchpad bug 256409 in bzr "inconsistent delta with deleted directories" [Critical,Triaged] [00:04] I'm working on this [00:04] I think its quite serious, I'm trying to understand it enough to create a test and figure out if its just 1.3.1 or if 1.6 is affected too [00:05] so did jelmer ever wake up today? :) [00:06] I haven't seen him [00:06] jelmer won't be around for a bit [00:06] I've been expecting a [00:06] "w00t, bzr-upload and bzr-search are in Debian", but nothing [00:06] lifeless, is he OK? [00:06] beuno: yup all good [00:07] hey poolie, where's the call? [00:09] hi [00:09] i was waiting for you here [00:10] ah, sorry [00:10] I saw the hello [00:10] np [00:10] you usually just call without response :) === edcrypt1 is now known as edcrypt === edcrypt1 is now known as edcrypt [00:44] jam: youhave a reply - and thanks for reading my essay :/ [00:48] jam: I admired your ascii art. [00:51] hardly ascii [00:51] Well, yeah. === mw is now known as mw|out [00:53] back shortly === kiko is now known as kiko-zzz [01:29] hm [01:29] are 'location aliases' documented anywhere? [01:30] are what now? [01:32] things like :this [01:32] (which turned out to be the one i wanted) [02:14] mwhudson: no. I should do that. [02:15] lifeless: I thought bug 256409 was a solved problem! What's up with it? [02:15] Launchpad bug 256409 in bzr "inconsistent delta with deleted directories" [Critical,Triaged] https://launchpad.net/bugs/256409 [02:15] good evening i'm having problems chceking out the ubuntu-docs branch from #lp and getting this error: http://pastebin.ubuntu.com/36701 in regards to a KnitPackRepository error [02:15] abentley: I'm trying to reproduce at the moment [02:15] abentley: I'm leaning towards 'what I found and fixed has just been causing trouble for people' [02:15] abentley: but until I can trigger it with test code in 1.3.1, I can't check it against 1.6/1.7 either [02:16] abentley: its pretty scary regardless of whether its now-fixed or not, because 1.3.1 is widely spread [02:16] abentley: if you want to poke at it too that would be great [02:16] lifeless: Oh, I had this confused with something else. [02:17] lifeless: You remember we had a problem where file kinds weren't being properly updated by TreeTransform.apply()? [02:18] vaguely [02:18] this seems to be a cluster of problems - my note about what we need to do itemises them [02:47] beuno: thanks :) [02:48] emmajane, :) [02:48] beuno: is it not possible to have something on the launchpad page to that effect? [02:49] emmajane, the explanation itself? [02:49] I mean, I'm all about increasing karma points by asking easily answered questions, but... ;) [02:49] yeah [02:49] hahah [02:49] I agree. I haven't done so because vila should be back from his vacation any day now, and we should be able to wrap it up and release a tarball [02:49] that'd be fantastic. [02:50] I know it's going to be discussed at a BoF at the DrupalCon in two weeks. [02:50] so, that and a .deb will supersede the bzr co... [02:50] bzr-upload? [02:50] bzr generally. [02:50] ah, how cool! [02:50] please get us some feedback on whatever comes out of that [02:50] absolutely! [02:50] I'm just looking for the session description. [02:51] http://szeged2008.drupalcon.org/program/sessions/bzr-bazaar-source-revision-control-system [02:52] The workflows page in the documentation is excellent, btw. Not sure who wrote it but my full compliments go to them. [02:53] emmajane, that would be Ian Clatworthy, which I don't see around at the moment [02:53] he's done most of the docs [02:53] The Five Minute intro had a few leaps of logic that I wasn't able to make (I only know CVS and SVN...and basic skills at that) [02:53] emmajane, like? [02:54] This will expose my naivety. ;) [02:54] poolie: see my email on the list, the log performance slowdown is because of the VersionedFiles changes and how it changes how we get at the per-file graph. [02:54] good, that we wat we can learn [02:54] I proposed a "possible" fix. [02:54] jam, i just saw it [02:54] thankyou! [02:54] Though it probably needs some discussion with lifeless [02:54] beuno: the --push felt like it was the equivalent (mirror) of a checkout but in the opposite direction. This is not the case at all. [02:55] * beuno looks [02:55] an extra sentence which read, "This will upload only the .bzr directory." would have helped me immensely. [02:56] I think of a branch as being a set of files that I download to work on in CVS. [02:56] which is an incorrect interpretation of that word, if I've correctly understood the first little bitof the full intro. [02:57] emmajane, is this the part you are reffering to? http://doc.bazaar-vcs.org/latest/en/mini-tutorial/index.html#publishing-your-branch-with-sftp [02:57] hello emmajane [02:57] beuno: that's the part, yes. [02:58] * emmajane waves at poolie [02:58] emmajane, I see, it would make sense to explain that it only uploads the repository [02:59] as a side note, if you push locally, you actually do push the full working tree (the actual files) as well [02:59] but not if you're going over the 'net? [03:00] emmajane, not if it's something remote (sftp/ftp/ssh) [03:00] * emmajane nods [03:00] I think the five minute intro would also benefit from having a link to the workflow page. It seems as though the setups are different depending on what you want to set up (go figure). [03:00] emmajane, are you subscribed to our mailing list? [03:01] not at this point. [03:01] if you'd like to (it's fairly high traffic though), and maybe send in your views so we can discuss them, I can put together a patch to fix it [03:02] I can fix it anyway, it would just be more interesting if you could put it all together, and we can ping-pong with everyone else to see what else we can improve [03:02] I'd be happy to once I've actually figured out where I think the documentation is unclear. :) Sometimes it's just my fault that I'm skimming. :) [03:02] I'm keeping notes on what I'm doing to set up my environment though. [03:02] emmajane, that information is still intersting, because we can change things so they get cought while skimming too :) [03:03] heh [03:07] emmajane, yes if you send a mail with it all in one place that would be good [03:09] * emmajane nods. I'm keeping very careful notes at this piont, but I thought it would be better to get things running the way I want and then go back and evaluate my notes and the original documentation to see what would have really helped. [03:26] I'm getting a strange error when trying to branch from an smb mounted share with bzr.dev: "ERROR: Transport error: [Errno 12] Cannot allocate memory.../filename.rix". Is that a known problem? [03:27] markh: no [03:29] beuno: Actually, I wrote the workflows page, and Ian polished it. [03:29] its a little strange - a branch seemed to fail, but a checkout worked. Then I did "bzr up" on the checkout, annd it said it applied all (1) changes, *then* gave the error. [03:29] I'll look in the log once the test suite finishes [03:29] markh: we have another bug open with SMB shares [03:29] * markh decided he should try to test his patches on Linux ;) [03:30] abentley, my apologies then. emmajane ^ [03:30] And I forget who did the images. [03:30] abentley: The workflows page is /fantastic/ [03:30] emmajane: Glad you like. [03:32] markh: bug 255656 [03:32] Launchpad bug 255656 in bzr ""bzr: ERROR: [Errno 22] Invalid argument" when "bzr pack" is executed manually or when "autopack" is triggered on a repository located on a windows network share" [Undecided,New] https://launchpad.net/bugs/255656 [03:33] markh: my guess is there is a commonality of some sort [03:33] (beyond 'windows sucks') [03:34] :) [03:40] markh: if you could look into that it would be really good [03:56] mornin' all [03:57] evening Verterok [03:59] Hi beuno, g'evening [04:04] * beuno is off to bed [04:33] lifeless: File "/home/skip/src/bazaar/bzr.dev/bzrlib/osutils.py", line 598, in sha_file_by_name [04:33] f = os.open(fname, os.O_RDONLY | O_BINARY) [04:33] OSError: [Errno 12] Cannot allocate memory: '/home/skip/o/src/bazaar/bzr.work.tests.blackbox//bzrlib/bugtracker.py' [04:34] but immediately after that, Python can do a normal open(fname, "rb") on that file [04:34] maybe samba's just running out of file handles. [04:36] interesting [04:36] try a gc.collect() before that call ? [04:36] ok [04:39] seems to work! removing it again to make sure [04:39] so [04:39] I speculate its a HANDLE leak [04:39] we do a lot of readvs [04:39] probably the same one causing test suite failures all over windows :) [04:40] both LockContentions and warning messages about loads of test dirs being left behind [04:40] I can't make it fail again. Did bzr pack the remote branch? [04:41] it failed when it said "Finishing Pack" on the progress bar. Now it completes every time [04:44] hi jonnyde1 [04:55] hi lifeless :) [04:55] just got an email about your new bug comment message [04:56] I will try your suggestions when I'm back at work, today... [04:58] need to have my breakfast now and then go to work... best regards and many thanks for your help :) [05:03] bug 256409 [05:03] Launchpad bug 256409 in bzr "inconsistent delta with deleted directories" [Critical,Triaged] https://launchpad.net/bugs/256409 [05:33] morning [05:35] i'm advocating usage of LP to GNUmed project...how is it possible to report bugs via email? does one configures separate email-list (i did something similar with roundup) or something else? [05:35] https://help.launchpad.net/BugTrackerEmailInterface [05:36] thanks a lot [05:43] i'd like to be able to stick stuff on the end of location aliases [05:44] bzr push :parent/../other [05:48] mwhudson, that would be good [05:49] i guess it's even not that hard [05:49] just a bit more code in AliasDirectory.look_up [06:10] lifeless, i have a clue [06:10] yay! [06:10] alexander graham bells invention time? [06:15] poolie: whats your clue? [06:15] see mail [06:15] (phone) === mark1 is now known as markh [07:16] today is bazaar-1.6 release day? [07:33] gour: I don't think so [07:33] poolie: do you have a release day for 1.6 specified? [07:35] running "bzr upgrade" on a dirstate-tags branch prints a deprecation warning telling you that the branch is in ann old format and that you should run "bzr upgrade" ... [07:35] (that's with 1.6rc1) [07:36] hmm, someone told me the other day that something is gonna to be released today... [07:38] hrm - merge.py's do_merge takes 3 locks, then sets up a finally to release them all. Shouldn't there be a finally per lock? [07:40] jamesh: yeah, it's a known bug that "bzr upgrade" does that (it's not specific to this particular format transition). [07:41] markh: probably that would be more correct, although the risk of the two unlocks for the lock_reads failing is pretty slim. [07:41] I'm thinking the test suite as much as anything... [07:42] markh: so, gc.collect() worked ? [07:42] lifeless: yeah, I replied. After that though I can't repro it by taking it out. Is that because bzr would have packed the remote branch? [07:42] markh: packing occurs on write operations only [07:43] markh: you can check your bzr.log to see if a pack occured [07:43] and gc.collect() fixes failure to remove test directories in some cases, so I'm wondering if cases like that do_merge might be responsible... [07:46] so, we do have a high volume of file operations [07:46] is there some way to tell python to suck less? [07:47] so now I can't repro it again :( [07:48] hi lifeless, sorry, i don't remember what exactly i did back then :/ [07:48] robsta: ah hi [07:49] robsta: so, the branch is a bit of a mess, I've spent all day trying to figure out WTF happened [07:49] I'm probably your number #1 spammer in your INBOX as a result :) [07:49] lifeless: "bzr mv" i did , that's for sure [07:49] what was revno6 about by the way [07:50] you said 'repaired' ... [07:52] lifeless: i did something that broke my local repo, therefore cloned again and copied over changes [07:52] when you say broke [07:52] what do you mean [07:52] oh, a stale lock [07:52] oh [07:52] ok [07:52] 'bzr break-lock' [07:53] oh (: [07:53] we avoid os-locks for our core data - the don't work well on e.g. FTP :) [07:56] lifeless: so can i do anything apart from starting over in a new repo? [07:56] because we don't use os-locks, its possible to get stale locks, and thats what happend; probably you had some external event, or possibly triggered some actual assertion [07:56] robsta: I've written several test cases to try and reproduce and I have failed to date [07:57] robsta: can you attach your ~/.bzr.log* to the bug report [07:59] done [08:00] thanks, looking [08:03] I'm going to study this [08:04] until I can reproduce it its pretty hard to say how-long the piece of string is [08:04] I think yes, copy the whole tree, rm -rf .bzr, init and start over :( [08:04] I'm not happy about this advice [08:05] can i do something to fix the repo on gnome's bzr-playground too, or would that need manual intervention? [08:05] that will probably be fine if you do push --overwrite [08:06] it will have cruft that can be garbage collected but unreferenced data is not fetched [08:06] or propogated [08:06] oh, good [08:07] ok, interestingly you used mkdir cbd [08:07] I'm going to use this log to try to reproduce again [08:08] possibly i used "bzr mv" with wildcards a few times [08:13] Could someone do me a small favor and "bzr upgrade lp:~bzr/bzr-push-and-update/trunk"? It's still using knits. [08:16] beuno: ^ [08:21] Peng_: done. [08:22] jml: Thanks. :) [08:38] is there a simple howto for using bzr's api to controll workdirs? [08:38] theres some stuff on the wiki [08:38] (i need to rewrite pidas bzr integration, currently its a ugly hack with subprocess)) [08:39] robsta: good, news I seem to have reproduction [08:40] lifeless: it's easing my pain a bit to know the suffering was not in vein :P [08:40] lifeless, yay [08:40] robsta: I have duplicated the failure at revision 11 [08:41] robsta: I suspect the others will be dups, reflecting how you used the tool [08:42] lifeless: oh, what's triggering it? [08:42] robsta: I am reducing the size of test at the moment [08:42] robsta: still a lot of variables [08:56] damn [08:56] missed a change in my test, still can't reproduce [08:57] * lifeless tries real-old-fashioned reproduction [08:58] That's a wonderful out-of-context quote :) [09:04] RAOF: heh [09:04] robsta: have you been using the same bzr version the whole time ? [09:05] lifeless: think so, unless ubuntu changed it [09:05] that is, no dist upgrade [09:05] I'm tracking down LockContention on Windows and I don't understand how it is supposed to work. I've instrumented 'do_merge' and can prove that in some cases, self.this_tree._dirstate._filename == self.base_tree._dirstate._filename [09:06] markh: things like revert could do that [09:06] then that method takes a WriteLock on the lhs, and attempts a ReadLock on the rhs - the readlock fails - which seems to be correct. But it works on Linux (and the paths compare true there too) [09:07] markh: yes, oslocks are different on windows and linux [09:07] heh - no wonder then :) Is that by design? [09:08] ie, what do we do about the test failures? [09:08] markh, it's the documented behaviour of locks [09:08] no; see my mail to the list about a simple change to reduce the issues here [09:08] i would say we made a poor choice (in hindsight) to use them [09:08] so we just skip those tests on Windows? [09:09] (on phone to lifeless) [09:09] i think there is a 'known failure' for the fact that they're not exclusive on linux [09:10] i _think_ the general approach is meant to be that we should detect that they're the same object and handle that at a higher level [09:11] i don't have your context here [09:13] many tests on Windows are failing with a LockContention error - as the locks are exclusive on Windows. [09:14] so if Linux had exclusive locks, I guess all those tests would fail there too? [09:15] best I can tell, do_merge, in some cases at least, is taking a read and write lock on the same dirstate (and failing to take the read lock) [09:16] I hit 54 such cases [09:16] s/I/the test suite/ [09:20] heh - which is more than 1/2 the total remaining errors ;) [09:30] hi, I'm just starting to develop using Bazzar. I've been merging back and forwards between two branches. If I merge again I've just merged and committed when there's nothing to be done, it seems to create a "pending merge" in the destination. Am I doing something wrong? [09:32] i commited and pushed a change that contains a bad log entry; is there way to fix the log for that revision? should i uncommit my last revision and push it again? i've search in bazaar-vcs.org docs with no luck, so i'd appreciate some help or advise, whatever you like [09:32] Stumbles: no, its normal behaviour (though not very useful) [09:32] Stumbles: I plan to enahnce the 'nothing to do' check to catch that as well [09:32] alex_muntada: if you really care about it, uncommit and commit and push --overwrite [09:32] lifeless: so I should just `bzr revert` to back out of that? [09:33] Stumbles: yup [09:33] will he need to --forget-pending-merges too? [09:34] lifeless: it's not a typo and it could be misinterpreted, so thanks for the tip :-) [09:34] markh: no [09:36] robsta: so [09:36] * robsta perks up [09:36] robsta: I suspect something is going on that is outside the variables I can meaningfully choose to examine here [09:36] robsta: I'd like to ask you to do a few things for me, if I may [09:37] lifeless: cheers [09:37] Stumbles: happy to help [09:37] robsta: you're using a deb package right? [09:37] robsta: can you do dpkg -l bzr? [09:38] lifeless: yes and dpkg -l bzr [09:38] Desired=Unknown/Install/Remove/Purge/Hold [09:38] | Status=Not/Installed/Config-f/Unpacked/Failed-cfg/Half-inst/t-aWait/T-pend [09:38] |/ Err?=(none)/Hold/Reinst-required/X=both-problems (Status,Err: uppercase=bad) [09:38] ||/ Name Version Description [09:38] +++-=========================-=========================-================================================================== [09:38] ii bzr 1.3.1-1ubuntu0.1 easy to use distributed version control system [09:38] ok cool [09:39] I did grab that packages source and test with it myself to no avail [09:39] robsta: are you using NFS or anything other than a local filesystem (for the branch that glitched) [09:39] no [09:39] have any other branches done this sort of thing to you ? [09:40] no, this is my only bzr project ATM [09:40] ok [09:41] can you, in a terminal somewhere, run 'bzr selftest --noplugins' [09:41] bzr: ERROR: no such option: --noplugins [09:41] --no-plugins [09:41] this will take a bit of time [09:42] but if it fails in an unexpected manner it may help explain things [09:42] also, I'd like you to take a copy of the corrupt branch [09:42] and in that copy: [09:42] rm -rf .bzr/checkout [09:43] bzr branch -r 10 . ../FOO [09:43] cd ../FOO [09:44] bzr mkdir cbd [09:44] bzr mv ../src/css-border.c ../src/css-border.h . [09:44] (oh, cd cbd first :) [09:44] bzr mv ../src/css-color.h . [09:44] bzr mv ../src/css-gtk.c ../src/css-gtk.h . [09:44] bzr mv ../src/css.h . [09:44] bzr commit -m "test commands" [09:45] bzr check [09:45] (and post the output) [09:45] "bzr mv ../src/css-border.c ../src/css-border.h ." fails, the paths are wrong [09:45] yeah cd to cbd first [09:45] I forgot to mention that cause its not in .bzr.log ;) [09:46] lifeless: sorry, you even wrote it above [09:46] didn't read that far [09:46] thats ok :) [09:47] here goes [09:47] bzr check [09:47] checked branch file:///home/rstaudinger/Desktop/Devel/FOO/ format Bazaar Branch Format 6 (bzr 0.15) [09:47] checked repository format [09:47] 11 revisions [09:47] 32 file-ids [09:47] 64 unique file texts [09:47] 179 repeated file texts [09:47] 0 unreferenced text versions [09:49] one final check [09:49] cd .. [09:49] bzr branch -r 10 FOO BAR [09:49] cd BAR [09:49] bzr pull ../FOO [09:50] from "FOO/cbd" i need to "cd .." twice, right ? [09:50] just trying to make sure everything is exactly right [09:50] ah yeah [09:51] "All changes applied successfully. [09:51] Now on revision 11. [09:51] " [09:51] the self test is thru too [09:52] Ran 10755 tests in 511.042s [09:52] OK (known_failures=9) [09:52] 663 tests skipped [09:52] Missing feature 'FTPServer' skipped 76 tests. [09:52] Missing feature 'Internally performed glob expansion' skipped 5 tests. [09:52] Missing feature '_winreg' skipped 2 tests. [09:52] Missing feature 'case-insensitive filesystem' skipped 2 tests. [09:52] tests passed [09:52] ok [09:52] the good news, is that doing what you appear to have done previously, has worked [09:52] and there isn't anything obviously wrong system wide [09:53] what plugins do you have installed (bzr plugins) [09:53] bzr plugins [09:53] launchpad [09:53] Launchpad.net integration plugin for Bazaar. [09:53] svn 0.4.9 [09:53] Support for Subversion branches [09:53] yeah, fine [09:55] so the bad news then is that if this is representative of your system, bzr behaved correctly previously, so something must have caused the confusion subsequently [09:55] now you said you'd had a locking problem [09:55] has that happened more than once? [09:57] no, and it was my fault, closed the terminal while bzr was prompting for commit msg [09:57] heh [09:57] that works in svn [09:57] * robsta ducks [09:57] mmm, wonder what signal bzr got, perhaps it could handle it better [09:57] feel free to file a bug [09:59] not that important [09:59] Use vim, it ignored ctrl-c [09:59] It chastises you and makes you use :q! [10:01] awilkins: closing the terminal is a little harsher [10:01] robsta: still, be a nice bit of polish [10:01] robsta: I'll file it [10:01] done [10:01] awilkins: $EDITOR ignores it too, nano or whatever is default [10:02] now, the icing on the cake [10:02] is that there is only one missing key [10:02] the one for the new directory [10:09] lifeless: out of interest, have you ever regretted writing bzr in python? [10:09] for lack of compiler checks and whatnot [10:10] nope [10:10] compiler checks catch such a small number of genuine bugs [10:11] by which I mean code that would be syntactically correct, pass selftests but a compiler can tell you about [10:11] Hmm ; I find checked languages to be easier going in a good IDE [10:12] If nothing else the IDE usually helps you out more [10:12] lifeless: yeah, that was my next question; figured it might be an advantage being forced to write tests for just about everything [10:13] When I'm hacking bzr I am often stymied by what "interface" a given class is supposed to support (and where in the hierarchy it gets it from) [10:13] Hunting around in text files is the usualy result [10:13] awilkins: static analysis is reall quite orthogonal [10:13] awilkins: consider erlang for instance [10:13] or ocaml [10:14] I'm too tired to think right now ; was up all night installing Windows (a thousand curses to Dell for fiddly BIOSes that only boot USB with legacy support on) [10:15] And another thousand curses to IT beurocracies that insist on Windows-only full-disk encryption tools [10:15] awilkins: heh, ouch [10:15] And a small curse to my wife for giving in to them [10:15] awilkins: just install windows in a linux VM :) [10:15] I was all prepared to reinstall Ubuntu on dm-crypt partitions for her [10:16] robsta: I'll look at possible corruptors tomorrow [10:16] I could have left that running and gone to bed [10:16] robsta: I did find *one* code path that could cause it, but it doesn't look like it could possibly have been involved with the parameters you used [10:17] lifeless: well, thanks for the awesome support [10:17] uhm, i have a merge problem, i try to recouncile two divergeant branches [10:17] it tells me that i must precise a reivsion base, so i tell it which reivisions to apply [10:18] robsta: and I've sent a patch up for that which will be in trunk tomorrow [10:18] the merge occurs succesfully [10:18] then i try to push, but then, it tells me again that the branches diverge [10:18] robsta: this is the first seriously borked repository we've ever had that wasn't quite obviously a NFS FAIL or memory bit-errors or the like [10:18] robsta: so I'm taking it very seriously [10:23] No one for an idea ? :) [10:24] kiorky: are you sure they are diverged and not just completely unrelated? [10:24] lifeless: they are unreleated [10:25] lifeless: why i thought why something like that : i merge from the other branches, what is different [10:25] then i pushed back the changes [10:25] lifeless: thing is that i update my bzr-svn repo, more nicely, and i try to merge back a locally branched thign. [10:25] (that was done before i updated my "svn" branch" [10:26] lifeless: What i have suceed to do is to get the svn changes in the local branch. What is left is to push back things to the svn branch [10:26] lifeless: Am i clear ? :) [10:27] kiorky: I have no idea what you're talking about :) - I think my brain has melted, its been a long day [10:27] lifeless: hang on, i ll make a draw :p [10:27] spiv: are you around perchance? [10:30] lifeless: http://www.friendpaste.com/MH3aG9k2 [10:30] lifeless: is that more clear for you ? [10:31] kiorky: after you merge, you need to do a commit [10:31] because merge puts the result in a pending state [10:31] lifeless: i forgot in the pastebin [10:31] but its commited, of course [10:32] if you have done merge oldsvn; commit; then push oldsvn should just work [10:32] uhn, and stupid question, do you have a tip referrer like "head" or "tip" in bzr world ? [10:32] lifeless: nope [10:32] yes, -1 is the head of a branch [10:33] lifeless: http://www.friendpaste.com/5h5axg9V [10:33] lifeless: ok [10:33] 73 does not look like a merge to me [10:33] if it was a merge there would be merged revisions [10:34] what does bzr missing oldsvn show? [10:34] actually, I *have* to go [10:34] hopefully someone else can give you a hand [10:34] lifeless: just go :) [10:34] sorry [10:34] i hope, i just have to rumble the channel [10:34] *rumble* [10:35] lifeless: missing just make a lot of noise [10:35] lifeless: i ll try to merge thez others, so. [10:37] does any backup occur on 'bzr revert' ? [10:38] strk: nope, use $ bzr shelve if you need a backup [10:39] strk: yes [10:39] strk: bzr makes .name~X files [10:39] great [10:39] (just passing through again) [10:39] they change on 'bzr switch' right ? [10:39] * lifeless is really gone [11:41] beuno: With LH, does ?start_revid do anything useful on /annotate/ URLs? Particularly for Googlebot? (I don't think so, but I'm not sure.) [11:45] beuno: What about on /revision/? [11:45] Peng_: on revision at least it makes a difference [11:45] Oh, hi. [11:46] ISTM it causes start_revid to be appended to most of the URLs, and changes the Previous/Next links. [11:46] dang, i blew my cover [11:46] Peng_: yeah, that's about right [11:47] Peng_: by default loggerhead views the mainline of the branch [11:47] mwhudson: So...not useful? [11:47] Oh? [11:47] if you give it a start_revid, instead of mainline it views what you get by starting at the start_revid and repeatedly taking the left-hand parent [11:47] (which will converge with mainline sooner or later) [11:48] i'm not at all convinced this makes sense as an organizing principle of navigation [11:48] but i haven't really thought up anything clearly better yet [11:48] Well, does it lead to anything Googlebot would otherwise miss out on? [11:48] (i have thought up some stuff that would be mostly better) [11:48] er [11:49] probably not [11:49] * Peng_ feels very confident. :P [11:50] I've managed to whittle down most of the useless pages Googlebot finds, and start_revid is the only thing left. [11:51] well [11:51] can I convert a checkout to a branch? [11:51] Peng_: start_revid certainly doesn't affect the content of the page over much [11:51] markh: bzr unbind [11:51] Peng_: thanks! [11:51] :) [11:51] Peng_: there might be pages that are only linked to with start_revid= though [11:52] I know start_revid is useful on some pages (/changes), but I think it's added to a lot where it isn't. [11:52] hrm - "bzr: ERROR: Local branch is not bound" - its a light-weight branch - does that matter? [11:52] (Well, by "useful" I mean "useful to Googlebot". It usually does change the page in some way.) [11:53] i'm not going to dispute that [11:53] markh: reconfigure can probably do it [11:53] I'm just not sure which pages those are. :P [11:54] Peng_: ah right, it's added to non-/changes pages so that it can be preserved for links to /changes pages, is all [11:54] Peng_: this much i am actually fairly confident on [11:55] mwhudson: it could indeed - thx [11:56] I've ~ 95 commands staring me in the face with 'bzr help commands' :) [11:56] Hmm. [11:59] OK, it's definitely useless on /atom. [12:02] jelmer: i tried to update bzr-svn this morning, and it seems broken for me [12:03] jelmer: http://www.friendpaste.com/EYAgFfR4 [12:03] jelmer: http://foo is a svn repo. [12:12] jelmer: syncing my bzr.dev helped, sorry for the noise. [13:03] * beuno opens one eye and gets coffee [13:03] Good morning. [13:04] g'mornin Peng_ [13:04] how are you today? [13:04] Um, I'm fine. How are you? [13:05] I think I'm good too, but I should find more about that after the caffeine kicks in [13:05] Heh. [13:12] Here's one for you ; bzr rm complains about not wanting to delete files that you have already bzr mv'ed out of the folder [13:13] awilkins, makes sense in my pre-caffeinated state [13:13] maybe --force it? [13:13] Hmm, this is part of a merge. [13:13] I'm bzr mv-ing the files out of folder.moved to folder [13:14] The complaint is from bzr rm folder.moved [13:14] are you suppose to bzr mv things in .moved, or just plain mv them? [13:15] I think you have to bzr mv them ; "folder" is the new folder, folder.moved is still a owefwef [13:15] a part of the inventory [13:16] It seems to think that by deleting folder.moved (which is now empty of files) the files I have renamed to "folder" will be deleted [13:17] Which doesn't make sense to me [13:19] woohoo - both "failures" and "errors" are under 100 on windows :) [13:20] * beuno cheers markh [13:20] (skipped is now sadly above 12,900 and rising.....) :-P [13:22] What fixed the liargest proportion of those errors? [13:22] heh - skipped remains under 1000 :) [13:22] And is there a fix for the evil "Can't delete temp folder" problem? [13:22] closing file handles, changing out of the directory being removed, etc :) [13:22] yeah - all of them are gone :) [13:23] s/all/most/ ;) [13:23] I can't help thinknig that test framework support for that would be nice [13:23] how do I remove part of a pending merge from my working tree? [13:23] test framework has some support, but when a test explcitly makes a dir, then changes into it, then tries to remove it, there's not alot that can be done [13:23] the merge brought in two revisions, but I only want one [13:24] most of the remaining errors are LockContention errors, which apparently is known [13:25] Keybuk: bzr revert, bzr merge -rX..X+1 /merged/branch ? [13:25] gimaker`: I've already resolved the conflicts for the bit I want, and don't want to lose that [13:25] ah [13:26] can't you use shelve to store the conflict resolution you done, then do what I said and unshelve the fix? [13:26] is there a way to "fake merge" ? [13:26] ie. just bring in the merge reference without the diff? [13:27] Keybuk: merge thing; revert . [13:28] lifeless: great! thanks === _mathrick is now known as mathrick === thunderstruck is now known as gnomefreak [14:17] Does anyone know if there's any sort of plugin to allow you to do something like 'bzr resolve --other' which will resolve everything to the .OTHER files? [14:18] Patches are probably welcome. :P [14:21] yet another of the projects I need to do when I find the time to learn Python I guess :P [14:24] You could file a bug. [14:24] (There might already be one, of course.) [14:26] I'll have a look and file one if there isn't, might get it in quicker than waiting for me to have time to learn python ;) [14:26] :) [14:27] Any rebasing experts in here? I'm (still) struggling with trying to remove history at the beginning of a branch [14:31] hey [14:32] does anybody know of any OS X specific GUIs for bazaar? [14:37] mheld: yes and no [14:37] i know there's gtk-bzr [14:37] I'm the project lead on one but it's not even got to 0.1 yet [14:37] launchpad.net/bazaarx [14:37] but, i don't want to have to install mac ports on all of my computers [14:38] plus we're doing a major re-write of the core parts so it could be a while before we get to 0.1 [14:38] ah [14:38] hopefully within a month [14:50] hi, is there any bzr extension similar to mercurial's patch-queues (MQ) extension ? [14:50] bvk: bzr-loom, I belive (haven't used it myself yet) [14:51] gimaker`: ok, i will try it out :-) === mw|out is now known as mw [16:38] dumb question - if someone removed all revisions, is there a way to revert back on launchpad? [16:39] TheEric, removed al revisions? [16:39] removed from the branch, yah. [16:40] how? [16:40] no clue. [16:40] how do you know they are removed then? :) [16:40] "1264 revisions were removed from the branch." [16:41] that's from which command? [16:41] That's from an email I received. [16:41] Manfre : Heh. [16:41] from launchpad? [16:41] TheEric, ah, someone merged and pushed [16:41] TheEric, you can do push --overwrite [16:41] no, somebody did push --overwrite [16:42] ah, right, makes more sense [16:42] merge will never decrease the number of revisions [16:42] it might decrease the number of mainline revisions, but not the total number of revisions [16:42] TheEric: what is the branch? [16:42] right, well, LP only shows mainline, so it makes me wonder... [16:43] TheEric: or, to be sure, you want to rever the branch to the original state? [16:43] lp:xpattern should be reverted to rev 1264 [16:43] Exactly. to Revision 1264 [16:43] It shows as 1 revision right now. [16:43] so somebody made a new branch and ran push --overwrite? [16:44] *shrug* [16:44] probably [16:44] something's not right: http://bazaar.launchpad.net/~xpattern/xpattern/xpattern-1.0/changes [16:44] yeah [16:44] it may be LP being dumb [16:45] TheEric: this is recoverable, but I still wonder how did it happen [16:45] luks, it doesn't seem like a problem with the actual branch [16:45] Manfre is listed as the admin with all the requisit access. (points at Manfre) [16:46] beuno: bzr log shows exactly one revision [16:46] luks, that's interesting, loggerhead shows 1256 [16:46] loggerhead is probably cached, isn't it? [16:46] nope [16:46] reading straight off the repo [16:47] oh, the cache code was removed? [16:47] this the most recent subscription update http://xpat.pastebin.com/m8676527 [16:47] yeap, a while ago [16:47] it only caches changed files [16:47] i truncated the file contents out of it [16:47] oh, I see [16:47] hmm [16:48] this is interesting [16:48] yah, and the removal of the revisions was done after the push [16:48] looks like the parent is a ghost [16:49] but the two events were done ~ seconds of each other. [16:51] i need to step away from the computer for a bit. So I'll defer any magically sign offs to TheEric...but i'm pretty sure it's obvious this is an error that needs correcting [16:51] I wouldn't touch the branch for now, as it looks like a bug [16:51] but all the data are on the server, so it should be recoverable [16:51] TheEric: can you please file a bug report? [16:52] Sure. === kiko-zzz is now known as kiko-phone [16:56] hmm, even more interesting, bzrlib has no problem reading the missing revisions [16:57] so it looks just like an UI bug [16:57] but a really serious UI bug, I think [16:59] hi. it now happened 2 times that a bzr push would hang at 0. needs 2 times ctrl-c to kill it. i then need break-lock and afterwards push works and takes almost no time [16:59] any ideas on what's going on? [17:00] TheEric: well, I've found the problem [17:00] oh? [17:00] the branch data is broken, the repository data is not [17:00] http://bazaar.launchpad.net/~xpattern/xpattern/xpattern-1.0/.bzr/branch/last-revision is not supposed to list revno 1 [17:00] any idea how that happened? [17:00] I have no idea at all [17:00] you better way for some bzr devs for that [17:00] but make sure you file the bug report [17:00] I am. [17:01] or already have. [17:01] I just added your current comment to the description. [17:01] I'm out to lunch. bbl. [17:02] the fix is as simple as changing 1 to 1265 in .bzr/branch/last-revision [17:02] but I wouldn't do that on the official branch until you head from a bzr dev [17:02] *hear [17:03] TheEric: hm, what's the link to the bug report? I can't find it in launchpad [17:04] I wonder if this could be some stacking related bug [17:08] Manfre, TheEric, do either of you have the branch that was used to push lp:xpattern ? [17:12] On branching that branch, I get bzr: ERROR: bzrlib.errors.NotLefthandHistory: Supplied history does not follow left-hand parents [17:21] is there any way of turning off this message? -- bzr: ERROR: no changes to commit. use --unchanged to commit anyhow -- I want to commit changes every 15 minutes from cron, silently doing nothing if there's nothing changed [17:24] Lea: "if bzr diff >/dev/null; then bzr commit -m 'autocommit'; fi" may what you want [17:26] james_w, thanks for the idea [17:27] rockstar: works for me using bzr.dev, which version are you using? [17:27] Lea: you may need to invert the test [17:27] luks, whatever's in the PPA currently. [17:27] it fetches all the ancestry, correctly packs it into a single pack, but leaves last-revision broken [17:27] luks, yea. I've seen this bug once before. [17:28] james_w, yeh, already noticed that [17:28] luks: does "bzr check" fail? [17:28] I thought it was a user error, because I didn't have much confidence in the user... [17:28] I've seen mismatch between the two numbers, but never last-revision reset to 1 [17:28] if not then check should probably check for "len(branch.revision_history()) == branch.last_revision_info()[1]" [17:28] james_w: I don't think it has a reaso n to fail, but I'll check [17:29] hm, true [17:29] rockstar: oh, it fails for me now, too [17:29] I'll check what's changed since then [17:30] interestingly, lp:xpattern fails, http://bazaar.launchpad.net/~xpattern/xpattern/xpattern-1.0/ doesn't [17:30] I thought it uses the same code path [17:31] Interesting. [17:31] ah, that's probably bzr+ssh vs http [17:31] Yea, that's probably what it is. [17:31] http just fetches the last-revision file, with bzr+ssh it has to recreate it [17:31] and recreating it fails on the assert [17:31] So maybe the bug is in the transport. [17:32] I still suspect it has something to do with stacking [17:32] I can't see why would anything in bzr reset the number to 1 [17:32] luks, do you have the original branch on your system? [17:32] I saw this bug long before stacking was even CLOSE to being in trunk, back in maybe May. [17:33] rockstar: this is not my branch, so no :) [17:33] Yea, I figured. [17:33] Whoever has the original branch would probably be helpful. [17:33] the original .bzr.log would help more than the branch, though [17:34] since the branch is already broken and the last-revision file overwritten [17:34] the state before the commit would help === kiko-phone is now known as kiko-fud [17:35] Yea, but the original branch would have everything we need, unless that branch is also screwed [17:36] I guess it is, unless this is indeed a bzr+ssh bug and it rewrote the number on push [17:37] Which would make sense. I don't think it has much to do with stacking, but I have no clue how to reproduce it. [17:37] I didn't mean stacking directly, but some bug introduced with stacking [17:39] Manfre: I understand you were the one who pushed the branch? was it just 'bzr push' or 'bzr push --overwrite'? [17:39] TheEric, 'bzr reconcile lp:xpattern' will fix the problem [17:39] (as mentioned by abentley) [17:45] So, what would be interesting: the source branch this was pushed from. An idea of when the branch was created. The .bzr.log from the most recent push. [17:45] TheEric, ca you get in touch with the person you pushed last? [17:47] Oh, the bzr version used for pushing, of course. === toytoy_ is now known as toytoy [18:06] Back [18:07] Manfre is the project lead, and not the person who last pushed. [18:08] i'm back [18:09] so the person who did the last commit needs to run "bzr reconcile lp:xpattern" ? [18:10] Manfre, anyone who has access can do that [18:10] it will fix it [18:10] although, if you could grab the person who pushed and get everything abentley mentioned above, it would be very helpful to us in the future [19:08] the reconcile didn't fix the problem. === mw is now known as mw|food [19:09] it completed about ten minutes ago, I tried to download the branch, and it's still giving me the same error. [19:20] https://bugs.launchpad.net/launchpad-bazaar/+bug/257340 [19:20] Launchpad bug 257340 in launchpad-bazaar "Revision History set to 0 following push" [Undecided,New] [19:20] TheEric, thanks for the report [19:21] could you pastebin the last bits of your .bzr.log? [19:21] from the reconcile? [19:21] yeap [19:22] Umm. Interesting.... [19:23] I don't seem to have that in the .bzr folder and the contents of my local xpattern directory is now, empty. [19:24] TheEric: ~/.bzr.log [19:24] I wouldn't trust reconcile over bzr+ssh [19:24] it's on a windows install. [19:25] my documents folder [19:25] TheEric: in that case I have no idea where it would be :) [19:25] I'm just a bit confused as to why -all- my local files for xpat are gone. [19:26] just bazaar.conf and ignore [19:26] odd [19:26] TheEric: are you looking to the right folder? [19:26] i wonder if the reconcile wiped it [19:27] I am. [19:27] bazaar.conf and ignore should be in Application Data/bazaar/2.0 [19:27] not in .bzr dir of your branch [19:27] I looked in the .bzr dir in the branch, and there wasn't any sort of log file. [19:27] of course, the xpattern directory is empty except for that folder. [19:27] .bzr.log should be in the home folder [19:27] .bzr.log is in the My Documents folder on my system [19:29] found it. [19:30] and it's blank. [19:37] yah, did a further search, and no other .bzr.log - only the blank file. That's odd as I've used bzr on this computer, multiple times. [19:38] TheEric: bzr --version will tell you where it's putting the log file. [19:38] same exact location where I found the blank log. [19:39] TheEric: can you post the output that bzr reconcile gave you? [19:40] ubottu: pastebin [19:40] pastebin is a service to post multiple-lined texts so you don't flood the channel. The Ubuntu pastebin is at http://paste.ubuntu.com (make sure you give us the URL for your paste - see also the channel topic) [19:40] Well, there's nothign really to post - the .bzr.log file is blank. 0 bytes. [19:41] i think they want the console output from the command [19:41] hopefully you didn't close the prompt [19:42] http://pastebin.com/d3404dfe6 [19:42] TheEric: I meant the console output. [19:42] yah, that's above. [19:45] TheEric: Strangely, it seems to think your revision_history is okay. === kiko-fud is now known as kiko-afk === ozzloy_ is now known as ozzloy [19:53] TheEric: I was able to branch successfully over http, but not bzr+ssh. Reconciling over sftp might work correctly. === mw|food is now known as mw [19:55] abentley: is it possible to revert to 1264 over http? [19:55] Manfre: Not over http, but it would be possible over sftp. [19:56] i'm not familiar with using bzr with sftp...only http and bzr+ssh [19:57] Manfre: it's very similar to bzr+ssh, but a bit slower. You just change the URL. [19:58] i.e. replace "bzr+ssh:" with "sftp:" [20:01] unsupported protocol [20:01] don't have module paramiko [20:03] Manfre: Okay, try changing "bzr+ssh" to "nosmart+bzr+ssh" [20:04] Manfre: But I'd recommend getting paramiko at some point. All the full installers should have it. [20:44] I just installed Bazaar via ports and wanted to work with svn. After installing the svn 1.5 bindings and the bzr-svn plugin, I ran "$ bzr co -v svn+https://server/repos/trunk" to test and got "Assertion failed: (*path != '/'), function svn_ra_get_log2, file subversion/libsvn_ra/ra_loader.c, line 940." followed by a SIGABRT coredump [20:44] ideas? [20:48] same assertion fails in bzr selftest svn after: "[9/824 in 4s] bzrlib.plugins.svn.tests.test_branch.WorkingSubversionBranch.test_create_checkout" [21:14] I tried to check out from http://people.samba.org/bzr/jelmer/bzr-svn/0.4/ and build, but then it fails to load the extension altogether [21:19] abentley: hey, I can't seem to "bzr merge http://bundlebuggy...." anymore. I sent a message to the list [21:20] It seems that BB isn't returning 404 for missing documents [21:20] it is returning 200 OK, with a 404 page. [21:22] Toranin: you might try running "bzr command -Derror" which might help figrue out why the extension is failing to load. === kiko-afk is now known as kiko [21:22] jam: Yeah, it does look broken. You might be able to work around it with nosmart+http. [21:23] abentley: nope, "Unknown bzrdir format: same thing if I revert to an earlier version of bzr [21:23] When it probes for .bzr/branch/format it gets a 200 OK document [21:23] but then doesn't recognize the contents. [21:24] It's supposed to try to use the bundle, and if that succeeds, not use the branch. [21:25] abentley: well, neither seems to be working ... [21:25] I can 'wget' and then merge from that, though. [21:25] and it is still broken for bzr.dev @ 3400, 3500, etc [21:25] so it doesn't seem to be something new for bzr [21:25] jam: it already gives an exception output now [21:25] jam: let me pastebin it for you [21:26] jelmer: ping? [21:27] jam: http://pastebin.com/d1f33eabd <-- says 'did you build it?' in there, but I did [21:28] Toranin: did you use "build_ext -i" or just "build" ? [21:28] if I go into the ~/.bazaar/plugins/svn directory and do 'PYTHONPATH=. python', I can import the modules it's failing on [21:28] I'm guessing you built it into a "build/XXX/...." directory [21:28] so it can't find it [21:28] python setup.py build_ext -i [21:28] okay [21:28] *should* be what you want [21:28] will do [21:28] but I'm guessing a bit [21:28] I just did gmake [21:28] there's a makefile that invokes setup but not sure exactly how [21:29] ran your command, didn't appear to do anything [21:29] I already have 4 .so files in the svn dir [21:30] the makefile appears to invoke python setup.py build_ext --inplace by default, which I presume is the same [21:32] Toranin: do you have editor.o in your root directory? [21:34] no -- what the build_ext did was put the o file in the build/... tree and then copy the .so (module) files back up into the root dir [21:36] I just tried copying the .o files into place, didn't help any [21:37] is this new? I notice there are no c or so files in the 4.10 tarball [21:43] Toranin: https://lists.ubuntu.com/archives/bazaar-announce/2008-August/000172.html [21:45] noted [21:47] hmm, does bzr do some kind of magic overrides on the import statement? [21:47] otherwise I can't see how the imports in question are supposed to work [21:58] ahh, I see [21:59] the svn plugin as written assumes it's installed under bzrlib/... [21:59] which is not the case for a homedir install [22:01] Toranin: Plugins are always loaded into bzrlib.plugins, regardless of their filesystem location. [22:06] abentley: I'd have thought so [22:06] but given the error I tried just installing it unto site-packages [22:06] didn't help any, as you probably expected [22:08] I'm just weirded out by the error, because I can manually import the .so file from the command line [22:08] moin === abadger19992 is now known as abadger1999 [22:19] abentley: ping [22:19] abentley: bb seems to think squid bundles are bazaar project bundls [22:19] abentley: or is it the wrong target branch leading to the confusion ? [22:20] lifeless: It would be the wrong target branch, I expect. [22:20] ok, [22:20] I'll tweak the squid doco; what do you think about categorising by history as well? [22:22] lifeless: I think that merge directives should be mergeable. A merge directive with the wrong target branch isn't mergeable, because the target branch isn't available as a resource for retrieving revisions. [22:22] * Toranin tried upgrading bzr to 1.6rc1 [22:24] abentley: ah yes [22:24] abentley: however, if the base is a revision I know about in my repo then the target doesn't strictly matter [22:24] lifeless: I'm not completely against adding more heuristics. [22:25] lifeless: But someone sending a merge directive doesn't typically know what's in your repository. [22:31] abentley: agreed; kinkies patch was against trunk though; as a user he did the right thing but is missing public_location [22:31] abentley: are you still suffering some contention issues on the BB database? [22:32] lifeless: I've got a load average of 6.24 [22:32] all from BB? [22:33] well, that's working much better...the tests are running, though there're some failures [22:33] lifeless: No, that machine handles my mail and web site as well. [22:35] ah whew, I'd hate to think review was using up that much order ;) [22:36] Order? [22:39] well doing work increase entropy, so decreases order :) [22:39] lifeless, do you have a minute to discuss bug #248018 - I can't reproduce it, really [22:39] Launchpad bug 248018 in loggerhead/1.6 "slow search results override fast ones" [High,Confirmed] https://launchpad.net/bugs/248018 [22:39] beuno: yes [22:40] lifeless, well, for starters, I can't get LH to override results :) [22:40] the code is in place to prevent it [22:40] so I need to reproduce it to find out where it's slipping [22:41] go to http://bzr-playground.gnome.org/accerciser/trunk/ [22:41] type 'a', wait a 1/2 second, type b [22:41] you should get ab showing a tad later, then the results for a [22:42] lifeless, yeap, got it. Is it running the latest LH? [22:42] search thumper [22:44] lifeless, nm, it has the same js, enough for me [22:45] now, let's see how to debug that... [22:45] see, easy :) [22:46] jam: so btree - 3 times faster [22:47] jam: I'm really starting to feel it would be of benefit to drop the core btree support into bzrlib in some form real soon [23:06] beuno: you need more from me on that? [23:06] lifeless, nope, thanks [23:10] statik: nice changes to the scripts [23:24] mwhudson, did you manage to figure out the "I'm serving from root" issue in https://code.edge.launchpad.net/~pickscrape/loggerhead/directory_breadcrumbs ? [23:25] beuno: no, didn't really look at it properly [23:26] mwhudson, k, np. I'll come back to it after I finish the remaining 1.6 bugs, if you haven't managed to before [23:26] beuno: i'll try to look at it now [23:27] mwhudson, you rock, thanks! :) [23:32] beuno: your 'bundles' branch looks mergeable to me [23:32] beuno: can you rename the 's' StringIO variable though? [23:33] mwhudson, it still needs a link to download the actual diff :) [23:33] hey guys, thanks for bzr, helped out GREAT at work for some badly VCS'ed jumble of code :D [23:33] mwhudson, sure, rename to...? [23:33] I am guilty of trying Git on Windows XP first though.... [23:33] that was not fun [23:33] it would also be possible to stream the output, dunno if that's worth it though.... [23:33] at all. [23:33] beuno: 'diff_content' ? [23:33] hm, maybe not that [23:33] mwhudson, just 'content'? [23:34] 'diff_content_stream' ? [23:34] mwhudson: should I delete that superseded branch? [23:34] pickscrape: if you like, no real need though [23:34] I like to keep things tidy :) [23:34] i guess it could be marked 'abandoned' [23:34] mark it abandoned then, it will disappear from almost all listings that way [23:34] Will that make it drop off the loggerhead branch list? [23:34] OK, I'll do that. [23:35] mwhudson, I'll tweak the remaining bits, and rename, and propose for merging [23:36] beuno: ok [23:36] beuno: and yeah, a link to it would be handy i guess :) [23:48] lifeless: I agree that we should bring them in, possibly before GC [23:48] I would probably bring them in without blooms [23:48] We have very little evidence that it will be better, and if we do tweak them to get better [23:48] it will likely be incompatible with existing bloom code anyway