/srv/irclogs.ubuntu.com/2008/09/17/#launchpad-meeting.txt

=== kiko is now known as kiko-zzz
=== mwhudson is now known as mwh
=== thumper_laptop is now known as thumper
=== danilo_ is now known as danilos
=== kiko-zzz is now known as kiko
=== mrevell is now known as mrevell-lunch
=== salgado-afk is now known as salgado
=== mrevell-lunch is now known as mrevell
barry#startmeeting15:00
barrymoooootbooootttttt15:00
sinzuiHe's dead Jim15:00
barryanyway.  welcome to this week's ameu reviewers meeting.  who's here today?15:00
sinzuime15:00
abentleyyou15:00
intellectronicame15:00
barryi'm a doctor not a software engineer!15:00
bigjoolsme15:01
salgadome15:01
flacosteme15:01
bacme15:01
barrygmb sends his apologies15:01
cprovme15:02
barryBjornT, danilos ping15:02
barryEdwinGrubbs: ping15:02
EdwinGrubbsme15:02
danilosme15:02
BjornTme15:03
barryi think that's everyone...15:03
barry[TOPIC] agenda15:03
barry * Roll call15:03
barry * Naming conventions for unit test methods. `testFooBar`, `test_fooBar` and `test_foo_bar` all exist. Recommend settling on `testFooBar` and only changing existing ones as encountered in normal work. -- jml [<<Date(2008-09-10T13:48:09+1000)>>]15:03
barry * Reviewers remove requests from Pending Reviews when you start a review.  If you forget the next on-call reviewer may duplicate your work.  -- bac [<<Date(2008-09-16T10:07:09-0500)>>]15:03
barry * If there's time, the old boring script15:03
barry   * Next meeting15:03
barry   * Action items15:03
barry   * Queue status15:03
barry   * Mentoring update15:03
bacjtv is having trouble getting into this channel15:03
barrybac: dang15:03
barry[TOPIC] naming conventions15:04
barryi'm just going to paste this one since it was submitted by an asiapacker.  i don't have any background on it since my intarwebs went out monday night15:04
barry * Naming conventions for unit test methods. `testFooBar`, `test_fooBar` and `test_foo_bar` all exist. Recommend settling on `testFooBar` and only changing existing ones as encountered in normal work. -- jml [<<Date(2008-09-10T13:48:09+1000)>>]15:04
barryi think it's fairly self evident15:04
barrywhat do y'all think?15:05
* sinzui hugs PEP-8, then kicks it out the door.15:05
kiko_I don't care myself as long as there's a single standard. :)15:05
* barry would like to see more pep-8 rather than less15:06
* abentley is conflicted, because test_fooBar is irregular, but fooBar would match the method name.15:06
flacostein all honestyu15:06
sinzuitestFooBar is consistent with our rules. So I think it is the right decision15:06
flacostei find test_ easier to read for tests15:06
intellectronicai think test_methodName is better15:06
flacosteespecially when you can use test_nameOfMethodIMTesting_and_special_consideration15:07
flacosteintellectronica: +115:07
barryflacoste: very good point15:07
bacintellectronica: +115:07
BjornT+1 to test_fooBar15:07
bigjools+115:07
salgado+115:07
barry+115:07
sinzui+115:07
barryany objections?15:08
flacostetest_fooBar_plus_special_case15:08
flacoste?15:08
flacosteor test_fooBarPlusSpecialCase15:08
flacoste?15:08
flacostewe often have more than one tests for one method15:08
barryflacoste: the former (IMO)15:09
intellectronicatest_fooBar_plus_special_case15:09
intellectronica!15:09
bac+1 on test_fooBarPlusSpecialCase15:09
barryintellectronica: +115:09
salgadoplease!15:09
salgadotest_methodName_plus_special_case15:09
flacostesalgado: +115:10
barrybac: why?15:10
bacit is simpler and looks better to me.15:10
barryany other comments?15:11
salgadoI vote on the former because it makes the methodName stand out from the rest15:11
flacostesame rationale over here15:11
salgadoand because we already use underscores for test_15:11
flacosteand it's more PEP-8 compliant15:11
barryagreed15:12
bacPEP-8 supports mixing camelCase and underscores?15:12
barrybac: not really, but it's the price we pay for being zopey15:12
barryokay, anyway, let's move on.  i'll forward the results of this discussion to the ml and we can decide from there15:13
barry[ACTION] barry to forward results of test naming discussion to ml15:13
barry[TOPIC] reveiwers remove requests15:14
barry * Reviewers remove requests from Pending Reviews when you start a review.  If you forget the next on-call reviewer may duplicate your work.  -- bac [<<Date(2008-09-16T10:07:09-0500)>>]15:14
barrybac: the floor is yours15:14
baclast week and this week i reviewed a branch from the general queue on PendingReviews only to discover later each had already been reviewed.  yes, had i double-checked with the launchpad-reviews mailing list i could have avoided the duplicated work.  but reviewers need to be diligent about removing branches from the General Queue when they take them.15:14
sinzuiWow, I did that last week too15:15
barrybac: yes, especially now that we're back to using PR exclusively for the time being15:15
barryduplicate work REALLY sucks15:15
intellectronicabac: my sympathies :(15:16
bacindeed.  of course, the duplicated review did raise some interesting issues, but it is still annoying.15:16
intellectronicabac: reviewers should pay attention to this, but ideally i think reviewees should take care of that15:16
barrybac: silver lining :)15:16
bacintellectronica: if you're doing an on-call review off the GQ the reviwee may not be around.  the reviewer should move it to his queue.15:17
intellectronicabac: yes, if the reviewee is absent then definitely15:17
bacthat's all.  just raising awareness that the problem exists.15:19
barrybac: thanks15:19
barrythat's it for the new items.  since we have time i'd like to go hit the old agenda items, but i'm going to skip ahead15:20
barry[TOPIC] mentoring update15:20
barrywe need a few mentors, one for rockstar and possibly soon for mars and leonardr15:20
barrydo we have any volunteers?15:21
barrywe currently have one mentat: abentley (who i'm mentoring)15:21
baci recall promising to step up for the next round.15:22
baci'll volunteer to mentor rockstar15:22
barrybac: awesome thanks15:22
sinzuiI'm very busy for the next month. after that, I'm happy to take a mentat15:22
barrysinzui: great.  leonardr and mars have not yet officially asked to be reviewers, so we have time to wait on that15:22
bacis rockstar starting next cycle?15:23
barrybac: i'd like him to15:23
bigjoolsresistance is futile, they will be assimilated15:23
bacok.  i'll contact him after the meeting.15:23
barrylol15:23
* barry thinks bigjools should change his nick to borgjools15:23
barrybac: thanks15:23
bigjoolsguffaw :)15:23
barry[TOPIC] action items15:24
bacafter i mentor rockstar next cycle i'm going to request a one month sabbatical.15:24
barrybac: from reviewing or mentoring?15:24
bacboth15:24
barrybac: cool.  everybody needs sabbaticals now and then15:24
barry * barry will move the preimp discussion to the ml15:25
barryi have a 1/2 composed email on this, so not done15:25
barry[TOPIC] queue status15:25
barryany comments?15:25
barryi notice lots of crossed off branches in pending-reviews.  let's try to clean those up (he says as an offender)15:26
barryanyway, that's all i have.  does anybody have anything not on the agenda?15:27
barrywell then, we can end early!  thanks everyone and have a good day15:29
barry#endmeeting15:29
bacbarry: do you want to edit PR to remove the reference to MergeProposals?15:29
barrybac: will do, thanks for the reminder15:30
bigjoolsthanks barry, and BCTL, wow!15:30
barrybigjools: yeah, wtf am i thinking?!15:31
=== salgado is now known as salgado-brb
=== salgado-brb is now known as salgado
=== kiko_ is now known as kiko-fud
=== salgado is now known as salgado-lunch
=== bac is now known as bac-lunch
=== bac-lunch is now known as bac
=== salgado-lunch is now known as salgado
=== kiko-fud is now known as kiko
=== thumper_laptop is now known as thumper
=== kiko is now known as kiko-phone
=== kiko-phone is now known as kiko
=== salgado is now known as salgado-afk
=== kiko is now known as kiko-afk
=== thumper_laptop is now known as thumper
=== bac is now known as bac_afk
=== thumper_laptop is now known as thumper

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!