=== kiko is now known as kiko-zzz === mwhudson is now known as mwh === thumper_laptop is now known as thumper === danilo_ is now known as danilos === kiko-zzz is now known as kiko === mrevell is now known as mrevell-lunch === salgado-afk is now known as salgado === mrevell-lunch is now known as mrevell [15:00] #startmeeting [15:00] moooootbooootttttt [15:00] He's dead Jim [15:00] anyway. welcome to this week's ameu reviewers meeting. who's here today? [15:00] me [15:00] you [15:00] me [15:00] i'm a doctor not a software engineer! [15:01] me [15:01] me [15:01] me [15:01] me [15:01] gmb sends his apologies [15:02] me [15:02] BjornT, danilos ping [15:02] EdwinGrubbs: ping [15:02] me [15:02] me [15:03] me [15:03] i think that's everyone... [15:03] [TOPIC] agenda [15:03] * Roll call [15:03] * Naming conventions for unit test methods. `testFooBar`, `test_fooBar` and `test_foo_bar` all exist. Recommend settling on `testFooBar` and only changing existing ones as encountered in normal work. -- jml [<>] [15:03] * Reviewers remove requests from Pending Reviews when you start a review. If you forget the next on-call reviewer may duplicate your work. -- bac [<>] [15:03] * If there's time, the old boring script [15:03] * Next meeting [15:03] * Action items [15:03] * Queue status [15:03] * Mentoring update [15:03] jtv is having trouble getting into this channel [15:03] bac: dang [15:04] [TOPIC] naming conventions [15:04] i'm just going to paste this one since it was submitted by an asiapacker. i don't have any background on it since my intarwebs went out monday night [15:04] * Naming conventions for unit test methods. `testFooBar`, `test_fooBar` and `test_foo_bar` all exist. Recommend settling on `testFooBar` and only changing existing ones as encountered in normal work. -- jml [<>] [15:04] i think it's fairly self evident [15:05] what do y'all think? [15:05] * sinzui hugs PEP-8, then kicks it out the door. [15:05] I don't care myself as long as there's a single standard. :) [15:06] * barry would like to see more pep-8 rather than less [15:06] * abentley is conflicted, because test_fooBar is irregular, but fooBar would match the method name. [15:06] in all honestyu [15:06] testFooBar is consistent with our rules. So I think it is the right decision [15:06] i find test_ easier to read for tests [15:06] i think test_methodName is better [15:07] especially when you can use test_nameOfMethodIMTesting_and_special_consideration [15:07] intellectronica: +1 [15:07] flacoste: very good point [15:07] intellectronica: +1 [15:07] +1 to test_fooBar [15:07] +1 [15:07] +1 [15:07] +1 [15:07] +1 [15:08] any objections? [15:08] test_fooBar_plus_special_case [15:08] ? [15:08] or test_fooBarPlusSpecialCase [15:08] ? [15:08] we often have more than one tests for one method [15:09] flacoste: the former (IMO) [15:09] test_fooBar_plus_special_case [15:09] ! [15:09] +1 on test_fooBarPlusSpecialCase [15:09] intellectronica: +1 [15:09] please! [15:09] test_methodName_plus_special_case [15:10] salgado: +1 [15:10] bac: why? [15:10] it is simpler and looks better to me. [15:11] any other comments? [15:11] I vote on the former because it makes the methodName stand out from the rest [15:11] same rationale over here [15:11] and because we already use underscores for test_ [15:11] and it's more PEP-8 compliant [15:12] agreed [15:12] PEP-8 supports mixing camelCase and underscores? [15:12] bac: not really, but it's the price we pay for being zopey [15:13] okay, anyway, let's move on. i'll forward the results of this discussion to the ml and we can decide from there [15:13] [ACTION] barry to forward results of test naming discussion to ml [15:14] [TOPIC] reveiwers remove requests [15:14] * Reviewers remove requests from Pending Reviews when you start a review. If you forget the next on-call reviewer may duplicate your work. -- bac [<>] [15:14] bac: the floor is yours [15:14] last week and this week i reviewed a branch from the general queue on PendingReviews only to discover later each had already been reviewed. yes, had i double-checked with the launchpad-reviews mailing list i could have avoided the duplicated work. but reviewers need to be diligent about removing branches from the General Queue when they take them. [15:15] Wow, I did that last week too [15:15] bac: yes, especially now that we're back to using PR exclusively for the time being [15:15] duplicate work REALLY sucks [15:16] bac: my sympathies :( [15:16] indeed. of course, the duplicated review did raise some interesting issues, but it is still annoying. [15:16] bac: reviewers should pay attention to this, but ideally i think reviewees should take care of that [15:16] bac: silver lining :) [15:17] intellectronica: if you're doing an on-call review off the GQ the reviwee may not be around. the reviewer should move it to his queue. [15:17] bac: yes, if the reviewee is absent then definitely [15:19] that's all. just raising awareness that the problem exists. [15:19] bac: thanks [15:20] that's it for the new items. since we have time i'd like to go hit the old agenda items, but i'm going to skip ahead [15:20] [TOPIC] mentoring update [15:20] we need a few mentors, one for rockstar and possibly soon for mars and leonardr [15:21] do we have any volunteers? [15:21] we currently have one mentat: abentley (who i'm mentoring) [15:22] i recall promising to step up for the next round. [15:22] i'll volunteer to mentor rockstar [15:22] bac: awesome thanks [15:22] I'm very busy for the next month. after that, I'm happy to take a mentat [15:22] sinzui: great. leonardr and mars have not yet officially asked to be reviewers, so we have time to wait on that [15:23] is rockstar starting next cycle? [15:23] bac: i'd like him to [15:23] resistance is futile, they will be assimilated [15:23] ok. i'll contact him after the meeting. [15:23] lol [15:23] * barry thinks bigjools should change his nick to borgjools [15:23] bac: thanks [15:23] guffaw :) [15:24] [TOPIC] action items [15:24] after i mentor rockstar next cycle i'm going to request a one month sabbatical. [15:24] bac: from reviewing or mentoring? [15:24] both [15:24] bac: cool. everybody needs sabbaticals now and then [15:25] * barry will move the preimp discussion to the ml [15:25] i have a 1/2 composed email on this, so not done [15:25] [TOPIC] queue status [15:25] any comments? [15:26] i notice lots of crossed off branches in pending-reviews. let's try to clean those up (he says as an offender) [15:27] anyway, that's all i have. does anybody have anything not on the agenda? [15:29] well then, we can end early! thanks everyone and have a good day [15:29] #endmeeting [15:29] barry: do you want to edit PR to remove the reference to MergeProposals? [15:30] bac: will do, thanks for the reminder [15:30] thanks barry, and BCTL, wow! [15:31] bigjools: yeah, wtf am i thinking?! === salgado is now known as salgado-brb === salgado-brb is now known as salgado === kiko_ is now known as kiko-fud === salgado is now known as salgado-lunch === bac is now known as bac-lunch === bac-lunch is now known as bac === salgado-lunch is now known as salgado === kiko-fud is now known as kiko === thumper_laptop is now known as thumper === kiko is now known as kiko-phone === kiko-phone is now known as kiko === salgado is now known as salgado-afk === kiko is now known as kiko-afk === thumper_laptop is now known as thumper === bac is now known as bac_afk === thumper_laptop is now known as thumper