=== ursula_ is now known as Ursinha [02:59] #startmeeting [02:59] Meeting started at 20:59. The chair is barry_. [02:59] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [02:59] mootbot! [02:59] hello everybody and welcome to this week's asiapac reviewers meeting [02:59] who's here today? [03:00] anybody? [03:01] jml, mwhudson, thumper ping? [03:01] hi [03:01] barry_: hi [03:01] I forgot it was Tuesday :) [03:01] * thumper is somewhat busy with beuno [03:02] jml: it's not, it's still monday :) [03:02] hi [03:02] my mistake [03:02] thumper: i can wait a little bit if you want [03:02] barry_: yeah, but you can't wait for a week :) [03:02] I'll just pop in and out [03:02] :) [03:03] cool. btw, i will not be here next week. do you want to skip the meeting or can one of you run it? [03:03] [TOPIC] agenda [03:03] New Topic: agenda [03:03] * Roll call [03:03] * Using ReST instead Moin for documentation -- flacoste [<>] [03:03] * Naming conventions for unit test methods. `testFooBar`, `test_fooBar` and `test_foo_bar` all exist. Recommend settling on `testFooBar` and only changing existing ones as encountered in normal work. -- jml [<>] [03:03] * Reviewers remove requests from Pending Reviews when you start a review. If you forget the next on-call reviewer may duplicate your work. -- bac [<>] [03:03] * If there's time, the old boring script [03:03] * Next meeting [03:03] * Action items [03:03] * Queue status [03:03] * Mentoring update [03:04] * jml waits [03:05] i'll let you guys sort it out for next week then :) [03:05] [TOPIC] * Using ReST instead Moin for documentation -- flacoste [<>] [03:05] New Topic: * Using ReST instead Moin for documentation -- flacoste [<>] [03:05] I really don't care about this one [03:05] i haven't talked to flacoste about this yet, but i think this was brought up by gary [03:06] gary wants to write doctests in reST [03:06] * barry_ likes reST [03:06] barry_: given that we aren't actually publishing the documentation, I don't see that it matters too much. [03:06] unless we're actually going to render the documentation and do something with it, i heartily don't care [03:07] cool. i just wanted to get your sense so i can communicate it accurately at the ameu meeting [03:07] (rendering the documentation would probably be a good idea though) [03:07] sounds like a resounding -0/+0 [03:07] barry_: can we change the doc standard so it's 78 cols all the way through? [03:07] barry_: well, it's a bit more negative than that, as it would be a lot of work [03:07] * jml is half kidding [03:07] jml: i've been wanting to do that since i started [03:08] .oO(not that i edit doctests much...) [03:08] barry_: 72 for text and 78 for Python seems like make-work to me. [03:08] mwhudson: i wouldn't propose to rewrite existing docs just to reformat them. do it as general cleanup [03:08] barry_: but that's probably a separate agendum :) [03:08] jml: why do you think i avoid friday reviews? sinzui is the only one who cares about that :) [03:09] jml: but now sinzui is team leader and not doing reviews, so there ya go :) [03:09] heh heh [03:09] barry_: still more work than seems worth it unless there are other benefits [03:09] jml: i will put it on the agenda for wednesday [03:09] [ACTION] barry put 78 column consistency in doctests on agenda for ameu [03:09] ACTION received: barry put 78 column consistency in doctests on agenda for ameu [03:10] mwhudson: ok, thanks. gotcha [03:10] cool. [03:10] * jml agrees with mwhudson [03:10] [TOPIC] * Naming conventions for unit test methods. `testFooBar`, `test_fooBar` and `test_foo_bar` all exist. Recommend settling on `testFooBar` and only changing existing ones as encountered in normal work. -- jml [<>] [03:10] New Topic: * Naming conventions for unit test methods. `testFooBar`, `test_fooBar` and `test_foo_bar` all exist. Recommend settling on `testFooBar` and only changing existing ones as encountered in normal work. -- jml [<>] [03:10] I had a look at the AMEU minutes. [03:10] jml: we talked about this in ameu, but you hadn't had time to state your position yet [03:10] it seems they settled on test__qualifying_comments [03:11] jml: right, are you okay with that? or disagree? [03:11] I assume that tests without identifiers just get pep8'd? [03:11] yep [03:12] barry_: I'm cool with it. [03:12] jml: cool [03:12] barry_: I basically just wanted a standard -- every module I use is different. [03:12] jml: right, agreed! [03:13] hooray [03:13] [TOPIC] * Reviewers remove requests from Pending Reviews when you start a review. If you forget the next on-call reviewer may duplicate your work. -- bac [<>] [03:13] New Topic: * Reviewers remove requests from Pending Reviews when you start a review. If you forget the next on-call reviewer may duplicate your work. -- bac [<>] [03:14] i think this one's just a heads up. several people did multiple reviews [03:14] oh that's right, we still have a wiki page :) [03:14] "what is this Pending Reviews you speak of" ? [03:14] :) [03:14] i guess it's worth making the point [03:14] * barry_ looks to thumper and beuno [03:14] barry_: incidentally... https://code.edge.launchpad.net/~launchpad/launchpad/trunk [03:15] sure [03:15] jml: shhh [03:15] ;-) [03:15] * jml needs to read over that "actually using Launchpad for reviews doesn't work" email [03:16] * thumper too [03:16] jml: whoa [03:17] barry_: FYI, beuno and I are making reviews rock in LP [03:17] i can has branches on lp? [03:17] thumper, beuno i am very excited to see the results [03:17] on the sly, yes. [03:17] barry_, it's very promising :) [03:17] barry_: although make sure you upgrade everything (branches and repos) to 1.6 [03:18] it should make the workflow almost natural [03:18] jml: cool. eta for switching to? [03:18] barry_: also use bzr 1.7 or later [03:18] beuno: eta? [03:18] barry_: and the scanner will choke somewhat until mwhudson's branch is cherrypicked [03:18] i guess we could switch in maybe a week? [03:18] barry_: there are a few patches we need to land. [03:19] depending on how the cherry blossoms fall [03:19] barry_, it depends on thumper's speed and availability, but we should ahve something submitable after this week [03:19] after mwhudson branch is cherrypicked? if we could do it on or before epic, that would be fantastic [03:19] that should be possible for sure [03:19] barry_: within a day or two for production is my guess [03:20] wow. it would be fantastic if we can dogfood all this, kill off devpad branches and PR at epic [03:21] * thumper hopes too [03:21] * beuno hopes three [03:21] I do have two weeks leave between now and the epic [03:23] cool. that's about it from me. queue update, mentor update, action items, blah blah blah [03:23] anything from you guys? anything you want me to bring up at ameu? [03:24] nothing springs to mind [03:24] nope [03:24] nada [03:24] cool. thanks guys. see you all in 2 weeks. [03:24] #endmeeting [03:24] ok [03:24] Meeting finished at 21:24. [03:24] later dude [03:25] barry_: see ya === bac_afk is now known as bac === salgado-afk is now known as salgado === bac is now known as bac_breakfast === mrevell is now known as mrevell-lunch === bac_breakfast is now known as bac === bac is now known as bac_standup === bac_standup is now known as bac === ursula_ is now known as Ursinha === mrevell-lunch is now known as mrevell === ursula_ is now known as Ursinha === bac is now known as bac_lunch === salgado is now known as salgado-lunch === bac_lunch is now known as bac === salgado-lunch is now known as salgado === bac is now known as bac_bbiab === bac_bbiab is now known as bac === bac is now known as bac_afk === thumper_laptop is now known as thumper === salgado is now known as salgado-afk