[02:59] <barry_> #startmeeting
[02:59] <MootBot> Meeting started at 20:59. The chair is barry_.
[02:59] <MootBot> Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE]
[02:59] <barry_> mootbot!
[02:59] <barry_> hello everybody and welcome to this week's asiapac reviewers meeting
[02:59] <barry_> who's here today?
[03:00] <barry_> anybody?
[03:01] <barry_> jml, mwhudson, thumper ping?
[03:01] <jml> hi
[03:01] <thumper> barry_: hi
[03:01] <jml> I forgot it was Tuesday :)
[03:01]  * thumper is somewhat busy with beuno
[03:02] <barry_> jml: it's not, it's still monday :)
[03:02] <mwhudson> hi
[03:02] <jml> my mistake
[03:02] <barry_> thumper: i can wait a little bit if you want
[03:02] <thumper> barry_: yeah, but you can't wait for a week :)
[03:02] <thumper> I'll just pop in and out
[03:02] <barry_> :)
[03:03] <barry_> cool.  btw, i will not be here next week.  do you want to skip the meeting or can one of you run it?
[03:03] <barry_> [TOPIC] agenda
[03:03] <MootBot> New Topic:  agenda
[03:03] <barry_>  * Roll call
[03:03] <barry_>  * Using ReST instead Moin for documentation -- flacoste  [<<Date(2008-09-22T10:17:00-0500)>>]
[03:03] <barry_>  * Naming conventions for unit test methods. `testFooBar`, `test_fooBar` and `test_foo_bar` all exist. Recommend settling on `testFooBar` and only changing existing ones as encountered in normal work. -- jml [<<Date(2008-09-10T13:48:09+1000)>>]
[03:03] <barry_>  * Reviewers remove requests from Pending Reviews when you start a review.  If you forget the next on-call reviewer may duplicate your work.  -- bac [<<Date(2008-09-16T10:07:09-0500)>>]
[03:03] <barry_>  * If there's time, the old boring script
[03:03] <barry_>    * Next meeting
[03:03] <barry_>    * Action items
[03:03] <barry_>    * Queue status
[03:03] <barry_>    * Mentoring update
[03:04]  * jml waits
[03:05] <barry_> i'll let you guys sort it out for next week then :)
[03:05] <barry_> [TOPIC]  * Using ReST instead Moin for documentation -- flacoste  [<<Date(2008-09-22T10:17:00-0500)>>]
[03:05] <MootBot> New Topic:   * Using ReST instead Moin for documentation -- flacoste  [<<Date(2008-09-22T10:17:00-0500)>>]
[03:05] <thumper> I really don't care about this one
[03:05] <barry_> i haven't talked to flacoste about this yet, but i think this was brought up by gary
[03:06] <barry_> gary wants to write doctests in reST
[03:06]  * barry_ likes reST
[03:06] <jml> barry_: given that we aren't actually publishing the documentation, I don't see that it matters too much.
[03:06] <mwhudson> unless we're actually going to render the documentation and do something with it, i heartily don't care
[03:07] <barry_> cool.  i just wanted to get your sense so i can communicate it accurately at the ameu meeting
[03:07] <mwhudson> (rendering the documentation would probably be a good idea though)
[03:07] <barry_> sounds like a resounding -0/+0
[03:07] <jml> barry_: can we change the doc standard so it's 78 cols all the way through?
[03:07] <mwhudson> barry_: well, it's a bit more negative than that, as it would be a lot of work
[03:07]  * jml is half kidding
[03:07] <barry_> jml: i've been wanting to do that since i started
[03:08] <mwhudson> .oO(not that i edit doctests much...)
[03:08] <jml> barry_: 72 for text and 78 for Python seems like make-work to me.
[03:08] <barry_> mwhudson: i wouldn't propose to rewrite existing docs just to reformat them.  do it as general cleanup
[03:08] <jml> barry_: but that's probably a separate agendum :)
[03:08] <barry_> jml: why do you think i avoid friday reviews?  sinzui is the only one who cares about that :)
[03:09] <barry_> jml: but now sinzui is team leader and not doing reviews, so there ya go :)
[03:09] <jml> heh heh
[03:09] <mwhudson> barry_: still more work than seems worth it unless there are other benefits
[03:09] <barry_> jml: i will put it on the agenda for wednesday
[03:09] <barry_> [ACTION] barry put 78 column consistency in doctests on agenda for ameu
[03:09] <MootBot> ACTION received:  barry put 78 column consistency in doctests on agenda for ameu
[03:10] <barry_> mwhudson: ok, thanks.  gotcha
[03:10] <jml> cool.
[03:10]  * jml agrees with mwhudson
[03:10] <barry_> [TOPIC]  * Naming conventions for unit test methods. `testFooBar`, `test_fooBar` and `test_foo_bar` all exist. Recommend settling on `testFooBar` and only changing existing ones as encountered in normal work. -- jml [<<Date(2008-09-10T13:48:09+1000)>>]
[03:10] <MootBot> New Topic:   * Naming conventions for unit test methods. `testFooBar`, `test_fooBar` and `test_foo_bar` all exist. Recommend settling on `testFooBar` and only changing existing ones as encountered in normal work. -- jml [<<Date(2008-09-10T13:48:09+1000)>>]
[03:10] <jml> I had a look at the AMEU minutes.
[03:10] <barry_> jml: we talked about this in ameu, but you hadn't had time to state your position yet
[03:10] <jml> it seems they settled on test_<identifier>_qualifying_comments
[03:11] <barry_> jml: right, are you okay with that? or disagree?
[03:11] <jml> I assume that tests without identifiers just get pep8'd?
[03:11] <barry_> yep
[03:12] <jml> barry_: I'm cool with it.
[03:12] <barry_> jml: cool
[03:12] <jml> barry_: I basically just wanted a standard -- every module I use is different.
[03:12] <barry_> jml: right, agreed!
[03:13] <mwhudson> hooray
[03:13] <barry_> [TOPIC]  * Reviewers remove requests from Pending Reviews when you start a review.  If you forget the next on-call reviewer may duplicate your work.  -- bac [<<Date(2008-09-16T10:07:09-0500)>>]
[03:13] <MootBot> New Topic:   * Reviewers remove requests from Pending Reviews when you start a review.  If you forget the next on-call reviewer may duplicate your work.  -- bac [<<Date(2008-09-16T10:07:09-0500)>>]
[03:14] <barry_> i think this one's just a heads up.  several people did multiple reviews
[03:14] <jml> oh that's right, we still have a wiki page :)
[03:14] <mwhudson> "what is this Pending Reviews you speak of" ?
[03:14] <barry_> :)
[03:14] <mwhudson> i guess it's worth making the point
[03:14]  * barry_ looks to thumper and beuno
[03:14] <jml> barry_: incidentally... https://code.edge.launchpad.net/~launchpad/launchpad/trunk
[03:15] <thumper> sure
[03:15] <thumper> jml: shhh
[03:15] <thumper> ;-)
[03:15]  * jml needs to read over that "actually using Launchpad for reviews doesn't work" email
[03:16]  * thumper too
[03:16] <barry_> jml: whoa
[03:17] <thumper> barry_: FYI, beuno and I are making reviews rock in LP
[03:17] <barry_> i can has branches on lp?
[03:17] <barry_> thumper, beuno i am very excited to see the results
[03:17] <jml> on the sly, yes.
[03:17] <beuno> barry_, it's very promising  :)
[03:17] <jml> barry_: although make sure you upgrade everything (branches and repos) to 1.6
[03:18] <beuno> it should make the workflow almost natural
[03:18] <barry_> jml: cool.  eta for switching to?
[03:18] <thumper> barry_: also use bzr 1.7 or later
[03:18] <barry_> beuno: eta?
[03:18] <thumper> barry_: and the scanner will choke somewhat until mwhudson's branch is cherrypicked
[03:18] <mwhudson> i guess we could switch in maybe a week?
[03:18] <jml> barry_: there are a few patches we need to land.
[03:19] <jml> depending on how the cherry blossoms fall
[03:19] <beuno> barry_, it depends on thumper's speed and availability, but we should ahve something submitable after this week
[03:19] <barry_> after mwhudson branch is cherrypicked?  if we could do it on or before epic, that would be fantastic
[03:19] <mwhudson> that should be possible for sure
[03:19] <thumper> barry_: within a day or two for production is my guess
[03:20] <barry_> wow. it would be fantastic if we can dogfood all this, kill off devpad branches and PR at epic
[03:21]  * thumper hopes too
[03:21]  * beuno hopes three
[03:21] <thumper> I do have two weeks leave between now and the epic
[03:23] <barry_> cool.  that's about it from me.  queue update, mentor update, action items, blah blah blah
[03:23] <barry_> anything from you guys?  anything you want me to bring up at ameu?
[03:24] <mwhudson> nothing springs to mind
[03:24] <jml> nope
[03:24] <thumper> nada
[03:24] <barry_> cool.  thanks guys.  see you all in 2 weeks.
[03:24] <barry_> #endmeeting
[03:24] <thumper> ok
[03:24] <MootBot> Meeting finished at 21:24.
[03:24] <thumper> later dude
[03:25] <jml> barry_: see ya