=== mrevell is now known as mrevell-lunch === salgado-afk is now known as salgado === cprov1 is now known as cprov === mrevell-lunch is now known as mrevell [15:00] #startmeeting [15:00] Meeting started at 09:01. The chair is barry. [15:00] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:01] me [15:01] hello everybody and welcome to this week's meeting. who's here today [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:01] me [15:02] me [15:02] me [15:03] me [15:03] me [15:04] [TOPIC] agenda [15:04] New Topic: agenda [15:04] barry: Bjorn mentioned that he'll be away this afternoon, maybe he's not back yet [15:04] == Agenda == [15:04] * Roll call [15:04] * Cross-referencing monkey patches in code (intellectronica, bigjools) [15:04] * If there's time, the old boring script [15:04] * Next meeting [15:04] * Action items [15:04] * Queue status [15:04] * Mentoring update [15:05] [TOPIC] * Cross-referencing monkey patches in code (intellectronica, bigjools) [15:05] New Topic: * Cross-referencing monkey patches in code (intellectronica, bigjools) [15:05] intellectronica, bigjools the floor is yours [15:05] ok, i'll go [15:05] * bigjools looks at intellectronica since he added the topic :) [15:06] sometimes we need to monkey patch code [15:06] this became quite frequent since we started exporting stuff to the API [15:07] ? [15:07] circular imports [15:07] since in order to avoid circular imports we often need to amend classes after they're first declared [15:07] intellectronica: can we define "monkey patch" :) [15:07] that,s not monkey patching! [15:07] that's working around circular imports! [15:07] flacoste: ok, since you oobviosly understand what i'm talking about, how about you propose a better definition? [15:07] barry is the master of monkeypatching [15:08] see launchpad/mailman/monkeypaches [15:08] intellectronica: well, you are talking about the working around of circular imports, right? [15:08] flacoste: [15:08] flacoste: yup [15:08] * barry is a patched monkey [15:09] intellectronica: ok, so what is the issue you wanted to raise about this? [15:09] see l/c/l/interfaces/bugtask.py:634 for a representative example of the problem i'm referring to [15:09] so, while working through a problem bigjools and i realised that it's often quite difficult, when you look at the class definition, to know where it's being amended [15:10] and wanted to suggest that we make it a requirement to cross reference the places using comments [15:10] so that next to the general definition, you'll have to add a comment saying where it's being patched [15:11] intellectronica: that seems like good practice to me [15:11] so where we have schema=Interface, # ITeamMembership [15:11] we would have [15:11] schema=Interface, # ITeamMembership, in teammembership.py? [15:12] see interfaces/archive.py for an example of how bac recommended I do this yesterday [15:12] flacoste: yes, maybe even something more specific, as long as it's maintainable [15:12] I think that this fixup requirement is a framework bug. We should allow schema='ITeamMembership' [15:12] flacoste, wild speculation, can Zope 3.4 deferred imports take care of this? [15:12] abentley: you beat me to it. +1 [15:12] abentley: that's a _really_ nice idea [15:12] yes, now that we have zope 3.4, we can look into deferredimport [15:13] eliminating the patch up is definitely the right way to go [15:13] gary reports that it's not necessarily nice [15:13] so if that turns out to be true [15:13] I'm happy with requiring an xreference until that's fixed. [15:13] we should look into supporting schema='canonical.launchpad.interfaces.ITeamMembership' [15:14] agreed. so who can i give an action item to for that? [15:14] foundations [15:14] we can look into deferredimport [15:14] and fix all of them [15:14] otherwise, we'll file a bug [15:15] [ACTION] flacoste & foundations to look into techniques for eliminating back-patching of schema types to avoid circular imports [15:15] ACTION received: flacoste & foundations to look into techniques for eliminating back-patching of schema types to avoid circular imports [15:15] actually, iirc, there is already a bug reported about using deferredimport [15:15] anything else on this topic? [15:16] flacoste: We also have the option of using bzrlib's lazy_import. [15:16] interesting! [15:16] i diN,t know about that one [15:17] * barry wishes python had a standard way of doing it [15:17] barry: What about the one in the email module :-) ? [15:17] abentley: yech :) [15:17] * rockstar notes that barry can make a standard way of doing it with his commit access. [15:17] * bigjools coughs and mentions that even C has a way of doing this [15:18] * barry emits an evil chortle [15:18] that's all the fun stuff on the agenda, so it's boring script time [15:18] [TOPIC] action items [15:18] New Topic: action items [15:18] * barry will move the preimp discussion to the ml [15:19] fail. but i did pull my half written email out of my drafts folder so i'll do that today [15:19] * flacoste to take discussion of rest v. moin to ml [15:19] that will happen once gary finishes his example [15:19] should be soon [15:19] flacoste: excellent, thanks [15:20] * rockstar to take discussion of adding launchpadlib tests for exposed api to ml [15:21] Oh noes! This has been an my TODO list for a week! I will start the discussion now. [15:21] rockstar: thanks! [15:21] * abentley to investigate current code coverage tools for lp tests [15:21] barry: I haven't done this yet. [15:22] abentley: np, we'll just carry it over [15:22] abentley: ISTR allenap did something related to this a way back. [15:22] Unless I remember incorrectly. [15:22] abentley: So it might be worth tapping his newly-returned cranium for information. [15:22] abentley: gmb: allenap did! [15:23] Thank you, Launchpad team historian. [15:23] :) [15:24] [TOPIC] * Queue status [15:24] New Topic: * Queue status [15:24] any comments on the queue? either the review queue, pqm, etc. [15:25] Apart from the occasional overnight buildup [15:25] (AMEU time) [15:25] The queue is very manageable at the moment. [15:26] (At least ona Thursday) [15:26] we've got more reviewers, that really helps [15:26] btw, i'm hoping that by epic we can try merge proposals again. the redesigned u/i really looks great [15:26] intellectronica: indeed. [15:27] barry, that should land soon [15:27] rockstar, abentley: correct me if i'm wrong, but diffs are still a ways away [15:27] * rockstar looks at abentley [15:27] barry: Hard to say. [15:28] Database patches... :) [15:28] ah :) [15:28] I'll be implementing diffs this week or next, I think. [15:28] abentley: will that include diffstats? [15:29] barry: Not initially. [15:30] * bigjools has to duck out now [15:30] cool, thanks [15:30] [TOPIC] * Mentoring update [15:30] New Topic: * Mentoring update [15:30] any feedback here? [15:31] barry: mars is doing an exceelent job. [15:31] rockstar continues doing a great job [15:31] Not all that many reviews to do, sadly. [15:31] * rockstar feels warm inside [15:31] * gmb hands rockstar an antacid [15:31] * barry feels bad that he's missed abentley's last few sessions [15:32] abentley: we'll get back on track after epic [15:32] barry: We managed alright. [15:32] abentley: yep, appreciated! [15:32] The big problem was getting attention from Rinchen and kiko the first time, when I didn't know what to do. [15:33] yep, they're busy guys :) [15:33] anyway, that's all i have today. do you have any topics not on the agenda? [15:33] Negative [15:33] barry: No. [15:34] okie dokie! have a great week everybody and thanks for coming [15:34] #endmeeting [15:34] Meeting finished at 09:34. [15:34] Thanks barry. === salgado is now known as salgado-lunch === salgado-lunch is now known as salgado === salgado is now known as salgado-afk