[00:03] <CIA-52> cdrom-detect: cjwatson * r429 ubuntu/debian/ (53 files in 2 dirs): Update Ubuntu-specific strings from Launchpad.
[00:04] <CIA-52> cdrom-detect: cjwatson * r430 ubuntu/debian/changelog: releasing version 1.28ubuntu3
[00:06] <cjwatson> I almost have this entirely scripted now ...
[00:06] <CIA-52> partman-auto: cjwatson * r272 ubuntu/debian/ (56 files in 2 dirs): Update Ubuntu-specific strings from Launchpad.
[00:07] <CIA-52> partman-auto: cjwatson * r273 ubuntu/debian/changelog: releasing version 78ubuntu3
[00:12] <CIA-52> partman-target: cjwatson * r731 ubuntu/debian/ (38 files in 2 dirs): Update Ubuntu-specific strings from Launchpad.
[00:13] <CIA-52> partman-target: cjwatson * r732 ubuntu/debian/changelog: releasing version 55ubuntu4
[00:14] <CIA-52> pkgsel: cjwatson * r125 ubuntu/debian/ (51 files in 2 dirs): Update Ubuntu-specific strings from Launchpad.
[00:15] <CIA-52> pkgsel: cjwatson * r126 ubuntu/debian/changelog: releasing version 0.20ubuntu10
[00:19] <CIA-52> oem-config: cjwatson * r539 oem-config/debian/ (9 files in 2 dirs): Update translations from Launchpad.
[07:34] <CIA-52> partman-base: evand * r110 partman-base.trunk/ (debian/changelog debian/partman-base.templates init.d/parted):
[07:34] <CIA-52> partman-base: Exclude devices that have mounted partitions. Useful for when installing
[07:34] <CIA-52> partman-base: from a disk (LP: #276656). This can be disabled by preseeding
[07:34] <CIA-52> partman-base: partman/filter_mounted to false.
[07:42] <CIA-52> partman-base: evand * r111 ubuntu/debian/changelog: releasing version 121ubuntu7
[07:47]  * evand is perplexed by debian/rules in grub removing files it has checked into bzr.
[08:15] <evand> cjwatson: I'd appreciate it if you could take a look at bug 282037 when you get back to work.  I think my latter proposal is sound, but would like a second opinion.
[21:04] <CIA-52> oem-config: cjwatson * r540 oem-config/ (d-i/manifest debian/changelog): Automatic update of included source packages: user-setup 1.20ubuntu9.
[21:25] <CIA-52> oem-config: cjwatson * r541 oem-config/ (10 files in 7 dirs): bump to 1.51
[21:29] <CIA-52> oem-config: cjwatson * r542 oem-config/debian/changelog: releasing version 1.51
[21:51] <evand> A heads up, I'll be uploading a new ubiquity tonight, after grub 0.97-29ubuntu41 hits the archive.  Please let me know if anyone wants me to hold off on doing this for a few hours so they can get some last minute changes in.
[22:01] <StevenK> evand: That will include the grub-installer changes so I can drop the hideous seed hack for -mid?
[22:09] <evand> StevenK: which grub-installer changes?
[22:11] <cjwatson> evand: I think your general approach in bug 282037 is fine, although I'm not absolutely sure about the grub-installer patch there. Is it possible that it should look more like the bootremovable stuff in the state=1 branch?
[22:12] <cjwatson> evand: and how does said bootremovable stuff interact with ubiquity's boot device display? Maybe we ought to rip that out and do the whole thing differently, but we'd still have to make sure to cover both state=1 (only) and state=2 branches ...
[22:13] <evand> cjwatson: Do you mean by default installing grub to the disk you're installing Ubuntu to, or only doing so when we know hd0 isn't correct, when it would be installing to the installation medium MBR?
[22:13] <evand> state=1?
[22:14] <cjwatson> well, I meant that it seems that in state=2 you want the default to be "install to MBR"
[22:15] <cjwatson> which is the same as what you want if you answer true to the question in state=1
[22:15] <cjwatson> I mean the 'if [ "$state" = 1 ]' conditional that starts at line 592
[22:15]  * evand digs
[22:15] <cjwatson> so it seems that both of those cases ought to be handled the same way
[22:17] <cjwatson> I suspect the reason we didn't notice what was wrong for years was that we thought we'd handled it with that $bootremovable business, but actually that only applies if state=1 is taken
[22:17] <cjwatson> while it might actually be bypassed
[22:19] <evand> ah
[22:20] <cjwatson> like I say I think your basic idea is right though
[22:20] <evand> can you clarify which one though?  I proposed two options, one to always go with the device Ubuntu is being installed to, and the other to go with the device Ubuntu is being installed to if hd0 is the installation medium.
[22:21] <evand> I suspect the latter, but I want to be sure.
[22:39] <cjwatson> oh, right, um.
[22:39] <cjwatson> given the difficulty of detecting what hd0 is it's really hard to say.
[22:40] <cjwatson> for the time being, I think it may make some sense to special-case installs from USB disks, since then we know that the installation medium is about to be removed and putting the boot loader there will be bad
[22:40] <cjwatson> i.e. I think your second option is probably better
[22:41] <cjwatson> an example where the first option would fall down would be if you're installing to a second hard disk, where I think the sensible default is to put the boot loader where the BIOS is actually going to boot from, i.e. the first hard disk
[22:42] <cjwatson> of course this won't please everyone and some people will call me names for saying the above is the sensible default, but that's why we make it selectable :)
[23:38] <evand> indeed, that's the exact example I was thinking of.  Ok, noted.  I'll rework the patch to accomodate this and take another look at handling all states in grub-installer.
[23:51] <StevenK> evand: The grub-installer changes for lpia == i686