| === Moot2 is now known as MootBot | ||
| === allenap1 is now known as allenap | ||
| === mrevell is now known as mrevell-lunch | ||
| === mrevell-lunch is now known as mrevell | ||
| === salgado-brb is now known as salgado | ||
| barry | #startmeeting | 15:00 |
|---|---|---|
| MootBot | Meeting started at 09:00. The chair is barry. | 15:00 |
| MootBot | Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] | 15:00 |
| barry | hi everybody and welcome to this week's reviewers meeting. who's here today? | 15:00 |
| intellectronica | me | 15:00 |
| bigjools | me | 15:00 |
| gmb | me | 15:00 |
| sinzui | me | 15:01 |
| allenap | me | 15:01 |
| bac | me | 15:01 |
| salgado | me | 15:01 |
| flacoste | me | 15:01 |
| cprov | me | 15:01 |
| EdwinGrubbs | me | 15:02 |
| barry | BjornT_ danilos ping | 15:03 |
| danilos | me | 15:03 |
| danilos | (I have my reminder set for an hour earlier, and then always miss out the real beginning; with DST soon to be off, I should be a regular :)) | 15:03 |
| barry | mars: rockstar ping | 15:04 |
| BjornT_ | me | 15:04 |
| barry | [TOPIC] agenda | 15:05 |
| MootBot | New Topic: agenda | 15:05 |
| barry | * Roll call | 15:05 |
| barry | * If there's time, the old boring script | 15:05 |
| barry | * Next meeting | 15:05 |
| barry | * f2f at epic? | 15:05 |
| barry | * Action items | 15:05 |
| barry | * Queue status | 15:05 |
| barry | * Mentoring update | 15:05 |
| barry | [TOPIC] next meeting | 15:05 |
| MootBot | New Topic: next meeting | 15:05 |
| danilos | corner of Kings Cross and... | 15:05 |
| barry | since we'll all be in london the next two weeks, i propose we suspend the irc meetings and try to find a time to meet f2f | 15:06 |
| danilos | +1 | 15:06 |
| bigjools | danilos: are you planning on kerb crawling then? :) | 15:06 |
| barry | we can talk about things to make the meetings better, improve pollination w/asiapac, ways to improve review process, etc | 15:06 |
| abentley | barry: +1 | 15:06 |
| gmb | +1 | 15:07 |
| intellectronica | +1 | 15:07 |
| sinzui | +1 | 15:07 |
| gmb | bigjools: Either that or he'll be getting mugged, depending on whom he encounters first. | 15:07 |
| bigjools | gmb: the pimp or the ho | 15:07 |
| barry | ouch | 15:07 |
| barry | :) | 15:07 |
| danilos | gmb: I am going for an attempted robbery, i.e. someone should try to rob me :) | 15:07 |
| gmb | bigjools: Mind you, danilos is a big fella, he should be safe. | 15:07 |
| gmb | Hah. | 15:07 |
| gmb | danilos: My point exactly ;) | 15:08 |
| barry | [AGREED] suspend next two weeks irc in favor of f2f in london | 15:08 |
| MootBot | AGREED received: suspend next two weeks irc in favor of f2f in london | 15:08 |
| barry | [TOPIC] action items | 15:08 |
| MootBot | New Topic: action items | 15:08 |
| barry | * flacoste and foundations to look into techniques for eliminating back-patching of schema types (avoiding circular imports) | 15:08 |
| flacoste | carry over | 15:08 |
| barry | done | 15:09 |
| barry | * barry will move the preimp discussion to the ml | 15:09 |
| barry | i suck and propose we just any related issues over at epic | 15:09 |
| barry | * flacoste to take discussion of rest v. moin to ml | 15:10 |
| barry | flacoste: any word on gary's experiment? | 15:10 |
| intellectronica | when you push things to the epic, it's probably a good idea to try and actually schedule it. from what i saw there's a pretty dense plan | 15:10 |
| flacoste | gary is progressing | 15:10 |
| flacoste | he should be finished today | 15:10 |
| barry | intellectronica: good oint | 15:10 |
| flacoste | and we will send an email to the list then | 15:10 |
| barry | flacoste: excellent, thanks | 15:10 |
| barry | [ACTION] barry will schedule reveiwers meeting at epic | 15:10 |
| MootBot | ACTION received: barry will schedule reveiwers meeting at epic | 15:10 |
| barry | * rockstar to take discussion of adding launchpadlib tests for exposed api to ml | 15:11 |
| * barry pokes rockstar | 15:12 | |
| intellectronica | fwiw i just got another bug in today which only happens with lplib and which tests like this would have caught ;) | 15:12 |
| barry | oh well, let's move on then ;) | 15:13 |
| barry | * abentley to investigate current code coverage tools for lp tests | 15:13 |
| abentley | I looked at the existing stuff, and it seems like the opposite of what I want. | 15:13 |
| abentley | I want to know if the tests run by a test command exercise all new code. | 15:14 |
| abentley | The existing work is about determining which tests exercise a given line of code. | 15:14 |
| danilos | abentley: at what granularity? | 15:14 |
| danilos | abentley: so, method or line of code for the opposite direction as well? | 15:15 |
| abentley | danilos: Ideally, just yes/no granularity. Either the changes are properly tested or they're not. | 15:15 |
| abentley | So the obvious implementation is: run the tests with coverage calculation, determine which lines are new, make sure they're covered. | 15:17 |
| barry | abentley: tho iwbn to know which lines /aren't/ covered | 15:17 |
| abentley | barry: Sure. | 15:18 |
| barry | abentley: any thoughts on putting something like this together? | 15:18 |
| abentley | barry: You mean, am I willing to do it? | 15:19 |
| barry | abentley: jfdi, man! | 15:19 |
| abentley | barry: I guess I could hack on it on review day. | 15:21 |
| BjornT_ | abentley: in what way does --coverage do the opposite of you want? it seems to tell you which lines are tested, and which aren't. that should be the first step in what you want, isn't it? | 15:21 |
| abentley | BjornT_: I'm not saying --coverage does. | 15:21 |
| BjornT_ | abentley: oh. you said the existing tools did the opposite. i assumed you meant --coverage. | 15:22 |
| abentley | BjornT_: I was talking about launchpad-specific work that someone did that I was pointed at last week. | 15:22 |
| BjornT_ | ah, right | 15:23 |
| barry | abentley: well if you have time, i think it would be a useful tool | 15:23 |
| barry | anyway, that's all i have for today. does anybody have topics not on the agenda? | 15:25 |
| abentley | BjornT_: https://launchpad.canonical.com/TestsFromChanges | 15:25 |
| barry | okay then, thanks everyone and see you next time in london! | 15:27 |
| barry | #endmeeting | 15:27 |
| MootBot | Meeting finished at 09:27. | 15:27 |
| bigjools | see y'all in The Smoke | 15:28 |
| === salgado is now known as salgado-lunch | ||
| === cprov is now known as cprov-lunch | ||
| === salgado-lunch is now known as salgado | ||
| === cprov-lunch is now known as cprov | ||
| === salgado is now known as salgado-afk | ||
| jml | hi | 23:36 |
| mwhudson | barry isn't here :) | 23:36 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!