barry | #startmeeting | 03:01 |
---|---|---|
MootBot | Meeting started at 21:01. The chair is barry. | 03:01 |
MootBot | Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] | 03:01 |
barry | hi folks, welcome to this week's asiapac launchpad reviewers meeting. who's here today? | 03:02 |
barry | jml, thumper ping | 03:03 |
jml | hi | 03:03 |
thumper | here late | 03:03 |
jml | wow, it's that time already. | 03:03 |
thumper | phew | 03:04 |
barry | no worries, i almost didn't make it either :) | 03:04 |
barry | [TOPIC] agenda | 03:04 |
MootBot | New Topic: agenda | 03:04 |
barry | * Roll call | 03:04 |
barry | * Watch out for queries in intermediate tables. -- salgado | 03:04 |
barry | * Using merge proposals again -- barry | 03:04 |
barry | * If there's time, the old boring script | 03:04 |
barry | * Next meeting | 03:04 |
barry | * Action items | 03:04 |
barry | * Queue status | 03:05 |
barry | * Mentoring update | 03:05 |
barry | [TOPIC] * Watch out for queries in intermediate tables. -- salgado | 03:05 |
MootBot | New Topic: * Watch out for queries in intermediate tables. -- salgado | 03:05 |
barry | i think you both understand this one. salgado was warning to watch about about problematic queries where you'd end up hitting e.g. the person table in a python iteration | 03:06 |
barry | e.g. one query per person | 03:06 |
jml | yes. | 03:06 |
thumper | ack | 03:06 |
barry | [TOPIC] * Using merge proposals again -- barry | 03:06 |
MootBot | New Topic: * Using merge proposals again -- barry | 03:06 |
barry | so, with your ack, we'll go back to using m-p's again | 03:07 |
thumper | ok | 03:07 |
thumper | I do have one nit | 03:07 |
barry | i think everybody wants to; bjornt had some reservations | 03:07 |
barry | thumper: go ahead | 03:07 |
thumper | and that some bugs are being filed as "adoption-blockers" when I don't think they are | 03:07 |
thumper | we can fix the minor things relatively easily | 03:07 |
thumper | but we shouldn't block on them | 03:07 |
thumper | that's it | 03:08 |
jml | there are still problems with blueprints and bugs that I would list as adoption blockers :) | 03:08 |
barry | we can debate that in the specific bug, right? | 03:08 |
thumper | sure | 03:08 |
thumper | or I might just remove the tag | 03:08 |
thumper | :) | 03:08 |
barry | thumper: yeah, you and the OP can fight it out :) | 03:08 |
* barry personally has no adoption blockers here :) | 03:08 | |
thumper | good | 03:09 |
barry | thumper: did you see BjornT's major reservation about going all-in? | 03:09 |
thumper | I may have missed it | 03:09 |
thumper | what is it? | 03:09 |
barry | that an email response with a cc adds the cc recipient as a nosy listener | 03:09 |
barry | or maybe as a reviewer | 03:10 |
thumper | ok, here is what I think on that... | 03:10 |
thumper | you can still add someone to a CC | 03:10 |
thumper | and they'll get the email | 03:10 |
thumper | everyone should be on the review mailing list anyway | 03:10 |
thumper | anyone can repsond | 03:10 |
thumper | and people can comment anyway | 03:11 |
thumper | we could easily add an "email command" to add a reviewer | 03:11 |
barry | and as long as the m-p email is on the recipients, it'll make it in a comment, right? | 03:11 |
thumper | right | 03:11 |
* thumper thinks | 03:11 | |
thumper | I don't think it has to be a TO | 03:11 |
thumper | although I may be wrong on that | 03:11 |
thumper | I'd have to check | 03:11 |
thumper | if it doesn't work | 03:11 |
thumper | it is a bug | 03:11 |
barry | cool, we'll let BjornT (or whoever) file a bug | 03:12 |
* thumper nods | 03:12 | |
* thumper is guessing that jml is almost asleep in front of his laptop | 03:13 | |
jml | not asleep | 03:13 |
thumper | I did say "almost" | 03:13 |
barry | personally, i think adding apis and improving review-submit is a bigger bang for the buck | 03:13 |
barry | that and diffs :) | 03:13 |
jml | but let's just say I'm not going to be doing anything involving either monads or threads today | 03:13 |
thumper | diffs are blocked on a db patch that is being reviewed | 03:13 |
jml | barry: I think we should pretty much stop investing in review-submit | 03:13 |
thumper | api is being worked on by rockstar | 03:14 |
barry | thumper: think that might happen this cycle? | 03:14 |
* rockstar perks up | 03:14 | |
thumper | barry: db patch? I'm not holding my breath | 03:14 |
barry | jml: review-submit could be made largely launchpad project agnostic and then it would be generally of coolness | 03:14 |
barry | thumper: heh | 03:14 |
thumper | barry: bzr send will work soon | 03:14 |
* barry is not sure he can type clearly today | 03:14 | |
jml | barry: in the general, I agree with you | 03:15 |
thumper | barry: although some people still want a synchronous review submit | 03:15 |
thumper | barry: which will probably use apis | 03:15 |
jml | barry: but more specifically, there's already a plugin for bzr interacting with Launchpad | 03:15 |
thumper | jml: I'd like our lp plugin to use launchpadlib lazily if it can | 03:15 |
jml | barry: and there's already a built-in command for submitting changes | 03:15 |
barry | thumper: we want cover letter submission too. i would think review-submit could call bzr send, but it would be alittle more (then maybe it would be lp specific again) | 03:16 |
jml | thumper: implementation detail, I think. | 03:16 |
thumper | barry: the merge directive can contain text in the email | 03:16 |
thumper | barry: that could become the initial message | 03:16 |
barry | very interesting | 03:16 |
jml | right. it's just a simple matter of adding an option to send to have a template | 03:16 |
thumper | jml: interesting idea there... | 03:16 |
barry | you'll definitely have to explain it all to us when that lands :) | 03:16 |
jml | and then a wrapper script or hooks or whatever to do those checks that we all love :) | 03:16 |
barry | jml: yeah, that would be cool | 03:17 |
jml | thumper: it's aaron's idea, I think. | 03:17 |
jml | barry: but essentially what I mean is, almost everything we need already exists in public code, so we should build out from there rather than re-implement and then open source. | 03:17 |
barry | jml: +1 | 03:17 |
jml | :) | 03:18 |
barry | jml: jfdi | 03:18 |
barry | :) | 03:18 |
* jml really wants that db patch in | 03:18 | |
thumper | barry: we are waiting on that db patch | 03:18 |
thumper | ... | 03:18 |
jml | it's going to make life so much better. | 03:18 |
barry | eafp <wink> | 03:18 |
thumper | ?!? | 03:18 |
jml | eat a fine prune? | 03:19 |
barry | er, bad acronym | 03:19 |
barry | never mind ;) | 03:19 |
thumper | ask for forgiveness? | 03:19 |
jml | engage all forward pulses? | 03:19 |
barry | thumper: yeah, that one :) | 03:19 |
thumper | barry: so JFDI | 03:19 |
* barry calls pqm-submit | 03:19 | |
thumper | barry: there are some limits to requesting forgiveness I think | 03:19 |
barry | thumper: sometimes the answer may be "no" ;) | 03:20 |
thumper | barry: heh, yeah | 03:20 |
barry | anyway. martin and curtis were here today sprint on other stuff. we talked about m-ps and recognize there are things to clean up, but it's still a huge win imo | 03:21 |
barry | and totally usable as is | 03:21 |
barry | and what part of lp /doesn't/ need improvement? ;) | 03:21 |
jml | right. | 03:21 |
thumper | right | 03:21 |
thumper | jml: snap | 03:21 |
jml | and if we don't dogfood | 03:21 |
jml | ... | 03:22 |
barry | 'zackly | 03:22 |
jml | (then it's not like the bazaar guys will) | 03:22 |
thumper | jml: +1 | 03:22 |
barry | did you see the bug with signature checks i submitted? | 03:22 |
thumper | nope | 03:22 |
* barry searches... | 03:23 | |
jml | thumper: actually, I might do some bug triage this arvo. We have a lot of New bugs and I'm not likely to do anything more useful. | 03:24 |
thumper | jml: ok | 03:24 |
barry | jeebus i can't find it now | 03:24 |
barry | it got duped | 03:24 |
barry | bug 211830 | 03:25 |
ubottu | Launchpad bug 211830 in malone "OOPS using email interface with a expired gpg key" [Low,Confirmed] https://launchpad.net/bugs/211830 | 03:25 |
barry | and my key isn't expired | 03:26 |
barry | annyyyway | 03:26 |
thumper | barry: do you have an oops id? | 03:26 |
barry | OOPS-1045CEMAIL12 | 03:27 |
thumper | ta | 03:27 |
barry | so i really don't have anything else today. anything on your side? | 03:27 |
thumper | nope | 03:28 |
barry | you guys all recovered from epic? :) | 03:28 |
jml | I'm still recovering from jetlag :) | 03:28 |
barry | :) | 03:28 |
thumper | yeah mostly | 03:28 |
thumper | last week wasn't much fun | 03:28 |
barry | martin took about 20 hours to get here from madrid i think, through zurich and montreal | 03:29 |
thumper | heh | 03:29 |
thumper | yeah | 03:29 |
barry | thumper: i think i sleep hacked my way through last week | 03:29 |
thumper | but martin loves flying | 03:29 |
thumper | I wish I had time to hack | 03:29 |
barry | yeah... not so much :) | 03:29 |
barry | thumper: you're a phb now. no hacking for you | 03:29 |
thumper | :( | 03:29 |
* thumper is going to shave his head | 03:30 | |
* jml already has. | 03:30 | |
* thumper wants photo evidence | 03:30 | |
thumper | barry: I think we're done | 03:30 |
barry | indeed :) | 03:30 |
barry | thanks guys | 03:30 |
barry | #endmeeting | 03:30 |
MootBot | Meeting finished at 21:30. | 03:30 |
jml | if only cheese wasn't terrible. | 03:30 |
thumper | thanks barry | 03:30 |
jml | barry: thanks. | 03:30 |
=== cprov is now known as cprov-zzz | ||
=== salgado-afk is now known as salgado | ||
=== mrevell is now known as mrevell-lunch | ||
=== mrevell-lunch is now known as mrevel | ||
=== salgado is now known as salgado-lunch | ||
=== mrevel is now known as mrevell | ||
=== salgado is now known as salgado-afk |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!