=== bac is now known as bac_afk === bac_afk is now known as bac === mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell === vednis is now known as mars [15:00] #startmeeting [15:00] Meeting started at 09:00. The chair is barry. [15:00] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:00] hello everyone and welcome to this week's ameu reviewer's meeting. who's here today? [15:00] me [15:00] me [15:00] me [15:00] me [15:00] me [15:00] me, but only half (sprinting in Lexington) [15:00] me [15:01] allenap: m ? [15:01] me [15:01] abentley: This week it's e [15:01] me [15:02] me [15:02] [TOPIC] agenda [15:02] New Topic: agenda [15:02] i don't have much today... [15:02] * Roll call [15:02] * Agreement on statuses: [15:02] * needs-reply == needs-fixing [15:02] * merge-approved == approve [15:02] * merge-conditional == approve + comment [15:02] * If there's time, the old boring script [15:02] * Next meeting [15:02] * Action items [15:02] * Queue status [15:03] * Mentoring update [15:03] [TOPIC] * Agreement on statuses: [15:03] New Topic: * Agreement on statuses: [15:03] me [15:03] me [15:03] at the asiapac meeting, i explained what we'd agreed from last week on the mapping between our review status and m-p statuses [15:03] everyone there agreed with our mapping [15:03] so i guess that makes it official [15:04] any comments or other thoughts? [15:04] can you remind us of that mapping? [15:04] flacoste: it's up in the agenda [15:04] :) [15:04] doh [15:05] :) [15:06] silence is assent :) [15:06] that's all i have except for the boring stuff. does anybody have anything not on the agenda? [15:06] yeah [15:07] I wonder about how do we see if there are branches waiting for review in merge-proposals? [15:07] danilos: the floor is yours [15:07] danilos: they mythical dashboard [15:07] I've tried digging that up, but was unable to find it once I cleared general queue yesterday [15:07] s/they/the/ [15:07] ok, so it's actually not there? [15:08] can we maybe agree to put branches in 'Mature' until it's there? [15:08] or some other status [15:08] danilos: Other that this: https://code.edge.launchpad.net/~launchpad-pqm/launchpad/devel/+merges ? [15:09] abentley: that doesn't show me only unassigned ones [15:09] abentley: that's a good page. i can already tell that the separate approve step doesn't work 'cause no one set it ;/ [15:09] * sinzui forgot to type me [15:09] me [15:10] danilos: All of them will be assigned to Launchpad Developers by default. [15:11] abentley: ok, so the only missing bit is that we need to update merge proposal statuses to 'Approved', right? [15:12] me [15:12] and, can we make this URL more visible? I tried getting something along those lines [15:12] danilos: Right. When they're reviewed, and ready to be merged. [15:13] danilos: It's the "12 branches proposed for merging into this one." link on https://code.edge.launchpad.net/~launchpad-pqm/launchpad/devel [15:13] abentley: ok, thanks [15:13] anything else? [15:13] so, my suggestion would be to make reviewers set "Approved" as well [15:13] barry: nope, that's it from me [15:14] danilos: + [15:14] + [15:14] barry: How do I subscribe to the new wiki page? [15:14] jeebus. +1 [15:14] abentley: that's a very good question. i tried to find it and couldn't [15:14] you can't! the price of progress ... [15:14] * barry has a BIG LIST of issues with the new wiki [15:14] +1. Thought that was already done. [15:15] abentley: go to your profile page, scroll down to subscriptions and add .* to the list :) [15:15] abentley: there's a bug for it, we talked about it yesterday. [15:16] rockstar: a bug for wiki subscription? [15:17] someone wake rockstar :) [15:17] anyway... [15:18] if there's nothing else, i just want to run through the outstanding action items from like, last decade [15:18] barry: i have a small agenda item as well (or rather a question) [15:18] BjornT: cool, go ahead [15:19] when are we going to evaluate how the merge proposals are going, and which issues are the most important (for the LP team as a whole) to fix? [15:20] BjornT: great question. i'm inclined to say let's do the evaluation at the beginning of '09. your thoughts? [15:20] barry: well, i was hoping sooner, so that we could get the most important fixes in the next milestone :) [15:21] BjornT: :) [15:21] BjornT: i'm okay with that. what about doing that for the next round of reviewer meetings? [15:22] barry: sure [15:22] iow, people should come prepared to discuss/lobby for their top m-p bugs [15:22] diffs plz [15:22] we can spend next week's meeting prioritizing them for us [15:23] bigjools: bug numbers plz :) [15:23] haha :) [15:23] barry: maybe we should tell everyone to pick their 1-2 top bugs, in an attempt to limit the discussions? [15:23] BjornT: yes, good idea [15:24] barry: We can decide here what lp reviewers consider high priority. Please don't expect the code team to adopt those priorities verbatim. [15:24] abentley: that's for sure [15:24] [ACTION] everyone come to next week's meeting with your top 1-2 merge-proposal bug numbers [15:24] ACTION received: everyone come to next week's meeting with your top 1-2 merge-proposal bug numbers [15:24] abentley: right [15:24] barry: Or alternatively, we could have a meeting where thumper was involved. [15:25] abentley: we should do that, but only after we've agreed among ourselves [15:25] And then the outcome might be clearer. [15:25] abentley: and remember i have asiapac meetings with thumper and co on monday nights (i know you know that :) [15:25] well, /my/ monday nights [15:26] abentley: agreed, the priorities we come up with here only serves for guidelines. i don't think thumper needs to be in this meeting. [15:26] Okay. [15:26] any other topics not on the agenda? [15:27] * bigjools raises hand [15:27] can I nominate a new reviewer? [15:27] bigjools: of course! [15:27] good - Muharem wants to start. [15:28] he's looking for a mentor right now [15:28] OAO [15:29] bigjools: +1. let me know if he can't round someone up [15:29] copy that [15:29] anything else? [15:30] 5...4...3...2...1 [15:30] [TOPIC] action items [15:30] New Topic: action items [15:30] please tell me if we should continue these or just forget they ever happened [15:30] * flacoste and foundations to look into techniques for eliminating back-patching of schema types (avoiding circular imports) [15:30] * bigjools would love that --^ [15:30] * barry too, and he doesn't think it's that hard [15:30] hmm, yeah, i forgot about that [15:31] barry, patch is welcome ;-) [15:31] flacoste: ah, a challenge! :) [15:31] wow, OSS fever :) [15:31] flacoste: sounds like the perfect thing to do while on hold waiting for your isp to un-fsck you [15:32] so we'll continue that one [15:32] * rockstar to take discussion of adding launchpadlib tests for exposed api to ml [15:32] * barry thinks rockstar fell asleep again :) [15:32] * abentley to investigate current code coverage tools for lp tests [15:33] barry, well, we discussed it at the Epic. [15:33] Current tools don't do what I want. [15:34] rockstar: good. i will remove it from the agenda! thanks [15:34] abentley: cool, you've investigated so i can take it off the agenda :) [15:35] rockstar: could you file a bug about allowing launchpadlib to speak directly to the publisher for testing purpose? [15:35] flacoste, sure. [15:35] What I want is a way to know whether a given test command exercises all the new code in a patch. [15:35] rockstar: that's the main blocker to allow this [15:35] Okay. [15:36] i think that's it. if there are no objections we can end early today [15:36] 5 [15:37] 4 [15:37] 3 [15:37] 2 [15:37] 1 [15:37] #endmeeting [15:37] Meeting finished at 09:37. [15:37] thanks everyone! [15:37] cheers [15:38] thanks barry [15:38] see ya back at the ranch === mrevell_ is now known as mrevell === bac is now known as bac_lunch === bac_lunch is now known as bac === cprov-lunch is now known as cprov === spm_ is now known as spm