=== Rinchen`` is now known as Rinchen === Rinchen`` is now known as Rinchen === Rinchen` is now known as Rinchen === salgado-afk is now known as salgado === mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell === bac_afk is now known as bac [15:00] #startmeeting [15:00] Meeting started at 09:00. The chair is barry. [15:00] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:00] me [15:00] me [15:00] hello everyone and welcome to this week's ameu reviewers meeting [15:00] who's here today? [15:00] me [15:00] me [15:00] me [15:00] me [15:00] argh [15:01] vednis: going old skool today? === vednis is now known as mars [15:01] barry, ghostbusting [15:01] me [15:01] :) [15:02] me [15:02] me [15:02] allenap: ping [15:03] BjornT, cprov, danilos ping [15:03] me [15:03] barry: BjornT is on leave today [15:03] gmb: ping [15:03] intellectronica: thanks [15:03] me [15:03] Thanks barry [15:03] me [15:03] [TOPIC] agenda [15:03] New Topic: agenda [15:04] * Roll call [15:04] * Last meeting of the year? [15:04] * Don't forget to add find-entry-uri rules when exposing new stuff in the API. See [[https://launchpad.canonical.com/API/StyleGuide#Update%20the%20XSLT%20stylesheet|API Style Guide >> Update the XSLT stylesheet]]. -- ''allenap'' [15:04] * Peanut gallery (anything not on the agenda) [15:04] * Action items [15:04] barry: thanks (I forgot) [15:04] * Mentoring update [15:04] np [15:04] [TOPIC] last meeting of the year [15:04] New Topic: last meeting of the year [15:04] do you guys want to meet on the 24th? i don't think i do :) [15:04] shall we make this the last meeting of 08? [15:04] Nope [15:04] i'm on leave, so +1 [15:04] I'll probably be out on the 24th [15:05] any objections? [15:05] 5... 4... 3... 2... [15:05] 1 [15:05] done [15:05] [TOPIC] * Don't forget to add find-entry-uri rules when exposing new stuff in the API. See [[https://launchpad.canonical.com/API/StyleGuide#Update%20the%20XSLT%20stylesheet|API Style Guide >> Update the XSLT stylesheet]]. -- ''allenap'' [15:05] New Topic: * Don't forget to add find-entry-uri rules when exposing new stuff in the API. See [[https://launchpad.canonical.com/API/StyleGuide#Update%20the%20XSLT%20stylesheet|API Style Guide >> Update the XSLT stylesheet]]. -- ''allenap'' [15:05] allenap: the floor is yours [15:06] * gmb blinks [15:06] He never me'd, but I asked him to put this on here, so I know what it's about... [15:07] rockstar: i missed that he didn't mii, but go ahead [15:07] Sorry I'm late. My CHR day, so schedule's a little off. [15:07] abentley: no worries! [15:07] Well, earlier in the cycle, I landed a branch exposing the bmps to the APIp [15:08] -p [15:08] I didn't update the XSLT stylesheet though, because I didn't know about it, and my reviewer didn't ask about it. [15:09] So allenap landed a branch with a bunch of new changes because it seemed I wasn't the only one (I reviewed the branch) [15:09] yes [15:09] that would have been part of my API reviewer cheat-sheet [15:09] So I just want to remind everyone to make sure the wsdl file gets updated on API changes. [15:09] (which I didn't do, so I suck) [15:10] the posted link does not work for me. is it available on the new wiki? [15:10] No idea. [15:10] doubtful [15:10] nobody moved this yet [15:10] i really need to spend some time moving the dev resources over to the new wiki [15:10] afaik [15:10] rockstar: is it possible to make `lint` complain about it ? [15:10] well [15:10] there is a gotcha abohut this [15:11] in the sense that the XSLT file lives in a separate branch [15:11] it's in the launchpadlib branch [15:11] not on the launchpad branch [15:11] the rationale for having it on launchpadlib was that some users asked for it [15:11] Maybe just asking about updating it is enough. We are all pretty honorable. [15:11] and we were hoping for community contrib on it [15:11] i agree with rockstar [15:12] I mean, if my reviewer asked about it, at least I would have known about it. [15:12] barry: Yeah, I've been meaning to move the developer documentation over, but I wanted to make sure it was all kosher. [15:12] And it would at least be a good reminder. [15:13] abentley: i think it could use some gardening along the way, but if you're bored, go for it! :) [15:13] well, if we don't have a code check it's very likely that even the most honorable programmer will forget to do it once in while. [15:13] but I'm fine with it being part of the dev & reviewers guidelines. [15:13] if devs don't remember it needs to be updated, it's likely some reviewers will also not remember [15:13] * barry looks in mirror [15:14] cprov: i definitely think that's a good start [15:14] barry: I'm meaning https://launchpad.canonical.com/DeveloperDocumentation, and it seems pretty clean to me. [15:14] flacoste: can we just pawn this one off on you too as part of the api reviewer cheatsheet? [15:14] barry: sure [15:15] abentley: oh yeah, that looks fine. it would be great to move those over. the reviewer ones need more gardening [15:15] flacoste: thanks [15:15] abentley: thanks [15:15] anything else on this topic? [15:16] [TOPIC] * Peanut gallery (anything not on the agenda) [15:16] New Topic: * Peanut gallery (anything not on the agenda) [15:16] the floor is open. do you have anything else to discuss today? [15:17] barry: bzr send. [15:17] abentley: give me some good news! [15:17] yay! [15:18] When the next rev of launchpad goes live, "bzr send --no-bundle --mail-to merge@code.launchpad.net" should Just Work. [15:18] awesome! [15:18] Woot! [15:19] It will create a merge directive attached to an email in your configured mail client. [15:19] The body of that email will be used as an initial comment. [15:19] this is great [15:19] this is fantastic [15:19] The diff in the merge directive will be attached as the review diff. [15:19] so we could upgrade lpreview on top of that [15:19] flacoste: +1 [15:19] * mars can see that becoming a new alias in his bazaar.conf [15:20] to integrate the lint and other stuff [15:20] mars: Yes, I highly recommend setting an alias. [15:20] flacoste: Yes, that's one option. Another would be extending bzr send so that we can just hook that in. [15:20] abentley: can I specify a diff or the revision to make the diff from? [15:20] sinzui: Yes. [15:20] abentley: does it play nice with looms? [15:21] barry, does anything? :) [15:21] lol [15:21] barry: Not in combination with Launchpad. [15:21] abentley: gotcha [15:21] barry: Sorry, but LP is branch-obsessed, and doesn't really grok loom threads. [15:21] abentley, barry: i'd expect a bzr send on a bzr export-loom-ed branch should Just Work [15:21] flacoste: Right. [15:22] export-loom FTW! [15:22] abentley, will it do dependant branches properly? [15:22] flacoste: right, but you'd have to be careful about exported higher threads so they don't include too much diff [15:22] flacoste: But your branch must have a public location specified. [15:22] mars: yeah, exactly === salgado is now known as salgado-lunch [15:22] mars: No. [15:22] :( [15:23] mars: Merge directives (bzr send output) have no concept of a dependent branch. They only specify a change to apply. [15:23] ah, ok [15:23] Merge proposals have dropped the dependent branch feature for now, because it greatly complicates things. It's an 80/20 rule. [15:24] right [15:24] Yup [15:24] well, this is still a great advance, thanks code team! [15:24] Oh, I should mention that the diffs will appear in the email and on the web page. [15:24] abentley: will there be an easier way to download the diff? rather than cut-n-paste? [15:25] In the email as an attachment, right? [15:25] barry: It will be an attachment in the email, but on the web UI, not yet. [15:26] However, it's a librarian file, so we can get that into edge soon, if we want. [15:27] * rockstar is so essited! [15:27] very cool [15:27] er, me, sorry. [15:28] allenap, I got your back. [15:28] One of the cool things about this feature is virtually any URL works. I just sent a merge proposal with the target branch specified as http://bazaar-vcs.org/bzr/bzr.dev, and it correctly picked the LP branch. [15:28] abentley, that's effing awesome [15:28] Note that LP does not handle bunldes yet, so for best results, specify --no-bundle. [15:28] abentley, how does it handle branches it doesn't know about? [15:28] That will ensure it checks that the appropriate revisions are present at the public location. [15:29] rockstar: For source branches it doesn't know about, it creates a new RemoteBranch. For target branches it doesn't know about, it errors. [15:29] Okay. That error is then emailed to me? [15:30] rockstar: Yes. [15:30] abentley, once again: woot [15:30] abentley, rockstar, you may want to copy the questions from this meeting into the feature FAQ, once it's written [15:30] mars: Good thought. [15:30] mars, point [15:31] Well, since barry is gone, I guess the meeting is over... :) [15:31] i'm not gone, just my irc sucks [15:31] is this thing on? [15:31] The one bad thing is my holidays start today, so I won't be on duty to answer questions until the new year. [15:32] but is there anything else for today? any other topics? [15:32] abentley, we should chat and I should get a brain dump then. [15:32] rockstar: Sounds good. [15:32] dd if=/dev/abentley of=/dev/rockstar [15:33] rockstar: Remember the ending of Indy 4? :-) [15:33] i guess we're done then? :) [15:33] Yup! [15:33] #endmeeting [15:33] Meeting finished at 09:33. [15:33] thanks barry [15:33] happy holidays and new year! [15:33] thanks barry [15:34] see you all in the new year! [15:35] rockstar: Thanks dude, I saw that! :) [15:35] rockstar: I am so not on the ball today. [15:35] allenap: no prob === salgado-lunch is now known as salgado