[15:00] <barry> #startmeeting
[15:00] <MootBot> Meeting started at 09:00. The chair is barry.
[15:00] <MootBot> Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE]
[15:00] <bac> me
[15:00] <EdwinGrubbs> me
[15:00] <barry> hello everyone and welcome to this week's ameu reviewers meeting
[15:00] <barry> who's here today?
[15:00] <intellectronica> me
[15:00] <vednis> me
[15:00] <sinzui> me
[15:00] <rockstar> me
[15:00] <vednis> argh
[15:01] <barry> vednis: going old skool today?
[15:01] <mars> barry, ghostbusting
[15:01] <adeuring> me
[15:01] <barry> :)
[15:02] <salgado> me
[15:02] <flacoste> me
[15:02] <barry> allenap: ping
[15:03] <barry> BjornT, cprov, danilos ping
[15:03] <danilos> me
[15:03] <intellectronica> barry: BjornT is on leave today
[15:03] <barry> gmb: ping
[15:03] <barry> intellectronica: thanks
[15:03] <gmb> me
[15:03] <gmb> Thanks barry
[15:03] <cprov> me
[15:03] <barry> [TOPIC] agenda
[15:03] <MootBot> New Topic:  agenda
[15:04] <barry>  * Roll call
[15:04] <barry>  * Last meeting of the year?
[15:04] <barry>  * Don't forget to add find-entry-uri rules when exposing new stuff in the API. See [[https://launchpad.canonical.com/API/StyleGuide#Update%20the%20XSLT%20stylesheet|API Style Guide >> Update the XSLT stylesheet]]. -- ''allenap''
[15:04] <barry>  * Peanut gallery (anything not on the agenda)
[15:04] <barry>  * Action items
[15:04] <cprov> barry: thanks (I forgot)
[15:04] <barry>  * Mentoring update
[15:04] <barry> np
[15:04] <barry> [TOPIC] last meeting of the year
[15:04] <MootBot> New Topic:  last meeting of the year
[15:04] <barry> do you guys want to meet on the 24th?  i don't think i do :)
[15:04] <barry> shall we make this the last meeting of 08?
[15:04] <rockstar> Nope
[15:04] <flacoste> i'm on leave, so +1
[15:04] <rockstar> I'll probably be out on the 24th
[15:05] <barry> any objections?
[15:05] <barry> 5... 4... 3... 2...
[15:05] <barry> 1
[15:05] <barry> done
[15:05] <barry> [TOPIC]  * Don't forget to add find-entry-uri rules when exposing new stuff in the API. See [[https://launchpad.canonical.com/API/StyleGuide#Update%20the%20XSLT%20stylesheet|API Style Guide >> Update the XSLT stylesheet]]. -- ''allenap''
[15:05] <MootBot> New Topic:   * Don't forget to add find-entry-uri rules when exposing new stuff in the API. See [[https://launchpad.canonical.com/API/StyleGuide#Update%20the%20XSLT%20stylesheet|API Style Guide >> Update the XSLT stylesheet]]. -- ''allenap''
[15:05] <barry> allenap: the floor is yours
[15:06]  * gmb blinks
[15:06] <rockstar> He never me'd, but I asked him to put this on here, so I know what it's about...
[15:07] <barry> rockstar: i missed that he didn't mii, but go ahead
[15:07] <abentley> Sorry I'm late.  My CHR day, so schedule's a little off.
[15:07] <barry> abentley: no worries!
[15:07] <rockstar> Well, earlier in the cycle, I landed a branch exposing the bmps to the APIp
[15:08] <rockstar> -p
[15:08] <rockstar> I didn't update the XSLT stylesheet though, because I didn't know about it, and my reviewer didn't ask about it.
[15:09] <rockstar> So allenap landed a branch with a bunch of new changes because it seemed I wasn't the only one (I reviewed the branch)
[15:09] <flacoste> yes
[15:09] <flacoste> that would have been part of my API reviewer cheat-sheet
[15:09] <rockstar> So I just want to remind everyone to make sure the wsdl file gets updated on API changes.
[15:09] <flacoste> (which I didn't do, so I suck)
[15:10] <bac> the posted link does not work for me.  is it available on the new wiki?
[15:10] <rockstar> No idea.
[15:10] <barry> doubtful
[15:10] <flacoste> nobody moved this yet
[15:10] <barry> i really need to spend some time moving the dev resources over to the new wiki
[15:10] <flacoste> afaik
[15:10] <cprov> rockstar: is it possible to make `lint` complain about it ?
[15:10] <flacoste> well
[15:10] <flacoste> there is a gotcha abohut this
[15:11] <flacoste> in the sense that the XSLT file lives in a separate branch
[15:11] <flacoste> it's in the launchpadlib branch
[15:11] <flacoste> not on the launchpad branch
[15:11] <flacoste> the rationale for having it on launchpadlib was that some users asked for it
[15:11] <rockstar> Maybe just asking about updating it is enough.  We are all pretty honorable.
[15:11] <flacoste> and we were hoping for community contrib on it
[15:11] <flacoste> i agree with rockstar
[15:12] <rockstar> I mean, if my reviewer asked about it, at least I would have known about it.
[15:12] <abentley> barry: Yeah, I've been meaning to move the developer documentation over, but I wanted to make sure it was all kosher.
[15:12] <rockstar> And it would at least be a good reminder.
[15:13] <barry> abentley: i think it could use some gardening along the way, but if you're bored, go for it! :)
[15:13] <cprov> well, if we don't have a code check it's very likely that even the most honorable programmer will forget to do it once in while.
[15:13] <cprov> but I'm fine with it being part of the dev & reviewers guidelines.
[15:13] <barry> if devs don't remember it needs to be updated, it's likely some reviewers will also not remember
[15:13]  * barry looks in mirror
[15:14] <barry> cprov: i definitely think that's a good start
[15:14] <abentley> barry: I'm meaning https://launchpad.canonical.com/DeveloperDocumentation, and it seems pretty clean to me.
[15:14] <barry> flacoste: can we just pawn this one off on you too as part of the api reviewer cheatsheet?
[15:14] <flacoste> barry: sure
[15:15] <barry> abentley: oh yeah, that looks fine.  it would be great to move those over.  the reviewer ones need more gardening
[15:15] <barry> flacoste: thanks
[15:15] <barry> abentley: thanks
[15:15] <barry> anything else on this topic?
[15:16] <barry> [TOPIC]  * Peanut gallery (anything not on the agenda)
[15:16] <MootBot> New Topic:   * Peanut gallery (anything not on the agenda)
[15:16] <barry> the floor is open.  do you have anything else to discuss today?
[15:17] <abentley> barry: bzr send.
[15:17] <barry> abentley: give me some good news!
[15:17] <rockstar> yay!
[15:18] <abentley> When the next rev of launchpad goes live, "bzr send --no-bundle --mail-to merge@code.launchpad.net" should Just Work.
[15:18] <flacoste> awesome!
[15:18] <rockstar> Woot!
[15:19] <abentley> It will create a merge directive attached to an email in your configured mail client.
[15:19] <abentley> The body of that email will be used as an initial comment.
[15:19] <flacoste> this is great
[15:19] <barry> this is fantastic
[15:19] <abentley> The diff in the merge directive will be attached as the review diff.
[15:19] <flacoste> so we could upgrade lpreview on top of that
[15:19] <barry> flacoste: +1
[15:19]  * mars can see that becoming a new alias in his bazaar.conf
[15:20] <flacoste> to integrate the lint and other stuff
[15:20] <abentley> mars: Yes, I highly recommend setting an alias.
[15:20] <abentley> flacoste: Yes, that's one option.  Another would be extending bzr send so that we can just hook that in.
[15:20] <sinzui> abentley: can I specify a diff or the revision to make the diff from?
[15:20] <abentley> sinzui: Yes.
[15:20] <barry> abentley: does it play nice with looms?
[15:21] <rockstar> barry, does anything? :)
[15:21] <barry> lol
[15:21] <abentley> barry: Not in combination with Launchpad.
[15:21] <barry> abentley: gotcha
[15:21] <abentley> barry: Sorry, but LP is branch-obsessed, and doesn't really grok loom threads.
[15:21] <flacoste> abentley, barry: i'd expect a bzr send on a bzr export-loom-ed branch should Just Work
[15:21] <abentley> flacoste: Right.
[15:22] <flacoste> export-loom FTW!
[15:22] <mars> abentley, will it do dependant branches properly?
[15:22] <barry> flacoste: right, but you'd have to be careful about exported higher threads so they don't include too much diff
[15:22] <abentley> flacoste: But your branch must have a public location specified.
[15:22] <barry> mars: yeah, exactly
[15:22] <abentley> mars: No.
[15:22] <mars> :(
[15:23] <abentley> mars: Merge directives (bzr send output) have no concept of a dependent branch.  They only specify a change to apply.
[15:23] <mars> ah, ok
[15:23] <abentley> Merge proposals have dropped the dependent branch feature for now, because it greatly complicates things.  It's an 80/20 rule.
[15:24] <mars> right
[15:24] <rockstar> Yup
[15:24] <barry> well, this is still a great advance, thanks code team!
[15:24] <abentley> Oh, I should mention that the diffs will appear in the email and on the web page.
[15:24] <barry> abentley: will there be an easier way to download the diff? rather than cut-n-paste?
[15:25] <rockstar> In the email as an attachment, right?
[15:25] <abentley> barry: It will be an attachment in the email, but on the web UI, not yet.
[15:26] <abentley> However, it's a librarian file, so we can get that into edge soon, if we want.
[15:27]  * rockstar is so essited!
[15:27] <barry> very cool
[15:27] <allenap> er, me, sorry.
[15:28] <rockstar> allenap, I got your back.
[15:28] <abentley> One of the cool things about this feature is virtually any URL works.  I just sent a merge proposal with the target branch specified as http://bazaar-vcs.org/bzr/bzr.dev, and it correctly picked the LP branch.
[15:28] <rockstar> abentley, that's effing awesome
[15:28] <abentley> Note that LP does not handle bunldes yet, so for best results, specify --no-bundle.
[15:28] <rockstar> abentley, how does it handle branches it doesn't know about?
[15:28] <abentley> That will ensure it checks that the appropriate revisions are present at the public location.
[15:29] <abentley> rockstar: For source branches it doesn't know about, it creates a new RemoteBranch.  For target branches it doesn't know about, it errors.
[15:29] <rockstar> Okay.  That error is then emailed to me?
[15:30] <abentley> rockstar: Yes.
[15:30] <rockstar> abentley, once again: woot
[15:30] <mars> abentley, rockstar, you may want to copy the questions from this meeting into the feature FAQ, once it's written
[15:30] <abentley> mars: Good thought.
[15:30] <rockstar> mars, point
[15:31] <rockstar> Well, since barry is gone, I guess the meeting is over...  :)
[15:31] <barry> i'm not gone, just my irc sucks
[15:31] <barry> is this thing on?
[15:31] <abentley> The one bad thing is my holidays start today, so I won't be on duty to answer questions until the new year.
[15:32] <barry> but is there anything else for today?  any other topics?
[15:32] <rockstar> abentley, we should chat and I should get a brain dump then.
[15:32] <abentley> rockstar: Sounds good.
[15:32] <rockstar> dd if=/dev/abentley of=/dev/rockstar
[15:33] <abentley> rockstar: Remember the ending of Indy 4? :-)
[15:33] <barry> i guess we're done then? :)
[15:33] <rockstar> Yup!
[15:33] <barry> #endmeeting
[15:33] <MootBot> Meeting finished at 09:33.
[15:33] <intellectronica> thanks barry
[15:33] <barry> happy holidays and new year!
[15:33] <mars> thanks barry
[15:34] <mars> see you all in the new year!
[15:35] <allenap> rockstar: Thanks dude, I saw that! :)
[15:35] <allenap> rockstar: I am so not on the ball today.
[15:35] <rockstar> allenap: no prob