=== mthaddon_ is now known as mthaddon
=== mrevell-afk is now known as mrevell
=== salgado-bbl is now known as salgado
=== salgado is now known as salgado-brb
=== salgado-brb is now known as salgado
=== bac_afk is now known as bac
=== mrevell is now known as mrevell-lunch
=== ursula_ is now known as Ursinha
=== mrevell-lunch is now known as mrevell
barrymootbot, like gwb is an ex-mootbot15:01
bigjoolsthe mystery of the missing mootbot15:01
rockstarmootbot is dead.15:01
rockstarI killed him.15:01
barryanyway.  welcome to this week's ameu reviewer's meeting.  who's here today?15:01
barryBjornT, cprov, danilos ping15:03
barryEdwinGrubbs: ping15:03
danilos(though I am likely to be on and off)15:03
barrynp, today's a light agenda15:03
barry[TOPIC] agenda15:03
barry * Roll call15:04
barry * mars to stop ocr, will review js on call until more reviewers are trained15:04
barry * Peanut gallery (anything not on the agenda)15:04
barry * Action items15:04
barry * Mentoring update15:04
barryoops.  ignore the mars item, we did that last week15:04
barrylet's skip around a bit...  i suck today15:04
barry[TOPIC] action items15:04
barry * barry to look into techniques for eliminating back-patching of schema types (avoiding circular imports)15:04
barryi actually started to look at this and i might have a branch for review later this week15:05
barry * barry to add `pretty()` functions to reviewers docs15:05
barrynot done15:05
barry * flacoste to work on API reviewer cheat sheet15:05
barryno worries.  do you want to keep it on the list?15:06
flacosteyeah, for two more weeks15:06
barryyou got it :)15:06
barry[TOPIC] mentoring update15:07
barryany word from mentors or mentats?15:07
gmbal-maisan's doing very well now that the volume of reviews is back up to something approaching normal15:07
gmbMondays aren't the ideal day for mentoring, I think; they can be quite quiet.15:08
* abentley agrees they are quiet.15:08
barryshould we move you guys to get better coverage?15:08
barryi think adeuring was looking for a monday slot15:09
gmbbarry: I'm not sure, it depends on how al-maisan feels.15:09
barrywe also have euro/tues free15:09
adeuringadeuring: well, I wouldn't oopose to taking Monday15:09
adeuring...or Tuesday or Wednesday15:10
al-maisangmb: I am your apprentice, so will tag along :)15:10
bigjoolsany day ending in a "y"15:10
gmbal-maisan, barry Maybe it's worth moving to Tuesday for a week or two.15:11
barrybigjools: thank goodness that leaves satursun out15:11
barrygmb, al-maisan ok. let's move you guys to tuesday for two weeks to get more mentoring in15:11
al-maisanfine :)15:12
barryadeuring: let's keep you at friday for now and then depending on how it goes with gmb and al-maisan we could switch you after that15:12
gmbI'll update the OCR page.15:12
adeuringbarry: OK15:12
barrygmb: awesome, thanks15:12
barryany other mentoring issues?15:12
barryguess not!15:13
barry[TOPIC] peanut gallery15:13
abentleyI have a PSA15:13
barrywell, that's all i have on my agenda, i open the floor to y'all15:13
barryabentley: go ahead15:14
* al-maisan wonders what a PSA is..?15:14
gmbal-maisan: public service announcement15:14
abentleyWhen you approve a merge proposal, please mark its status approved as well.15:14
abentleyIf you are using email, you can use the "status approved" command.15:14
rockstarNow you know, and knowing is half the battle! Gee Eye JOOOOOOOOOOE15:15
abentleyThis will remove the proposal from the list of active reviews.15:15
barryabentley: that is a continuing source of pain ;)15:15
abentleyWhich makes it easier to see what needs to be reviewed.15:15
bacabentley: +115:15
gmbNurse, nurse! rockstar's out of bed again...15:15
rockstargmb: did you not watch GI Joe, with the PSAs at the end?15:16
abentleyYou can use "review approve" and "status approved" in the same email.15:16
gmbrockstar: Call it cultural differences :)15:16
abentleyJust on different lines.15:16
salgadoabentley, why do we need both?15:16
rockstarI know thumper talked about doing it automatically, but we have some details to figure out first.15:17
al-maisanabentley: do you need both?15:17
abentleysalgado: Because one is a reviewer's opinion, and one is the status of the merge proposal.15:17
rockstarsalgado: one is the status of the CodeReviewVote, the other is for the status of the BranchMergeProposal15:17
sinzuisalgado: some project may require two more more reviews to be approved before the status is really approved.15:17
EdwinGrubbsabentley: btw, doesn't there need to be a leading space in the email commands, so it should be " review approve"15:17
flacostei think you only need status approve15:17
salgadoI see15:17
abentleyEdwinGrubbs: Yes.15:17
flacosteiirc, it also automatically approve the review15:18
rockstarflacoste: not true currently.15:18
abentleysalgado: There are two reviews in many cases.15:18
salgadoI've been using only "status approve"15:18
barrysalgado: i guess that approves the mp without setting your review status to approve...?15:18
rockstarsalgado: it'd be " status approved" - note the tense15:19
abentleysalgado: Other projects may have different rules about how many reviews are required, whether reviewers can veto, etc.15:19
bigjoolsmaybe have a per-project policy that can be set then15:19
abentleybarry: Right.  It's like: "I don't approve of this, but merge it anyway."15:19
flacostesure, i thought thumper said it did both15:20
salgadoabentley, I don't see it that way.  I see it more as an indication that the reviewer didn't know there were two separate things to approve15:20
barryabentley: and eventually we'll be able to specify those workflows and have it all work automatically, right? <wink>15:20
rockstarflacoste: it does in cases where you voted needs_fixing, and then revoted approve15:20
abentleybarry: That's a good question.  The mandate to avoid imposing policy was from on high.15:20
barryabentley: not imposing policy, but providing the mechanisms for projects to specify their policy15:21
rockstarbarry: eventually, given enough time, Launchpad will support direct teleportation to sprints.15:21
barryabentley: but i think that's also frowned on :/15:21
abentleybarry: You may not from my work on Bundle Buggy that I think it makes a lot of sense to have policy about what is needed to approve a merge proposal.15:21
barryrockstar: thank goodness, 'cause i'm running out of my little round friends15:21
barryabentley: in this case, it could be as simple as a count of the number of approved reviews.  i don't even care about the rejected ones15:22
al-maisanthe email generated by the webapp says: "Review: Approve" BTW .. that means we cannot use that any more?15:22
rockstarbarry: in Entertainer's case, a rejected or a needs_fixing prevents the branch from landing regardless of the approveds...15:23
abentleybarry: So in LP, we have mentor / mentat reviews, which are one special case.  And we have database reviews, which are another.15:23
* barry invokes the 80/20 rule15:24
rockstaral-maisan: that is just the output email.  The input in " review approve"15:24
salgadodoes "vote approve" work as well?15:25
abentleyrockstar is working on exposing BMPs through the API.  Presumably he could write a script to enforce a policy.15:25
barryabentley, rockstar +1 !15:25
rockstarabentley: yes, that's an idea.15:25
rockstarsalgado: vote is deprecated.  Use review.15:25
salgadowill do15:26
barryabentley: cool, thanks for that psa15:26
abentleybarry: np15:26
barryanything else on this or other topics?15:26
abentleybarry: I've just started work on generating diffs for all merge proposals.15:27
* flacoste cheers15:27
barryabentley: yay!15:27
flacostei propose a virtual wave for abentley!15:27
barryeveryone send abentley an e-beer15:28
barryare we done?15:29
barrythanks everyone!15:30
gmbThanks barry15:30
flacostethanks barry!15:30
abentleyThanks barry15:30
al-maisanthanks barry!15:30
=== salgado is now known as salgado-lunch
=== salgado-lunch is now known as salgado
=== EdwinGrubbs is now known as EdwinGrubbs-lunc
=== EdwinGrubbs-lunc is now known as EdwinGrubb-lunch
=== bac is now known as bac_lunch
=== bac_lunch is now known as bac
=== mrevell is now known as mrevell-afk
=== EdwinGrubb-lunch is now known as EdwinGrubbs
=== salgado is now known as salgado-afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!