=== ursula_ is now known as Ursinha === ursula_ is now known as Ursinha === salgado-afk is now known as salgado [15:00] #startmeeting [15:00] Meeting started at 09:00. The chair is barry. [15:00] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:00] hello everyone and welcome to this week's ameu reviewers meeting. who's here today? [15:00] me [15:00] me [15:00] we have a number of sprinters who probably won't make it [15:01] me [15:01] so today's agenda will be pretty light [15:01] me [15:01] me! [15:02] allenap: sinzui cprov BjornT ping [15:02] me [15:02] me [15:02] barry: allenap is off sick today [15:03] barry: allenap has the lurgi [15:03] BjornT: bummer :( [15:03] [TOPIC] agenda [15:03] New Topic: agenda [15:03] * Roll call [15:03] * Action items [15:03] * Mentoring update [15:03] * Peanut gallery (anything not on the agenda) [15:03] [TOPIC] action items [15:03] New Topic: action items [15:03] * abentley to experiment on storm base class [15:04] me [15:04] dunno where abentley is but he did work on a branch, which i semi-reviewed [15:04] it looked pretty good. stub did a semi-review too and between us i think we had some good suggestions [15:04] jml has the official review, though i'll pick it up on friday if it gets that far [15:05] i think it'll make a nice convenient base class for our storm classes [15:05] anyway, we'll see how that goes [15:05] * barry to add `field_id` to coding guideline [15:06] that came up at the asiapac meeting. preference is to use field_id instead of fieldID for foreign key references [15:06] iow, the attribute name in the storm class [15:06] * barry to add `pretty()` functions to reviewers docs [15:06] not done [15:06] * flacoste to work on API reviewer cheat sheet [15:06] i suspect, not done [15:06] :-) [15:07] he said something about that item last week, didn't he? [15:07] or was it his other item? [15:07] it was that one [15:08] he's changing his name to flacoste-hoover because he sucks :) [15:08] * barry thinks he has to do the same [15:08] Feb 11 10:43:45 if it's not done next week, i change my [15:08] name to flacoste_hoover [15:08] right :) [15:08] [TOPIC] * Mentoring update [15:08] New Topic: * Mentoring update [15:08] any feedback from mentors or mentats? [15:09] okay! [15:10] [TOPIC] * Peanut gallery (anything not on the agenda) [15:10] New Topic: * Peanut gallery (anything not on the agenda) [15:10] you guys have anything? [15:10] Why does MootBot suck? [15:10] Or, ore directly, why don't we have logs? :-) [15:10] s/ore/more/ [15:11] gary_poster: and why do i continue to use it? [15:11] :-) [15:11] It would be nice to have logs [15:11] regarding the patching we do to get around circular imports for the API work, I recommend that we get some helper functions written. [15:11] bigjools: i think that's the way to go. my previous experiment failed [15:11] bigjools: would you like to take a crack at that? [15:11] bigjools, have you seen interfaces/_schema_circular_imports [15:11] rockstar: I haven't [15:12] bigjools, that's where the code team has started putting their circular import avoidance patching. [15:12] What happened to lazy_import? Or doesn't that work for schema declarations? [15:12] gmb, I don't think lazy_import would help in this situation. [15:12] barry: I can try, if I find the time! [15:13] rockstar: that's not what I had in miund [15:13] rockstar: +1 for moving them all to the same place [15:13] rockstar: Ah, right [15:13] barry, it makes my life easier, because I know where the declarations are. [15:13] rockstar: yeah, grepping them out was 3/4 of the pain of my experiment [15:13] I am talking about helper funcs that save you from working out WTF you need to patch [15:13] though i hate the module name :) [15:13] I'd rather they were kept in the interface file [15:14] bigjools, ah, I can't think of a use for that. I usually know what I need to patch as I do it. [15:14] bigjools: if the helpers were easily grepped for, that's fine [15:14] barry, it can be changed. It was thumper's idea, and can change pretty easily. [15:14] I think something like patch_returns_collection_type(func, type) [15:15] and patch_param_type(func, param, type) [15:15] make sense? [15:16] something like that. maybe get 'circular' and 'import' in the names? [15:16] e.g. close_circular_import(...) ? [15:16] so_we_end_up_with_a_really_long_help_function_name() ? :) [15:16] spin_wheels_make_smoke [15:17] bigjools: in the fine tradition of python, keep ugly things ugly :) [15:17] bigjools: anyway, take a crack at it and i'll happily review it! [15:17] okidoki [15:17] [ACTION] bigjools to work on helper functions for circular imports in interfaces [15:17] ACTION received: bigjools to work on helper functions for circular imports in interfaces [15:17] bigjools: thanks! [15:17] my pleasure [15:17] anything else? [15:18] one more thing [15:18] sure thing [15:18] I chatted to Bjorn this morning about extending the sourcedeps rsync filter that rocketfuel-get uses [15:18] so it ignores */.bzr/* [15:19] my motiviation being that I am fed up of downloading the huge packs files when rsync runs after a bzr sourcedep update [15:19] does this sound good or bad? [15:19] ideally I'd like to bzr pull the source deps ... [15:20] buildbot has had issues with pulling bzr this weekend [15:20] it pulls sourcedeps to update normally [15:20] but bzr did something funky with their branch [15:20] so it needed a merge (or an rsync) [15:21] so rsync is safer when that kind of situation arises [15:21] sounds like it's not a problem to be too worried about? [15:21] don't we eventually want to move to ppas for all that stuff anyway? [15:21] sure, once in a month and a half [15:21] how does everyone else sync sourcedeps? [15:21] barry: +1 [15:22] bigjools: rocketfuel-get (rsync) [15:22] a combination of ppas and buildout eggs [15:22] gary_poster: yes yes yes yes yes yes yes yes yes [15:22] well, source [15:22] rf-get [15:22] or "sourcecode" I should say [15:22] gary_poster: you coming to our nags head sprint? :) [15:23] barry: not that I know of :-) (first I heard of it) [15:23] gary_poster: 120 hours of drinkin' and hackin' [15:23] heh, cool [15:23] gary_poster: drive on down! [15:23] :-) [15:23] anyway we don't need to decide now, I just wanted to discuss and see what people thought because I really am fed up with downloading 100+Mb of data when sourcecode/bzr is updated [15:23] bigjools: thanks for putting this on the radar [15:24] Bjorn's objection to not syncing the .bzr dirs was that people might want to branch off it [15:25] np [15:25] EOF [15:25] for most people that will happen rarely enough that making a fresh branch shouldn't be a problem [15:25] IME [15:25] cool. anything else on this or other topic? [15:25] my thoughts too - branch off the official source, not our sourcecode deps :) [15:27] sounds like we're done! [15:27] #endmeeting [15:27] Meeting finished at 09:27. [15:27] thanks everyone [15:27] cheers [15:27] thanks === salgado is now known as salgado-lunch === salgado-lunch is now known as salgado === mrevell is now known as mrevell-dinner === bac is now known as fakestevejobs === fakestevejobs is now known as bac === salgado is now known as salgado-afk