[15:00] <barry> #startmeeting
[15:00] <MootBot> Meeting started at 09:00. The chair is barry.
[15:00] <MootBot> Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE]
[15:00] <barry> hello everyone and welcome to this week's ameu reviewers meeting.  who's here today?
[15:00] <bigjools> me
[15:00] <gary_poster> me
[15:00] <barry> we have a number of sprinters who probably won't make it
[15:01] <bac> me
[15:01] <barry> so today's agenda will be pretty light
[15:01] <gmb> me
[15:01] <salgado> me!
[15:02] <barry> allenap: sinzui cprov BjornT ping
[15:02] <BjornT> me
[15:02] <cprov> me
[15:02] <BjornT> barry: allenap is off sick today
[15:03] <gmb> barry: allenap has the lurgi
[15:03] <barry> BjornT: bummer :(
[15:03] <barry> [TOPIC] agenda
[15:03] <MootBot> New Topic:  agenda
[15:03] <barry>  * Roll call
[15:03] <barry>  * Action items
[15:03] <barry>  * Mentoring update
[15:03] <barry>  * Peanut gallery (anything not on the agenda)
[15:03] <barry> [TOPIC] action items
[15:03] <MootBot> New Topic:  action items
[15:03] <barry>  * abentley to experiment on storm base class
[15:04] <sinzui> me
[15:04] <barry> dunno where abentley is but he did work on a branch, which i semi-reviewed
[15:04] <barry> it looked pretty good.  stub did a semi-review too and between us i think we had some good suggestions
[15:04] <barry> jml has the official review, though i'll pick it up on friday if it gets that far
[15:05] <barry> i think it'll make a nice convenient base class for our storm classes
[15:05] <barry> anyway, we'll see how that goes
[15:05] <barry>  * barry to add `field_id` to coding guideline
[15:06] <barry> that came up at the asiapac meeting.   preference is to use field_id instead of fieldID for foreign key references
[15:06] <barry> iow, the attribute name in the storm class
[15:06] <barry>  * barry to add `pretty()` functions to reviewers docs
[15:06] <barry> not done
[15:06] <barry>  * flacoste to work on API reviewer cheat sheet
[15:06] <barry> i suspect, not done
[15:06] <gary_poster> :-)
[15:07] <salgado> he said something about that item last week, didn't he?
[15:07] <salgado> or was it his other item?
[15:07] <barry> it was that one
[15:08] <barry> he's changing his name to flacoste-hoover because he sucks :)
[15:08]  * barry thinks he has to do the same
[15:08] <salgado> Feb 11 10:43:45 <flacoste>      if it's not done next week, i change my
[15:08] <salgado> name to flacoste_hoover
[15:08] <barry> right :)
[15:08] <barry> [TOPIC]  * Mentoring update
[15:08] <MootBot> New Topic:   * Mentoring update
[15:08] <barry> any feedback from mentors or mentats?
[15:09] <barry> okay!
[15:10] <barry> [TOPIC]  * Peanut gallery (anything not on the agenda)
[15:10] <MootBot> New Topic:   * Peanut gallery (anything not on the agenda)
[15:10] <barry> you guys have anything?
[15:10] <gary_poster> Why does MootBot suck?
[15:10] <gary_poster> Or, ore directly, why don't we have logs? :-)
[15:10] <gary_poster> s/ore/more/
[15:11] <barry> gary_poster: and why do i continue to use it?
[15:11] <gary_poster> :-)
[15:11] <gary_poster> It would be nice to have logs
[15:11] <bigjools> regarding the patching we do to get around circular imports for the API work, I recommend that we get some helper functions written.
[15:11] <barry> bigjools: i think that's the way to go.  my previous experiment failed
[15:11] <barry> bigjools: would you like to take a crack at that?
[15:11] <rockstar> bigjools, have you seen interfaces/_schema_circular_imports
[15:11] <bigjools> rockstar: I haven't
[15:12] <rockstar> bigjools, that's where the code team has started putting their circular import avoidance patching.
[15:12] <gmb> What happened to lazy_import? Or doesn't that work for schema declarations?
[15:12] <rockstar> gmb, I don't think lazy_import would help in this situation.
[15:12] <bigjools> barry: I can try, if I find the time!
[15:13] <bigjools> rockstar: that's not what I had in miund
[15:13] <barry> rockstar: +1 for moving them all to the same place
[15:13] <gmb> rockstar: Ah, right
[15:13] <rockstar> barry, it makes my life easier, because I know where the declarations are.
[15:13] <barry> rockstar: yeah, grepping them out was 3/4 of the pain of my experiment
[15:13] <bigjools> I am talking about helper funcs that save you from working out WTF you need to patch
[15:13] <barry> though i hate the module name :)
[15:13] <bigjools> I'd rather they were kept in the interface file
[15:14] <rockstar> bigjools, ah, I can't think of a use for that.  I usually know what I need to patch as I do it.
[15:14] <barry> bigjools: if the helpers were easily grepped for, that's fine
[15:14] <rockstar> barry, it can be changed.  It was thumper's idea, and can change pretty easily.
[15:14] <bigjools> I think something like patch_returns_collection_type(func, type)
[15:15] <bigjools> and patch_param_type(func, param, type)
[15:15] <bigjools> make sense?
[15:16] <barry> something like that.  maybe get 'circular' and 'import' in the names?
[15:16] <barry> e.g. close_circular_import(...) ?
[15:16] <bigjools> so_we_end_up_with_a_really_long_help_function_name() ? :)
[15:16] <sinzui> spin_wheels_make_smoke
[15:17] <barry> bigjools: in the fine tradition of python, keep ugly things ugly :)
[15:17] <barry> bigjools: anyway, take a crack at it and i'll happily review it!
[15:17] <bigjools> okidoki
[15:17] <barry> [ACTION] bigjools to work on helper functions for circular imports in interfaces
[15:17] <MootBot> ACTION received:  bigjools to work on helper functions for circular imports in interfaces
[15:17] <barry> bigjools: thanks!
[15:17] <bigjools> my pleasure
[15:17] <barry> anything else?
[15:18] <bigjools> one more thing
[15:18] <barry> sure thing
[15:18] <bigjools> I chatted to Bjorn this morning about extending the sourcedeps rsync filter that rocketfuel-get uses
[15:18] <bigjools> so it ignores */.bzr/*
[15:19] <bigjools> my motiviation being that I am fed up of downloading the huge packs files when rsync runs after a bzr sourcedep update
[15:19] <bigjools> does this sound good or bad?
[15:19] <bigjools> ideally I'd like to bzr pull the source deps ...
[15:20] <gary_poster> buildbot has had issues with pulling bzr this weekend
[15:20] <gary_poster> it pulls sourcedeps to update normally
[15:20] <gary_poster> but bzr did something funky with their branch
[15:20] <gary_poster> so it needed a merge (or an rsync)
[15:21] <gary_poster> so rsync is safer when that kind of situation arises
[15:21] <bigjools> sounds like it's not a problem to be too worried about?
[15:21] <barry> don't we eventually want to move to ppas for all that stuff anyway?
[15:21] <gary_poster> sure, once in a month and a half
[15:21] <bigjools> how does everyone else sync sourcedeps?
[15:21] <bigjools> barry: +1
[15:22] <barry> bigjools: rocketfuel-get (rsync)
[15:22] <gary_poster> a combination of ppas and buildout eggs
[15:22] <barry> gary_poster: yes yes yes yes yes yes yes yes yes
[15:22] <gary_poster> well, source
[15:22] <bac> rf-get
[15:22] <bigjools> or "sourcecode" I should say
[15:22] <barry> gary_poster: you coming to our nags head sprint? :)
[15:23] <gary_poster> barry: not that I know of :-) (first I heard of it)
[15:23] <barry> gary_poster: 120 hours of drinkin' and hackin'
[15:23] <gary_poster> heh, cool
[15:23] <bac> gary_poster: drive on down!
[15:23] <gary_poster> :-)
[15:23] <bigjools> anyway we don't need to decide now, I just wanted to discuss and see what people thought because I really am fed up with downloading 100+Mb of data when sourcecode/bzr is updated
[15:23] <barry> bigjools: thanks for putting this on the radar
[15:24] <bigjools> Bjorn's objection to not syncing the .bzr dirs was that people might want to branch off it
[15:25] <bigjools> np
[15:25] <bigjools> EOF
[15:25] <gary_poster> for most people that will happen rarely enough that making a fresh branch shouldn't be a problem
[15:25] <gary_poster> IME
[15:25] <barry> cool.  anything else on this or other topic?
[15:25] <bigjools> my thoughts too - branch off the official source, not our sourcecode deps :)
[15:27] <barry> sounds like we're done!
[15:27] <barry> #endmeeting
[15:27] <MootBot> Meeting finished at 09:27.
[15:27] <barry> thanks everyone
[15:27] <bigjools> cheers
[15:27] <gary_poster> thanks