=== salgado is now known as salgado-afk === mrevell is now known as mrevell-sprint [15:00] #startmeeting [15:00] Meeting started at 09:00. The chair is barry. [15:00] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:00] hello everyone and welcome to this week's ameu reviewers meeting. who's here today? [15:00] me [15:01] me [15:01] me (at sprint - so half here) [15:01] me [15:01] me [15:01] and me [15:01] me [15:01] me [15:01] welcome noodles775 ! [15:01] * noodles775 grins [15:02] me [15:02] bac: ping [15:02] me [15:02] danilos: ping [15:03] EdwinGrubbs: ping [15:03] mars: ping [15:03] rockstar: ping [15:03] salgado: ping [15:03] me [15:03] [TOPIC] agenda [15:03] New Topic: agenda [15:03] pretty light day today! [15:04] * Roll call [15:04] * Peanut gallery (anything not on the agenda) [15:04] * Mentoring update [15:04] * al-maisan graduates [15:04] * noodles to start js reviews this cycle, official mentat status next cycle [15:04] * Action items [15:04] [TOPIC] peanut gallery [15:04] New Topic: peanut gallery [15:04] me [15:04] let's start off with this: does anyone have anything reviewish that they'd like to bring up? [15:05] wow, nothing? [15:06] js reviews [15:06] can be difficult to organise when all the reviewers are sprinting [15:07] mars: do we have a plan for mentoring more js reviewers? [15:07] Do we want to consider a plan to train up js reviewers? [15:07] me [15:07] barry, anyone can pick up a JS review, if they are comfortable doing so [15:07] ideally everyone should be able to review js [15:08] sure, i'm just wondering if we need a mentoring program for those (like me) who feel less comfortable reviewing js. [15:08] frankly, I think i need much more experience writing JS code before I would feel able to review JS code [15:08] sinzui can't review his own JS code, but he can ask the OCR if they are comfortable doing so [15:08] :) [15:08] hmm [15:09] the OCR/reviewer thing is the best we have for now - it spreads the knowledge pretty wide [15:09] without having formal JS-Review training for all the other reviewers [15:10] mars: i guess we just need backups then for stuff we're less experienced with? [15:10] mars: Do we have updated standards and cheatsheet of common JS problems? [15:10] barry, well, we do have 8 people who can review JS code [15:10] sinzui, that's on my list to write today [15:11] * sinzui is thinking of the rule that zope3 does not make css3 valid ids, so Y.get() fails. [15:11] barry: in a way, reviewing is a great way to build confidence, because you _have_ to understand what the code does and why it's written the way it is, and you _should_ ask if you don't :) [15:11] mars: i actually like the idea of throwing people into the deep end, getting the ocr to review the js, but with an experienced js'er reviewing the review [15:11] sinzui, :) [15:11] intellectronica: yep :) [15:12] barry, if you were at the sprint, you may have rethought that... [15:12] lol [15:12] the deep end for browser scripting is... deep [15:12] with sharks [15:12] :) [15:13] mars: foundations will make it all better, right? [15:13] that's why I feel it's best suited to a "volunteer" program [15:13] mars: or are you fitting laser helmets right now? [15:13] barry, we're working on it - tools should help [15:13] barry, yes, tools will help [15:14] in a few cycles we should be to the point where the reviewer can just trust the tests [15:14] but we're not there yet [15:14] mars: i think coding guidelines will help a lot, even if they're incomplete [15:14] mars: something a reviewer can read and point to [15:14] agreed [15:14] mars: that we fill up as questions arise [15:15] mars: so i guess the recommendation is: ocr should try to review, and ask if you're not sure [15:15] barry, true - the JS review then becomes more of a style and conformance review, but it still has value [15:15] also agreed [15:16] mars: i think that's the best way to start, since those are easier to get a handle on [15:16] oh, i also want to point out that mars updated https://dev.launchpad.net/ReviewerSchedule [15:16] this now includes a "specialties" column so you have a better idea of who can help out with js [15:16] sinzui: thanks. did you have anything else on this topic? [15:16] no [15:17] s/specialties/mentoring offered/ ? [15:17] cool, anybody have anything else on any topic not on the agenda? [15:17] mars: sup to the reviewer i guess [15:18] [TOPIC] mentoring update [15:18] New Topic: mentoring update [15:18] * al-maisan graduates [15:18] but he's not here :) [15:18] congart al-maisan! [15:19] * noodles to start js reviews this cycle, official mentat status next cycle [15:19] noodles775: we'll figure out a mentor/ocr for you next cycle. welcome aboard! [15:19] Thanks! [15:20] [TOPIC] action items [15:20] New Topic: action items [15:20] * gary to add `getStore()` as an alias for `_get_store()` [15:20] gary's not here though. does anybody know if this happened? [15:21] * flacoste to look into storm/sqlobject result set compatibility [15:21] barry: gary still needs to do this, he's on a sprint so has an excuse [15:21] cool :) [15:21] barry: i replied with a possible solution to gavin yesterday [15:21] barry: he can tell if it works or not :-) [15:22] excellent, thanks! [15:22] flacoste: I'll be putting that in my branch later today. [15:22] Thank you :) [15:22] allenap: great, let us know how it works [15:22] allenap: if it works, i'd suggest you add it to storm itself [15:22] Will do. [15:22] well, *if* it works :) [15:22] flacoste: Good idea! [15:23] * gary will check to see if there's a bug open for adding a hook to `bzr send`, and submit one if there isn't [15:23] gary's sprinting so we won't worry about this one [15:23] * bigjools to take crack at helper functions for backpatching schemas to avoid circular imports [15:23] and bigjools isn't here (sprinting?) [15:23] * abentley to experiment on storm base class [15:23] nor is abentley, but does anybody know what the status of his sugarstorm branch is? [15:24] i have not done my three action items, but now i have access to to the old wiki again, so i'm going to try to find some time to migrate/update [15:25] * flacoste to work on API reviewer cheat sheet [15:25] * flacoste hides [15:25] no worries hoover :) keep it on the list? [15:26] barry: bigjools is off (vacations) this week [15:26] cprov: cool, thanks [15:26] well. that's everything that i have. if there's nothing more we can break early [15:26] 5 [15:27] 4 [15:27] 2 [15:27] 1 [15:27] #endmeeting [15:27] Meeting finished at 09:27. [15:27] thanks everyone! record time [15:27] thanks barry [15:27] Woo, thanks. [15:28] thanks, barry [15:28] taa barry [15:28] bye === cprov is now known as cprov-lunch === cprov-lunch is now known as cprov === salgado is now known as salgado-lunch === salgado-lunch is now known as salgado