[00:53] <shtylman> evand: thanks for the heads up...I will take a look...ran it several times without issue...:/
[06:42] <Scix> cjwatson, where can I find pitti?
[06:43] <superm1> Scix, usually in #ubuntu-devel I see him, but i'd check /whois
[06:43] <Scix> superm1, tanks :) I'll try that
[11:40] <StevenK> evand: Did you see mterry's oem-config bug?
[11:40] <evand> #?
[11:41] <StevenK> evand: Digging it up
[11:42] <StevenK> evand: #341758
[11:45] <evand> ah, very cool.  I'll review and merge it in a little bit (just need to get through some other things that have been piled on this morning)
[11:45] <evand> StevenK: thanks for pointing me at that
[11:45] <StevenK> evand: No worries.
[13:03] <CIA-3> ubiquity: cjwatson * r3098 ubiquity/ (debian/changelog scripts/install.py):
[13:03] <CIA-3> ubiquity: broken_packages is fairly slow due to having to iterate over the whole
[13:03] <CIA-3> ubiquity: cache. Speed it up a bit by stopping when the number of broken packages
[13:03] <CIA-3> ubiquity: found reaches cache._depcache.BrokenCount; this improves blacklist
[13:03] <CIA-3> ubiquity: calculation time for the previously-mentioned DVD English-only install
[13:03] <CIA-3> ubiquity: from 3:30 to 2:30 (see LP #335596).
[13:09] <cjwatson> I have a suspicion that if we topologically-sort packages to be removed, it might go faster
[13:09] <cjwatson> the path where we have to identify broken packages and remove them too is slower
[13:23] <evand> out of curiosity, what method are you using to profile this?
[13:25] <cjwatson> evand: time(1) ;-)
[13:26] <evand> heh
[13:26] <cjwatson> I did try python-profiler but it threw a fit at something in python-apt
[13:26] <cjwatson> so I've been sprinkling prints around to get a feel for what's taking time
[13:26] <cjwatson> old-fashioned approach ...
[13:30] <evand> indeed
[13:31] <cjwatson> beginning to run out of ideas for making it very much faster though
[13:47] <CIA-3> ubiquity: evand * r3099 ubiquity/ (debian/changelog scripts/install.py):
[13:47] <CIA-3> ubiquity: Fix a bit of code that wasn't updated to reflect other changes in
[13:47] <CIA-3> ubiquity: remove_extras.
[13:48] <evand> I *think* that's right.
[13:50] <cjwatson> evand: yes, looks right, sorry about that
[13:50] <cjwatson> I got a bit confused because blacklisting and removal handle that differently
[13:53] <cjwatson> I can't seem to get the topological sort approach to work, but on reflection I think it is going to be of reduced benefit anyway because there are so many dependency cycles in language packs
[13:53] <evand> no worries
[13:53] <evand> mm, ouch
[13:53] <cjwatson> i.e. you end up going down the broken-packages slow path for all the language-pack-foo/language-pack-foo-base pairs anyway
[13:54] <cjwatson> I wonder if it would be worth special-casing those ...
[13:54] <cjwatson> looks pretty fiddly though
[13:54] <cjwatson> get_remove_list only ever tries one at a time at the moment
[13:56] <evand> hrm, still might be worth special casing if we run out of options.
[13:56] <cjwatson> I think I'll wait and see whether the stuff I've done so far is enough
[14:07] <CIA-3> debian-installer: cjwatson * r1062 ubuntu/ (build/config/armel/orion5x/netboot.cfg debian/changelog):
[14:07] <CIA-3> debian-installer: Disable armel/orion5x/netboot/mv2120 flavour for now, since the kernel
[14:07] <CIA-3> debian-installer: is slightly too big.
[14:10] <CIA-3> debian-installer: cjwatson * r1063 ubuntu/debian/changelog: releasing version 20081029ubuntu25
[16:36] <CIA-3> oem-config: evand * r630 oem-config/ (debian/changelog lib/frontend/gtk_ui.py):
[16:36] <CIA-3> oem-config: Fix 'resize if too big for screen' logic (LP: #341758). Thanks Michael
[16:36] <CIA-3> oem-config: Terry!
[18:07] <CIA-3> wubi: evand * r94 trunk/ (debian/changelog src/wubi/backends/win32/backend.py): (log message trimmed)
[18:07] <CIA-3> wubi: * os.environ is a dictionary, not a callable method.
[18:07] <CIA-3> wubi: * Only uncompress files in the boot directory.
[18:07] <CIA-3> wubi: * Call the correct bootloader installation method for each version of
[18:07] <CIA-3> wubi:  Windows.
[18:07] <CIA-3> wubi: * Use registry.{get,set}_value not the nonexistent
[18:07] <CIA-3> wubi:  registry.{get,set}_key.
[18:08] <evand> So much easier to hack on.
[18:42] <CIA-3> ubiquity: cjwatson * r3100 ubiquity/ (3 files in 3 dirs):
[18:42] <CIA-3> ubiquity: * GTK frontend:
[18:42] <CIA-3> ubiquity:  - Restore set_window_hints method for use by windows other than the main
[18:42] <CIA-3> ubiquity:  one (it was still called in the Glade file), just in case we're using
[18:42] <CIA-3> ubiquity:  a window manager that pays attention to this. In these cases
[18:42] <CIA-3> ubiquity:  maximisation doesn't really make sense so we no longer permit that.
[18:47] <CIA-3> ubiquity: cjwatson * r3101 ubiquity/debian/changelog: Evan's r3099 fixes LP: #342319
[18:50] <CIA-3> oem-config: cjwatson * r631 trunk/ (3 files in 3 dirs):
[18:50] <CIA-3> oem-config: * GTK frontend:
[18:50] <CIA-3> oem-config:  - Full-screen the window when --only is used - i.e. more or less always,
[18:50] <CIA-3> oem-config:  except for testing. The extra screen real estate makes the timezone
[18:50] <CIA-3> oem-config:  map, among other widgets, easier to use. (Ported from Evan Dandrea's
[18:50] <CIA-3> oem-config:  similar change to Ubiquity; the KDE frontend needed no change as in
[18:50] <cjwatson> evand: ^- does oem-config r631 look OK to you?
[18:50] <CIA-3> oem-config:  oem-config it's always full-screen.)
[18:54] <CIA-3> oem-config: cjwatson * r632 trunk/ (debian/changelog gui/glade/oem-config.glade):
[18:54] <CIA-3> oem-config: Use stock preferences-system icon (thanks, Michael Terry;
[18:54] <CIA-3> oem-config: LP: #341770).
[18:58]  * evand checks
[19:00] <evand> yup, looks good to me
[19:16] <CIA-3> wubi: evand * r95 trunk/ (debian/changelog src/wubi/backends/win32/backend.py):
[19:16] <CIA-3> wubi: * Only uncompress files in the boot directory (LP: #341640). Thanks Agostino
[19:16] <CIA-3> wubi:  Russo!
[19:16] <CIA-3> wubi: * subprocess.Popen takes a list of string arguments.
[19:16] <evand> closer.  I've at least got a bootloader entry now.