[00:53] evand: thanks for the heads up...I will take a look...ran it several times without issue...:/ [06:42] cjwatson, where can I find pitti? [06:43] Scix, usually in #ubuntu-devel I see him, but i'd check /whois [06:43] superm1, tanks :) I'll try that === mpt_ is now known as mpt [11:40] evand: Did you see mterry's oem-config bug? [11:40] #? [11:41] evand: Digging it up [11:42] evand: #341758 [11:45] ah, very cool. I'll review and merge it in a little bit (just need to get through some other things that have been piled on this morning) [11:45] StevenK: thanks for pointing me at that [11:45] evand: No worries. [13:03] ubiquity: cjwatson * r3098 ubiquity/ (debian/changelog scripts/install.py): [13:03] ubiquity: broken_packages is fairly slow due to having to iterate over the whole [13:03] ubiquity: cache. Speed it up a bit by stopping when the number of broken packages [13:03] ubiquity: found reaches cache._depcache.BrokenCount; this improves blacklist [13:03] ubiquity: calculation time for the previously-mentioned DVD English-only install [13:03] ubiquity: from 3:30 to 2:30 (see LP #335596). [13:03] Launchpad bug 335596 in ubiquity "DVD install takes forever compared to the CD install during the step that it's calculating packages to remove, causing pain for OEM" [High,Triaged] https://launchpad.net/bugs/335596 [13:09] I have a suspicion that if we topologically-sort packages to be removed, it might go faster [13:09] the path where we have to identify broken packages and remove them too is slower [13:23] out of curiosity, what method are you using to profile this? [13:25] evand: time(1) ;-) [13:26] heh [13:26] I did try python-profiler but it threw a fit at something in python-apt [13:26] so I've been sprinkling prints around to get a feel for what's taking time [13:26] old-fashioned approach ... [13:30] indeed [13:31] beginning to run out of ideas for making it very much faster though [13:47] ubiquity: evand * r3099 ubiquity/ (debian/changelog scripts/install.py): [13:47] ubiquity: Fix a bit of code that wasn't updated to reflect other changes in [13:47] ubiquity: remove_extras. [13:48] I *think* that's right. [13:50] evand: yes, looks right, sorry about that [13:50] I got a bit confused because blacklisting and removal handle that differently [13:53] I can't seem to get the topological sort approach to work, but on reflection I think it is going to be of reduced benefit anyway because there are so many dependency cycles in language packs [13:53] no worries [13:53] mm, ouch [13:53] i.e. you end up going down the broken-packages slow path for all the language-pack-foo/language-pack-foo-base pairs anyway [13:54] I wonder if it would be worth special-casing those ... [13:54] looks pretty fiddly though [13:54] get_remove_list only ever tries one at a time at the moment [13:56] hrm, still might be worth special casing if we run out of options. [13:56] I think I'll wait and see whether the stuff I've done so far is enough [14:07] debian-installer: cjwatson * r1062 ubuntu/ (build/config/armel/orion5x/netboot.cfg debian/changelog): [14:07] debian-installer: Disable armel/orion5x/netboot/mv2120 flavour for now, since the kernel [14:07] debian-installer: is slightly too big. [14:10] debian-installer: cjwatson * r1063 ubuntu/debian/changelog: releasing version 20081029ubuntu25 [16:36] oem-config: evand * r630 oem-config/ (debian/changelog lib/frontend/gtk_ui.py): [16:36] oem-config: Fix 'resize if too big for screen' logic (LP: #341758). Thanks Michael [16:36] oem-config: Terry! === robbiew1 is now known as robbiew [18:07] wubi: evand * r94 trunk/ (debian/changelog src/wubi/backends/win32/backend.py): (log message trimmed) [18:07] wubi: * os.environ is a dictionary, not a callable method. [18:07] wubi: * Only uncompress files in the boot directory. [18:07] wubi: * Call the correct bootloader installation method for each version of [18:07] wubi: Windows. [18:07] wubi: * Use registry.{get,set}_value not the nonexistent [18:07] wubi: registry.{get,set}_key. [18:08] So much easier to hack on. [18:42] ubiquity: cjwatson * r3100 ubiquity/ (3 files in 3 dirs): [18:42] ubiquity: * GTK frontend: [18:42] ubiquity: - Restore set_window_hints method for use by windows other than the main [18:42] ubiquity: one (it was still called in the Glade file), just in case we're using [18:42] ubiquity: a window manager that pays attention to this. In these cases [18:42] ubiquity: maximisation doesn't really make sense so we no longer permit that. [18:47] ubiquity: cjwatson * r3101 ubiquity/debian/changelog: Evan's r3099 fixes LP: #342319 [18:50] oem-config: cjwatson * r631 trunk/ (3 files in 3 dirs): [18:50] oem-config: * GTK frontend: [18:50] oem-config: - Full-screen the window when --only is used - i.e. more or less always, [18:50] oem-config: except for testing. The extra screen real estate makes the timezone [18:50] oem-config: map, among other widgets, easier to use. (Ported from Evan Dandrea's [18:50] oem-config: similar change to Ubiquity; the KDE frontend needed no change as in [18:50] evand: ^- does oem-config r631 look OK to you? [18:50] oem-config: oem-config it's always full-screen.) [18:54] oem-config: cjwatson * r632 trunk/ (debian/changelog gui/glade/oem-config.glade): [18:54] oem-config: Use stock preferences-system icon (thanks, Michael Terry; [18:54] oem-config: LP: #341770). [18:58] * evand checks [19:00] yup, looks good to me [19:16] wubi: evand * r95 trunk/ (debian/changelog src/wubi/backends/win32/backend.py): [19:16] wubi: * Only uncompress files in the boot directory (LP: #341640). Thanks Agostino [19:16] wubi: Russo! [19:16] wubi: * subprocess.Popen takes a list of string arguments. [19:16] closer. I've at least got a bootloader entry now.